Re: [PATCH] media: v4l2-compat-ioctl32: don't oops on overlay

2018-03-29 Thread Laurent Pinchart
Hello, On Wednesday, 28 March 2018 23:16:08 EEST Sakari Ailus wrote: > On Wed, Mar 28, 2018 at 02:59:22PM -0300, Mauro Carvalho Chehab wrote: > > At put_v4l2_window32(), it tries to access kp->clips. However, > > kp points to an userspace pointer. So, it should be obtained > > > > via

Re: [PATCH 07/15] v4l: vsp1: Move DRM atomic commit pipeline setup to separate function

2018-03-29 Thread Laurent Pinchart
Hi Kieran, On Wednesday, 28 March 2018 17:43:13 EEST Kieran Bingham wrote: > On 26/02/18 21:45, Laurent Pinchart wrote: > > The DRM pipeline setup code used at atomic commit time is similar to the > > setup code used when enabling the pipeline. Move it to a separate > > function in order to share

Re: [v2,2/2] media: Add a driver for the ov7251 camera sensor

2018-03-29 Thread Todor Tomov
Hi Jacopo, Thank you for your prompt review. On 23.03.2018 15:40, jacopo mondi wrote: > Hi Todor, >thanks for the patch. > > When running checkpatch --strict I see a few warning you can easily > close (braces indentation mostly, and one additional empty line at > line 1048). Thank you for

Re: [PATCH 02/15] v4l: vsp1: Remove outdated comment

2018-03-29 Thread Laurent Pinchart
Hi Kieran, On Wednesday, 28 March 2018 22:04:49 EEST Kieran Bingham wrote: > On 28/03/18 13:27, Kieran Bingham wrote: > > On 26/02/18 21:45, Laurent Pinchart wrote: > >> The entities in the pipeline are all started when the LIF is setup. > >> Remove the outdated comment that state otherwise. > >>

Re: [PATCH 4/8] dma-buf: add peer2peer flag

2018-03-29 Thread Daniel Vetter
On Sun, Mar 25, 2018 at 12:59:56PM +0200, Christian König wrote: > Add a peer2peer flag noting that the importer can deal with device > resources which are not backed by pages. > > Signed-off-by: Christian König Um strictly speaking they all should, but ttm never

Re: [PATCH for v3.18 00/18] Backport CVE-2017-13166 fixes to Kernel 3.18

2018-03-29 Thread Inki Dae
2018년 03월 29일 13:25에 Greg KH 이(가) 쓴 글: > On Thu, Mar 29, 2018 at 08:22:08AM +0900, Inki Dae wrote: >> Really thanks for doing this. :) There would be many users who use >> Linux-3.18 for their products yet. > > For new products? They really should not be. The kernel is officially Really no.

Re: [PATCH 05/15] v4l: vsp1: Use vsp1_entity.pipe to check if entity belongs to a pipeline

2018-03-29 Thread Laurent Pinchart
Hi Kieran, On Wednesday, 28 March 2018 17:10:10 EEST Kieran Bingham wrote: > On 26/02/18 21:45, Laurent Pinchart wrote: > > The DRM pipeline handling code uses the entity's pipe list head to check > > whether the entity is already included in a pipeline. This method is a > > bit fragile in the

Re: [PATCH] media: v4l2-compat-ioctl32: don't oops on overlay

2018-03-29 Thread Laurent Pinchart
Hi Sakari, On Thursday, 29 March 2018 10:35:49 EEST Sakari Ailus wrote: > On Thu, Mar 29, 2018 at 09:19:43AM +0300, Laurent Pinchart wrote: > > On Wednesday, 28 March 2018 23:16:08 EEST Sakari Ailus wrote: > > > On Wed, Mar 28, 2018 at 02:59:22PM -0300, Mauro Carvalho Chehab wrote: > > > > At

Re: [PATCH for v3.18 00/18] Backport CVE-2017-13166 fixes to Kernel 3.18

2018-03-29 Thread Greg KH
On Thu, Mar 29, 2018 at 03:39:54PM +0900, Inki Dae wrote: > 2018년 03월 29일 13:25에 Greg KH 이(가) 쓴 글: > > On Thu, Mar 29, 2018 at 08:22:08AM +0900, Inki Dae wrote: > >> Really thanks for doing this. :) There would be many users who use > >> Linux-3.18 for their products yet. > > > > For new

Re: [PATCH] media: v4l2-compat-ioctl32: don't oops on overlay

2018-03-29 Thread Sakari Ailus
On Thu, Mar 29, 2018 at 09:19:43AM +0300, Laurent Pinchart wrote: > Hello, > > On Wednesday, 28 March 2018 23:16:08 EEST Sakari Ailus wrote: > > On Wed, Mar 28, 2018 at 02:59:22PM -0300, Mauro Carvalho Chehab wrote: > > > At put_v4l2_window32(), it tries to access kp->clips. However, > > > kp

Re: [PATCH 2/8] PCI: Add pci_find_common_upstream_dev()

2018-03-29 Thread Logan Gunthorpe
On 29/03/18 10:10 AM, Christian König wrote: > Why not? I mean the dma_map_resource() function is for P2P while other > dma_map_* functions are only for system memory. Oh, hmm, I wasn't aware dma_map_resource was exclusively for mapping P2P. Though it's a bit odd seeing we've been working

Re: [linux-sunxi] [PATCH v9 0/2] Initial Allwinner V3s CSI Support

2018-03-29 Thread Martin Kelly
On 03/28/2018 06:02 PM, Yong wrote: AFAIK, there is no document about MIPI CSI-2. You can take a look at the source code in BSP: https://github.com/friendlyarm/h3_lichee/tree/master/linux-3.4/drivers/media/video/sunxi-vfe/mipi_csi And try to port it to mainline. Yep, I see there's lots of

Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

2018-03-29 Thread Nasser
On Thu, Mar 29, 2018 at 12:02:40PM -0300, Mauro Carvalho Chehab wrote: > Em Thu, 29 Mar 2018 19:04:35 +0430 > Nasser escreveu: > > > On Tue, Mar 27, 2018 at 02:59:21AM +0430, Nasser wrote: > > Hi Mauro, > > > > Thank you for taking time to review my patch. > > > > May

Re: [PATCH 2/8] PCI: Add pci_find_common_upstream_dev()

2018-03-29 Thread Christian König
Am 29.03.2018 um 18:25 schrieb Logan Gunthorpe: On 29/03/18 10:10 AM, Christian König wrote: Why not? I mean the dma_map_resource() function is for P2P while other dma_map_* functions are only for system memory. Oh, hmm, I wasn't aware dma_map_resource was exclusively for mapping P2P. Though

Re: [PATCH 2/8] PCI: Add pci_find_common_upstream_dev()

2018-03-29 Thread Christian König
Am 29.03.2018 um 17:45 schrieb Logan Gunthorpe: On 29/03/18 05:44 AM, Christian König wrote: Am 28.03.2018 um 21:53 schrieb Logan Gunthorpe: On 28/03/18 01:44 PM, Christian König wrote: Well, isn't that exactly what dma_map_resource() is good for? As far as I can see it makes sure IOMMU is

Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

2018-03-29 Thread Mauro Carvalho Chehab
Em Thu, 29 Mar 2018 22:37:57 +0430 Nasser escreveu: > On Thu, Mar 29, 2018 at 12:02:40PM -0300, Mauro Carvalho Chehab wrote: > > Em Thu, 29 Mar 2018 19:04:35 +0430 > > Nasser escreveu: > > > > > On Tue, Mar 27, 2018 at 02:59:21AM +0430,

Re: [v2,2/2] media: Add a driver for the ov7251 camera sensor

2018-03-29 Thread Sakari Ailus
Hi Todor and Jacopo, On Thu, Mar 29, 2018 at 10:50:10AM +0300, Todor Tomov wrote: ... > >> +static const struct of_device_id ov7251_of_match[] = { > >> + { .compatible = "ovti,ov7251" }, > >> + { /* sentinel */ } > >> +}; > >> +MODULE_DEVICE_TABLE(of, ov7251_of_match); > >> + > >> +static

Re: [PATCH] media: v4l2-compat-ioctl32: don't oops on overlay

2018-03-29 Thread Hans Verkuil
Hi Mauro, On 28/03/18 19:59, Mauro Carvalho Chehab wrote: > At put_v4l2_window32(), it tries to access kp->clips. However, > kp points to an userspace pointer. So, it should be obtained > via get_user(), otherwise it can OOPS: > > > cc: sta...@vger.kernel.org > Signed-off-by: Mauro Carvalho

Re: [RFCv9 PATCH 05/29] media-request: add request ioctls

2018-03-29 Thread Sakari Ailus
Hi Hans, I think it'd be easier to review the code if it was a part of the previous patch. It's so closely related to what's being done there. On Wed, Mar 28, 2018 at 03:50:06PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > Implement the MEDIA_REQUEST_IOC_QUEUE

Re: [PATCH for v3.18 00/18] Backport CVE-2017-13166 fixes to Kernel 3.18

2018-03-29 Thread Inki Dae
2018년 03월 29일 16:00에 Greg KH 이(가) 쓴 글: > On Thu, Mar 29, 2018 at 03:39:54PM +0900, Inki Dae wrote: >> 2018년 03월 29일 13:25에 Greg KH 이(가) 쓴 글: >>> On Thu, Mar 29, 2018 at 08:22:08AM +0900, Inki Dae wrote: Really thanks for doing this. :) There would be many users who use Linux-3.18 for

Re: [RFCv9 PATCH 03/29] media-request: allocate media requests

2018-03-29 Thread Sakari Ailus
Hi Hans, On Wed, Mar 28, 2018 at 03:50:04PM +0200, Hans Verkuil wrote: ... > @@ -88,6 +96,8 @@ struct media_device_ops { > * @disable_source: Disable Source Handler function pointer > * > * @ops: Operation handler callbacks > + * @req_lock:Serialise access to requests > + *

Re: [RFCv9 PATCH 03/29] media-request: allocate media requests

2018-03-29 Thread Sakari Ailus
Hi Hans, On Thu, Mar 29, 2018 at 11:16:45AM +0200, Hans Verkuil wrote: > On 29/03/18 11:01, Sakari Ailus wrote: > > On Thu, Mar 29, 2018 at 10:57:44AM +0200, Hans Verkuil wrote: > >> On 29/03/18 10:45, Sakari Ailus wrote: > >>> Hi Hans, > >>> > >>> On Wed, Mar 28, 2018 at 03:50:04PM +0200, Hans

Re: [RFCv9 PATCH 02/29] uapi/linux/media.h: add request API

2018-03-29 Thread Sakari Ailus
On Wed, Mar 28, 2018 at 03:50:03PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > Define the public request API. > > This adds the new MEDIA_IOC_REQUEST_ALLOC ioctl to allocate a request > and two ioctls that operate on a request in order to queue the > contents of

Re: [PATCH v2 1/2] dt-bindings: media: Binding document for OV7251 camera sensor

2018-03-29 Thread Sakari Ailus
On Fri, Mar 23, 2018 at 12:14:19PM +0800, Todor Tomov wrote: > Add the document for ov7251 device tree binding. > > CC: Rob Herring > CC: Mark Rutland > CC: devicet...@vger.kernel.org > Signed-off-by: Todor Tomov > Reviewed-by: Rob

Re: [RFCv9 PATCH 01/29] v4l2-device.h: always expose mdev

2018-03-29 Thread Sakari Ailus
On Wed, Mar 28, 2018 at 03:50:02PM +0200, Hans Verkuil wrote: > From: Hans Verkuil > > The mdev field is only present if CONFIG_MEDIA_CONTROLLER is set. > But since we will need to pass the media_device to vb2 snd the > control framework it is very convenient to just make

Re: [RFCv9 PATCH 03/29] media-request: allocate media requests

2018-03-29 Thread Hans Verkuil
On 29/03/18 10:45, Sakari Ailus wrote: > Hi Hans, > > On Wed, Mar 28, 2018 at 03:50:04PM +0200, Hans Verkuil wrote: > ... >> @@ -88,6 +96,8 @@ struct media_device_ops { >> * @disable_source: Disable Source Handler function pointer >> * >> * @ops:Operation handler callbacks >> + *

Re: [RFCv9 PATCH 03/29] media-request: allocate media requests

2018-03-29 Thread Sakari Ailus
On Thu, Mar 29, 2018 at 10:57:44AM +0200, Hans Verkuil wrote: > On 29/03/18 10:45, Sakari Ailus wrote: > > Hi Hans, > > > > On Wed, Mar 28, 2018 at 03:50:04PM +0200, Hans Verkuil wrote: > > ... > >> @@ -88,6 +96,8 @@ struct media_device_ops { > >> * @disable_source: Disable Source Handler

Re: [RFCv9 PATCH 03/29] media-request: allocate media requests

2018-03-29 Thread Hans Verkuil
On 29/03/18 11:01, Sakari Ailus wrote: > On Thu, Mar 29, 2018 at 10:57:44AM +0200, Hans Verkuil wrote: >> On 29/03/18 10:45, Sakari Ailus wrote: >>> Hi Hans, >>> >>> On Wed, Mar 28, 2018 at 03:50:04PM +0200, Hans Verkuil wrote: >>> ... @@ -88,6 +96,8 @@ struct media_device_ops { *

Re: [v2,2/2] media: Add a driver for the ov7251 camera sensor

2018-03-29 Thread Todor Tomov
Hi Sakari On 29.03.2018 11:29, Sakari Ailus wrote: > Hi Todor and Jacopo, > > On Thu, Mar 29, 2018 at 10:50:10AM +0300, Todor Tomov wrote: > ... +static const struct of_device_id ov7251_of_match[] = { + { .compatible = "ovti,ov7251" }, + { /* sentinel */ } +};

Re: [v2,2/2] media: Add a driver for the ov7251 camera sensor

2018-03-29 Thread Sakari Ailus
Hi Todor, On Thu, Mar 29, 2018 at 01:09:18PM +0300, Todor Tomov wrote: > > There's another change needed, too, which is not using of_match_ptr > > macro, but instead assigning the of_match_table unconditionally. > > In that case the MODULE_DEVICE_TABLE(i2c, ...) is again not needed? > And

Re: [PATCH v2 2/2] media: Add a driver for the ov7251 camera sensor

2018-03-29 Thread Sakari Ailus
Hi Todor, Thanks for the patch. A few quick comments below... On Fri, Mar 23, 2018 at 12:14:20PM +0800, Todor Tomov wrote: > The ov7251 sensor is a 1/7.5-Inch B VGA (640x480) CMOS Digital Image > Sensor from Omnivision. > > The driver supports the following modes: > - 640x480 30fps > - 640x480

Re: [v2,2/2] media: Add a driver for the ov7251 camera sensor

2018-03-29 Thread jacopo mondi
Hi Todor, On Thu, Mar 29, 2018 at 10:50:10AM +0300, Todor Tomov wrote: > Hi Jacopo, > > > > > > With the above nits clarified, and as you addressed my v1 comments: > > > > Reviewed-by: Jacopo Mondi > > Would you like to see the corrections or I can add the tag before sending

Re: [PATCH 2/8] PCI: Add pci_find_common_upstream_dev()

2018-03-29 Thread Christian König
Am 28.03.2018 um 21:53 schrieb Logan Gunthorpe: On 28/03/18 01:44 PM, Christian König wrote: Well, isn't that exactly what dma_map_resource() is good for? As far as I can see it makes sure IOMMU is aware of the access route and translates a CPU address into a PCI Bus address. I'm using that

Re: [PATCH 10/15] v4l: vsp1: Move DRM pipeline output setup code to a function

2018-03-29 Thread Kieran Bingham
Hi Laurent, Thank you for another patch :D On 26/02/18 21:45, Laurent Pinchart wrote: > In order to make the vsp1_du_setup_lif() easier to read, and for > symmetry with the DRM pipeline input setup, move the pipeline output > setup code to a separate function. > > Signed-off-by: Laurent

Re: [PATCH v7 2/2] v4l: cadence: Add Cadence MIPI-CSI2 TX driver

2018-03-29 Thread Niklas Söderlund
Hi Maxime, Thanks for your patch. On 2018-03-26 15:34:56 +0200, Maxime Ripard wrote: > The Cadence MIPI-CSI2 TX controller is an hardware block meant to be used > as a bridge between pixel interfaces and a CSI-2 bus. > > It supports operating with an internal or external D-PHY, with up to 4 >

Re: [RFCv9 PATCH 03/29] media-request: allocate media requests

2018-03-29 Thread Hans Verkuil
On 29/03/18 11:52, Sakari Ailus wrote: > Hi Hans, > > On Thu, Mar 29, 2018 at 11:16:45AM +0200, Hans Verkuil wrote: >> On 29/03/18 11:01, Sakari Ailus wrote: >>> On Thu, Mar 29, 2018 at 10:57:44AM +0200, Hans Verkuil wrote: On 29/03/18 10:45, Sakari Ailus wrote: > Hi Hans, > > On

Re: [PATCH 4/8] dma-buf: add peer2peer flag

2018-03-29 Thread Christian König
Am 29.03.2018 um 08:57 schrieb Daniel Vetter: On Sun, Mar 25, 2018 at 12:59:56PM +0200, Christian König wrote: Add a peer2peer flag noting that the importer can deal with device resources which are not backed by pages. Signed-off-by: Christian König Um strictly

Re: [PATCH 12/15] v4l: vsp1: Generalize detection of entity removal from DRM pipeline

2018-03-29 Thread Kieran Bingham
Hi Laurent, Thank you for the patch, On 26/02/18 21:45, Laurent Pinchart wrote: > When disabling a DRM plane, the corresponding RPF is only marked as > removed from the pipeline in the atomic update handler, with the actual > removal happening when configuring the pipeline at atomic commit time.

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

2018-03-29 Thread Maxime Ripard
Hi Niklas, On Tue, Feb 13, 2018 at 12:01:32AM +0100, Niklas Söderlund wrote: > + switch (priv->lanes) { > + case 1: > + phycnt = PHYCNT_ENABLECLK | PHYCNT_ENABLE_0; > + break; > + case 2: > + phycnt = PHYCNT_ENABLECLK | PHYCNT_ENABLE_1 |

Re: [PATCH 2/8] PCI: Add pci_find_common_upstream_dev()

2018-03-29 Thread Jerome Glisse
On Thu, Mar 29, 2018 at 10:25:52AM -0600, Logan Gunthorpe wrote: > > > On 29/03/18 10:10 AM, Christian König wrote: > > Why not? I mean the dma_map_resource() function is for P2P while other > > dma_map_* functions are only for system memory. > > Oh, hmm, I wasn't aware dma_map_resource was

RE: [PATCH v3 7/9] v4l: xilinx: dma: Add multi-planar support

2018-03-29 Thread Satish Kumar Nagireddy
Hi Hyun, Thanks a lot for the comments. I will fix them in v4 patch-set. Regards, Satish > -Original Message- > From: Hyun Kwon [mailto:hyun.k...@xilinx.com] > Sent: Friday, February 16, 2018 9:05 AM > To: Satish Kumar Nagireddy > Cc: linux-media@vger.kernel.org;

[lwn:docs-next 73/74] htmldocs: include/net/mac80211.h:950: warning: Function parameter or member 'control.rates' not described in 'ieee80211_tx_info'

2018-03-29 Thread kbuild test robot
tree: git://git.lwn.net/linux-2.6 docs-next head: 86afad7d87f535ebb1a0e978bc32a8c58ac99268 commit: d404d57955a6f67365423f9d0b89ad1881799087 [73/74] docs: kernel-doc: fix parsing of arrays reproduce: make htmldocs All warnings (new ones prefixed by >>): WARNING: convert(1) not found, for

[PATCH v6 00/12] Intel IPU3 ImgU patchset

2018-03-29 Thread Yong Zhi
Hi, This series adds support for the Intel IPU3 (Image Processing Unit) ImgU which is essentially a modern memory-to-memory ISP. It implements raw Bayer to YUV image format conversion as well as a large number of other pixel processing algorithms for improving the image quality. Meta data

[PATCH v6 06/12] intel-ipu3: css: Add support for firmware management

2018-03-29 Thread Yong Zhi
Introduce functions to load and install ImgU FW blobs. Signed-off-by: Yong Zhi --- drivers/media/pci/intel/ipu3/ipu3-abi.h| 1888 drivers/media/pci/intel/ipu3/ipu3-css-fw.c | 261 drivers/media/pci/intel/ipu3/ipu3-css-fw.h | 198 +++ 3

[PATCH v6 10/12] intel-ipu3: Add css pipeline programming

2018-03-29 Thread Yong Zhi
This provides helper library to be used by v4l2 level to program imaging pipelines and control the streaming. Signed-off-by: Yong Zhi --- drivers/media/pci/intel/ipu3/ipu3-css.c | 1752 +++ 1 file changed, 1752 insertions(+) diff --git

[PATCH v6 05/12] intel-ipu3: css: Add dma buff pool utility functions

2018-03-29 Thread Yong Zhi
The pools are used to store previous parameters set by user with the parameter queue. Due to pipelining, there needs to be multiple sets (up to four) of parameters which are queued in a host-to-sp queue. Signed-off-by: Yong Zhi ---

[PATCH v6 02/12] intel-ipu3: Add user space API definitions

2018-03-29 Thread Yong Zhi
Define the structures and macros to be used by public. Signed-off-by: Yong Zhi Signed-off-by: Rajmohan Mani --- include/uapi/linux/intel-ipu3.h | 1403 +++ 1 file changed, 1403 insertions(+) create mode 100644

[PATCH v6 04/12] intel-ipu3: Implement DMA mapping functions

2018-03-29 Thread Yong Zhi
From: Tomasz Figa This driver uses IOVA space for buffer mapping through IPU3 MMU to transfer data between imaging pipelines and system DDR. Signed-off-by: Tomasz Figa Signed-off-by: Yong Zhi ---

[PATCH 08/12] intel-ipu3: css: Compute and program ccs

2018-03-29 Thread Yong Zhi
A collection of routines that are mainly used to calculate the parameters for accelerator cluster. Signed-off-by: Yong Zhi --- drivers/media/pci/intel/ipu3/ipu3-css-params.c | 2890 drivers/media/pci/intel/ipu3/ipu3-css-params.h | 25 +

[PATCH v6 01/12] v4l: Add Intel IPU3 meta buffer formats

2018-03-29 Thread Yong Zhi
Add IPU3-specific meta formats for parameter processing and 3A statistics: V4L2_META_FMT_IPU3_PARAMS V4L2_META_FMT_IPU3_STAT_3A Signed-off-by: Yong Zhi --- drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++ include/uapi/linux/videodev2.h | 4 2 files changed, 6

[PATCH v6 03/12] intel-ipu3: mmu: Implement driver

2018-03-29 Thread Yong Zhi
From: Tomasz Figa This driver translates IO virtual address to physical address based on two levels page tables. Signed-off-by: Tomasz Figa Signed-off-by: Yong Zhi --- drivers/media/pci/intel/ipu3/ipu3-mmu.c | 560

[PATCH v6 11/12] intel-ipu3: Add v4l2 driver based on media framework

2018-03-29 Thread Yong Zhi
Implement video driver that utilizes v4l2, vb2 queue support and media controller APIs. The driver exposes single subdevice and six nodes. Signed-off-by: Yong Zhi Signed-off-by: Ramya Vijaykumar --- drivers/media/pci/intel/ipu3/ipu3-v4l2.c | 1089

[PATCH v6 09/12] intel-ipu3: css: Initialize css hardware

2018-03-29 Thread Yong Zhi
This patch implements the functions to initialize and configure IPU3 h/w such as clock, irq and power. Signed-off-by: Yong Zhi Signed-off-by: Tomasz Figa --- drivers/media/pci/intel/ipu3/ipu3-css.c | 537 1 file changed,

[PATCH v6 12/12] intel-ipu3: Add imgu top level pci device driver

2018-03-29 Thread Yong Zhi
This patch adds support for the Intel IPU v3 as found on Skylake and Kaby Lake SoCs. The driver glues v4l2, css(camera sub system) and other pieces together to perform its functions, it also loads the IPU3 firmware binary as part of its initialization. Signed-off-by: Yong Zhi

DVB-T2 support for TVR801 USB stick (Astrometa DVB-T2)

2018-03-29 Thread TPClmml
Could anyone clarify what is supported on this stick for me? According to https://www.linuxtv.org/wiki/index.php/Astrometa_DVB-T2 DVB-T2 has been supported since kernel 4.6. I tried using a 4.9.9 kernel about a year ago and again today using 4.14.30, in both cases with the development tree

cron job: media_tree daily build: WARNINGS

2018-03-29 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Mar 30 05:00:10 CEST 2018 media-tree git hash:6ccd228e0cfce2a4f44558422d25c60fcb1a6710 media_build

Re: [PATCH] media: v4l2-compat-ioctl32: don't oops on overlay

2018-03-29 Thread Mauro Carvalho Chehab
Em Thu, 29 Mar 2018 10:40:23 +0200 Hans Verkuil escreveu: > Hi Mauro, > > On 28/03/18 19:59, Mauro Carvalho Chehab wrote: > > At put_v4l2_window32(), it tries to access kp->clips. However, > > kp points to an userspace pointer. So, it should be obtained > > via get_user(),

Re: [PATCH] media: v4l2-compat-ioctl32: don't oops on overlay

2018-03-29 Thread Hans Verkuil
On 29/03/18 15:00, Mauro Carvalho Chehab wrote: > Em Thu, 29 Mar 2018 10:40:23 +0200 > Hans Verkuil escreveu: > >> Hi Mauro, >> >> On 28/03/18 19:59, Mauro Carvalho Chehab wrote: >>> At put_v4l2_window32(), it tries to access kp->clips. However, >>> kp points to an userspace

Re: [PATCH v8 1/2] dt-bindings: media: Add Cadence MIPI-CSI2 RX Device Tree bindings

2018-03-29 Thread Niklas Söderlund
Hi Maxime, Thanks for your patch. On 2018-02-15 14:33:34 +0100, Maxime Ripard wrote: > The Cadence MIPI-CSI2 RX controller is a CSI2RX bridge that supports up to > 4 CSI-2 lanes, and can route the frames to up to 4 streams, depending on > the hardware implementation. > > It can operate with an

Wrong use of GFP_DMA32 in drivers/media/platform/vivid/vivid-osd.c

2018-03-29 Thread Hans de Goede
Hi Hans, et. al., While debugging another GFP_DMA32 problem I did a quick grep for GFP_DMA32 on the kernel, this result stood out: drivers/media/platform/vivid/vivid-osd.c 373:dev->video_vbase = kzalloc(dev->video_buffer_size, GFP_KERNEL | GFP_DMA32); Because it is making the same mistake

Re: [PATCH v8 2/2] v4l: cadence: Add Cadence MIPI-CSI2 RX driver

2018-03-29 Thread Niklas Söderlund
Hi Maxime, Thanks for your patch. On 2018-02-15 14:33:35 +0100, Maxime Ripard wrote: > The Cadence CSI-2 RX Controller is an hardware block meant to be used as a > bridge between a CSI-2 bus and pixel grabbers. > > It supports operating with internal or external D-PHY, with up to 4 lanes, > or

Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

2018-03-29 Thread Mauro Carvalho Chehab
Em Thu, 29 Mar 2018 19:04:35 +0430 Nasser escreveu: > On Tue, Mar 27, 2018 at 02:59:21AM +0430, Nasser wrote: > Hi Mauro, > > Thank you for taking time to review my patch. > > May be I should rephrase the commit message to something like: > Use the default

Re: [PATCH for v3.18 00/18] Backport CVE-2017-13166 fixes to Kernel 3.18

2018-03-29 Thread Mauro Carvalho Chehab
Em Thu, 29 Mar 2018 08:22:08 +0900 Inki Dae escreveu: > Hi Mauro, > > 2018년 03월 29일 03:12에 Mauro Carvalho Chehab 이(가) 쓴 글: > > Hi Greg, > > > > Those are the backports meant to solve CVE-2017-13166 on Kernel 3.18. > > > > It contains two v4l2-ctrls fixes that are

Re: [PATCH] media: i2c: tvp5150: fix color burst lock instability on some hardware

2018-03-29 Thread Nasser
On Tue, Mar 27, 2018 at 02:59:21AM +0430, Nasser wrote: Hi Mauro, Thank you for taking time to review my patch. May be I should rephrase the commit message to something like: Use the default register values as suggested in TVP5150AM1 datasheet As this is not a hardware-dependent issue.

[no subject]

2018-03-29 Thread Rainer Keller
unsubscribe linux-media

[RESEND PATCH] Add pixel clock support to OV5640 camera sensor

2018-03-29 Thread Manivannan Sadhasivam
Some of the camera subsystems like camss in Qualcommm MSM chipsets require pixel clock support in camera sensor drivers for proper functioning. So, add a default pixel clock rate of 96MHz to OV5640 camera sensor driver. According to the datasheet, 96MHz can be used as a pixel clock rate for most

[RESEND PATCH] media: i2c: ov5640: Add pixel clock support

2018-03-29 Thread Manivannan Sadhasivam
Some of the camera subsystems like camss in Qualcommm MSM chipsets require pixel clock support in camera sensor drivers. So, this commit adds a default pixel clock rate of 96MHz to OV5640 camera sensor driver. According to the datasheet, 96MHz can be used as a pixel clock rate for most of the

Re: [PATCH 2/8] PCI: Add pci_find_common_upstream_dev()

2018-03-29 Thread Alex Deucher
Sorry, didn't mean to drop the lists here. re-adding. On Wed, Mar 28, 2018 at 4:05 PM, Alex Deucher wrote: > On Wed, Mar 28, 2018 at 3:53 PM, Logan Gunthorpe wrote: >> >> >> On 28/03/18 01:44 PM, Christian König wrote: >>> Well, isn't that exactly

Re: [PATCH 2/8] PCI: Add pci_find_common_upstream_dev()

2018-03-29 Thread Logan Gunthorpe
On 29/03/18 05:44 AM, Christian König wrote: > Am 28.03.2018 um 21:53 schrieb Logan Gunthorpe: >> >> On 28/03/18 01:44 PM, Christian König wrote: >>> Well, isn't that exactly what dma_map_resource() is good for? As far as >>> I can see it makes sure IOMMU is aware of the access route and >>>