[PATCH 3/6] vicodec: simplify flags handling

2018-08-21 Thread Hans Verkuil
From: Hans Verkuil The flags field can be removed from struct vicodec_q_data. This simplifies the flags handling elsewhere. Signed-off-by: Hans Verkuil --- drivers/media/platform/vicodec/vicodec-core.c | 26 +-- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git

[PATCH 2/6] vicodec: add support for more pixel formats

2018-08-21 Thread Hans Verkuil
From: Hans Verkuil Add support for 4:2:2, 4:4:4 and RGB 24/32 bits formats. This makes it a lot more useful, esp. as a simple video compression codec for use with v4l2-ctl/qvidcap. Note that it does not do any conversion between e.g. 4:2:2 and 4:2:0 or RGB and YUV: it still just compresses

[PATCH 5/6] vicodec: improve handling of uncompressable planes

2018-08-21 Thread Hans Verkuil
From: Hans Verkuil Exit the loop immediately once it is clear that the plane cannot be compressed. Also clear the PCODED bit and fix the PCODED check (it should check for the bit) in the caller code. Signed-off-by: Hans Verkuil --- drivers/media/platform/vicodec/vicodec-codec.c | 10

[PATCH 7/6] pixfmt-compressed.rst: update vicodec-codec.h reference

2018-08-21 Thread Hans Verkuil
This header has been renamed to codec-fwht.h, so update this doc as well. Signed-off-by: Hans Verkuil --- Documentation/media/uapi/v4l/pixfmt-compressed.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/media/uapi/v4l/pixfmt-compressed.rst

Re: [RFC] Request API and V4L2 capabilities

2018-08-21 Thread Tomasz Figa
Hi Hans, Paul, On Mon, Aug 6, 2018 at 6:29 PM Paul Kocialkowski wrote: > > On Mon, 2018-08-06 at 11:23 +0200, Hans Verkuil wrote: > > On 08/06/2018 11:13 AM, Paul Kocialkowski wrote: > > > Hi, > > > > > > On Mon, 2018-08-06 at 10:32 +0200, Hans Verkuil wrote: > > > > On 08/06/2018 10:16 AM, Paul

Re: [RFC] Request API and V4L2 capabilities

2018-08-21 Thread Tomasz Figa
On Wed, Aug 15, 2018 at 11:18 PM Hans Verkuil wrote: > > On 15/08/18 14:11, Mauro Carvalho Chehab wrote: > > Em Sat, 4 Aug 2018 15:50:04 +0200 > > Hans Verkuil escreveu: > > > >> Hi all, > >> > >> While the Request API patch series addresses all the core API issues, there > >> are some

Re: [RFC] Request API questions

2018-08-21 Thread Tomasz Figa
On Tue, Aug 21, 2018 at 7:00 PM Sakari Ailus wrote: > > On Fri, Aug 17, 2018 at 12:09:40PM +0200, Hans Verkuil wrote: > > On 17/08/18 12:02, Tomasz Figa wrote: > > > On Thu, Aug 16, 2018 at 8:15 PM Mauro Carvalho Chehab > > > wrote: > > >> > > >> Em Thu, 16 Aug 2018 12:25:25 +0200 > > >> Hans

[PATCH 8/6] codec-fwht.h: update two cframe_hdr references in comments.

2018-08-21 Thread Hans Verkuil
cframe_hdr has been renamed to fwht_cframe_hdr, but the old name was still used in two comments. Signed-off-by: Hans Verkuil --- drivers/media/platform/vicodec/codec-fwht.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/vicodec/codec-fwht.h

Re: [RFC] Request API and V4L2 capabilities

2018-08-21 Thread Tomasz Figa
On Mon, Aug 6, 2018 at 5:32 PM Hans Verkuil wrote: > > On 08/06/2018 10:16 AM, Paul Kocialkowski wrote: > > Hi Hans and all, > > > > On Sat, 2018-08-04 at 15:50 +0200, Hans Verkuil wrote: > >> Hi all, > >> > >> While the Request API patch series addresses all the core API issues, there > >> are

[PATCH 6/6] vicodec: rename and use proper fwht prefix for codec

2018-08-21 Thread Hans Verkuil
From: Hans Verkuil The codec source is generic and not vicodec specific. It can be used by other drivers or userspace as well. So rename the source and header to something more generic (codec-fwht.c/h) and prefix the defines, types and functions with fwht_. Signed-off-by: Hans Verkuil ---

[PATCH 4/6] vicodec: simplify blocktype checking

2018-08-21 Thread Hans Verkuil
From: Hans Verkuil Simplify some blocktype/is_intra checks. Signed-off-by: Hans Verkuil --- drivers/media/platform/vicodec/vicodec-codec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/platform/vicodec/vicodec-codec.c

[PATCH 1/6] vicodec: add QP controls

2018-08-21 Thread Hans Verkuil
From: Hans Verkuil Instead of hardcoding the quantization parameter (or 'DEADZONE_WIDTH' as it was called in the codec) make this configurable through two controls: one for I frames, one for P frames. Signed-off-by: Hans Verkuil --- .../media/platform/vicodec/vicodec-codec.c| 17 -

[PATCH 0/6] vicodec improvements

2018-08-21 Thread Hans Verkuil
From: Hans Verkuil - add support for quantization parameters - support many more pixel formats - code simplifications - rename source and use proper prefixes for the codec: this makes it independent from the vicodec driver and easier to reuse in userspace (similar to what we do for the

Re: [PATCH 0/6] vicodec improvements

2018-08-21 Thread Hans Verkuil
Just ignore this series, I need to make some more improvements so there will be a v2 later. Regards, Hans On 08/21/18 09:31, Hans Verkuil wrote: > From: Hans Verkuil > > - add support for quantization parameters > - support many more pixel formats > - code simplifications > - rename

[PATCH] media: af9035: prevent buffer overflow on write

2018-08-21 Thread Jozef Balga
media: af9035: prevents buffer overflow when less than 3 bytes are written to the device When less than 3 bytes are written to the device, memcpy is called with negative array size which leads to buffer overflow and kernel panic. This patch adds a condition and returns -EOPNOTSUPP instead. Fixes

Re: [RFC] Request API questions

2018-08-21 Thread Sakari Ailus
On Fri, Aug 17, 2018 at 12:09:40PM +0200, Hans Verkuil wrote: > On 17/08/18 12:02, Tomasz Figa wrote: > > On Thu, Aug 16, 2018 at 8:15 PM Mauro Carvalho Chehab > > wrote: > >> > >> Em Thu, 16 Aug 2018 12:25:25 +0200 > >> Hans Verkuil escreveu: > >> > >>> Laurent raised a few API issues/questions

[PATCH] media: i2c: max2175: convert to SPDX identifiers

2018-08-21 Thread Kuninori Morimoto
From: Kuninori Morimoto This patch updates license to use SPDX-License-Identifier instead of verbose license text. Signed-off-by: Kuninori Morimoto --- drivers/media/i2c/max2175.c | 10 +- drivers/media/i2c/max2175.h | 12 ++-- 2 files changed, 3 insertions(+), 19

Re: [RFC] Request API and V4L2 capabilities

2018-08-21 Thread Alexandre Courbot
On Tue, Aug 21, 2018 at 6:15 PM Tomasz Figa wrote: > > On Wed, Aug 15, 2018 at 11:18 PM Hans Verkuil wrote: > > > > On 15/08/18 14:11, Mauro Carvalho Chehab wrote: > > > Em Sat, 4 Aug 2018 15:50:04 +0200 > > > Hans Verkuil escreveu: > > > > > >> Hi all, > > >> > > >> While the Request API patch

Question regarding optimizing pipeline in Vimc

2018-08-21 Thread Helen Koike
Hello, One of the discussions we had when developing Vimc, was regarding optimizing image generation. The ideia was to generate the images directly in the capture instead of propagating through the pipeline (to make things faster). But my question is: if this optimization is on, and if there is a

cron job: media_tree daily build: OK

2018-08-21 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Aug 22 05:00:12 CEST 2018 media-tree git hash:da2048b7348a0be92f706ac019e022139e29495e media_build