cron job: media_tree daily build: OK

2018-09-06 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Sep 7 04:00:14 CEST 2018 media-tree git hash:d842a7cf938b6e0f8a1aa9f1aec0476c9a599310 media_build

Re: [PATCH 2/2] media: ov5640: Fix auto-exposure disabling

2018-09-06 Thread Laurent Pinchart
Hello, On Tuesday, 14 August 2018 18:45:25 EEST jacopo mondi wrote: > On Tue, Aug 07, 2018 at 08:53:23AM +, Hugues FRUCHET wrote: > > Hi Jacopo, > > > > In serie "[PATCH 0/5] Fix OV5640 exposure & gain" > > https://www.mail-archive.com/linux-media@vger.kernel.org/msg133269.html > > I've

[GIT PULL FOR v4.20 (request_api branch)] Request API: follow-up patches

2018-09-06 Thread Hans Verkuil
This patch series adds the remaining changes to the Request API topic branch. Userspace visible changes: - Invalid request_fd values now return -EINVAL instead of -ENOENT to be consistent with e.g. dmabuf fds. - It is no longer possible to use VIDIOC_G_EXT_CTRLS for requests that are not

Re: [PATCH v3 1/2] media: ov5640: Re-work MIPI startup sequence

2018-09-06 Thread jacopo mondi
Hello Loic, On Thu, Sep 06, 2018 at 10:13:53AM +0200, Loic Poulain wrote: > On 6 September 2018 at 09:48, jacopo mondi wrote: > > Hello Loic, > >thanks for looking into this > > > > On Tue, Sep 04, 2018 at 07:22:50PM +0200, Loic Poulain wrote: > >> Hi Jacopo, > >> > >> > - ret =

Re: [PATCH v3 1/4] dt-bindings: media: Add i.MX Pixel Pipeline binding

2018-09-06 Thread Philipp Zabel
Hi Philippe, On Thu, 2018-09-06 at 12:36 +0200, Philippe De Muyter wrote: [...] > > --- /dev/null > +++ b/Documentation/devicetree/bindings/media/fsl-pxp.txt > > @@ -0,0 +1,26 @@ > > +Freescale Pixel Pipeline > > + > > + > > +The Pixel Pipeline (PXP) is a memory-to-memory

Re: [PATCH v2 1/4] dt-bindings: media: Add i.MX Pixel Pipeline binding

2018-09-06 Thread Philipp Zabel
Hi Stefan, thank you for your comments. On Wed, 2018-09-05 at 19:10 +0200, Stefan Wahren wrote: > Hi Philipp, > > > Philipp Zabel hat am 5. September 2018 um 12:00 > > geschrieben: > > > > > > Add DT binding documentation for the Pixel Pipeline (PXP) found on > > various NXP i.MX SoCs. > >

Re: [PATCH v2 3/4] media: imx-pxp: add i.MX Pixel Pipeline driver

2018-09-06 Thread Philipp Zabel
On Thu, 2018-09-06 at 09:57 +0200, Hans Verkuil wrote: [...] > > If userspace sets xfer_func explicitly, it will get the explicit default > > ycbcr_enc and quantization values. > > > > I think I did this to make v4l2-compliance at some point, but it could > > be that the explicit output->capture

Re: [PATCH 2/2] CNF4 pixel format for media subsystem

2018-09-06 Thread Laurent Pinchart
Hello Sergey, On Thursday, 6 September 2018 12:37:36 EEST Hans Verkuil wrote: > On 09/06/18 09:51, dorod...@gmail.com wrote: > > From: Sergey Dorodnicov > > > > Registering new GUID used by Intel RealSense depth cameras with fourcc > > CNF4, encoding sensor confidence information for every

Re: [PATCH 1/2] CNF4 fourcc for 4 bit-per-pixel packed confidence information

2018-09-06 Thread Hans Verkuil
Hi Sergey, Some review comments: On 09/06/18 09:51, dorod...@gmail.com wrote: > From: Sergey Dorodnicov > > Adding new fourcc CNF4 for 4 bit-per-pixel packed confidence information > provided by Intel RealSense depth cameras. Every two consecutive pixels > are packed into a single byte

Re: [PATCH v2] [RFC v2] v4l2: add support for colorspace conversion for video capture

2018-09-06 Thread Philipp Zabel
On Thu, 2018-09-06 at 11:02 +0200, Hans Verkuil wrote: > Hi Philipp, > > It is much appreciated that this old RFC of mine Right, I should have made clearer that this is just a rework of Hans' original RFC in [1]. [1] https://patchwork.linuxtv.org/patch/28847/ > is picked up again. I always

[PATCH v3 3/4] media: imx-pxp: add i.MX Pixel Pipeline driver

2018-09-06 Thread Philipp Zabel
Add a V4L2 mem-to-mem scaler/CSC driver for the Pixel Pipeline (PXP) version found on i.MX6ULL SoCs. A similar variant is used on i.MX7D. Since this driver only uses the legacy pipeline, it should be reasonably easy to extend it to work with the older PXP versions found on i.MX6UL, i.MX6SX,

[PATCH v3 1/4] dt-bindings: media: Add i.MX Pixel Pipeline binding

2018-09-06 Thread Philipp Zabel
Add DT binding documentation for the Pixel Pipeline (PXP) found on various NXP i.MX SoCs. Signed-off-by: Philipp Zabel Reviewed-by: Rob Herring --- No changes since v2. --- .../devicetree/bindings/media/fsl-pxp.txt | 26 +++ 1 file changed, 26 insertions(+) create mode

[PATCH v3 0/4] i.MX PXP scaler/CSC driver

2018-09-06 Thread Philipp Zabel
The Pixel Pipeline (PXP) is a memory-to-memory graphics processing engine that supports scaling, colorspace conversion, alpha blending, rotation, and pixel conversion via lookup table. Different versions are present on various i.MX SoCs from i.MX23 to i.MX7. The latest versions on i.MX6ULL and

Re: [PATCH v2] [RFC v2] v4l2: add support for colorspace conversion for video capture

2018-09-06 Thread Hans Verkuil
Hi Philipp, It is much appreciated that this old RFC of mine is picked up again. I always wanted to get this in, but I never had a driver where it would make sense to do so. On 09/05/2018 07:09 PM, Philipp Zabel wrote: > For video capture it is the driver that reports the colorspace, add:

[PATCH v3 4/4] MAINTAINERS: add entry for i.MX PXP media mem2mem driver

2018-09-06 Thread Philipp Zabel
Signed-off-by: Philipp Zabel --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a5b256b25905..2e23c644f5d3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8994,6 +8994,13 @@ F: drivers/staging/media/imx/ F:

Re: [PATCH 2/2] CNF4 pixel format for media subsystem

2018-09-06 Thread Hans Verkuil
On 09/06/18 09:51, dorod...@gmail.com wrote: > From: Sergey Dorodnicov > > Registering new GUID used by Intel RealSense depth cameras with fourcc > CNF4, encoding sensor confidence information for every pixel. > > Signed-off-by: Sergey Dorodnicov > Signed-off-by: Evgeni Raikhel > --- >

Re: [PATCH v2] [RFC v2] v4l2: add support for colorspace conversion for video capture

2018-09-06 Thread Hans Verkuil
On 09/06/18 11:50, Philipp Zabel wrote: > On Thu, 2018-09-06 at 11:02 +0200, Hans Verkuil wrote: >> Hi Philipp, >> >> It is much appreciated that this old RFC of mine > > Right, I should have made clearer that this is just a rework of Hans' > original RFC in [1]. > > [1]

Re: [PATCH v3 1/4] dt-bindings: media: Add i.MX Pixel Pipeline binding

2018-09-06 Thread Philippe De Muyter
Hi Philipp, On Thu, Sep 06, 2018 at 11:02:12AM +0200, Philipp Zabel wrote: > Add DT binding documentation for the Pixel Pipeline (PXP) found on > various NXP i.MX SoCs. > > Signed-off-by: Philipp Zabel > Reviewed-by: Rob Herring > --- > No changes since v2. > --- >

Re: [PATCH v3 1/2] media: ov5640: Re-work MIPI startup sequence

2018-09-06 Thread Loic Poulain
On 6 September 2018 at 09:48, jacopo mondi wrote: > Hello Loic, >thanks for looking into this > > On Tue, Sep 04, 2018 at 07:22:50PM +0200, Loic Poulain wrote: >> Hi Jacopo, >> >> > - ret = ov5640_mod_reg(sensor, OV5640_REG_MIPI_CTRL00, BIT(5), >> > -on ? 0 :

Re: [PATCH v2] [RFC v2] v4l2: add support for colorspace conversion for video capture

2018-09-06 Thread Philipp Zabel
On Thu, 2018-09-06 at 12:54 +0200, Hans Verkuil wrote: [...] > > The application usually doesn't need to know whether the driver changed > > the requested ycbcr_enc because it doesn't have CSC matrix support at > > all, or because it doesn't implement a specific conversion. And if the > >

Re: [PATCH v2 3/5] media: ov5640: fix wrong binning value in exposure calculation

2018-09-06 Thread Laurent Pinchart
Hi Hugues, Thank you for the patch. On Monday, 13 August 2018 13:19:44 EEST Hugues Fruchet wrote: > ov5640_set_mode_exposure_calc() is checking binning value but > binning value read is buggy, fix this. > Rename ov5640_binning_on() to ov5640_get_binning() as per other > similar functions. > >

Re: [PATCH v2 4/5] media: ov5640: fix auto controls values when switching to manual mode

2018-09-06 Thread Laurent Pinchart
Hi Hugues, Thank you for the patch. On Monday, 13 August 2018 13:19:45 EEST Hugues Fruchet wrote: > When switching from auto to manual mode, V4L2 core is calling > g_volatile_ctrl() in manual mode in order to get the manual initial value. > Remove the manual mode check/return to not break this

Re: [PATCH v2 1/5] media: ov5640: fix exposure regression

2018-09-06 Thread Laurent Pinchart
Hi Hugues, Thank you for the patch. On Monday, 13 August 2018 13:19:42 EEST Hugues Fruchet wrote: > fixes: bf4a4b518c20 ("media: ov5640: Don't force the auto exposure state at > start time"). > > Symptom was black image when capturing HD or 5Mp picture > due to manual exposure set to 1 while it

Re: [PATCH] Documentation/media: uapi: Explicitly say there are no Invariant Sections

2018-09-06 Thread Ben Hutchings
Are you still waiting for agreement from any contributors, or is this ready to apply? Ben. On Fri, 2018-08-03 at 15:41 +0100, Ben Hutchings wrote: > The GNU Free Documentation License allows for a work to specify > Invariant Sections that are not allowed to be modified. (Debian > considers that

[PATCH 2/2] au0828: Fix incorrect error messages

2018-09-06 Thread Brad Love
Correcting red herring error messages. Where appropriate, replaces au0282_dev_register with: - au0828_analog_register - au0828_dvb_register Signed-off-by: Brad Love --- drivers/media/usb/au0828/au0828-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 0/2] au0828 Oops fix and message correction

2018-09-06 Thread Brad Love
An end user reported oopsing on connection of multiple Hauppauge 950Q devices. The oops is related to analog setup failing during usb probe for a device. If analog setup fails then dev is kfree'd and then drivers usb disconnect function is called, which requires valid dev. Hence, immediate oops.

[PATCH 1/2] au0828: cannot kfree dev before usb disconnect

2018-09-06 Thread Brad Love
If au0828_analog_register fails, the dev is kfree'd and then flow jumps to done, which can call au0828_usb_disconnect. Since all USB error codes are negative, au0828_usb_disconnect will be called. The problem is au0828_usb_disconnect uses dev, if dev is NULL then there is immediate oops

[PATCH 0/2] [media] Confidence pixel-format for Intel RealSense cameras

2018-09-06 Thread dorodnic
From: Sergey Dorodnicov Define new fourcc describing depth sensor confidence data used in Intel RealSense cameras. Confidence information is stored as packed 4 bits per pixel single-plane image. The patches were tested on 4.18-rc2 and merged with media_tree/master. Sergey Dorodnicov (2):

[PATCH 1/2] CNF4 fourcc for 4 bit-per-pixel packed confidence information

2018-09-06 Thread dorodnic
From: Sergey Dorodnicov Adding new fourcc CNF4 for 4 bit-per-pixel packed confidence information provided by Intel RealSense depth cameras. Every two consecutive pixels are packed into a single byte (little-endian). Signed-off-by: Sergey Dorodnicov Signed-off-by: Evgeni Raikhel ---

[PATCH 2/2] CNF4 pixel format for media subsystem

2018-09-06 Thread dorodnic
From: Sergey Dorodnicov Registering new GUID used by Intel RealSense depth cameras with fourcc CNF4, encoding sensor confidence information for every pixel. Signed-off-by: Sergey Dorodnicov Signed-off-by: Evgeni Raikhel --- drivers/media/usb/uvc/uvc_driver.c | 5 +

Re: [PATCH v3 1/2] media: ov5640: Re-work MIPI startup sequence

2018-09-06 Thread jacopo mondi
Hello Loic, thanks for looking into this On Tue, Sep 04, 2018 at 07:22:50PM +0200, Loic Poulain wrote: > Hi Jacopo, > > > - ret = ov5640_mod_reg(sensor, OV5640_REG_MIPI_CTRL00, BIT(5), > > -on ? 0 : BIT(5)); > > - if (ret) > > - return ret;

Re: [PATCH v2 3/4] media: imx-pxp: add i.MX Pixel Pipeline driver

2018-09-06 Thread Hans Verkuil
On 09/05/2018 03:20 PM, Philipp Zabel wrote: > On Wed, 2018-09-05 at 14:50 +0200, Hans Verkuil wrote: >>> +static enum v4l2_ycbcr_encoding pxp_default_ycbcr_enc(struct pxp_ctx *ctx) >>> +{ >>> + if (ctx->xfer_func) >>> + return V4L2_MAP_YCBCR_ENC_DEFAULT(ctx->colorspace); >>> + else