[GIT PULL FOR v4.20 (request_api branch)] Add Allwinner cedrus decoder driver

2018-09-10 Thread Hans Verkuil
Hi Mauro, This is the cedrus Allwinner decoder driver. It is for the request_api topic branch, but it assumes that this pull request is applied first: https://patchwork.linuxtv.org/patch/51889/ The last two patches could optionally be squashed with the main driver patch: they fix COMPILE_TEST

Re: [PATCH v2 4/5] media: ov5640: fix auto controls values when switching to manual mode

2018-09-10 Thread Hugues FRUCHET
Hi Laurent, On 09/06/2018 03:31 PM, Laurent Pinchart wrote: > Hi Hugues, > > Thank you for the patch. > > On Monday, 13 August 2018 13:19:45 EEST Hugues Fruchet wrote: >> When switching from auto to manual mode, V4L2 core is calling >> g_volatile_ctrl() in manual mode in order to get the manual

3% Loan Offer Apply Now

2018-09-10 Thread Mr. Passy Ben
ARE YOU IN NEED OF LOAN @3% INTEREST RATE FOR BUSINESS AND PRIVATE PURPOSES? IF YES: FILL AND RETURN Name:=== Amount needed:=== Duration:== country:=== Purpose:=== Mobile number

[PATCH 3/3] media: replace strncpy() by strscpy()

2018-09-10 Thread Mauro Carvalho Chehab
The strncpy() function is being deprecated upstream. Replace it by the safer strscpy(). Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/as102_fe.c | 2 +- drivers/media/dvb-frontends/dib7000p.c | 3 ++- drivers/media/dvb-frontends/dib8000.c

[PATCH 2/3] media: replace strcpy() by strscpy()

2018-09-10 Thread Mauro Carvalho Chehab
The strcpy() function is being deprecated upstream. Replace it by the safer strscpy(). Signed-off-by: Mauro Carvalho Chehab --- drivers/media/common/saa7146/saa7146_video.c | 2 +- drivers/media/dvb-core/dvb_frontend.c | 2 +- drivers/media/dvb-frontends/mt312.c | 9

[PATCH 0/3] Use only strscpy() for string copy

2018-09-10 Thread Mauro Carvalho Chehab
There are hot discussions upstream about getting rid of strcpy(), strncpy() and strlcpy() in favor of the safer strscpy(). While there are exceptions where strscpy() may not be the best option (for example, when filling records with fixed size), we don't have those situations right now on media.

Re: [PATCH v3 1/2] media: dt-bindings: bind nokia,n900-ir to generic pwm-ir-tx driver

2018-09-10 Thread Sean Young
On Fri, Aug 31, 2018 at 11:07:23AM +0300, Sakari Ailus wrote: > Hi Sean, > > On Fri, Jul 13, 2018 at 01:22:29PM +0100, Sean Young wrote: > > The generic pwm-ir-tx driver should work for the Nokia n900. > > > > Compile tested only. > > > > Cc: Rob Herring > > Cc: Ivaylo Dimitrov > > Cc: Pali

Re: [PATCH v5 5/6] media: Add controls for JPEG quantization tables

2018-09-10 Thread Hans Verkuil
On 09/06/2018 12:00 AM, Ezequiel Garcia wrote: > From: Shunqian Zheng > > Add V4L2_CID_JPEG_QUANTIZATION compound control to allow userspace > configure the JPEG quantization tables. > > Signed-off-by: Shunqian Zheng > Signed-off-by: Ezequiel Garcia > --- >

Re: [PATCH v5 5/6] media: Add controls for JPEG quantization tables

2018-09-10 Thread Ezequiel Garcia
Hi Hans, Thanks for the review. On Mon, 2018-09-10 at 14:42 +0200, Hans Verkuil wrote: > On 09/06/2018 12:00 AM, Ezequiel Garcia wrote: > > From: Shunqian Zheng > > > > Add V4L2_CID_JPEG_QUANTIZATION compound control to allow userspace > > configure the JPEG quantization tables. > > > >

Re: [PATCH v2 4/5] media: ov5640: fix auto controls values when switching to manual mode

2018-09-10 Thread Laurent Pinchart
Hi Hugues, On Monday, 10 September 2018 13:23:41 EEST Hugues FRUCHET wrote: > On 09/06/2018 03:31 PM, Laurent Pinchart wrote: > > On Monday, 13 August 2018 13:19:45 EEST Hugues Fruchet wrote: > > > >> When switching from auto to manual mode, V4L2 core is calling > >> g_volatile_ctrl() in manual

3% Loan Offer Apply Now

2018-09-10 Thread Mr. Passy Ben
ARE YOU IN NEED OF LOAN @3% INTEREST RATE FOR BUSINESS AND PRIVATE PURPOSES? IF YES: FILL AND RETURN Name:=== Amount needed:=== Duration:== country:=== Purpose:=== Mobile number

[GIT PULL FOR v4.20] i.MX PXP scaler/CSC driver

2018-09-10 Thread Hans Verkuil
Pull request for v3 of this new driver (https://www.spinics.net/lists/arm-kernel/msg674871.html). Regards, Hans The following changes since commit d842a7cf938b6e0f8a1aa9f1aec0476c9a599310: media: adv7842: enable reduced fps detection (2018-08-31 10:03:51 -0400) are available in the

Re: [PATCH v2 4/5] media: ov5640: fix auto controls values when switching to manual mode

2018-09-10 Thread Hugues FRUCHET
Hi Laurent, On 09/10/2018 12:46 PM, Laurent Pinchart wrote: > Hi Hugues, > > On Monday, 10 September 2018 13:23:41 EEST Hugues FRUCHET wrote: >> On 09/06/2018 03:31 PM, Laurent Pinchart wrote: >>> On Monday, 13 August 2018 13:19:45 EEST Hugues Fruchet wrote: >>> When switching from auto to

Re: [PATCH 3/3] media: replace strncpy() by strscpy()

2018-09-10 Thread Kees Cook
On Mon, Sep 10, 2018 at 5:19 AM, Mauro Carvalho Chehab wrote: > The strncpy() function is being deprecated upstream. Replace > it by the safer strscpy(). This one I'm quite concerned about. This could lead to kernel memory exposures if any of the callers depend on strncpy()'s trailing

Re: [PATCH v2 5/5] media: ov5640: fix restore of last mode set

2018-09-10 Thread Hugues FRUCHET
Hi Laurent, Steve, On 09/07/2018 04:18 PM, Laurent Pinchart wrote: > Hello Hugues, > > On Thursday, 16 August 2018 18:07:54 EEST Hugues FRUCHET wrote: >> On 08/16/2018 12:10 PM, jacopo mondi wrote: >>> On Mon, Aug 13, 2018 at 12:19:46PM +0200, Hugues Fruchet wrote: >>> Mode setting depends

Re: [PATCH 1/2] vicodec: Drop unneeded symbol dependency

2018-09-10 Thread Hans Verkuil
On 09/10/2018 05:44 PM, Ezequiel Garcia wrote: > On Mon, 2018-09-10 at 17:23 +0200, Hans Verkuil wrote: >> On 09/10/2018 05:21 PM, Ezequiel Garcia wrote: >>> The vicodec doesn't use the Subdev API, so drop the dependency. >>> >>> Signed-off-by: Ezequiel Garcia >>> --- >>>

[PATCH 2/2] vicodec: set state->info before calling the encode/decode funcs

2018-09-10 Thread Hans Verkuil
From: Hans Verkuil state->info was NULL since I completely forgot to set state->info. Oops. Reported-by: Ezequiel Garcia Signed-off-by: Hans Verkuil --- drivers/media/platform/vicodec/vicodec-core.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git

[PATCH 1/2] vicodec: check for valid format in v4l2_fwht_en/decode

2018-09-10 Thread Hans Verkuil
From: Hans Verkuil These functions did not return an error if state->info was NULL or an unsupported pixelformat was selected (should not happen, but just to be on the safe side). Signed-off-by: Hans Verkuil --- drivers/media/platform/vicodec/codec-v4l2-fwht.c | 15 +++

Re: [PATCH 1/2] vicodec: Drop unneeded symbol dependency

2018-09-10 Thread Ezequiel Garcia
On Mon, 2018-09-10 at 17:23 +0200, Hans Verkuil wrote: > On 09/10/2018 05:21 PM, Ezequiel Garcia wrote: > > The vicodec doesn't use the Subdev API, so drop the dependency. > > > > Signed-off-by: Ezequiel Garcia > > --- > > drivers/media/platform/vicodec/Kconfig | 2 +- > > 1 file changed, 1

Re: [PATCH 1/2] vicodec: Drop unneeded symbol dependency

2018-09-10 Thread Hans Verkuil
On 09/10/2018 05:21 PM, Ezequiel Garcia wrote: > The vicodec doesn't use the Subdev API, so drop the dependency. > > Signed-off-by: Ezequiel Garcia > --- > drivers/media/platform/vicodec/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

[PATCH 2/2] vicodec: Drop unused job_abort()

2018-09-10 Thread Ezequiel Garcia
The vicodec does not use the aborting field. In fact, this driver can't really cancel any work, since it performs all the work in device_run(). Signed-off-by: Ezequiel Garcia --- drivers/media/platform/vicodec/vicodec-core.c | 11 --- 1 file changed, 11 deletions(-) diff --git

[PATCH 1/2] vicodec: Drop unneeded symbol dependency

2018-09-10 Thread Ezequiel Garcia
The vicodec doesn't use the Subdev API, so drop the dependency. Signed-off-by: Ezequiel Garcia --- drivers/media/platform/vicodec/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/vicodec/Kconfig b/drivers/media/platform/vicodec/Kconfig index

Re: [PATCH 1/3] media: use strscpy() instead of strlcpy()

2018-09-10 Thread Kees Cook
On Mon, Sep 10, 2018 at 5:19 AM, Mauro Carvalho Chehab wrote: > The implementation of strscpy() is more robust and safer. > > That's now the recommended way to copy NUL terminated strings. This looks fine since I don't see anything using the strlcpy() return value (the return value meaning

Re: [PATCH 2/3] media: replace strcpy() by strscpy()

2018-09-10 Thread Kees Cook
On Mon, Sep 10, 2018 at 5:19 AM, Mauro Carvalho Chehab wrote: > The strcpy() function is being deprecated upstream. Replace > it by the safer strscpy(). Did you verify that all the destination buffers here are arrays and not pointers? For example: struct thing { char buffer[64]; char *ptr;

Re: [PATCH 2/2] vicodec: set state->info before calling the encode/decode funcs

2018-09-10 Thread Ezequiel Garcia
On Mon, 2018-09-10 at 17:00 +0200, Hans Verkuil wrote: > From: Hans Verkuil > > state->info was NULL since I completely forgot to set state->info. > Oops. > > Reported-by: Ezequiel Garcia > Signed-off-by: Hans Verkuil For both patches: Tested-by: Ezequiel Garcia With these changes, now

Re: [PATCH 3/3] media: replace strncpy() by strscpy()

2018-09-10 Thread Mauro Carvalho Chehab
Em Mon, 10 Sep 2018 09:18:05 -0700 Kees Cook escreveu: > On Mon, Sep 10, 2018 at 5:19 AM, Mauro Carvalho Chehab > wrote: > > The strncpy() function is being deprecated upstream. Replace > > it by the safer strscpy(). > > This one I'm quite concerned about. This could lead to kernel memory >

Re: [PATCH 2/2] vicodec: set state->info before calling the encode/decode funcs

2018-09-10 Thread Nicolas Dufresne
Le lundi 10 septembre 2018 à 12:37 -0300, Ezequiel Garcia a écrit : > On Mon, 2018-09-10 at 17:00 +0200, Hans Verkuil wrote: > > From: Hans Verkuil > > > > state->info was NULL since I completely forgot to set state->info. > > Oops. > > > > Reported-by: Ezequiel Garcia > > Signed-off-by: Hans

Re: [PATCH 2/3] media: replace strcpy() by strscpy()

2018-09-10 Thread Mauro Carvalho Chehab
Em Mon, 10 Sep 2018 09:16:35 -0700 Kees Cook escreveu: > On Mon, Sep 10, 2018 at 5:19 AM, Mauro Carvalho Chehab > wrote: > > The strcpy() function is being deprecated upstream. Replace > > it by the safer strscpy(). > > Did you verify that all the destination buffers here are arrays and >

Re: [PATCH 2/2] vicodec: set state->info before calling the encode/decode funcs

2018-09-10 Thread Ezequiel Garcia
On Mon, 2018-09-10 at 13:16 -0400, Nicolas Dufresne wrote: > Le lundi 10 septembre 2018 à 12:37 -0300, Ezequiel Garcia a écrit : > > On Mon, 2018-09-10 at 17:00 +0200, Hans Verkuil wrote: > > > From: Hans Verkuil > > > > > > state->info was NULL since I completely forgot to set state->info. > >

[PATCH 2/3 v2] media: replace strcpy() by strscpy()

2018-09-10 Thread Mauro Carvalho Chehab
The strcpy() function is being deprecated upstream. Replace it by the safer strscpy(). Signed-off-by: Mauro Carvalho Chehab -- v2: removed the changes at the imon driver. There, the is a debugfs node with a store function using DEVICE_ATTR() passing a char * buf without any sizing information.

Re: [PATCH v2 4/5] media: ov5640: fix auto controls values when switching to manual mode

2018-09-10 Thread Laurent Pinchart
Hi Hugues, (Hans, there's a question for you below) On Monday, 10 September 2018 17:43:27 EEST Hugues FRUCHET wrote: > On 09/10/2018 12:46 PM, Laurent Pinchart wrote: > > On Monday, 10 September 2018 13:23:41 EEST Hugues FRUCHET wrote: > >> On 09/06/2018 03:31 PM, Laurent Pinchart wrote: > >>>

Re: [PATCH 2/3] media: replace strcpy() by strscpy()

2018-09-10 Thread Mauro Carvalho Chehab
Em Mon, 10 Sep 2018 16:48:47 -0300 Mauro Carvalho Chehab escreveu: > Em Mon, 10 Sep 2018 09:16:35 -0700 > Kees Cook escreveu: > > > On Mon, Sep 10, 2018 at 5:19 AM, Mauro Carvalho Chehab > > wrote: > > > The strcpy() function is being deprecated upstream. Replace > > > it by the safer

Re: [PATCH 3/3] media: replace strncpy() by strscpy()

2018-09-10 Thread Kees Cook
On Mon, Sep 10, 2018 at 11:34 AM, Mauro Carvalho Chehab wrote: > Em Mon, 10 Sep 2018 09:18:05 -0700 > Kees Cook escreveu: > >> On Mon, Sep 10, 2018 at 5:19 AM, Mauro Carvalho Chehab >> wrote: >> > The strncpy() function is being deprecated upstream. Replace >> > it by the safer strscpy(). >> >>

Re: [PATCH v2 5/5] media: ov5640: fix restore of last mode set

2018-09-10 Thread Laurent Pinchart
Hi Hugues, On Monday, 10 September 2018 18:14:45 EEST Hugues FRUCHET wrote: > On 09/07/2018 04:18 PM, Laurent Pinchart wrote: > > On Thursday, 16 August 2018 18:07:54 EEST Hugues FRUCHET wrote: > >> On 08/16/2018 12:10 PM, jacopo mondi wrote: > >>> On Mon, Aug 13, 2018 at 12:19:46PM +0200, Hugues

cron job: media_tree daily build: OK

2018-09-10 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Sep 11 04:00:15 CEST 2018 media-tree git hash:d842a7cf938b6e0f8a1aa9f1aec0476c9a599310 media_build