Add a single imx-media mem2mem video device that uses the IPU IC PP
(image converter post processing) task for scaling and colorspace
conversion.
On i.MX6Q/DL SoCs with two IPUs currently only the first IPU is used.
The hardware only supports writing to destination buffers up to
1024x1024 pixels
This will allow to calculate seam positions after initializing the
ipu_image base structure but before calculating tile dimensions.
Signed-off-by: Philipp Zabel
---
No changes since v2.
---
drivers/gpu/ipu-v3/ipu-image-convert.c | 17 ++---
1 file changed, 10 insertions(+), 7
Let convert_start start from a given tile index, allocate intermediate
tile with maximum tile size.
Signed-off-by: Philipp Zabel
---
No changes since v2.
---
drivers/gpu/ipu-v3/ipu-image-convert.c | 60 +++---
1 file changed, 35 insertions(+), 25 deletions(-)
diff --git
For differently sized tiles or if the resizing coefficients change,
we have to stop, reconfigure, and restart the IC between tiles.
Signed-off-by: Philipp Zabel
---
No changes since v2.
---
drivers/gpu/ipu-v3/ipu-image-convert.c | 65 +-
1 file changed, 44 insertions(+),
Select seam positions that minimize distortions during seam hiding while
satifying input and output IDMAC, rotator, and image format constraints.
This code looks for aligned output seam positions that minimize the
difference between the fractional corresponding ideal input positions
and the input
From: Steve Longerbeam
Add a WARN_ON_ONCE() if either the Y/packed buffer, or the U/V offsets,
are not aligned on 8-byte boundaries. This will catch alignment
bugs in DRM, V4L2.
Signed-off-by: Steve Longerbeam
---
New since v2.
---
drivers/gpu/ipu-v3/ipu-cpmem.c | 6 ++
1 file changed, 6
Slightly modifying resize coefficients per-tile allows to completely
hide the seams between tiles and to sample the correct input pixels at
the bottom and right edges of the image.
Tiling requires a bilinear interpolator reset at each tile start, which
causes the image to be slightly shifted if
Store tile top/left position in pixels in the tile structure.
This will allow overlapping tiles with different sizes later.
Signed-off-by: Philipp Zabel
---
No changes since v2.
---
drivers/gpu/ipu-v3/ipu-image-convert.c | 27 ++
1 file changed, 15 insertions(+), 12
Move tile_width_align and tile_height_align up so they
can be used by the tile edge position calculation code.
Signed-off-by: Philipp Zabel
---
No changes since v2.
---
drivers/gpu/ipu-v3/ipu-image-convert.c | 54 +-
1 file changed, 27 insertions(+), 27 deletions(-)
Hi,
this is the third version of the i.MX mem2mem scaler series.
The driver patch has been moved to the beginning, as Steve suggested.
I've added his warning patch to catch alignment bugs to the series,
seam position selection has been fixed for more corner cases, the
alignment restriction
For the planar but U/V-packed formats NV12 and NV16, 8 pixel width
alignment is good enough to fulfill the 8 byte stride requirement.
If we allow the input 8-pixel DMA bursts to overshoot the end of the
line, the only input alignment restrictions are dictated by the pixel
format and 8-byte aligned
For planar formats, bytesperline does not depend on BPP. It must always
be larger than width and aligned to tile width alignment restrictions.
The input bytesperline to ipu_image_convert_adjust() may be
uninitialized, so don't rely on input bytesperline as the
minimum value for clamp_align(). Use
If width or height are in the [2049, 3072] range, allow to
use just three tiles in this dimension, instead of four.
Signed-off-by: Philipp Zabel
---
New since v2.
---
drivers/gpu/ipu-v3/ipu-image-convert.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git
For tiled scaling, we want to compute the scaling coefficients
externally in such a way that the interpolation overshoots tile
boundaries and samples up to the first pixel of the next tile.
Prepare to override the resizing coefficients from the image
conversion code.
Signed-off-by: Philipp Zabel
The documentation in Documentation/media/uapi/v4l/pixfmt-packed-rgb.rst
tells us that the V4L2_PIX_FMT_RGB32 format is deprecated and must not
be used by new drivers. Replace it with V4L2_PIX_FMT_XRGB32.
Signed-off-by: Philipp Zabel
---
drivers/staging/media/imx/imx-media-utils.c | 4 ++--
1
Hi Bingbu,
On Mon, Sep 17, 2018 at 2:53 PM wrote:
>
> From: Bingbu Cao
>
> Add a v4l2 sub-device driver for the Sony imx319 image sensor.
> This is a camera sensor using the i2c bus for control and the
> csi-2 bus for data.
Please see my comments inline. Also, I'd appreciate being CCed on
Since tile dimensions now vary between tiles, add debug output for each
tile's position and dimensions.
Signed-off-by: Philipp Zabel
---
No changes since v2.
---
drivers/gpu/ipu-v3/ipu-image-convert.c | 12 ++--
1 file changed, 10 insertions(+), 2 deletions(-)
diff --git
Visualize the scaling and rotation pipeline with some ASCII art
diagrams. Remove the FIXME comment about missing seam prevention.
Signed-off-by: Philipp Zabel
---
No changes since v2.
---
drivers/gpu/ipu-v3/ipu-image-convert.c | 39 +++---
1 file changed, 29 insertions(+),
Double-buffering only works if tile sizes are the same and the resizing
coefficient does not change between tiles, even for non-planar formats.
Signed-off-by: Philipp Zabel
---
No changes since v2.
---
drivers/gpu/ipu-v3/ipu-image-convert.c | 27 --
1 file changed, 25
Hi,
On 18-09-14 15:57, Mauro Carvalho Chehab wrote:
> Em Fri, 14 Sep 2018 20:20:46 +0200
> Marco Felsch escreveu:
>
> > Hi Sakari,
> >
> > On 18-09-14 16:23, Sakari Ailus wrote:
> > > Hi Marco,
> > >
> > > On Mon, Aug 13, 2018 at 11:25:08AM +0200, Marco Felsch wrote:
> > > > Don't
On Mon, Sep 17, 2018 at 6:03 PM Akinobu Mita wrote:
>
> AMG88xx has a register for setting frame rate 1 or 10 FPS.
> This adds support changing frame interval.
>
> Reference specifications:
> https://docid81hrs3j1.cloudfront.net/medialibrary/2017/11/PANA-S-A0002141979-1.pdf
>
> Cc: Matt Ranostay
On Mon, Sep 17, 2018 at 6:03 PM Akinobu Mita wrote:
>
> AMG88xx has a register for setting operating mode. This adds support
> runtime PM by changing the operating mode.
>
> The instruction for changing sleep mode to normal mode is from the
> reference specifications.
>
>
tree: git://linuxtv.org/mchehab/experimental tvp5150-5
head: c223c451df23ac71a844d05aab65ede057b70eb0
commit: bc93ce496fa909d8fa9496c93d36e9ea413a9065 [135/138] tvp5150: add
FORMAT_TRY support for get/set selection handlers
config: i386-randconfig-s0-09171149 (attached as .config)
compiler:
tree: git://linuxtv.org/mchehab/experimental tvp5150-5
head: c223c451df23ac71a844d05aab65ede057b70eb0
commit: 71c04fa3b90605e64a5bf2ea9b686c2d64f0066b [131/138] tvp5150: add input
source selection of_graph support
config: i386-randconfig-s0-09171149 (attached as .config)
compiler: gcc-6
Lieber Freund,
Ich bin Herr Tayeb Souami, New Jersey, Vereinigte Staaten von Amerika, der
Mega-Gewinner von $ 315million In Mega Millions Jackpot, spende ich an 5
zufällige Personen, wenn Sie diese E-Mail erhalten, dann wurde Ihre E-Mail nach
einem Spinball ausgewählt.Ich habe den größten
On Mon, Sep 17, 2018 at 5:20 AM Zhi, Yong wrote:
>
> Hi, Tomasz,
>
> Thanks for the code review.
>
> > -Original Message-
> > From: linux-media-ow...@vger.kernel.org [mailto:linux-media-
> > ow...@vger.kernel.org] On Behalf Of Tomasz Figa
> > Sent: Monday, July 2, 2018 3:08 AM
> > To:
tree: git://linuxtv.org/mchehab/experimental tvp5150-5
head: c223c451df23ac71a844d05aab65ede057b70eb0
commit: bc93ce496fa909d8fa9496c93d36e9ea413a9065 [135/138] tvp5150: add
FORMAT_TRY support for get/set selection handlers
config: x86_64-randconfig-s5-09181631 (attached as .config)
compiler:
On 09/18/2018 02:42 AM, Philipp Zabel wrote:
The documentation in Documentation/media/uapi/v4l/pixfmt-packed-rgb.rst
tells us that the V4L2_PIX_FMT_RGB32 format is deprecated and must not
be used by new drivers. Replace it with V4L2_PIX_FMT_XRGB32.
Signed-off-by: Philipp Zabel
Acked-by:
On 09/17/2018 03:27 AM, Hans Verkuil wrote:
On 05/07/2018 11:54 AM, Hans Verkuil wrote:
On 07/04/18 15:04, Marek Vasut wrote:
In VDIC direct mode, the VDIC applies combing filter during and
doubles the framerate, that is, after the first two half-frames
are received and the first frame is
On 09/17/2018 03:25 AM, Hans Verkuil wrote:
On 05/07/2018 11:55 AM, Hans Verkuil wrote:
On 07/04/18 15:05, Marek Vasut wrote:
In case the PRPVF is not connected directly to CSI, the PRPVF subdev
driver won't find the CSI subdev and will not configure the CSI input
mux. This is not noticable
Hi Sakari,
> -Original Message-
> From: sakari.ai...@linux.intel.com [mailto:sakari.ai...@linux.intel.com]
> Sent: Thursday, September 13, 2018 4:38 AM
> To: Mani, Rajmohan
> Cc: Hans Verkuil ; Zhi, Yong ; linux-
> me...@vger.kernel.org; tf...@chromium.org; mche...@kernel.org;
>
Hi Sakari,
> -Original Message-
> From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com]
> Sent: Thursday, September 13, 2018 12:37 AM
> To: Mani, Rajmohan
> Cc: Tomasz Figa ; Mauro Carvalho Chehab
> ; Hans Verkuil ; Zhi,
> Yong ; Linux Media Mailing List me...@vger.kernel.org>; Mauro
This message is generated daily by a cron job that builds media_tree for
the kernels and architectures in the list below.
Results of the daily build of media_tree:
date: Wed Sep 19 04:00:16 CEST 2018
media-tree git hash:985cdcb08a0488558d1005139596b64d73bee267
media_build
On Thu, Sep 13, 2018 at 9:15 PM Paul Kocialkowski wrote:
>
> Hi,
>
> On Wed, 2018-09-05 at 19:00 -0300, Ezequiel Garcia wrote:
> > From: Shunqian Zheng
> >
> > Add V4L2_CID_JPEG_QUANTIZATION compound control to allow userspace
> > configure the JPEG quantization tables.
> >
> > Signed-off-by:
Hi Bingbu,
On Mon, Sep 17, 2018 at 2:53 PM wrote:
[snip]
> +static int imx319_update_digital_gain(struct imx319 *imx319, u32 d_gain)
> +{
> + int ret;
> +
> + ret = imx319_write_reg(imx319, IMX319_REG_DPGA_USE_GLOBAL_GAIN, 1, 1);
> + if (ret)
> + return ret;
> +
>
On Sun, Sep 16, 2018 at 1:48 AM Paul Kocialkowski wrote:
>
> Hi,
>
> On Mon, 2018-09-10 at 10:25 -0300, Ezequiel Garcia wrote:
> > Hi Hans,
> >
> > Thanks for the review.
> >
> > On Mon, 2018-09-10 at 14:42 +0200, Hans Verkuil wrote:
> > > On 09/06/2018 12:00 AM, Ezequiel Garcia wrote:
> > > >
Hi Grant,
On Mon, Sep 17, 2018 at 03:52:30PM -0700, Grant Grundler wrote:
> On Fri, Sep 14, 2018 at 4:41 AM Sakari Ailus
> wrote:
> >
> > Hi Ping-chung,
> >
> > My apologies for the late review.
>
> Yeah...I had the impression this was already accepted. Though it
> should be straight forward to
2018年9月18日(火) 15:23 Matt Ranostay :
>
> On Mon, Sep 17, 2018 at 6:03 PM Akinobu Mita wrote:
> >
> > AMG88xx has a register for setting operating mode. This adds support
> > runtime PM by changing the operating mode.
> >
> > The instruction for changing sleep mode to normal mode is from the
> >
There is no need to create another input device.
Signed-off-by: Sean Young
---
drivers/media/rc/ir-imon-decoder.c | 62 ++
drivers/media/rc/rc-core-priv.h| 2 -
drivers/media/rc/rc-main.c | 6 +++
3 files changed, 10 insertions(+), 60 deletions(-)
diff
libevdev (which is used by libinput) gets a list of keycodes from the
input device on creation. Any events with keycodes which are not in this
list are silently dropped. So, set all keycodes on device creation since
we do not know which will be used if the keymap changes.
Signed-off-by: Sean
There is no need to create another input device.
Signed-off-by: Sean Young
---
drivers/media/rc/ir-mce_kbd-decoder.c | 77 +--
drivers/media/rc/rc-core-priv.h | 3 --
2 files changed, 14 insertions(+), 66 deletions(-)
diff --git
tree: git://linuxtv.org/mchehab/experimental tvp5150-5
head: c223c451df23ac71a844d05aab65ede057b70eb0
commit: 71c04fa3b90605e64a5bf2ea9b686c2d64f0066b [131/138] tvp5150: add input
source selection of_graph support
config: x86_64-randconfig-s5-09181631 (attached as .config)
compiler: gcc-7
2018年9月18日(火) 12:19 Matt Ranostay :
>
> On Mon, Sep 17, 2018 at 9:03 AM Akinobu Mita wrote:
> >
> > Use regmap for i2c register access. This simplifies register accesses and
> > chooses suitable access commands based on the functionality that the
> > adapter supports.
> >
> > Cc: Matt Ranostay
This patch adds the of_graph support to describe the tvp connections.
Physical the TVP5150 has three ports: AIP1A, AIP1B and YOUT. As result
of discussion [1],[2] the device-tree maps these ports 1:1. The svideo
connector must be conneted to port@0/endpoint@1, look at the Documentation
for more
The TVP5150/1 decoders support different video input sources to their
AIP1A/B pins.
Possible configurations are as follows:
- Analog Composite signal connected to AIP1A.
- Analog Composite signal connected to AIP1B.
- Analog S-Video Y (luminance) and C (chrominance)
signals connected to
Commit 37c65802e76a ("media: tvp5150: Add sync lock interrupt handling")
introduced the interrupt handling. But we have to free the
v4l2_ctrl_handler before we can return the error code.
Fixes: 37c65802e76a ("media: tvp5150: Add sync lock interrupt handling")
Signed-off-by: Marco Felsch
---
Hi,
this is my v3 with the integrated reviews from my v2 [1]. This serie
applies to Mauro's experimental.git [2].
@Mauro:
Patch ("media: tvp5150: fix irq_request error path during probe") is new
in this series. Maybe you can squash them with ("media: tvp5150: Add sync lock
interrupt handling"),
From: Javier Martinez Canillas
Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support")
added input signals support for the tvp5150, but the approach was found
to be incorrect so the corresponding DT binding commit 82c2ffeb217a
("[media] tvp5150: document input connectors DT
Don't en-/disable the interrupts during s_stream because someone can
disable the stream but wants to get informed if the stream is locked
again. So keep the interrupts enabled the whole time the pipeline is
opened.
Signed-off-by: Marco Felsch
---
drivers/media/i2c/tvp5150.c | 23
From: Michael Tretter
There are several debug prints in the tvp5150_parse_dt() function, which
do not print the prefix, because the v4l2_subdev is not initialized, yet.
Initialize the v4l2_subdev before parsing the device tree to fix the
debug messages.
Signed-off-by: Michael Tretter
These helpers make us of the media-controller entity which is only
available if the CONFIG_MEDIA_CONTROLLER is enabled.
Signed-off-by: Marco Felsch
---
Changelog:
v3:
- add CONFIG_MEDIA_CONTROLLER switch instead of moving the
v4l2_subdev_get_try_* APIs into the existing one.
v2:
- Initial
Since commit 10d5509c8d50 ("[media] v4l2: remove g/s_crop from video ops")
the 'which' field for set/get_selection must be FORMAT_ACTIVE. There is
no way to try different selections. The patch adds a helper function to
select the correct selection memory space (sub-device file handle or
driver
On Tue, Sep 18, 2018 at 09:13:04AM -0400, Adam Stylinski wrote:
> On Sat, Sep 15, 2018 at 09:30:30AM +0100, David R wrote:
> > Any bisection would take ages, as I need to run for approaching a week
> > to be sure. There are only 3 commits that are possible.
> >
> > commit
In case of missing CONFIG_VIDEO_V4L2_SUBDEV_API those helpers aren't
available. So each driver have to add ifdefs around those helpers or
add the CONFIG_VIDEO_V4L2_SUBDEV_API as dependcy.
Make these helpers available in case of CONFIG_VIDEO_V4L2_SUBDEV_API
isn't set to avoid ifdefs. This approach
+Hans Verkuil
(I think he commented on earlier revisions. Please keep anyone who
commented before on CC when sending further revisions.)
On Mon, Sep 17, 2018 at 5:04 AM Zhi, Yong wrote:
>
> Hi, Tomasz,
>
> Sorry for the delay in responding to your review.
>
> > -Original Message-
> >
55 matches
Mail list logo
