RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-21 Thread Chen, Ping-chung
Typo. -Original Message- From: Chen, Ping-chung Sent: Friday, September 21, 2018 3:07 PM To: 'Ricardo Ribalda Delgado' ; Laurent Pinchart Cc: Sakari Ailus ; tf...@chromium.org; Sakari Ailus ; sylwester.nawro...@gmail.com; linux-media ; Yeh, Andy ; Lai, Jim ; grund...@chromium.org;

Re: [PATCH] libv4l: Add support for BAYER10P format conversion

2018-09-21 Thread Hans de Goede
Hi, On 21-09-18 09:40, Ricardo Ribalda Delgado wrote: Hi Hans On Fri, Sep 21, 2018 at 9:38 AM Hans de Goede wrote: Hi, On 20-09-18 22:04, Ricardo Ribalda Delgado wrote: Add support for 10 bit packet Bayer formats: -V4L2_PIX_FMT_SBGGR10P -V4L2_PIX_FMT_SGBRG10P -V4L2_PIX_FMT_SGRBG10P

Re: [PATCH v5] media: add imx319 camera sensor driver

2018-09-21 Thread Bing Bu Cao
On 09/17/2018 07:34 PM, Sakari Ailus wrote: > Hi Bingbu, > > Thanks for the update! A few more small comments, I think we're done after > these. > > On Mon, Sep 17, 2018 at 01:57:52PM +0800, bingbu@intel.com wrote: >> From: Bingbu Cao >> >> Add a v4l2 sub-device driver for the Sony imx319

Re: [PATCH v5] media: add imx319 camera sensor driver

2018-09-21 Thread Sakari Ailus
Hi Bingbu, On Fri, Sep 21, 2018 at 03:20:19PM +0800, Bing Bu Cao wrote: ... > >> + try_fmt->field = V4L2_FIELD_NONE; > >> + > >> + mutex_unlock(>mutex); > >> + > >> + return 0; > >> +} > >> + > >> +static int imx319_update_digital_gain(struct imx319 *imx319, u32 d_gain) > >> +{ > >> + int

Re: [PATCH] libv4l: Add support for BAYER10P format conversion

2018-09-21 Thread Ricardo Ribalda Delgado
Hi Hans On Fri, Sep 21, 2018 at 9:38 AM Hans de Goede wrote: > > Hi, > > On 20-09-18 22:04, Ricardo Ribalda Delgado wrote: > > Add support for 10 bit packet Bayer formats: > > -V4L2_PIX_FMT_SBGGR10P > > -V4L2_PIX_FMT_SGBRG10P > > -V4L2_PIX_FMT_SGRBG10P > > -V4L2_PIX_FMT_SRGGB10P > > > > These

RE: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-21 Thread Chen, Ping-chung
Hi Sakari, >-Original Message- >From: Ricardo Ribalda Delgado [mailto:ricardo.riba...@gmail.com] >Sent: Friday, September 21, 2018 5:55 AM >HI On Thu, Sep 20, 2018 at 11:13 PM Laurent Pinchart wrote: > > Hi Sakari, > > On Thursday, 20 September 2018 23:56:59 EEST Sakari Ailus wrote: >

Re: [PATCH] libv4l: Add support for BAYER10P format conversion

2018-09-21 Thread Hans de Goede
Hi, On 20-09-18 22:04, Ricardo Ribalda Delgado wrote: Add support for 10 bit packet Bayer formats: -V4L2_PIX_FMT_SBGGR10P -V4L2_PIX_FMT_SGBRG10P -V4L2_PIX_FMT_SGRBG10P -V4L2_PIX_FMT_SRGGB10P These formats pack the 2 LSBs for every 4 pixels in an indeppendent byte. Signed-off-by: Ricardo

Re: [PATCH v5] media: imx208: Add imx208 camera sensor driver

2018-09-21 Thread Helmut Grohne
On Thu, Sep 20, 2018 at 11:00:26PM +0200, Laurent Pinchart wrote: > On Thursday, 20 September 2018 23:16:47 EEST Sylwester Nawrocki wrote: > > On 09/20/2018 06:49 PM, Grant Grundler wrote: > > > On Thu, Sep 20, 2018 at 1:52 AM Tomasz Figa wrote: > > >> We have a problem here. The sensor supports

Re: [PATCH v5] media: add imx319 camera sensor driver

2018-09-21 Thread Tomasz Figa
On Fri, Sep 21, 2018 at 11:28 AM Bing Bu Cao wrote: > > > On 09/18/2018 05:49 PM, Tomasz Figa wrote: > > Hi Bingbu, > > > > On Mon, Sep 17, 2018 at 2:53 PM wrote: > >> From: Bingbu Cao > >> > >> Add a v4l2 sub-device driver for the Sony imx319 image sensor. > >> This is a camera sensor using

? recommended way to implement gain control

2018-09-21 Thread Philippe De Muyter
Hi, I see there's an ongoing discussion about implementing gain control for imx208. I have a similar problem (in the sense that the documentation of V4L2_CID_GAIN does not answer my question). The IMX264 has only one gain control, ranging from 0 to 480, but the unit is 'tenth of dB'. How can I

[PATCH v6] media: add imx319 camera sensor driver

2018-09-21 Thread bingbu . cao
From: Bingbu Cao Add a v4l2 sub-device driver for the Sony imx319 image sensor. This is a camera sensor using the i2c bus for control and the csi-2 bus for data. This driver supports following features: - manual exposure and analog/digital gain control support - vblank/hblank control support -

[PATCH v2] libv4l: Add support for BAYER10P format conversion

2018-09-21 Thread Ricardo Ribalda Delgado
Add support for 10 bit packet Bayer formats: -V4L2_PIX_FMT_SBGGR10P -V4L2_PIX_FMT_SGBRG10P -V4L2_PIX_FMT_SGRBG10P -V4L2_PIX_FMT_SRGGB10P These formats pack the 2 LSBs for every 4 pixels in an indeppendent byte. Signed-off-by: Ricardo Ribalda Delgado --- lib/libv4lconvert/bayer.c |

[GIT FIXES for 4.19] Prevent freeing media subscriptions while they're being accessed

2018-09-21 Thread Sakari Ailus
Hi Mauro, There's just a single patch in this pull request: the one that prevents releasing media event subscription memory while it is still being accessed. Compared to what was last reviewed on the list, I added Cc to stable, for this patch applies to 4.14 as well. Older LTS kernels (3.16,

Re: [PATCH v6] media: add imx319 camera sensor driver

2018-09-21 Thread Sakari Ailus
Hi Bingbu, On Fri, Sep 21, 2018 at 05:41:55PM +0800, bingbu@intel.com wrote: > From: Bingbu Cao > > Add a v4l2 sub-device driver for the Sony imx319 image sensor. > This is a camera sensor using the i2c bus for control and the > csi-2 bus for data. > > This driver supports following

Power Management and lens-focus

2018-09-21 Thread Ricardo Ribalda Delgado
Hello I have started using the lens-focus property: ad5820: dac@0c { compatible = "adi,ad5820"; reg = <0x0c>; VANA-supply = <_l23>; enable-gpios = < 26 GPIO_ACTIVE_HIGH>; }; camera_rear@60 { lens-focus = <>; }; I was testing my device using the following setup: qv4l2 grabbing images and yavta

Re: [PATCH v6 06/12] intel-ipu3: css: Add support for firmware management

2018-09-21 Thread Sakari Ailus
Hi Yong, On Wed, Sep 19, 2018 at 10:57:55PM +, Zhi, Yong wrote: ... > > > +struct imgu_abi_osys_frame_params { > > > + /* Output pins */ > > > + __u32 enable; > > > + __u32 format; /* enum imgu_abi_osys_format */ > > > + __u32 flip; > > > + __u32

Re: [PATCH v5] media: add imx319 camera sensor driver

2018-09-21 Thread Bing Bu Cao
On 09/21/2018 03:41 PM, Sakari Ailus wrote: > Hi Bingbu, > > On Fri, Sep 21, 2018 at 03:20:19PM +0800, Bing Bu Cao wrote: > ... + try_fmt->field = V4L2_FIELD_NONE; + + mutex_unlock(>mutex); + + return 0; +} + +static int

RE: [PATCH v6 06/12] intel-ipu3: css: Add support for firmware management

2018-09-21 Thread Zhi, Yong
Hi, Sakari, > -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] > Sent: Friday, September 21, 2018 6:52 AM > To: Zhi, Yong > Cc: Tomasz Figa ; Linux Media Mailing List me...@vger.kernel.org>; Mani, Rajmohan ; > Toivonen, Tuukka ; Hu, Jerry W > ; Zheng, Jian

cron job: media_tree daily build: OK

2018-09-21 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Sep 22 04:00:16 CEST 2018 media-tree git hash:985cdcb08a0488558d1005139596b64d73bee267 media_build