[PATCH] [v4l-utils] libv4l2subdev: Add MEDIA_BUS_FMT_FIXED to mbus_formats[]

Also add V4L2_COLORSPACE_RAW to the colorspaces[]. Signed-off-by: Yong Zhi --- utils/media-ctl/libv4l2subdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/utils/media-ctl/libv4l2subdev.c b/utils/media-ctl/libv4l2subdev.c index a989efb..46668eb 100644 ---

RE: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

Hi, Mauro, Thanks for your review. > -Original Message- > From: Mauro Carvalho Chehab [mailto:mchehab+sams...@kernel.org] > Sent: Friday, November 2, 2018 6:49 AM > To: Zhi, Yong > Cc: linux-media@vger.kernel.org; sakari.ai...@linux.intel.com; > tf...@chromium.org;

[PATCH v5 0/9] Asynchronous UVC

From: Kieran Bingham The Linux UVC driver has long provided adequate performance capabilities for web-cams and low data rate video devices in Linux while resolutions were low. Modern USB cameras are now capable of high data rates thanks to USB3 with 1080p, and even 4k capture resolutions

[PATCH v5 7/9] media: uvcvideo: Split uvc_video_enable into two

From: Kieran Bingham uvc_video_enable() is used both to start and stop the video stream object, however the single function entry point shares no code between the two operations. Split the function into two distinct calls, and rename to uvc_video_start_streaming() and uvc_video_stop_streaming()

[PATCH v5 9/9] media: uvcvideo: Utilise for_each_uvc_urb iterator

From: Kieran Bingham A new iterator is available for processing UVC URB structures. This simplifies the processing of the internal stream data. Convert the manual loop iterators to the new helper, adding an index helper to keep the existing debug print. Signed-off-by: Kieran Bingham --- This

[PATCH v5 8/9] media: uvcvideo: Rename uvc_{un,}init_video()

From: Kieran Bingham We have both uvc_init_video() and uvc_video_init() calls which can be quite confusing to determine the process for each. Now that video uvc_video_enable() has been renamed to uvc_video_start_streaming(), adapt these calls to suit the new flow. Rename uvc_init_video() to

[PATCH v5 5/9] media: uvcvideo: queue: Support asynchronous buffer handling

From: Kieran Bingham The buffer queue interface currently operates sequentially, processing buffers after they have fully completed. In preparation for supporting parallel tasks operating on the buffers, we will need to support buffers being processed on multiple CPUs. Adapt the

[PATCH v5 6/9] media: uvcvideo: Move decode processing to process context

From: Kieran Bingham Newer high definition cameras, and cameras with multiple lenses such as the range of stereo-vision cameras now available have ever increasing data rates. The inclusion of a variable length packet header in URB packets mean that we must memcpy the frame data out to our

[PATCH v5 2/9] media: uvcvideo: Convert decode functions to use new context structure

From: Kieran Bingham The URB completion handlers currently reference the stream context. Now that each URB has its own context structure, convert the decode (and one encode) functions to utilise this context for URB management. Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart ---

[PATCH v5 1/9] media: uvcvideo: Refactor URB descriptors

From: Kieran Bingham We currently store three separate arrays for each URB reference we hold. Objectify the data needed to track URBs into a single uvc_urb structure, allowing better object management and tracking of the URB. All accesses to the data pointers through stream, are converted to

[PATCH v5 4/9] media: uvcvideo: queue: Simplify spin-lock usage

From: Kieran Bingham Both uvc_start_streaming(), and uvc_stop_streaming() are called from userspace context, with interrupts enabled. As such, they do not need to save the IRQ state, and can use spin_lock_irq() and spin_unlock_irq() respectively. Signed-off-by: Kieran Bingham Reviewed-by:

[PATCH v4l-utils] Add missing linux/bpf_common.h

File needed by linux/bpf.h, add copy from linux-4.19.1 (and add to sync-with-kernel Makefile target). Signed-off-by: Peter Seiderer --- Changes v1 -> v2: - add linux/bpf_common.h to sync-with-kernel target --- Makefile.am| 4 ++- include/linux/bpf_common.h | 57

Re: [PATCH v5 7/9] media: uvcvideo: Split uvc_video_enable into two

Hi Kieran, Thank you for the patch. On Tuesday, 6 November 2018 23:27:18 EET Kieran Bingham wrote: > From: Kieran Bingham > > uvc_video_enable() is used both to start and stop the video stream > object, however the single function entry point shares no code between > the two operations. > >

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

On 11/01/2018 08:03 PM, Sakari Ailus wrote: > Hi Yong, > > Thanks for the update! > > On Mon, Oct 29, 2018 at 03:22:54PM -0700, Yong Zhi wrote: >> Hi, >> >> This series adds support for the Intel IPU3 (Image Processing Unit) >> ImgU which is essentially a modern memory-to-memory ISP. It

[PATCH] media: imx258: remove test pattern map from driver

From: "Chen, JasonX Z" Test Pattern mode be picked at HAL instead of driver. do a FLIP when userspace use test pattern mode. add entity_ops for validating imx258 link. Signed-off-by: Chen, JasonX Z --- drivers/media/i2c/imx258.c | 28 1 file changed, 8

cron job: media_tree daily build: ERRORS

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Nov 7 05:00:11 CET 2018 media-tree git hash:fbe57dde7126d1b2712ab5ea93fb9d15f89de708 media_build

[PATCH v5 3/9] media: uvcvideo: Protect queue internals with helper

From: Kieran Bingham The URB completion operation obtains the current buffer by reading directly into the queue internal interface. Protect this queue abstraction by providing a helper uvc_queue_get_current_buffer() which can be used by both the decode task, and the uvc_queue_next_buffer()

[GIT PULL FOR v4.21] rc changes

Hi Mauro, A new driver for the usb IR receiver for the original XBox, and a few minor fixes. Thanks, Sean The following changes since commit ef86eaf97acd6d82cd3fd40f997b1c8c4895a443: media: Rename vb2_m2m_request_queue -> v4l2_m2m_request_queue (2018-11-06 05:24:22 -0500) are available in

Re: [PATCH v4l-utils] Add missing linux/bpf_common.h

Hello Sean, On Tue, 6 Nov 2018 10:38:56 +, Sean Young wrote: > On Mon, Nov 05, 2018 at 09:30:47PM +0100, Peter Seiderer wrote: > > Copy from [1], needed by bpf.h. > > > > [1] > >

Hello

Limes Asset Ltd is a Registered UK company currently delivering business financing and financing. We are currently funding start-up, Growth stage companies and Individual funding. Do you need to pay for our services? Website: limesassetltd.co.uk Email: i...@limesassetltd.co.uk John Pratt

Re: [PATCH v5 6/9] media: uvcvideo: Move decode processing to process context

Hi Kieran, Thank you for the patch. On Tuesday, 6 November 2018 23:27:17 EET Kieran Bingham wrote: > From: Kieran Bingham > > Newer high definition cameras, and cameras with multiple lenses such as > the range of stereo-vision cameras now available have ever increasing > data rates. > > The

Re: [PATCH v5 9/9] media: uvcvideo: Utilise for_each_uvc_urb iterator

Hi Kieran, Thank you for the patch. On Tuesday, 6 November 2018 23:27:20 EET Kieran Bingham wrote: > From: Kieran Bingham > > A new iterator is available for processing UVC URB structures. This > simplifies the processing of the internal stream data. > > Convert the manual loop iterators to

Re: [PATCH v5 0/9] Asynchronous UVC

Hi Kieran, Thank you for the patches. On Tuesday, 6 November 2018 23:27:11 EET Kieran Bingham wrote: > From: Kieran Bingham > > The Linux UVC driver has long provided adequate performance capabilities for > web-cams and low data rate video devices in Linux while resolutions were > low. > >

RE: [PATCH v7 05/16] intel-ipu3: abi: Add structs

Hi Sakari, > Subject: Re: [PATCH v7 05/16] intel-ipu3: abi: Add structs > > Hi Raj, > > On Mon, Nov 05, 2018 at 07:05:53PM +, Mani, Rajmohan wrote: > > Hi Sakari, > > > > > Subject: Re: [PATCH v7 05/16] intel-ipu3: abi: Add structs > > > > > > Hi Yong, > > > > > > On Mon, Oct 29, 2018 at

Re: [RFC] Create test script(s?) for regression testing

Hi Hans, On Tuesday, 6 November 2018 15:56:34 EET Hans Verkuil wrote: > On 11/06/18 14:12, Laurent Pinchart wrote: > > On Tuesday, 6 November 2018 13:36:55 EET Sakari Ailus wrote: > >> On Tue, Nov 06, 2018 at 09:37:07AM +0100, Hans Verkuil wrote: > >>> Hi all, > >>> > >>> After the media summit

Re: [PATCH v5 5/9] media: uvcvideo: queue: Support asynchronous buffer handling

Hi Kieran, Thank you for the patch. On Tuesday, 6 November 2018 23:27:16 EET Kieran Bingham wrote: > From: Kieran Bingham > > The buffer queue interface currently operates sequentially, processing > buffers after they have fully completed. > > In preparation for supporting parallel tasks

Re: [PATCH v5 8/9] media: uvcvideo: Rename uvc_{un,}init_video()

Hi Kieran, Thank you for the patch. On Tuesday, 6 November 2018 23:27:19 EET Kieran Bingham wrote: > From: Kieran Bingham > > We have both uvc_init_video() and uvc_video_init() calls which can be > quite confusing to determine the process for each. Now that video > uvc_video_enable() has been

RE: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI

Hi Mauro, Thanks for the reviews. > Subject: Re: [PATCH v7 03/16] v4l: Add Intel IPU3 meta data uAPI > > Hi Mauro, > > On Fri, Nov 2, 2018 at 10:49 PM Mauro Carvalho Chehab > wrote: > > > > Em Mon, 29 Oct 2018 15:22:57 -0700 > > Yong Zhi escreveu: > [snip] > > > +struct

Re: [PATCH v2 3/3] media: imx-pxp: Improve pxp_soft_reset() error message

On Mon, 2018-11-05 at 18:45 -0200, Fabio Estevam wrote: > Improve the pxp_soft_reset() error message by moving it to the > caller function, associating it with a proper device and also > by displaying the error code. > > Signed-off-by: Fabio Estevam > --- > Changes since v1: > - Newly introduced

[PATCH v3 2/3] media: imx-pxp: Check for pxp_soft_reset() error

pxp_soft_reset() may fail with a timeout, so it is better to propagate the error in this case. Signed-off-by: Fabio Estevam Reviewed-by: Philipp Zabel --- Changes since v2: - Jump to err_clck when pxp_soft_reset() fails. (Philipp) drivers/media/platform/imx-pxp.c | 12 +--- 1 file

[PATCH v3 1/3] media: imx-pxp: Check the return value from clk_prepare_enable()

clk_prepare_enable() may fail, so we should better check its return value and propagate it in the case of error. Signed-off-by: Fabio Estevam Reviewed-by: Philipp Zabel --- Changes since v2: - None drivers/media/platform/imx-pxp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-)

[PATCH] davinci_vpfe: add a missing break

As warned by gcc: drivers/staging/media/davinci_vpfe/dm365_ipipeif.c: In function 'ipipeif_hw_setup': drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:298:3: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (isif_port_if) { ^~

[PATCH v3 3/3] media: imx-pxp: Improve pxp_soft_reset() error message

Improve the pxp_soft_reset() error message by moving it to the caller function, associating it with a proper device and also by displaying the error code. Signed-off-by: Fabio Estevam Reviewed-by: Philipp Zabel --- Changes since v2: - None (only rebased against the change made in 2/3)

Re: [PATCH] davinci_vpfe: add a missing break

On 11/06/18 11:15, Mauro Carvalho Chehab wrote: > As warned by gcc: > > drivers/staging/media/davinci_vpfe/dm365_ipipeif.c: In function > 'ipipeif_hw_setup': > drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:298:3: warning: this > statement may fall through [-Wimplicit-fallthrough=] >

Re: [PATCH 01/15] media: coda: fix memory corruption in case more than 32 instances are opened

On Mon, 2018-11-05 at 16:32 +, Ian Arkver wrote: > Hi Philipp, > > On 05/11/2018 15:24, Philipp Zabel wrote: > > The ffz() return value is undefined if the instance mask does not > > contain any zeros. If it returned 32, the following set_bit would > > corrupt the debugfs_root pointer. > >

[PATCH v2] media: coda: fix memory corruption in case more than 32 instances are opened

The ffz() return value is undefined if the instance mask does not contain any zeros. If it returned 32, the following set_bit would corrupt the debugfs_root pointer. Switch to IDA for context index allocation. This also removes the artificial 32 instance limit for all except CodaDx6.

Re: [PATCH v2 1/3] media: imx-pxp: Check the return value from clk_prepare_enable()

Hi Fabio, thank you for the fixes! On Mon, 2018-11-05 at 18:45 -0200, Fabio Estevam wrote: > clk_prepare_enable() may fail, so we should better check its return value > and propagate it in the case of error. > > Signed-off-by: Fabio Estevam > --- > Changes since v1: > - Properly enumerate the

Re: [PATCH v2 2/3] media: imx-pxp: Check for pxp_soft_reset() error

On Mon, 2018-11-05 at 18:45 -0200, Fabio Estevam wrote: > pxp_soft_reset() may fail with a timeout, so it is better to propagate > the error in this case. > > Signed-off-by: Fabio Estevam > --- > Changes since v1: > - None > > drivers/media/platform/imx-pxp.c | 12 +--- > 1 file

Re: [PATCH v3 1/1] v4l: event: Add subscription to list before calling "add" operation

On Tue, 6 Nov 2018 at 08:00, Sakari Ailus wrote: > > Patch ad608fbcf166 changed how events were subscribed to address an issue > elsewhere. As a side effect of that change, the "add" callback was called > before the event subscription was added to the list of subscribed events, > causing the

[PATCH] configure: build without BPF support in ir-keytable

It currently does not build on mips and some platforms do not have BPF support yet (risc-v, for example). Signed-off-by: Sean Young --- configure.ac | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 387f8539..4100db06 100644 ---

[GIT PULL FOR 4.20] Fix first event delivery

Hi Mauro, There turns out to have been an issue in the event subscription fix; in particular the first control event is missed due to a subtle bug in the patch. This patch fixes it. Once it's in, I'll submit the corresponding patches to the stable kernels. Please pull. The following changes

Re: [PATCH v4l-utils] Add missing linux/bpf_common.h

On Mon, Nov 05, 2018 at 09:30:47PM +0100, Peter Seiderer wrote: > Copy from [1], needed by bpf.h. > > [1] > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/plain/include/uapi/linux/bpf_common.h?h=v4.19 So bpf.h does include this file, but we don't use anything from it in

[PATCH] media: dm365_ipipeif: better annotate a fall though

Shut up this warning: drivers/staging/media/davinci_vpfe/dm365_ipipeif.c: In function 'ipipeif_hw_setup': drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:298:3: warning: this statement may fall through [-Wimplicit-fallthrough=] switch (isif_port_if) {

[PATCH v3 1/1] v4l: event: Add subscription to list before calling "add" operation

Patch ad608fbcf166 changed how events were subscribed to address an issue elsewhere. As a side effect of that change, the "add" callback was called before the event subscription was added to the list of subscribed events, causing the first event queued by the add callback (and possibly other

Re: [PATCH v3 1/1] v4l: event: Add subscription to list before calling "add" operation

On 11/06/2018 09:00 AM, Sakari Ailus wrote: > Patch ad608fbcf166 changed how events were subscribed to address an issue > elsewhere. As a side effect of that change, the "add" callback was called > before the event subscription was added to the list of subscribed events, > causing the first event

Re: [PATCH v7 05/16] intel-ipu3: abi: Add structs

Hi Raj, On Mon, Nov 05, 2018 at 07:05:53PM +, Mani, Rajmohan wrote: > Hi Sakari, > > > -Original Message- > > From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] > > Sent: Monday, November 05, 2018 12:28 AM > > To: Zhi, Yong > > Cc: linux-media@vger.kernel.org;

[RFC] Create test script(s?) for regression testing

Hi all, After the media summit (heavy on test discussions) and the V4L2 event regression we just found it is clear we need to do a better job with testing. All the pieces are in place, so what is needed is to combine it and create a script that anyone of us as core developers can run to check

Re: [RFC] Create test script(s?) for regression testing

Hi Hans, On Tue, Nov 06, 2018 at 09:37:07AM +0100, Hans Verkuil wrote: > Hi all, > > After the media summit (heavy on test discussions) and the V4L2 event > regression > we just found it is clear we need to do a better job with testing. > > All the pieces are in place, so what is needed is to

Re: [PATCH] media: dm365_ipipeif: better annotate a fall though

On 11/06/18 11:55, Mauro Carvalho Chehab wrote: > Shut up this warning: > > drivers/staging/media/davinci_vpfe/dm365_ipipeif.c: In function > 'ipipeif_hw_setup': > drivers/staging/media/davinci_vpfe/dm365_ipipeif.c:298:3: warning: this > statement may fall through

Re: [PATCH] cedrus: check if kzalloc() fails

On Tue, Nov 06, 2018 at 06:21:29AM -0500, Mauro Carvalho Chehab wrote: > As warned by static code analizer checkers: > drivers/staging/media/sunxi/cedrus/cedrus.c: > drivers/staging/media/sunxi/cedrus/cedrus.c:93 cedrus_init_ctrls() error: > potential null dereference 'ctx->ctrls'.

[PATCH] cedrus: check if kzalloc() fails

As warned by static code analizer checkers: drivers/staging/media/sunxi/cedrus/cedrus.c: drivers/staging/media/sunxi/cedrus/cedrus.c:93 cedrus_init_ctrls() error: potential null dereference 'ctx->ctrls'. (kzalloc returns null) The problem is that it assumes that kzalloc() will always

[GIT PULL for 4.20] Sensor and ISP driver patches for 4.21

Hi Mauro, Here are a few sensor and ISP driver patches for 4.21, plus a documentation fix. The noteworthy change in the sea of bugfixes is the imx214 driver. Please pull. The following changes since commit dafb7f9aef2fd44991ff1691721ff765a23be27b: v4l2-controls: add a missing include

Re: [RFC] Create test script(s?) for regression testing

On Tue, 2018-11-06 at 09:37 +0100, Hans Verkuil wrote: > Hi all, > > After the media summit (heavy on test discussions) and the V4L2 event > regression > we just found it is clear we need to do a better job with testing. > > All the pieces are in place, so what is needed is to combine it and

[PATCH] vivid: fill in media_device bus_info

If you create multiple vivid instances, each with their own media device, then there was no way to tell them apart. Fill in the bus_info so each instance has a unique bus_info string. Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/platform/vivid/vivid-core.c

[GIT PULL FOR v4.21] Convert last remaining g/s_crop/cropcap drivers

This pull request converts the last remaining drivers that use g/s_crop and cropcap to g/s_selection. The first two patches do some minor code cleanup. The third patch adds a new video_device flag to indicate that the driver inverts the normal usage of g/s_crop/cropcap. This applies to the old

Re: [PATCH 1/3] media: imx: add capture compose rectangle

Hi Philipp, On Mon, Nov 05, 2018 at 04:20:53PM +0100, Philipp Zabel wrote: > Allowing to compose captured images into larger memory buffers > will let us lift alignment restrictions on CSI crop width. > > Signed-off-by: Philipp Zabel > --- > drivers/staging/media/imx/imx-ic-prpencvf.c | 3

Re: [RFC] Create test script(s?) for regression testing

Hello, On Tuesday, 6 November 2018 13:36:55 EET Sakari Ailus wrote: > On Tue, Nov 06, 2018 at 09:37:07AM +0100, Hans Verkuil wrote: > > Hi all, > > > > After the media summit (heavy on test discussions) and the V4L2 event > > regression we just found it is clear we need to do a better job with >

Re: [RFC] Create test script(s?) for regression testing

On 11/06/18 14:12, Laurent Pinchart wrote: > Hello, > > On Tuesday, 6 November 2018 13:36:55 EET Sakari Ailus wrote: >> On Tue, Nov 06, 2018 at 09:37:07AM +0100, Hans Verkuil wrote: >>> Hi all, >>> >>> After the media summit (heavy on test discussions) and the V4L2 event >>> regression we just

Re: [PATCH 1/3] media: imx: add capture compose rectangle

Hi Sakari, On Tue, 2018-11-06 at 16:01 +0200, Sakari Ailus wrote: [...] > @@ -290,6 +294,35 @@ static int capture_s_std(struct file *file, void *fh, > v4l2_std_id std) > > return v4l2_subdev_call(priv->src_sd, video, s_std, std); > > } > > > > +static int capture_g_selection(struct file

[GIT PULL FOR v4.21] cec: add new SECO driver

This pull request adds CEC support to SECO devices, in particular UDOO X86. The pull request is identical to the v4 of this series: https://lkml.org/lkml/2018/10/21/143 Just rebased. Regards, Hans The following changes since commit fbe57dde7126d1b2712ab5ea93fb9d15f89de708: media: