Re: [PATCH] media: Use wait_queue_head_t for media_request

2018-11-09 Thread Jasmin J.
Hi! Temporary add this patch to media-build until it is integrated in mainline. This should fix the build errors for Kernels older than 4.12. BR, Jasmin

Re: [PATCH v3.16 0/2] V4L2 event subscription fixes

2018-11-09 Thread Ben Hutchings
On Thu, 2018-11-08 at 14:03 +0200, Sakari Ailus wrote: > Hi Ben, > > The two patches fix a use-after-free issue in V4L2 event handling. The > first patch that fixes that issue is already in the other stable trees (as > well as Linus's tree) whereas the second that fixes a bug in the first > one,

cron job: media_tree daily build: ERRORS

2018-11-09 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Sat Nov 10 05:00:11 CET 2018 media-tree git hash:fbe57dde7126d1b2712ab5ea93fb9d15f89de708 media_build

spca561 webcam support, broken since v4.18

2018-11-09 Thread softwarebugs
v4.17.19 is the last version it works with. Since v4.18 I cannot use it. from the lsusb output: ID 04fc:0561 Sunplus Technology Co., Ltd Flexcam 100 from the dmesg output: After a restart, after I click to make it start capturing (the bandwidth message appears only when the first capturing is

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-11-09 Thread Nicolas Dufresne
Le jeudi 08 novembre 2018 à 16:45 +0900, Tomasz Figa a écrit : > > In this patch we should consider a way to tell userspace that this has > > been opt in, otherwise existing userspace will have to remain using > > sub-optimal copy based reclaiming in order to ensure that renegotiation > > can work

[PATCH] media: Use wait_queue_head_t for media_request

2018-11-09 Thread Jasmin J.
From: Jasmin Jessich The portable type for a wait queue is wait_queue_head_t. Signed-off-by: Jasmin Jessich --- include/media/media-request.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/media/media-request.h b/include/media/media-request.h index

Re: VIVID/VIMC and media fuzzing

2018-11-09 Thread Dmitry Vyukov
On Fri, Nov 9, 2018 at 6:16 AM, Hans Verkuil wrote: > Hi Dmitry, > > On 11/02/18 18:15, Dmitry Vyukov wrote: >> On Wed, Oct 31, 2018 at 10:46 AM, Hans Verkuil wrote: >>> On 10/30/2018 03:02 PM, Dmitry Vyukov wrote: Hello Helen and linux-media, I've attended your talk "Shifting

RE: [PATCH v7 14/16] intel-ipu3: Add v4l2 driver based on media framework

2018-11-09 Thread Zhi, Yong
Hi, Sakari, Thanks for the feedback. > -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] > Sent: Friday, November 9, 2018 6:37 AM > To: Zhi, Yong > Cc: linux-media@vger.kernel.org; tf...@chromium.org; > mche...@kernel.org; hans.verk...@cisco.com; >

spca561 webcam support, broken since v4.18

2018-11-09 Thread softwarebugs
v4.17.19 is the last version it works with. Since v4.18 I cannot use it. from the lsusb output: ID 04fc:0561 Sunplus Technology Co., Ltd Flexcam 100 from the dmesg output: After a restart, after I click to make it start capturing (the bandwidth message appears only when the first capturing is

Re: [PATCH v4l-utils] Add missing linux/bpf_common.h

2018-11-09 Thread Peter Seiderer
Hello Sean, On Fri, 9 Nov 2018 12:10:38 +, Sean Young wrote: > Hi Peter, > > On Thu, Nov 08, 2018 at 10:13:38PM +0100, Peter Seiderer wrote: > > Thanks, works for the buildroot use case (disabling > > bpf support unconditionally)... > > > > The reason to provide copies of the linux kernel

Re: VIVID/VIMC and media fuzzing

2018-11-09 Thread Dmitry Vyukov
On Fri, Nov 9, 2018 at 1:17 PM, Dmitry Vyukov wrote: > On Fri, Nov 9, 2018 at 6:16 AM, Hans Verkuil wrote: >> Hi Dmitry, >> >> On 11/02/18 18:15, Dmitry Vyukov wrote: >>> On Wed, Oct 31, 2018 at 10:46 AM, Hans Verkuil wrote: On 10/30/2018 03:02 PM, Dmitry Vyukov wrote: > Hello Helen

[PATCH v4l-utils] Introduce v4l2-get-device tool

2018-11-09 Thread Ezequiel Garcia
This tool allows to find a device by driver name, this is useful for scripts to be written in a generic way. Usage: v4l2-get-device -d uvcvideo -c V4L2_CAP_VIDEO_CAPTURE /dev/video0 /dev/video2 Signed-off-by: Ezequiel Garcia --- configure.ac| 1 +

spca561 webcam support, broken since v4.18

2018-11-09 Thread softwarebugs
v4.17.19 is the last version it works with. Since v4.18 I cannot use it. from the lsusb output: ID 04fc:0561 Sunplus Technology Co., Ltd Flexcam 100 from the dmesg output: After a restart, after I click to make it start capturing (the bandwidth message appears only when the first capturing is

RE: [PATCH v7 08/16] intel-ipu3: css: Add dma buff pool utility functions

2018-11-09 Thread Zhi, Yong
Hi, Sakari, > -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] > Sent: Thursday, November 8, 2018 9:36 AM > To: Zhi, Yong > Cc: linux-media@vger.kernel.org; tf...@chromium.org; > mche...@kernel.org; hans.verk...@cisco.com; > laurent.pinch...@ideasonboard.com;

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-11-09 Thread Sakari Ailus
Hi Bing Bu, On Wed, Nov 07, 2018 at 12:16:47PM +0800, Bing Bu Cao wrote: > > On 11/01/2018 08:03 PM, Sakari Ailus wrote: > > Hi Yong, > > > > Thanks for the update! > > > > On Mon, Oct 29, 2018 at 03:22:54PM -0700, Yong Zhi wrote: > >> Hi, > >> > >> This series adds support for the Intel IPU3

[RFC PATCH 3/5] vim2m: add cookie support

2018-11-09 Thread Hans Verkuil
From: Hans Verkuil Copy cookies in vim2m. Signed-off-by: Hans Verkuil --- drivers/media/platform/vim2m.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/vim2m.c b/drivers/media/platform/vim2m.c index d82db738f174..daf83d01f1c8 100644 ---

[RFC PATCH 2/5] vb2: add cookie support

2018-11-09 Thread Hans Verkuil
From: Hans Verkuil Add support for cookies to vb2. Besides just storing and setting the cookie this patch also adds the vb2_find_cookie() function that can be used to find a buffer with the given cookie. This function will only look at DEQUEUED and DONE buffers, i.e. buffers that are already

[RFC PATCH 5/5] cedrus: add cookie support

2018-11-09 Thread Hans Verkuil
Replace old reference frame indices by new cookie method. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-ctrls.c | 9 drivers/staging/media/sunxi/cedrus/cedrus.h | 8 --- .../staging/media/sunxi/cedrus/cedrus_dec.c | 10

[RFC PATCH 4/5] vicodec: add cookie support

2018-11-09 Thread Hans Verkuil
From: Hans Verkuil Copy cookies in vicodec. Signed-off-by: Hans Verkuil --- drivers/media/platform/vicodec/vicodec-core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/vicodec/vicodec-core.c b/drivers/media/platform/vicodec/vicodec-core.c index

[RFC PATCH 1/5] videodev2.h: add cookie support

2018-11-09 Thread Hans Verkuil
From: Hans Verkuil Add support for 'cookies' to struct v4l2_buffer. These can be used to by m2m devices so userspace can set a cookie in an output buffer and this value will then be copied to the capture buffer(s). This cookie can be used to refer to capture buffers, something that is needed by

[RFC PATCH 0/5] vb2/cedrus: add cookie support

2018-11-09 Thread Hans Verkuil
As was discussed here (among other places): https://lkml.org/lkml/2018/10/19/440 using capture queue buffer indices to refer to reference frames is not a good idea. A better idea is to use 'cookies' (a better name is welcome!) where the application can assign a u64 cookie to an output buffer,

Re: [RFC PATCH 0/5] vb2/cedrus: add cookie support

2018-11-09 Thread Hans Verkuil
On 11/09/18 10:56, Hans Verkuil wrote: > As was discussed here (among other places): > > https://lkml.org/lkml/2018/10/19/440 > > using capture queue buffer indices to refer to reference frames is > not a good idea. A better idea is to use 'cookies' (a better name is > welcome!) where the

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-11-09 Thread Sakari Ailus
Hi Yong, On Fri, Nov 09, 2018 at 01:28:27AM +, Zhi, Yong wrote: > Hi, Sakari, > > Thanks for your review and comments. > Bingbu has replied to some of your questions, so I will continue with the > rest. > > > -Original Message- > > From: Bing Bu Cao

[PATCH] Revert "media: dt-bindings: Document the Rockchip VPU bindings"

2018-11-09 Thread Ezequiel Garcia
This reverts commit e4183d3256e3cd668e899d06af66da5aac3a51af. The commit was picked by mistake, as the Rockchip VPU driver is not ready for inclusion yet, and it's still under discussion. Signed-off-by: Ezequiel Garcia --- .../bindings/media/rockchip-vpu.txt | 29 ---

Re: [PATCH v5 8/9] media: uvcvideo: Rename uvc_{un,}init_video()

2018-11-09 Thread Philipp Zabel
On Wed, 2018-11-07 at 22:25 +0200, Laurent Pinchart wrote: > Hi Kieran, > > On Wednesday, 7 November 2018 16:30:46 EET Kieran Bingham wrote: > > On 06/11/2018 23:13, Laurent Pinchart wrote: > > > On Tuesday, 6 November 2018 23:27:19 EET Kieran Bingham wrote: > > > > From: Kieran Bingham > > > >

Re: [PATCH v4l-utils] Add missing linux/bpf_common.h

2018-11-09 Thread Sean Young
Hi Peter, On Thu, Nov 08, 2018 at 10:13:38PM +0100, Peter Seiderer wrote: > Thanks, works for the buildroot use case (disabling > bpf support unconditionally)... > > The reason to provide copies of the linux kernel headers in v4l-utils > is to be independent of old(-er) headers provided by

Re: [PATCH 3/3] media: imx: lift CSI width alignment restriction

2018-11-09 Thread Philipp Zabel
Hi Steve, On Thu, 2018-11-08 at 21:46 -0800, Steve Longerbeam wrote: > > diff --git a/drivers/staging/media/imx/imx-media-csi.c > > b/drivers/staging/media/imx/imx-media-csi.c > > index c4523afe7b48..d39682192a67 100644 > > --- a/drivers/staging/media/imx/imx-media-csi.c > > +++

[PATCH] vivid: free bitmap_cap when updating std/timings/etc.

2018-11-09 Thread Hans Verkuil
When vivid_update_format_cap() is called it should free any overlay bitmap since the compose size will change. Signed-off-by: Hans Verkuil Reported-by: syzbot+0cc8e3cc63ca37372...@syzkaller.appspotmail.com --- drivers/media/platform/vivid/vivid-vid-cap.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [PATCH v3 0/9] TVP5150 fixes and new features

2018-11-09 Thread Marco Felsch
Hi Mauro, I don't want to spam you. Can you give me some feedback? I know the merge window is a busy time, so maybe you have some time now. Regards, Marco On 18-10-29 19:41, Marco Felsch wrote: > Hi Mauro, > > just a reminder, Rob already added his ack/rev-by tags. > > Thanks, > Marco > > On

Re: [PATCH 2/3] media: imx: set compose rectangle to mbus format

2018-11-09 Thread Philipp Zabel
On Thu, 2018-11-08 at 21:33 -0800, Steve Longerbeam wrote: > Hi Philipp, > > On 11/5/18 7:20 AM, Philipp Zabel wrote: > > Prepare for mbus format being smaller than the written rectangle > > due to burst size. > > > > Signed-off-by: Philipp Zabel > > --- > >

Re: [PATCH v5 0/9] Asynchronous UVC

2018-11-09 Thread Kieran Bingham
Hi Laurent, On 08/11/2018 17:01, Laurent Pinchart wrote: > Hi Kieran, > > On Wednesday, 7 November 2018 01:31:29 EET Laurent Pinchart wrote: >> On Tuesday, 6 November 2018 23:27:11 EET Kieran Bingham wrote: >>> From: Kieran Bingham >>> >>> The Linux UVC driver has long provided adequate

Re: [PATCH v7 12/16] intel-ipu3: css: Initialize css hardware

2018-11-09 Thread Sakari Ailus
Hi Yong, On Mon, Oct 29, 2018 at 03:23:06PM -0700, Yong Zhi wrote: > This patch implements the functions to initialize > and configure IPU3 h/w such as clock, irq and power. > > Signed-off-by: Yong Zhi > Signed-off-by: Tomasz Figa > --- > drivers/media/pci/intel/ipu3/ipu3-css.c | 537 >

Re: [PATCH v7 14/16] intel-ipu3: Add v4l2 driver based on media framework

2018-11-09 Thread Sakari Ailus
Hi Yong, On Mon, Oct 29, 2018 at 03:23:08PM -0700, Yong Zhi wrote: > Implement video driver that utilizes v4l2, vb2 queue support > and media controller APIs. The driver exposes single > subdevice and six nodes. > > Signed-off-by: Yong Zhi > --- > drivers/media/pci/intel/ipu3/ipu3-v4l2.c |

Re: [PATCH v7 15/16] intel-ipu3: Add imgu top level pci device driver

2018-11-09 Thread Sakari Ailus
Hi Yong, On Mon, Oct 29, 2018 at 03:23:09PM -0700, Yong Zhi wrote: > This patch adds support for the Intel IPU v3 as found > on Skylake and Kaby Lake SoCs. > > The driver glues v4l2, css(camera sub system) and other > pieces together to perform its functions, it also loads > the IPU3 firmware

Re: [PATCH 1/3] media: imx: add capture compose rectangle

2018-11-09 Thread Philipp Zabel
Hi Steve, thank you for the review. On Thu, 2018-11-08 at 21:33 -0800, Steve Longerbeam wrote: [...] > > --- a/drivers/staging/media/imx/imx-media-capture.c > > +++ b/drivers/staging/media/imx/imx-media-capture.c > > @@ -262,6 +262,10 @@ static int capture_s_fmt_vid_cap(struct file *file, > >

[PATCH v6 00/10] Asynchronous UVC

2018-11-09 Thread Kieran Bingham
The Linux UVC driver has long provided adequate performance capabilities for web-cams and low data rate video devices in Linux while resolutions were low. Modern USB cameras are now capable of high data rates thanks to USB3 with 1080p, and even 4k capture resolutions supported. Cameras such as

[PATCH v6 01/10] media: uvcvideo: Refactor URB descriptors

2018-11-09 Thread Kieran Bingham
We currently store three separate arrays for each URB reference we hold. Objectify the data needed to track URBs into a single uvc_urb structure, allowing better object management and tracking of the URB. All accesses to the data pointers through stream, are converted to use a uvc_urb pointer

[PATCH v6 02/10] media: uvcvideo: Convert decode functions to use new context structure

2018-11-09 Thread Kieran Bingham
The URB completion handlers currently reference the stream context. Now that each URB has its own context structure, convert the decode (and one encode) functions to utilise this context for URB management. Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- v2: - fix checkpatch

[PATCH v6 05/10] media: uvcvideo: queue: Support asynchronous buffer handling

2018-11-09 Thread Kieran Bingham
The buffer queue interface currently operates sequentially, processing buffers after they have fully completed. In preparation for supporting parallel tasks operating on the buffers, we will need to support buffers being processed on multiple CPUs. Adapt the uvc_queue_next_buffer() such that a

[PATCH v6 04/10] media: uvcvideo: queue: Simplify spin-lock usage

2018-11-09 Thread Kieran Bingham
Both uvc_start_streaming(), and uvc_stop_streaming() are called from userspace context, with interrupts enabled. As such, they do not need to save the IRQ state, and can use spin_lock_irq() and spin_unlock_irq() respectively. Signed-off-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- v4:

Re: [PATCH v5 8/9] media: uvcvideo: Rename uvc_{un,}init_video()

2018-11-09 Thread Kieran Bingham
On 09/11/2018 15:41, Philipp Zabel wrote: > On Wed, 2018-11-07 at 22:25 +0200, Laurent Pinchart wrote: >> Hi Kieran, >> >> On Wednesday, 7 November 2018 16:30:46 EET Kieran Bingham wrote: >>> On 06/11/2018 23:13, Laurent Pinchart wrote: On Tuesday, 6 November 2018 23:27:19 EET Kieran Bingham

Hello My Beloved One

2018-11-09 Thread Aisha Gaddafi
Assalamu alaikum, I came across your e-mail contact prior a private search while in need of a trusted person. My name is Mrs. Aisha Gaddafi, a single Mother and a Widow with three Children. I am the only biological Daughter of late Libyan President (Late Colonel Muammar Gaddafi)I have a

[PATCH v6 07/10] media: uvcvideo: Move decode processing to process context

2018-11-09 Thread Kieran Bingham
Newer high definition cameras, and cameras with multiple lenses such as the range of stereo-vision cameras now available have ever increasing data rates. The inclusion of a variable length packet header in URB packets mean that we must memcpy the frame data out to our destination 'manually'. This

[PATCH v6 09/10] media: uvcvideo: Rename uvc_{un,}init_video()

2018-11-09 Thread Kieran Bingham
We have both uvc_init_video() and uvc_video_init() calls which can be quite confusing to determine the process for each. Now that video uvc_video_enable() has been renamed to uvc_video_start_streaming(), adapt these calls to suit the new flow. Rename uvc_init_video() to uvc_video_start() and

[PATCH v6 10/10] media: uvcvideo: Utilise for_each_uvc_urb iterator

2018-11-09 Thread Kieran Bingham
A new iterator is available for processing UVC URB structures. This simplifies the processing of the internal stream data. Convert the manual loop iterators to the new helper, adding an index helper to keep the existing debug print. Signed-off-by: Kieran Bingham --- v6: - rename lone 'j'

[PATCH v6 06/10] media: uvcvideo: Abstract streaming object lifetime

2018-11-09 Thread Kieran Bingham
The streaming object is a key part of handling the UVC device. Although not critical, we are currently missing a call to destroy the mutex on clean up paths, and we are due to extend the objects complexity in the near future. Facilitate easy management of a stream object by creating a pair of

[PATCH v6 08/10] media: uvcvideo: Split uvc_video_enable into two

2018-11-09 Thread Kieran Bingham
uvc_video_enable() is used both to start and stop the video stream object, however the single function entry point shares no code between the two operations. Split the function into two distinct calls, and rename to uvc_video_start_streaming() and uvc_video_stop_streaming() as appropriate.

[PATCH v6 03/10] media: uvcvideo: Protect queue internals with helper

2018-11-09 Thread Kieran Bingham
The URB completion operation obtains the current buffer by reading directly into the queue internal interface. Protect this queue abstraction by providing a helper uvc_queue_get_current_buffer() which can be used by both the decode task, and the uvc_queue_next_buffer() functions. Signed-off-by:

Re: [PATCH 3/3] media: imx: lift CSI width alignment restriction

2018-11-09 Thread Philipp Zabel
On Thu, 2018-11-08 at 21:46 -0800, Steve Longerbeam wrote: > On 11/5/18 7:20 AM, Philipp Zabel wrote: > > The CSI subdevice shouldn't have to care about IDMAC line start > > address alignment. With compose rectangle support in the capture > > driver, it doesn't have to anymore. > > > >

Re: VIVID/VIMC and media fuzzing

2018-11-09 Thread Hans Verkuil
Hi Dmitry, On 11/02/18 18:15, Dmitry Vyukov wrote: > On Wed, Oct 31, 2018 at 10:46 AM, Hans Verkuil wrote: >> On 10/30/2018 03:02 PM, Dmitry Vyukov wrote: >>> Hello Helen and linux-media, >>> >>> I've attended your talk "Shifting Media App Development into High >>> Gear" on OSS Summit last week

[GIT PULL FOR v4.21] Various fixes

2018-11-09 Thread Hans Verkuil
Various fixes, mostly related to issues found by syzbot. The following changes since commit fbe57dde7126d1b2712ab5ea93fb9d15f89de708: media: ov7740: constify structures stored in fields of v4l2_subdev_ops structure (2018-11-06 07:17:02 -0500) are available in the Git repository at:

Re: [PATCH v6 09/10] media: uvcvideo: Rename uvc_{un,}init_video()

2018-11-09 Thread Kieran Bingham
Hi Laurent, I'm sorry - I didn't update the commit message on this one. On 09/11/2018 17:05, Kieran Bingham wrote: > We have both uvc_init_video() and uvc_video_init() calls which can be > quite confusing to determine the process for each. Now that video > uvc_video_enable() has been renamed to

Re: [PATCH 3/3] media: imx: lift CSI width alignment restriction

2018-11-09 Thread Steve Longerbeam
On 11/9/18 6:50 AM, Philipp Zabel wrote: On Thu, 2018-11-08 at 21:46 -0800, Steve Longerbeam wrote: On 11/5/18 7:20 AM, Philipp Zabel wrote: The CSI subdevice shouldn't have to care about IDMAC line start address alignment. With compose rectangle support in the capture driver, it doesn't