cron job: media_tree daily build: WARNINGS

2018-11-12 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Nov 13 05:00:10 CET 2018 media-tree git hash:fbe57dde7126d1b2712ab5ea93fb9d15f89de708 media_build

Re: [PATCH v7 08/16] intel-ipu3: css: Add dma buff pool utility functions

2018-11-12 Thread Sakari Ailus
Hi Yong, On Fri, Nov 09, 2018 at 11:16:44PM +, Zhi, Yong wrote: > Hi, Sakari, > > > -Original Message- > > From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] > > Sent: Thursday, November 8, 2018 9:36 AM > > To: Zhi, Yong > > Cc: linux-media@vger.kernel.org; tf...@chromium.org;

Re: [RFC PATCH 0/5] vb2/cedrus: add cookie support

2018-11-12 Thread Hans Verkuil
On 11/12/2018 08:07 AM, Alexandre Courbot wrote: > Hi Hans, > > On Fri, Nov 9, 2018 at 6:56 PM Hans Verkuil wrote: >> >> As was discussed here (among other places): >> >> https://lkml.org/lkml/2018/10/19/440 >> >> using capture queue buffer indices to refer to reference frames is >> not a good

[PATCH] media: v4l: v4l2-controls.h must include types.h

2018-11-12 Thread Jean Delvare
Fix the following build-time warning: ./usr/include/linux/v4l2-controls.h:1105: found __[us]{8,16,32,64} type without #include Signed-off-by: Jean Delvare Fixes: c27bb30e7b6d ("media: v4l: Add definitions for MPEG-2 slice format and metadata") Cc: Paul Kocialkowski Cc: Mauro Carvalho Chehab

Re: [PATCH] media: v4l: v4l2-controls.h must include types.h

2018-11-12 Thread Paul Kocialkowski
Hi, On Mon, 2018-11-12 at 11:01 +0100, Jean Delvare wrote: > Fix the following build-time warning: > ./usr/include/linux/v4l2-controls.h:1105: found __[us]{8,16,32,64} type > without #include We already have a similar fix in the media tree:

Re: [PATCH] media: v4l: v4l2-controls.h must include types.h

2018-11-12 Thread Jean Delvare
On Mon, 2018-11-12 at 11:03 +0100, Paul Kocialkowski wrote: > On Mon, 2018-11-12 at 11:01 +0100, Jean Delvare wrote: > > Fix the following build-time warning: > > ./usr/include/linux/v4l2-controls.h:1105: found __[us]{8,16,32,64} type > > without #include > > We already have a similar fix in

[PATCH] media: venus: Support V4L2 QP parameters in Venus encoder

2018-11-12 Thread Kelvin Lawson
Support V4L2 QP parameters in Venus encoder: * V4L2_CID_MPEG_VIDEO_H264_I_FRAME_QP * V4L2_CID_MPEG_VIDEO_H264_B_FRAME_QP * V4L2_CID_MPEG_VIDEO_H264_MIN_QP * V4L2_CID_MPEG_VIDEO_H264_MAX_QP Signed-off-by: Kelvin Lawson --- drivers/media/platform/qcom/venus/venc.c | 19 +++ 1

[GIT FIXES FOR v4.20] media-request fixes

2018-11-12 Thread Hans Verkuil
Two trivial fixes: Use proper wait_queue_head_t type. Add compat ioctl. Regards, Hans The following changes since commit fbe57dde7126d1b2712ab5ea93fb9d15f89de708: media: ov7740: constify structures stored in fields of v4l2_subdev_ops structure (2018-11-06 07:17:02 -0500) are

Re: [RFC PATCHv2 0/5] vb2/cedrus: add tag support

2018-11-12 Thread Hans Verkuil
On 11/12/2018 05:32 PM, Paul Kocialkowski wrote: > Hi, > > On Mon, 2018-11-12 at 09:33 +0100, Hans Verkuil wrote: >> As was discussed here (among other places): >> >> https://lkml.org/lkml/2018/10/19/440 >> >> using capture queue buffer indices to refer to reference frames is >> not a good idea.

Re: [RFC PATCHv2 5/5] cedrus: add tag support

2018-11-12 Thread Hans Verkuil
On 11/12/2018 05:47 PM, Paul Kocialkowski wrote: > Hi, > > On Mon, 2018-11-12 at 09:33 +0100, Hans Verkuil wrote: >> Replace old reference frame indices by new tag method. > > I tested this for the cedrus driver and it works properly! > Thanks a lot for implementating this for our driver. > I

[PATCH 2/7] media: mt9m111: add V4L2_CID_COLORFX control

2018-11-12 Thread Akinobu Mita
The mt9m111 has special camera effects feature. This makes use of it through V4L2_CID_COLORFX control. Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- drivers/media/i2c/mt9m111.c | 37 - 1 file changed, 36 insertions(+), 1

[PATCH 3/7] media: ov2640: add V4L2_CID_TEST_PATTERN control

2018-11-12 Thread Akinobu Mita
The ov2640 has the test pattern generator features. This makes use of it through V4L2_CID_TEST_PATTERN control. Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- drivers/media/i2c/ov2640.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff

[PATCH 7/7] media: ov772x: support log_status ioctl and event interface

2018-11-12 Thread Akinobu Mita
This adds log_status ioctl and event interface for ov772x's v4l2 controls. Cc: Jacopo Mondi Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- drivers/media/i2c/ov772x.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[PATCH 1/7] media: mt9m111: support log_status ioctl and event interface

2018-11-12 Thread Akinobu Mita
This adds log_status ioctl and event interface for mt9m111's v4l2 controls. Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- drivers/media/i2c/mt9m111.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/mt9m111.c

[PATCH 0/7] media: i2c: small enhancements for camera sensor drivers

2018-11-12 Thread Akinobu Mita
This patchset addds relatively small enhancements (log_status ioctl, event interface, V4L2_CID_TEST_PATTERN control, and V4L2_CID_COLORFX control) for mt9m111, ov2640, ov5640, ov7670, and ov772x drivers. I have these devices so these patches are tested with real devices. Akinobu Mita (7):

Re: [RFC PATCHv2 1/5] videodev2.h: add tag support

2018-11-12 Thread Paul Kocialkowski
Hi, On Mon, 2018-11-12 at 09:33 +0100, Hans Verkuil wrote: > From: Hans Verkuil > > Add support for 'tags' to struct v4l2_buffer. These can be used > by m2m devices so userspace can set a tag for an output buffer and > this value will then be copied to the capture buffer(s). > > This tag can

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-11-12 Thread Hans Verkuil
On 11/12/2018 10:29 AM, Philipp Zabel wrote: > Hi Tomasz, > > On Sun, 2018-11-11 at 12:43 +0900, Tomasz Figa wrote: >> On Sat, Nov 10, 2018 at 6:06 AM Nicolas Dufresne >> wrote: >>> >>> Le jeudi 08 novembre 2018 à 16:45 +0900, Tomasz Figa a écrit : > In this patch we should consider a way

Re: VIVID/VIMC and media fuzzing

2018-11-12 Thread Hans Verkuil
On 11/10/2018 08:28 PM, Dmitry Vyukov wrote: > On Sat, Nov 10, 2018 at 2:01 AM, Hans Verkuil wrote: >> On 11/09/2018 10:34 PM, Dmitry Vyukov wrote: > What would be a good improvement is if you add this to the kernel command > options: > "vivid.n_devs=2 vivid.multiplanar=1,2" >

[PATCH 4/7] media: ov2640: support log_status ioctl and event interface

2018-11-12 Thread Akinobu Mita
This adds log_status ioctl and event interface for ov2640's v4l2 controls. Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- drivers/media/i2c/ov2640.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov2640.c

[PATCH 5/7] media: ov5640: support log_status ioctl and event interface

2018-11-12 Thread Akinobu Mita
This adds log_status ioctl and event interface for ov5640's v4l2 controls. Cc: Steve Longerbeam Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- drivers/media/i2c/ov5640.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[PATCH 6/7] media: ov7670: support log_status ioctl and event interface

2018-11-12 Thread Akinobu Mita
This adds log_status ioctl and event interface for ov7670's v4l2 controls. Cc: Jonathan Corbet Cc: Sakari Ailus Cc: Mauro Carvalho Chehab Signed-off-by: Akinobu Mita --- drivers/media/i2c/ov7670.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git

[RFC PATCHv2 0/5] vb2/cedrus: add tag support

2018-11-12 Thread Hans Verkuil
As was discussed here (among other places): https://lkml.org/lkml/2018/10/19/440 using capture queue buffer indices to refer to reference frames is not a good idea. A better idea is to use a 'tag' (thanks to Alexandre for the excellent name; it's much better than 'cookie') where the application

[RFC PATCHv2 5/5] cedrus: add tag support

2018-11-12 Thread Hans Verkuil
Replace old reference frame indices by new tag method. Signed-off-by: Hans Verkuil --- drivers/media/v4l2-core/v4l2-ctrls.c | 9 drivers/staging/media/sunxi/cedrus/cedrus.h | 8 --- .../staging/media/sunxi/cedrus/cedrus_dec.c | 10 +

[RFC PATCHv2 4/5] vicodec: add tag support

2018-11-12 Thread Hans Verkuil
From: Hans Verkuil Copy tags in vicodec. Signed-off-by: Hans Verkuil --- drivers/media/platform/vicodec/vicodec-core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/vicodec/vicodec-core.c b/drivers/media/platform/vicodec/vicodec-core.c index

[RFC PATCHv2 2/5] vb2: add tag support

2018-11-12 Thread Hans Verkuil
From: Hans Verkuil Add support for tags to vb2. Besides just storing and setting the tag this patch also adds the vb2_find_tag() function that can be used to find a buffer with the given tag. This function will only look at DEQUEUED and DONE buffers, i.e. buffers that are already processed.

[RFC PATCHv2 1/5] videodev2.h: add tag support

2018-11-12 Thread Hans Verkuil
From: Hans Verkuil Add support for 'tags' to struct v4l2_buffer. These can be used by m2m devices so userspace can set a tag for an output buffer and this value will then be copied to the capture buffer(s). This tag can be used to refer to capture buffers, something that is needed by stateless

[RFC PATCHv2 3/5] vim2m: add tag support

2018-11-12 Thread Hans Verkuil
From: Hans Verkuil Copy tags in vim2m. Signed-off-by: Hans Verkuil --- drivers/media/platform/vim2m.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/vim2m.c b/drivers/media/platform/vim2m.c index d82db738f174..e6ae5a9ac77e 100644 ---

Re: [RFP] Which V4L2 ioctls could be replaced by better versions?

2018-11-12 Thread Philipp Zabel
Hi Tomasz, On Sun, 2018-11-11 at 12:43 +0900, Tomasz Figa wrote: > On Sat, Nov 10, 2018 at 6:06 AM Nicolas Dufresne wrote: > > > > Le jeudi 08 novembre 2018 à 16:45 +0900, Tomasz Figa a écrit : > > > > In this patch we should consider a way to tell userspace that this has > > > > been opt in,

Inquiry 12/11/2018

2018-11-12 Thread sinara-group
Hi,friend, This is Daniel Murray and i am from Sinara Group Co.Ltd Group Co.,LTD in Russia. We are glad to know about your company from the web and we are interested in your products. Could you kindly send us your Latest catalog and price list for our trial order. Best Regards, Daniel

Price Inquiry

2018-11-12 Thread Daniel Murray
Hi,friend, This is Daniel Murray and i am from Sinara Group Co.Ltd Group Co.,LTD in Russia. We are glad to know about your company from the web and we are interested in your products. Could you kindly send us your Latest catalog and price list for our trial order. Best Regards, Daniel

Re: [RFC PATCHv2 5/5] cedrus: add tag support

2018-11-12 Thread Paul Kocialkowski
Hi, On Mon, 2018-11-12 at 09:33 +0100, Hans Verkuil wrote: > Replace old reference frame indices by new tag method. I tested this for the cedrus driver and it works properly! Thanks a lot for implementating this for our driver. I have one minor cosmetic comment below. Regarding the padding

Re: [PATCH v5 0/5] Make sure .device_run is always called in non-atomic context

2018-11-12 Thread Paul Kocialkowski
Hi, On Sun, 2018-11-11 at 18:26 -0300, Ezequiel Garcia wrote: > On Thu, 2018-10-18 at 15:02 -0300, Ezequiel Garcia wrote: > > This series goal is to avoid drivers from having ad-hoc code > > to call .device_run in non-atomic context. Currently, .device_run > > can be called via

Re: [RFC PATCHv2 0/5] vb2/cedrus: add tag support

2018-11-12 Thread Paul Kocialkowski
Hi, On Mon, 2018-11-12 at 09:33 +0100, Hans Verkuil wrote: > As was discussed here (among other places): > > https://lkml.org/lkml/2018/10/19/440 > > using capture queue buffer indices to refer to reference frames is > not a good idea. A better idea is to use a 'tag' (thanks to Alexandre > for

RE: [PATCH v7 15/16] intel-ipu3: Add imgu top level pci device driver

2018-11-12 Thread Zhi, Yong
Hi, Sakari, Thanks again for the code review. > -Original Message- > From: Sakari Ailus [mailto:sakari.ai...@linux.intel.com] > Sent: Friday, November 9, 2018 6:54 AM > To: Zhi, Yong > Cc: linux-media@vger.kernel.org; tf...@chromium.org; > mche...@kernel.org; hans.verk...@cisco.com; >

Re: VIVID/VIMC and media fuzzing

2018-11-12 Thread Dmitry Vyukov
On Mon, Nov 12, 2018 at 7:11 AM, Hans Verkuil wrote: >> What would be a good improvement is if you add this to the kernel >> command options: >> "vivid.n_devs=2 vivid.multiplanar=1,2" >> >> This will create two vivid instances, one using the single planar API >> and one

Re: [PATCH v5 0/5] Make sure .device_run is always called in non-atomic context

2018-11-12 Thread Ezequiel Garcia
On Mon, 12 Nov 2018 at 13:52, Paul Kocialkowski wrote: > > Hi, > > On Sun, 2018-11-11 at 18:26 -0300, Ezequiel Garcia wrote: > > On Thu, 2018-10-18 at 15:02 -0300, Ezequiel Garcia wrote: > > > This series goal is to avoid drivers from having ad-hoc code > > > to call .device_run in non-atomic

Re: [PATCH v5 5/5] media: cedrus: Get rid of interrupt bottom-half

2018-11-12 Thread Paul Kocialkowski
Hi, On Thu, 2018-10-18 at 15:02 -0300, Ezequiel Garcia wrote: > Now that the mem2mem framework guarantees that .device_run > won't be called from interrupt context, it is safe to call > v4l2_m2m_job_finish directly in the top-half. > > So this means the bottom-half is no longer needed and we >