[PATCH v10 4/4] media: add Rockchip VPU JPEG encoder driver

2018-11-21 Thread Ezequiel Garcia
Add a mem2mem driver for the VPU available on Rockchip SoCs. Currently only JPEG encoding is supported, for RK3399 and RK3288 platforms. Signed-off-by: Ezequiel Garcia --- MAINTAINERS | 7 + drivers/staging/media/Kconfig | 2 +

[PATCH v10 3/4] arm64: dts: rockchip: add VPU device node for RK3399

2018-11-21 Thread Ezequiel Garcia
Add the Video Processing Unit node for the RK3399 SoC. Also, fix the VPU IOMMU node, which was disabled and lacking its power domain property. Signed-off-by: Ezequiel Garcia --- arch/arm64/boot/dts/rockchip/rk3399.dtsi | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff

Re: [PATCH v8 03/12] media: staging/imx7: add imx7 CSI subdev driver

2018-11-21 Thread Sakari Ailus
Hi Rui, On Wed, Nov 21, 2018 at 11:15:49AM +, Rui Miguel Silva wrote: > This add the media entity subdevice and control driver for the i.MX7 > CMOS Sensor Interface. > > Signed-off-by: Rui Miguel Silva > --- > drivers/staging/media/imx/Kconfig |9 +- >

Re: [PATCH v8 04/12] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

2018-11-21 Thread kbuild test robot
Hi Rui, I love your patch! Perhaps something to improve: [auto build test WARNING on linuxtv-media/master] [also build test WARNING on v4.20-rc3 next-20181121] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci

[PATCH] media: staging/imx7: fix platform_no_drv_owner.cocci warnings

2018-11-21 Thread kbuild test robot
From: kbuild test robot drivers/staging/media/imx/imx7-mipi-csis.c:1125:3-8: No need to set .owner here. The core will do it. Remove .owner field if calls are used which set it automatically Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci Fixes: 181331ab8acb ("media:

Re: [PATCH v8 01/12] media: staging/imx: refactor imx media device probe

2018-11-21 Thread kbuild test robot
Hi Rui, I love your patch! Yet something to improve: [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.20-rc3 next-20181121] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH v8 05/12] media: dt-bindings: add bindings for i.MX7 media driver

2018-11-21 Thread Sakari Ailus
Hi Rui, On Wed, Nov 21, 2018 at 11:15:51AM +, Rui Miguel Silva wrote: > Add bindings documentation for i.MX7 media drivers. > The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. > > Signed-off-by: Rui Miguel Silva > Reviewed-by: Rob Herring > Acked-by: Sakari Ailus > --- >

[PATCH v10 0/4] Add Rockchip VPU JPEG encoder

2018-11-21 Thread Ezequiel Garcia
This series is based on Mauro's master branch, with the following patch applied: https://patchwork.kernel.org/patch/10676149/ Hans, If you think the driver is now ready, I'd like to merge only patches 1/4 and 4/4 (the driver per-se) via the media tree. The devicetree changes could go via

[PATCH v10 1/4] media: dt-bindings: Document the Rockchip VPU bindings

2018-11-21 Thread Ezequiel Garcia
Add devicetree binding documentation for Rockchip Video Processing Unit IP. Reviewed-by: Rob Herring Signed-off-by: Ezequiel Garcia --- .../bindings/media/rockchip-vpu.txt | 29 +++ 1 file changed, 29 insertions(+) create mode 100644

[PATCH v10 2/4] ARM: dts: rockchip: add VPU device node for RK3288

2018-11-21 Thread Ezequiel Garcia
Add the Video Processing Unit node for RK3288 SoC. Fix the VPU IOMMU node, which was disabled and lacking its power domain property. Signed-off-by: Ezequiel Garcia --- arch/arm/boot/dts/rk3288.dtsi | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git

[PATCH v8 02/12] media: staging/imx: rearrange group id to take in account IPU

2018-11-21 Thread Rui Miguel Silva
Some imx system do not have IPU, so prepare the imx media drivers to support this kind of devices. Rename the group ids to include an _IPU_ prefix, add a new group id to support systems with only a CSI without IPU, and also rename the create internal links to make it clear that only systems with

[PATCH v8 11/12] media: staging/imx: add i.MX7 entries to TODO file

2018-11-21 Thread Rui Miguel Silva
Add some i.MX7 related entries to TODO file. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/TODO | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/staging/media/imx/TODO b/drivers/staging/media/imx/TODO index aeeb15494a49..6f29b5ca5324 100644 ---

[PATCH v8 08/12] ARM: dts: imx7: Add video mux, csi and mipi_csi and connections

2018-11-21 Thread Rui Miguel Silva
This patch adds the device tree nodes for csi, video multiplexer and mipi-csi besides the graph connecting the necessary endpoints to make the media capture entities to work in imx7 Warp board. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s-warp.dts | 51

[PATCH v8 10/12] media: imx7.rst: add documentation for i.MX7 media driver

2018-11-21 Thread Rui Miguel Silva
Add rst document to describe the i.MX7 media driver and also a working example from the Warp7 board usage with a OV2680 sensor. Signed-off-by: Rui Miguel Silva --- Documentation/media/v4l-drivers/imx7.rst | 157 ++ Documentation/media/v4l-drivers/index.rst | 1 + 2 files

[PATCH v8 03/12] media: staging/imx7: add imx7 CSI subdev driver

2018-11-21 Thread Rui Miguel Silva
This add the media entity subdevice and control driver for the i.MX7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Kconfig |9 +- drivers/staging/media/imx/Makefile |2 + drivers/staging/media/imx/imx7-media-csi.c | 1352

[PATCH v2] vim2m/vicodec: set device_caps in video_device struct

2018-11-21 Thread Hans Verkuil
Instead of setting device_caps/capabilities in the querycap ioctl, set it in struct video_device instead. Signed-off-by: Hans Verkuil --- Changes in v2: vfd->device_caps was only set for the first of the two video devices. Set it for the second video_device as well. ---

[PATCH] media: ov2680: fix null dereference at power on

2018-11-21 Thread Rui Miguel Silva
Swapping the order between v4l2 subdevice registration and checking chip id in b7a417628abf ("media: ov2680: don't register the v4l2 subdevice before checking chip ID") makes the mode restore to use the sensor controls before they are set, so move the mode restore call to s_power after the

[PATCH v8 12/12] media: video-mux: add bayer formats

2018-11-21 Thread Rui Miguel Silva
Add non vendor bayer formats to the allowed format array. Signed-off-by: Rui Miguel Silva --- drivers/media/platform/video-mux.c | 20 1 file changed, 20 insertions(+) diff --git a/drivers/media/platform/video-mux.c b/drivers/media/platform/video-mux.c index

[PATCH v8 07/12] ARM: dts: imx7s: add multiplexer controls

2018-11-21 Thread Rui Miguel Silva
The IOMUXC General Purpose Register has bitfield to control video bus multiplexer to control the CSI input between the MIPI-CSI2 and parallel interface. Add that register and mask. Signed-off-by: Rui Miguel Silva Reviewed-by: Philipp Zabel --- arch/arm/boot/dts/imx7s.dtsi | 8 +++- 1 file

[PATCH v8 00/12] media: staging/imx7: add i.MX7 media driver

2018-11-21 Thread Rui Miguel Silva
Hi, This series introduces the Media driver to work with the i.MX7 SoC. it uses the already existing imx media core drivers but since the i.MX7, contrary to i.MX5/6, do not have an IPU and because of that some changes in the imx media core are made along this series to make it support that case.

[PATCH v8 06/12] ARM: dts: imx7s: add mipi phy power domain

2018-11-21 Thread Rui Miguel Silva
Add power domain index 0 related with mipi-phy to imx7s. While at it rename pcie power-domain node to remove pgc prefix. Signed-off-by: Rui Miguel Silva --- arch/arm/boot/dts/imx7s.dtsi | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/imx7s.dtsi

[PATCH v8 01/12] media: staging/imx: refactor imx media device probe

2018-11-21 Thread Rui Miguel Silva
Refactor and move media device initialization code to a new common module, so it can be used by other devices, this will allow for example a near to introduce imx7 CSI driver, to use this media device. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile| 1 +

[PATCH v8 04/12] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

2018-11-21 Thread Rui Miguel Silva
Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI CSI-2 interface. Signed-off-by: Rui Miguel Silva --- drivers/staging/media/imx/Makefile |1 + drivers/staging/media/imx/imx7-mipi-csis.c | 1134 2 files changed, 1135 insertions(+) create mode

[PATCH v8 05/12] media: dt-bindings: add bindings for i.MX7 media driver

2018-11-21 Thread Rui Miguel Silva
Add bindings documentation for i.MX7 media drivers. The imx7 MIPI CSI2 and imx7 CMOS Sensor Interface. Signed-off-by: Rui Miguel Silva Reviewed-by: Rob Herring Acked-by: Sakari Ailus --- .../devicetree/bindings/media/imx7-csi.txt| 45 ++ .../bindings/media/imx7-mipi-csi2.txt

[PATCH v8 09/12] ARM: dts: imx7s-warp: add ov2680 sensor node

2018-11-21 Thread Rui Miguel Silva
Warp7 comes with a Omnivision OV2680 sensor, add the node here to make complete the camera data path for this system. Add the needed regulator to the analog voltage supply, the port and endpoints in mipi_csi node and the pinctrl for the reset gpio. Signed-off-by: Rui Miguel Silva ---

Re: [PATCH v8 00/12] media: staging/imx7: add i.MX7 media driver

2018-11-21 Thread Hans Verkuil
On 11/21/2018 12:15 PM, Rui Miguel Silva wrote: > Hi, > This series introduces the Media driver to work with the i.MX7 SoC. it uses > the > already existing imx media core drivers but since the i.MX7, contrary to > i.MX5/6, do not have an IPU and because of that some changes in the imx media >

[GIT PULL FOR v4.21] Various fixes/improvements

2018-11-21 Thread Hans Verkuil
Note: this supersedes https://patchwork.linuxtv.org/patch/53017/. The only change is an updated device_caps patch: https://patchwork.linuxtv.org/patch/53057/ Regards, Hans The following changes since commit 5200ab6a32d6055428896a49ec9e3b1652c1a100: media: vidioc_cropcap ->

[RFCv4 PATCH 2/3] media controller: add properties support

2018-11-21 Thread Hans Verkuil
From: Hans Verkuil Add support for properties. In this initial implementation properties can be added to entities and pads. In addition, properties can be nested. Since this patch adds the topology_idx to the graph objects it is now easy to fill in the index fields in the topology to allow

[RFCv4 PATCH 1/3] uapi/linux/media.h: add property support

2018-11-21 Thread Hans Verkuil
From: Hans Verkuil Add a new topology struct that includes properties and adds index fields to quickly find references from one object to another in the topology arrays. Signed-off-by: Hans Verkuil --- include/uapi/linux/media.h | 88 -- 1 file changed, 84

[RFCv4 PATCH 3/3] vimc: add property test code

2018-11-21 Thread Hans Verkuil
From: Hans Verkuil Add properties to entities and pads to be able to test the properties API. Signed-off-by: Hans Verkuil --- drivers/media/platform/vimc/vimc-common.c | 50 +++ 1 file changed, 50 insertions(+) diff --git a/drivers/media/platform/vimc/vimc-common.c

[RFCv4 PATCH 0/3] This RFC patch series implements properties for the media controller.

2018-11-21 Thread Hans Verkuil
The main changes since RFCv3 are: - Add entity index to media_v2_pad - Add source/sink pad index to media_v2_link - Add owner_idx and owner type flags to media_v2_prop An updated v4l2-ctl and v4l2-compliance that can report properties is available here:

RE: [PATCH v1 1/1] media: atmel-isc: Add safety checks for NULL isc->raw_fmt struct

2018-11-21 Thread Ken Sloat
>> From: Ken Sloat >> >> In some usages isc->raw_fmt will not be initialized. If this is the >> case, it is very possible that a NULL struct de-reference will occur, >> as this member is referenced many times. > Hello Ken, > Do you have any confidence that just by avoiding the NULL

Re: [PATCH v9 3/3] media: add Rockchip VPU JPEG encoder driver

2018-11-21 Thread Hans Verkuil
On 11/20/2018 10:20 PM, Ezequiel Garcia wrote: > Add a mem2mem driver for the VPU available on Rockchip SoCs. > Currently only JPEG encoding is supported, for RK3399 and RK3288 > platforms. > > Signed-off-by: Ezequiel Garcia > --- > MAINTAINERS | 7 + >

[PATCH 1/1] v4l: uAPI doc: Changing frame interval won't change format

2018-11-21 Thread Sakari Ailus
Document that changing the frame interval has no effect on frame size. While this was the assumption in the API, it was not documented as such. Signed-off-by: Sakari Ailus --- Documentation/media/uapi/v4l/vidioc-g-parm.rst | 3 +++

[PATCH v2 1/2] media: video-i2c: check if chip struct has set_power function

2018-11-21 Thread Matt Ranostay
Not all future supported video chips will always have power management support, and so it is important to check before calling set_power() is defined. Signed-off-by: Matt Ranostay --- drivers/media/i2c/video-i2c.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-)

[PATCH v2 0/2] media: video-i2c: add Melexis MLX90640 thermal camera support

2018-11-21 Thread Matt Ranostay
Add initial support for Melexis line of thermal cameras. This is the first part of processing pipeline in which the real processing is done in userspace using the V4L2 camera data. Dependency patchset series: https://patchwork.kernel.org/cover/10650541/ Changes from v1: * add

[PATCH v2 2/2] media: video-i2c: add Melexis MLX90640 thermal camera support

2018-11-21 Thread Matt Ranostay
Add initial support for MLX90640 thermal cameras which output an 32x24 greyscale pixel image along with 2 rows of coefficent data. Because of this the data outputed is really 32x26 and needs the two rows removed after using the coefficent information to generate processed images in userspace.

Re: [PATCHv2 0/9] vb2/cedrus: add tag support

2018-11-21 Thread Alexandre Courbot
On Wed, Nov 14, 2018 at 10:47 PM Hans Verkuil wrote: > > From: Hans Verkuil > > As was discussed here (among other places): > > https://lkml.org/lkml/2018/10/19/440 > > using capture queue buffer indices to refer to reference frames is > not a good idea. A better idea is to use a 'tag' where the

cron job: media_tree daily build: WARNINGS

2018-11-21 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Thu Nov 22 05:00:11 CET 2018 media-tree git hash:5200ab6a32d6055428896a49ec9e3b1652c1a100 media_build

Re: is it possible to use single IOCTL to setup media pipeline?

2018-11-21 Thread Tomasz Figa
Hi Ning, On Thu, Nov 22, 2018 at 11:52 AM Zhang, Ning A wrote: > > Hello everyone > > when we need to setup media pipeline, eg, for camera capture, media-ctl > needs to be called multiple time to setup media link and subdev > formats, or similar code in a single application. this will use >

is it possible to use single IOCTL to setup media pipeline?

2018-11-21 Thread Zhang, Ning A
Hello everyone when we need to setup media pipeline, eg, for camera capture, media-ctl needs to be called multiple time to setup media link and subdev formats, or similar code in a single application. this will use multiple IOCTLs on "/dev/mediaX" and "/dev/v4l2-subdevY". to setup media