cron job: media_tree daily build: ERRORS

2018-12-03 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Tue Dec 4 05:00:13 CET 2018 media-tree git hash:9b90dc85c718443a3e573a0ccf55900ff4fa73ae media_build

[PATCH v5] media: imx: add mem2mem device

2018-12-03 Thread Philipp Zabel
Add a single imx-media mem2mem video device that uses the IPU IC PP (image converter post processing) task for scaling and colorspace conversion. On i.MX6Q/DL SoCs with two IPUs currently only the first IPU is used. The hardware only supports writing to destination buffers up to 1024x1024 pixels

[PATCH 2/3] vim2m: add buf_validate callback

2018-12-03 Thread hverkuil-cisco
From: Hans Verkuil Split off the field validation from buf_prepare into a new buf_validate function. Field validation for output buffers should be done there since buf_prepare is not guaranteed to be called at QBUF time. Signed-off-by: Hans Verkuil --- drivers/media/platform/vim2m.c | 16

[PATCH 3/3] vivid: add buf_validate callback

2018-12-03 Thread hverkuil-cisco
From: Hans Verkuil Split off the field validation from buf_prepare into a new buf_validate function. Field validation for output buffers should be done there since buf_prepare is not guaranteed to be called at QBUF time. Signed-off-by: Hans Verkuil ---

[PATCH 1/3] vb2: add buf_validate callback

2018-12-03 Thread hverkuil-cisco
From: Hans Verkuil Adding the request API uncovered a pre-existing problem with validating output buffers. The problem is that for output buffers the driver has to validate the 'field' field of struct v4l2_buffer. This is critical when encoding or deinterlacing interlaced video. Drivers always

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-12-03 Thread Sakari Ailus
Hi Laurent, On Fri, Nov 30, 2018 at 01:07:53AM +0200, Laurent Pinchart wrote: > Hello Bing, > > On Wednesday, 7 November 2018 06:16:47 EET Bing Bu Cao wrote: > > On 11/01/2018 08:03 PM, Sakari Ailus wrote: > > > On Mon, Oct 29, 2018 at 03:22:54PM -0700, Yong Zhi wrote: > > [snip] > > > >> ImgU

Re: v4l controls API

2018-12-03 Thread Hans Verkuil
On 12/03/2018 11:03 AM, Sebastian Süsens wrote: > Hey, > > I use the driver mx6s_capture kernel 4.9.88 > On the device tree it is registered with following name "fsl,imx6s-csi". Ah, that's probably the freescale driver. We don't support that. It's known to be quite buggy. Sorry, you're on your

Re: v4l controls API

2018-12-03 Thread Sebastian Süsens
Hey, I use the driver mx6s_capture kernel 4.9.88 On the device tree it is registered with following name "fsl,imx6s-csi". Hint: I have no sub-devices on my systems only /dev/video0 Sebastian Süsens Tel.

Re: [PATCH v9 04/13] media: staging/imx7: add MIPI CSI-2 receiver subdev for i.MX7

2018-12-03 Thread Sakari Ailus
Hi Rui, On Thu, Nov 22, 2018 at 03:18:25PM +, Rui Miguel Silva wrote: > Adds MIPI CSI-2 subdev for i.MX7 to connect with sensors with a MIPI > CSI-2 interface. > > Signed-off-by: Rui Miguel Silva > --- > drivers/staging/media/imx/Makefile |1 + >

Re: v4l controls API

2018-12-03 Thread Sebastian Süsens
Ok, nevertheless thank your for your reply. Sebastian Süsens Tel. +49 4321 559 56-27 mycable GmbH Fax+49 4321 559 56-10 Gartenstrasse 10 24534 Neumuenster, Germany Email

Re: [PATCH] media: unify some sony camera sensors pattern naming

2018-12-03 Thread Sakari Ailus
Hi Bing Bu, Tomasz, On Mon, Dec 03, 2018 at 10:53:34AM +0800, Bingbu Cao wrote: > > > On 12/01/2018 02:08 AM, Tomasz Figa wrote: > > Hi Bingbu, > > > > On Mon, Nov 26, 2018 at 7:56 PM wrote: > > > From: Bingbu Cao > > > > > > Some Sony camera sensors have same test pattern > > >

Re: [PATCHv2] videodev2.h: add V4L2_BUF_CAP_SUPPORTS_PREPARE_BUF/CREATE_BUFS

2018-12-03 Thread Hans Verkuil
On 11/29/2018 10:30 AM, Hans Verkuil wrote: > Add new buffer capability flags to indicate if the VIDIOC_PREPARE_BUF or > VIDIOC_CREATE_BUFS ioctls are supported. > > The reason for this is that there is currently no way for an application > to detect if VIDIOC_PREPARE_BUF is implemented other

[PATCHv3 2/9] vb2: add tag support

2018-12-03 Thread hverkuil-cisco
From: Hans Verkuil Add support for tags to vb2. Besides just storing and setting the tag this patch also adds the vb2_find_tag() function that can be used to find a buffer with the given tag. This function will only look at DEQUEUED and DONE buffers, i.e. buffers that are already processed.

[PATCHv3 3/9] v4l2-ioctl.c: log v4l2_buffer tag

2018-12-03 Thread hverkuil-cisco
From: Hans Verkuil When debugging is on, log the new tag field of struct v4l2_buffer as well. Signed-off-by: Hans Verkuil Reviewed-by: Paul Kocialkowski Reviewed-by: Alexandre Courbot --- drivers/media/v4l2-core/v4l2-ioctl.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-)

[PATCHv3 0/9] vb2/cedrus: add tag support

2018-12-03 Thread hverkuil-cisco
From: Hans Verkuil As was discussed here (among other places): https://lkml.org/lkml/2018/10/19/440 using capture queue buffer indices to refer to reference frames is not a good idea. A better idea is to use a 'tag' where the application can assign a u32 tag to an output buffer, which is then

[PATCHv3 1/9] videodev2.h: add tag support

2018-12-03 Thread hverkuil-cisco
From: Hans Verkuil Add support for 'tags' to struct v4l2_buffer. These can be used by m2m devices so userspace can set a tag for an output buffer and this value will then be copied to the capture buffer(s). This tag can be used to refer to capture buffers, something that is needed by stateless

Re: [PATCH v5] media: imx: add mem2mem device

2018-12-03 Thread Hans Verkuil
On 12/03/2018 12:48 PM, Philipp Zabel wrote: > Add a single imx-media mem2mem video device that uses the IPU IC PP > (image converter post processing) task for scaling and colorspace > conversion. > On i.MX6Q/DL SoCs with two IPUs currently only the first IPU is used. > > The hardware only

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-12-03 Thread Laurent Pinchart
Hi Sakari, On Monday, 3 December 2018 11:51:01 EET Sakari Ailus wrote: > On Fri, Nov 30, 2018 at 01:07:53AM +0200, Laurent Pinchart wrote: > > On Wednesday, 7 November 2018 06:16:47 EET Bing Bu Cao wrote: > >> On 11/01/2018 08:03 PM, Sakari Ailus wrote: > >>> On Mon, Oct 29, 2018 at 03:22:54PM

[PATCHv3 4/9] buffer.rst: document the new buffer tag feature.

2018-12-03 Thread hverkuil-cisco
From: Hans Verkuil Document V4L2_BUF_FLAG_TAG. Signed-off-by: Hans Verkuil Reviewed-by: Paul Kocialkowski Reviewed-by: Alexandre Courbot --- Documentation/media/uapi/v4l/buffer.rst | 32 ++- .../media/uapi/v4l/vidioc-reqbufs.rst | 4 +++ 2 files changed, 28

[PATCHv3 6/9] vb2: add new supports_tags queue flag

2018-12-03 Thread hverkuil-cisco
From: Hans Verkuil Add new flag to indicate that buffer tags are supported. Signed-off-by: Hans Verkuil Reviewed-by: Paul Kocialkowski Reviewed-by: Alexandre Courbot --- drivers/media/common/videobuf2/videobuf2-v4l2.c | 2 ++ include/media/videobuf2-core.h | 2 ++ 2 files

[PATCHv3 8/9] vicodec: add tag support

2018-12-03 Thread hverkuil-cisco
From: Hans Verkuil Copy tags in vicodec. Signed-off-by: Hans Verkuil Reviewed-by: Paul Kocialkowski Reviewed-by: Alexandre Courbot --- drivers/media/platform/vicodec/vicodec-core.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git

[PATCHv3 9/9] cedrus: add tag support

2018-12-03 Thread hverkuil-cisco
From: Hans Verkuil Replace old reference frame indices by new tag method. Signed-off-by: Hans Verkuil Reviewed-by: Paul Kocialkowski Reviewed-by: Alexandre Courbot --- drivers/media/v4l2-core/v4l2-ctrls.c | 9 drivers/staging/media/sunxi/cedrus/cedrus.h | 9 +---

[PATCHv3 7/9] vim2m: add tag support

2018-12-03 Thread hverkuil-cisco
From: Hans Verkuil Copy tags in vim2m. Signed-off-by: Hans Verkuil Reviewed-by: Paul Kocialkowski Reviewed-by: Alexandre Courbot --- drivers/media/platform/vim2m.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/drivers/media/platform/vim2m.c

[PATCHv3 5/9] v4l2-mem2mem: add v4l2_m2m_buf_copy_data helper function

2018-12-03 Thread hverkuil-cisco
From: Hans Verkuil Memory-to-memory devices should copy various parts of struct v4l2_buffer from the output buffer to the capture buffer. Add a helper function that does that to simplify the driver code. Signed-off-by: Hans Verkuil Reviewed-by: Paul Kocialkowski Reviewed-by: Alexandre

Re: [PATCHv3 9/9] cedrus: add tag support

2018-12-03 Thread Paul Kocialkowski
Hi, On Mon, 2018-12-03 at 14:51 +0100, hverkuil-ci...@xs4all.nl wrote: > From: Hans Verkuil > > Replace old reference frame indices by new tag method. > Signed-off-by: Hans Verkuil > Reviewed-by: Paul Kocialkowski I missed it earlier, but we should remember to update the MPEG-2 controls

Re: [PATCH 1/2] media: ov5640: Fix set format regression

2018-12-03 Thread Adam Ford
On Thu, Nov 29, 2018 at 8:48 AM Jacopo Mondi wrote: > > The set_fmt operations updates the sensor format only when the image format > is changed. When only the image sizes gets changed, the format do not get > updated causing the sensor to always report the one that was previously in > use. > >

Re: [PATCH 2/2] media: ov5640: make MIPI clock depend on mode

2018-12-03 Thread Adam Ford
On Thu, Nov 29, 2018 at 8:49 AM Jacopo Mondi wrote: > > The MIPI clock generation tree uses the MIPI_DIV divider to generate both the > MIPI SCALER CLOCK and the PIXEL_CLOCK. It seems the MIPI BIT CLK frequency is > generated by either the MIPI SCALER or the PIXEL CLOCK, depending if the >

Re: [PATCH 2/2] media: ov5640: make MIPI clock depend on mode

2018-12-03 Thread Adam Ford
On Mon, Dec 3, 2018 at 10:28 AM Adam Ford wrote: > > On Thu, Nov 29, 2018 at 8:49 AM Jacopo Mondi > wrote: > > > > The MIPI clock generation tree uses the MIPI_DIV divider to generate both > > the > > MIPI SCALER CLOCK and the PIXEL_CLOCK. It seems the MIPI BIT CLK frequency > > is > >

Re: [GIT PULL FOR v4.21] dvb fixes

2018-12-03 Thread Mauro Carvalho Chehab
Em Wed, 28 Nov 2018 19:40:30 + Sean Young escreveu: > Hi Mauro, > > So I've gone through the outstanding DVB patches and picked up the easier > ones to deal with first. Please scrutinise. Thanks! Just one note. See below. > > Thanks, > > Sean > > The following changes since commit

Re: [PATCH 2/2] media: ov5640: make MIPI clock depend on mode

2018-12-03 Thread jacopo mondi
Hi Adam, thanks for testing On Mon, Dec 03, 2018 at 10:28:04AM -0600, Adam Ford wrote: > On Thu, Nov 29, 2018 at 8:49 AM Jacopo Mondi > wrote: > > > > The MIPI clock generation tree uses the MIPI_DIV divider to generate both > > the > > MIPI SCALER CLOCK and the PIXEL_CLOCK. It seems the

[GIT FIXES FOR v4.20] seco-cec: add missing header

2018-12-03 Thread Hans Verkuil
The following changes since commit 708d75fe1c7c6e9abc5381b6fcc32b49830383d0: media: dvb-pll: don't re-validate tuner frequencies (2018-11-23 12:27:18 -0500) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git tags/br-v4.20p for you to fetch changes up to

Re: [PATCH v6 01/12] media: ov5640: Fix set format regression

2018-12-03 Thread Adam Ford
On Mon, Dec 3, 2018 at 2:45 AM Maxime Ripard wrote: > > From: Jacopo Mondi > > The set_fmt operations updates the sensor format only when the image format > is changed. When only the image sizes gets changed, the format do not get > updated causing the sensor to always report the one that was

[PATCH v6 10/12] media: ov5640: Make the FPS clamping / rounding more extendable

2018-12-03 Thread Maxime Ripard
The current code uses an algorithm to clamp the FPS values and round them to the closest supported one that isn't really allows to be extended to more than two values. Rework it a bit to make it much easier to extend the amount of FPS options we support. Signed-off-by: Maxime Ripard Tested-by:

[PATCH v6 07/12] media: ov5640: Remove pixel clock rates

2018-12-03 Thread Maxime Ripard
The pixel clock rates were introduced to report the initially static clock rate. Since this is now handled dynamically, we can remove them entirely. Signed-off-by: Maxime Ripard Tested-by: Adam Ford #imx6dq --- drivers/media/i2c/ov5640.c | 21 + 1 file changed, 1

[PATCH v6 11/12] media: ov5640: Add 60 fps support

2018-12-03 Thread Maxime Ripard
Now that we have everything in place to compute the clock rate at runtime, we can enable the 60fps framerate for the mode we tested it with. Signed-off-by: Maxime Ripard Tested-by: Adam Ford #imx6dq --- drivers/media/i2c/ov5640.c | 20 1 file changed, 16 insertions(+), 4

[PATCH v6 08/12] media: ov5640: Enhance FPS handling

2018-12-03 Thread Maxime Ripard
Now that we have moved the clock generation logic out of the bytes array, these arrays are identical between the 15fps and 30fps variants. Remove the duplicate entries, and convert the code accordingly. Signed-off-by: Maxime Ripard Tested-by: Adam Ford #imx6dq --- drivers/media/i2c/ov5640.c |

[PATCH v6 09/12] media: ov5640: Make the return rate type more explicit

2018-12-03 Thread Maxime Ripard
In the ov5640_try_frame_interval function, the ret variable actually holds the frame rate index to use, which is represented by the enum ov5640_frame_rate in the driver. Make it more obvious. Signed-off-by: Maxime Ripard Tested-by: Adam Ford #imx6dq --- drivers/media/i2c/ov5640.c | 8

[PATCH v6 03/12] media: ov5640: Remove the clocks registers initialization

2018-12-03 Thread Maxime Ripard
Part of the hardcoded initialization sequence is to set up the proper clock dividers. However, this is now done dynamically through proper code and as such, the static one is now redundant. Let's remove it. Signed-off-by: Maxime Ripard Tested-by: Adam Ford #imx6dq ---

[PATCH v6 02/12] media: ov5640: Adjust the clock based on the expected rate

2018-12-03 Thread Maxime Ripard
The clock structure for the PCLK is quite obscure in the documentation, and was hardcoded through the bytes array of each and every mode. This is troublesome, since we cannot adjust it at runtime based on other parameters (such as the number of bytes per pixel), and we can't support either

[PATCH v6 00/12] media: ov5640: Misc cleanup and improvements

2018-12-03 Thread Maxime Ripard
Hi, Here is a "small" series that mostly cleans up the ov5640 driver code, slowly getting rid of the big data array for more understandable code (hopefully). The biggest addition would be the clock rate computation at runtime, instead of relying on those arrays to setup the clock tree properly.

[PATCH v6 05/12] media: ov5640: Remove redundant register setup

2018-12-03 Thread Maxime Ripard
The MIPI divider is also cleared as part of the clock setup sequence, so we can remove that code. Signed-off-by: Maxime Ripard Tested-by: Adam Ford #imx6dq --- drivers/media/i2c/ov5640.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/drivers/media/i2c/ov5640.c

[PATCH v6 06/12] media: ov5640: Compute the clock rate at runtime

2018-12-03 Thread Maxime Ripard
The clock rate, while hardcoded until now, is actually a function of the resolution, framerate and bytes per pixel. Now that we have an algorithm to adjust our clock rate, we can select it dynamically when we change the mode. This changes a bit the clock rate being used, with the following

[PATCH v6 12/12] media: ov5640: Remove duplicate auto-exposure setup

2018-12-03 Thread Maxime Ripard
The autoexposure setup in the 1080p init array is redundant with the default value of the sensor. Remove it. Signed-off-by: Maxime Ripard Tested-by: Adam Ford #imx6dq --- drivers/media/i2c/ov5640.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov5640.c

[PATCH v6 04/12] media: ov5640: Remove redundant defines

2018-12-03 Thread Maxime Ripard
The OV5640_SCLK2X_ROOT_DIVIDER_DEFAULT and OV5640_SCLK_ROOT_DIVIDER_DEFAULT defines represent exactly the same setup, and are at the same value, than the more consistent with the rest of the driver OV5640_SCLK2X_ROOT_DIV and OV5640_SCLK_ROOT_DIV. Remove them. Signed-off-by: Maxime Ripard

[PATCH v6 01/12] media: ov5640: Fix set format regression

2018-12-03 Thread Maxime Ripard
From: Jacopo Mondi The set_fmt operations updates the sensor format only when the image format is changed. When only the image sizes gets changed, the format do not get updated causing the sensor to always report the one that was previously in use. Without this patch, updating frame size only

v4l controls API

2018-12-03 Thread Sebastian Süsens
Hello, I don't know how to get access to the v4l controls on a I2C camera sensor. My driver structure looks following: bridge driver-> csi-driver -> sensor driver (includes controls) register-async-notifer for csi driver

Re: v4l controls API

2018-12-03 Thread Hans Verkuil
On 12/03/2018 09:02 AM, Sebastian Süsens wrote: > Hello, > > I don't know how to get access to the v4l controls on a I2C camera sensor. > > My driver structure looks following: > > bridge driver-> csi-driver > -> sensor driver