Re: [PATCH dvb v1 3/4] media: dvb-usb-v2: remove __func__ from dev_dbg()

2018-12-04 Thread Victor Toso
Hi Sean, Thanks for taking time to review those patches. On Tue, Nov 27, 2018 at 10:32:44AM +, Sean Young wrote: > On Tue, Oct 30, 2018 at 05:14:50PM +0100, Victor Toso wrote: > > From: Victor Toso > > > > As dynamic debug can be instructed to add the function name to the > > debug output

Re: [PATCH 1/1] media: Use common test pattern menu entries

2018-12-04 Thread sakari . ailus
On Tue, Nov 27, 2018 at 07:19:52PM +0800, Bingbu Cao wrote: > > On 11/27/2018 05:33 PM, Sakari Ailus wrote: > > diff --git a/include/uapi/linux/v4l2-controls.h > > b/include/uapi/linux/v4l2-controls.h > > index 998983a6e6b7..a74ff6f1ac88 100644 > > --- a/include/uapi/linux/v4l2-controls.h > >

Re: [PATCH 1/1] v4l uapi: Make "Vertical Colour Bars" menu item a little more generic

2018-12-04 Thread Mauro Carvalho Chehab
Em Tue, 4 Dec 2018 12:32:32 -0200 Mauro Carvalho Chehab escreveu: > Em Tue, 4 Dec 2018 15:45:06 +0200 > Sakari Ailus escreveu: > > > The test pattern could contain a different number of colour bars than > > eight, make the entry more useful by removing "Eight " from the name. > > > >

Re: [PATCH v6 06/10] media: uvcvideo: Abstract streaming object lifetime

2018-12-04 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday, 9 November 2018 19:05:29 EET Kieran Bingham wrote: > The streaming object is a key part of handling the UVC device. Although > not critical, we are currently missing a call to destroy the mutex on > clean up paths, and we are due to extend the

Re: [PATCH v6 07/10] media: uvcvideo: Move decode processing to process context

2018-12-04 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday, 9 November 2018 19:05:30 EET Kieran Bingham wrote: > Newer high definition cameras, and cameras with multiple lenses such as > the range of stereo-vision cameras now available have ever increasing > data rates. > > The inclusion of a variable

[GIT PULL FOR v4.21] uvcvideo updates, part 2

2018-12-04 Thread Laurent Pinchart
Hi Mauro, The following changes since commit 9b90dc85c718443a3e573a0ccf55900ff4fa73ae: media: seco-cec: add missing header file to fix build (2018-12-03 15:11:00 -0500) are available in the Git repository at: git://linuxtv.org/pinchartl/media.git uvc/async for you to fetch changes up to

[PATCH 1/1] v4l uapi: Make "Vertical Colour Bars" menu item a little more generic

2018-12-04 Thread Sakari Ailus
The test pattern could contain a different number of colour bars than eight, make the entry more useful by removing "Eight " from the name. Signed-off-by: Sakari Ailus --- include/uapi/linux/v4l2-controls.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v6 08/10] media: uvcvideo: Split uvc_video_enable into two

2018-12-04 Thread Laurent Pinchart
Hi Kieran, On Sunday, 11 November 2018 00:02:39 EET Kieran Bingham wrote: > Hi Laurent, > > I see that you made changes to this patch before accepting it last time. > > I'm afraid I haven't made those changes here, so please just cherry-pick > your previous incarnation. There are no changes

Re: [PATCH v2 1/1] media: Use common test pattern menu entries

2018-12-04 Thread Mauro Carvalho Chehab
Em Tue, 4 Dec 2018 15:40:42 +0200 Sakari Ailus escreveu: > While the test pattern menu itself is not standardised, many devices > support the same test patterns. Aligning the menu entries helps the user > space to use the interface, and adding macros for the menu entry strings > helps to keep

Re: [PATCH v2] v4l2-ioctl: Zero v4l2_plane_pix_format reserved fields

2018-12-04 Thread sakari . ailus
On Tue, Nov 27, 2018 at 07:07:56PM -0300, Ezequiel Garcia wrote: > Make the core set the reserved fields to zero in > vv4l2_pix_format_mplane.4l2_plane_pix_format, > for _MPLANE queue types. > > Moving this to the core avoids having to do so in each > and every driver. > > Suggested-by: Tomasz

[PATCH v2 1/1] media: Use common test pattern menu entries

2018-12-04 Thread Sakari Ailus
While the test pattern menu itself is not standardised, many devices support the same test patterns. Aligning the menu entries helps the user space to use the interface, and adding macros for the menu entry strings helps to keep them aligned. Signed-off-by: Sakari Ailus --- since v1: - Fix

Re: [PATCH v6 09/10] media: uvcvideo: Rename uvc_{un,}init_video()

2018-12-04 Thread Laurent Pinchart
Hi Kieran, Thank you for the patch. On Friday, 9 November 2018 19:15:42 EET Kieran Bingham wrote: > Hi Laurent, > > I'm sorry - I didn't update the commit message on this one. > > On 09/11/2018 17:05, Kieran Bingham wrote: > > We have both uvc_init_video() and uvc_video_init() calls which can

Re: [PATCH 1/1] v4l uapi: Make "Vertical Colour Bars" menu item a little more generic

2018-12-04 Thread Mauro Carvalho Chehab
Em Tue, 4 Dec 2018 15:45:06 +0200 Sakari Ailus escreveu: > The test pattern could contain a different number of colour bars than > eight, make the entry more useful by removing "Eight " from the name. > > Signed-off-by: Sakari Ailus > --- > include/uapi/linux/v4l2-controls.h | 2 +- > 1 file

RE: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-12-04 Thread Mani, Rajmohan
Hi Laurent, > -Original Message- > From: Laurent Pinchart [mailto:laurent.pinch...@ideasonboard.com] > Sent: Tuesday, December 04, 2018 8:42 AM > To: Mani, Rajmohan > Cc: Tomasz Figa ; Zhi, Yong ; > Linux Media Mailing List ; Sakari Ailus > ; Mauro Carvalho Chehab > ; Hans Verkuil ;

Re: [PATCH 1/4] media: lmedm04: Add missing usb_free_urb to free, interrupt urb

2018-12-04 Thread Sean Young
On Thu, Nov 29, 2018 at 10:29:31PM +, Malcolm Priestley wrote: > The interrupt urb is killed but never freed add the function > > Cc: sta...@vger.kernel.org > Signed-off-by: Malcolm Priestley > --- > drivers/media/usb/dvb-usb-v2/lmedm04.c | 1 + > 1 file changed, 1 insertion(+) > > diff

Re: [PATCH 3/4] media: lmedm04: Move interrupt buffer to priv buffer.

2018-12-04 Thread Sean Young
On Thu, Nov 29, 2018 at 10:30:15PM +, Malcolm Priestley wrote: > Interrupt is always present throught life time of > there is no dma element move this buffer to private > area of driver. > > Signed-off-by: Malcolm Priestley > --- > drivers/media/usb/dvb-usb-v2/lmedm04.c | 26

RE: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-12-04 Thread Mani, Rajmohan
Hi Laurent, Tomasz, > > Thanks for the reviews. > > > Subject: Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset > > > > Hi Tomasz, > > > > On Thursday, 29 November 2018 21:51:32 EET Tomasz Figa wrote: > > > On Thu, Nov 29, 2018 at 6:43 AM Laurent Pinchart wrote: > > > > On Tuesday, 30 October 2018

Greetings...

2018-12-04 Thread Karen Post Office
Get back to us, it is highly important. Mr.Ahmed Yaki

Re: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-12-04 Thread Laurent Pinchart
Hi Rajmohan, On Tuesday, 4 December 2018 18:07:16 EET Mani, Rajmohan wrote: > >> On Thursday, 29 November 2018 21:51:32 EET Tomasz Figa wrote: > >>> On Thu, Nov 29, 2018 at 6:43 AM Laurent Pinchart wrote: > On Tuesday, 30 October 2018 00:22:54 EET Yong Zhi wrote: > >> > >> [snip] > >> >

[PATCH] media: vicodec: Change variable names

2018-12-04 Thread Dafna Hirschfeld
Change variables names in vicodec-core.c to *_src *_dst to improve readability Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vicodec/vicodec-core.c | 94 ++- 1 file changed, 48 insertions(+), 46 deletions(-) diff --git

Re: [PATCH] Add ir-rcmm-driver

2018-12-04 Thread patrick9876
We have so many decoders at the linux kernel level now. I'm not sure of the best option. Patrick. On 04/12/2018 21:57, Sean Young wrote: On Tue, Dec 04, 2018 at 09:20:25PM +0100, patrick9...@free.fr wrote: From: Patrick LERDA --- drivers/media/rc/Kconfig | 10 ++

Re: [PATCH] Add ir-rcmm-driver

2018-12-04 Thread patrick9876
The toggle flag is well handled with this code and at the kernel level; This adds reliability. Patrick. On 04/12/2018 22:06, patrick9...@free.fr wrote: We have so many decoders at the linux kernel level now. I'm not sure of the best option. Patrick. On 04/12/2018 21:57, Sean Young wrote:

[PATCH] Add ir-rcmm-driver

2018-12-04 Thread patrick9876
From: Patrick LERDA --- drivers/media/rc/Kconfig | 10 ++ drivers/media/rc/Makefile | 1 + drivers/media/rc/ir-rcmm-decoder.c | 185 + drivers/media/rc/rc-core-priv.h| 5 + drivers/media/rc/rc-main.c | 3 + include/media/rc-map.h

[PATCH] Add ir-rcmm-driver

2018-12-04 Thread patrick9876
Add support for RCMM infrared remote controls.

Re: [PATCH] Add ir-rcmm-driver

2018-12-04 Thread Sean Young
On Tue, Dec 04, 2018 at 09:20:25PM +0100, patrick9...@free.fr wrote: > From: Patrick LERDA > > --- > drivers/media/rc/Kconfig | 10 ++ > drivers/media/rc/Makefile | 1 + > drivers/media/rc/ir-rcmm-decoder.c | 185 + >

[ragnatech:media-tree] BUILD INCOMPLETE 9b90dc85c718443a3e573a0ccf55900ff4fa73ae

2018-12-04 Thread kbuild test robot
tree/branch: git://git.ragnatech.se/linux media-tree branch HEAD: 9b90dc85c718443a3e573a0ccf55900ff4fa73ae media: seco-cec: add missing header file to fix build TIMEOUT after 1554m Sorry we cannot finish the testset for your branch within a reasonable time. It's our fault -- either some

[PATCHv2] Add ir-rcmm-driver

2018-12-04 Thread patrick9876
Fix typo RC_PROTO_BIT_RCMM issue.

[PATCH] [PATCHv2] Add ir-rcmm-driver

2018-12-04 Thread patrick9876
From: Patrick LERDA --- drivers/media/rc/Kconfig | 10 ++ drivers/media/rc/Makefile | 1 + drivers/media/rc/ir-rcmm-decoder.c | 185 + drivers/media/rc/rc-core-priv.h| 5 + drivers/media/rc/rc-main.c | 3 + include/media/rc-map.h

Re: [PATCH v5] media: imx: add mem2mem device

2018-12-04 Thread Steve Longerbeam
Hi Hans, Philipp, One comment on my side... On 12/3/18 7:21 AM, Hans Verkuil wrote: +void imx_media_mem2mem_device_unregister(struct imx_media_video_dev *vdev) +{ + struct mem2mem_priv *priv = to_mem2mem_priv(vdev); + struct video_device *vfd = priv->vdev.vfd; + +

RE: [PATCH v7 00/16] Intel IPU3 ImgU patchset

2018-12-04 Thread Mani, Rajmohan
Hi Laurent, > > Hi Rajmohan, > > > > On Tuesday, 4 December 2018 18:07:16 EET Mani, Rajmohan wrote: > > > >> On Thursday, 29 November 2018 21:51:32 EET Tomasz Figa wrote: > > > >>> On Thu, Nov 29, 2018 at 6:43 AM Laurent Pinchart wrote: > > > On Tuesday, 30 October 2018 00:22:54 EET Yong Zhi

[GIT PULL FOR v4.21] more dvb fixes

2018-12-04 Thread Sean Young
Hi Mauro, I think these are the all the outstanding dvb patches for the kernel. Thanks, Sean The following changes since commit 9b90dc85c718443a3e573a0ccf55900ff4fa73ae: media: seco-cec: add missing header file to fix build (2018-12-03 15:11:00 -0500) are available in the Git repository

cron job: media_tree daily build: ERRORS

2018-12-04 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Wed Dec 5 05:00:10 CET 2018 media-tree git hash:9b90dc85c718443a3e573a0ccf55900ff4fa73ae media_build