Re: [PATCH 1/2]: media: hdpvr: Add adaptive sleeping in hdpvr_start_streaming

2019-07-25 Thread Hans Verkuil
On 7/7/19 11:15 PM, Keith Pyle wrote: > The hdpvr firmware reacts poorly to a fast close/open sequence. Delaying > a few seconds between the close and next open produces generally reliable > results. Rather than requiring user programs to implement this delay and > coordinate among themselves whe

Re: [PATCH 2/2]: media: hdpvr: Add optional restart, with optional delay, after restarting streaming

2019-07-25 Thread Hans Verkuil
On 7/7/19 11:16 PM, Keith Pyle wrote: > `hdpvr_read` attempts to restart streaming if the device is read while > it is both not ready and not disconnected. However, the device is often > still not ready immediately after the call to `hdpvr_start_streaming` > returns, causing the condition `if (buf

[PATCH] media: staging: davinci: remove vpfe driver

2019-07-25 Thread Arnd Bergmann
The davinci_vpfe driver was merged into staging back in 2012 by Manjunath Hadli from TI, with a long TODO list. For all I can tell, since then it has only seen fixes for compile-time issues and global cleanups, but nobody has actually worked on the items on the TODO list. To make things worse, th

[PATCH] vivid: fix typo: use -> user

2019-07-25 Thread Hans Verkuil
Fix typo in two comments. Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/platform/vivid/vivid-core.c b/drivers/media/platform/vivid/vivid-core.c index bc2a176937a4..8e1ebc94943e 100644 --- a/drivers/media/platform/vivid/vivid-core.c +++ b/drivers/media/platform/vivid/vivid-core.c @@

[GIT PULL FOR v5.4] Various fixes, removal of davince_vpfe, bcm2048

2019-07-25 Thread Hans Verkuil
The following changes since commit e2727ec58c113c2c95cbb75f6a129bd1fa0bf761: media: vimc.rst: add vimc-streamer source documentation (2019-07-23 11:55:00 -0400) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.4d for you to fetch changes up to 73

Re: kernel Warning when using vivid with contiguous dma

2019-07-25 Thread Dafna Hirschfeld
On Tue, 2019-07-23 at 14:05 +, Hans Verkuil (hansverk) wrote: > On 7/23/19 3:14 PM, Dafna Hirschfeld wrote: > > On Mon, 2019-07-22 at 08:38 -0300, Mauro Carvalho Chehab wrote: > > > Em Mon, 22 Jul 2019 13:21:00 +0200 > > > Dafna Hirschfeld escreveu: > > > > > > > I loaded the vivid module wit

[GIT PULL for 5.4] V4L2 ISP, fwnode, sensor and CSI2 patches

2019-07-25 Thread Sakari Ailus
Hi Mauro, Here's my first set of V4L2 patches for 5.4. Included are sensor driver patches, but also update for the Cadence CSI2TX driver and odd fixes and cleanups. No new drivers this time. Please pull. The following changes since commit ebe15c7679680308268b99d911b1db15d514c7b8: media: tegr

Re: [PATCH] media: imx7.rst: Fix the references to the CSI multiplexer

2019-07-25 Thread Mauro Carvalho Chehab
Em Sat, 29 Jun 2019 09:16:23 -0300 Fabio Estevam escreveu: > In imx7s.dtsi the node name for the CSI multiplexer is "csi-mux", not > "csi_mux", so fix all the references in the document. > > This fixes the following error when the instructions are followed: > > # media-ctl -l "'imx7-mipi-csis.0

Re: [GIT PULL for 5.4] V4L2 ISP, fwnode, sensor and CSI2 patches

2019-07-25 Thread Mauro Carvalho Chehab
Em Thu, 25 Jul 2019 12:50:30 +0300 Sakari Ailus escreveu: > Hi Mauro, > > Here's my first set of V4L2 patches for 5.4. Included are sensor driver > patches, but also update for the Cadence CSI2TX driver and odd fixes and > cleanups. No new drivers this time. > > Please pull. > > > The followi

Re: [GIT PULL for 5.4] V4L2 ISP, fwnode, sensor and CSI2 patches

2019-07-25 Thread Sakari Ailus
On Thu, Jul 25, 2019 at 07:47:14AM -0300, Mauro Carvalho Chehab wrote: > Em Thu, 25 Jul 2019 12:50:30 +0300 > Sakari Ailus escreveu: > > > Hi Mauro, > > > > Here's my first set of V4L2 patches for 5.4. Included are sensor driver > > patches, but also update for the Cadence CSI2TX driver and odd

[GIT PULL for 5.4] V4L2 fwnode parsing improvements

2019-07-25 Thread Sakari Ailus
Hi Mauro, This set contains the V4L2 fwnode parsing improvements that have had lengthy reviews on the list. Please pull. The following changes since commit ebe15c7679680308268b99d911b1db15d514c7b8: media: tegra-cec: use cec_notifier_cec_adap_(un)register (2019-07-23 08:40:57 -0400) are ava

Re: [PATCH v2] staging: media: sunxi: Add bool cast to value

2019-07-25 Thread Hans Verkuil
On 7/22/19 8:06 AM, Nishka Dasgupta wrote: > Typecast as bool the return value of cedrus_find_format in > cedrus_check_format as the return value of cedrus_check_format is always > treated like a boolean value. > > Signed-off-by: Nishka Dasgupta > --- > Changes in v2: > - Add !! to the returned p

[PATCH] v4l2-dev: fix WARN_ON(!vdev->device_caps)

2019-07-25 Thread Hans Verkuil
Device nodes of type VFL_TYPE_SUBDEV have a 0 device_caps, so they trigger this warning. Add a check against VFL_TYPE_SUBDEV. Signed-off-by: Hans Verkuil Fixes: 3c1350501c21 ("media: v4l2-dev/ioctl: require non-zero device_caps, verify sane querycap results") Reported-by: Jan Kotas --- diff --g

Re: [PATCH] media: imx7.rst: Fix the references to the CSI multiplexer

2019-07-25 Thread Fabio Estevam
Hi Mauro, On Thu, Jul 25, 2019 at 7:41 AM Mauro Carvalho Chehab wrote: > Did you check the "make htmldocs" output after this change? > > This code-block is broken, as it starts from column 1. > > Please add a tab (or at least 2 spaces) before each line, in order > to make Sphinx process this cod

[PATCH] uvc: don't set description in ENUM_FMT

2019-07-25 Thread Hans Verkuil
Leave it to the V4L2 core to set the description. In fact, that was already the case for a long time since v4l_fill_fmtdesc() overwrites the description. So remove all description strings from the driver. uvc_ioctl_enum_fmt() was also cleaned up a bit since zeroed the v4l2_fmtdesc struct, when al

Re: [PATCH 0/6] V4L2 core I2C/SPI code cleanup

2019-07-25 Thread Hans Verkuil
On 7/15/19 11:06 PM, Ezequiel Garcia wrote: > Hi Mauro, Hans: > > While reading v4l2-common.c, I came across a few ifdefs > that could be cleaned-up with some minor reorganization. > > Patch 1 is just cleaning the Makefile, removing ifeq/endif > to make it more readable. > > Patch 2 merges v4l2-

[GIT PULL FOR v5.4] Support RK3399 VP8 decoding, various fixes, rcar-vin improvements

2019-07-25 Thread Hans Verkuil
Hi Mauro, Please note the 'v4l2-dev: fix WARN_ON(!vdev->device_caps)' patch. Sorry about that. I did test the original patch with vimc, but test-media doesn't actually create a FAIL if a module can't be loaded. I'll fix that. Other than that it's the usual fixes/cleanups and also it adds RK3399 V

Re: [PATCH 2/2] media: Don't hide any menu if "ancillary drivers autoselect" is enabled

2019-07-25 Thread Mauro Carvalho Chehab
Em Mon, 15 Jul 2019 18:23:16 -0300 Ezequiel Garcia escreveu: > Many users have been complaining about not being able to find > certain menu options. One such example are camera sensor drivers > (e.g IMX219, OV5645, etc) which are common on embedded platforms > and not always ancillary devices. >

Re: [PATCH 2/2] media: Don't hide any menu if "ancillary drivers autoselect" is enabled

2019-07-25 Thread Hans Verkuil
On 7/25/19 5:57 PM, Mauro Carvalho Chehab wrote: > Em Mon, 15 Jul 2019 18:23:16 -0300 > Ezequiel Garcia escreveu: > >> Many users have been complaining about not being able to find >> certain menu options. One such example are camera sensor drivers >> (e.g IMX219, OV5645, etc) which are common on

[PATCH] media: staging: hantro: avoid future namespace collisions

2019-07-25 Thread Mauro Carvalho Chehab
Rename: vp8_dec_mc_filter -> hantro_vp8_dec_mc_filter As other drivers may end implementing something with the same name. So, prepend driver's name here, in order to make symbol namespace cleaner. Signed-off-by: Mauro Carvalho Chehab --- drivers/staging/media/hantro/hantro_g1_vp8_dec.c

Re: [PATCH 2/6] media: v4l2-core: Module re-organization

2019-07-25 Thread Mauro Carvalho Chehab
Em Mon, 15 Jul 2019 18:06:43 -0300 Ezequiel Garcia escreveu: > videodev.ko and v4l2-common.ko driver are built under > the same conditions. Therefore, it doesn't make much sense > to split them in two different modules. > > Splitting v4l2-common to its own driver has done many > years ago: > >

Re: [GIT PULL FOR v5.4] Support RK3399 VP8 decoding, various fixes, rcar-vin improvements

2019-07-25 Thread Mauro Carvalho Chehab
Em Thu, 25 Jul 2019 17:33:47 +0200 Hans Verkuil escreveu: > Hi Mauro, > > Please note the 'v4l2-dev: fix WARN_ON(!vdev->device_caps)' patch. Sorry about > that. I did test the original patch with vimc, but test-media doesn't actually > create a FAIL if a module can't be loaded. I'll fix that. >

Re: [PATCH 2/6] media: v4l2-core: Module re-organization

2019-07-25 Thread Ezequiel Garcia
On Thu, 2019-07-25 at 13:31 -0300, Mauro Carvalho Chehab wrote: > Em Mon, 15 Jul 2019 18:06:43 -0300 > Ezequiel Garcia escreveu: > > > videodev.ko and v4l2-common.ko driver are built under > > the same conditions. Therefore, it doesn't make much sense > > to split them in two different modules. >

Re: [PATCH 2/6] media: v4l2-core: Module re-organization

2019-07-25 Thread Mauro Carvalho Chehab
Em Thu, 25 Jul 2019 13:41:34 -0300 Ezequiel Garcia escreveu: > On Thu, 2019-07-25 at 13:31 -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 15 Jul 2019 18:06:43 -0300 > > Ezequiel Garcia escreveu: > > > > > videodev.ko and v4l2-common.ko driver are built under > > > the same conditions. Theref

Re: [PATCH 2/2] media: Don't hide any menu if "ancillary drivers autoselect" is enabled

2019-07-25 Thread Ezequiel Garcia
On Thu, 2019-07-25 at 12:57 -0300, Mauro Carvalho Chehab wrote: > Em Mon, 15 Jul 2019 18:23:16 -0300 > Ezequiel Garcia escreveu: > > > Many users have been complaining about not being able to find > > certain menu options. One such example are camera sensor drivers > > (e.g IMX219, OV5645, etc) w

Re: [PATCH 2/6] media: v4l2-core: Module re-organization

2019-07-25 Thread Ezequiel Garcia
On Thu, 2019-07-25 at 14:03 -0300, Mauro Carvalho Chehab wrote: > Em Thu, 25 Jul 2019 13:41:34 -0300 > Ezequiel Garcia escreveu: > > > On Thu, 2019-07-25 at 13:31 -0300, Mauro Carvalho Chehab wrote: > > > Em Mon, 15 Jul 2019 18:06:43 -0300 > > > Ezequiel Garcia escreveu: > > > > > > > videode

Re: kernel Warning when using vivid with contiguous dma

2019-07-25 Thread Nicolin Chen
Allow me to trim the message a bit. On Thu, Jul 25, 2019 at 11:27:45AM +0200, Dafna Hirschfeld wrote: > > > [   70.219867] cma: cma_alloc(cma (ptrval), count 4050, > > > align 8) > > > [   70.237878] cma: cma_alloc: alloc failed, req-size: 4050 pages, > > > ret: -12 It shows that cma_all

Re: [PATCH 2/2] media: Don't hide any menu if "ancillary drivers autoselect" is enabled

2019-07-25 Thread Chen-Yu Tsai
On Fri, Jul 26, 2019 at 1:06 AM Ezequiel Garcia wrote: > > On Thu, 2019-07-25 at 12:57 -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 15 Jul 2019 18:23:16 -0300 > > Ezequiel Garcia escreveu: > > > > > Many users have been complaining about not being able to find > > > certain menu options. One s

Re: [PATCH 2/2] media: Don't hide any menu if "ancillary drivers autoselect" is enabled

2019-07-25 Thread Mauro Carvalho Chehab
Em Thu, 25 Jul 2019 14:05:58 -0300 Ezequiel Garcia escreveu: > On Thu, 2019-07-25 at 12:57 -0300, Mauro Carvalho Chehab wrote: > > Em Mon, 15 Jul 2019 18:23:16 -0300 > > Ezequiel Garcia escreveu: > > > > > Many users have been complaining about not being able to find > > > certain menu option

Re: [PATCH 2/2] media: Don't hide any menu if "ancillary drivers autoselect" is enabled

2019-07-25 Thread Mauro Carvalho Chehab
Em Fri, 26 Jul 2019 01:29:58 +0800 Chen-Yu Tsai escreveu: > On Fri, Jul 26, 2019 at 1:06 AM Ezequiel Garcia > wrote: > > > > On Thu, 2019-07-25 at 12:57 -0300, Mauro Carvalho Chehab wrote: > > > Em Mon, 15 Jul 2019 18:23:16 -0300 > > > Ezequiel Garcia escreveu: > > > > > > > Many users hav

Re: [PATCH 2/2] media: Don't hide any menu if "ancillary drivers autoselect" is enabled

2019-07-25 Thread Helen Koike
On 7/25/19 3:41 PM, Mauro Carvalho Chehab wrote: > Em Fri, 26 Jul 2019 01:29:58 +0800 > Chen-Yu Tsai escreveu: > >> On Fri, Jul 26, 2019 at 1:06 AM Ezequiel Garcia >> wrote: >>> >>> On Thu, 2019-07-25 at 12:57 -0300, Mauro Carvalho Chehab wrote: Em Mon, 15 Jul 2019 18:23:16 -0300

Re: [PATCH 2/2] media: Don't hide any menu if "ancillary drivers autoselect" is enabled

2019-07-25 Thread Mauro Carvalho Chehab
Em Thu, 25 Jul 2019 16:00:02 -0300 Helen Koike escreveu: > On 7/25/19 3:41 PM, Mauro Carvalho Chehab wrote: > > Em Fri, 26 Jul 2019 01:29:58 +0800 > > Chen-Yu Tsai escreveu: > > > >> On Fri, Jul 26, 2019 at 1:06 AM Ezequiel Garcia > >> wrote: > >>> > >>> On Thu, 2019-07-25 at 12:57 -0300,

Re: [PATCH v3 2/3] media: uapi: h264: Add the concept of decoding mode

2019-07-25 Thread Paul Kocialkowski
Hi, On Wed 03 Jul 19, 14:28, Boris Brezillon wrote: > @@ -125,6 +134,10 @@ struct v4l2_h264_pred_weight_table { > struct v4l2_ctrl_h264_slice_params { > /* Size in bytes, including header */ > __u32 size; > + > + /* Where the slice starts in the output buffer (expressed in bytes).

Re: [PATCH v3 1/3] media: uapi: h264: Clarify our expectations regarding NAL header format

2019-07-25 Thread Paul Kocialkowski
Hi, On Wed 03 Jul 19, 14:28, Boris Brezillon wrote: > Looks like some stateless decoders expect slices to be prefixed with > ANNEX B start codes (they most likely do some kind of bitstream parsing > and/or need that to delimit slices when doing per frame decoding). > Since skipping those start cod

Re: [PATCH v3 1/3] media: uapi: h264: Clarify our expectations regarding NAL header format

2019-07-25 Thread Paul Kocialkowski
Hi, On Thu 25 Jul 19, 08:42, Boris Brezillon wrote: > On Fri, 5 Jul 2019 19:16:18 +0200 > Boris Brezillon wrote: > > > On Fri, 05 Jul 2019 13:40:03 -0300 > > Ezequiel Garcia wrote: > > > > > Hi Boris, Paul, > > > > > > On Wed, 2019-07-03 at 14:28 +0200, Boris Brezillon wrote: > > > > Looks

Re: [PATCH v3 3/3] media: uapi: h264: Get rid of the p0/b0/b1 ref-lists

2019-07-25 Thread Paul Kocialkowski
Hi, On Wed 24 Jul 19, 07:46, Boris Brezillon wrote: > On Wed, 24 Jul 2019 12:39:55 +0900 > Tomasz Figa wrote: > > > Hi Boris, > > > > On Wed, Jul 3, 2019 at 9:28 PM Boris Brezillon > > wrote: > > > > > > Those lists can be extracted from the dpb, let's simplify userspace > > > life and build t

Re: kernel Warning when using vivid with contiguous dma

2019-07-25 Thread Nicolin Chen
Just an update here: After looking at the code and the logs here, submitted a fix: https://lkml.org/lkml/2019/7/25/1432 I only added Dafna in the To-list but anyone is interested can find it in the maillist. Thanks Nicolin On Thu, Jul 25, 2019 at 11:27:45AM +0200, Dafna Hirschfeld wrote: > On T

Re: [PATCH 2/2] media: Don't hide any menu if "ancillary drivers autoselect" is enabled

2019-07-25 Thread Ezequiel Garcia
On Thu, 2019-07-25 at 15:41 -0300, Mauro Carvalho Chehab wrote: > Em Fri, 26 Jul 2019 01:29:58 +0800 > Chen-Yu Tsai escreveu: > > > On Fri, Jul 26, 2019 at 1:06 AM Ezequiel Garcia > > wrote: > > > On Thu, 2019-07-25 at 12:57 -0300, Mauro Carvalho Chehab wrote: > > > > Em Mon, 15 Jul 2019 18:2

[ras:edac-for-next] BUILD SUCCESS 3123c5c4ca157edc518102ee5385f60cb90f93f5

2019-07-25 Thread kbuild test robot
tree/branch: https://kernel.googlesource.com/pub/scm/linux/kernel/git/ras/ras.git edac-for-next branch HEAD: 3123c5c4ca157edc518102ee5385f60cb90f93f5 edac: altera: Move Stratix10 SDRAM ECC to peripheral elapsed time: 353m configs tested: 150 The following configs have been built successfull

Re: [PATCH 2/2] media: Don't hide any menu if "ancillary drivers autoselect" is enabled

2019-07-25 Thread Mauro Carvalho Chehab
Em Thu, 25 Jul 2019 20:55:13 -0300 Ezequiel Garcia escreveu: > On Thu, 2019-07-25 at 15:41 -0300, Mauro Carvalho Chehab wrote: > > Em Fri, 26 Jul 2019 01:29:58 +0800 > > Chen-Yu Tsai escreveu: > > > > > On Fri, Jul 26, 2019 at 1:06 AM Ezequiel Garcia > > > wrote: > > > > On Thu, 2019-07-2

Re: [PATCH v3 1/3] media: uapi: h264: Clarify our expectations regarding NAL header format

2019-07-25 Thread Ezequiel Garcia
On Thu, 2019-07-25 at 21:36 +0200, Paul Kocialkowski wrote: > Hi, > > On Thu 25 Jul 19, 08:42, Boris Brezillon wrote: > > On Fri, 5 Jul 2019 19:16:18 +0200 > > Boris Brezillon wrote: > > > > > On Fri, 05 Jul 2019 13:40:03 -0300 > > > Ezequiel Garcia wrote: > > > > > > > Hi Boris, Paul, > > > >

Re: [PATCH 2/2] media: Don't hide any menu if "ancillary drivers autoselect" is enabled

2019-07-25 Thread Ezequiel Garcia
On Thu, 2019-07-25 at 23:09 -0300, Mauro Carvalho Chehab wrote: > Em Thu, 25 Jul 2019 20:55:13 -0300 > Ezequiel Garcia escreveu: > > > On Thu, 2019-07-25 at 15:41 -0300, Mauro Carvalho Chehab wrote: > > > Em Fri, 26 Jul 2019 01:29:58 +0800 > > > Chen-Yu Tsai escreveu: > > > > > > > On Fri, Ju

cron job: media_tree daily build: ERRORS

2019-07-25 Thread Hans Verkuil
This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Jul 26 05:00:10 CEST 2019 media-tree git hash:a8f910ec66583bfb61558c3f333195b3960d832d media_build gi

Re: [PATCH v3 1/3] media: uapi: h264: Clarify our expectations regarding NAL header format

2019-07-25 Thread Boris Brezillon
On Thu, 25 Jul 2019 23:39:11 -0300 Ezequiel Garcia wrote: > On Thu, 2019-07-25 at 21:36 +0200, Paul Kocialkowski wrote: > > Hi, > > > > On Thu 25 Jul 19, 08:42, Boris Brezillon wrote: > > > On Fri, 5 Jul 2019 19:16:18 +0200 > > > Boris Brezillon wrote: > > > > > > > On Fri, 05 Jul 2019 13: