[PATCH] v4l2-compliance: fix metadata output support

This patch fixes test failure in the v4l2-compliance for metadata output support. Signed-off-by: Vandana BN --- utils/v4l2-compliance/v4l2-compliance.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/utils/v4l2-compliance/v4l2-compliance.cpp b/utils/v4l2-compliance/v4l2-

[PATCH] v4l2-ctl: support for metadata output

Adds support to test metadata output format V4L2_META_FMT_VIVID. Signed-off-by: Vandana BN --- contrib/freebsd/include/linux/videodev2.h | 1 + include/linux/videodev2.h | 1 + utils/v4l2-ctl/v4l2-ctl-meta.cpp | 31 +++ utils/v4l2-ctl/v4l2-ctl-strea

[PATCH 2/2] vivid: Add metadata output support

Support metadata output in vivid driver. Metadata output is used to set brightness, contrast, saturation and hue. Adds new files for metadata output. Signed-off-by: Vandana BN --- drivers/media/platform/vivid/Makefile | 2 +- drivers/media/platform/vivid/vivid-core.c | 98

[PATCH 0/2] vivid: Metadata output support

This patch adds metadata output support in vivid driver. New metadata format V4L2_META_FMT_VIVID is added, which is used to set brightness, contrast, sturation and hue. Regards, Vandana. Vandana BN (2): v4l2-core: Add new metadata format vivid: Add metadata output support drivers/media/plat

[PATCH 1/2] v4l2-core: Add new metadata format

Add new metadata format to support metadata output in vivid. Signed-off-by: Vandana BN --- drivers/media/v4l2-core/v4l2-ioctl.c | 1 + include/uapi/linux/videodev2.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-i

Re: [PATCH] v4l2-ctl: support for metadata output

Hi Vandana, Since the videodev2.h header is copied from the header I can't apply this yet until support for V4L2_META_FMT_VIVID is merged into the kernel. I also have a few other comments, see below: On 10/3/19 9:06 AM, Vandana BN wrote: > Adds support to test metadata output format V4L2_META_FM

Re: [PATCH 1/2] v4l2-core: Add new metadata format

On 10/3/19 9:18 AM, Vandana BN wrote: > Add new metadata format to support metadata output in vivid. > > Signed-off-by: Vandana BN > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > include/uapi/linux/videodev2.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/media/

Re: [PATCH 1/2] v4l2-core: Add new metadata format

On 10/3/19 9:18 AM, Vandana BN wrote: > Add new metadata format to support metadata output in vivid. > > Signed-off-by: Vandana BN > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > include/uapi/linux/videodev2.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/media/

Build failed in Jenkins: v4l-utils #50

See Changes: [hverkuil-cisco] utils/libcecutil: add CEC utility library [hverkuil-cisco] cec-follower: switch to the new CEC utilities library [hverkuil-cisco] cec-compliance: use the new CEC utilities library [hverku

Re: venus: venc: Fix enum frameintervals - was: [GIT PULL for v5.5] Venus updates, take 2

Hi Mauro, On 10/2/19 5:09 PM, Mauro Carvalho Chehab wrote: > Em Wed, 2 Oct 2019 14:29:53 +0300 > Stanimir Varbanov escreveu: > >> Hi Mauro, >> >> The Venus driver updates include: >> >> * three fixes: fail to suspend, enum frameinterval issue with encoder >> and frequency table modifications fo

[PATCH v3] media: uvcvideo: Add a quirk to force GEO GC6500 Camera bits-per-pixel value

This device does not function correctly in raw mode in kernel versions validating buffer sizes in bulk mode. It erroneously announces 16 bits per pixel instead of 12 for NV12 format, so it needs this quirk to fix computed frame size and avoid legitimate frames getting discarded. Signed-off-by: Ser

Build failed in Jenkins: v4l-utils #51

See Changes: [hverkuil-cisco] libcecutil: do not assume building in source tree. -- [...truncated 18.06 KB...] make[3]: Leaving directory '

[PATCH v4] venus: venc: Fix enum frameintervals

This fixes an issue when setting the encoder framerate because of missing precision. Now the frameinterval type is changed to TYPE_CONTINUOUS and step = 1. Also the math is changed when framerate property is called - the firmware side expects the framerate in Q16 values. Signed-off-by: Stanimir Va

Re: [PATCH v4] venus: venc: Fix enum frameintervals

I have tested this on db410c with following gst pipeline: gst-launch-1.0 -v videotestsrc ! video/x-raw,format=NV12,width=1280,height=960,framerate=24/1 ! v4l2h264enc extra-controls="controls,h264_profile=4,h264_level="5",video_bitrate=1000;" ! filesink location=gstenc.h264 Loic, could you giv

[PATCH v2 5/5] media: vimc: remove the helper function vimc_ent_sd_unregister

since this function only calls v4l2_device_unregister_subdev, it is pointless. Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vimc/vimc-common.c | 5 - drivers/media/platform/vimc/vimc-common.h | 12 drivers/media/platform/vimc/vimc-debayer.c | 2 +- drivers/medi

[PATCH v2 3/5] media: vimc: sensor: register subdevice only after initialization

vimc_sen_add function first registers the subdevice and then calls tpg_alloc. If tpg_alloc fails it unregisters the subdevice and then frees vsen, this cause double free since the release callback that follows subdevice unregistration also frees vsen. Signed-off-by: Dafna Hirschfeld Acked-by: Hel

[PATCH v2 4/5] media: vimc: move media_entity_cleanup to release callbacks

according to the docs, this function must be called during the cleanup phase after unregistering the entity. Signed-off-by: Dafna Hirschfeld Acked-by: Helen Koike --- drivers/media/platform/vimc/vimc-capture.c | 2 +- drivers/media/platform/vimc/vimc-common.c | 1 - drivers/media/platform/vimc

[PATCH v2 0/5] media: vimc: bug fixes related to memory management

Changes since v1: fixes due to Helen Koike and Andrzej Pietrasiewicz's comments (thanks for the review!): - split the first patch into two patches, one that fixes the bug and one cleanup patch - fix allignment issue - add a last patch that removes vimc_ent_sd_unregister since it is not needed

[PATCH v4l-utils] ir-ctl: report timeout when it cannot be modified

There are many IR devices which cannot modify their timeout, but do have a timeout which should be reported (e.g. mtk_cir). Signed-off-by: Sean Young --- utils/ir-ctl/ir-ctl.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/utils/ir-ctl/ir-ctl.c b/utils/ir-ctl/i

[PATCH v2 2/5] media: vimc: cleanup code that assigns entity in entities array

Since the add callback returns NULL on failure and the array is initialized to NULLs, there is no need for the intermediate assignment to local var. Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vimc/vimc-core.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

[PATCH v2 1/5] media: vimc: initialize vim entity pointers to NULL

since NULL value for vimc entity pointer indicates that entity creation failed and this is tested, the pointers should be initialized to NULL. Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vimc/vimc-core.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/driv

[PATCH v2] v4l2-ctl: support for metadata output

Adds support to test metadata output format V4L2_META_FMT_VIVID. Signed-off-by: Vandana BN --- contrib/freebsd/include/linux/videodev2.h | 1 + include/linux/videodev2.h | 1 + utils/v4l2-ctl/v4l2-ctl-meta.cpp | 35 +++ utils/v4l2-ctl/v4l2-ctl-strea

[PATCH v2 2/2] vivid: Add metadata output support

Support metadata output in vivid driver. Metadata output is used to set brightness, contrast, saturation and hue. Adds new files for metadata output. Signed-off-by: Vandana BN --- drivers/media/platform/vivid/Makefile | 2 +- drivers/media/platform/vivid/vivid-core.c | 98

[PATCH v2 1/2] v4l2-core: Add new metadata format

Add new metadata format to support metadata output in vivid. Signed-off-by: Vandana BN --- drivers/media/v4l2-core/v4l2-ioctl.c | 1 + include/uapi/linux/videodev2.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2-i

[PATCH v2 0/2] vivid: Metadata output support

This patch adds metadata output support in vivid driver. New metadata format V4L2_META_FMT_VIVID is added, which is used to set brightness, contrast, sturation and hue. V2 has changes in metadata output structure and metadata format define. Regards, Vandana. Vandana BN (2): v4l2-core: Add new m

[GIT PULL FOR v5.5] Two cec fixes

The following changes since commit 503e59365dd134b2c63864f14e2de0476284b003: media: i2c: ov2659: Switch to SPDX Licensing (2019-10-01 17:39:16 -0300) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.5e for you to fetch changes up to 7a47b22e2051d6

Re: [GIT PULL FOR v5.5] Two cec fixes

From: buil...@linuxtv.org Pull request: https://patchwork.linuxtv.org/patch/59161/ Build log: https://builder.linuxtv.org/job/patchwork/18798/ Build time: 00:03:26 Link: https://lore.kernel.org/linux-media/df1e93e3-25d9-6ff3-4ad2-2293c2fee...@xs4all.nl gpg: Signature made Thu 03 Oct 2019 11:08:5

Jenkins build is back to normal : v4l-utils #52

See

[GIT PULL FOR v5.5] [v2] Two cec fixes

Changes since v1: - Fixes too-long lines in commit logs. The following changes since commit 503e59365dd134b2c63864f14e2de0476284b003: media: i2c: ov2659: Switch to SPDX Licensing (2019-10-01 17:39:16 -0300) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git t

Re: [GIT PULL FOR v5.5] [v2] Two cec fixes

From: buil...@linuxtv.org Pull request: https://patchwork.linuxtv.org/patch/59163/ Build log: https://builder.linuxtv.org/job/patchwork/18800/ Build time: 00:02:49 Link: https://lore.kernel.org/linux-media/e19af1d9-8a06-cedf-4982-29a72d1d1...@xs4all.nl gpg: Signature made Thu 03 Oct 2019 11:37:3

Re: [PATCH v7 1/2] vivid: Add metadata capture support

On 9/25/19 10:27 AM, Vandana BN wrote: > This patch adds meatadata capture support in vivid driver. > Adds new files for metadata capture. > Adds vivid controls to generate PTS and SCR for metadata stream. > > Signed-off-by: Vandana BN > --- > drivers/media/platform/vivid/Makefile | 2

Re: [PATCH v7 2/2] vivid: fixes for v4l2-compliance issues.

On 9/25/19 10:27 AM, Vandana BN wrote: > From: Hans Verkuil > > This patch fixes v4l2-compliance issues seen on metadata device. > > Signed-off-by: Hans Verkuil Can you squash this patch into the previous one? It's really all fixes for the previous patch, and it is better to apply one good pat

Re: [PATCH v2 1/2] v4l2-core: Add new metadata format

On 10/3/19 1:08 PM, Vandana BN wrote: > Add new metadata format to support metadata output in vivid. > > Signed-off-by: Vandana BN > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 1 + > include/uapi/linux/videodev2.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/media/

[PATCH v2] media: vimc: embed the pads of entities in the entities' structs

since the pads array is of known small size, there is no reason to allocate it separately. Instead, it is embedded in the entity struct. This also conforms to the media controller doc: 'Most drivers will embed the pads array in a driver-specific structure, avoiding dynamic allocation.' Signed-off-

Re: [PATCH v2 2/2] vivid: Add metadata output support

On 10/3/19 1:08 PM, Vandana BN wrote: > Support metadata output in vivid driver. > Metadata output is used to set brightness, contrast, saturation > and hue. > Adds new files for metadata output. > > Signed-off-by: Vandana BN > --- > drivers/media/platform/vivid/Makefile | 2 +- > driv

Re: [PATCH v2 1/5] media: vimc: initialize vim entity pointers to NULL

On 10/3/19 7:44 AM, Dafna Hirschfeld wrote: > since NULL value for vimc entity pointer indicates > that entity creation failed and this is tested, the > pointers should be initialized to NULL. > > Signed-off-by: Dafna Hirschfeld Acked-by: Helen Koike > --- > drivers/media/platform/vimc/vim

Re: [PATCH v2 2/5] media: vimc: cleanup code that assigns entity in entities array

On 10/3/19 7:44 AM, Dafna Hirschfeld wrote: > Since the add callback returns NULL on failure and the array > is initialized to NULLs, there is no need for the intermediate > assignment to local var. > > Signed-off-by: Dafna Hirschfeld I would just rename the title to something like: "media: v

[PATCH] media: cxd2841er: avoid too many status inquires

As reported at: https://tvheadend.org/issues/5625 Retrieving certain status can cause discontinuity issues. Prevent that by adding a timeout to each status logic. Currently, the timeout is estimated based at the channel bandwidth. There are other parameters that may also affect the timeo

[PATCH] media: cxd2841er: avoid too many status inquires

As reported at: https://tvheadend.org/issues/5625 Retrieving certain status can cause discontinuity issues. Prevent that by adding a timeout to each status logic. Currently, the timeout is estimated based at the channel bandwidth. There are other parameters that may also affect the timeo

Re: [PATCH v2 3/5] media: vimc: sensor: register subdevice only after initialization

Hi Dafna, Could you just rename the title tags to "media: vimc: sen: " to follow the model of the other commits? Thanks Helen On 10/3/19 7:44 AM, Dafna Hirschfeld wrote: > vimc_sen_add function first registers the subdevice and then > calls tpg_alloc. If tpg_alloc fails it unregisters the subdev

Re: [PATCH v2 5/5] media: vimc: remove the helper function vimc_ent_sd_unregister

On 10/3/19 7:44 AM, Dafna Hirschfeld wrote: > since this function only calls v4l2_device_unregister_subdev, > it is pointless. > > Signed-off-by: Dafna Hirschfeld Acked-by: Helen Koike > --- > drivers/media/platform/vimc/vimc-common.c | 5 - > drivers/media/platform/vimc/vimc-common.

[PATCH 2/2] ARM: dts: sun7i: Drop the module clock from the device tree

What we thought would be the module clock is actually the clock meant to be used by the sensors, and play no role in the CSI controller. Now that the binding has been updated to reflect that, let's update the device tree too. Fixes: d2b9c6444301 ("ARM: dts: sun7i: Add CSI0 controller") Reported-by

[PATCH 1/2] dt-bindings: media: sun4i-csi: Drop the module clock

It turns out that what was thought to be the module clock was actually the clock meant to be used by the sensor, and isn't playing any role with the CSI controller itself. Let's drop that clock from our binding. Fixes: c5e8f4ccd775 ("media: dt-bindings: media: Add Allwinner A10 CSI binding") Repor

Re: [PATCH 1/2] dt-bindings: media: sun4i-csi: Drop the module clock

Hi, On Thu, Oct 3, 2019 at 11:48 PM Maxime Ripard wrote: > > It turns out that what was thought to be the module clock was actually the > clock meant to be used by the sensor, and isn't playing any role with the > CSI controller itself. Let's drop that clock from our binding. > > Fixes: c5e8f4ccd

Re: [Linux-kernel-mentees] [PATCH v2 1/2] v4l2-core: Add new metadata format

On 10/3/19 5:08 AM, Vandana BN wrote: Add new metadata format to support metadata output in vivid. Signed-off-by: Vandana BN --- drivers/media/v4l2-core/v4l2-ioctl.c | 1 + include/uapi/linux/videodev2.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/media/v4l2-core/v4l

Re: [PATCH 1/2] dt-bindings: media: sun4i-csi: Drop the module clock

Hi, On Thu, Oct 03, 2019 at 11:51:05PM +0800, Chen-Yu Tsai wrote: > On Thu, Oct 3, 2019 at 11:48 PM Maxime Ripard wrote: > > > > It turns out that what was thought to be the module clock was actually the > > clock meant to be used by the sensor, and isn't playing any role with the > > CSI control

Re: [Linux-kernel-mentees] [PATCH v2 2/2] vivid: Add metadata output support

On 10/3/19 5:08 AM, Vandana BN wrote: Support metadata output in vivid driver. Metadata output is used to set brightness, contrast, saturation and hue. Adds new files for metadata output. Signed-off-by: Vandana BN --- drivers/media/platform/vivid/Makefile | 2 +- drivers/media/plat

Re: [PATCH 1/2] media: uapi: h264: Add num_ref_idx_active_override_flag

Hi, On Mon 09 Sep 19, 18:40, Tomasz Figa wrote: > On Mon, Sep 9, 2019 at 4:30 PM Philipp Zabel wrote: > > > > On Mon, 2019-09-09 at 16:09 +0900, Tomasz Figa wrote: > > > On Thu, Sep 5, 2019 at 11:17 PM Nicolas Dufresne > > > wrote: > > > > > > > > Le jeudi 05 septembre 2019 à 12:39 +0200, Philip

Re: [PATCH 1/2] media: uapi: h264: Add num_ref_idx_active_override_flag

Hi, On Thu 05 Sep 19, 12:15, Philipp Zabel wrote: > This flag tells the kernel whether the slice header contained the > num_ref_idx_l[01]_active_minus1 syntax elements, or whether the > num_ref_idx_l[01]_default_active_minus1 from PPS should be used > instead. Looks good to me: Reviewed-by: Paul

Re: [PATCH] media: uapi: h264: clarify num_ref_idx_l[01]_(default_)active fields

Hi, On Thu 05 Sep 19, 13:42, Philipp Zabel wrote: > To explain why num_ref_idx_active_override_flag is not part of the API, > describe how the num_ref_idx_l[01]_active_minus1 fields and the > num_ref_idx_l[01]_default_active_minus1 fields are used, depending on > whether the decoder parses slice h

The potential uninitialized variables used in function isc_interrupt()

Hi Eugen: In function isc_interrupt(), variable "isc_intsr" and "isc_intmask" (drivers/media/platform/atmel/atmel-isc-base.c) could be uninitialized if regmap_read() fails and return -EINVAL . However, they are used to decide the control flow later in the if statement, which is potentially unsafe

cron job: media_tree daily build: OK

This message is generated daily by a cron job that builds media_tree for the kernels and architectures in the list below. Results of the daily build of media_tree: date: Fri Oct 4 05:00:10 CEST 2019 media-tree git hash:503e59365dd134b2c63864f14e2de0476284b003 media_build gi

[PATCH v6 1/1] Add test for new features in cec-follower

Analog tuner control test tuner_ctl_test(): - give analog tuner status - select tuner analog service - analog tuner step features Signed-off-by: Jiunn Chang --- utils/cec-compliance/cec-test.cpp | 75 +++ 1 file changed, 75 insertions(+) diff --git a/utils/cec-

[PATCH v6 0/1] cec-compliance: tuner control

This patch series implements analog tuner step features and cec-compliance tests. Added tuner_ctl_test() to test new tuner features implemented in the cec-follower. --- Changes made since v5: - Add missing fail_on_test(cec_msg_status_is_abort(&msg)): hverkuil - Remove redundant test unrecog

Re: [PATCH 1/2] dt-bindings: media: sun4i-csi: Drop the module clock

On Fri, Oct 4, 2019 at 12:37 AM Maxime Ripard wrote: > > Hi, > > On Thu, Oct 03, 2019 at 11:51:05PM +0800, Chen-Yu Tsai wrote: > > On Thu, Oct 3, 2019 at 11:48 PM Maxime Ripard wrote: > > > > > > It turns out that what was thought to be the module clock was actually the > > > clock meant to be us