[PATCH 1/2] drivers: usbvideo: remove custom implementation of hex_to_bin()

Signed-off-by: Andy Shevchenko andy.shevche...@gmail.com --- drivers/media/video/usbvideo/usbvideo.c | 12 1 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/media/video/usbvideo/usbvideo.c b/drivers/media/video/usbvideo/usbvideo.c index 5ac37c6..f1fcf97 100644

[PATCH 2/2] media: video: pvrusb2: remove custom hex_to_bin()

Signed-off-by: Andy Shevchenko andy.shevche...@gmail.com Cc: Mike Isely is...@pobox.com --- drivers/media/video/pvrusb2/pvrusb2-debugifc.c | 14 ++ 1 files changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/media/video/pvrusb2/pvrusb2-debugifc.c b/drivers/media/video

[PATCH 1/2] dvb: mantis: use '%pM' format to print MAC address

Signed-off-by: Andy Shevchenko andy.shevche...@gmail.com --- drivers/media/dvb/mantis/mantis_core.c |5 + drivers/media/dvb/mantis/mantis_ioc.c |9 + 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/media/dvb/mantis/mantis_core.c b/drivers/media/dvb

[PATCH 2/2] media: cx23885: use '%pM' format to print MAC address

Signed-off-by: Andy Shevchenko andy.shevche...@gmail.com --- drivers/media/video/cx23885/cx23885-dvb.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/cx23885/cx23885-dvb.c b/drivers/media/video/cx23885/cx23885-dvb.c index 3d70af2..eca7247 100644

[PATCHv2 1/2] dvb: mantis: use '%pM' format to print MAC address

Signed-off-by: Andy Shevchenko andy.shevche...@gmail.com --- drivers/media/dvb/mantis/mantis_core.c |5 + drivers/media/dvb/mantis/mantis_ioc.c |9 + 2 files changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/media/dvb/mantis/mantis_core.c b/drivers/media/dvb

[PATCHv2 2/2] media: cx23885: use '%pM' format to print MAC address

Signed-off-by: Andy Shevchenko andy.shevche...@gmail.com --- drivers/media/video/cx23885/cx23885-dvb.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/cx23885/cx23885-dvb.c b/drivers/media/video/cx23885/cx23885-dvb.c index 3d70af2..0674ea1 100644

[media-ctl][PATCH] libmediactl: engage udev to get devname

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- configure.in| 10 src/Makefile.am |2 + src/media.c | 66 ++ 3 files changed, 44 insertions(+), 34 deletions(-) diff --git a/configure.in b

Re: [media-ctl][PATCH] libmediactl: engage udev to get devname

On Mon, 2011-08-15 at 16:52 +0200, Laurent Pinchart wrote: Hi Andy, Thank you for the patch. What about making it a configuration option to still support systems that don't provide libudev ? We could keep the current behaviour for those. Good point. Will do. -- Andy Shevchenko

[media-ctl][PATCHv2 1/4] libmediactl: restruct error path

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- src/media.c | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/src/media.c b/src/media.c index e3cab86..050289e 100644 --- a/src/media.c +++ b/src/media.c @@ -255,7 +255,7 @@ static int

[media-ctl][PATCHv2 2/4] libmediactl: split media_get_devname from media_enum_entities

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- src/media.c | 69 +- 1 files changed, 39 insertions(+), 30 deletions(-) diff --git a/src/media.c b/src/media.c index 050289e..fc05a86 100644 --- a/src/media.c +++ b/src

[media-ctl][PATCHv2 3/4] libmediactl: use udev conditionally to get a devname

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- configure.in| 22 ++ src/Makefile.am |2 ++ src/media.c | 50 ++ 3 files changed, 74 insertions(+), 0 deletions(-) diff --git a/configure.in b

[media-ctl][PATCHv2 4/4] libmediactl: pass verbose to media_get_devname

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- src/media.c | 13 +++-- 1 files changed, 7 insertions(+), 6 deletions(-) diff --git a/src/media.c b/src/media.c index e159526..e276df5 100644 --- a/src/media.c +++ b/src/media.c @@ -255,7 +255,7 @@ static int

Re: [PATCH] Media controller: Define media_entity_init() and media_entity_cleanup() conditionally

On Wed, 2011-08-17 at 16:04 +0530, Deepthy Ravi wrote: From: Vaibhav Hiremath hvaib...@ti.com Defines the two functions only when CONFIG_MEDIA_CONTROLLER is enabled. Is it not a driver's option to be dependent on MEDIA_CONTROLLER? -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel

[PATCH] adp1653: make -power() method optional

The -power() could be absent or not used on some platforms. This patch makes its presence optional. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/adp1653.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions

Re: [PATCH] adp1653: make -power() method optional

On Thu, 2011-08-18 at 12:21 +0300, Sakari Ailus wrote: On Thu, Aug 18, 2011 at 11:53:03AM +0300, Andy Shevchenko wrote: The -power() could be absent or not used on some platforms. This patch makes its presence optional. Hi Andy, Thanks for the patch! Signed-off-by: Andy

Re: [PATCH] adp1653: make -power() method optional

On Thu, 2011-08-18 at 13:53 +0300, Sakari Ailus wrote: On Thu, Aug 18, 2011 at 01:30:50PM +0300, Andy Shevchenko wrote: On Thu, 2011-08-18 at 12:21 +0300, Sakari Ailus wrote: On Thu, Aug 18, 2011 at 11:53:03AM +0300, Andy Shevchenko wrote: The -power() could be absent or not used

[PATCHv2] adp1653: make -power() method optional

The -power() could be absent or not used on some platforms. This patch makes its presence optional. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video/adp1653.c |5 + 1 files changed, 5 insertions(+), 0 deletions

Re: [PATCHv2] adp1653: make -power() method optional

On Thu, 2011-08-18 at 14:22 +0300, Andy Shevchenko wrote: The -power() could be absent or not used on some platforms. This patch makes its presence optional. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Sakari Ailus sakari.ai...@iki.fi --- drivers/media/video

Re: [PATCHv2] adp1653: make -power() method optional

On Thu, 2011-08-18 at 14:51 +0300, Sakari Ailus wrote: On Thu, Aug 18, 2011 at 02:32:02PM +0300, Andy Shevchenko wrote: On Thu, 2011-08-18 at 14:22 +0300, Andy Shevchenko wrote: The -power() could be absent or not used on some platforms. This patch makes its presence optional

RE: [PATCHv2] ISP:BUILD:FIX: Move media_entity_init() and

, obviously. -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[media-ctl][PATCHv3 1/3] libmediactl: restruct error path

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- src/media.c | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/src/media.c b/src/media.c index e3cab86..050289e 100644 --- a/src/media.c +++ b/src/media.c @@ -255,7 +255,7 @@ static int

[media-ctl][PATCHv3 2/3] libmediactl: split media_get_devname_sysfs from media_enum_entities

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- src/media.c | 61 +- 1 files changed, 35 insertions(+), 26 deletions(-) diff --git a/src/media.c b/src/media.c index 050289e..5d3ff7c 100644 --- a/src/media.c +++ b/src

[media-ctl][PATCHv3 3/3] libmediactl: get the device name via udev

If configured with --with-libudev, the libmediactl is built with libudev support. It allows to get the device name in right way in the modern linux systems. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- configure.in| 22 src/Makefile.am |2 + src

Re: [media-ctl][PATCHv2 3/4] libmediactl: use udev conditionally to get a devname

, have_libudev=no)], +[have_libudev=no]) I don't think this works when cross-compiling. Do you mean pkg-config call? Its manual tells us about PKG_CONFIG_SYSROOT_DIR which might be helpful. -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list

Re: [media-ctl][PATCHv2 3/4] libmediactl: use udev conditionally to get a devname

On Fri, 2011-09-02 at 13:17 +0200, Laurent Pinchart wrote: Hi Andy, On Friday 02 September 2011 10:42:06 Andy Shevchenko wrote: On Tue, 2011-08-30 at 21:14 +0200, Laurent Pinchart wrote: +AC_ARG_WITH([libudev], +AS_HELP_STRING([--without-libudev], +[Ignore presence

[media-ctl][PATCHv4 1/3] libmediactl: restruct error path

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- src/media.c | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/src/media.c b/src/media.c index e3cab86..050289e 100644 --- a/src/media.c +++ b/src/media.c @@ -255,7 +255,7 @@ static int

[media-ctl][PATCHv4 2/3] libmediactl: split media_get_devname_sysfs from media_enum_entities

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- src/media.c | 61 +- 1 files changed, 35 insertions(+), 26 deletions(-) diff --git a/src/media.c b/src/media.c index 050289e..5d3ff7c 100644 --- a/src/media.c +++ b/src

[media-ctl][PATCHv4 3/3] libmediactl: get the device name via udev

If configured with --with-libudev, the libmediactl is built with libudev support. It allows to get the device name in right way in the modern linux systems. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- configure.in| 22 src/Makefile.am |2 + src

Re: [media-ctl][PATCHv4 3/3] libmediactl: get the device name via udev

On Mon, 2011-09-05 at 12:31 +0200, Laurent Pinchart wrote: Hi Andy, On Friday 02 September 2011 15:09:28 Andy Shevchenko wrote: If configured with --with-libudev, the libmediactl is built with libudev support. It allows to get the device name in right way in the modern linux systems

[media-ctl][PATCHv5 1/5] libmediactl: restruct error path

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- src/media.c | 16 +--- 1 files changed, 9 insertions(+), 7 deletions(-) diff --git a/src/media.c b/src/media.c index e3cab86..050289e 100644 --- a/src/media.c +++ b/src/media.c @@ -255,7 +255,7 @@ static int

[media-ctl][PATCHv5 2/5] libmediactl: split media_get_devname_sysfs from media_enum_entities

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- src/media.c | 61 +- 1 files changed, 35 insertions(+), 26 deletions(-) diff --git a/src/media.c b/src/media.c index 050289e..5d3ff7c 100644 --- a/src/media.c +++ b/src

[media-ctl][PATCHv5 3/5] libmediactl: get the device name via udev

If configured with --with-libudev, the libmediactl is built with libudev support. It allows to get the device name in right way in the modern linux systems. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- configure.in| 22 +++ src/Makefile.am |2 + src

[media-ctl][PATCHv5 4/5] libmediactl: simplify code by introducing close_and_free inliner

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- src/media.c | 15 +-- 1 files changed, 9 insertions(+), 6 deletions(-) diff --git a/src/media.c b/src/media.c index 657b6c4..6c03369 100644 --- a/src/media.c +++ b/src/media.c @@ -403,6 +403,12 @@ static int

[media-ctl][PATCHv5 5/5] libmediactl: get rid of memset via using calloc

The code snippet x = malloc(sizeof(*x)); memset(x, 0, sizeof(*x)); could be easily changed to x = calloc(1, sizeof(*x)); Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- src/media.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff

Re: [media-ctl][PATCHv4 3/3] libmediactl: get the device name via udev

to media_enum_entities() (which is static), and calling media_udev_close() in media_open() after the media_enum_entities() call ? I sent the patch series that incorporates your last comments. -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from

Re: [media-ctl][PATCHv5 1/5] libmediactl: restruct error path

: udef_unref is aware of NULL. -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [media-ctl][PATCHv5 1/5] libmediactl: restruct error path

On Tue, 2011-09-06 at 13:46 +0300, Andy Shevchenko wrote: On Tue, 2011-09-06 at 12:25 +0200, Laurent Pinchart wrote: I've slightly modified 1/5 and 3/5 (the first one returned -1 from media_enum_entities(), which made media-ctl stop with a failure message) and pushed the result

Re: [RFC][PATCH] as3645a: introduce new LED Flash driver

On Fri, 2011-09-09 at 17:08 +0200, Laurent Pinchart wrote: Hi Andy, On Friday 09 September 2011 16:59:31 Andy Shevchenko wrote: The driver supports the AS3645A, LM3555 chips and their clones. Accordingly to datasheet the AS3645 chip is a 1000/720mA Ultra Small High efficient single

v4l2 api for flash drivers

Hello. I didn't see the patchset [1] in any public tree on git.kernel.org. Is this patch going to be pushed? [1] http://www.spinics.net/lists/linux-media/msg32527.html -- Andy Shevchenko andriy.shevche...@intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe

[PATCH] adp1653: check platform_data before usage

The driver requires platform_data to be present. That's why we need to check and fail in case of the absence of necessary data. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: Sakari Ailus sakari.ai...@iki.fi --- drivers/media

Re: v4l2 api for flash drivers

. However, the question is why have you chosen hardware units for *_INTENSITY instead of, let say, hundredth of percents (like 0 .. 1)? -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

[PATCH] adp1653: check error code of adp1653_init_controls

Potentially the adp1653_init_controls could return an error. In our case the error was ignored, meanwhile it means incorrect initialization of V4L2 controls. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: Sakari Ailus sakari.ai

Re: [PATCH] adp1653: check error code of adp1653_init_controls

On Wed, 2011-07-27 at 11:15 +0300, Sakari Ailus wrote: On Wed, Jul 27, 2011 at 10:58:02AM +0300, Andy Shevchenko wrote: Potentially the adp1653_init_controls could return an error. In our case the error was ignored, meanwhile it means incorrect initialization of V4L2 controls. Hi, Andy

[PATCHv2] adp1653: check error code of adp1653_init_controls

Potentially the adp1653_init_controls could return an error. In our case the error was ignored, meanwhile it means incorrect initialization of V4L2 controls. Additionally we have to free control handler structures in case of apd1653_init_controls or media_entity_init failure. Signed-off-by: Andy

Re: [PATCHv2] adp1653: check error code of adp1653_init_controls

(flash-subdev.entity, 0, NULL, 0); done: if (ret 0) { v4l2_ctrl_handler_free(flash-ctrls); kfree(flash); } return ret; There is no difference at first glance. However, your variant is less straight to understand for my opinion. -- Andy

adp1653 usage

? - if there is no v4l-subdevX device node, when and how the kernel runs -open() and -close() methods of v4l2_subdev_internal_ops? -- Andy Shevchenko andriy.shevche...@intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: adp1653 usage

. -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] adp1653: set media entity type

The type of a media entity is default for this driver. This patch makes it explicitly defined as MEDIA_ENT_T_V4L2_SUBDEV_FLASH. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/video/adp1653.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff

[PATCH] media: video: append $(srctree) to -I parameters

Some details could be found in [1] as well. [1] http://comments.gmane.org/gmane.linux.kbuild.devel/7733 Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/video/Makefile |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/video

Re: [PATCH] media: video: append $(srctree) to -I parameters

On Thu, 2012-02-16 at 07:22 +0100, Laurent Pinchart wrote: Hi Andy, Thanks for the patch. On Wednesday 15 February 2012 17:08:01 Andy Shevchenko wrote: Without this we have got the warnings like following if build with make W=1 O=/var/tmp: CHECK drivers/media/video/videobuf

[PATCHv2 1/7] media: video: append $(srctree) to -I parameters

Some details could be found in [1] as well. [1] http://comments.gmane.org/gmane.linux.kbuild.devel/7733 Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/video/Makefile |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/video

[PATCHv2 4/7] media: dvb: append $(srctree) to -I parameters

Without this we have got the warnings like following if build with make W=1 O=/var/tmp: cc1: warning: drivers/media/dvb/dvb-core: No such file or directory [enabled by default] Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/dvb/dvb-usb/Makefile |7

[PATCHv2 2/7] media: tuners: append $(srctree) to -I parameters

Without this we have got the warnings like following if build with make W=1 O=/var/tmp: cc1: warning: drivers/media/dvb/dvb-core: No such file or directory [enabled by default] Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/common/tuners/Makefile |4

[PATCHv2 3/7] media: gspca: append $(srctree) to -I parameters

Without this we have got the warnings like following if build with make W=1 O=/var/tmp: cc1: warning: drivers/media/dvb/dvb-core: No such file or directory [enabled by default] Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/video/gspca/gl860/Makefile

[PATCHv2 6/7] media: saa7164: append $(srctree) to -I parameters

Without this we have got the warnings like following if build with make W=1 O=/var/tmp: cc1: warning: drivers/media/dvb/dvb-core: No such file or directory [enabled by default] Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/video/saa7164/Makefile |8

[PATCHv2 5/7] media: ivtv: append $(srctree) to -I parameters

Without this we have got the warnings like following if build with make W=1 O=/var/tmp: cc1: warning: drivers/media/dvb/dvb-core: No such file or directory [enabled by default] Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/video/ivtv/Makefile |8

[PATCHv2 7/7] media: saa7134: append $(srctree) to -I parameters

Without this we have got the warnings like following if build with make W=1 O=/var/tmp: cc1: warning: drivers/media/dvb/dvb-core: No such file or directory [enabled by default] Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/video/saa7134/Makefile |8

[PATCH] media: dvb-usb: print mac address via native %pM

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/dvb/dvb-usb/az6007.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/dvb/dvb-usb/az6007.c b/drivers/media/dvb/dvb-usb/az6007.c index 4008b9c..8ffcad0 100644 --- a/drivers

[PATCH 05/12] staging: lirc: use %*ph to print small buffers

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: linux-media@vger.kernel.org --- drivers/staging/media/lirc/lirc_igorplugusb.c |4 ++-- drivers/staging/media/lirc/lirc_zilog.c |3 +-- 2 files changed, 3 insertions

[PATCH 01/11] saa7164: use native print_hex_dump() instead of custom one

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/video/saa7164/saa7164-api.c | 15 ++--- drivers/media/video/saa7164/saa7164-core.c | 46 +++- drivers/media/video/saa7164/saa7164.h |1 - 3 files changed, 14 insertions

[PATCH 02/11] dvb: nxt200x: apply levels to the printk()s

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/dvb/frontends/nxt200x.c | 56 ++--- 1 file changed, 30 insertions(+), 26 deletions(-) diff --git a/drivers/media/dvb/frontends/nxt200x.c b/drivers/media/dvb/frontends/nxt200x.c index

[PATCH 06/11] radio-shark2: use %*ph to print small buffers

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/radio/radio-shark2.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/media/radio/radio-shark2.c b/drivers/media/radio/radio-shark2.c index b9575de..90aecfb 100644

[PATCH 10/11] saa7127: use %*ph to print small buffers

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/video/saa7127.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/media/video/saa7127.c b/drivers/media/video/saa7127.c index 39c90b0..8ecb656 100644 --- a/drivers/media/video

[PATCH 08/11] dvb: use %*ph to hexdump small buffers

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/dvb/b2c2/flexcop-usb.c |5 + drivers/media/dvb/bt8xx/dst_ca.c |3 ++- drivers/media/dvb/dvb-core/dmxdev.c |4 +--- drivers/media/dvb/ngene/ngene-core.c | 14 -- 4 files changed, 8

[PATCH 05/11] dvb: frontends: use %*ph to dump small buffers

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Antti Palosaari cr...@iki.fi --- drivers/media/dvb/frontends/cxd2820r_t.c |3 +-- drivers/media/dvb/frontends/nxt200x.c|8 +++- drivers/media/dvb/frontends/rtl2830.c|2 +- 3 files changed, 5 insertions

[PATCH 09/11] ati_remote: use %*ph to dump small buffers

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Anssi Hannula anssi.hann...@iki.fi --- drivers/media/rc/ati_remote.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/media/rc/ati_remote.c b/drivers/media/rc/ati_remote.c index 8fa72e2

[PATCH 03/11] common: tunners: use %*ph to dump small buffers

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/common/tuners/tuner-xc2028.c |3 +-- drivers/media/common/tuners/xc4000.c |3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/common/tuners/tuner-xc2028.c b/drivers

[PATCH 07/11] gspca: use %*ph to print small buffers

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Hans de Goede hdego...@redhat.com --- drivers/media/video/gspca/sq905c.c |7 ++- drivers/media/video/gspca/sq930x.c | 10 +- drivers/media/video/gspca/vc032x.c |7 ++- 3 files changed, 5 insertions

[PATCH 11/11] au0828: use %*ph to dump small buffers

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/video/au0828/au0828-core.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/media/video/au0828/au0828-core.c b/drivers/media/video/au0828/au0828-core.c index 1e4ce50

Re: [PATCH 2/2] dvb_usb_v2: use %*ph to dump usb xfer debugs

could be in above cases, but be aware that %*ph prints up to 64 bytes only. Is it enough here? -- With Best Regards, Andy Shevchenko -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 11/11] au0828: use %*ph to dump small buffers

On Mon, Aug 13, 2012 at 10:41 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 07-08-2012 13:43, Andy Shevchenko escreveu: Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- That one doesn't apply anymore. It's not needed anymore. Please, skip it. -- With Best Regards

[PATCH] as3645a: move .remove under .devexit.text

There is no needs to keep .remove under .exit.text. This driver is for a standalone chip that could be on any board and connected to any i2c bus. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video

Re: [PATCH] as3645a: move .remove under .devexit.text

On Sat, 2012-04-21 at 19:36 +0200, Laurent Pinchart wrote: Hi Andy, Thanks for the patch. On Thursday 19 April 2012 16:48:10 Andy Shevchenko wrote: There is no needs to keep .remove under .exit.text. This driver is for a standalone chip that could be on any board and connected to any

[PATCHv2] as3645a: move relevant code under __devinit/__devexit

tag. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com Cc: Laurent Pinchart laurent.pinch...@ideasonboard.com --- drivers/media/video/as3645a.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/media/video/as3645a.c b/drivers/media/video

[PATCH] gspca: print small buffers via %*ph

Instead of passing each byte through stack let's use %*ph specifier to do this job better. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/usb/gspca/sonixb.c | 5 + drivers/media/usb/gspca/xirlink_cit.c | 12 2 files changed, 5 insertions

[PATCH 2/2] dvb: or51211: apply pr_fmt and use pr_* macros instead of printk

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/dvb-frontends/or51211.c | 94 +++-- 1 file changed, 43 insertions(+), 51 deletions(-) diff --git a/drivers/media/dvb-frontends/or51211.c b/drivers/media/dvb-frontends/or51211.c index

[PATCH 1/2] dvb-frontends: use %*ph[N] to dump small buffers

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/dvb-frontends/ix2505v.c |2 +- drivers/media/dvb-frontends/or51211.c |5 + 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/dvb-frontends/ix2505v.c b/drivers/media/dvb

[PATCH 2/2] dvb: or51211: apply pr_fmt and use pr_* macros instead of printk

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/dvb-frontends/or51211.c | 94 +++-- 1 file changed, 43 insertions(+), 51 deletions(-) diff --git a/drivers/media/dvb-frontends/or51211.c b/drivers/media/dvb-frontends/or51211.c index

[PATCHv2] dvb: or51211: apply pr_fmt and use pr_* macros instead of printk

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/dvb-frontends/or51211.c | 94 +++-- 1 file changed, 43 insertions(+), 51 deletions(-) diff --git a/drivers/media/dvb-frontends/or51211.c b/drivers/media/dvb-frontends/or51211.c index

Re: [PATCH v2 2/2] as3645a: Add driver for LED flash controller

On Mon, 2011-11-14 at 11:34 +0200, Sakari Ailus wrote: Hi Laurent, Thanks for the patch!! I have a few comments below. Most of your comments is about to be addressed by my patches. Please, wait a bit, And I send my series as I promised. -- Andy Shevchenko andriy.shevche...@linux.intel.com

Re: [PATCH v2 2/2] as3645a: Add driver for LED flash controller

to actually manufacture the chips? I don't know :-) I guess the vendor is proper word here. For example, lm3555 (NSC) is slightly different from as3645a. And why dev_dbg? I think dev_info here might be suitable. -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy

[PATCH 1/9] as3645a: mention lm3555 as a clone of that chip

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/video/as3645a.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/as3645a.c b/drivers/media/video/as3645a.c index a9f857f..ef1226d 100644 --- a/drivers/media/video

[PATCH 2/9] as3645a: print vendor and revision of the chip

The as3645a_registered() is used to detect connected chip. It would be nice to print the detected value every time we load the module. The Vendor is probably better word to use there. For example, lm3555 (NSC) is slightly different to as3645a. Signed-off-by: Andy Shevchenko andriy.shevche

[PATCH 0/9] as3645a: set of fixes up

This series incorporates Sakari's comments and couple of fixes from my version of the driver. Andy Shevchenko (9): as3645a: mention lm3555 as a clone of that chip as3645a: print vendor and revision of the chip as3645a: remove unused code as3645a: No error, no message. as3645a: move

[PATCH 4/9] as3645a: No error, no message.

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/video/as3645a.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/as3645a.c b/drivers/media/video/as3645a.c index 5c7e42f..108bc0f 100644 --- a/drivers/media/video

[PATCH 5/9] as3645a: move limits to the platform_data

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/video/as3645a.c | 12 ++-- include/media/as3645a.h | 32 +--- 2 files changed, 19 insertions(+), 25 deletions(-) diff --git a/drivers/media/video/as3645a.c b/drivers

[PATCH 6/9] as3645a: free resources in case of error properly

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/video/as3645a.c | 23 --- 1 files changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/media/video/as3645a.c b/drivers/media/video/as3645a.c index 541f8bc..9aebaa2 100644

[PATCH 3/9] as3645a: remove unused code

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/video/as3645a.c |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/as3645a.c b/drivers/media/video/as3645a.c index 8882a14..5c7e42f 100644 --- a/drivers/media/video

[PATCH 7/9] as3645a: use struct dev_pm_ops

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/video/as3645a.c | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/as3645a.c b/drivers/media/video/as3645a.c index 9aebaa2..774f797 100644 --- a/drivers/media

[PATCH 8/9] as3645a: use pr_err macro instead of printk KERN_ERR

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/video/as3645a.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/as3645a.c b/drivers/media/video/as3645a.c index 774f797..5f8fa68 100644 --- a/drivers/media/video

[PATCH 9/9] as3645a: use the same timeout for hw and sw strobes

It seems the timeout value couldn't be different for either external or software strobe (accordingly to as3645a datasheet, table 6). This patch doesn't prevent to use software watchdog, because it will use another mechanism to stop strobing (i.e. low out pin). Signed-off-by: Andy Shevchenko

Re: [PATCH 6/9] as3645a: free resources in case of error properly

(flash); } return ret; I'm okay with it. However, I don't know if the compiler could optimize double check here. -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message

Re: [PATCH v5 2/2] as3645a: Add driver for LED flash controller

); + } + + return ret; +} -- Andy Shevchenko andriy.shevche...@linux.intel.com Intel Finland Oy -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/2] media: video: pwc: Use kernel's simple_strtol()

From: Andy Shevchenko ext-andriy.shevche...@nokia.com Change own implementation of pwc_atoi() by simple_strtol(x, NULL, 10). Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com Acked-by: Pekka Enberg penb...@cs.helsinki.fi --- drivers/media/video/pwc/pwc-if.c | 23

[PATCH 2/2] atoi: Drop custom atoi from drivers/video/modedb.c

From: Andy Shevchenko ext-andriy.shevche...@nokia.com Kernel has simple_strtol() implementation which could be used as atoi(). Signed-off-by: Andy Shevchenko ext-andriy.shevche...@nokia.com --- drivers/video/modedb.c | 24 +--- 1 files changed, 5 insertions(+), 19

[PATCH] dvb-usb: print small buffers via %*ph

Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/usb/dvb-usb/a800.c |2 +- drivers/media/usb/dvb-usb/cinergyT2-core.c |3 +-- drivers/media/usb/dvb-usb/dibusb-common.c |2 +- drivers/media/usb/dvb-usb/digitv.c |2 +- drivers

Re: [patch] [media] staging: lirc: clean error handling in probe()

On Wed, 2013-06-26 at 10:53 +0300, Dan Carpenter wrote: I have reorganized the error handling into a simpler and more canonical format. Since you reorganize error handling, might be worth to convert it to devm_*? If you want I could do the patch. -- Andy Shevchenko andriy.shevche

[PATCH v2] staging: lirc: clean error handling in probe()

Carpenter dan.carpen...@oracle.com Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/staging/media/lirc/lirc_igorplugusb.c | 56 +++ 1 file changed, 14 insertions(+), 42 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_igorplugusb.c b

Re: [PATCH v2] staging: lirc: clean error handling in probe()

On Wed, 2013-06-26 at 18:10 +0300, Dan Carpenter wrote: On Wed, Jun 26, 2013 at 05:37:36PM +0300, Andy Shevchenko wrote: From: Dan Carpenter dan.carpen...@oracle.com We have reorganized the error handling into a simpler and more canonical format. Additionally we removed extra empty

[PATCH] smiapp: re-use clamp_t instead of min(..., max(...))

clamp_t does the job to put a variable into the given range. Signed-off-by: Andy Shevchenko andriy.shevche...@linux.intel.com --- drivers/media/i2c/smiapp/smiapp-core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b

  1   2   3   >