[PATCH] vivi: Don't depend on FONTS

CONFIG_FONTS has nothing to do with whether find_font() is defined. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/video/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig index f6e4d04

[PATCH] DVB/V4L: Fix Kconfig select/depend conflicts

depends on manual selection being enabled. It also necessarily removes some explicit menus, since explicit menus always result in a config dependency. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- Mauro, please try to get this included in 2.6.37. Now that Kconfig warns about such conflicts

Re: Bug#639161: linux-image-3.0.0-1-686-pae: Upgrade 2.6.39 - 3.0.0 breaks playback on DiBcom 7000PC

Patrick, Please could you take a look at the following bug report on Linux 3.0 as packaged in Debian. Ben. On Wed, 2011-08-24 at 18:59 +0200, Soeren D. Schulze wrote: Package: linux-2.6 Version: 3.0.0-1 Severity: normal I usually use tzap/mplayer for TV playback. After the upgrade to

Re: [RFC/PATCH 0/3] locking fixes for cx88

On Sat, 2011-04-02 at 04:38 -0500, Jonathan Nieder wrote: Hi, Huber Andreas wrote[1]: Processes that try to open a cx88-blackbird driven MPEG device will hang up. Here's a possible fix based on a patch by Ben Hutchings and corrections from Andi Huber. Warning: probably full

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

isn't an MFD the parent of its component devices? Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

On Wed, 2011-04-06 at 19:51 +0200, Samuel Ortiz wrote: Hi Ben, On Wed, Apr 06, 2011 at 06:16:49PM +0100, Ben Hutchings wrote: So, adding an MFD cell pointer to the device structure allows us to cleanly pass both pieces of information, while keeping all the MFD sub drivers

Re: [PATCH net-next-2.6 1/4] net: introduce mc list helpers

)) Once you change the list type this can presumably be made less ugly. Ben. -- Ben Hutchings, Senior Software Engineer, Solarflare Communications Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked

[PATCH] V4L/DVB: lgs8gxx: remove firmware for lgs8g75

The recently added support for lgs8g75 included some 8051 machine code without accompanying source code. Replace this with use of the firmware loader. Compile-tested only. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- This firmware can be added to linux-firmware.git instead, and I

[PATCH 10/75] V4L/DVB: declare MODULE_FIRMWARE for modules using XC2028 and XC3028L tuners

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- I'm not really sure whether it's better to do this in the drivers which specify which firmware file to use, or just once in the xc2028 tuner driver. Your call. Ben. drivers/media/dvb/dvb-usb/cxusb.c |1 + drivers/media/dvb/dvb

[PATCH 11/75] xc5000: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/common/tuners/xc5000.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/common/tuners/xc5000.c b/drivers/media/common/tuners/xc5000.c index 432003d..e13165a 100644 --- a/drivers/media/common

[PATCH 12/75] dvb-usb: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/dvb/dvb-usb/a800.c|1 + drivers/media/dvb/dvb-usb/af9005.c |1 + drivers/media/dvb/dvb-usb/af9015.c |1 + drivers/media/dvb/dvb-usb/cxusb.c |2 ++ drivers/media/dvb/dvb-usb

[PATCH 13/75] af90013: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/dvb/frontends/af9013.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/dvb/frontends/af9013.c b/drivers/media/dvb/frontends/af9013.c index 12e018b..fc1c8c8 100644 --- a/drivers/media/dvb

[PATCH 14/75] bcm3510: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/dvb/frontends/bcm3510.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/dvb/frontends/bcm3510.c b/drivers/media/dvb/frontends/bcm3510.c index cf5e576..a08bd1f 100644 --- a/drivers/media/dvb

[PATCH 15/75] cx24416: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/dvb/frontends/cx24116.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/dvb/frontends/cx24116.c b/drivers/media/dvb/frontends/cx24116.c index 2410d8b..f3eef67 100644 --- a/drivers/media

[PATCH 16/75] drx397xD: declare MODULE_FIRMWARE

Move punctuation into definition of _FW_ENTRY so we can use either a comma or semicolon. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/dvb/frontends/drx397xD.c|7 --- drivers/media/dvb/frontends/drx397xD_fw.h |4 ++-- 2 files changed, 6 insertions(+), 5

[PATCH 17/75] nxt200x: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/dvb/frontends/nxt200x.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/dvb/frontends/nxt200x.c b/drivers/media/dvb/frontends/nxt200x.c index eac2065..9c6f530 100644 --- a/drivers/media

[PATCH 18/75] or51132: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/dvb/frontends/or51132.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/dvb/frontends/or51132.c b/drivers/media/dvb/frontends/or51132.c index 38e67ac..1b6529d 100644 --- a/drivers/media

[PATCH 19/75] or51211: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/dvb/frontends/or51211.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/dvb/frontends/or51211.c b/drivers/media/dvb/frontends/or51211.c index c709ce6..5102038 100644 --- a/drivers/media/dvb

[PATCH 20/75] sp8870: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/dvb/frontends/sp8870.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/dvb/frontends/sp8870.c b/drivers/media/dvb/frontends/sp8870.c index b85eb60..51bee98 100644 --- a/drivers/media/dvb

[PATCH 21/75] sp887x: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/dvb/frontends/sp887x.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/dvb/frontends/sp887x.c b/drivers/media/dvb/frontends/sp887x.c index 4a7c3d8..298e2a5 100644 --- a/drivers/media/dvb

[PATCH 22/75] tda10048: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/dvb/frontends/tda10048.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/dvb/frontends/tda10048.c b/drivers/media/dvb/frontends/tda10048.c index 4e2a7c8..175e90e 100644 --- a/drivers/media

[PATCH 23/75] tda1004x: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/dvb/frontends/tda1004x.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/dvb/frontends/tda1004x.c b/drivers/media/dvb/frontends/tda1004x.c index f2a8abe..0561aa1 100644 --- a/drivers/media

[PATCH 24/75] smsmdtv/smsusb: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/dvb/siano/sms-cards.c |4 drivers/media/dvb/siano/smscoreapi.c |7 +++ drivers/media/dvb/siano/smsusb.c |4 3 files changed, 15 insertions(+), 0 deletions(-) diff --git a/drivers/media/dvb/siano

[PATCH 25/75] dvb-ttpci/av7110: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/dvb/ttpci/av7110.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/dvb/ttpci/av7110.c b/drivers/media/dvb/ttpci/av7110.c index 8d65c65..5ddc9d6 100644 --- a/drivers/media/dvb/ttpci/av7110.c

[PATCH 26/75] ttusb-dec: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/dvb/ttusb-dec/ttusb_dec.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/media/dvb/ttusb-dec/ttusb_dec.c b/drivers/media/dvb/ttusb-dec/ttusb_dec.c index d91e063..f835852 100644 --- a/drivers

[PATCH 27/75] bttv: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/video/bt8xx/bttv-cards.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/bt8xx/bttv-cards.c b/drivers/media/video/bt8xx/bttv-cards.c index 12279f6..000b970 100644 --- a/drivers/media

[PATCH 28/75] cpia2: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/video/cpia2/cpia2_core.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/cpia2/cpia2_core.c b/drivers/media/video/cpia2/cpia2_core.c index 1cc0df8..8897032 100644 --- a/drivers/media

[PATCH 30/75] cx23885: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/video/cx23885/cx23885-417.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/cx23885/cx23885-417.c b/drivers/media/video/cx23885/cx23885-417.c index 0eed852..ff36155 100644

[PATCH 31/75] cx25840: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/video/cx25840/cx25840-firmware.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/cx25840/cx25840-firmware.c b/drivers/media/video/cx25840/cx25840-firmware.c index 8150200..6dd9253

[PATCH 32/75] cx88-blackbird: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/video/cx88/cx88-blackbird.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/cx88/cx88-blackbird.c b/drivers/media/video/cx88/cx88-blackbird.c index fbdc1cd..da62b37 100644

[PATCH 33/75] dabusb: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/video/dabusb.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/dabusb.c b/drivers/media/video/dabusb.c index ee43876..9b413a3 100644 --- a/drivers/media/video/dabusb.c +++ b/drivers

[PATCH 34/75] ivtv: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/video/ivtv/ivtv-firmware.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/ivtv/ivtv-firmware.c b/drivers/media/video/ivtv/ivtv-firmware.c index c1b7ec4..fd74d41 100644

[PATCH 35/75] pvrusb2: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/video/pvrusb2/pvrusb2-devattr.c |4 drivers/media/video/pvrusb2/pvrusb2-hdw.c |1 + 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/pvrusb2/pvrusb2-devattr.c b/drivers/media

[PATCH 36/75] s2255drv: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/video/s2255drv.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/s2255drv.c b/drivers/media/video/s2255drv.c index d0824f3..cf12356 100644 --- a/drivers/media/video/s2255drv.c +++ b

[PATCH 37/75] saa7164: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/video/saa7164/saa7164-fw.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/saa7164/saa7164-fw.c b/drivers/media/video/saa7164/saa7164-fw.c index ee0af35..b411fa0 100644 --- a/drivers

Re: [PATCH 29/75] cx18: declare MODULE_FIRMWARE

On Sat, 2009-11-07 at 20:40 -0500, Andy Walls wrote: On Sat, 2009-11-07 at 21:51 +, Ben Hutchings wrote: Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/video/cx18/cx18-av-firmware.c |1 + drivers/media/video/cx18/cx18-dvb.c |2 ++ drivers/media

[PATCH 0/4] V4L/DVB: Select correct frontends and tuners

I found a few more drivers that don't select the same frontends and tuners that they reference. Ben. Ben Hutchings (4): V4L/DVB: dw2102: Select tda10023 frontend, not tda10021 V4L/DVB: budget: Select correct frontends V4L/DVB: dib0700: Select dib0090 frontend V4L/DVB: m920x: Select

[PATCH 1/4] V4L/DVB: dw2102: Select tda10023 frontend, not tda10021

Update the Kconfig selections to match the code. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/dvb/dvb-usb/Kconfig |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/dvb/dvb-usb/Kconfig b/drivers/media/dvb/dvb-usb/Kconfig index e5f91f1

[PATCH 2/4] V4L/DVB: budget: Select correct frontends

Update the Kconfig selections to match the code. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/dvb/ttpci/Kconfig |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb/ttpci/Kconfig b/drivers/media/dvb/ttpci/Kconfig index d8d4214

[PATCH 3/4] V4L/DVB: dib0700: Select dib0090 frontend

Update the Kconfig selections to match the code. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/dvb/dvb-usb/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/dvb/dvb-usb/Kconfig b/drivers/media/dvb/dvb-usb/Kconfig index cfcbf4f

[PATCH 4/4] V4L/DVB: m920x: Select simple tuner

Update the Kconfig selections to match the code. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/dvb/dvb-usb/Kconfig |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/dvb/dvb-usb/Kconfig b/drivers/media/dvb/dvb-usb/Kconfig index 73a6e9d

[PATCH] V4L/DVB: mantis: Select correct frontends

Update the Kconfig selections to match the code. Add the usual condition of !DVB_FE_CUSTOMISE. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/dvb/mantis/Kconfig | 14 ++ 1 files changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/media/dvb/mantis

[PATCH] V4L/DVB: mantis: Rename gpio_set_bits to mantis_gpio_set_bits

This function is declared extern and exported, and should not be given a generic name which may conflict with gpiolib in future. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/dvb/mantis/hopper_vp3028.c |4 ++-- drivers/media/dvb/mantis/mantis_core.c |2 +- drivers

Re: Bug#655109: linux-2.6: BUG in videobuf-core triggered by mplayer on HVR-1300

you remember which was the first version where this bug appeared? Ben. Here's the dmesg output from a boot of the system: [removed; see http://bugs.debian.org/655109] -- Ben Hutchings Life is what happens to you while you're busy making other plans

Re: [PATCH 1/5] staging: lirc_serial: Fix init/exit order

everything except 9b98d6067971 (4/5) would be appropriate. Ben. -- Ben Hutchings One of the nice things about standards is that there are so many of them. signature.asc Description: This is a digitally signed message part

Re: [PATCH 3.0.y 0/4] Re: lirc_serial spuriously claims assigned port and irq to be in use

On Wed, Mar 07, 2012 at 12:04:07PM -0800, Greg Kroah-Hartman wrote: On Fri, Mar 02, 2012 at 02:39:13PM -0600, Jonathan Nieder wrote: Ben Hutchings wrote: On Thu, 2012-03-01 at 21:45 -0600, Jonathan Nieder wrote: Would some of these patches (e.g., at least patches 1, 2, and 5

Re: [GIT PULL] go7007 firmware updates

used up to now. If the driver has been changed in 3.10-rc to use different filenames, it's not too late to revert this mistake in the driver. But if such a change was made earlier, we'll need to add symlinks. Ben. -- Ben Hutchings Experience is what causes a person to make new mistakes instead

Re: [GIT PULL] go7007 firmware updates

On Mon, 2013-05-27 at 21:56 +0200, Hans Verkuil wrote: On Mon May 27 2013 18:24:32 Ben Hutchings wrote: On Thu, 2013-05-23 at 10:25 +0200, Hans Verkuil wrote: Hi Ben, David, The go7007 staging driver has been substantially overhauled for kernel 3.10. As part of that process

Re: [PATCH stable v3.7] media mantis: fix silly crash case

On Tue, 2013-05-21 at 15:07 +0200, Bjørn Mork wrote: Hello, Please apply mainline commit e1d45ae to any maintained stable kernel prior to v3.7. I just hit this bug on a Debian 3.2.41-2+deb7u2 kernel: [...] Queued up for 3.2, thanks. Ben. -- Ben Hutchings If at first you don't succeed

Re: [GIT PULL] go7007 firmware updates

On Tue, 2013-05-28 at 08:42 +0200, Hans Verkuil wrote: On Mon May 27 2013 23:53:15 Ben Hutchings wrote: On Mon, 2013-05-27 at 21:56 +0200, Hans Verkuil wrote: On Mon May 27 2013 18:24:32 Ben Hutchings wrote: On Thu, 2013-05-23 at 10:25 +0200, Hans Verkuil wrote: Hi Ben, David

[3.2-3.3 regression] mceusb: only every second keypress is recognised

to kernel 3.2 from sid, all back to normal. I have no idea how the kernel could be responsible there... ok, a weird bug in the responsible kernel module for the remote, but somehow I doubt that. The driver in question is mceusb. Ben. -- Ben Hutchings Every program is either trivial or else

Re: [git:v4l-dvb/for_v3.6] [media] gspca-core: Fix buffers staying in queued state after a stream_off

Ospite osp...@studenti.unina.it CC: sta...@vger.kernel.org Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com [...] This surely can't both be so important that it should go into stable updates, yet so unimportant that it can wait for 3.6. Ben. -- Ben Hutchings Lowery's Law

Re: [PATCH for stable] cx25821: Remove bad strcpy to read-only char*

/stable_kernel_rules.txt, so I guess it was enough to add a tag Cc: sta...@vger.kernel.org in the patch (right?). Now I know it :-) If I'm doing anything wrong, just yell at me. [...] An upstream commit hash would have helped, but I found it anyway. Queued up for 3.2.y. Ben. -- Ben Hutchings It is impossible

Re: [patch] [media] rc: divide by zero bugs in s_tx_carrier()

; + nvt_cir_reg_write(nvt, 1, CIR_CP); val = 300 / (carrier) - 1; nvt_cir_reg_write(nvt, val 0xff, CIR_CC); -- Ben Hutchings I say we take off; nuke the site from orbit. It's the only way to be sure. signature.asc Description: This is a digitally signed message part

[PATCH] [media] rc: ite-cir: Initialise ite_dev::rdev earlier

rc_allocate_device(). References: http://bugs.debian.org/684441 Reported-and-tested-by: YunQiang Su wzss...@gmail.com Signed-off-by: Ben Hutchings b...@decadent.org.uk Cc: sta...@vger.kernel.org --- drivers/media/rc/ite-cir.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2] [media] rc: ite-cir: Initialise ite_dev::rdev earlier

rc_allocate_device(). References: http://bugs.debian.org/684441 Reported-and-tested-by: YunQiang Su wzss...@gmail.com Signed-off-by: Ben Hutchings b...@decadent.org.uk Cc: sta...@vger.kernel.org --- Unlike the previous version, this will apply cleanly to the media staging/for_v3.6 branch. Ben

[PATCH] [media] rc: Fix invalid free_region and/or free_irq on probe failure

-tested only. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/rc/fintek-cir.c | 13 ++--- drivers/media/rc/ite-cir.c | 14 ++ drivers/media/rc/nuvoton-cir.c | 26 -- 3 files changed, 24 insertions(+), 29 deletions(-) diff --git

Re: [PATCH] [media] rc: Fix invalid free_region and/or free_irq on probe failure

On Tue, 2012-05-15 at 02:36 +0100, Ben Hutchings wrote: fintek-cir, ite-cir and nuvoton-cir may try to free an I/O region and/or IRQ handler that was never allocated after a failure in their respective probe functions. Add and use separate labels on the failure path so they will do the right

Firmware blob in vs6624 driver

source. Also, shouldn't you check the loaded firmware version first to verify that it's safe to apply the patch? Ben. -- Ben Hutchings You can't have everything. Where would you put it? signature.asc Description: This is a digitally signed message part

Re: [PATCH 5/8] nuvoton-cir: Code cleanup: remove unused variable and function

On Thu, Jun 14, 2012 at 02:58:13PM -0300, Peter Senna Tschudin wrote: Tested by compilation only. [...] I can't say whether this is correct since I never used the driver either, but the function you remove is reading registers so it may have important side-effects. Ben. -- Ben Hutchings We

Re: [PATCH 0/4] [media] Make lirc_bt829 a well-behaved PCI driver

On Mon, 2013-09-02 at 01:36 +0100, Ben Hutchings wrote: I noticed lirc_bt829 didn't have a module device ID table, so I set out to fix that and ended up with this series. It still appears to do everything else wrong (like reinventing i2c-algo-bit) though... This is compile-tested only

[PATCH v2 0/4] lirc_bt829 fixes, second try

A less ambitious set of fixes for the lirc_bt829 driver. Ben. Ben Hutchings (4): [media] lirc_bt829: Fix physical address type [media] lirc_bt829: Fix iomap and PCI device leaks [media] lirc_bt829: Enable and disable device [media] lirc_bt829: Note in TODO why it can't be a normal PCI

[PATCH v2 1/4] [media] lirc_bt829: Fix physical address type

Use phys_addr_t and log format %pa. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/staging/media/lirc/lirc_bt829.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_bt829.c b/drivers/staging/media/lirc/lirc_bt829.c index

[PATCH v2 2/4] [media] lirc_bt829: Fix iomap and PCI device leaks

We must call iounmap() and pci_dev_put() when removed and on the probe failure path. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/staging/media/lirc/lirc_bt829.c | 21 ++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/lirc

[PATCH v2 4/4] [media] lirc_bt829: Note in TODO why it can't be a normal PCI driver yet

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/staging/media/lirc/TODO | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/media/lirc/TODO b/drivers/staging/media/lirc/TODO index b6cb593..cbea5d8 100644 --- a/drivers/staging/media/lirc/TODO +++ b/drivers

[PATCH v2 3/4] [media] lirc_bt829: Enable and disable device

We must not assume that the PCI device is already enabled. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/staging/media/lirc/lirc_bt829.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/lirc/lirc_bt829.c b/drivers/staging/media

Re: [PATCH 01/51] DMA-API: provide a helper to set both DMA and coherent DMA masks

to the same or a smaller mask than the streaming mask. Ben. -- Ben Hutchings, Staff Engineer, Solarflare Not speaking for my employer; that's the marketing department's job. They asked us to note that Solarflare product names are trademarked. -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCHv2 07/29] platform drivers: Fix build on cris and frv archs

/asm/io.h so I don't know what the problem is there. Ben. -- Ben Hutchings Kids! Bringing about Armageddon can be dangerous. Do not attempt it in your own home. - Terry Pratchett and Neil Gaiman, `Good Omens' signature.asc Description: This is a digitally signed message part

[PATCH] drxk: Use BUG() for invalid numberOfParameters in QAMDemodulatorCommand()

it harder to ignore incorrect usage. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/media/dvb-frontends/drxk_hard.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/drxk_hard.c b/drivers/media/dvb-frontends/drxk_hard.c index 8b4c6d5

Re: [GIT PULL] linux-firmware: cx23885: update to Version 2.06.139

deletions(-) How odd, these two files are currently identical to each other... Ben. -- Ben Hutchings Always try to do things in chronological order; it's less confusing that way. signature.asc Description: This is a digitally signed message part

[PATCH 1/5] staging: lirc_serial: Fix init/exit order

. The module exit function removes the platform device before the character device that provides access to it. Change it to reverse the order of initialisation. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- The down-side of this is that module insertion now succeeds even if the device can't

[PATCH 2/5] staging: lirc_serial: Free resources on failure paths of lirc_serial_probe()

Failure to allocate the I/O region leaves the IRQ allocated. A later failure leaves them both allocated. Reported-by: Torsten Crass torsten.cr...@ebiology.de References: http://bugs.debian.org/645811 Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/staging/media/lirc/lirc_serial.c

[PATCH 3/5] staging: lirc_serial: Fix deadlock on resume failure

A resume function cannot remove the device it is resuming! Signed-off-by: Ben Hutchings b...@decadent.org.uk --- I haven't seen any report of this deadlock, but it seems pretty obvious. Ben. drivers/staging/media/lirc/lirc_serial.c |4 +--- 1 files changed, 1 insertions(+), 3 deletions

[PATCH 4/5] staging: lirc_serial: Fix bogus error codes

Device not found? ENODEV, not EINVAL. Write to read-only device? EPERM, not EBADF. Invalid argument? EINVAL, not ENOSYS. Unsupported ioctl? ENOIOCTLCMD, not ENOSYS. Another function returned an error code? Use that, don't replace it. Signed-off-by: Ben Hutchings b...@decadent.org.uk

[PATCH 5/5] staging: lirc_serial: Do not assume error codes returned by request_irq()

lirc_serial_probe() must fail if request_irq() returns an error, even if it isn't EBUSY or EINVAL, Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/staging/media/lirc/lirc_serial.c | 21 + 1 files changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers

[PATCH 11/11] dabusb: declare MODULE_FIRMWARE

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- Mauro, You nacked my previous patches for media because they would result in many false dependencies. However, I think this driver at least will always depend on the same files. Ben. drivers/media/video/dabusb.c |2 ++ 1 files changed

[PATCH] cxusb: Select all required frontend and tuner modules

cxusb uses the atbm8830 and lgs8gxx (not lgs8gl5) frontends and the max2165 tuner, so it needs to select them. Signed-off-by: Ben Hutchings b...@decadent.org.uk Cc: sta...@kernel.org --- drivers/media/dvb/dvb-usb/Kconfig |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git

Re: [PATCH] V4L/DVB: lgs8gxx: remove firmware for lgs8g75

On Tue, 2010-02-02 at 13:40 -0200, Mauro Carvalho Chehab wrote: Mauro Carvalho Chehab wrote: Ben Hutchings wrote: The recently added support for lgs8g75 included some 8051 machine code without accompanying source code. Replace this with use of the firmware loader. Compile-tested only

[PATCH firmware 6/6] Add firmware for lgs8g75

This is taken from the lgs8gxx driver as of 2.6.32-rc5. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- The binary changes are omitted from this message as they are impossible to review. Ben. WHENCE |9 + lgs8g75.fw | Bin 0 - 262 bytes 2 files changed, 9 insertions

Re: Firmware for cx23885 in linux-firmware.git is broken

(or the driver itself). For now, I think we should delete the current version. Ben. -- Ben Hutchings Absolutum obsoletum. (If it works, it's out of date.) - Stafford Beer signature.asc Description: This is a digitally signed message part

Re: Firmware for cx23885 in linux-firmware.git is broken

On Sun, 2013-02-24 at 11:36 -0500, Joseph Yasi wrote: On Sun, Feb 24, 2013 at 7:22 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em Sun, 24 Feb 2013 03:16:35 + Ben Hutchings b...@decadent.org.uk escreveu: [...] For now, I think we should delete the current version. That seems

Re: [PATCH v2] [media] rc: ite-cir: Initialise ite_dev::rdev earlier

On Tue, 2012-08-28 at 12:44 +0100, Luis Henriques wrote: On Mon, Aug 20, 2012 at 12:32:27AM +0100, Ben Hutchings wrote: ite_dev::rdev is currently initialised in ite_probe() after rc_register_device() returns. If a newly registered device is opened quickly enough, we may enable interrupts

Re: [patch v2] [media] rc-core: prevent divide by zero bug in s_tx_carrier()

a generic meaning to a value of 0 some time later. Ben. -- Ben Hutchings Time is nature's way of making sure that everything doesn't happen at once. signature.asc Description: This is a digitally signed message part

Re: [patch v2] [media] rc-core: prevent divide by zero bug in s_tx_carrier()

-by: Dan Carpenter dan.carpen...@oracle.com --- v2: Ben Hutchings pointed out that my first patch was not a complete fix. diff --git a/drivers/media/rc/ir-lirc-codec.c b/drivers/media/rc/ir-lirc-codec.c index 6ad4a07..28dc0f0 100644 --- a/drivers/media/rc/ir-lirc-codec.c +++ b

[PATCH 0/4] [media] Make lirc_bt829 a well-behaved PCI driver

I noticed lirc_bt829 didn't have a module device ID table, so I set out to fix that and ended up with this series. It still appears to do everything else wrong (like reinventing i2c-algo-bit) though... This is compile-tested only. Ben. Ben Hutchings (4): [media] lirc_bt829: Make it a proper

[PATCH 1/4] [media] lirc_bt829: Make it a proper PCI driver

, as the driver wasn't calling pci_dev_put(). Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/staging/media/lirc/lirc_bt829.c | 276 +--- 1 file changed, 144 insertions(+), 132 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_bt829.c b/drivers/staging

[PATCH 2/4] [media] lirc_bt829: Fix physical address type

Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/staging/media/lirc/lirc_bt829.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/media/lirc/lirc_bt829.c b/drivers/staging/media/lirc/lirc_bt829.c index c277bf3..8c5ba2a 100644 --- a/drivers

[PATCH 4/4] [media] lirc_bt829: Enable and disable memory BAR

We must not assume that the PCI device is already enabled. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/staging/media/lirc/lirc_bt829.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/lirc/lirc_bt829.c b/drivers/staging/media

[PATCH 3/4] [media] lirc_bt829: Fix iomap leak

We must call iounmap() when removed from a device. Signed-off-by: Ben Hutchings b...@decadent.org.uk --- drivers/staging/media/lirc/lirc_bt829.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/staging/media/lirc/lirc_bt829.c b/drivers/staging/media/lirc

Re: [PATCH 2/4] [media] lirc_bt829: Fix physical address type

On Sun, 2013-09-01 at 22:37 -0300, Fabio Estevam wrote: On Sun, Sep 1, 2013 at 9:39 PM, Ben Hutchings b...@decadent.org.uk wrote: pci_addr_phys = pdev-resource[0].start; - dev_info(pdev-dev, memory at 0x%08X\n, -(unsigned int)pci_addr_phys

[RFC PATCH 0/5] media: rcar_vin: Fixes for buffer management

This is a re-submission of patches previously sent and archived at http://thread.gmane.org/gmane.linux.ports.sh.devel/37184/. Will has rebased onto 3.18 and added a further patch to address Hans' review comments. The driver continues to works for single frame capture, and no longer provokes a

[RFC PATCH 1/5] media: rcar_vin: Dont aggressively retire buffers

From: Ian Molton ian.mol...@codethink.co.uk rcar_vin_videobuf_release() is called once per buffer from the buf_cleanup hook. There is no need to look up the queue and free all buffers at this point. Signed-off-by: Ian Molton ian.mol...@codethink.co.uk Signed-off-by: William Towle

[RFC PATCH 3/5] media: rcar_vin: Fix race condition terminating stream

From: Ian Molton ian.mol...@codethink.co.uk This patch fixes a race condition whereby a frame being captured may generate an interrupt between requesting capture to halt and freeing buffers. This condition is exposed by the earlier patch that explicitly calls vb2_buffer_done() during stop

[RFC PATCH 2/5] media: rcar_vin: Ensure all in-flight buffers are returned to error state before stopping.

From: Ian Molton ian.mol...@codethink.co.uk Videobuf2 complains about buffers that are still marked ACTIVE (in use by the driver) following a call to stop_streaming(). This patch returns all active buffers to state ERROR prior to stopping. Note: this introduces a (non fatal) race condition as

[RFC PATCH 4/5] media: rcar_vin: Clean up rcar_vin_irq

From: Ian Molton ian.mol...@codethink.co.uk This patch makes the rcar_vin IRQ handler a little more readable. Removes an else clause, and simplifies the buffer handling. Signed-off-by: Ian Molton ian.mol...@codethink.co.uk Reviewed-by: William Towle william.to...@codethink.co.uk ---

[RFC PATCH 5/5] media: rcar_vin: move buffer management to .stop_streaming handler

From: William Towle william.to...@codethink.co.uk Move the buffer state test in the .buf_cleanup handler into .stop_streaming so that a) the vb2_queue API is not subverted, and b) tracking of active-state buffers via priv-queue_buf[] is handled as early as is possible Signed-off-by: William

Re: [RFC PATCH 5/5] media: rcar_vin: move buffer management to .stop_streaming handler

On Sun, 2015-01-18 at 22:23 +0100, Guennadi Liakhovetski wrote: On Thu, 18 Dec 2014, Ben Hutchings wrote: From: William Towle william.to...@codethink.co.uk Move the buffer state test in the .buf_cleanup handler into .stop_streaming so that a) the vb2_queue API is not subverted, and b

Re: [Linux-kernel] [PATCH 13/20] media: soc_camera: v4l2-compliance fixes for querycap

On Thu, 2015-05-21 at 13:46 +0100, Rob Taylor wrote: On 21/05/15 06:58, Hans Verkuil wrote: On 05/20/2015 06:39 PM, William Towle wrote: Fill in bus_info field and zero reserved field. Signed-off-by: Rob Taylor rob.tay...@codethink.co.uk Reviewed-by: William Towle

Re: [PATCH 2/4] WHENCE: use https://linuxtv.org for LinuxTV URLs

;   >  Licence: GPLv2 or later >   > -ARM assembly source code available at > http://www.linuxtv.org/downloads/firmware/Boot.S > +ARM assembly source code available at > https://linuxtv.org/downloads/firmware/Boot.S >   >  ----------

[PATCH] [media] dvb-usb-dibusb-mc-common: Add MODULE_LICENSE

ia] dvb-usb: split out common parts of dibusb") Signed-off-by: Ben Hutchings <b...@decadent.org.uk> --- drivers/media/usb/dvb-usb/dibusb-mc-common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/usb/dvb-usb/dibusb-mc-common.c b/drivers/media/usb/dvb-usb/dibusb-mc-commo

  1   2   >