[PATCH] drivers/media/dvb/dvb-usb/dib0700: fix return values

Propagte correct error values instead of returning -1 which just means -EPERM (Permission denied) While at it, also fix some coding style violations. Signed-off-by: Daniel Mack dan...@caiaq.de Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: Jiri Slaby jsl...@suse.cz Cc: Dmitry Torokhov d

[PATCH] drivers/media/dvb/dvb-usb/dib0700: fix return values

Propagte correct error values instead of returning -1 which just means -EPERM (Permission denied) While at it, also fix some coding style violations. Signed-off-by: Daniel Mack dan...@caiaq.de Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: Jiri Slaby jsl...@suse.cz Cc: Dmitry Torokhov d

[PATCH 1/2] drivers/media/dvb/dvb-usb/dib0700: fix return values

Propagte correct error values instead of returning -1 which just means -EPERM (Permission denied) Signed-off-by: Daniel Mack dan...@caiaq.de Cc: Wolfram Sang w.s...@pengutronix.de Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: Jiri Slaby jsl...@suse.cz Cc: Dmitry Torokhov d...@mail.ru Cc

[PATCH] drivers/media/dvb/dvb-usb/dib0700: CodingStyle fixes

Signed-off-by: Daniel Mack dan...@caiaq.de Cc: Wolfram Sang w.s...@pengutronix.de Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: Jiri Slaby jsl...@suse.cz Cc: Dmitry Torokhov d...@mail.ru Cc: Devin Heitmueller dheitmuel...@kernellabs.com Cc: linux-media@vger.kernel.org --- drivers/media/dvb

Re: [PATCH] drivers/media/dvb/dvb-usb/dib0700: CodingStyle fixes

On Mon, May 24, 2010 at 08:56:24AM -0700, Dmitry Torokhov wrote: On Mon, May 24, 2010 at 05:23:05PM +0200, Daniel Mack wrote: Signed-off-by: Daniel Mack dan...@caiaq.de Cc: Wolfram Sang w.s...@pengutronix.de Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: Jiri Slaby jsl...@suse.cz

Re: A reliable kernel panic (3.6.2) and system crash when visiting a particular website

On 03.11.2012 15:10, Christof Meerwald wrote: On Sat, 20 Oct 2012 23:15:17 + (GMT), Artem S. Tashkinov wrote: It's almost definitely either a USB driver bug or video4linux driver bug: I'm CC'ing linux-media and linux-usb mailing lists, the problem is described here:

Re: A reliable kernel panic (3.6.2) and system crash when visiting a particular website

On 21.10.2012 01:15, Artem S. Tashkinov wrote: You don't get me - I have *no* VirtualBox (or any proprietary) modules running - but I can reproduce this problem using *the same system running under* VirtualBox in Windows 7 64. It's almost definitely either a USB driver bug or video4linux

Re: A reliable kernel panic (3.6.2) and system crash when visiting a particular website

On 21.10.2012 12:34, Daniel Mack wrote: On 21.10.2012 01:15, Artem S. Tashkinov wrote: You don't get me - I have *no* VirtualBox (or any proprietary) modules running - but I can reproduce this problem using *the same system running under* VirtualBox in Windows 7 64. It's almost

Re: A reliable kernel panic (3.6.2) and system crash when visiting a particular website

On 21.10.2012 13:59, Artem S. Tashkinov wrote: On Oct 21, 2012, Borislav Petkov wrote: On Sun, Oct 21, 2012 at 01:57:21AM +, Artem S. Tashkinov wrote: The freeze happens on my *host* Linux PC. For an experiment I decided to check if I could reproduce the freeze under a virtual machine -

Re: A reliable kernel panic (3.6.2) and system crash when visiting a particular website

On 21.10.2012 13:59, Artem S. Tashkinov wrote: On Oct 21, 2012, Borislav Petkov wrote: On Sun, Oct 21, 2012 at 01:57:21AM +, Artem S. Tashkinov wrote: The freeze happens on my *host* Linux PC. For an experiment I decided to check if I could reproduce the freeze under a virtual machine -

Re: was: Re: A reliable kernel panic (3.6.2) and system crash when visiting a particular website

[Cc: alsa-devel] On 21.10.2012 14:30, Artem S. Tashkinov wrote: On Oct 21, 2012, Daniel Mack wrote: A hint at least. How did you enable the audio record exactly? Can you reproduce this with arecord? What chipset are you on? Please provide both lspci -v and lsusb -v dumps. As I said, I

Re: was: Re: A reliable kernel panic (3.6.2) and system crash when visiting a particular website

On 21.10.2012 16:57, Artem S. Tashkinov wrote: On Oct 21, 2012, Daniel Mack wrote: [Cc: alsa-devel] On 21.10.2012 14:30, Artem S. Tashkinov wrote: On Oct 21, 2012, Daniel Mack wrote: A hint at least. How did you enable the audio record exactly? Can you reproduce this with arecord

Re: A reliable kernel panic (3.6.2) and system crash when visiting a particular website

On 21.10.2012 21:49, Artem S. Tashkinov wrote: On Oct 21, 2012, Borislav Petkov b...@alien8.de wrote: On Sun, Oct 21, 2012 at 11:59:36AM +, Artem S. Tashkinov wrote: http://imageshack.us/a/img685/9452/panicz.jpg list_del corruption. prev-next should be ... but was ... Btw, this is

Re: A reliable kernel panic (3.6.2) and system crash when visiting a particular website

On 21.10.2012 22:43, Artem S. Tashkinov wrote: Nice. Could you do that again with the patch applied I sent yo some hours ago? That patch was of no help - the system has crashed and I couldn't spot relevant messages. I've no idea what it means. The sequence of driver callbacks issued on

Re: A reliable kernel panic (3.6.2) and system crash when visiting a particular website

On 22.10.2012 17:17, Alan Stern wrote: On Sun, 21 Oct 2012, Artem S. Tashkinov wrote: dmesg messages up to a crash can be seen here: https://bugzilla.kernel.org/attachment.cgi?id=84221 The first problem in the log is endpoint list corruption. Here's a debugging patch which should

Re: [PATCH 44/50] sound: usb: caiaq: spin_lock in complete() cleanup

On 11.07.2013 11:06, Ming Lei wrote: Complete() will be run with interrupt enabled, so change to spin_lock_irqsave(). Cc: Daniel Mack zon...@gmail.com Cc: Jaroslav Kysela pe...@perex.cz Cc: Takashi Iwai ti...@suse.de Cc: alsa-de...@alsa-project.org Signed-off-by: Ming Lei ming

Re: [RFC v2 3/3] dt: bindings: Add a binding for referencing EEPROM from camera sensors

On 05/29/2017 02:20 PM, Sakari Ailus wrote: > On Mon, May 08, 2017 at 12:24:18PM -0500, Rob Herring wrote: >> On Fri, May 05, 2017 at 11:48:30AM +0300, Sakari Ailus wrote: >>> Many camera sensor devices contain EEPROM chips that describe the >>> properties of a given unit --- the data is specific

Composite MIPI camera devices

Hi everyone, On an embedded board I'm working on, I need to interface a camera that exposes three distinct I2C addresses: one for the imaging sensor (OmniVision), one focus motor driver and one EEPROM. Usually such cameras hide their complexity behind one common interface, but this one just

Re: [PATCH v4 04/21] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document

Hi, On 28.08.2017 09:10, Todor Tomov wrote: > On 25.08.2017 17:10, Daniel Mack wrote: >> Could you explain how ISPIF, CSID and CSIPHY are related? >> >> I have a userspace test setup that works fine for USB webcams, but when >> operating on any of the video dev

Re: [PATCH v4 04/21] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document

Hi Todor, On 08/28/2017 09:10 AM, Todor Tomov wrote: > On 25.08.2017 17:10, Daniel Mack wrote: >> I have a userspace test setup that works fine for USB webcams, but when >> operating on any of the video devices exposed by this driver, the >> lowlevel functions such as .s_pow

Re: [PATCH v4 04/21] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document

Hi Todor, Thanks a lot for working on the upstream support for this! On 08/08/2017 03:30 PM, Todor Tomov wrote: > +The Camera Subsystem hardware found on 8x16 processors and supported by the > +driver consists of: > + > +- 2 CSIPHY modules. They handle the Physical layer of the CSI2 receivers. >

Re: camss: camera controls missing on vfe interfaces

Todor et all, Any hint on how to tackle this? I can contribute patches, but I'd like to understand what the idea is. Thanks, Daniel On Thursday, October 26, 2017 06:11 PM, Daniel Mack wrote: > Hi Todor, > > When using the camss driver trough one of its /dev/videoX dev

Re: camss: camera controls missing on vfe interfaces

Hi Todor, everyone, On Monday, November 20, 2017 11:59 AM, Daniel Mack wrote: > On Monday, November 20, 2017 09:32 AM, Todor Tomov wrote: >> It is not a missing feature, it is more of a missing userspace >> implementation. >> When working with a media oriented device driv

Re: camss: camera controls missing on vfe interfaces

Hi Todor, Thanks for following up! On Monday, November 20, 2017 09:32 AM, Todor Tomov wrote: > On 15.11.2017 21:31, Daniel Mack wrote: >> Todor et all, >> >> Any hint on how to tackle this? >> >> I can contribute patches, but I'd like to understand what the id

Re: camss: camera controls missing on vfe interfaces

Hi, FWIW, we are using the attached trivial patch in our tree now. Not sure if this is interesting for upstream, but it does solve our problem. Let me know what you think. Thanks, Daniel On Monday, November 27, 2017 12:50 AM, Daniel Mack wrote: > Hi Todor, everyone, > > On Monday,

Re: [PATCH v4 04/21] doc: media/v4l-drivers: Add Qualcomm Camera Subsystem driver document

Hi Todor, On Wednesday, October 25, 2017 02:07 PM, Todor Tomov wrote: > On 16.10.2017 18:01, Daniel Mack wrote: >> I'd be grateful for any pointer about what I could investigate on. >> > > Everything that you have described seems correct. > > As you say that frames

Re: [PATCH v3 01/12] media: ov5640: Fix timings setup code

Hi, On Thursday, May 17, 2018 10:53 AM, Maxime Ripard wrote: From: Samuel Bobrowicz The current code, when changing the mode and changing the scaling or sampling parameters, will look at the horizontal and vertical total size, which, since 5999f381e023 ("media:

Re: [PATCH v3 00/12] media: ov5640: Misc cleanup and improvements

Hi, On Thursday, May 17, 2018 10:53 AM, Maxime Ripard wrote: Here is a "small" series that mostly cleans up the ov5640 driver code, slowly getting rid of the big data array for more understandable code (hopefully). The biggest addition would be the clock rate computation at runtime, instead of

Re: [PATCH v3 03/12] media: ov5640: Remove the clocks registers initialization

On Thursday, May 17, 2018 10:53 AM, Maxime Ripard wrote: Part of the hardcoded initialization sequence is to set up the proper clock dividers. However, this is now done dynamically through proper code and as such, the static one is now redundant. Let's remove it. Signed-off-by: Maxime Ripard

Re: [PATCH v3 03/12] media: ov5640: Remove the clocks registers initialization

Hi, On Saturday, May 19, 2018 04:42 AM, Sam Bobrowicz wrote: This set of patches is also not working for my MIPI platform (mine has a 12 MHz external clock). I am pretty sure is isn't working because it does not include the following, which my tests have found to be necessary: 1) Setting pclk

Re: [PATCH 05/15] mtd: nand: pxa3xx: remove the dmaengine compat need

Hi Robert, Please refer to the attached patch instead of the one I sent earlier. I missed to also remove the platform_get_resource(IORESOURCE_DMA) call. Thanks, Daniel On Friday, May 18, 2018 11:31 PM, Daniel Mack wrote: Hi Robert, Thanks for this series. On Monday, April 02, 2018 04:26

Re: [PATCH v3 03/12] media: ov5640: Remove the clocks registers initialization

Hi Maxime, On Tuesday, May 22, 2018 09:54 PM, Maxime Ripard wrote: On Mon, May 21, 2018 at 09:39:02AM +0200, Maxime Ripard wrote: On Fri, May 18, 2018 at 07:42:34PM -0700, Sam Bobrowicz wrote: This set of patches is also not working for my MIPI platform (mine has a 12 MHz external clock). I

Re: [PATCH v2 08/13] ASoC: pxa: remove the dmaengine compat need

the more generic function dma_request_slave_channel(). Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Reviewed-by: Daniel Mack <dan...@zonque.org> --- sound/arm/pxa2xx-ac97.c | 14 ++ sound/arm/pxa2xx-pcm-lib.c | 6 +++--- sound/soc/pxa/pxa2xx

Re: [PATCH v2 13/13] ARM: pxa: change SSP DMA channels allocation

. is a 1-1 match to ssp., and the channels are either "rx" or "tx". - for device tree platforms, the dma node should be hooked into the pxa2xx-ac97 or pxa-ssp-dai node. Signed-off-by: Robert Jarzmik <robert.jarz...@free.fr> Acked-by: Daniel Mack <dan...@zonque.org

Re: [PATCH 05/15] mtd: nand: pxa3xx: remove the dmaengine compat need

mtd/nand/raw/marvell_nand.c recently, so this patch can be dropped. I attached a version for the new driver which you can pick instead. Thanks, Daniel >From c63bc40bdfe2d596e42919235840109a2f1b2776 Mon Sep 17 00:00:00 2001 From: Daniel Mack <dan...@zonque.org> Date: Sat, 12 May 2018 2

camss: camera controls missing on vfe interfaces

Hi Todor, When using the camss driver trough one of its /dev/videoX device nodes, applications are currently unable to see the video controls the camera sensor exposes. Same goes for other ioctls such as VIDIOC_ENUM_FMT, so the only valid resolution setting for applications to use is the one

[PATCH 1/3] media: ov5640: initialize mode data structs by name

This patch initializes the members of struct ov5640_mode_info by name for better readability. This makes later additions to this struct easier. No functional change intended. Signed-off-by: Daniel Mack <dan...@zonque.org> --- drivers/media/i2c/ov5640.c

[PATCH 3/3] media: ov5640: add support for xclk frequency control

Allow setting the xclk rate via an optional 'clock-frequency' property in the device tree node. Signed-off-by: Daniel Mack <dan...@zonque.org> --- Documentation/devicetree/bindings/media/i2c/ov5640.txt | 2 ++ drivers/media/i2c/ov5640.c | 10 ++ 2

[PATCH 2/3] media: ov5640: add PIXEL_RATE and LINK_FREQ controls

Add v4l2 controls to report the pixel and MIPI link rates of each mode. The camss camera subsystem needs them to set up the correct hardware clocks. Tested on msm8016 based hardware. Signed-off-by: Daniel Mack <dan...@zonque.org> --- drivers/media/i2c/ov5640.

Re: [PATCH 2/3] media: ov5640: add PIXEL_RATE and LINK_FREQ controls

Hi, On Friday, April 20, 2018 04:15 PM, Maxime Ripard wrote: > On Fri, Apr 20, 2018 at 11:44:18AM +0200, Daniel Mack wrote: >> struct ov5640_ctrls { >> struct v4l2_ctrl_handler handler; >> +struct { >> +struct v4l2_ctrl *link_freq; >&

Re: [PATCH 2/3] media: ov5640: add PIXEL_RATE and LINK_FREQ controls

Hi, On Tuesday, April 24, 2018 12:22 PM, Sakari Ailus wrote: > On Fri, Apr 20, 2018 at 11:44:18AM +0200, Daniel Mack wrote: >> Add v4l2 controls to report the pixel and MIPI link rates of each mode. >> The camss camera subsystem needs them to set up the correct hardware >>