Re: [PATCH] IR/imon: remove incorrect calls to input_free_device

2010-07-26 Thread Dmitry Torokhov
On Mon, Jul 26, 2010 at 10:13:52AM -0400, Jarod Wilson wrote: Per Dmitry Torokhov (in a completely unrelated thread on linux-input), following input_unregister_device with an input_free_device is forbidden, the former is sufficient alone. CC: Dmitry Torokhov dmitry.torok...@gmail.com Signed

Handling of large keycodes

2010-07-31 Thread Dmitry Torokhov
a look and let me know if I missed something important. Thank you. -- Dmitry Signed-off-by: Dmitry Torokhov d...@mail.ru --- drivers/char/keyboard.c | 31 +++- drivers/input/evdev.c | 139 +++ drivers/input/input.c | 351

Re: Handling of large keycodes

2010-08-02 Thread Dmitry Torokhov
On Sat, Jul 31, 2010 at 10:23:45AM -0300, Mauro Carvalho Chehab wrote: Hi Dmitry, Em 31-07-2010 06:19, Dmitry Torokhov escreveu: Hi Mauro, I finally got a chance to review the patches adding handling of large scancodes to input core and there are a few things with this approach

Re: Handling of large keycodes

2010-08-02 Thread Dmitry Torokhov
On Sat, Jul 31, 2010 at 01:03:26PM +0200, Stefan Richter wrote: Dmitry Torokhov wrote: --- a/include/linux/input.h +++ b/include/linux/input.h @@ -56,22 +56,35 @@ struct input_absinfo { __s32 resolution; }; -struct keycode_table_entry { - __u32 keycode; /* e.g

[PATCH 0/6] Large scancode handling

2010-09-08 Thread Dmitry Torokhov
Hi Mauro, I guess I better get off my behind and commit the changes to support large scancodes, or they will not make to 2.6.37 either... There isn't much changes, except I followed David's suggestion and changed boolean index field into u8 flags field. Still, please glance it over once again and

[PATCH 2/6] Input: sparse-keymap - switch to using new keycode interface

2010-09-08 Thread Dmitry Torokhov
Switch sparse keymap library to use new style of getkeycode and setkeycode methods to allow retrieving and setting keycodes not only by their scancodes but also by index. Signed-off-by: Dmitry Torokhov d...@mail.ru --- drivers/input/sparse-keymap.c | 81

[PATCH 1/6] Input: add support for large scancodes

2010-09-08 Thread Dmitry Torokhov
. Folded fixes by: - Dan Carpenter: locking fixes for the original implementation - Jarod Wilson: fix crash when setting keycode and wiring up get/set handlers in original implementation. - Dmitry Torokhov: rework to consolidate old and new scancode handling, provide

[PATCH 4/6] Input: winbond-cir - switch to using new keycode interface

2010-09-08 Thread Dmitry Torokhov
Switch the code to use new style of getkeycode and setkeycode methods to allow retrieving and setting keycodes not only by their scancodes but also by index. Signed-off-by: Dmitry Torokhov d...@mail.ru --- drivers/input/misc/winbond-cir.c | 248 +- 1 files

[PATCH 5/6] Input: ati-remote2 - switch to using new keycode interface

2010-09-08 Thread Dmitry Torokhov
Switch the code to use new style of getkeycode and setkeycode methods to allow retrieving and setting keycodes not only by their scancodes but also by index. Signed-off-by: Dmitry Torokhov d...@mail.ru --- drivers/input/misc/ati_remote2.c | 93 +++--- 1 files

[PATCH 6/6] Input: media/IR - switch to using new keycode interface

2010-09-08 Thread Dmitry Torokhov
Switch the code to use new style of getkeycode and setkeycode methods to allow retrieving and setting keycodes not only by their scancodes but also by index. Signed-off-by: Dmitry Torokhov d...@mail.ru --- drivers/media/IR/ir-keytable.c | 393 +++- include

[PATCH 3/6] Input: hid-input - switch to using new keycode interface

2010-09-08 Thread Dmitry Torokhov
Switch HID code to use new style of getkeycode and setkeycode methods to allow retrieving and setting keycodes not only by their scancodes but also by index. Signed-off-by: Dmitry Torokhov d...@mail.ru --- drivers/hid/hid-input.c | 103 --- 1 files

Re: [PATCH 0/6] Large scancode handling

2010-09-08 Thread Dmitry Torokhov
On Wed, Sep 08, 2010 at 10:31:21AM -0400, Jarod Wilson wrote: On Wed, Sep 08, 2010 at 12:41:38AM -0700, Dmitry Torokhov wrote: Hi Mauro, I guess I better get off my behind and commit the changes to support large scancodes, or they will not make to 2.6.37 either... There isn't much

Re: [PATCH 0/6] Large scancode handling

2010-09-08 Thread Dmitry Torokhov
On Wed, Sep 08, 2010 at 05:25:13PM +0200, Jiri Kosina wrote: On Wed, 8 Sep 2010, Jarod Wilson wrote: It'll conflict a little bith with the tivo slide patch I posted yesterday, but mostly just minor context changes. I can redo that patch on top of these changes if that's

Re: [PATCH 0/6] Large scancode handling

2010-09-08 Thread Dmitry Torokhov
On Wed, Sep 08, 2010 at 11:48:50AM +0200, Jiri Kosina wrote: On Wed, 8 Sep 2010, Dmitry Torokhov wrote: Hi Mauro, I guess I better get off my behind and commit the changes to support large scancodes, or they will not make to 2.6.37 either... There isn't much changes, except I

Re: [PATCH 0/6] Large scancode handling

2010-09-08 Thread Dmitry Torokhov
On Wed, Sep 08, 2010 at 12:09:08PM -0400, Jarod Wilson wrote: On Wed, Sep 08, 2010 at 05:25:13PM +0200, Jiri Kosina wrote: On Wed, 8 Sep 2010, Jarod Wilson wrote: It'll conflict a little bith with the tivo slide patch I posted yesterday, but mostly just minor context changes.

Re: [PATCH 4/6] Input: winbond-cir - switch to using new keycode interface

2010-09-08 Thread Dmitry Torokhov
On Wed, Sep 08, 2010 at 11:16:17PM +0200, David Härdeman wrote: On Wed, Sep 08, 2010 at 12:42:00AM -0700, Dmitry Torokhov wrote: Switch the code to use new style of getkeycode and setkeycode methods to allow retrieving and setting keycodes not only by their scancodes but also by index

Re: [PATCH 5/6] Input: ati-remote2 - switch to using new keycode interface

2010-09-13 Thread Dmitry Torokhov
On Thu, Sep 09, 2010 at 03:40:04PM +0300, Ville Syrjälä wrote: On Wed, Sep 08, 2010 at 12:42:05AM -0700, Dmitry Torokhov wrote: Switch the code to use new style of getkeycode and setkeycode methods to allow retrieving and setting keycodes not only by their scancodes but also by index

Re: [PATCH 0/6] Large scancode handling

2010-09-13 Thread Dmitry Torokhov
On Mon, Sep 13, 2010 at 01:48:14PM -0400, Jarod Wilson wrote: On Wed, Sep 8, 2010 at 11:34 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wed, Sep 08, 2010 at 10:31:21AM -0400, Jarod Wilson wrote: On Wed, Sep 08, 2010 at 12:41:38AM -0700, Dmitry Torokhov wrote: ... Ville, do you

Re: [PATCH 5/6] Input: ati-remote2 - switch to using new keycode interface

2010-09-15 Thread Dmitry Torokhov
On Thu, Sep 16, 2010 at 12:04:19AM +0300, Ville Syrjälä wrote: On Mon, Sep 13, 2010 at 09:28:07AM -0700, Dmitry Torokhov wrote: On Thu, Sep 09, 2010 at 03:40:04PM +0300, Ville Syrjälä wrote: On Wed, Sep 08, 2010 at 12:42:05AM -0700, Dmitry Torokhov wrote: Switch the code to use new style

Re: drivers/media/IR/ir-keytable.c::ir_getkeycode - 'retval' may be used uninitialized

2010-10-31 Thread Dmitry Torokhov
be used uninitialized in this function It is due to an actual bug but I don't know the fix. The patch below should fix it. I wonder if Linus released -rc1 yet... -- Dmitry Input: ir-keytable - fix uninitialized variable warning From: Dmitry Torokhov dmitry.torok...@gmail.com We were

Re: drivers/media/IR/ir-keytable.c::ir_getkeycode - 'retval' may be used uninitialized

2010-11-02 Thread Dmitry Torokhov
On Tue, Nov 02, 2010 at 12:04:56PM -0400, Jarod Wilson wrote: On Sun, Oct 31, 2010 at 6:18 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Sunday, October 31, 2010 10:51:21 am Stefan Richter wrote: Commit 9f470095068e Input: media/IR - switch to using new keycode interface added

Re: Fwd: [PATH] Fix rc-tbs-nec table after converting the cx88 driver to ir-core

2010-11-16 Thread Dmitry Torokhov
On Tuesday, November 16, 2010 09:39:09 am Mauro Carvalho Chehab wrote: Hi Dmitry, This patch fixes an IR table. The patch is trivial, but there are two buttons on this IR that are not directly supported currently (buttons 10- and 10+). In a matter of fact, some other IR's use other key codes

[RFC] Input: define separate EVIOCGKEYCODE_V2/EVIOCSKEYCODE_V2

2010-12-09 Thread Dmitry Torokhov
-by: Dmitry Torokhov d...@mail.ru --- drivers/input/evdev.c | 113 + include/linux/input.h |6 ++- 2 files changed, 62 insertions(+), 57 deletions(-) diff --git a/drivers/input/evdev.c b/drivers/input/evdev.c index 17660b1..915287e 100644

Re: [RFC] Input: define separate EVIOCGKEYCODE_V2/EVIOCSKEYCODE_V2

2010-12-09 Thread Dmitry Torokhov
On Thu, Dec 09, 2010 at 08:04:36PM +0100, Henrik Rydberg wrote: On 12/09/2010 10:39 AM, Dmitry Torokhov wrote: The desire to keep old names for the EVIOCGKEYCODE/EVIOCSKEYCODE while extending them to support large scancodes was a mistake. While we tried to keep ABI intact (and we

Re: [RFC] Input: define separate EVIOCGKEYCODE_V2/EVIOCSKEYCODE_V2

2010-12-13 Thread Dmitry Torokhov
On Thu, Dec 09, 2010 at 11:16:47AM -0800, Dmitry Torokhov wrote: On Thu, Dec 09, 2010 at 08:04:36PM +0100, Henrik Rydberg wrote: On 12/09/2010 10:39 AM, Dmitry Torokhov wrote: The desire to keep old names for the EVIOCGKEYCODE/EVIOCSKEYCODE while extending them to support large

Re: [PATCH] firedtv: fix remote control with newer Xorg evdev

2011-01-17 Thread Dmitry Torokhov
Hi Stefan, On Sun, Jan 16, 2011 at 09:39:21AM +0100, Stefan Richter wrote: @@ -188,6 +189,7 @@ void fdtv_handle_rc(struct firedtv *fdtv return; } - input_report_key(fdtv-remote_ctrl_dev, code, 1); - input_report_key(fdtv-remote_ctrl_dev, code, 0); +

Re: [PATCH update] firedtv: fix remote control with newer Xorg evdev

2011-01-17 Thread Dmitry Torokhov
their state. Signed-off-by: Stefan Richter stef...@s5r6.in-berlin.de Acked-by: Dmitry Torokhov d...@mail.ru --- drivers/media/dvb/firewire/firedtv-rc.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) Index: b/drivers/media/dvb/firewire/firedtv-rc.c

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-24 Thread Dmitry Torokhov
On Tue, Jan 25, 2011 at 12:07:29AM -0500, Mark Lord wrote: On 11-01-25 12:04 AM, Mark Lord wrote: On 11-01-24 11:55 PM, Dmitry Torokhov wrote: On Mon, Jan 24, 2011 at 11:37:06PM -0500, Mark Lord wrote: .. This results in (map-size==10) for 2.6.36+ (wrong), and a much larger map-size

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-24 Thread Dmitry Torokhov
On Mon, Jan 24, 2011 at 09:31:17PM -0800, Dmitry Torokhov wrote: On Tue, Jan 25, 2011 at 12:07:29AM -0500, Mark Lord wrote: On 11-01-25 12:04 AM, Mark Lord wrote: On 11-01-24 11:55 PM, Dmitry Torokhov wrote: On Mon, Jan 24, 2011 at 11:37:06PM -0500, Mark Lord wrote: .. This results

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-25 Thread Dmitry Torokhov
On Tue, Jan 25, 2011 at 09:42:44AM -0200, Mauro Carvalho Chehab wrote: Em 25-01-2011 03:31, Dmitry Torokhov escreveu: On Tue, Jan 25, 2011 at 12:07:29AM -0500, Mark Lord wrote: On 11-01-25 12:04 AM, Mark Lord wrote: On 11-01-24 11:55 PM, Dmitry Torokhov wrote: On Mon, Jan 24, 2011 at 11

Re: Extending rc-core/userspace to handle bigger scancodes - Was: Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-25 Thread Dmitry Torokhov
On Tue, Jan 25, 2011 at 12:42:57PM -0200, Mauro Carvalho Chehab wrote: Em 25-01-2011 04:52, Dmitry Torokhov escreveu: On Mon, Jan 24, 2011 at 09:31:17PM -0800, Dmitry Torokhov wrote: On Tue, Jan 25, 2011 at 12:07:29AM -0500, Mark Lord wrote: On 11-01-25 12:04 AM, Mark Lord wrote: On 11-01

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-25 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 06:09:45AM +1000, Linus Torvalds wrote: On Wed, Jan 26, 2011 at 2:48 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: We should be able to handle the case where scancode is valid even though it might be unmapped yet. This is regardless of what version

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-25 Thread Dmitry Torokhov
On Tue, Jan 25, 2011 at 12:54:53PM -0800, Dmitry Torokhov wrote: On Wed, Jan 26, 2011 at 06:09:45AM +1000, Linus Torvalds wrote: On Wed, Jan 26, 2011 at 2:48 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: We should be able to handle the case where scancode is valid even though

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-25 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 07:20:07AM +1000, Linus Torvalds wrote: On Wed, Jan 26, 2011 at 7:01 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: BTW, another issue is that evdev's ioctl returns -EINVAL for unknown ioctls so applications would have hard time figuring out whether error

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-25 Thread Dmitry Torokhov
On Tue, Jan 25, 2011 at 05:22:09PM -0500, Mark Lord wrote: On 11-01-25 05:00 PM, Mauro Carvalho Chehab wrote: Em 25-01-2011 18:54, Dmitry Torokhov escreveu: On Wed, Jan 26, 2011 at 06:09:45AM +1000, Linus Torvalds wrote: On Wed, Jan 26, 2011 at 2:48 AM, Dmitry Torokhov dmitry.torok

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-25 Thread Dmitry Torokhov
On Tue, Jan 25, 2011 at 03:29:14PM -0800, Dmitry Torokhov wrote: On Tue, Jan 25, 2011 at 05:22:09PM -0500, Mark Lord wrote: On 11-01-25 05:00 PM, Mauro Carvalho Chehab wrote: Em 25-01-2011 18:54, Dmitry Torokhov escreveu: On Wed, Jan 26, 2011 at 06:09:45AM +1000, Linus Torvalds wrote

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 10:05:57AM -0500, Mark Lord wrote: On 11-01-25 09:00 PM, Dmitry Torokhov wrote: On Tue, Jan 25, 2011 at 03:29:14PM -0800, Dmitry Torokhov wrote: On Tue, Jan 25, 2011 at 05:22:09PM -0500, Mark Lord wrote: On 11-01-25 05:00 PM, Mauro Carvalho Chehab wrote: Em 25-01

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 12:18:29PM -0200, Mauro Carvalho Chehab wrote: Em 26-01-2011 11:08, Gerd Hoffmann escreveu: Hi, Btw, I took some time to take analyse the input-kbd stuff. As said at the README: This is a small collection of input layer utilities. I wrote them

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 12:18:29PM -0200, Mauro Carvalho Chehab wrote: diff --git a/input.c b/input.c index d57a31e..a9bd5e8 100644 --- a/input.c +++ b/input.c @@ -101,8 +101,8 @@ int device_open(int nr, int verbose) close(fd); return -1; } - if

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 03:41:01PM -0200, Mauro Carvalho Chehab wrote: Em 26-01-2011 12:58, Mark Lord escreveu: On 11-01-26 06:26 AM, Mauro Carvalho Chehab wrote: .. However, as said previously in this thread, input-kbd won't work with any RC table that uses NEC extended (and there are

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 03:29:09PM -0200, Mauro Carvalho Chehab wrote: Em 26-01-2011 14:51, Dmitry Torokhov escreveu: On Wed, Jan 26, 2011 at 12:18:29PM -0200, Mauro Carvalho Chehab wrote: diff --git a/input.c b/input.c index d57a31e..a9bd5e8 100644 --- a/input.c +++ b/input.c

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 08:16:09PM +0100, Gerd Hoffmann wrote:Hi, The check should be against concrete version (0x1 in this case). Stepping back: what does the version mean? Nothing, it is just a number. 0x1 == 1.0 ? 0x10001 == 1.1 ? No, not really. Can I expect the

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 02:31:44PM -0500, Mark Lord wrote: On 11-01-26 11:44 AM, Dmitry Torokhov wrote: On Wed, Jan 26, 2011 at 10:05:57AM -0500, Mark Lord wrote: .. Nope. Does not work here: $ lsinput protocol version mismatch (expected 65536, got 65537) It would be much more

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 02:33:17PM -0500, Mark Lord wrote: On 11-01-26 12:32 PM, Mauro Carvalho Chehab wrote: Em 26-01-2011 13:05, Mark Lord escreveu: .. Nope. Does not work here: $ lsinput protocol version mismatch (expected 65536, got 65537) You need to relax the version test at

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 02:47:18PM -0500, Mark Lord wrote: On 11-01-26 02:41 PM, Dmitry Torokhov wrote: I do not consider lsinput refusing to work a regression. Obviously, since you don't use that tool. Those of us who do use it see this as broken userspace compatibility. Who the hell

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 04:41:07PM -0500, Mark Lord wrote: On 11-01-26 02:50 PM, Dmitry Torokhov wrote: On Wed, Jan 26, 2011 at 02:47:18PM -0500, Mark Lord wrote: On 11-01-26 02:41 PM, Dmitry Torokhov wrote: I do not consider lsinput refusing to work a regression. Obviously, since you

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 04:49:14PM -0500, Mark Lord wrote: Or perhaps get rid of that unworkable version number thing (just freeze it in time with the 2.6.35 value returned), and implement a get_feature_flags ioctl or something for going forward. Then you can just turn on new bits in the flags

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 08:07:29PM -0500, Mark Lord wrote: On 11-01-26 08:01 PM, Mark Lord wrote: On 11-01-26 10:05 AM, Mark Lord wrote: On 11-01-25 09:00 PM, Dmitry Torokhov wrote: .. I wonder if the patch below is all that is needed... Nope. Does not work here: $ lsinput

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-26 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 10:18:53PM -0500, Mark Lord wrote: On 11-01-26 09:12 PM, Dmitry Torokhov wrote: On Wed, Jan 26, 2011 at 08:07:29PM -0500, Mark Lord wrote: On 11-01-26 08:01 PM, Mark Lord wrote: On 11-01-26 10:05 AM, Mark Lord wrote: On 11-01-25 09:00 PM, Dmitry Torokhov wrote

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-27 Thread Dmitry Torokhov
On Wed, Jan 26, 2011 at 10:18:53PM -0500, Mark Lord wrote: On 11-01-26 09:12 PM, Dmitry Torokhov wrote: On Wed, Jan 26, 2011 at 08:07:29PM -0500, Mark Lord wrote: On 11-01-26 08:01 PM, Mark Lord wrote: On 11-01-26 10:05 AM, Mark Lord wrote: On 11-01-25 09:00 PM, Dmitry Torokhov wrote

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-27 Thread Dmitry Torokhov
On Thu, Jan 27, 2011 at 08:30:00AM -0200, Mauro Carvalho Chehab wrote: On my tests here, this is working fine, with Fedora and RHEL 6, on my usual test devices, so I don't believe that the tool itself is broken, nor I think that the issue is due to the fix patch. I remember that when Kay

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-27 Thread Dmitry Torokhov
On Thu, Jan 27, 2011 at 01:12:48PM -0500, Mark Lord wrote: On 11-01-27 11:39 AM, Dmitry Torokhov wrote: On Wed, Jan 26, 2011 at 10:18:53PM -0500, Mark Lord wrote: No, it does not seem to segfault when I unload/reload ir-kbd-i2c and then invoke it by hand with the same parameters. Quite

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-28 Thread Dmitry Torokhov
On Thu, Jan 27, 2011 at 04:58:57PM -0200, Mauro Carvalho Chehab wrote: Em 27-01-2011 15:21, Dmitry Torokhov escreveu: On Thu, Jan 27, 2011 at 08:30:00AM -0200, Mauro Carvalho Chehab wrote: On my tests here, this is working fine, with Fedora and RHEL 6, on my usual test devices, so I don't

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-28 Thread Dmitry Torokhov
On Fri, Jan 28, 2011 at 09:55:58AM -0200, Mauro Carvalho Chehab wrote: Em 28-01-2011 07:39, Dmitry Torokhov escreveu: On Thu, Jan 27, 2011 at 04:58:57PM -0200, Mauro Carvalho Chehab wrote: Em 27-01-2011 15:21, Dmitry Torokhov escreveu: On Thu, Jan 27, 2011 at 08:30:00AM -0200, Mauro

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-28 Thread Dmitry Torokhov
On Thu, Jan 27, 2011 at 11:53:25AM -0800, Dmitry Torokhov wrote: On Thu, Jan 27, 2011 at 01:12:48PM -0500, Mark Lord wrote: On 11-01-27 11:39 AM, Dmitry Torokhov wrote: On Wed, Jan 26, 2011 at 10:18:53PM -0500, Mark Lord wrote: No, it does not seem to segfault when I unload/reload ir-kbd

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-28 Thread Dmitry Torokhov
On Fri, Jan 28, 2011 at 03:01:58PM -0200, Mauro Carvalho Chehab wrote: Em 28-01-2011 14:40, Dmitry Torokhov escreveu: On Fri, Jan 28, 2011 at 09:55:58AM -0200, Mauro Carvalho Chehab wrote: The rc-core register (and the corresponding input register) is done when the device detected

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-28 Thread Dmitry Torokhov
On Fri, Jan 28, 2011 at 04:15:51PM -0200, Mauro Carvalho Chehab wrote: Em 28-01-2011 15:33, Dmitry Torokhov escreveu: On Fri, Jan 28, 2011 at 03:01:58PM -0200, Mauro Carvalho Chehab wrote: Em 28-01-2011 14:40, Dmitry Torokhov escreveu: On Fri, Jan 28, 2011 at 09:55:58AM -0200, Mauro

Re: 2.6.36/2.6.37: broken compatibility with userspace input-utils ?

2011-01-28 Thread Dmitry Torokhov
On Fri, Jan 28, 2011 at 04:03:07PM -0500, Mark Lord wrote: On 11-01-28 03:55 PM, Mark Lord wrote: On 11-01-28 11:42 AM, Dmitry Torokhov wrote: On Thu, Jan 27, 2011 at 11:53:25AM -0800, Dmitry Torokhov wrote: On Thu, Jan 27, 2011 at 01:12:48PM -0500, Mark Lord wrote: On 11-01-27 11:39 AM

[PATCH] Input: rc-keymap - return KEY_RESERVED for unknown mappings

2011-01-28 Thread Dmitry Torokhov
...@teksavvy.com Signed-off-by: Dmitry Torokhov d...@mail.ru --- Linus, Due to the fact that contents of drivers/media in my 'for-linus' branch are quite different from mainline/Mauro's trees and I am not planning on merging this branch until closer to the next merge window I am sending

[PATCH] dvb-usb-remote - convert to new style of get/setkeycode

2011-01-31 Thread Dmitry Torokhov
Input: dvb-usb-remote - convert to new style of get/setkeycode Signed-off-by: Dmitry Torokhov d...@mail.ru --- Mauro, This is needed so that I could rename get/setkeycode_new into get/setkeycode and get rid of duplicate pointers and compat code in input core. Compiled only, not tested. If you

[PATCH] Input: switch completely over to the new versions of get/setkeycode

2011-01-31 Thread Dmitry Torokhov
Input: switch completely over to the new versions of get/setkeycode All users of old style get/setkeycode methids have been converted so it is time to retire them. Signed-off-by: Dmitry Torokhov d...@mail.ru --- Jiri, Mauro, There is not a good way to avoid crossing multiple subsystems

Re: [PATCH] Input: switch completely over to the new versions of get/setkeycode

2011-01-31 Thread Dmitry Torokhov
. Signed-off-by: Dmitry Torokhov d...@mail.ru --- Jiri, Mauro, There is not a good way to avoid crossing multiple subsystems but the changes are minimal, so if you are OK with the patch I'd like to move it through my tree for .39. Acked-by: Mauro Carvalho Chehab mche

Re: cx23885-input.c does in fact use a workqueue....

2011-02-13 Thread Dmitry Torokhov
On Sun, Feb 13, 2011 at 08:35:22PM -0500, Andy Walls wrote: Tejun, I just noticed this commit: commit 8c71778cbf2c8beaefaa2dee5478aa0622d96682 Author: Tejun Heo t...@kernel.org Date: Fri Dec 24 16:14:20 2010 +0100 media/video: don't use flush_scheduled_work() This

Re: [Bug 30022] Kernel cannot find Flyvideo 98's remote control device.

2011-03-10 Thread Dmitry Torokhov
On Thursday, March 10, 2011 12:52:00 am bugzilla-dae...@bugzilla.kernel.org wrote: https://bugzilla.kernel.org/show_bug.cgi?id=30022 --- Comment #7 from Mehmet Tekbaş btek...@gmail.com 2011-03-10 08:51:59 --- Tried with Inca I-TV004 (bt878 analog card) and result didn't changed. IR

Re: [RFC PATCH] input: add KEY_IMAGES specifically for AL Image Browser

2011-04-12 Thread Dmitry Torokhov
On Tuesday, April 12, 2011 02:00:53 PM Jarod Wilson wrote: Andy Walls wrote: Jarod Wilsonja...@redhat.com wrote: Many media center remotes have buttons intended for jumping straight to one type of media browser or another -- commonly, images/photos/pictures, audio/music, television,

Re: IR remote control autorepeat / evdev

2011-05-11 Thread Dmitry Torokhov
On Wed, May 11, 2011 at 08:59:16PM +0300, Anssi Hannula wrote: I meant replacing the softrepeat with native repeat for such devices that have native repeats but no native release events: - keypress from device = keydown + keyup - repeat from device = keydown + keyup - repeat from device =

Re: [PATCH] [media] rc: call input_sync after scancode reports

2011-06-23 Thread Dmitry Torokhov
function difference until the referenced change went into the input layer. Reported-by: Stephan Raue sr...@openelec.tv CC: Mauro Carvalho Chehab mche...@redhat.com CC: Jeff Brown jeffbr...@android.com Signed-off-by: Jarod Wilson ja...@redhat.com Signed-off-by: Dmitry Torokhov d...@mail.ru

Re: [PATCH v2] [media] rc: call input_sync after scancode reports

2011-06-23 Thread Dmitry Torokhov
keycode, which manifested with the reordering of calling input_report_key and setting last_keycode. Reported-by: Stephan Raue sr...@openelec.tv CC: Stephan Raue sr...@openelec.tv CC: Mauro Carvalho Chehab mche...@redhat.com CC: Jeff Brown jeffbr...@android.com CC: Dmitry Torokhov d...@mail.ru

Re: [git:v4l-dvb/for_v3.1] [media] rc: call input_sync after scancode reports

2011-07-07 Thread Dmitry Torokhov
On Fri, Jul 01, 2011 at 09:34:45PM +0200, Mauro Carvalho Chehab wrote: This is an automatic generated email to let you know that the following patch were queued at the http://git.linuxtv.org/media_tree.git tree: Subject: [media] rc: call input_sync after scancode reports Author: Jarod

Re: [git:v4l-dvb/for_v3.1] [media] rc: call input_sync after scancode reports

2011-07-07 Thread Dmitry Torokhov
On Thu, Jul 07, 2011 at 08:28:12PM -0400, Jarod Wilson wrote: On Thu, Jul 7, 2011 at 7:58 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Fri, Jul 01, 2011 at 09:34:45PM +0200, Mauro Carvalho Chehab wrote: This is an automatic generated email to let you know that the following

Re: [PATCH 5/7] [media] ati_remote: add keymap for Medion X10 RF remote

2011-08-07 Thread Dmitry Torokhov
On Sun, Aug 07, 2011 at 01:18:11AM +0300, Anssi Hannula wrote: Add keymap for the Medion X10 RF remote which uses the ati_remote driver, and default to it based on the usb id. Since rc-core supports loading custom keytmaps should we ass medion keymap here? I think we should keep the original

Re: [RFC] Should we create a raw input interface for IR's ? - Was: Re: [PATCH 1/3 v2] lirc core device driver infrastructure

2009-11-23 Thread Dmitry Torokhov
On Mon, Nov 23, 2009 at 03:14:56PM +0100, Krzysztof Halasa wrote: Mauro Carvalho Chehab mche...@redhat.com writes: Event input has the advantage that the keystrokes will provide an unique representation that is independent of the device. This can hardly work as the only means, the

Re: [RFC] Should we create a raw input interface for IR's ? - Was: Re: [PATCH 1/3 v2] lirc core device driver infrastructure

2009-11-25 Thread Dmitry Torokhov
On Mon, Nov 23, 2009 at 09:51:31PM +0100, Krzysztof Halasa wrote: Dmitry Torokhov dmitry.torok...@gmail.com writes: Curreently the scan codes in the input layer serve just to help users to map whatever the device emits into a proper input event code so that the rest of userspace would

Re: [RFC] Should we create a raw input interface for IR's ? - Was: Re: [PATCH 1/3 v2] lirc core device driver infrastructure

2009-11-25 Thread Dmitry Torokhov
On Mon, Nov 23, 2009 at 11:37:53PM -0500, Jarod Wilson wrote: On 11/23/2009 12:37 PM, Dmitry Torokhov wrote: On Mon, Nov 23, 2009 at 03:14:56PM +0100, Krzysztof Halasa wrote: Mauro Carvalho Chehabmche...@redhat.com writes: Event input has the advantage that the keystrokes will provide

Re: IR raw input is not sutable for input system

2009-11-25 Thread Dmitry Torokhov
On Wed, Nov 25, 2009 at 01:32:51AM +0200, Maxim Levitsky wrote: Folks, I really want to tell everyone that doing all the mapping from raw codes to keypresses in kernel is wrong. Why is this wrong? Doing simple translation is easy and it does not require having all the tables for all possible

Re: IR raw input is not sutable for input system

2009-11-25 Thread Dmitry Torokhov
On Tue, Nov 24, 2009 at 07:32:42PM -0800, Trent Piepho wrote: One thing that could be done, unless it has changed much since I wrote it 10+ years ago, is to take the mark/space protocol the ir device uses and sent that data to lircd via the input layer. It would be less efficient, but would

Re: [RFC] Should we create a raw input interface for IR's ? - Was: Re: [PATCH 1/3 v2] lirc core device driver infrastructure

2009-11-25 Thread Dmitry Torokhov
On Mon, Nov 23, 2009 at 07:53:57PM -0500, Andy Walls wrote: On Mon, 2009-11-23 at 22:11 +0100, Christoph Bartelmus wrote: Czesc Krzysztof, on 23 Nov 09 at 15:14, Krzysztof Halasa wrote: [...] I think we shouldn't at this time worry about IR transmitters. Sorry, but I have to

Re: [RFC] Should we create a raw input interface for IR's ?

2009-11-25 Thread Dmitry Torokhov
On Wed, Nov 25, 2009 at 09:49:28PM +0100, Krzysztof Halasa wrote: Jarod Wilson ja...@wilsonet.com writes: Well, we've got a number of IOCTLs already, could extend those. (Although its been suggested elsewhere that we replace the IOCTLs with sysfs knobs). Not sure if sysfs would be fast

Re: [RFC] Should we create a raw input interface for IR's ? - Was: Re: [PATCH 1/3 v2] lirc core device driver infrastructure

2009-11-26 Thread Dmitry Torokhov
On Thu, Nov 26, 2009 at 09:01:00AM +0100, Christoph Bartelmus wrote: Hi, on 25 Nov 09 at 12:44, Jarod Wilson wrote: [...] Ah, but the approach I'd take to converting to in-kernel decoding[*] would be this: [...] [*] assuming, of course, that it was actually agreed upon that in-kernel

Re: [RFC] Should we create a raw input interface for IR's ? - Was: Re: [PATCH 1/3 v2] lirc core device driver infrastructure

2009-11-26 Thread Dmitry Torokhov
On Nov 26, 2009, at 9:46 AM, Krzysztof Halasa k...@pm.waw.pl wrote: Dmitry Torokhov dmitry.torok...@gmail.com writes: In what way the key interface is unsufficient for delivering button events? At present: 128 different keys only (RC5: one group). Where did this limitation come from? We

Re: [RFC] Should we create a raw input interface for IR's ? - Was: Re: [PATCH 1/3 v2] lirc core device driver infrastructure

2009-11-26 Thread Dmitry Torokhov
On Thu, Nov 26, 2009 at 01:16:01AM -0500, Jarod Wilson wrote: On Nov 26, 2009, at 12:31 AM, Dmitry Torokhov wrote: On Mon, Nov 23, 2009 at 11:37:53PM -0500, Jarod Wilson wrote: On 11/23/2009 12:37 PM, Dmitry Torokhov wrote: On Mon, Nov 23, 2009 at 03:14:56PM +0100, Krzysztof Halasa wrote

Re: [RFC] Should we create a raw input interface for IR's ? - Was: Re: [PATCH 1/3 v2] lirc core device driver infrastructure

2009-11-26 Thread Dmitry Torokhov
On Wed, Nov 25, 2009 at 10:58:29PM +0100, Gerd Hoffmann wrote: (1) ir code (say rc5) - keycode conversion looses information. I think this can easily be addressed by adding a IR event type to the input layer, which could look like this: input_event-type = EV_IR input_event-code =

Re: [RFC] Should we create a raw input interface for IR's ? - Was: Re: [PATCH 1/3 v2] lirc core device driver infrastructure

2009-11-26 Thread Dmitry Torokhov
On Thu, Nov 26, 2009 at 03:49:13PM -0200, Mauro Carvalho Chehab wrote: Dmitry, While lirc is basically a series of input drivers, considering that they have lots in common with the input drivers at V4L/DVB and that we'll need to work on some glue to merge both, do you mind if I add the

Re: [RFC] Should we create a raw input interface for IR's ? - Was: Re: [PATCH 1/3 v2] lirc core device driver infrastructure

2009-11-26 Thread Dmitry Torokhov
On Fri, Nov 27, 2009 at 01:13:51AM +0100, Krzysztof Halasa wrote: Dmitry Torokhov dmitry.torok...@gmail.com writes: One remote per device only. Why would you want more? One physical device usually corresponds to a logical device. If you have 2 remotes create 2 devices. I meant per

Re: [RFC] Should we create a raw input interface for IR's ? - Was: Re: [PATCH 1/3 v2] lirc core device driver infrastructure

2009-11-26 Thread Dmitry Torokhov
On Thu, Nov 26, 2009 at 09:28:51PM -0500, Jarod Wilson wrote: On 11/26/2009 06:23 PM, Dmitry Torokhov wrote: On Thu, Nov 26, 2009 at 01:16:01AM -0500, Jarod Wilson wrote: On Nov 26, 2009, at 12:31 AM, Dmitry Torokhov wrote: On Mon, Nov 23, 2009 at 11:37:53PM -0500, Jarod Wilson wrote: On 11

Re: [RFC] Should we create a raw input interface for IR's ? - Was: Re: [PATCH 1/3 v2] lirc core device driver infrastructure

2009-11-26 Thread Dmitry Torokhov
On Thu, Nov 26, 2009 at 10:08:29PM -0500, Jon Smirl wrote: On Thu, Nov 26, 2009 at 9:28 PM, Jarod Wilson ja...@wilsonet.com wrote: No, at present we expect 1:1 button-event mapping leaving macro expansion (i.e. KEY_PROG1 -  do some multi-step sequence to userspace). Hm. So ctrl-x,

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-28 Thread Dmitry Torokhov
On Sat, Nov 28, 2009 at 11:32:01PM -0500, Andy Walls wrote: On Sat, 2009-11-28 at 12:37 -0500, Jon Smirl wrote: On Sat, Nov 28, 2009 at 12:35 PM, Krzysztof Halasa k...@pm.waw.pl wrote: Jon Smirl jonsm...@gmail.com writes: There are two very basic things that we need to reach consensus

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-28 Thread Dmitry Torokhov
On Sun, Nov 29, 2009 at 01:17:03PM +1030, Mike Lampard wrote: On Sat, 28 Nov 2009 02:27:59 am Jon Smirl wrote: On Fri, Nov 27, 2009 at 2:45 AM, Christoph Bartelmus christ...@bartelmus.de wrote: Hi Mauro, on 26 Nov 09 at 14:25, Mauro Carvalho Chehab wrote: Christoph Bartelmus

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-28 Thread Dmitry Torokhov
On Sat, Nov 28, 2009 at 06:26:55PM -0500, Andy Walls wrote: Jon, On Sat, 2009-11-28 at 12:37 -0500, Jon Smirl wrote: On Sat, Nov 28, 2009 at 12:35 PM, Krzysztof Halasa k...@pm.waw.pl wrote: Jon Smirl jonsm...@gmail.com writes: There are two very basic things that we need to reach

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-28 Thread Dmitry Torokhov
On Sat, Nov 28, 2009 at 05:18:34PM -0500, Jon Smirl wrote: I'm looking at a Sony multi-function remote right now. It has five devices and forty keys. Each of the five devices can transmit 0-9, power, volume, etc. It transmits 5*40 = 200 unique scancodes. I want the five devices to correspond

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-28 Thread Dmitry Torokhov
On Sun, Nov 29, 2009 at 04:01:53PM +1030, Mike Lampard wrote: On Sun, 29 Nov 2009 03:25:49 pm Dmitry Torokhov wrote: On Sun, Nov 29, 2009 at 01:17:03PM +1030, Mike Lampard wrote: On Sat, 28 Nov 2009 02:27:59 am Jon Smirl wrote: On Fri, Nov 27, 2009 at 2:45 AM, Christoph Bartelmus

Re: [IR-RFC PATCH v4 0/6] In-kernel IR support using evdev

2009-11-28 Thread Dmitry Torokhov
On Thu, Nov 26, 2009 at 10:34:55PM -0500, Jon Smirl wrote: On Thu, Nov 26, 2009 at 10:12 PM, Jarod Wilson ja...@wilsonet.com wrote: This part... Not so wild about. The common thought I'm seeing from people is that we should be using setkeycode to load keymaps. I mean, sure, I suppose this

Re: [IR-RFC PATCH v4 0/6] In-kernel IR support using evdev

2009-11-28 Thread Dmitry Torokhov
On Thu, Nov 26, 2009 at 10:58:59PM -0500, Jon Smirl wrote: Code is only lightly tested. Encoders and decoders have not been written for all protocols. Repeat is not handled for any protocol. I'm looking for help. There are 15 more existing LIRC drivers. And there's the hangup for me.

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-29 Thread Dmitry Torokhov
On Nov 29, 2009, at 12:44 PM, Jon Smirl jonsm...@gmail.com wrote: On Sun, Nov 29, 2009 at 3:27 PM, Krzysztof Halasa k...@pm.waw.pl wrote: 1. Do we agree that a lirc (-style) kernel-user interface is needed at least? 2. Is there any problem with lirc kernel-user interface? Can you

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-29 Thread Dmitry Torokhov
On Nov 29, 2009, at 12:27 PM, Krzysztof Halasa k...@pm.waw.pl wrote: 1. Do we agree that a lirc (-style) kernel-user interface is needed at least? 2. Is there any problem with lirc kernel-user interface? If the answer for #1 is yes and for #2 is no then perhaps we merge the Jarod's lirc

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-29 Thread Dmitry Torokhov
On Nov 29, 2009, at 1:47 PM, Jon Smirl jonsm...@gmail.com wrote: On Sun, Nov 29, 2009 at 4:29 PM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Nov 29, 2009, at 12:44 PM, Jon Smirl jonsm...@gmail.com wrote: On Sun, Nov 29, 2009 at 3:27 PM, Krzysztof Halasa k...@pm.waw.pl wrote: 1

Re: [RFC] What are the goals for the architecture of an in-kernel IR system?

2009-11-30 Thread Dmitry Torokhov
On Mon, Nov 30, 2009 at 03:33:52PM -0200, Mauro Carvalho Chehab wrote: kevin granade wrote: On Mon, Nov 30, 2009 at 7:24 AM, Mauro Carvalho Chehab mche...@redhat.com wrote: After the boot, a device can open the raw API, disabling any in-kernel decoding/handling and handle IR directly.

Re: [RFC v2] Another approach to IR

2009-12-01 Thread Dmitry Torokhov
On Tue, Dec 01, 2009 at 05:00:40PM -0200, Mauro Carvalho Chehab wrote: Dmitry Torokhov wrote: On Tue, Dec 01, 2009 at 03:29:44PM -0200, Mauro Carvalho Chehab wrote: For sure we need to add an EVIOSETPROTO ioctl to allow the driver to change the protocol in runtime. Mauro, I

Re: [RFC v2] Another approach to IR

2009-12-02 Thread Dmitry Torokhov
On Tue, Dec 01, 2009 at 07:05:49PM -0200, Mauro Carvalho Chehab wrote: Dmitry Torokhov wrote: On Tue, Dec 01, 2009 at 05:00:40PM -0200, Mauro Carvalho Chehab wrote: Dmitry Torokhov wrote: On Tue, Dec 01, 2009 at 03:29:44PM -0200, Mauro Carvalho Chehab wrote: For sure we need to add

Re: [RFC v2] Another approach to IR

2009-12-02 Thread Dmitry Torokhov
On Wed, Dec 02, 2009 at 10:37:02AM -0500, Jon Smirl wrote: On Wed, Dec 2, 2009 at 4:38 AM, Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Tue, Dec 01, 2009 at 07:05:49PM -0200, Mauro Carvalho Chehab wrote: Dmitry Torokhov wrote: On Tue, Dec 01, 2009 at 05:00:40PM -0200, Mauro

  1   2   3   >