in this is the same as upstream),
but ***not tested with a real video device***.
Signed-off-by: Dr. David Alan Gilbert li...@treblig.org
--
diff --git a/drivers/media/video/v4l1-compat.c
b/drivers/media/video/v4l1-compat.c
index 0c2105c..d4ac751 100644
--- a/drivers/media/video/v4l1-compat.c
protects
the accesses that ivtv_write_vbi performs.
Is there something that makes this safe?
Dave
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\ gro.gilbert @ treblig.org
Andy Walls wrote:
(Sorry, I've probably screwed up the threading on this)
Dr. David Alan Gilbert wrote:
Hi,
Sparse pointed me at the following line in ivtv-fileops.c's
ivtv_v4l2_write:
ivtv_write_vbi(itv, (const struct v4l2_sliced_vbi_data
*)user_buf, elems
* Andy Walls (awa...@md.metrocast.net) wrote:
On Sun, 2010-11-28 at 17:40 +, Dr. David Alan Gilbert wrote:
Hi,
Sparse pointed me at the following line in ivtv-fileops.c's
ivtv_v4l2_write:
ivtv_write_vbi(itv, (const struct v4l2_sliced_vbi_data
*)user_buf, elems
be:
ivtv_write_vbi_line(itv, d, cc, found_cc);
What do you think?
Dave
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\ gro.gilbert @ treblig.org | | In Hex
* Andy Walls (awa...@md.metrocast.net) wrote:
On Sun, 2011-01-09 at 00:34 +, Dr. David Alan Gilbert wrote:
Hi Andy,
It looks like we missed something in that copy from user
patch from the end of last year:
+void ivtv_write_vbi_from_user(struct ivtv *itv
of the comment.
(I haven't got this hardware to test on - but if you've been having
some weird AGC issues on that card it might explain it!)
Dave
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy
that assigns
1 to it that just won't fit).
(Introduced by e23ccc0ad9258634e6d52cedf473b35dc34416c7 , spotted in
2.6.39-rc1 )
Dave
--
-Open up your eyes, open up your mind, open up your code ---
/ Dr. David Alan Gilbert| Running GNU/Linux | Happy \
\ gro.gilbert
(Originally sent to Pawel's Samsung address that bounced)
* Dr. David Alan Gilbert (li...@treblig.org) wrote:
Hi Pawel,
'sparse' spotted that vb2_plane's mapped field is a signed
bitfield:
include/media/videobuf2-core.h:78:41 1 bit signed int
struct vb2_plane {
void
