Re: [PATCH FOR 2.6.36] uvc: Move constants and structures definitions to linux/usb/video.h

2010-07-10 Thread Greg KH
On Sat, Jul 10, 2010 at 08:03:20PM +0200, Laurent Pinchart wrote: The UVC host and gadget drivers both define constants and structures in private header files. Move all those definitions to linux/usb/video.h where they can be shared by the two drivers (and be available for userspace

Re: [PATCH 0/15] STAGING: add lirc device drivers

2010-07-27 Thread Greg KH
On Tue, Jul 27, 2010 at 04:33:32PM -0300, Mauro Carvalho Chehab wrote: Em 27-07-2010 15:24, Jarod Wilson escreveu: On Tue, Jul 27, 2010 at 09:09:56AM -0700, Greg KH wrote: On Tue, Jul 27, 2010 at 12:59:00PM -0300, Mauro Carvalho Chehab wrote: Em 26-07-2010 20:25, Jarod Wilson escreveu

Re: [PATCH 1/2] staging/lirc: port lirc_streamzap to ir-core

2010-08-02 Thread Greg KH
On Mon, Aug 02, 2010 at 05:29:22PM -0400, Jarod Wilson wrote: drivers/media/IR/keymaps/Makefile |1 + Uppercase IR? Any reason why you all picked that? Just curious. greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to

Re: [PATCH 1/2] staging/lirc: port lirc_streamzap to ir-core

2010-08-02 Thread Greg KH
On Mon, Aug 02, 2010 at 09:24:14PM -0300, Mauro Carvalho Chehab wrote: Em 02-08-2010 19:35, Greg KH escreveu: On Mon, Aug 02, 2010 at 05:29:22PM -0400, Jarod Wilson wrote: drivers/media/IR/keymaps/Makefile |1 + Uppercase IR? Any reason why you all picked that? Infra

Re: [RFCv5 3/9] mm: cma: Added SysFS support

2010-09-06 Thread Greg KH
On Mon, Sep 06, 2010 at 08:33:53AM +0200, Michal Nazarewicz wrote: +++ b/Documentation/ABI/testing/sysfs-kernel-mm-contiguous @@ -0,0 +1,53 @@ +What:/sys/kernel/mm/contiguous/ +Date:August 2010 +Contact: Michal Nazarewicz m.nazarew...@samsung.com

Re: [RFCv5 0/9] CMA + VCMM integration

2010-09-06 Thread Greg KH
On Mon, Sep 06, 2010 at 08:33:50AM +0200, Michal Nazarewicz wrote: Hello everyone, This patchset introduces a draft of a redesign of Zach Pfeffer's VCMM. What is a VCMM? What is a CMA? Not all of the functionality of the original VCMM has been ported into this patchset. This is mostly

Re: [RFCv5 8/9] mm: vcm: Sample driver added

2010-09-06 Thread Greg KH
On Mon, Sep 06, 2010 at 08:33:58AM +0200, Michal Nazarewicz wrote: --- /dev/null +++ b/include/linux/vcm-sample.h Don't put sample code in include/linux/ please. That's just cluttering up the place, don't you think? Especially as no one else needs the file there... thanks, greg k-h -- To

Re: [RFCv5 0/9] CMA + VCMM integration

2010-09-06 Thread Greg KH
On Tue, Sep 07, 2010 at 03:40:46AM +0200, Micha?? Nazarewicz wrote: On Mon, 06 Sep 2010 23:09:05 +0200, Greg KH g...@kroah.com wrote: On Mon, Sep 06, 2010 at 08:33:50AM +0200, Michal Nazarewicz wrote: Hello everyone, This patchset introduces a draft of a redesign of Zach Pfeffer's VCMM

Re: [RFCv5 3/9] mm: cma: Added SysFS support

2010-09-07 Thread Greg KH
23:07:47 +0200, Greg KH g...@kroah.com wrote: So this returns more than one value? Aren't thing like cpufreq governors listed in a single sysfs file? Yeah, but I don't like it :) I remember there was such a file somewhere. Has that been made deprecated? I cannot seem to find any information

Re: [PATCH] uvc: Enable USB autosuspend by default on uvcvideo

2010-09-16 Thread Greg KH
On Thu, Sep 16, 2010 at 02:00:04PM -0400, Matthew Garrett wrote: We've been doing this for a while in Fedora without any complaints. No complaints probably, but does it actually do anything? Last time I measured, it didn't, but that was in the .31 kernel days. thanks, greg k-h -- To

Re: [PATCH] uvc: Enable USB autosuspend by default on uvcvideo

2010-09-16 Thread Greg KH
On Thu, Sep 16, 2010 at 07:53:18PM +0100, Matthew Garrett wrote: On Thu, Sep 16, 2010 at 11:45:30AM -0700, Greg KH wrote: On Thu, Sep 16, 2010 at 02:00:04PM -0400, Matthew Garrett wrote: We've been doing this for a while in Fedora without any complaints. No complaints probably, but does

Re: [PATCH] V4L/DVB: Add a todo file for staging/tm6000

2010-10-14 Thread Greg KH
On Thu, Oct 14, 2010 at 05:37:10PM -0300, Mauro Carvalho Chehab wrote: Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com Acked-by: Greg Kroah-Hartman gre...@suse.de I'm guessing that you want to take this through your tree, right? Fine with me. thanks, greg k-h -- To unsubscribe from

Re: [Ksummit-2010-discuss] [v2] Remaining BKL users, what to do

2010-10-18 Thread Greg KH
On Mon, Oct 18, 2010 at 05:42:06PM +0200, Arnd Bergmann wrote: Out of the remaining modules, I guess i810/i830, adfs, hpfs and ufs might end up not getting fixed at all, we can either mark them non-SMP or move them to drivers/staging once all the others are done. I recommend moving them to

Re: [Ksummit-2010-discuss] [v2] Remaining BKL users, what to do

2010-10-18 Thread Greg KH
On Tue, Oct 19, 2010 at 09:00:09AM +1000, Dave Airlie wrote: On Tue, Oct 19, 2010 at 4:43 AM, Greg KH g...@kroah.com wrote: On Mon, Oct 18, 2010 at 05:42:06PM +0200, Arnd Bergmann wrote: Out of the remaining modules, I guess i810/i830, adfs, hpfs and ufs might end up not getting fixed

Re: [Ksummit-2010-discuss] [v2] Remaining BKL users, what to do

2010-10-18 Thread Greg KH
On Tue, Oct 19, 2010 at 10:57:43AM +1000, Dave Airlie wrote: On Tue, Oct 19, 2010 at 10:40 AM, Greg KH g...@kroah.com wrote: On Tue, Oct 19, 2010 at 09:00:09AM +1000, Dave Airlie wrote: On Tue, Oct 19, 2010 at 4:43 AM, Greg KH g...@kroah.com wrote: On Mon, Oct 18, 2010 at 05:42:06PM +0200

Re: [Ksummit-2010-discuss] [v2] Remaining BKL users, what to do

2010-10-19 Thread Greg KH
On Tue, Oct 19, 2010 at 02:24:53PM -0400, valdis.kletni...@vt.edu wrote: On Mon, 18 Oct 2010 17:40:04 PDT, Greg KH said: I do have access to this hardware, but its on an old single processor laptop, so any work that it would take to help do this development, really wouldn't be able

Re: [Ksummit-2010-discuss] [v2] Remaining BKL users, what to do

2010-10-19 Thread Greg KH
On Tue, Oct 19, 2010 at 09:40:47PM +0200, Oliver Neukum wrote: Am Dienstag, 19. Oktober 2010, 21:37:35 schrieb Greg KH: So no need to clean it up for multiprocessor support. http://download.intel.com/design/chipsets/datashts/29067602.pdf http://www.intel.com/design/chipsets/specupdt

Re: [stable] V4L/DVB (13966): DVB-T regression fix for saa7134 cards

2010-10-19 Thread Greg KH
On Wed, Sep 29, 2010 at 12:28:00PM -0300, Mauro Carvalho Chehab wrote: Hi, Some users are reporting a regression on 2.6.31 and 2.6.32 that were fixed on 2.6.33, related to DVB reception with saa7134. Could you please cherry-pick this patch to 2.6.32 stable as well?

Re: [stable] [PATCH 1/2] V4L/DVB: dib7770: enable the current mirror

2010-10-19 Thread Greg KH
On Tue, Sep 07, 2010 at 05:50:45PM +0200, pboettc...@kernellabs.com wrote: From: Olivier Grenie olivier.gre...@dibcom.fr To improve performance on DiB7770-devices enabling the current mirror is needed. This patch adds an option to the dib7000p-driver to do that and it creates a separate

Re: [PATCH] i2c: Remove obsolete cleanup for clientdata

2010-11-10 Thread Greg KH
On Wed, Nov 10, 2010 at 01:28:19PM +0100, Wolfram Sang wrote: A few new i2c-drivers came into the kernel which clear the clientdata-pointer on exit. This is obsolete meanwhile, so fix it and hope the word will spread. Signed-off-by: Wolfram Sang w.s...@pengutronix.de --- Like last time I

Re: [stable] [PATCH] [media] gspca - main: Fix a regression with the PS3 Eye webcam

2010-11-22 Thread Greg KH
On Mon, Nov 22, 2010 at 12:34:18PM +0100, Antonio Ospite wrote: On Fri, 5 Nov 2010 23:08:12 +0100 Antonio Ospite osp...@studenti.unina.it wrote: From: =?UTF-8?q?Jean-Fran=C3=A7ois=20Moine?= moin...@free.fr commit f43402fa55bf5e7e190c176343015122f694857c upstream. When audio is

Re: [PATCH 09/10] MCDE: Add build files and bus

2010-11-30 Thread Greg KH
On Tue, Nov 30, 2010 at 04:21:47PM +0100, Arnd Bergmann wrote: On Tuesday 30 November 2010, Linus Walleij wrote: 2010/11/26 Arnd Bergmann a...@arndb.de: * When you say that the devices are static, I hope you do not mean static in the C language sense. We used to allow devices to be

Re: [PATCH/RFC] core: add a function to safely try to get device driver owner

2010-11-30 Thread Greg KH
On Tue, Nov 30, 2010 at 06:09:46PM +0100, Guennadi Liakhovetski wrote: On Tue, 30 Nov 2010, Greg KH wrote: On Tue, Nov 30, 2010 at 12:11:42AM +0100, Guennadi Liakhovetski wrote: On Mon, 29 Nov 2010, Greg KH wrote: On Mon, Nov 29, 2010 at 11:10:50PM +0100, Guennadi Liakhovetski

Re: [PATCH/RFC] core: add a function to safely try to get device driver owner

2010-11-30 Thread Greg KH
On Tue, Nov 30, 2010 at 06:55:54PM +0100, Laurent Pinchart wrote: Hi Greg, On Tuesday 30 November 2010 18:15:09 Greg KH wrote: On Tue, Nov 30, 2010 at 06:09:46PM +0100, Guennadi Liakhovetski wrote: On Tue, 30 Nov 2010, Greg KH wrote: On Tue, Nov 30, 2010 at 12:11:42AM +0100, Guennadi

Re: [PATCH 09/10] MCDE: Add build files and bus

2010-11-30 Thread Greg KH
On Tue, Nov 30, 2010 at 06:40:49PM +, Russell King - ARM Linux wrote: On Tue, Nov 30, 2010 at 04:21:47PM +0100, Arnd Bergmann wrote: On Tuesday 30 November 2010, Linus Walleij wrote: 2010/11/26 Arnd Bergmann a...@arndb.de: * When you say that the devices are static, I hope you do

Re: [PATCH/RFC] core: add a function to safely try to get device driver owner

2010-11-30 Thread Greg KH
On Tue, Nov 30, 2010 at 09:43:09PM +0100, Laurent Pinchart wrote: The way we deal with this is to try_module_get() on the OMAP3 ISP driver in the subdev open() handlers. I'm of course opened to alternatives. Do it like the rest of the kernel does it, lock the module in place with the

Re: [PATCH 09/10] MCDE: Add build files and bus

2010-11-30 Thread Greg KH
On Tue, Nov 30, 2010 at 10:05:50PM +, Russell King - ARM Linux wrote: On Tue, Nov 30, 2010 at 10:48:34AM -0800, Greg KH wrote: On Tue, Nov 30, 2010 at 06:40:49PM +, Russell King - ARM Linux wrote: There's lots of static devices, not only platform devices, in the ARM tree. It's

Re: [PATCH 09/10] MCDE: Add build files and bus

2010-11-30 Thread Greg KH
On Tue, Nov 30, 2010 at 11:42:15PM +, Russell King - ARM Linux wrote: It's a work in progress, but wherever possible, I encourage people to not make 'struct device' static. Right, so saying to ARM developers that they can't submit code which adds new static device structures is rather

Re: [stable] [PATCH] [media] gspca - main: Fix a regression with the PS3 Eye webcam

2010-12-06 Thread Greg KH
On Mon, Nov 22, 2010 at 12:34:18PM +0100, Antonio Ospite wrote: On Fri, 5 Nov 2010 23:08:12 +0100 Antonio Ospite osp...@studenti.unina.it wrote: From: =?UTF-8?q?Jean-Fran=C3=A7ois=20Moine?= moin...@free.fr commit f43402fa55bf5e7e190c176343015122f694857c upstream. When audio is

Re: [stable] [PATCH] [media] msp3400: fix mute audio regression

2010-12-07 Thread Greg KH
On Thu, Nov 25, 2010 at 02:05:42PM +0100, Hans Verkuil wrote: This patch applies 2.6.37 commit 0310871d8f71da4ad8643687fbc40f219a0dac4d to the 2.6.36 stable series. It was just too late to be included in 2.6.36 at the time, but it should be added to 2.6.36 since it fixes broken audio on

Re: [stable] [RESEND][PATCH for stable 2.6.36 REGRESSION] cx25840: Prevent device probe failure due to volume control ERANGE error]

2010-12-10 Thread Greg KH
On Fri, Dec 10, 2010 at 08:19:57AM -0500, Andy Walls wrote: Resending, since this didn't appear to make its way into in 2.6.36.2. That's because it's not in Linus's tree, right? I have to wait for that to happen before I can add it to a stable tree. thanks, greg k-h -- To unsubscribe from

Re: [stable] [RESEND][PATCH for stable 2.6.36 REGRESSION] cx25840: Prevent device probe failure due to volume control ERANGE error]

2010-12-10 Thread Greg KH
On Fri, Dec 10, 2010 at 02:41:03PM -0500, Andy Walls wrote: On Fri, 2010-12-10 at 10:16 -0800, Greg KH wrote: On Fri, Dec 10, 2010 at 08:19:57AM -0500, Andy Walls wrote: Resending, since this didn't appear to make its way into in 2.6.36.2. That's because it's not in Linus's tree, right

Re: [RFC/PATCH v7 01/12] media: Media device node support

2010-12-22 Thread Greg KH
On Mon, Dec 20, 2010 at 12:36:24PM +0100, Laurent Pinchart wrote: The media_devnode structure provides support for registering and unregistering character devices using a dynamic major number. Reference counting is handled internally, making device drivers easier to write without having to

Re: [RFC/PATCH v7 02/12] media: Media device

2010-12-22 Thread Greg KH
On Mon, Dec 20, 2010 at 12:36:25PM +0100, Laurent Pinchart wrote: The media_device structure abstracts functions common to all kind of media devices (v4l2, dvb, alsa, ...). It manages media entities and offers a userspace API to discover and configure the media device internal topology. As

Re: [RFC/PATCH v7 01/12] media: Media device node support

2010-12-22 Thread Greg KH
On Mon, Dec 20, 2010 at 12:36:24PM +0100, Laurent Pinchart wrote: +/* + * Flag to mark the media_devnode struct as registered. Drivers must not touch + * this flag directly, it will be set and cleared by media_devnode_register and + * media_devnode_unregister. + */ +#define

Re: USB mini-summit report

2011-08-21 Thread Greg KH
On Fri, Aug 19, 2011 at 02:37:25PM -0700, Sarah Sharp wrote: The USB mini-summit was a success! Thank you to all the people who attended. I think we had some productive discussions that could have taken weeks on the mailing list. Please reply to this email if you have your own notes, or

Re: [PATCH v2] Staging: cx25821: fix coding style issues

2011-08-23 Thread Greg KH
On Tue, Aug 02, 2011 at 05:03:18PM +0800, Leonid V. Fedorenchik wrote: Fix too long lines in cx25821-audio.h Fix wrong brace placement in cx25821-cards.c, cx25821-core.c, and cx25821-i2c.c Use DEFINE_PCI_DEVICE_TABLE for cx25821_pci_tbl. Move EXPORT_SYMBOL(cx25821_set_gpiopin_direction) to

Re: usb_set_intfdata usage for two subdrivers

2011-08-28 Thread Greg KH
On Mon, Aug 29, 2011 at 02:30:26AM +0300, Antti Palosaari wrote: I am trying to implement DVB USB device smartcard reader support using USB-serial. Really? Why? That doesn't seem to make sense, please explain more. The main problem is now that both DVB-USB and USB-serial uses interface

Re: [PATCH 1/2] misc: remove CONFIG_MISC_DEVICES

2011-09-18 Thread Greg KH
On Sun, Sep 18, 2011 at 08:11:45AM -0700, Randy Dunlap wrote: On 09/05/2011 07:19 AM, Arnd Bergmann wrote: I think it would simply be more consistent to have it enabled all the time. Well, even better would be to move the bulk of the misc drivers to a proper location sorted by their

Re: [PATCH 1/2] misc: remove CONFIG_MISC_DEVICES

2011-09-19 Thread Greg KH
On Mon, Sep 19, 2011 at 10:47:50AM +0200, Arnd Bergmann wrote: On Sunday 18 September 2011 11:45:16 Randy Dunlap wrote: We have fallbacks to Andrew and/or GregKH currently, but GregKH is not consistent or timely with applying drivers/misc/ patches. It deserves better. [added him to

Re: Staging submission: PCTV 80e and PCTV 74e drivers (was Re: Problems cloning the git repostories)

2011-09-27 Thread Greg KH
/staging In summary, if you don't have a couple hours to make your driver to match Kernel Coding Style, just send it as is to /drivers/staging, c/c me and Greg KH, and that's it. PULL http://kernellabs.com/hg/~dheitmueller/v4l-dvb-80e/ PULL http://kernellabs.com/hg/~dheitmueller/v4l-dvb

Re: serial device name for smart card reader that is integrated to Anysee DVB USB device

2011-10-04 Thread Greg KH
On Wed, Oct 05, 2011 at 12:22:09AM +0300, Antti Palosaari wrote: I have been looking for correct device name for serial smart card reader that is integrated to Anysee DVB USB devices. Consider it like old so called Phoenix reader. Phoenix is de facto protocol used for such readers and there is

Re: serial device name for smart card reader that is integrated to Anysee DVB USB device

2011-10-05 Thread Greg KH
On Wed, Oct 05, 2011 at 08:15:17AM +0200, Oliver Neukum wrote: Am Mittwoch, 5. Oktober 2011, 07:58:51 schrieb Antti Palosaari: On 10/05/2011 07:59 AM, Greg KH wrote: Why not just use the usb-serial core and then you get a ttyUSB* device node for free? It also should provide a lot

Re: [PATCH 0/7] Staging submission: PCTV 74e drivers and some cleanup (was: Staging submission: PCTV 80e and PCTV 74e drivers)

2011-10-17 Thread Greg KH
On Sat, Oct 15, 2011 at 10:54:14PM +0200, Piotr Chmura wrote: [PATCH 1/7] pull as102 driver fromhttp://kernellabs.com/hg/~dheitmueller/v4l-dvb-as102-2/ with the only change needed to compile it in git tree[1]: usb_buffer_alloc() to usb_alloc_coherent() and usb_buffer_free() to

Re: [RESEND PATCH 10/14] staging/media/as102: properly handle multiple product names

2011-10-18 Thread Greg KH
On Tue, Oct 18, 2011 at 10:54:08PM +0200, Piotr Chmura wrote: On Tue, 18 Oct 2011 13:28:39 -0700 Joe Perches j...@perches.com wrote: On Tue, 2011-10-18 at 22:02 +0200, Piotr Chmura wrote: Patch taken from http://kernellabs.com/hg/~dheitmueller/v4l-dvb-as102-2/ [] diff --git

Re: [PATCH 0/3] Move media staging drivers to staging/media

2011-11-02 Thread Greg KH
On Wed, Nov 02, 2011 at 09:45:09AM -0200, Mauro Carvalho Chehab wrote: Greg, As agreed, this is the patches that move media drivers to their own places. Basically, cx25821 now seems ready to be at the standard place, while the other drivers should still be in staging for a while. The

Re: [RFC/PATCH v7 01/12] media: Media device node support

2011-01-06 Thread Greg KH
On Fri, Dec 24, 2010 at 12:59:38PM +0100, Laurent Pinchart wrote: Hi Greg, Thank you for the review. On Thursday 23 December 2010 04:32:53 Greg KH wrote: On Mon, Dec 20, 2010 at 12:36:24PM +0100, Laurent Pinchart wrote: The media_devnode structure provides support for registering

Re: [RFC/PATCH v7 01/12] media: Media device node support

2011-01-06 Thread Greg KH
On Fri, Jan 07, 2011 at 12:27:11AM +0100, Hans Verkuil wrote: On Thursday, January 06, 2011 23:19:12 Greg KH wrote: snip +static ssize_t media_read(struct file *filp, char __user *buf, + size_t sz, loff_t *off) +{ + struct media_devnode *mdev

Re: [RFC/PATCH v7 01/12] media: Media device node support

2011-01-06 Thread Greg KH
A: No. Q: Should I include quotations after my reply? http://daringfireball.net/2007/07/on_top On Thu, Jan 06, 2011 at 07:24:27PM -0500, Andy Walls wrote: Why, yes, there is a standard: http://pubs.opengroup.org/onlinepubs/009695399/functions/xsh_chap02_03.html A somewhat verbose

Re: [stable] [PATCH 1/4] [media] gspca - sonixj: Move bridge init to sd start

2011-02-16 Thread Greg KH
I'm confused, what tree is this for? .32? It's already in .37, right? thanks, greg k-h On Thu, Jan 06, 2011 at 09:28:35AM -0200, Mauro Carvalho Chehab wrote: Backports changeset 5e68f400aad4e2c29e2531cc4413c459fa88cb62 Signed-off-by: Jean-François Moine moin...@free.fr Signed-off-by:

Re: [stable] [PATCH 0/4] gspca fix backports for 2.6.36

2011-02-16 Thread Greg KH
On Thu, Jan 06, 2011 at 01:56:40PM +0100, Jean-Francois Moine wrote: On Thu, 6 Jan 2011 09:28:36 -0200 Mauro Carvalho Chehab mche...@redhat.com wrote: This patch series backport POWER INV fixes for sonixj sensors. Jean, I'm currently without any sensorj camera. Could you please

Re: [Security] [PATCH 00/20] world-writable files in sysfs and debugfs

2011-03-14 Thread Greg KH
On Mon, Mar 14, 2011 at 10:26:05PM -0400, James Bottomley wrote: On Sat, 2011-03-12 at 23:23 +0300, Vasiliy Kulikov wrote: Vasiliy Kulikov (20): mach-ux500: mbox-db5500: world-writable sysfs fifo file leds: lp5521: world-writable sysfs engine* files leds: lp5523: world-writable

Re: [Security] [PATCH 00/20] world-writable files in sysfs and debugfs

2011-03-15 Thread Greg KH
On Tue, Mar 15, 2011 at 07:50:28AM -0400, James Bottomley wrote: On Mon, 2011-03-14 at 20:09 -0700, Greg KH wrote: On Mon, Mar 14, 2011 at 10:26:05PM -0400, James Bottomley wrote: On Sat, 2011-03-12 at 23:23 +0300, Vasiliy Kulikov wrote: Vasiliy Kulikov (20): mach-ux500: mbox

Re: [ANNOUNCE] usbmon capture and parser script

2011-03-16 Thread Greg KH
On Wed, Mar 16, 2011 at 03:34:17PM -0300, Mauro Carvalho Chehab wrote: While trying to debug some issues on a driver on Linux, and using a Beagleboard card as a hardware USB sniffer[1], I noticed the need of having a parser to work with the sniffer data. While wireshark provides a good way of

Re: [ANNOUNCE] usbmon capture and parser script

2011-03-16 Thread Greg KH
On Wed, Mar 16, 2011 at 09:20:24PM +0100, Paul Bolle wrote: On Wed, 2011-03-16 at 12:47 -0700, Greg KH wrote: Very cool stuff. You are away of: http://vusb-analyzer.sourceforge.net/ right? I know you are doing this in console mode, but it looks close to the same idea. Perhaps

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-06 Thread Greg KH
On Wed, Apr 06, 2011 at 05:23:23PM +0200, Samuel Ortiz wrote: --- a/include/linux/device.h +++ b/include/linux/device.h @@ -33,6 +33,7 @@ struct class; struct subsys_private; struct bus_type; struct device_node; +struct mfd_cell; struct bus_attribute { struct attribute

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-06 Thread Greg KH
On Wed, Apr 06, 2011 at 07:05:38PM +0200, Samuel Ortiz wrote: Hi Greg, On Wed, Apr 06, 2011 at 08:58:05AM -0700, Greg KH wrote: On Wed, Apr 06, 2011 at 05:23:23PM +0200, Samuel Ortiz wrote: --- a/include/linux/device.h +++ b/include/linux/device.h @@ -33,6 +33,7 @@ struct class

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-06 Thread Greg KH
On Wed, Apr 06, 2011 at 11:25:57AM -0700, Andres Salomon wrote: We've been faced with the problem of being able to pass both MFD related data and a platform_data pointer to some of those drivers. Squeezing the MFD bits in the sub driver platform_data pointer doesn't work for drivers

Re: [PATCH 07/19] timberdale: mfd_cell is now implicitly available to drivers

2011-04-06 Thread Greg KH
On Wed, Apr 06, 2011 at 09:59:02PM +0300, Felipe Balbi wrote: Hi, On Wed, Apr 06, 2011 at 08:47:34PM +0200, Samuel Ortiz wrote: What is a MFD cell pointer and why is it needed in struct device? An MFD cell is an MFD instantiated device. MFD (Multi Function Device) drivers

Re: [stable] [PATCH] media/radio/wl1273: fix build errors

2011-04-11 Thread Greg KH
On Thu, Mar 31, 2011 at 08:09:57PM -0400, Mike Frysinger wrote: On Sun, Feb 27, 2011 at 12:51, Randy Dunlap wrote: From: Randy Dunlap randy.dun...@oracle.com RADIO_WL1273 needs to make sure that the mfd core is built to avoid build errors: ERROR: mfd_add_devices

Re: [PATCH] Fix cx88 remote control input

2011-05-04 Thread Greg KH
On Wed, May 04, 2011 at 05:16:29PM -0300, Mauro Carvalho Chehab wrote: Hi Lawerence, Em 03-05-2011 14:19, Jarod Wilson escreveu: On May 3, 2011, at 3:25 AM, Lawrence Rust wrote: On Mon, 2011-05-02 at 15:50 -0300, Mauro Carvalho Chehab wrote: Em 08-04-2011 09:50, Lawrence Rust

Re: [PATCH] Fix cx88 remote control input

2011-05-05 Thread Greg KH
On Wed, May 04, 2011 at 11:25:10PM -0300, Mauro Carvalho Chehab wrote: Em 04-05-2011 17:36, Greg KH escreveu: Yes, as long as .39 is working properly. We take patches in -stable for stuff like this at times, it just needs to be specified exactly like you did above. OK. Want me

[patch 36/38] [media] cx88: Fix HVR4000 IR keymap

2011-05-05 Thread Greg KH
2.6.38-stable review patch. If anyone has any objections, please let us know. -- From: Lawrence Rust l...@softsystem.dot.uk [fixed in .39 in a much different way that is too big to backport to .38 - gregkh] Fixes the RC key input for Nova-S plus, HVR1100, HVR3000 and HVR4000

Re: Fw: [PATCH -next RESEND/still needed] staging: altera-jtag needs delay.h

2011-05-19 Thread Greg KH
On Thu, May 19, 2011 at 04:22:06PM -0300, Mauro Carvalho Chehab wrote: Em 28-03-2011 12:23, Randy Dunlap escreveu: From: Randy Dunlap randy.dun...@oracle.com altera-jtag.c needs to include linux/delay.h to fix a build error: drivers/staging/altera-stapl/altera-jtag.c:398: error:

Re: [stable] [PATCH] pwc: better usb disconnect handling

2011-06-06 Thread Greg KH
On Mon, Jun 06, 2011 at 07:43:39PM +0200, Hans de Goede wrote: Unplugging a pwc cam while an app has the /dev/video# node open leads to an oops in pwc_video_close when the app closes the node, because the disconnect handler has free-ed the pdev struct pwc_video_close tries to use. Instead of

Re: USB mini-summit at LinuxCon Vancouver

2011-06-09 Thread Greg KH
On Thu, Jun 09, 2011 at 05:21:03PM -0700, Sarah Sharp wrote: Topic 1 --- The KVM folks suggested that it would be good to get USB and virtualization developers together to talk about how to virtualize the xHCI host controller. The xHCI spec architect worked closely with VMWare to get

Re: USB mini-summit at LinuxCon Vancouver

2011-06-10 Thread Greg KH
On Fri, Jun 10, 2011 at 12:48:15PM -0700, Sarah Sharp wrote: On Thu, Jun 09, 2011 at 08:18:05PM -0700, Greg KH wrote: On Thu, Jun 09, 2011 at 05:21:03PM -0700, Sarah Sharp wrote: Topic 1 --- The KVM folks suggested that it would be good to get USB and virtualization

Re: [PATCH v3 2/2] USB: EHCI: Allow users to override 80% max periodic bandwidth

2011-07-01 Thread Greg KH
On Fri, Jul 01, 2011 at 03:47:11PM +0400, Kirill Smelkov wrote: drivers/usb/host/ehci-sysfs.c | 104 +++-- As you are adding new sysfs files, it is required that you also add new entries in the Documentation/ABI/ directory. Please do that for these files

Re: [PATCH] [staging] lirc_serial: allocate irq at init time

2011-07-05 Thread Greg KH
On Thu, Jun 16, 2011 at 03:31:46PM -0400, Jarod Wilson wrote: There's really no good reason not to just grab the desired IRQ at driver init time, instead of every time the lirc device node is accessed. This also improves the speed and reliability with which a serial transmitter can operate, as

Re: [PATCH] [staging] lirc_serial: allocate irq at init time

2011-07-07 Thread Greg KH
On Thu, Jul 07, 2011 at 08:31:28PM -0400, Jarod Wilson wrote: On Tue, Jul 5, 2011 at 1:21 PM, Greg KH g...@kroah.com wrote: On Thu, Jun 16, 2011 at 03:31:46PM -0400, Jarod Wilson wrote: There's really no good reason not to just grab the desired IRQ at driver init time, instead of every time

Re: USB mini-summit at LinuxCon Vancouver

2011-08-04 Thread Greg KH
On Thu, Aug 04, 2011 at 07:21:47PM -0300, Mauro Carvalho Chehab wrote: I know that this problem were somewhat solved for 3G modems, with the usage of the userspace problem usb_modeswitch, and with some quirks for the USB storage driver, but I'm not sure if such tricks will scale forever, as

Re: USB mini-summit at LinuxCon Vancouver

2011-08-10 Thread Greg KH
On Wed, Aug 10, 2011 at 01:33:25PM -0500, Theodore Kilgore wrote: -- moving the kernel webcam drivers out of the kernel and doing with these cameras _everything_ including webcam function through libusb. I myself do not have the imagination to be able to figure out how this could be done

Re: [PATCH] usb: add reset endpoint operations

2009-04-08 Thread Greg KH
On Thu, Apr 09, 2009 at 03:36:51AM +0400, Alexey Klimov wrote: (added linux-media maillist) Hello, David On Wed, Apr 8, 2009 at 9:36 PM, David Vrabel david.vra...@csr.com wrote: Wireless USB endpoint state has a sequence number and a current window and not just a single toggle bit.  So

Re: patch usb-pwc-do-not-pass-stack-allocated-buffers-to-usb-core.patch added to gregkh-2.6 tree

2009-04-23 Thread Greg KH
...@gmail.com Date: Tue, 21 Apr 2009 21:48:09 +0200 Subject: USB: pwc : do not pass stack allocated buffers to USB core. To: Greg KH g...@kroah.com, linux-media@vger.kernel.org Message-ID: 20090421194808.8272.8437.st...@mfuzzey-laptop This is causes problems on platforms that have

Re: [PATCH] media: remove driver_data direct access of struct device

2009-05-11 Thread Greg KH
On Fri, May 01, 2009 at 10:18:38PM -0500, Mike Isely wrote: Acked-By: Mike Isely is...@pobox.com Note #1: I am just acking the pvrusb2 part of this. Note #2: I am immediately pulling the pvrusb2 part of these changes into that driver. Thanks for doing this, I appreciate it. greg k-h

Re: Probably strange bug with usb radio-mr800

2009-06-04 Thread Greg KH
On Fri, Jun 05, 2009 at 02:43:04AM +0400, Alexey Klimov wrote: Is there any ideas about different behaviour of device on 32- and 64-bit platforms with the same usb bulk messages? No, there should be no difference. Have you run usbmon to look at the data on the wire? thanks, greg k-h -- To

Re: [IR-RFC PATCH v4 2/6] Core IR module

2009-11-29 Thread Greg KH
On Thu, Nov 26, 2009 at 08:34:23PM -0500, Jon Smirl wrote: Changes to core input subsystem to allow send and receive of IR messages. Encode and decode state machines are provided for common IR porotocols such as Sony, JVC, NEC, Philips, etc. Received IR messages generate event in the input

Re: [IR-RFC PATCH v4 2/6] Core IR module

2009-11-29 Thread Greg KH
+static ssize_t ir_raw_show(struct device *dev, + struct device_attribute *attr, char *buf) +{ + struct input_dev *input_dev = to_input_dev(dev); + unsigned int i, count = 0; + + for (i = input_dev-ir-raw.tail; i != input_dev-ir-raw.head; ) { + +

Re: [IR-RFC PATCH v4 2/6] Core IR module

2009-11-29 Thread Greg KH
On Sun, Nov 29, 2009 at 12:37:36PM -0500, Jon Smirl wrote: On Sun, Nov 29, 2009 at 12:14 PM, Greg KH g...@kroah.com wrote: On Thu, Nov 26, 2009 at 08:34:23PM -0500, Jon Smirl wrote: Changes to core input subsystem to allow send and receive of IR messages. Encode and decode state machines

Re: [IR-RFC PATCH v4 2/6] Core IR module

2009-11-29 Thread Greg KH
On Sun, Nov 29, 2009 at 12:41:22PM -0500, Jon Smirl wrote: On Sun, Nov 29, 2009 at 12:17 PM, Greg KH g...@kroah.com wrote: +static ssize_t ir_raw_show(struct device *dev, + ? ? ? ? ? ? ? ? ? ? ? ? ? ? ?struct device_attribute *attr, char *buf) +{ + ? ? struct input_dev *input_dev

Re: [stable] [PATCH] ov511: fix probe() hang due to double mutex_lock

2009-12-10 Thread Greg KH
On Thu, Dec 10, 2009 at 05:04:49PM -0800, Brandon Philips wrote: Commit 163fe744c3283fd267268629afff4cfc846ed0e0 added a double mutex_lock which hangs ov51x_probe(). This was clearly a typo. Change final mutex_lock() - mutex_unlock() Signed-off-by: Brandon Philips bphil...@suse.de

Re: [stable] [PATCH v2] V4L/DVB: budget: Oops: BUG: unable to handle kernel NULL pointer dereference

2010-04-19 Thread Greg KH
On Wed, Mar 24, 2010 at 02:17:38PM +0100, Bjørn Mork wrote: Never call dvb_frontend_detach if we failed to attach a frontend. This fixes the following oops: [8.172997] DVB: registering new adapter (TT-Budget S2-1600 PCI) [8.209018] adapter has MAC addr = 00:d0:5c:cc:a7:29 [

Re: 0844-Staging-cx25821-fix-coding-style-issues-in-cx25821-a.patch

2010-04-28 Thread Greg KH
On Sun, Mar 14, 2010 at 06:13:16PM +0200, Olimpiu Pascariu wrote: From 9473816c446a6ca91905fc49a73732f70b5223b4 Mon Sep 17 00:00:00 2001 From: Olimpiu Pascariu olimpiu.pasca...@gmail.com Date: Sun, 14 Mar 2010 17:44:37 +0200 Subject: [PATCH 844/844] Staging: cx25821: fix coding style issues in

Re: [RFC 0/2] UVC gadget driver

2010-04-28 Thread Greg KH
On Thu, Apr 29, 2010 at 12:52:57AM +0200, Laurent Pinchart wrote: Hi everybody, Here's a new version of the UVC gadget driver I posted on the list some time ago, rebased on 2.6.34-rc5. The private events API has been replaced by the new V4L2 events API that will be available in 2.6.34

Re: [RFC 0/2] UVC gadget driver

2010-04-30 Thread Greg KH
On Thu, Apr 29, 2010 at 09:14:03AM +0200, Laurent Pinchart wrote: Hi Greg, On Thursday 29 April 2010 05:41:11 Greg KH wrote: On Thu, Apr 29, 2010 at 12:52:57AM +0200, Laurent Pinchart wrote: Hi everybody, Here's a new version of the UVC gadget driver I posted on the list some

Re: [PATCH 1/2] USB gadget: video class function driver

2010-05-03 Thread Greg KH
On Mon, May 03, 2010 at 02:29:57PM +0200, Laurent Pinchart wrote: Hi Viral, On Monday 03 May 2010 13:14:11 Viral Mehta wrote: Hi, This USB video class function driver implements a video capture device from the host's point of view. It creates a V4L2 output device on the gadget's

Re: [PATCH] drivers: remove all i2c_set_clientdata(client, NULL)

2010-05-31 Thread Greg KH
On Mon, May 31, 2010 at 02:55:48PM +0200, Wolfram Sang wrote: I2C-drivers can use the clientdata-pointer to point to private data. As I2C devices are not really unregistered, but merely detached from their driver, it used to be the drivers obligation to clear this pointer during remove() or a

Re: [PATCH 6/6] Staging: tm6000: Fix coding style issues Fixed coding style issues founded by checkpatch.pl in files: tm6000-alsa.c, tm6000-cards, tm6000-core.c, tm6000-dvb.c, tm6000-i2c.c, tm6000-std

2010-06-18 Thread Greg KH
This patch does not apply properly. What tree did you make it against? Please redo it against the latest linux-next tree and resend it. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 6/6] Staging: tm6000: Fix coding style issues Fixed coding style issues founded by checkpatch.pl in files: tm6000-alsa.c, tm6000-cards, tm6000-core.c, tm6000-dvb.c, tm6000-i2c.c, tm6000-std

2010-06-19 Thread Greg KH
On Sat, Jun 19, 2010 at 07:34:57AM +0200, Stefan Ringel wrote: Am 19.06.2010 01:46, schrieb Greg KH: This patch does not apply properly. What tree did you make it against? Please redo it against the latest linux-next tree and resend it. thanks, greg k-h please look in staging

Re: [2.6.33.4 PATCH] V4L/uvcvideo: Add support for Suyin Corp. Lenovo Webcam

2010-06-26 Thread Greg KH
On Sat, Jun 26, 2010 at 12:36:15PM +0200, Nils Radtke wrote: Isn't the vendor/product ID a point of reference that tells the kernel which module to load when supported hw is found? That was the idea behind adding the ID and submitting the patch. No, it also triggers off of the class

Re: S4 hang with uvcvideo causing Unlink after no-IRQ? Controller is probably using the wrong IRQ.

2009-03-06 Thread Greg KH
On Fri, Mar 06, 2009 at 11:11:22AM -0800, Brandon Philips wrote: Hello- When an UVC device is open and a S4 is attempted the thaw hangs (see the stack below). I don't see what the UVC driver is doing wrong to cause this to happen though. I don't think this is a uvc driver issue, it looks

Re: linux-next: Tree for March 11 (staging/multimedia)

2009-03-11 Thread Greg KH
On Wed, Mar 11, 2009 at 10:12:39AM -0700, Randy Dunlap wrote: Stephen Rothwell wrote: Hi all, Changes since 20090310: drivers/staging/go7007/go7007-v4l2.c:1830: error: 'VID_TYPE_CAPTURE' undeclared here (not in a function) Odd, nothing has changed in this driver, is this a v4l api

Re: linux-next: Tree for March 11 (staging/multimedia)

2009-03-11 Thread Greg KH
On Wed, Mar 11, 2009 at 11:21:52AM -0700, Randy Dunlap wrote: Greg KH wrote: On Wed, Mar 11, 2009 at 10:12:39AM -0700, Randy Dunlap wrote: Stephen Rothwell wrote: Hi all, Changes since 20090310: drivers/staging/go7007/go7007-v4l2.c:1830: error: 'VID_TYPE_CAPTURE' undeclared here

Re: [stable] Fwd: [PATCH] 2.6.27.y: fix NULL ptr deref in cx23885 video_open

2009-03-12 Thread Greg KH
On Thu, Mar 12, 2009 at 04:24:38PM -0400, Michael Krufky wrote: Can we have this merged into -stable? Jarod Wilson sent this last month, but he left off the cc to sta...@kernel.org What is the git commit id of the patch in Linus's tree that matches up with this? thanks, greg k-h -- To

Re: [stable] Fwd: [PATCH] 2.6.27.y: fix NULL ptr deref in cx23885 video_open

2009-03-12 Thread Greg KH
On Thu, Mar 12, 2009 at 11:00:11PM -0400, Jarod Wilson wrote: Greg KH wrote: On Thu, Mar 12, 2009 at 04:24:38PM -0400, Michael Krufky wrote: Can we have this merged into -stable? Jarod Wilson sent this last month, but he left off the cc to sta...@kernel.org What is the git commit id

Re: [patch -longterm v2] V4L/DVB: v4l2-ioctl: integer overflow in video_usercopy()

2012-01-05 Thread Greg KH
On Thu, Jan 05, 2012 at 09:28:22AM +0300, Dan Carpenter wrote: If p-count is too high the multiplication could overflow and array_size would be lower than expected. Mauro and Hans Verkuil suggested that we cap it at 1024. That comes from the maximum number of controls with lots of room for

Re: [PATCH 0/5] Get rid of get_driver() and put_driver()

2012-01-24 Thread Greg KH
On Tue, Jan 24, 2012 at 01:33:37PM -0500, Alan Stern wrote: Greg: This patch series removes the get_driver() and put_driver() routines from the kernel. Those routines don't do anything useful. Their comments say that they increment and decrement the driver's reference count, just like

Re: [BUG] v3.2.1: circular locking dvb_device_open / videobuf_dvb_find_frontend

2012-02-05 Thread Greg KH
On Sun, Feb 05, 2012 at 02:33:43PM +0100, Knut Petersen wrote: Hi Linus! The problem still exists in 3.2.4, but nobody seems to be interested ... Isn't it resolved in 3.3-rc2 already? If not, please work with the linux-media developers. thanks, greg k-h -- To unsubscribe from this list:

Re: [question] between probe() and open()

2012-02-25 Thread Greg KH
On Sat, Feb 25, 2012 at 07:09:49PM -0300, Ezequiel García wrote: Hello, This is a question in general about usb drivers and in particular about easycap driver. Is there any way a driver can be accesed between after usb_probe() but before device open()? usb_remove() can always be called

Re: [PATCH - stable v3.2] omap3isp: ccdc: Fix crash in HS/VS interrupt handler

2012-03-13 Thread Greg KH
On Sun, Mar 11, 2012 at 01:07:43PM +0100, Laurent Pinchart wrote: The HS/VS interrupt handler needs to access the pipeline object. It erronously tries to get it from the CCDC output video node, which isn't necessarily included in the pipeline. This leads to a NULL pointer dereference. Fix

  1   2   3   4   >