exchanged between both host and coprocessor.
This avoids to manage tables on both sides to get back the running context
of each instance.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/Kconfig| 1 +
drivers/media/platform/sti/delta/Makefile | 2 +-
drivers/media
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/sti/delta/delta-v4l2.c | 143 +-
drivers/media/platform/sti/delta/delta.h | 24 -
2 files changed, 165 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/sti/delta/delta-v4l2.c
b/drivers
test VIDIOC_EXPBUF: OK
Test input 0:
Total: 43, Succeeded: 43, Failed: 0, Warnings: 6
Hugues Fruchet (9):
Documentation: DT: add bindings for ST DELTA
ARM: dts: STiH410: add DELTA dt node
[media] MAINTAINERS: add st-delta driver
[media] st-delta: STiH4xx multi-format video decoder
This patch adds DT node for STMicroelectronics
DELTA V4L2 video decoder
Signed-off-by: Hugues Fruchet
---
arch/arm/boot/dts/stih410.dtsi | 10 ++
1 file changed, 10 insertions(+)
diff --git a/arch/arm/boot/dts/stih410.dtsi b/arch/arm/boot/dts/stih410.dtsi
index ff245e4..5f951cc 100644
Add entry for the STMicroelectronics DELTA driver.
Signed-off-by: Hugues Fruchet
---
MAINTAINERS | 8
1 file changed, 8 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index db814a8..fae934b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2363,6 +2363,14 @@ W: https
This V4L2 driver enables DELTA multi-format video decoder
of STMicroelectronics STiH4xx SoC series.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/Kconfig| 20 +
drivers/media/platform/Makefile |2 +
drivers/media/platform/sti/delta/Makefile
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/sti/delta/Makefile| 2 +-
drivers/media/platform/sti/delta/delta-mem.c | 51
drivers/media/platform/sti/delta/delta-mem.h | 14
drivers/media/platform/sti/delta/delta.h | 8 +
4 files
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/Kconfig | 6 +
drivers/media/platform/sti/delta/Makefile | 4 +
drivers/media/platform/sti/delta/delta-cfg.h | 4 +
drivers/media/platform/sti/delta/delta-mjpeg-dec.c | 439
This patch adds DT binding documentation for STMicroelectronics
DELTA V4L2 video decoder.
Signed-off-by: Hugues Fruchet
---
Documentation/devicetree/bindings/media/st,st-delta.txt | 17 +
1 file changed, 17 insertions(+)
create mode 100644 Documentation/devicetree/bindings
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/sti/delta/Makefile | 2 +-
drivers/media/platform/sti/delta/delta-debug.c | 164 +
drivers/media/platform/sti/delta/delta-debug.h | 18 +++
drivers/media/platform/sti/delta/delta-v4l2.c | 31 -
4 files
---
drivers/media/v4l2-core/v4l2-ctrls.c | 2 +-
include/uapi/linux/v4l2-controls.h | 163 +--
2 files changed, 140 insertions(+), 25 deletions(-)
diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c
b/drivers/media/v4l2-core/v4l2-ctrls.c
index c8bc4d4..6187dfc 1
http://www.spinics.net/lists/linux-media/msg104824.html
Hugues Fruchet (1):
[media] v4l2-ctrls: add mpeg2 parser metadata
drivers/media/v4l2-core/v4l2-ctrls.c | 2 +-
include/uapi/linux/v4l2-controls.h | 163 +--
2 files changed, 140 insertions(+), 25 deletions(-)
--
1
From: Tiphaine Inguere
If the input stream format is MPEG1 or MPEG2, the stream is parsed
using mpeg parser library to build mpeg metadata.
Change-Id: I767cd0a8ea546755bcdc031ca4a2808690cccf63
signed-off-by: Tiphaine Inguere
Signed-off-by: Hugues Fruchet
---
lib/libv4l-delta/Makefile.am
eeded by DELTA video decoder.
[1] http://www.mail-archive.com/linux-media@vger.kernel.org/msg102894.html
[2] http://www.spinics.net/lists/linux-media/msg104824.html
[3] https://lwn.net/Articles/641204/
Hugues Fruchet (2):
[media] st-delta: add parser meta controls
[media] st-delta: add mpeg2 sup
---
drivers/media/platform/sti/delta/delta-v4l2.c | 92 ++-
drivers/media/platform/sti/delta/delta.h | 8 ++-
2 files changed, 98 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/sti/delta/delta-v4l2.c
b/drivers/media/platform/sti/delta/delta-v4l2.c
show the premice of a libv4l2 plugin
infrastructure allowing to use any appropriate proprietary or open-source
bitstream parser needed by frame API based video hardware accelerators.
Hugues Fruchet (1):
add a libv4l plugin for st-delta video decoder
Tiphaine Inguere (2):
libv4l-delta: add
library shared
between GStreamer and V4L2 would be a far better implementation.
Change-Id: I7722c64e80101d833bbf9c973df846f60c3b8ee7
signed-off-by: Tiphaine Inguere
Signed-off-by: Hugues Fruchet
---
configure.ac |1 +
lib/libv4l-delta/Makefile.am
Change-Id: Ic586e3b2c7c15e76ea9aff318f8580eb3493e21b
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/Kconfig |6 +
drivers/media/platform/sti/delta/Makefile |3 +
drivers/media/platform/sti/delta/delta-cfg.h |5 +
drivers/media/platform/sti
f-by: Hugues Fruchet
---
configure.ac| 2 +
lib/Makefile.am | 3 +-
lib/libv4l-delta/Makefile.am| 9 +
lib/libv4l-delta/libv4l-delta.c | 344
lib/libv4l-delta/libv4l-delta.h | 97 ++
lib/li
Hi Sakari,
On 12/13/2017 08:47 PM, Sakari Ailus wrote:
> Hi Hugues,
>
> Hugues FRUCHET wrote:
>> Hi Sakari,
>>
>> On 12/07/2017 02:59 PM, Sakari Ailus wrote:
>>> Hi Hugues,
>>>
>>> On Thu, Dec 07, 2017 at 01:40:51PM +0100, Hugues Fruchet wrot
Thanks Sakari,
I'll push a patchset based on this discussion.
Best regards,
Hugues.
On 12/19/2017 11:08 AM, Sakari Ailus wrote:
> Hi Hugues,
>
> On Mon, Dec 18, 2017 at 10:24:40AM +, Hugues FRUCHET wrote:
>> Hi Sakari,
>>
>> On 12/13/2017 08:47 PM, S
Switch gpiod_set_value to gpiod_set_value_cansleep to avoid
warnings when powering sensor.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index
Refine CSI-2 endpoint documentation and add bindings
for DVP parallel interface support.
Signed-off-by: Hugues Fruchet
---
.../devicetree/bindings/media/i2c/ov5640.txt | 48 +-
1 file changed, 46 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree
ings
version 1:
- Initial submission
Hugues Fruchet (5):
media: ov5640: switch to gpiod_set_value_cansleep()
media: ov5640: check chip id
media: dt-bindings: ov5640: refine CSI-2 and add parallel interface
media: ov5640: add support of DVP parallel interface
media: ov5640: add suppor
Add support of DVP parallel mode in addition of
existing MIPI CSI mode. The choice between two modes
and configuration is made through device tree.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 148 +++--
1 file changed, 130 insertions
Add RGB565 (LE & BE) and YUV422 YUYV format in addition
to existing YUV422 UYVY format.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 74 +-
1 file changed, 67 insertions(+), 7 deletions(-)
diff --git a/drivers/media/i2c/ov5640
Verify that chip identifier is correct when probing.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 95 ++
1 file changed, 79 insertions(+), 16 deletions(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index
ore thing, please see below.
>>
>> On Wed, Dec 20, 2017 at 10:51:12AM +0100, Hugues Fruchet wrote:
>>> Refine CSI-2 endpoint documentation and add bindings
>>> for DVP parallel interface support.
>>>
>>> Signed-off-by: Hugues Fruchet
OK, thanks for all Sakari !
On 01/03/2018 10:10 AM, Sakari Ailus wrote:
> On Wed, Jan 03, 2018 at 08:47:09AM +0000, Hugues FRUCHET wrote:
>> Hi Sakari,
>> this is fine for me to drop those two lines so sync signals become
>> mandatory.
>> Must I repost a v5 serie ?
>
Refine CSI-2 endpoint documentation and add bindings
for DVP parallel interface support.
Signed-off-by: Hugues Fruchet
---
.../devicetree/bindings/media/i2c/ov5640.txt | 46 +-
1 file changed, 44 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree
isit ov5640_set_stream_dvp() to only configure DVP at streamon
- Revisit ov5640_set_stream_dvp() implementation with fewer register settings
version 1:
- Initial submission
Hugues Fruchet (5):
media: ov5640: switch to gpiod_set_value_cansleep()
media: ov5640: check chip id
media: dt-bind
Verify that chip identifier is correct when probing.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 95 ++
1 file changed, 79 insertions(+), 16 deletions(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index
Add RGB565 (LE & BE) and YUV422 YUYV format in addition
to existing YUV422 UYVY format.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 74 +-
1 file changed, 67 insertions(+), 7 deletions(-)
diff --git a/drivers/media/i2c/ov5640
Switch gpiod_set_value to gpiod_set_value_cansleep to avoid
warnings when powering sensor.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index
Add support of DVP parallel mode in addition of
existing MIPI CSI mode. The choice between two modes
and configuration is made through device tree.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 148 +++--
1 file changed, 130 insertions
v5 sent !
On 01/03/2018 10:23 AM, Sakari Ailus wrote:
> Hi Hugues,
>
> On Wed, Jan 03, 2018 at 09:12:43AM +0000, Hugues FRUCHET wrote:
>> OK, thanks for all Sakari !
>
> One thing I've missed so far --- the DT binding changes should be always
> cc'd to the devi
first check hsync/vsync polarities, the datasheet is
buggy on VSYNC polarity as documented in patch 4/5.
Best regards,
Hugues.
On 01/08/2018 04:38 PM, Maxime Ripard wrote:
> Hi Hugues,
>
> On Wed, Jan 03, 2018 at 10:57:27AM +0100, Hugues Fruchet wrote:
>> Enhance OV5640 CSI driver
om/linux-media@vger.kernel.org/msg122693.html
>>
>> version 2:
>>- Fix comments from Sakari Ailus:
>> https://www.mail-archive.com/linux-media@vger.kernel.org/msg122259.html
>>- Revisit ov5640_set_stream_dvp() to only configure DVP at streamon
>>- Revisi
- HREF: active low
+* - PCLK: active low
+*/
[...]
Best regards,
Hugues.
On 01/10/2018 04:37 PM, Maxime Ripard wrote:
> Hi Hugues,
>
> On Mon, Jan 08, 2018 at 05:13:39PM +, Hugues FRUCHET wrote:
>> I'm using a ST board with OV5640 wired in paralle
Hi Sakari,
On 01/10/2018 11:25 PM, Sakari Ailus wrote:
> Hi Hugues,
>
> On Wed, Jan 10, 2018 at 03:51:07PM +0000, Hugues FRUCHET wrote:
>> Good news Maxime !
>>
>> Have you seen that you can adapt the polarities through devicetree ?
>>
>> +
On 01/11/2018 09:19 AM, Sakari Ailus wrote:
> On Thu, Jan 11, 2018 at 08:12:11AM +0000, Hugues FRUCHET wrote:
>> Hi Sakari,
>>
>> On 01/10/2018 11:25 PM, Sakari Ailus wrote:
>>> Hi Hugues,
>>>
>>> On Wed, Jan 10, 2018 at 03:51:07PM +0
rest of code sequence.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index f017742..e2dd352 100644
--- a/drivers/media/i2c/ov5640.c
+++ b/drivers/media/i2c/ov5640.c
@@ -2057,6
for rest of code sequence.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index f017742..e2dd352 100644
--- a/drivers/media/i2c/ov5640.c
+++ b/drivers/media/i2c/ov5640.c
Add YUV422 encoded JPEG support.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 82 --
1 file changed, 80 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index e2dd352..db9aeeb 100644
Hi Sakari,
Thanks for reviewing,
On 01/22/2018 01:52 PM, Sakari Ailus wrote:
> Hi Hugues,
>
> On Mon, Jan 22, 2018 at 11:46:36AM +0100, Hugues Fruchet wrote:
>> Add YUV422 encoded JPEG support.
>>
>> Signed-off-by: Hugues Fruchet
>> ---
>
Add YUV422 encoded JPEG support.
Signed-off-by: Hugues Fruchet
---
version 2:
- Revisit code as per Sakari suggestions:
- fix lock scheme
- fix switch back to non-JPEG output while sensor powered
See https://www.mail-archive.com/linux-media@vger.kernel.org/msg124979.html
drivers
Add YUV422 encoded JPEG support.
Signed-off-by: Hugues Fruchet
---
version 2:
- Revisit code as per Sakari suggestions:
- fix lock scheme
- fix switch back to non-JPEG output while sensor powered
See https://www.mail-archive.com/linux-media@vger.kernel.org/msg124979.html
version 3
Add an error trace in ov5640_read_reg() in case of i2c_transfer()
failure.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index 99a5902..882a7c3 100644
Various typo & style fixes either detected by code
review or checkpatch.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 52 +++---
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/m
Hi Sakari,
I've made it symetric to ov5640_write_reg() which also uses v4l2_err,
I will change both so we are gone with all v4l2_err.
BR,
Hugues.
On 01/31/2018 12:57 PM, Sakari Ailus wrote:
> On Wed, Jan 31, 2018 at 12:19:24PM +0100, Hugues Fruchet wrote:
>> Add an error trace in o
Add an error trace in ov5640_read_reg() in case of i2c_transfer()
failure.
Uniformize error traces using dev_err instead v4l2_err.
Signed-off-by: Hugues Fruchet
---
version 2:
- Uniformize error traces using dev_err instead v4l2_err
as per Sakari's review comment.
drivers/medi
>
> On Wed, Jan 31, 2018 at 12:22:09PM +0100, Hugues Fruchet wrote:
>> Various typo & style fixes either detected by code
>> review or checkpatch.
>>
>> Signed-off-by: Hugues Fruchet
>> ---
>> drivers/media/i2c/ov5640.c | 52
>> +++
Comment added about module_param()
On 01/31/2018 03:29 PM, Hugues Fruchet wrote:
> Y're welcome, changes you pointed out are detected by checkpatch
> (--strict), see below:
>
> On 01/31/2018 03:23 PM, Sakari Ailus wrote:
>> Hi Hugues,
>>
>> Thanks for the pa
Various typo & style fixes either detected by code
review or checkpatch.
Signed-off-by: Hugues Fruchet
---
version 2:
As per Sakari's review comment:
- Drop module_param() permission update, will be pushed into a new commit
- Drop changes related to checkpatch "CHECK: Lines
set initial value to 0 for default value
and add an error trace in case of virtual_channel not in
the valid range of values.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/ov5640.c b
error trace in case of virtual_channel not in
the valid range of values.
Signed-off-by: Hugues Fruchet
---
version 2:
- Fix code as per Jacopo Mondi suggestions:
- int to uint
- no need to set global to 0
- shorten error trace
See https://www.mail-archive.com/linux-media
Hi Jacopo,
Thanks for review, v2 sent !
BR,
Hugues.
On 02/01/2018 05:56 PM, jacopo mondi wrote:
> Hi Hugues,
>
> On Thu, Feb 01, 2018 at 02:17:34PM +0100, Hugues Fruchet wrote:
>> Fix module_param(virtual_channel) permissions.
>> This problem was detected by che
Fix some missing "\n".
Trace error returned by subdev streamon/streamoff.
Remove extra "0x" unneeded with %pad formatter.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
Remove redundant capture enable already done
in dcmi_start_capture().
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers/media/platform/stm32/stm32-dcmi.c
index
It is already cleared in dcmi_irq_callback().
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers/media/platform/stm32/stm32-dcmi.c
index abc79d8..dfab867 100644
Remove some redundant code and fix/enhance some
error trace points.
Hugues Fruchet (3):
media: stm32-dcmi: remove redundant capture enable
media: stm32-dcmi: remove redundant clear of interrupt flags
media: stm32-dcmi: improve error trace points
drivers/media/platform/stm32/stm32-dcmi.c
Fix lock scheme leading to spurious freeze.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 57 ++-
1 file changed, 25 insertions(+), 32 deletions(-)
diff --git a/drivers/media/platform/stm32/stm32-dcmi.c
b/drivers/media/platform/stm32
, this slows down
system and lead to more overrun errors. Use a counter
instead and log errors at stop streaming.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 30 --
1 file changed, 12 insertions(+), 18 deletions(-)
diff --git a/drivers
Add g/s_parm framerate support by calling subdev
g/s_frame_interval ops.
This allows user to control sensor framerate by
calling ioctl G/S_PARM.
Signed-off-by: Hugues Fruchet
---
drivers/media/platform/stm32/stm32-dcmi.c | 49 +++
1 file changed, 49 insertions
Hi Jacopo,
In serie "[PATCH 0/5] Fix OV5640 exposure & gain"
https://www.mail-archive.com/linux-media@vger.kernel.org/msg133269.html
I've tried to collect fixes around exposure/gain, not only the exposure
regression and I would prefer to keep it consistent with the associated
procedure test.
Mor
Hi Jacopo,
Thanks for this patch, when testing on my side I don't see special
regression or enhancement with that fix, particularly on image quality
(exposure, ...),
do you have a test procedure that underline the issue ?
For example on my side when I do 5Mp then QVGA capture, pictures are
over
Save load of mode registers array when V4L2 client sets a format or a
frame interval which selects the same mode than the current one.
Signed-off-by: Hugues Fruchet
---
Version 2:
- Fix fuzzy image because of JPEG default format not being
changed according to new format selected, fix this
Ensure that auto gain and auto exposure are well restored
when changing mode.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 96 ++
1 file changed, 54 insertions(+), 42 deletions(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers
: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index c110a6a..923cc30 100644
--- a/drivers/media/i2c/ov5640.c
+++ b/drivers/media/i2c/ov5640.c
@@ -225,6 +225,7 @@ struct
fixes: bf4a4b518c20 ("media: ov5640: Don't force the auto exposure state at
start time").
Symptom was black image when capturing HD or 5Mp picture
due to manual exposure set to 1 while it was intended to
set autoexposure to "manual", fix this.
Signed-off-by: Hugues Fr
gain (int): min=0 max=1023 step=1 default=0
value=22 flags=inactive, volatile
Note the "0" for auto exposure.
===
= history =
===
version 2:
- Fix patch 3/5 commit comment and rename binning function as per jacopo'
suggestion:
https://www.mail-archive.com/lin
ov5640_set_mode_exposure_calc() is checking binning value but
binning value read is buggy, fix this.
Rename ov5640_binning_on() to ov5640_get_binning() as per other
similar functions.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 8
1 file changed, 4 insertions(+), 4
When switching from auto to manual mode, V4L2 core is calling
g_volatile_ctrl() in manual mode in order to get the manual initial value.
Remove the manual mode check/return to not break this behaviour.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 4
1 file changed, 4
initial value was set to JPEG, fix this.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 21 -
1 file changed, 16 insertions(+), 5 deletions(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index 071f4bc..2ddd86d 100644
--- a/drivers/media
Hi all,
Please ignore this v2, the v1 was merged.
I've just pushed a new patch which fixes the regression observed, see:
https://www.mail-archive.com/linux-media@vger.kernel.org/msg134413.html
Sorry for inconvenience.
Best regards,
Hugues.
On 08/13/2018 11:21 AM, Hugues Fruchet wrote:
&
Hi Jacopo,
On 08/16/2018 12:10 PM, jacopo mondi wrote:
> Hi Hugues,
> thanks for the patch
>
> On Mon, Aug 13, 2018 at 12:19:46PM +0200, Hugues Fruchet wrote:
>> Mode setting depends on last mode set, in particular
>> because of exposure calculation when downscal
Hi Laurent,
On 09/06/2018 03:31 PM, Laurent Pinchart wrote:
> Hi Hugues,
>
> Thank you for the patch.
>
> On Monday, 13 August 2018 13:19:45 EEST Hugues Fruchet wrote:
>> When switching from auto to manual mode, V4L2 core is calling
>> g_volatile_ctrl() in manual mode
Hi Laurent,
On 09/10/2018 12:46 PM, Laurent Pinchart wrote:
> Hi Hugues,
>
> On Monday, 10 September 2018 13:23:41 EEST Hugues FRUCHET wrote:
>> On 09/06/2018 03:31 PM, Laurent Pinchart wrote:
>>> On Monday, 13 August 2018 13:19:45 EEST Hugues Fruchet wrote:
>>>
Hi Laurent, Steve,
On 09/07/2018 04:18 PM, Laurent Pinchart wrote:
> Hello Hugues,
>
> On Thursday, 16 August 2018 18:07:54 EEST Hugues FRUCHET wrote:
>> On 08/16/2018 12:10 PM, jacopo mondi wrote:
>>> On Mon, Aug 13, 2018 at 12:19:46PM +0200, Hugues Fruchet wrote:
>&
Hi Jacopo,
On 08/25/2018 04:53 PM, jacopo mondi wrote:
> Hi Hugues,
> one more comment on this patch..
>
> On Mon, Aug 13, 2018 at 12:19:46PM +0200, Hugues Fruchet wrote:
>> Mode setting depends on last mode set, in particular
>> because of exposure calculation when
Hi Laurent,
On 09/10/2018 10:56 PM, Laurent Pinchart wrote:
> Hi Hugues,
>
> On Monday, 10 September 2018 18:14:45 EEST Hugues FRUCHET wrote:
>> On 09/07/2018 04:18 PM, Laurent Pinchart wrote:
>>> On Thursday, 16 August 2018 18:07:54 EEST Hugues FRUCHET wrote:
>>>
Hi Hans,
On 09/09/2018 11:38 AM, Hans Verkuil wrote:
> Hi Hugues,
>
> On 04/28/2017 03:25 PM, Hugues Fruchet wrote:
>> The patchset implements the MPEG-2 part of V4L2 unified low-level decoder
>> API RFC [0] needed by stateless video decoders, ie decoders which require
fixes: bf4a4b518c20 ("media: ov5640: Don't force the auto exposure state at
start time").
Symptom was black image when capturing HD or 5Mp picture
due to manual exposure set to 1 while it was intended to
set autoexposure to "manual", fix this.
Signed-off-by: Hugues Fruc
: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index c110a6a..427c2e7 100644
--- a/drivers/media/i2c/ov5640.c
+++ b/drivers/media/i2c/ov5640.c
@@ -225,6 +225,7
ov5640_set_mode_exposure_calc() is checking binning value but
binning value read is buggy, fix this.
Rename ov5640_binning_on() to ov5640_get_binning() as per other
similar functions.
Signed-off-by: Hugues Fruchet
Reviewed-by: Laurent Pinchart
---
drivers/media/i2c/ov5640.c | 8
1
When switching from auto to manual mode, V4L2 core is calling
g_volatile_ctrl() in manual mode in order to get the manual initial value.
Remove the manual mode check/return to not break this behaviour.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 4
1 file changed, 4
lists/linux-media/msg139457.html
version 2:
- Fix patch 3/5 commit comment and rename binning function as per jacopo'
suggestion:
https://www.mail-archive.com/linux-media@vger.kernel.org/msg133272.html
Hugues Fruchet (5):
media: ov5640: fix exposure regression
media: ov5640: fix aut
Ensure that auto gain and auto exposure are well restored
when changing mode.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 96 ++
1 file changed, 54 insertions(+), 42 deletions(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers
> Hi Sakari,
>> thanks for handling this
>>
>> On Sun, Sep 16, 2018 at 02:02:30AM +0300, Sakari Ailus wrote:
>>> Hi Jacopo, Hugues,
>>>
>>> On Fri, Sep 14, 2018 at 06:07:12PM +0200, jacopo mondi wrote:
>>>> Hi Sakari,
>>>>
>>>&g
Change 720p JPEG mode to mode 3 as per other resolutions.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c
index 30b15e9..664ffac 100644
--- a/drivers/media
this constraint.
Signed-off-by: Hugues Fruchet
---
Documentation/devicetree/bindings/media/video-interfaces.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/media/video-interfaces.txt
b/Documentation/devicetree/bindings/media/video-interfaces.txt
index
Reduce parallel port rate according to maximum pixel clock frequency
admissible by camera interface.
This allows to support any resolutions/framerate requests by decreasing
the framerate according to maximum camera interface capabilities.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c
Add pclk-max-frequency property in parallel port endpoint in order
to inform sensor of the maximum pixel clock frequency admissible
by camera interface that is connected on.
Signed-off-by: Hugues Fruchet
---
drivers/media/v4l2-core/v4l2-fwnode.c | 3 +++
include/media/v4l2-fwnode.h
Set DVP_PCLK_DIVIDER (0x3824) and VFIFO_CTRL0C (0x460c) registers
in ov5640_set_dvp_pclk() according to mode selected.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 66 --
1 file changed, 46 insertions(+), 20 deletions(-)
diff --git
ail-archive.com/linux-media@vger.kernel.org/msg131655.html
Hugues Fruchet (4):
media: ov5640: move parallel port pixel clock divider out of registers
set
media: v4l2-core: add pixel clock max frequency parallel port property
media: dt-bindings: media: Document pclk-max-frequency property
Hi Maxime & all OV5640 stakeholders,
I've just pushed a new patchset also related to rate/pixel clock
handling [1], based on your V3 great work:
>media: ov5640: Adjust the clock based on the expected rate
>media: ov5640: Remove the clocks registers initialization
>media: ov5640: Re
Hi Maxime,
On 09/28/2018 06:05 PM, Maxime Ripard wrote:
> Hi Hugues,
>
> On Thu, Sep 27, 2018 at 03:59:04PM +0000, Hugues FRUCHET wrote:
>> Hi Maxime & all OV5640 stakeholders,
>>
>> I've just pushed a new patchset also related to rate/pixel clock
>>
Hi Sakari,
On 09/28/2018 09:03 AM, Sakari Ailus wrote:
> Hi Hugues,
>
> On Thu, Sep 27, 2018 at 04:46:06PM +0200, Hugues Fruchet wrote:
>> This optional property aims to inform parallel video devices
>> of the maximum pixel clock frequency admissible by host video
>>
Changing framerate right before streamon had no effect,
the new framerate value was taken into account only at
next streamon, fix this.
Signed-off-by: Hugues Fruchet
---
drivers/media/i2c/ov5640.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c
Hi Maxime,
On 10/04/2018 05:04 PM, Maxime Ripard wrote:
> Hi!
>
> On Mon, Oct 01, 2018 at 02:12:31PM +0000, Hugues FRUCHET wrote:
>>>> This is working perfectly fine on my parallel setup and allows me to
>>>> well support VGA@30fps (instead 27) and also suppor
1 - 100 of 440 matches
Mail list logo
