Re: [PATCH] v4l2-ctrl.h: fix comments

On 15/06/16 11:10, Hans Verkuil wrote: The comments for the unlocked v4l2_ctrl_s_ctrl* functions were wrong (copy and pasted from the locked variants). Fix this, since it is confusing. Signed-off-by: Hans Verkuil diff --git a/include/media/v4l2-ctrls.h

Re: [PATCH 31/38] media: imx: Add video switch

For me this fails when I try to enable both video muxes (mx6dl, though mx6q should be the same). I get a sysfs duplicate name failure for 34.videomux. I realise passing the GPR13 register offset and a bitfield mask as a tuple in the reg value of the of_node is handy, but how should we account

Re: [PATCH v3 3/9] media: adv7180: add support for NEWAVMODE

On 25/07/16 23:04, Steve Longerbeam wrote: On 07/25/2016 12:36 PM, Ian Arkver wrote: On 25/07/16 18:55, Steve Longerbeam wrote: On 07/25/2016 05:04 AM, Ian Arkver wrote: On 23/07/16 18:00, Steve Longerbeam wrote: +#define ADV7180_VSYNC_FIELD_CTL_1_NEWAVMODE 0x02 See below re this value

Re: [PATCH v3 3/9] media: adv7180: add support for NEWAVMODE

Resend due to HTML email bounce. On 23/07/16 18:00, Steve Longerbeam wrote: Parse the optional v4l2 endpoint DT node. If the bus type is V4L2_MBUS_BT656 and the endpoint node specifies "newavmode", configure the BT.656 bus in NEWAVMODE. Signed-off-by: Steve Longerbeam

Re: [PATCH v3 3/9] media: adv7180: add support for NEWAVMODE

On 25/07/16 18:55, Steve Longerbeam wrote: On 07/25/2016 05:04 AM, Ian Arkver wrote: On 23/07/16 18:00, Steve Longerbeam wrote: Parse the optional v4l2 endpoint DT node. If the bus type is V4L2_MBUS_BT656 and the endpoint node specifies "newavmode", configure the BT.656 bus in

Re: [PATCHv2 7/7] [PATCHv5] media: adv7180: fix field type

On 03/08/16 15:23, Lars-Peter Clausen wrote: On 08/03/2016 04:11 PM, Hans Verkuil wrote: On 08/03/2016 03:21 PM, Niklas Söderlund wrote: On 2016-08-02 17:00:07 +0200, Lars-Peter Clausen wrote: [...] diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c index

Re: [PATCH 06/11] media: adv7180: add bt.656-4 OF property

This conversation has drifted off topic, sorry. It now relates to code in drivers/gpu/ipu-v3/ipu-csi.c, so adding Philipp Zabel. On 11/07/16 23:03, Steve Longerbeam wrote: On 07/11/2016 12:06 AM, Ian Arkver wrote: On 10/07/16 23:34, Steve Longerbeam wrote: On 07/10/2016 07:30 AM, Hans

Re: [PATCH v3 3/9] DocBook/v4l: Add compressed video formats used on MT8173 codec driver

On 12/07/16 20:14, Nicolas Dufresne wrote: Le mardi 12 juillet 2016 à 15:08 -0400, Nicolas Dufresne a écrit : Le mardi 12 juillet 2016 à 16:16 +0800, Wu-Cheng Li (李務誠) a écrit : Decoder hardware produces MT21 (compressed). Image processor can convert it to a format that can be input of display

Re: [PATCH 06/11] media: adv7180: add bt.656-4 OF property

On 10/07/16 13:55, Hans Verkuil wrote: On 07/10/2016 02:10 PM, Lars-Peter Clausen wrote: On 07/09/2016 11:36 PM, Steve Longerbeam wrote: On 07/09/2016 02:10 PM, Steve Longerbeam wrote: On 07/09/2016 11:59 AM, Steve Longerbeam wrote: On 07/07/2016 07:52 AM, Lars-Peter Clausen wrote: On

Re: [PATCH 06/11] media: adv7180: add bt.656-4 OF property

On 10/07/16 23:34, Steve Longerbeam wrote: On 07/10/2016 07:30 AM, Hans Verkuil wrote: On 07/10/2016 04:17 PM, Ian Arkver wrote: On 10/07/16 13:55, Hans Verkuil wrote: On 07/10/2016 02:10 PM, Lars-Peter Clausen wrote: On 07/09/2016 11:36 PM, Steve Longerbeam wrote: On 07/09/2016 02:10 PM

Re: [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

On 31/01/17 22:04, Russell King - ARM Linux wrote: On Tue, Jan 31, 2017 at 09:55:29PM +, Ian Arkver wrote: On 31/01/17 20:33, Russell King - ARM Linux wrote: On Tue, Jan 31, 2017 at 10:21:26AM -0800, Steve Longerbeam wrote: On 01/31/2017 05:42 AM, Russell King - ARM Linux wrote: On Fri

Re: [PATCH v3 20/24] media: imx: Add Camera Interface subdev driver

On 31/01/17 20:33, Russell King - ARM Linux wrote: On Tue, Jan 31, 2017 at 10:21:26AM -0800, Steve Longerbeam wrote: On 01/31/2017 05:42 AM, Russell King - ARM Linux wrote: On Fri, Jan 20, 2017 at 03:38:28PM +0100, Hans Verkuil wrote: Should be set to something like

Re: [PATCH v6 2/2] media: Add a driver for the ov5645 camera sensor.

On 26/10/16 15:07, Todor Tomov wrote: Hi, On 10/26/2016 03:48 PM, Ian Arkver wrote: [snip] +static int ov5645_regulators_enable(struct ov5645 *ov5645) +{ +int ret; + +ret = regulator_enable(ov5645->io_regulator); +if (ret < 0) { +dev_err(ov5645->dev, "set io

Re: [PATCH 07/22] [media] imx: Add IPUv3 media common code

On 07/10/16 17:00, Philipp Zabel wrote: From: Sascha Hauer Add video4linux API routines common to drivers for units that accept or provide video data via the i.MX IPU IDMAC channels, such as capture, mem2mem scaler or deinterlacer drivers. Signed-off-by: Sascha Hauer

Re: [PATCH v6 2/2] media: Add a driver for the ov5645 camera sensor.

[snip] +static int ov5645_regulators_enable(struct ov5645 *ov5645) +{ + int ret; + + ret = regulator_enable(ov5645->io_regulator); + if (ret < 0) { + dev_err(ov5645->dev, "set io voltage failed\n"); + return ret; + } + + ret =

Re: [PATCH 02/22] [media] v4l2-async: allow subdevices to add further subdevices to the notifier waiting list

On 14/10/16 16:48, Philipp Zabel wrote: Am Samstag, den 08.10.2016, 01:43 +0300 schrieb Sakari Ailus: [...] [...] diff --git a/include/media/v4l2-async.h b/include/media/v4l2-async.h index 8e2a236..e4e4b11 100644 --- a/include/media/v4l2-async.h +++ b/include/media/v4l2-async.h @@ -114,6

Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0

On 13/12/16 09:43, Sakari Ailus wrote: Hi Nicholas, On Tue, Dec 13, 2016 at 02:58:02AM +0100, Nicholas Mc Guire wrote: As this is not in atomic context and it does not seem like a critical timing setting a range of 1ms allows the timer subsystem to optimize the hrtimer here. I'd suggest not

Re: [PATCH] [media] coda: disable BWB for all codecs on CODA 960

Hi Philipp, On 02/03/17 10:19, Philipp Zabel wrote: I don't know what the BWB unit is, I guess W is for write and one of the Bs is for burst. All I know is that there repeatedly have been issues with it hanging on certain streams (ENGR00223231, ENGR00293425), with various firmware versions,

Re: [PATCH] [media] coda: disable BWB for all codecs on CODA 960

On 19/07/17 10:32, Philipp Zabel wrote: On Wed, 2017-07-19 at 10:15 +0100, Ian Arkver wrote: On 19/07/17 09:09, Philipp Zabel wrote: Hi Ian, On Wed, 2017-07-19 at 08:16 +0100, Ian Arkver wrote: Hi Philipp, On 02/03/17 10:19, Philipp Zabel wrote: Side effects are reduced burst lengths when

Re: [PATCH] [media] coda: disable BWB for all codecs on CODA 960

On 19/07/17 09:09, Philipp Zabel wrote: Hi Ian, On Wed, 2017-07-19 at 08:16 +0100, Ian Arkver wrote: Hi Philipp, On 02/03/17 10:19, Philipp Zabel wrote: Side effects are reduced burst lengths when writing out decoded frames to memory, so there is an "enable_bwb" module paramet

Re: [PATCH] [media] coda: disable BWB only while decoding on CODA 960

, but I can confirm that this patch restores the VPU encode performance. With that limitation... Tested-by: Ian Arkver <ian.arkver@gmail.com> Cc: Ian Arkver <ian.arkver@gmail.com> Reported-by: Ian Arkver <ian.arkver@gmail.com> Fixes: 89ed025d5c53 ("[media] co

Re: [PATCH v2 0/2] Avoid namespace collision within macros & tidyup

On 13/06/17 14:33, Ramesh Shanmugasundaram wrote: Hi All, The readx_poll_timeout & similar macros defines local variable that can cause name space collision with the caller. Fixed this issue by prefixing them with underscores. The compound statement has a local variable scope, so these won't

Re: [PATCH v2 0/2] Avoid namespace collision within macros & tidyup

On 14/06/17 08:18, Ramesh Shanmugasundaram wrote: Subject: Re: [PATCH v2 0/2] Avoid namespace collision within macros & tidyup On 13/06/17 14:33, Ramesh Shanmugasundaram wrote: Hi All, The readx_poll_timeout & similar macros defines local variable that can cause name space collision with the

Re: [PATCH] tc358743: fix connected/active CSI-2 lane reporting

On 21/09/17 12:04, Ian Arkver wrote: Hi Philipp On 21/09/17 11:24, Philipp Zabel wrote: g_mbus_config was supposed to indicate all supported lane numbers, not only the number of those currently in active use. Since the tc358743 can dynamically reduce the number of active lanes if the required

Re: [PATCH] tc358743: fix connected/active CSI-2 lane reporting

Hi Philipp On 21/09/17 11:24, Philipp Zabel wrote: g_mbus_config was supposed to indicate all supported lane numbers, not only the number of those currently in active use. Since the tc358743 can dynamically reduce the number of active lanes if the required bandwidth allows for it, report all

Re: [PATCH 4/6] media: imx-csi: Enable interlaced scan for field type alternate

On 28/05/18 08:00, Philipp Zabel wrote: On Fri, 2018-05-25 at 16:53 -0700, Steve Longerbeam wrote: Interlaced scan, a.k.a. interweave, should be enabled at the CSI IDMAC output pad if the input field type is 'alternate' (in addition to field types 'seq-tb' and 'seq-bt'). Which brings up

Re: [PATCH v4 09/10] v4l: xilinx: dma: Add multi-planar support

Hi Satish, On 01/05/18 02:35, Satish Kumar Nagireddy wrote: The current v4l driver supports single plane formats. This patch adds support to handle multi-planar formats. Driver can handle both single and multi-planar formats. Signed-off-by: Satish Kumar Nagireddy

Re: [PATCH] media: imx-media-internal-sd: Use memset to clear pdevinfo struct

On 09/02/18 16:36, Fabio Estevam wrote: When building with W=1 the following warning shows up: drivers/staging/media/imx/imx-media-internal-sd.c:274:49: warning: Using plain integer as NULL pointer Fix this problem by using memset() to clear the pdevinfo structure. Hi Fabio, I thought

Re: [PATCH] media: imx-media-internal-sd: Use memset to clear pdevinfo struct

On 09/02/18 21:17, Ian Arkver wrote: On 09/02/18 16:36, Fabio Estevam wrote: When building with W=1 the following warning shows up: drivers/staging/media/imx/imx-media-internal-sd.c:274:49: warning: Using plain integer as NULL pointer Fix this problem by using memset() to clear the pdevinfo

Re: [PATCH v2 9/9] [media] Add documentation for YUV420 bus format

On 09/02/18 01:22, Satish Kumar Nagireddy wrote: The code is MEDIA_BUS_FMT_VYYUYY8_1X24 Signed-off-by: Satish Kumar Nagireddy --- Documentation/media/uapi/v4l/subdev-formats.rst | 34 + 1 file changed, 34 insertions(+) diff --git

Re: [PATCH 16/22] [media] tvp5150: add querystd

On 02/08/18 10:49, Mauro Carvalho Chehab wrote: Em Thu, 2 Aug 2018 10:01:01 +0200 Marco Felsch escreveu: Hi Mauro, On 18-08-01 12:50, Mauro Carvalho Chehab wrote: Em Wed, 1 Aug 2018 16:49:26 +0200 Marco Felsch escreveu: Hi Mauro, On 18-08-01 11:22, Mauro Carvalho Chehab wrote: Em

Re: [PATCH] media: imx: shut up a false positive warning

Hi Mauro, On 07/08/18 10:58, Mauro Carvalho Chehab wrote: With imx, gcc produces a false positive warning: drivers/staging/media/imx/imx-media-csi.c: In function 'csi_idmac_setup_channel': drivers/staging/media/imx/imx-media-csi.c:457:6: warning: this statement may fall

Re: [PATCH] media: coda: do not try to propagate format if capture queue busy

On 28/03/18 18:12, Philipp Zabel wrote: The driver helpfully resets the capture queue format and selection rectangle whenever output format is changed. This only works while the capture queue is not busy. Signed-off-by: Philipp Zabel ---

Re: [PATCH 01/15] media: coda: fix memory corruption in case more than 32 instances are opened

Hi Philipp, On 05/11/2018 15:24, Philipp Zabel wrote: The ffz() return value is undefined if the instance mask does not contain any zeros. If it returned 32, the following set_bit would corrupt the debugfs_root pointer. Switch to IDA for context index allocation. This also removes the

Re: [PATCH v4 5/6] media: Add controls for JPEG quantization tables

Hi, On 03/09/2018 10:50, Hans Verkuil wrote: On 08/31/2018 05:52 PM, Ezequiel Garcia wrote: From: Shunqian Zheng Add V4L2_CID_JPEG_QUANTIZATION compound control to allow userspace configure the JPEG quantization tables. Signed-off-by: Shunqian Zheng Signed-off-by: Ezequiel Garcia ---

Re: [PATCH v4 5/6] media: Add controls for JPEG quantization tables

Hi Hans, Ezequiel, On 03/09/2018 16:33, Hans Verkuil wrote: On 09/03/2018 05:27 PM, Ezequiel Garcia wrote: Hi Ian, Hans: On Mon, 2018-09-03 at 14:29 +0100, Ian Arkver wrote: Hi, On 03/09/2018 10:50, Hans Verkuil wrote: On 08/31/2018 05:52 PM, Ezequiel Garcia wrote: From: Shunqian Zheng

Re: [PATCH v4 5/6] media: Add controls for JPEG quantization tables

Hi Ezequiel, On 03/09/2018 18:15, Ezequiel Garcia wrote: On Mon, 2018-09-03 at 16:51 +0100, Ian Arkver wrote: Hi Hans, Ezequiel, On 03/09/2018 16:33, Hans Verkuil wrote: On 09/03/2018 05:27 PM, Ezequiel Garcia wrote: Hi Ian, Hans: On Mon, 2018-09-03 at 14:29 +0100, Ian Arkver wrote: Hi

Re: [PATCH] media: cedrus: don't initialize pointers with zero

On 07/12/2018 11:37, Hans Verkuil wrote: On 12/07/2018 12:31 PM, Mauro Carvalho Chehab wrote: Em Fri, 7 Dec 2018 12:14:50 +0100 Hans Verkuil escreveu: On 12/07/2018 11:56 AM, Mauro Carvalho Chehab wrote: A common mistake is to assume that initializing a var with: struct foo f = { 0