[RFC] [PATCH 0/6] Add camera support to the OMAP1 Amstrad Delta videophone

2010-07-17 Thread Janusz Krzysztofik
This series consists of the following patches: 1/6 SoC Camera: add driver for OMAP1 camera interface 2/6 OMAP1: Add support for SoC camera interface 3/6 SoC Camera: add driver for OV6650 sensor 4/6 SoC Camera: add support for g_parm / s_parm operations 5/6 OMAP1: Amstrad

[RFC] [PATCH 1/6] SoC Camera: add driver for OMAP1 camera interface

2010-07-17 Thread Janusz Krzysztofik
/omap1_camera.c1970-01-01 01:00:00.0 +0100 +++ linux-2.6.35-rc3/drivers/media/video/omap1_camera.c 2010-07-18 01:32:48.0 +0200 @@ -0,0 +1,1656 @@ +/* + * V4L2 SoC Camera driver for OMAP1 Camera Interface + * + * Copyright (C) 2010, Janusz Krzysztofik jkrzy...@tis.icnet.pl

[RFC] [PATCH 2/6] OMAP1: Add support for SoC camera interface

2010-07-17 Thread Janusz Krzysztofik
This patch adds support for SoC camera interface to OMAP1 devices. Created and tested against linux-2.6.35-rc3 on Amstrad Delta. For successfull compilation, requires a header file provided by PATCH 1/6 from this series, SoC Camera: add driver for OMAP1 camera interface. Signed-off-by: Janusz

[RFC] [PATCH 3/6] SoC Camera: add driver for OV6650 sensor

2010-07-17 Thread Janusz Krzysztofik
camera supported operations, g_parm and s_parm. These can be used after applying patch 4/6 from this series, SoC Camera: add support for g_parm / s_parm operations. Created and tested against linux-2.6.35-rc3 on Amstrad Delta. Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl --- drivers

[RFC] [PATCH 4/6] SoC Camera: add support for g_parm / s_parm operations

2010-07-17 Thread Janusz Krzysztofik
on Amstrad Delta. Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl --- drivers/media/video/soc_camera.c | 18 ++ 1 file changed, 18 insertions(+) --- linux-2.6.35-rc3.orig/drivers/media/video/soc_camera.c 2010-06-26 15:55:34.0 +0200 +++ linux-2.6.35-rc3/drivers

[RFC] [PATCH 5/6] OMAP1: Amstrad Delta: add support for camera

2010-07-17 Thread Janusz Krzysztofik
against linux-2.6.35-rc3. Works on top of previous patches from the series, at least 1/6, 2/6 and 3/6. Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl --- arch/arm/mach-omap1/board-ams-delta.c | 45 ++ 1 file changed, 45 insertions(+) --- linux-2.6.35-rc3.orig

[RFC] [PATCH 6/6] OMAP1: Amstrad Delta: add camera controlled LEDS trigger

2010-07-17 Thread Janusz Krzysztofik
/ platforms as well, I can try to reimplement it at the SoC camera framework level, or OMAP1 camera interface level. Created and tested against linux-2.6.35-rc3. Works on top of patch 5/6, OMAP1: Amstrad Delta: add support for on-board camera Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl

Re: [RFC] [PATCH 0/6] Add camera support to the OMAP1 Amstrad Delta videophone

2010-07-20 Thread Janusz Krzysztofik
Tuesday 20 July 2010 11:49:54 Guennadi Liakhovetski wrote: Hi Janusz Hi Guennadi, Thanks for your answer. On Sun, 18 Jul 2010, Janusz Krzysztofik wrote: This series consists of the following patches: 1/6 SoC Camera: add driver for OMAP1 camera interface 2/6 OMAP1: Add

Re: [RFC] [PATCH 1/6] SoC Camera: add driver for OMAP1 camera interface

2010-07-30 Thread Janusz Krzysztofik
;). On Sun, 18 Jul 2010, Janusz Krzysztofik wrote: This is a V4L2 driver for TI OMAP1 SoC camera interface. Two versions of the driver are provided, using either videobuf-dma-contig or videobuf-dma-sg. The former uses less processing power, but often fails to allocate contignuous buffer memory

Re: [RFC] [PATCH 1/6] SoC Camera: add driver for OMAP1 camera interface

2010-08-01 Thread Janusz Krzysztofik
Friday 30 July 2010 20:49:05 Janusz Krzysztofik napisał(a): Friday 30 July 2010 13:07:42 Guennadi Liakhovetski napisał(a): On Sun, 18 Jul 2010, Janusz Krzysztofik wrote: This is a V4L2 driver for TI OMAP1 SoC camera interface. Two versions of the driver are provided, using either

Re: [RFC] [PATCH 1/6] SoC Camera: add driver for OMAP1 camera interface

2010-08-13 Thread Janusz Krzysztofik
Thursday 12 August 2010 23:38:17 Guennadi Liakhovetski napisał(a): On Sun, 1 Aug 2010, Janusz Krzysztofik wrote: Friday 30 July 2010 20:49:05 Janusz Krzysztofik napisał(a): I think the right way would be if implemented at the videobuf-core level. Then, drivers should be able

Re: [RFC] [PATCH 1/6] SoC Camera: add driver for OMAP1 camera interface

2010-08-13 Thread Janusz Krzysztofik
Friday 13 August 2010 11:11:52 Marin Mitov napisał(a): On Friday, August 13, 2010 11:52:41 am Guennadi Liakhovetski wrote: On Fri, 13 Aug 2010, Janusz Krzysztofik wrote: Thursday 12 August 2010 23:38:17 Guennadi Liakhovetski napisał(a): 1. We've discussed this dynamic switching a bit

Re: [RFC] [PATCH 1/6] SoC Camera: add driver for OMAP1 camera interface

2010-08-14 Thread Janusz Krzysztofik
Saturday 14 August 2010 06:47:56 Marin Mitov napisał(a): On Friday, August 13, 2010 10:13:08 pm Janusz Krzysztofik wrote: Friday 13 August 2010 11:11:52 Marin Mitov napisał(a): On Friday, August 13, 2010 11:52:41 am Guennadi Liakhovetski wrote: On Fri, 13 Aug 2010, Janusz Krzysztofik

Re: [RFC] [PATCH 1/6] SoC Camera: add driver for OMAP1 camera interface

2010-08-15 Thread Janusz Krzysztofik
Saturday 14 August 2010 19:33:09 Guennadi Liakhovetski napisał(a): On Fri, 13 Aug 2010, Janusz Krzysztofik wrote: Friday 13 August 2010 11:11:52 Marin Mitov napisał(a): On Friday, August 13, 2010 11:52:41 am Guennadi Liakhovetski wrote: On Fri, 13 Aug 2010, Janusz Krzysztofik wrote

Re: [RFC] [PATCH 1/6] SoC Camera: add driver for OMAP1 camera interface

2010-08-19 Thread Janusz Krzysztofik
Monday 16 August 2010 12:17:36 Marin Mitov wrote: On Saturday, August 14, 2010 08:33:09 pm Guennadi Liakhovetski wrote: On Fri, 13 Aug 2010, Janusz Krzysztofik wrote: Friday 13 August 2010 11:11:52 Marin Mitov napisał(a): On Friday, August 13, 2010 11:52:41 am Guennadi Liakhovetski wrote

Re: [RFC] [PATCH 1/6] SoC Camera: add driver for OMAP1 camera interface

2010-08-19 Thread Janusz Krzysztofik
Thursday 19 August 2010 14:16:21 Marin Mitov napisał(a): On Thursday, August 19, 2010 02:39:47 pm Guennadi Liakhovetski wrote: No, I don't think you should go to the next power of 2 - that's too crude. Try rounding your buffer size to the page size, that should suffice. Guennadi, If you

Re: [RFC] [PATCH 3/6] SoC Camera: add driver for OV6650 sensor

2010-08-22 Thread Janusz Krzysztofik
Hi Guennadi, Thanks for your review time. Sunday 22 August 2010 18:40:13 Guennadi Liakhovetski wrote: On Sun, 18 Jul 2010, Janusz Krzysztofik wrote: This patch provides a V4L2 SoC Camera driver for OV6650 camera sensor, found on OMAP1 SoC based Amstrad Delta videophone. Have you also had

[PATCH v2 4/6] SoC Camera: add support for g_parm / s_parm operations

2010-09-10 Thread Janusz Krzysztofik
on Amstrad Delta. Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl --- v1-v2 changes: - no functional changes, - refreshed against linux-2.6.36-rc3. drivers/media/video/soc_camera.c | 18 ++ 1 file changed, 18 insertions(+) diff -upr linux-2.6.36-rc3.orig/drivers/media

[PATCH v2 5/6] OMAP1: Amstrad Delta: add support for camera

2010-09-10 Thread Janusz Krzysztofik
against linux-2.6.36-rc3. Works on top of previous patches from the series, at least 1/6, 2/6 and 3/6. Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl --- v1-v2 changes: - no functional changes, - refreshed against linux-2.6.36-rc3 arch/arm/mach-omap1/board-ams-delta.c | 45

[PATCH v2 6/6] OMAP1: Amstrad Delta: add camera controlled LEDS trigger

2010-09-10 Thread Janusz Krzysztofik
5/6, OMAP1: Amstrad Delta: add support for on-board camera Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl --- Having no comments received on v1 of this patch, I assume nobody could see any benefit if I implemented this idea at the SoC camera or OMAP1 camera level, so I'm leaveing

[RESEND][PATCH v2 2/6] OMAP1: Add support for SoC camera interface

2010-09-10 Thread Janusz Krzysztofik
This patch adds support for SoC camera interface to OMAP1 devices. Created and tested against linux-2.6.36-rc3 on Amstrad Delta. For successfull compilation, requires a header file provided by PATCH 1/6 from this series, SoC Camera: add driver for OMAP1 camera interface. Signed-off-by: Janusz

Re: [PATCH v2 1/6] SoC Camera: add driver for OMAP1 camera interface

2010-09-22 Thread Janusz Krzysztofik
Wednesday 22 September 2010 01:23:22 Guennadi Liakhovetski napisał(a): On Sat, 11 Sep 2010, Janusz Krzysztofik wrote: This is a V4L2 driver for TI OMAP1 SoC camera interface. Both videobuf-dma versions are supported, contig and sg, selectable with a module option. The former uses less

Re: [PATCH v2 2/6] OMAP1: Add support for SoC camera interface

2010-09-22 Thread Janusz Krzysztofik
Wednesday 22 September 2010 08:53:19 Guennadi Liakhovetski napisał(a): That's up to the platform maintainer to review / apply this one, but if you like, a couple of nit-picks from me: Guennadi, Thanks for also looking at this! On Sat, 11 Sep 2010, Janusz Krzysztofik wrote: This patch adds

Re: [PATCH v2 3/6] SoC Camera: add driver for OV6650 sensor

2010-09-22 Thread Janusz Krzysztofik
Wednesday 22 September 2010 11:12:46 Guennadi Liakhovetski napisał(a): Ok, just a couple more comments, all looking quite good so far, if we get a new version soon enough, we still might manage it for 2.6.37 On Sat, 11 Sep 2010, Janusz Krzysztofik wrote: [snip] +/* write a register

Re: [PATCH v2 1/6] SoC Camera: add driver for OMAP1 camera interface

2010-09-23 Thread Janusz Krzysztofik
Thursday 23 September 2010 15:33:54 Guennadi Liakhovetski napisał(a): On Wed, 22 Sep 2010, Janusz Krzysztofik wrote: Wednesday 22 September 2010 01:23:22 Guennadi Liakhovetski napisał(a): On Sat, 11 Sep 2010, Janusz Krzysztofik wrote: + + vb = buf-vb

Re: [PATCH v2 3/6] SoC Camera: add driver for OV6650 sensor

2010-09-23 Thread Janusz Krzysztofik
Thursday 23 September 2010 18:06:15 Guennadi Liakhovetski napisał(a): On Wed, 22 Sep 2010, Janusz Krzysztofik wrote: Wednesday 22 September 2010 11:12:46 Guennadi Liakhovetski napisał(a): Ok, just a couple more comments, all looking quite good so far, if we get a new version soon enough

Re: [RESEND][PATCH v2 2/6] OMAP1: Add support for SoC camera interface

2010-09-23 Thread Janusz Krzysztofik
Friday 24 September 2010 01:23:10 Tony Lindgren napisał(a): * Janusz Krzysztofik jkrzy...@tis.icnet.pl [100910 18:26]: This patch adds support for SoC camera interface to OMAP1 devices. Created and tested against linux-2.6.36-rc3 on Amstrad Delta. For successfull compilation, requires

Re: [PATCH v2 5/6] OMAP1: Amstrad Delta: add support for camera

2010-09-23 Thread Janusz Krzysztofik
Friday 24 September 2010 01:26:17 Tony Lindgren napisał(a): * Tony Lindgren t...@atomide.com [100923 16:06]: * Janusz Krzysztofik jkrzy...@tis.icnet.pl [100910 18:20]: This patch adds configuration data and initialization code required for camera support to the Amstrad Delta board

Re: [RESEND][PATCH v2 2/6] OMAP1: Add support for SoC camera interface

2010-09-24 Thread Janusz Krzysztofik
Friday 24 September 2010 08:54:20 Guennadi Liakhovetski napisał(a): On Thu, 23 Sep 2010, Tony Lindgren wrote: * Janusz Krzysztofik jkrzy...@tis.icnet.pl [100923 16:37]: Friday 24 September 2010 01:23:10 Tony Lindgren napisał(a): I think you can just move the OMAP1_CAMERA_IOSIZE

Re: [PATCH v2 5/6] OMAP1: Amstrad Delta: add support for camera

2010-09-24 Thread Janusz Krzysztofik
Friday 24 September 2010 08:57:06 Guennadi Liakhovetski napisał(a): On Thu, 23 Sep 2010, Tony Lindgren wrote: * Janusz Krzysztofik jkrzy...@tis.icnet.pl [100923 16:52]: Friday 24 September 2010 01:26:17 Tony Lindgren napisał(a): * Tony Lindgren t...@atomide.com [100923 16:06

Re: [PATCH v2 3/6] SoC Camera: add driver for OV6650 sensor

2010-09-24 Thread Janusz Krzysztofik
Friday 24 September 2010 08:52:32 Guennadi Liakhovetski napisał(a): On Fri, 24 Sep 2010, Janusz Krzysztofik wrote: Thursday 23 September 2010 18:06:15 Guennadi Liakhovetski napisał(a): On Wed, 22 Sep 2010, Janusz Krzysztofik wrote: Wednesday 22 September 2010 11:12:46 Guennadi

[PATCH v3] OMAP1: Add support for SoC camera interface

2010-09-26 Thread Janusz Krzysztofik
-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl --- Tony, I hope this now satisfies your requirements. I resubmit only this updated patch, not the other two, Amstrad Delta specific, which you have alredy applied. Those are still valid (work for me), only the not yet merged include/media

[PATCH v3 3/6] SoC Camera: add driver for OV6650 sensor

2010-09-26 Thread Janusz Krzysztofik
to provide two not yet SoC camera supported operations, g_parm and s_parm. These can be used after applying patch 4/6 from this series, SoC Camera: add support for g_parm / s_parm operations. Created and tested against linux-2.6.36-rc5 on Amstrad Delta. Signed-off-by: Janusz Krzysztofik jkrzy

[PATCH v3] SoC Camera: add driver for OMAP1 camera interface

2010-09-30 Thread Janusz Krzysztofik
reset/powerdown input and what is the input polarity. Created and tested against linux-2.6.36-rc5 on Amstrad Delta. Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl --- Guennadi, Since 2.6.36-rc6 is out, I've decided to submit the driver, no longer trying to make it still better

Re: [PATCH v3 3/6] SoC Camera: add driver for OV6650 sensor

2010-10-02 Thread Janusz Krzysztofik
Saturday 02 October 2010 07:47:47 Guennadi Liakhovetski napisał(a): Ok, let's take this one, but, please, address the below couple of minor issues in an incremental patch. On Mon, 27 Sep 2010, Janusz Krzysztofik wrote: +/* write a register */ +static int ov6650_reg_write(struct i2c_client

Re: [PATCH v3] SoC Camera: add driver for OMAP1 camera interface

2010-10-02 Thread Janusz Krzysztofik
: add support for g_parm / s_parm operations, http://www.spinics.net/lists/linux-media/msg22887.html ? On Thu, 30 Sep 2010, Janusz Krzysztofik wrote: +static void omap1_videobuf_queue(struct videobuf_queue *vq, + struct videobuf_buffer *vb

Re: [PATCH v3] SoC Camera: add driver for OMAP1 camera interface

2010-10-04 Thread Janusz Krzysztofik
Sunday 03 October 2010 04:42:53 Guennadi Liakhovetski napisał(a): On Sat, 2 Oct 2010, Janusz Krzysztofik wrote: Saturday 02 October 2010 08:07:28 Guennadi Liakhovetski napisał(a): Same with this one - let's take it as is and address a couple of clean-ups later. Guennadi, Thanks

[PATCH 2.6.37-rc1] SoC Camera: OMAP1: update for recent framework changes

2010-11-02 Thread Janusz Krzysztofik
The recently added OMAP1 camera driver was not ready for one video queue per device framework changes. Fix it. Created and tested against linux-2.6.37-rc1. Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl --- drivers/media/video/omap1_camera.c |8 1 file changed, 4

[PATCH 2.6.37-rc1] SoC Camera: OMAP1: update for recent videobuf changes

2010-11-02 Thread Janusz Krzysztofik
Recent locking related videobuf changes has not been incorporated into the new OMAP1 camera driver. Fix it. Created and tested against linux-2.6.37-rc1. Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl --- drivers/media/video/omap1_camera.c |6 +++--- 1 file changed, 3 insertions

[PATCH] SOC Camera: OMAP1: typo fix

2010-11-02 Thread Janusz Krzysztofik
Fix an outstanding typo in the recently added driver, as requested by the subsystem maintainer. Created against linux-2.6.37-rc1. Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl --- drivers/media/video/omap1_camera.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux

[PATCH] SoC Camera: ov6650: minor cleanups

2010-11-02 Thread Janusz Krzysztofik
. Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl --- drivers/media/video/ov6650.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) --- linux-2.6.37-rc1/drivers/media/video/ov6650.c.orig 2010-11-01 22:41:59.0 +0100 +++ linux-2.6.37-rc1/drivers/media/video/ov6650.c

Re: [PATCH] SoC Camera: ov6650: minor cleanups

2010-11-13 Thread Janusz Krzysztofik
Monday 08 November 2010 22:20:33 Guennadi Liakhovetski wrote: On Tue, 2 Nov 2010, Janusz Krzysztofik wrote: This is a followup patch that addresses two minor issues left in the recently added ov6650 sensor driver, as I've promised to the subsystem maintainer: - remove a pair of extra

[PATCH 0/2] OMAP1: amsdelta: reserve memory for videobuf_contig

2010-12-05 Thread Janusz Krzysztofik
Latest developements seem to allow for reserving a block of memory on boot to be used as a device dedicated dma coherent memory. This may be required for videobuf_config based video drivers avoid problems with allocating dma coherent memory after system memory gets fragmented. This set extends

[PATCH 1/2] OMAP1: allow reserving memory for camera

2010-12-05 Thread Janusz Krzysztofik
for removing a block of memory from system memory early on boot, then, if reserved this way, declare it as the device dedicated dma coherent memory. An example use case on Amstrad Delta will be provided with patch 2/2. Created and tested against linux-2.6.37-rc4. Signed-off-by: Janusz Krzysztofik jkrzy

[PATCH 2/2] OMAP1: Amstrad Delta: reserve memory for camera

2010-12-05 Thread Janusz Krzysztofik
allocation failure after system memory gets fragmented. Created and tested against linux-2.6.27-rc4 on top of patch 1/2. Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl --- arch/arm/mach-omap1/board-ams-delta.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) --- linux

Re: [PATCH 0/2] OMAP1: amsdelta: reserve memory for videobuf_contig

2010-12-10 Thread Janusz Krzysztofik
Friday 10 December 2010 02:29:09 Tony Lindgren wrote: * Janusz Krzysztofik jkrzy...@tis.icnet.pl [101205 10:19]: Latest developements seem to allow for reserving a block of memory on boot to be used as a device dedicated dma coherent memory. This may be required for videobuf_config based

[RESEND] [PATCH 0/2] OMAP1: amsdelta: reserve memory for videobuf_contig

2010-12-10 Thread Janusz Krzysztofik
Since there were no request for changes, I'm resending the set, this time Cc linux-arm-kernel. Sunday 05 December 2010 19:29:05 Janusz Krzysztofik wrote: Latest developements seem to allow for reserving a block of memory on boot to be used as a device dedicated dma coherent memory. This may

[RESEND] [PATCH 1/2] OMAP1: allow reserving memory for camera

2010-12-10 Thread Janusz Krzysztofik
for removing a block of memory from system memory early on boot, then, if reserved this way, declare it as the device dedicated dma coherent memory. An example use case on Amstrad Delta will be provided with patch 2/2. Created and tested against linux-2.6.37-rc4. Signed-off-by: Janusz Krzysztofik jkrzy

[PATCH 2/2] OMAP1: Amstrad Delta: reserve memory for camera

2010-12-10 Thread Janusz Krzysztofik
allocation failure after system memory gets fragmented. Created and tested against linux-2.6.27-rc4 on top of patch 1/2. Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl --- arch/arm/mach-omap1/board-ams-delta.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) --- linux

Re: [RESEND] [PATCH 1/2] OMAP1: allow reserving memory for camera

2010-12-10 Thread Janusz Krzysztofik
Friday 10 December 2010 18:03:56 Russell King - ARM Linux napisał(a): On Fri, Dec 10, 2010 at 12:03:07PM +0100, Janusz Krzysztofik wrote: void __init omap1_camera_init(void *info) { struct platform_device *dev = omap1_camera_device; + dma_addr_t paddr

Re: [RESEND] [PATCH 1/2] OMAP1: allow reserving memory for camera

2010-12-19 Thread Janusz Krzysztofik
Wednesday 15 December 2010 18:01:42 Russell King - ARM Linux wrote: On Wed, Dec 15, 2010 at 12:39:20PM +, Catalin Marinas wrote: Should we not try to fix the generic code and still allow platforms to use dma_declare_coherent_memory() in a safer way? I guess it may need some

[PATCH] dma_declare_coherent_memory: push ioremap() up to caller

2010-12-23 Thread Janusz Krzysztofik
() method for reserving a region of system RAM preallocated with another dma_alloc_coherent(). Compile tested for all modified files except arch/sh/drivers/pci/fixups-dreamcast.c. Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl --- I intended to quote Russell in my commit message and even asked

Re: [PATCH] dma_declare_coherent_memory: push ioremap() up to caller

2010-12-23 Thread Janusz Krzysztofik
Friday 24 December 2010 00:54:34 Russell King - ARM Linux napisał(a): On Fri, Dec 24, 2010 at 12:20:32AM +0100, Janusz Krzysztofik wrote: The patch tries to implement a solution suggested by Russell King, http://lists.infradead.org/pipermail/linux-arm-kernel/2010-December /035264.html

Re: [PATCH] dma_declare_coherent_memory: push ioremap() up to caller

2010-12-24 Thread Janusz Krzysztofik
Friday 24 December 2010 14:02:00 Russell King - ARM Linux wrote: On Fri, Dec 24, 2010 at 12:20:32AM +0100, Janusz Krzysztofik wrote: The patch tries to implement a solution suggested by Russell King, http://lists.infradead.org/pipermail/linux-arm-kernel/2010-December /035264.html

Re: [PATCH] dma_declare_coherent_memory: push ioremap() up to caller

2010-12-24 Thread Janusz Krzysztofik
Friday 24 December 2010 16:41:20 Russell King - ARM Linux napisał(a): On Fri, Dec 24, 2010 at 02:55:25PM +0100, Janusz Krzysztofik wrote: Friday 24 December 2010 14:02:00 Russell King - ARM Linux wrote: On Fri, Dec 24, 2010 at 12:20:32AM +0100, Janusz Krzysztofik wrote: The patch tries

Re: [PATCH] dma_declare_coherent_memory: push ioremap() up to caller

2010-12-27 Thread Janusz Krzysztofik
Sunday 26 December 2010 18:45:00 Guennadi Liakhovetski wrote: On Sat, 25 Dec 2010, Janusz Krzysztofik wrote: [snip] Passing the virtual address allows the API to become much more flexible. Not only that, it allows it to be used on ARM, rather than becoming (as it currently stands

Re: [PATCH] V4L: omap1-camera: fix Oops with NULL platform data

2011-09-07 Thread Janusz Krzysztofik
On Wed, 7 Sep 2011 at 15:49:15 Guennadi Liakhovetski wrote: Consistently check for platform data != NULL before dereferencing. Sure, thanks for taking care of this. Janusz Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Cc: Janusz Krzysztofik jkrzy...@tis.icnet.pl --- drivers

Re: [PATCH 08/13 v3] ov6650: convert to the control framework.

2011-09-09 Thread Janusz Krzysztofik
: Acked-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl There are also a few minor comments for you to consider. Thanks, Janusz --- drivers/media/video/ov6650.c | 381 +- 1 files changed, 115 insertions(+), 266 deletions(-) diff --git a/drivers

Re: [PATCH 08/13 v3] ov6650: convert to the control framework.

2011-09-09 Thread Janusz Krzysztofik
On Fri, 9 Sep 2011 at 20:01:14 Guennadi Liakhovetski wrote: Hi Janusz On Fri, 9 Sep 2011, Janusz Krzysztofik wrote: On Thu, 8 Sep 2011 at 10:44:01 Guennadi Liakhovetski wrote: From: Hans Verkuil hans.verk...@cisco.com Signed-off-by: Hans Verkuil hans.verk...@cisco.com

[PATCH] media: ov6650: Fix wrong register used for red control

2011-09-12 Thread Janusz Krzysztofik
(), * v4l2_ctrl_new_std_menu() max value of V4L2_EXPOSURE_MANUAL instead of equivalent 1 looks more clear. Created on top of Converting soc_camera to the control framework series. Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl --- drivers/media/video/ov6650.c | 16 +++- 1 files

Re: [PATCH] media: ov6650: Fix wrong register used for red control

2011-09-12 Thread Janusz Krzysztofik
, and then add this your patch without that hunk and with an amended description on top, would that be ok with you? Yeah, that's exactly what I thought could be more appropriate. Thanks, Janusz Thanks Guennadi On Mon, 12 Sep 2011, Janusz Krzysztofik wrote: REG_BLUE has been used by mistake instead

Re: [PATCH v3] SoC Camera: add driver for OMAP1 camera interface

2011-03-23 Thread Janusz Krzysztofik
On Wednesday, 23 March 2011, at 11:00:06, Guennadi Liakhovetski wrote: Hi Janusz You might want to retest ams-delta with the camera on the current (next or git://linuxtv.org/media_tree.git staging/for_v2.6.39 ) kernel - I suspect, you'll need something similar to

[PATCH 2.6.39] soc_camera: OMAP1: fix missing bytesperline and sizeimage initialization

2011-04-08 Thread Janusz Krzysztofik
(). OMAP1 camera host driver has never been providing these parameters, so it no longer works correctly. Fix it by adding suitable assignments to omap1_cam_set_fmt(). Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl --- drivers/media/video/omap1_camera.c |6 ++ 1 file changed, 6

V4L/ARM: videobuf-dma-contig no longer works on my ARM machine (was: [PATCH v3] SoC Camera: add driver for OMAP1 camera interface)

2011-04-08 Thread Janusz Krzysztofik
On Wendesday, 23 March 2011, at 11:00:06, Guennadi Liakhovetski wrote: You might want to retest ams-delta with the camera on the current (next or git://linuxtv.org/media_tree.git staging/for_v2.6.39) kernel ... Hi Guennadi, With the patch I've just submitted to the linux-media list

Re: V4L/ARM: videobuf-dma-contig no longer works on my ARM machine

2011-04-09 Thread Janusz Krzysztofik
(CC: Jiri Slaby, the author of the problematic change; truncate subject) On Sat, 09 Apr 2011, at 09:16:24, Russell King - ARM Linux wrote: On Sat, Apr 09, 2011 at 03:33:39AM +0200, Janusz Krzysztofik wrote: Since there were no actual problems reported before, I suppose the old code, which

Re: [PATCH 2.6.39] soc_camera: OMAP1: fix missing bytesperline and sizeimage initialization

2011-04-10 Thread Janusz Krzysztofik
Dnia niedziela 10 kwiecień 2011 o 18:00:14 Guennadi Liakhovetski napisał(a): Hi Janusz On Sat, 9 Apr 2011, Janusz Krzysztofik wrote: Since commit 0e4c180d3e2cc11e248f29d4c604b6194739d05a, bytesperline and sizeimage memebers of v4l2_pix_format structure have no longer been calculated

[PATCH 2.6.39] V4L: videobuf-dma-contig: fix mmap_mapper broken on ARM

2011-04-10 Thread Janusz Krzysztofik
directions, should compensate. Both solutions tested on ARM OMAP1 based Amstrad Delta board. Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl --- drivers/media/video/videobuf-dma-contig.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) --- linux-2.6.39-rc2/drivers

Re: [PATCH 2.6.39] V4L: videobuf-dma-contig: fix mmap_mapper broken on ARM

2011-04-11 Thread Janusz Krzysztofik
On Mon 11 Apr 2011 at 02:42:13 Mauro Carvalho Chehab wrote: Em 10-04-2011 19:47, Janusz Krzysztofik escreveu: After switching from mem-dma_handle to virt_to_phys(mem-vaddr) used for obtaining page frame number passed to remap_pfn_range() (commit 35d9f510b67b10338161aba6229d4f55b4000f5b

Re: [PATCH] V4L: soc-camera: regression fix: calculate .sizeimage in soc_camera.c

2011-04-11 Thread Janusz Krzysztofik
Dnia poniedziałek 11 kwiecień 2011 o 10:58:26 Guennadi Liakhovetski napisał(a): A recent patch has given individual soc-camera host drivers a possibility to calculate .sizeimage and .bytesperline pixel format fields internally, however, some drivers relied on the core calculating these values

Re: [PATCH 2.6.39] V4L: videobuf-dma-contig: fix mmap_mapper broken on ARM

2011-04-11 Thread Janusz Krzysztofik
On Mon 11 Apr 2011 at 02:42:13 Mauro Carvalho Chehab wrote: Em 10-04-2011 19:47, Janusz Krzysztofik escreveu: After switching from mem-dma_handle to virt_to_phys(mem-vaddr) used for obtaining page frame number passed to remap_pfn_range() (commit 35d9f510b67b10338161aba6229d4f55b4000f5b

Re: [PATCH] V4L: soc-camera: regression fix: calculate .sizeimage in soc_camera.c

2011-04-11 Thread Janusz Krzysztofik
Dnia poniedziałek 11 kwiecień 2011 o 18:58:51 Guennadi Liakhovetski napisał(a): On Mon, 11 Apr 2011, Aguirre, Sergio wrote: Ok. And how about the attached patch? Would that work? Yes, I think, ot would work too, only the call to soc_camera_xlate_by_fourcc() in the S_FMT case is

Re: [PATCH] V4L: soc-camera: regression fix: calculate .sizeimage in soc_camera.c

2011-04-11 Thread Janusz Krzysztofik
Dnia poniedziałek 11 kwiecień 2011 o 22:05:35 Aguirre, Sergio napisał(a): Please find below a refreshed patch, which should be based on mainline commit: Hi, This version works for me, and fixes the regression. Thanks, Janusz From f767059c12c755ebe79c4b74de17c23a257007c7 Mon Sep 17

Re: [PATCH] V4L: soc-camera: regression fix: calculate .sizeimage in soc_camera.c

2011-04-12 Thread Janusz Krzysztofik
Dnia wtorek 12 kwiecień 2011 o 17:39:35 Aguirre, Sergio napisał(a): On Mon, Apr 11, 2011 at 4:52 PM, Janusz Krzysztofik jkrzy...@tis.icnet.pl wrote: Dnia poniedziałek 11 kwiecień 2011 o 22:05:35 Aguirre, Sergio napisał(a): Please find below a refreshed patch, which should be based

[PATCH 2.6.39 v2] V4L: videobuf-dma-contig: fix mmap_mapper broken on ARM

2011-04-12 Thread Janusz Krzysztofik
on ARM OMAP1 based Amstrad Delta board. Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl --- v1 - v2 changes: - drop dma_mmap_coherent() path, it may not work correctly for device memory preallocated with dma_declare_coherent_memory(). drivers/media/video/videobuf-dma-contig.c |4

Re: V4L/ARM: videobuf-dma-contig no longer works on my ARM machine

2011-04-13 Thread Janusz Krzysztofik
Dnia sobota 09 kwiecień 2011 o 18:42:40 Jiri Slaby napisał(a): On 04/09/2011 05:10 PM, Janusz Krzysztofik wrote: (CC: Jiri Slaby, the author of the problematic change; truncate subject) On Sat, 09 Apr 2011, at 09:16:24, Russell King - ARM Linux wrote: On Sat, Apr 09, 2011 at 03:33:39AM

Re: [PATCH 2.6.39 v2] V4L: videobuf-dma-contig: fix mmap_mapper broken on ARM

2011-04-13 Thread Janusz Krzysztofik
On Tue 12 Apr 2011 at 23:40:11 Russell King - ARM Linux wrote: On Tue, Apr 12, 2011 at 11:06:34PM +0200, Janusz Krzysztofik wrote: The patch tries to solve this regression by using virt_to_phys(bus_to_virt(mem-dma_handle)) instead of problematic virt_to_phys(mem-vaddr). Who says that DMA

Re: [PATCH 2.6.39 v2] V4L: videobuf-dma-contig: fix mmap_mapper broken on ARM

2011-04-13 Thread Janusz Krzysztofik
Dnia środa 13 kwiecień 2011 o 14:03:44 Sergei Shtylyov napisał(a): Hello. On 13-04-2011 1:06, Janusz Krzysztofik wrote: After switching from mem-dma_handle to virt_to_phys(mem-vaddr) used for obtaining page frame number passed to remap_pfn_range() (commit

Re: [PATCH 2.6.39 v2] V4L: videobuf-dma-contig: fix mmap_mapper broken on ARM

2011-04-13 Thread Janusz Krzysztofik
Dnia środa 13 kwiecień 2011 o 20:32:31 Russell King - ARM Linux napisał(a): On Wed, Apr 13, 2011 at 12:52:31PM +0200, Janusz Krzysztofik wrote: Taking into account that I'm just trying to fix a regression, and not invent a new, long term solution: are you able to name an ARM based board

Re: [PATCH 2.6.39 v2] V4L: videobuf-dma-contig: fix mmap_mapper broken on ARM

2011-04-13 Thread Janusz Krzysztofik
Dnia środa 13 kwiecień 2011 o 19:36:30 Sergei Shtylyov napisał(a): Hello. Janusz Krzysztofik wrote: After switching from mem-dma_handle to virt_to_phys(mem-vaddr) used for obtaining page frame number passed to remap_pfn_range() (commit 35d9f510b67b10338161aba6229d4f55b4000f5b

Re: [PATCH 2.6.39 v2] V4L: videobuf-dma-contig: fix mmap_mapper broken on ARM

2011-04-13 Thread Janusz Krzysztofik
Dnia środa 13 kwiecień 2011 o 23:01:55 Janusz Krzysztofik napisał(a): Dnia środa 13 kwiecień 2011 o 19:36:30 Sergei Shtylyov napisał(a): Hello. Janusz Krzysztofik wrote: After switching from mem-dma_handle to virt_to_phys(mem-vaddr) used for obtaining page frame number passed

Re: [PATCH 2.6.39 v2] V4L: videobuf-dma-contig: fix mmap_mapper broken on ARM

2011-04-13 Thread Janusz Krzysztofik
Dnia czwartek 14 kwiecień 2011 o 00:00:08 Russell King - ARM Linux napisał(a): On Wed, Apr 13, 2011 at 10:56:39PM +0200, Janusz Krzysztofik wrote: Dnia środa 13 kwiecień 2011 o 20:32:31 Russell King - ARM Linux napisał(a): On Wed, Apr 13, 2011 at 12:52:31PM +0200, Janusz Krzysztofik

Re: [PATCH 2/5] V4L: omap1-camera: fix huge lookup array

2011-05-23 Thread Janusz Krzysztofik
Dnia środa 18 maj 2011 o 16:11:30 Guennadi Liakhovetski napisał(a): Since V4L2_MBUS_FMT_* codes have become large and sparse, they cannot be used as array indices anymore. Hi Guennadi, Thanks for taking care of this. Regards, Janusz Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de

Re: [RESEND] [PATCH 1/2] OMAP1: allow reserving memory for camera

2011-06-08 Thread Janusz Krzysztofik
On Fri 10 Dec 2010 at 22:03:52 Janusz Krzysztofik wrote: Friday 10 December 2010 18:03:56 Russell King - ARM Linux napisał(a): On Fri, Dec 10, 2010 at 12:03:07PM +0100, Janusz Krzysztofik wrote: void __init omap1_camera_init(void *info) { struct platform_device *dev

Re: [RESEND] [PATCH 1/2] OMAP1: allow reserving memory for camera

2011-06-08 Thread Janusz Krzysztofik
On Thu 09 Jun 2011 at 00:13:30 Russell King - ARM Linux wrote: I stand by my answer to your patches quoted above from a technical point of view; we should not be mapping SDRAM using device mappings. That ioremap() inside dma_declare_coherent_memory() needs to die, Then how about your

[PATCH 3.0] soc_camera: OMAP1: stop falling back to dma-sg on single -ENOMEM

2011-06-09 Thread Janusz Krzysztofik
, more resource hungry videobuf-dma-sg mode if a single open() fails, as long as users are still able to switch DMA modes from user space over the driver provided sysfs interface, should videobuf-dma-contig mode still happen to keep failing for them. Tested on Amstrad Delta. Signed-off-by: Janusz

Re: [PATCH 3.0] soc_camera: OMAP1: stop falling back to dma-sg on single -ENOMEM

2011-06-09 Thread Janusz Krzysztofik
On Thu 09 Jun 2011 at 14:07:22 Guennadi Liakhovetski wrote: Hi Janusz On Thu, 9 Jun 2011, Janusz Krzysztofik wrote: Since commit 6d3163ce86dd386b4f7bda80241d7fea2bc0bb1d, mm: check if any page in a pageblock is reserved before marking it MIGRATE_RESERVE, the OMAP1 camera driver behaviour

Re: [Linaro-mm-sig] [PATCH 6/8] drivers: add Contiguous Memory Allocator

2011-07-09 Thread Janusz Krzysztofik
On Wed, 6 Jul 2011 at 16:59:45 Arnd Bergmann wrote: On Wednesday 06 July 2011, Nicolas Pitre wrote: On Wed, 6 Jul 2011, Russell King - ARM Linux wrote: Another issue is that when a platform has restricted DMA regions, they typically don't fall into the highmem zone. As the dmabounce

Re: [Linaro-mm-sig] [PATCH 6/8] drivers: add Contiguous Memory Allocator

2011-07-11 Thread Janusz Krzysztofik
Dnia poniedziałek, 11 lipca 2011 o 15:47:32 Marek Szyprowski napisał(a): Hello, On Saturday, July 09, 2011 4:57 PM Janusz Krzysztofik wrote: On Wed, 6 Jul 2011 at 16:59:45 Arnd Bergmann wrote: On Wednesday 06 July 2011, Nicolas Pitre wrote: On Wed, 6 Jul 2011, Russell King - ARM Linux

Re: [RESEND] [PATCH 1/2] OMAP1: allow reserving memory for camera

2011-07-12 Thread Janusz Krzysztofik
On Thu, 9 Jun 2011 at 00:13:30 Russell King - ARM Linux wrote: On Wed, Jun 08, 2011 at 11:53:49PM +0200, Janusz Krzysztofik wrote: On Fri 10 Dec 2010 at 22:03:52 Janusz Krzysztofik wrote: Friday 10 December 2010 18:03:56 Russell King - ARM Linux napisał(a): On Fri, Dec 10, 2010 at 12:03

Re: [PATCH 00/59] Convert soc-camera to .[gs]_mbus_config() subdev operations

2011-08-01 Thread Janusz Krzysztofik
Dnia piątek, 29 lipca 2011 o 12:56:00 Guennadi Liakhovetski napisał(a): This patch-series converts all soc-camera client and host drivers and the core from soc-camera specific .{query,set}_bus_param() operations to the new .[gs]_mbus_config() subdev operations. In order to prevent bisect

[PATCH] V4L: omap1_camera: fix missing linux/module.h include

2011-11-24 Thread Janusz Krzysztofik
Otherwise compilation breaks with: drivers/media/video/omap1_camera.c:1535: error: 'THIS_MODULE' undeclared here (not in a function) ... after apparently no longer included recursively from other header files. Signed-off-by: Janusz Krzysztofik jkrzy...@tis.icnet.pl --- drivers/media/video

Re: [PATCH] V4L: soc-camera: fix compiler warnings on 64-bit platforms

2011-12-05 Thread Janusz Krzysztofik
On Monday 05 of December 2011 at 16:15:28, Guennadi Liakhovetski wrote: On 64-bit platforms assigning a pointer to a 32-bit variable causes a compiler warning and cannot actually work. Soc-camera currently doesn't support any 64-bit systems, but such platforms can be added in the and in any

Re: [PATCH] V4L: soc-camera: fix compiler warnings on 64-bit platforms

2011-12-05 Thread Janusz Krzysztofik
On Monday 05 of December 2011 at 18:23:44, Janusz Krzysztofik wrote: On Monday 05 of December 2011 at 16:15:28, Guennadi Liakhovetski wrote: On 64-bit platforms assigning a pointer to a 32-bit variable causes a compiler warning and cannot actually work. Soc-camera currently doesn't support

Re: [PATCH v2] V4L: soc-camera: fix compiler warnings on 64-bit platforms

2011-12-05 Thread Janusz Krzysztofik
case compiler warnings should be avoided. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de --- v2: On Mon, 5 Dec 2011, Janusz Krzysztofik wrote: Hi Guennadi, Where is the v4l2_set_subdev_hostdata() supposed to be called from? I can find it called only from drivers/media

[RFC] [PATCH 3/3] staging: media: omap1: use dmaengine

2016-06-16 Thread Janusz Krzysztofik
Created and tested on Amstrad Delta on top of Linux-4.7-rc3 with "staging: media: omap1: convert to videobuf2" applied. Signed-off-by: Janusz Krzysztofik <jmkrzy...@gmail.com> --- drivers/staging/media/omap1/Kconfig| 2 +- drivers/staging/media/omap1/omap

[RFC] [PATCH 2/3] staging: media: omap1: convert to videobuf2

2016-06-16 Thread Janusz Krzysztofik
Created and tested on Amstrad Delta on top of Linux-4.7-rc3 with "staging: media: omap1: drop videobuf-dma-sg mode" applied. Signed-off-by: Janusz Krzysztofik <jmkrzy...@gmail.com> --- drivers/staging/media/omap1/Kconfig| 2 +- drivers/staging/media/omap1/omap

[RFC] [PATCH 1/3] staging: media: omap1: drop videobuf-dma-sg mode

2016-06-16 Thread Janusz Krzysztofik
fixes applied. Signed-off-by: Janusz Krzysztofik <jmkrzy...@gmail.com> --- drivers/staging/media/omap1/Kconfig | 1 - drivers/staging/media/omap1/omap1_camera.c | 445 --- include/linux/platform_data/media/omap1_camera.h | 9 - 3 files chang

[RFC] [PATCH 0/3] media: an attempt to refresh omap1_camera driver

2016-06-16 Thread Janusz Krzysztofik
how much time I have for that, i.e., when the soc-camera framework is going to be depreciated. Thanks, Janusz Janusz Krzysztofik (3): staging: media: omap1: drop videobuf-dma-sg mode staging: media: omap1: convert to videobuf2 staging: media: omap1: use dmaengine drivers/staging/media

[PATCH 3/3] media: i2c/soc_camera: fix ov6650 sensor getting wrong clock

2016-06-15 Thread Janusz Krzysztofik
;mclk", started to return respective CCF clock instead of the V4l2 one registered by soc_camera. Fix it by calling v4l2_clk_get() with NULL clock name. Created and tested on Amstrad Delta against Linux-4.7-rc3 with omap1_camera fixes. Signed-off-by: Janusz Krzysztofik <jmkrzy...@gmail.com&

[PATCH 2/3] staging: media: omap1: fix sensor probe not working anymore

2016-06-15 Thread Janusz Krzysztofik
soc_camera_host_register() invocation with clock_start() / clock_stop(). Created and tested on Amstrad Delta against Linux-4.7-rc3 with 'staging: media: omap1: fix null pointer dereference in omap1_cam_probe()' applied. Signed-off-by: Janusz Krzysztofik <jmkrzy...@gmail.com> --- drivers/s

  1   2   >