[PATCH v4 3/3] st-hva: add H.264 video encoding support

2016-07-25 Thread Jean-Christophe Trotin
: 1x1 only Signed-off-by: Yannick Fertre <yannick.fer...@st.com> Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com> --- drivers/media/platform/sti/hva/Makefile |2 +- drivers/media/platform/sti/hva/hva-h264.c | 1053 + drivers/media/

[PATCH v4 1/3] Documentation: DT: add bindings for ST HVA

2016-07-25 Thread Jean-Christophe Trotin
This patch adds DT binding documentation for STMicroelectronics hva driver. Signed-off-by: Yannick Fertre <yannick.fer...@st.com> Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com> --- .../devicetree/bindings/media/st,st-hva.txt| 24 ++

[PATCH v4 2/3] st-hva: multi-format video encoder V4L2 driver

2016-07-25 Thread Jean-Christophe Trotin
management utilities (hva-mem.c) This patch doesn't include the support of specific codec (e.g. H.264) video encoding: this support is part of subsequent patches. Signed-off-by: Yannick Fertre <yannick.fer...@st.com> Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com>

[PATCH v4 0/3] support of v4l2 encoder for STMicroelectronics SOC

2016-07-25 Thread Jean-Christophe Trotin
Streaming ioctls: test read/write: OK (Not Supported) test MMAP: OK test USERPTR: OK (Not Supported) test DMABUF: Cannot test, specify --expbuf-device Total: 46, Succeeded: 46, Failed: 0, Warnings: 8 Jean-Christophe Troti

Re: [PATCH v2 2/3] [media] hva: multi-format video encoder V4L2 driver

2016-07-25 Thread Jean Christophe TROTIN
On 07/21/2016 11:49 AM, Hans Verkuil wrote: > > > On 07/21/2016 09:30 AM, Jean Christophe TROTIN wrote: >> >> On 07/18/2016 01:45 PM, Hans Verkuil wrote: >>> Hi Jean-Christophe, >>> >>> See my review comments below. Nothing really major, but I

Re: [PATCH v2 2/3] [media] hva: multi-format video encoder V4L2 driver

2016-07-21 Thread Jean Christophe TROTIN
ll the other comments. All these modifications will be reflected in the version 3. Best regards, Jean-Christophe. > On 07/11/2016 05:14 PM, Jean-Christophe Trotin wrote: >> This patch adds V4L2 HVA (Hardware Video Accelerator) video encoder >> driver for STMicroelectronics SoC

Re: [PATCH v2 3/3] [media] hva: add H.264 video encoding support

2016-07-21 Thread Jean Christophe TROTIN
On 07/18/2016 01:55 PM, Hans Verkuil wrote: > On 07/11/2016 05:14 PM, Jean-Christophe Trotin wrote: >> This patch adds the H.264 video encoding capability in the V4L2 HVA >> video encoder driver for STMicroelectronics SoC (hva-h264.c). >> >> The main supported

[PATCH v3 3/3] hva: add H.264 video encoding support

2016-07-21 Thread Jean-Christophe Trotin
: 1x1 only Signed-off-by: Yannick Fertre <yannick.fer...@st.com> Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com> --- drivers/media/platform/sti/hva/Makefile |2 +- drivers/media/platform/sti/hva/hva-h264.c | 1053 + drivers/media/

[PATCH v3 2/3] hva: multi-format video encoder V4L2 driver

2016-07-21 Thread Jean-Christophe Trotin
management utilities (hva-mem.c) This patch doesn't include the support of specific codec (e.g. H.264) video encoding: this support is part of subsequent patches. Signed-off-by: Yannick Fertre <yannick.fer...@st.com> Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com>

[PATCH v3 1/3] Documentation: DT: add bindings for STI HVA

2016-07-21 Thread Jean-Christophe Trotin
This patch adds DT binding documentation for STMicroelectronics hva driver. Signed-off-by: Yannick Fertre <yannick.fer...@st.com> Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com> --- .../devicetree/bindings/media/st,sti-hva.txt | 24 ++

[PATCH v3 0/3] support of v4l2 encoder for STMicroelectronics SOC

2016-07-21 Thread Jean-Christophe Trotin
BUFS/QUERYBUF: OK test VIDIOC_EXPBUF: OK Test input 0: Streaming ioctls: test read/write: OK (Not Supported) test MMAP: OK test USERPTR: OK (Not Supported) test DMABUF: Cannot test, specify --expbuf-device Total

Re: [PATCH v2 2/3] [media] hva: multi-format video encoder V4L2 driver

2016-07-19 Thread Jean Christophe TROTIN
Hi Hans, Thank you for your comments. I've started to take them into account. I've got a question about V4L2_FIELD_ANY in buf_prepare (please see below). [snip] >> +static int hva_buf_prepare(struct vb2_buffer *vb) >> +{ >> + struct hva_ctx *ctx = vb2_get_drv_priv(vb->vb2_queue); >> +

Re: [PATCH v2 0/3] support of v4l2 encoder for STMicroelectronics SOC

2016-07-13 Thread Jean Christophe TROTIN
On 07/11/2016 08:57 PM, Javier Martinez Canillas wrote: > On Mon, Jul 11, 2016 at 1:48 PM, Nicolas Dufresne > <nicolas.dufre...@gmail.com> wrote: >> Le lundi 11 juillet 2016 à 17:14 +0200, Jean-Christophe Trotin a >> écrit : > > [snip] > >>&g

Re: [PATCH v2 2/3] [media] hva: multi-format video encoder V4L2 driver

2016-07-13 Thread Jean Christophe TROTIN
On 07/11/2016 08:00 PM, Nicolas Dufresne wrote: > Le lundi 11 juillet 2016 à 17:14 +0200, Jean-Christophe Trotin a écrit : [snip] >> +static int hva_g_fmt_stream(struct file *file, void *fh, struct v4l2_format >> *f) >> +{ >> +struct hva_ctx *ctx = f

[PATCH v2 1/3] Documentation: DT: add bindings for STI HVA

2016-07-11 Thread Jean-Christophe Trotin
This patch adds DT binding documentation for STMicroelectronics hva driver. Signed-off-by: Yannick Fertre <yannick.fer...@st.com> Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com> --- .../devicetree/bindings/media/st,sti-hva.txt | 24 ++

[PATCH v2 0/3] support of v4l2 encoder for STMicroelectronics SOC

2016-07-11 Thread Jean-Christophe Trotin
DMABUF: Cannot test, specify --expbuf-device Total: 45, Succeeded: 45, Failed: 0, Warnings: 12 Jean-Christophe Trotin (3): Documentation: DT: add bindings for STI HVA [media] hva: multi-format video encoder V4L2 driver [media] hva: add H.264 video encoding support .../devicetree/bindings

[PATCH v2 2/3] [media] hva: multi-format video encoder V4L2 driver

2016-07-11 Thread Jean-Christophe Trotin
management utilities (hva-mem.c) This patch doesn't include the support of specific codec (e.g. H.264) video encoding: this support is part of subsequent patches. Signed-off-by: Yannick Fertre <yannick.fer...@st.com> Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com>

[PATCH v2 3/3] [media] hva: add H.264 video encoding support

2016-07-11 Thread Jean-Christophe Trotin
: 1x1 only Signed-off-by: Yannick Fertre <yannick.fer...@st.com> Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com> --- drivers/media/platform/sti/hva/Makefile |2 +- drivers/media/platform/sti/hva/hva-h264.c | 1053 + drivers/media/

[PATCH v4 2/2] st-hva: add debug file system

2017-01-31 Thread Jean-Christophe Trotin
he last closed instance debugfs entry. Signed-off-by: Yannick Fertre <yannick.fer...@st.com> Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com> --- drivers/media/platform/Kconfig | 11 + drivers/media/platform/sti/hva/Makefile

[PATCH v4 1/2] st-hva: encoding summary at instance release

2017-01-31 Thread Jean-Christophe Trotin
, encoding...) errors Signed-off-by: Yannick Fertre <yannick.fer...@st.com> Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com> --- drivers/media/platform/sti/hva/hva-h264.c | 6 drivers/media/platform/sti/hva/hva-hw.c | 5 drivers/media/platform/sti/hva/hva

[PATCH v4 0/2] add debug capabilities to v4l2 encoder for STMicroelectronics SOC

2017-01-31 Thread Jean-Christophe Trotin
including the debug information) is saved to feed, on demand, the last closed instance debugfs entry. These debug capabilities are mainly implemented in the hva-debugfs.c file. Jean-Christophe Trotin (2): st-hva: encoding summary at instance release st-hva: add debug file system drivers/media/platfo

Re: [PATCH v3 1/3] st-hva: encoding summary at instance release

2017-01-31 Thread Jean Christophe TROTIN
On 01/30/2017 06:28 PM, Mauro Carvalho Chehab wrote: > Em Mon, 28 Nov 2016 11:30:52 +0100 > Jean-Christophe Trotin <jean-christophe.tro...@st.com> escreveu: > >> This patch prints unconditionnaly a short summary > > Why? Is this driver so broken that everyone would nee

Re: [PATCH v5 2/3] st-hva: multi-format video encoder V4L2 driver

2016-09-05 Thread Jean Christophe TROTIN
On 09/05/2016 10:24 AM, Hans Verkuil wrote: > On 08/29/2016 03:21 PM, Jean-Christophe Trotin wrote: >> This patch adds V4L2 HVA (Hardware Video Accelerator) video encoder >> driver for STMicroelectronics SoC. It uses the V4L2 mem2mem framework. >> >> This patch o

[PATCH v6 3/3] st-hva: add H.264 video encoding support

2016-09-05 Thread Jean-Christophe Trotin
: 1x1 only Signed-off-by: Yannick Fertre <yannick.fer...@st.com> Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com> Acked-by: Peter Griffin <peter.grif...@linaro.org> --- drivers/media/platform/sti/hva/Makefile |2 +- drivers/media/platform/sti/hva

RE: [STLinux Kernel] [PATCH v5 0/3] support of v4l2 encoder for STMicroelectronics SOC

2016-08-30 Thread Jean Christophe TROTIN
in the next version. Regards, JC. Jean-Christophe TROTIN | TINA: 1667397 | Tel: +33 244027397 | Mobile: +33 624726135 STMicroelectronics 9-11 rue Pierre-Félix Delarue | 72100 Le Mans | France ST online: www.st.com -Original Message- From: Peter Griffin [mailto:peter.grif...@linaro.org]

[PATCH v1 1/2] st-hva: encoding summary at instance release

2016-09-12 Thread Jean-Christophe Trotin
...) errors Signed-off-by: Yannick Fertre <yannick.fer...@st.com> Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com> --- drivers/media/platform/sti/hva/Makefile| 2 +- drivers/media/platform/sti/hva/hva-debug.c | 125 + drivers/media/plat

[PATCH v1 0/2] add debug capabilities to v4l2 encoder for STMicroelectronics SOC

2016-09-12 Thread Jean-Christophe Trotin
on demand, the last closed instance debugfs entry. These debug capabilities are mainly implemented in the hva-debug.c file. Jean-Christophe Trotin (2): st-hva: encoding summary at instance release st-hva: add debug file system drivers/media/platform/sti/hva/Makefile| 2 +-

[PATCH v1 2/2] st-hva: add debug file system

2016-09-12 Thread Jean-Christophe Trotin
Yannick Fertre <yannick.fer...@st.com> Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com> --- drivers/media/platform/sti/hva/hva-debug.c | 362 + drivers/media/platform/sti/hva/hva-hw.c| 39 drivers/media/platform/sti/hva/hva-hw.

Re: [PATCH v1 2/2] st-hva: add debug file system

2016-09-20 Thread Jean Christophe TROTIN
ory makes sense. It might be part of a different patch series dealing with the "sti coherency" (we discussed about that on IRC with Benjamin Gaignard few weeks ago). Regards, Jean-Christophe. > > On 09/12/2016 06:01 PM, Jean-Christophe Trotin wrote: >> This patch creates 4 static debug

[PATCH v2 2/2] [media] st-hva: add debug file system

2016-09-20 Thread Jean-Christophe Trotin
he last closed instance debugfs entry. Signed-off-by: Yannick Fertre <yannick.fer...@st.com> Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com> --- drivers/media/platform/sti/hva/hva-debug.c | 417 + drivers/media/platform/sti/hva/hva-hw.c

[PATCH v2 0/2] add debug capabilities to v4l2 encoder for STMicroelectronics SOC

2016-09-20 Thread Jean-Christophe Trotin
instance debugfs entry. These debug capabilities are mainly implemented in the hva-debug.c file. Jean-Christophe Trotin (2): [media] st-hva: encoding summary at instance release [media] st-hva: add debug file system drivers/media/platform/sti/hva/Makefile| 2 +- drivers/media/platform/sti/hva/hv

[PATCH v2 1/2] [media] st-hva: encoding summary at instance release

2016-09-20 Thread Jean-Christophe Trotin
, encoding...) errors Signed-off-by: Yannick Fertre <yannick.fer...@st.com> Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com> --- drivers/media/platform/sti/hva/Makefile| 2 +- drivers/media/platform/sti/hva/hva-debug.c | 71 ++ drivers/me

Re: [PATCH v4 0/3] support of v4l2 encoder for STMicroelectronics SOC

2016-08-23 Thread Jean Christophe TROTIN
t; test VIDIOC_G/S_EDID: OK (Not Supported) >> >> Control ioctls: >> test VIDIOC_QUERY_EXT_CTRL/QUERYMENU: OK >> test VIDIOC_QUERYCTRL: OK >> test VIDIOC_G/S_CTRL: OK >> test VIDIOC_G/S/TRY_EXT_CTRLS:

[PATCH v5 3/3] st-hva: add H.264 video encoding support

2016-08-29 Thread Jean-Christophe Trotin
: 1x1 only Signed-off-by: Yannick Fertre <yannick.fer...@st.com> Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com> --- drivers/media/platform/sti/hva/Makefile |2 +- drivers/media/platform/sti/hva/hva-h264.c | 1050 + drivers/media/

[PATCH v5 2/3] st-hva: multi-format video encoder V4L2 driver

2016-08-29 Thread Jean-Christophe Trotin
management utilities (hva-mem.c) This patch doesn't include the support of specific codec (e.g. H.264) video encoding: this support is part of subsequent patches. Signed-off-by: Yannick Fertre <yannick.fer...@st.com> Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com>

[PATCH v5 1/3] Documentation: DT: add bindings for ST HVA

2016-08-29 Thread Jean-Christophe Trotin
This patch adds DT binding documentation for STMicroelectronics hva driver. Signed-off-by: Yannick Fertre <yannick.fer...@st.com> Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com> --- .../devicetree/bindings/media/st,st-hva.txt| 24 ++

[PATCH v5 0/3] support of v4l2 encoder for STMicroelectronics SOC

2016-08-29 Thread Jean-Christophe Trotin
test DMABUF: Cannot test, specify --expbuf-device Total: 46, Succeeded: 46, Failed: 0, Warnings: 8 Jean-Christophe Trotin (3): Documentation: DT: add bindings for ST HVA st-hva: multi-format video encoder V4L2 driver st-hva: add H.264 video encoding support .../devi

Re: [PATCH] [media] st-hva: fix a copy-and-paste variable name error

2016-10-24 Thread Jean Christophe TROTIN
Thanks (and sorry for the delay of my answer), Acked-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com> On 09/19/2016 08:19 AM, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > The second check for an error on hva->lmi_err_reg appears > t

Re: [patch] [media] st-hva: fix some error handling in hva_hw_probe()

2016-10-24 Thread Jean Christophe TROTIN
Thanks, Acked-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com> On 10/14/2016 09:32 AM, Dan Carpenter wrote: > The devm_ioremap_resource() returns error pointers, never NULL. The > platform_get_resource() returns NULL on error, never error pointers. > The error code

[PATCH v3 0/3] add debug capabilities to v4l2 encoder for STMicroelectronics SOC

2016-11-28 Thread Jean-Christophe Trotin
encoding (HW processing duration, average bitrate, average framerate...) Each time a running instance is closed, its context (including the debug information) is saved to feed, on demand, the last closed instance debugfs entry. These debug capabilities are mainly implemented in the hva-debugfs.c f

[PATCH v3 2/3] st-hva: add debug file system

2016-11-28 Thread Jean-Christophe Trotin
he last closed instance debugfs entry. Signed-off-by: Yannick Fertre <yannick.fer...@st.com> Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com> --- drivers/media/platform/Kconfig | 11 + drivers/media/platform/sti/hva/Makefile

[PATCH v3 3/3] ARM: multi_v7_defconfig: enable STMicroelectronics HVA debugfs

2016-11-28 Thread Jean-Christophe Trotin
Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com> --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index eb14ab6..7a15107 100644 --- a/arch/arm/c

[PATCH v3 1/3] st-hva: encoding summary at instance release

2016-11-28 Thread Jean-Christophe Trotin
, encoding...) errors Signed-off-by: Yannick Fertre <yannick.fer...@st.com> Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com> --- drivers/media/platform/sti/hva/hva-h264.c | 6 drivers/media/platform/sti/hva/hva-hw.c | 5 drivers/media/platform/sti/hva/hva

Re: [PATCH v3 3/3] ARM: multi_v7_defconfig: enable STMicroelectronics HVA debugfs

2016-12-08 Thread Jean Christophe TROTIN
e you sure you want to enable it in the defconfig? I think in general > DEBUGFS config options aren't enabled by default. > > Regards, > > Hans > > On 11/28/2016 11:30 AM, Jean-Christophe Trotin wrote: >> Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com&

[PATCH v1] [media] v4l2-common: fix aligned value calculation

2016-12-16 Thread Jean-Christophe Trotin
Correct the calculation of the rounding to nearest aligned value in the clamp_align() function. For example, clamp_align(1277, 1, 9600, 2) returns 1276, while it should return 1280. Signed-off-by: Jean-Christophe Trotin <jean-christophe.tro...@st.com> --- drivers/media/v4l2-core/v4l2-co

Re: [PATCH v1] [media] v4l2-common: fix aligned value calculation

2017-01-03 Thread Jean Christophe TROTIN
. Regards, Jean-Christophe. On 12/16/2016 02:56 PM, Sakari Ailus wrote: > Hi Jean-Christophe, > > On Fri, Dec 16, 2016 at 02:32:15PM +0100, Jean-Christophe Trotin wrote: >> Correct the calculation of the rounding to nearest aligned value in >> the clamp_align() function. For example