iew.
Signed-off-by: Jia-Ju Bai
---
drivers/media/platform/sti/bdisp/bdisp-hw.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/media/platform/sti/bdisp/bdisp-hw.c
b/drivers/media/platform/sti/bdisp/bdisp-hw.c
index b7892f3..e94a371 100644
--- a/driv
Hi,
On 2017/12/15 22:51, Fabien DESSENNE wrote:
Hi
On 12/12/17 14:47, Jia-Ju Bai wrote:
The driver may sleep under a spinlock.
The function call path is:
bdisp_device_run (acquire the spinlock)
bdisp_hw_reset
msleep --> may sleep
To fix it, msleep is replaced with mdelay.
Ma
iew.
Signed-off-by: Jia-Ju Bai
---
drivers/media/platform/sti/bdisp/bdisp-hw.c | 23 ---
1 file changed, 12 insertions(+), 11 deletions(-)
diff --git a/drivers/media/platform/sti/bdisp/bdisp-hw.c
b/drivers/media/platform/sti/bdisp/bdisp-hw.c
index b7892f3..b63d9c9 100644
--
On 2017/12/19 18:43, Fabien DESSENNE wrote:
Hi,
On 16/12/17 12:54, Jia-Ju Bai wrote:
The driver may sleep under a spinlock.
The function call path is:
bdisp_device_run (acquire the spinlock)
bdisp_hw_reset
msleep --> may sleep
To fix it, readl_poll_timeout_atomic is used
coherent() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.
This is found by a static analysis tool named DCNS written by myself.
And I also manually check it.
Signe
urb() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.
This is found by a static analysis tool named DCNS written by myself.
And I also manually check it
urb() with GFP_ATOMIC,
which does not sleep for allocation.
GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL,
which can sleep and improve the possibility of sucessful allocation.
This is found by a static analysis tool named DCNS written by myself.
And I also manually check it
memory is freed by
vfree through the temporary value outside the lock holding.
Signed-off-by: Jia-Ju Bai
---
drivers/media/pci/cx18/cx18-alsa-pcm.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/pci/cx18/cx18-alsa-pcm.c
b/drivers/media/pci/cx18/cx18-alsa-
memory is freed by
vfree through the temporary value outside the lock holding.
Signed-off-by: Jia-Ju Bai
---
drivers/media/pci/ivtv/ivtv-alsa-pcm.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/pci/ivtv/ivtv-alsa-pcm.c
b/drivers/media/pci/ivtv/ivtv-alsa-
memory is freed by
vfree through the temporary value outside the lock holding.
Signed-off-by: Jia-Ju Bai
---
drivers/media/pci/ivtv/ivtv-alsa-pcm.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/media/pci/ivtv/ivtv-alsa-pcm.c
b/drivers/media/pci/ivtv/ivtv-alsa-
memory is freed by
vfree through the temporary value outside the lock holding.
Signed-off-by: Jia-Ju Bai
---
drivers/media/pci/cx18/cx18-alsa-pcm.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/media/pci/cx18/cx18-alsa-pcm.c
b/drivers/media/pci/cx18/cx18-alsa-
The driver may sleep under a spinlock.
The function call path is:
bdisp_device_run (acquire the spinlock)
bdisp_hw_reset
msleep --> may sleep
To fix it, msleep is replaced with mdelay.
This bug is found by my static analysis tool(DSAC) and checked by my code
review.
Signed-off-by: Jia
SAC) and checked by my code
review.
Signed-off-by: Jia-Ju Bai
---
drivers/media/platform/sti/bdisp/bdisp-hw.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/sti/bdisp/bdisp-hw.c
b/drivers/media/platform/sti/bdisp/bdisp-hw.c
index 4b62ceb..7b45
ode review.
Thanks,
Jia-Ju Bai
14 matches
Mail list logo
