[PATCH 1/1] DVB: fix dvr node refcounting

2010-07-18 Thread Jiri Slaby
] __device_release_driver+0x70/0xe0 ... So check against 1 there instead. BTW why's the TODO there? Adding TODOs to the code without descriptions is like adding nothing. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Markus Rechberger markus.rechber...@amd.com Cc: Mauro Carvalho Chehab mche...@infradead.org --- drivers

[PATCH 1/1] VIDEO: ivtvfb, remove unneeded NULL test

2010-07-19 Thread Jiri Slaby
the test. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Andy Walls awa...@md.metrocast.net Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: Tejun Heo t...@kernel.org Cc: Ian Armstrong i...@iarmst.demon.co.uk Cc: ivtv-de...@ivtvdriver.org Cc: linux-media@vger.kernel.org --- drivers/media/video/ivtv

Re: [PATCH] dvb: siano: free spinlock before schedule()

2010-07-27 Thread Jiri Slaby
On 07/27/2010 08:42 PM, Kulikov Vasiliy wrote: Calling schedule() holding spinlock with disables irqs is improper. As spinlock protects list coredev-buffers, it can be unlocked untill wakeup. This bug was introduced in a9349315f65cd6a16e8fab1f6cf0fd40f379c4db. Signed-off-by: Kulikov Vasiliy

[PATCH 1/4] V4L: cx231xx, fix lock imbalance

2010-10-27 Thread Jiri Slaby
Stanse found that there is mutex_lock in a fail path of cx231xx_i2c_xfer instead of mutex_unlock (i.e. double lock + leaving a function in locked state). So fix that. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Mauro Carvalho Chehab mche...@redhat.com Cc: Devin Heitmueller dheitmuel

[PATCH 1/1] V4L: videobuf, don't use dma addr as physical

2010-12-06 Thread Jiri Slaby
mem-dma_handle is a dma address obtained by dma_alloc_coherent which needn't be a physical address in presence of IOMMU. So ensure we are remapping (remap_pfn_range) the right page in __videobuf_mmap_mapper by using virt_to_phys(mem-vaddr) and not mem-dma_handle. Signed-off-by: Jiri Slaby jsl

[PATCH v2 1/1] V4L: videobuf, don't use dma addr as physical

2010-12-06 Thread Jiri Slaby
of explicit shift. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- drivers/media/video/videobuf-dma-contig.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video

[PATCH 1/1] DVB-USB: dib0700, fix oops with non-dib7000pc devices

2011-02-05 Thread Jiri Slaby
[dvb_core] ... Code: a6 f9 ff 48 83 c4 18 c3 66 66 66 2e 0f 1f 84 00 00 00 00 00 41 57 41 56 41 89 d6 41 55 49 89 f5 41 54 55 53 48 89 fb 48 83 ec 18 48 8b 47 10 48 83 38 00 0f 84 c8 00 00 00 65 48 8b 04 25 40 b5 Signed-off-by: Jiri Slaby jsl...@suse.cz --- drivers/media/dvb/dvb-usb

Re: [PATCH 1/1] DVB-USB: dib0700, fix oops with non-dib7000pc devices

2011-02-24 Thread Jiri Slaby
Hmm, could anybody pick it up? On 02/05/2011 07:20 PM, Jiri Slaby wrote: These devices use different internal structures (dib7000m) and dib7000p pid ctrl accesses invalid members causing kernel to die. Introduce pid control functions for dib7000m which operate on the correct structure

Re: [PATCH 1/1] DVB-USB: dib0700, fix oops with non-dib7000pc devices

2011-02-24 Thread Jiri Slaby
On 02/24/2011 01:53 PM, Mauro Carvalho Chehab wrote: Em 24-02-2011 09:24, Jiri Slaby escreveu: Hmm, could anybody pick it up? On 02/05/2011 07:20 PM, Jiri Slaby wrote: These devices use different internal structures (dib7000m) and dib7000p pid ctrl accesses invalid members causing kernel

[PATCH v2 -resend#1 1/1] V4L: videobuf, don't use dma addr as physical

2011-02-28 Thread Jiri Slaby
of explicit shift. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- drivers/media/video/videobuf-dma-contig.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video

Re: [PATCH v2 -resend#1 1/1] V4L: videobuf, don't use dma addr as physical

2011-02-28 Thread Jiri Slaby
On 02/28/2011 11:53 AM, Laurent Pinchart wrote: On Monday 28 February 2011 10:37:02 Jiri Slaby wrote: mem-dma_handle is a dma address obtained by dma_alloc_coherent which needn't be a physical address in presence of IOMMU. So ensure we are remapping (remap_pfn_range) the right page

Re: [PATCH v2 -resend#1 1/1] V4L: videobuf, don't use dma addr as physical

2011-02-28 Thread Jiri Slaby
On 02/28/2011 04:14 PM, Laurent Pinchart wrote: Hi Jiri, On Monday 28 February 2011 16:07:43 Jiri Slaby wrote: On 02/28/2011 11:53 AM, Laurent Pinchart wrote: On Monday 28 February 2011 10:37:02 Jiri Slaby wrote: mem-dma_handle is a dma address obtained by dma_alloc_coherent which needn't

Re: [PATCH v2 -resend#1 1/1] V4L: videobuf, don't use dma addr as physical

2011-02-28 Thread Jiri Slaby
On 02/28/2011 03:53 PM, Konrad Rzeszutek Wilk wrote: On Mon, Feb 28, 2011 at 10:37:02AM +0100, Jiri Slaby wrote: mem-dma_handle is a dma address obtained by dma_alloc_coherent which needn't be a physical address in presence of IOMMU. So ensure we are Can you add a comment why you are fixing

[PATCH v2 1/1] V4L: videobuf, don't use dma addr as physical

2011-03-01 Thread Jiri Slaby
v4l drivers use this layer and have no idea whether IOMMU is in the system and running or not. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- This is a version with updated changelog. drivers/media

Re: [PATCH v2 1/1] V4L: videobuf, don't use dma addr as physical

2011-03-01 Thread Jiri Slaby
On 03/01/2011 09:21 AM, Jiri Slaby wrote: mem-dma_handle is a dma address obtained by dma_alloc_coherent which needn't be a physical address as a hardware IOMMU can (and most likely will) return a bus address where physical != bus address. So ensure we are remapping (remap_pfn_range) the right

Re: [PATCH v2 -resend#1 1/1] V4L: videobuf, don't use dma addr as physical

2011-03-21 Thread Jiri Slaby
On 03/21/2011 11:43 PM, Mauro Carvalho Chehab wrote: As I got no return, and the patch looked sane, I've reviewed the comment myself, Aha, I forgot to send it. Sorry. It looks OK. Author: Jiri Slaby jsl...@suse.cz Date: Mon Feb 28 06:37:02 2011 -0300 [media] V4L: videobuf, don't

Re: V4L/ARM: videobuf-dma-contig no longer works on my ARM machine

2011-04-09 Thread Jiri Slaby
On 04/09/2011 05:10 PM, Janusz Krzysztofik wrote: (CC: Jiri Slaby, the author of the problematic change; truncate subject) On Sat, 09 Apr 2011, at 09:16:24, Russell King - ARM Linux wrote: On Sat, Apr 09, 2011 at 03:33:39AM +0200, Janusz Krzysztofik wrote: Since there were no actual problems

[REVERT] Re: V4L: videobuf-dma-contig: fix mmap_mapper broken on ARM

2011-04-19 Thread Jiri Slaby
that commit and rethink the mmap behaviour for some of next -rc1s. Linus, please revert commit 35d9f510b67b10338161aba6229d4f55b4000f5b Author: Jiri Slaby jsl...@suse.cz Date: Mon Feb 28 06:37:02 2011 -0300 [media] V4L: videobuf, don't use dma addr as physical === It fixes mmap when IOMMU is used

DVB_NET help message is useless

2011-06-16 Thread Jiri Slaby
Hi, I've just updated to 3.0-rc and saw CONFIG_DVB_NET. Hmm, let's see what's that by asking with '?'. And I got this crap: CONFIG_DVB_NET: The DVB network support in the DVB core can optionally be disabled if this option is set to N. If unsure say Y. Why do

[PATCH] DVB: dvb-net, make the kconfig text helpful

2011-06-16 Thread Jiri Slaby
Telling the user they can disable an option if they want is not the much useful. Describe what it is good for instead. The text was derived from Mauro's email. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Mauro Carvalho Chehab mche...@redhat.com Cc: Hans Petter Selasky hsela...@c2i.net

Re: [PATCH] DVB: dvb-net, make the kconfig text helpful

2011-06-17 Thread Jiri Slaby
On 06/17/2011 08:04 AM, Hans Petter Selasky wrote: PS: Don't forget the other patch to add a dependency to DVB_CORE. Sorry, I'm not your fixing monkey. Fix your bugs on your own. thanks, -- js -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to

Re: [PATCH] vino: replace dma_sync_single with dma_sync_single_for_cpu

2009-05-28 Thread Jiri Slaby
On 05/28/2009 03:10 AM, FUJITA Tomonori wrote: This replaces dma_sync_single() with dma_sync_single_for_cpu() because dma_sync_single() is an obsolete API; include/linux/dma-mapping.h says: /* Backwards compat, remove in 2.7.x */ #define dma_sync_single dma_sync_single_for_cpu

sleep in atomic in dvb_dmx_swfilter_packet

2009-06-19 Thread Jiri Slaby
Hi, we've found that there is a vmalloc call from atomic context: dvb_dmx_swfilter_packets - spin_lock() - dvb_dmx_swfilter_packet - vmalloc() -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH 2/4] V4L: em28xx, fix lock imbalance

2009-06-19 Thread Jiri Slaby
There is one omitted unlock in em28xx_usb_probe. Fix that. Signed-off-by: Jiri Slaby jirisl...@gmail.com --- drivers/media/video/em28xx/em28xx-cards.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/em28xx/em28xx-cards.c b/drivers/media/video/em28xx

[PATCH 4/4] V4L: saa7134, fix lock imbalance

2009-06-19 Thread Jiri Slaby
There seems to be one superfluos unlock in a poll function. Remove it. Signed-off-by: Jiri Slaby jirisl...@gmail.com --- drivers/media/video/saa7134/saa7134-video.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/saa7134/saa7134-video.c b/drivers

[PATCH 1/4] V4L: radio-si470x, fix lock imbalance

2009-06-19 Thread Jiri Slaby
There is one path with omitted unlock in si470x_fops_release. Fix that. Signed-off-by: Jiri Slaby jirisl...@gmail.com --- drivers/media/radio/radio-si470x.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/radio/radio-si470x.c b/drivers/media/radio

[PATCH 3/4] V4L: hdpvr, fix lock imbalances

2009-06-19 Thread Jiri Slaby
There are many lock imbalances in this driver. Fix all found. Signed-off-by: Jiri Slaby jirisl...@gmail.com --- drivers/media/video/hdpvr/hdpvr-core.c | 12 ++-- drivers/media/video/hdpvr/hdpvr-video.c |6 -- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git

dvb-apps: add scan file for Kojal, Czech Republic

2010-01-03 Thread Jiri Slaby
# HG changeset patch # User Jiri Slaby jirisl...@gmail.com # Date 1262532622 -3600 # Node ID 5f093a32da807e2e324e978e36ab092402aece6f # Parent a66ed623e524395f3805ce6266354f9e52913941 add scan file for Kojal, Czech Republic diff -r a66ed623e524 -r 5f093a32da80 util/scan/dvb-t/cz-Kojal --- /dev

Re: schedule inside spin_lock_irqsave?

2010-05-30 Thread Jiri Slaby
On 05/30/2010 04:52 PM, Richard Zidlicky wrote: Hi, came across following snippet of code (2.6.34:drivers/media/dvb/siano/smscoreapi.c) and since prepare_to_wait is new for me I am wondering if this is can work? struct smscore_buffer_t *smscore_getbuffer(struct smscore_device_t

Re: schedule inside spin_lock_irqsave?

2010-05-30 Thread Jiri Slaby
On 05/30/2010 05:24 PM, Jiri Slaby wrote: struct smscore_buffer_t *get_entry(void) { struct smscore_buffer_t *cb = NULL; spin_lock_irqsave(coredev-bufferslock, flags); if (!list_empty(coredev-buffers)) { cb = (struct smscore_buffer_t *) coredev-buffers.next; Looking

Re: [PATCH 2.6.34] schedule inside spin_lock_irqsave

2010-06-06 Thread Jiri Slaby
On 06/06/2010 02:43 PM, Richard Zidlicky wrote: Hi, I have done a minimaly invasive patch for the stable 2.6.34 kernel and stress-tested it for many hours, definitely seems to improve the behaviour. I have left out your beautification suggestion for now, want to do more playing with

[PATCH] VIDEO: ivtvfb, remove unneeded NULL test

2010-06-22 Thread Jiri Slaby
Stanse found that in ivtvfb_callback_cleanup there is an unneeded test for itv being NULL. But itv is initialized as container_of with non-zero offset, so it is never NULL (even if v4l2_dev is). This was found because itv is dereferenced earlier than the test. Signed-off-by: Jiri Slaby jsl

Re: [PATCH] VIDEO: ivtvfb, remove unneeded NULL test

2010-07-04 Thread Jiri Slaby
On 07/04/2010 06:11 AM, Andy Walls wrote: You missed an identical instance of the useless test 10 lines prior in ivtvfb_callback_init(). :) Ah, thank you for pointing out. Find my comment below. --- a/drivers/media/video/ivtv/ivtvfb.c +++ b/drivers/media/video/ivtv/ivtvfb.c @@ -1201,9

Re: [PATCH] VIDEO: ivtvfb, remove unneeded NULL test

2010-07-05 Thread Jiri Slaby
On 07/04/2010 03:22 PM, Andy Walls wrote: On Sun, 2010-07-04 at 09:24 +0200, Jiri Slaby wrote: On 07/04/2010 06:11 AM, Andy Walls wrote: --- a/drivers/media/video/ivtv/ivtvfb.c +++ b/drivers/media/video/ivtv/ivtvfb.c @@ -1201,9 +1201,14 @@ static int ivtvfb_init_card(struct ivtv *itv

MEDIA: lirc, improper locking

2010-07-07 Thread Jiri Slaby
Hi, stanse found a locking error in lirc_dev_fop_read: if (mutex_lock_interruptible(ir-irctl_lock)) return -ERESTARTSYS; ... while (written length ret == 0) { if (mutex_lock_interruptible(ir-irctl_lock)) {#1 ret = -ERESTARTSYS; break; } ... }

[PATCH 2/4] DVB: dib0700, separate stk7070pd initialization

2012-01-10 Thread Jiri Slaby
The start is common for both stk7070pd and novatd specific routine. This is just a preparation for the next patch. Signed-off-by: Jiri Slaby jsl...@suse.cz --- drivers/media/dvb/dvb-usb/dib0700_devices.c | 22 ++ 1 files changed, 14 insertions(+), 8 deletions(-) diff --git

[PATCH 4/4] DVB: dib0700, add support for Nova-TD LEDs

2012-01-10 Thread Jiri Slaby
Add an override of read_status to intercept lock status. This allows us to switch LEDs appropriately on and off with signal un/locked. The second phase is to override sleep to properly turn off both. This is a hackish way to achieve that. Thanks to Mike Krufky for his help. Signed-off-by: Jiri

[PATCH 3/4] DVB: dib0700, add corrected Nova-TD frontend_attach

2012-01-10 Thread Jiri Slaby
This means cut paste from the former f. attach. But while at it write to the right GPIO to turn on the right LED. Also turn the other two off jsut for sure. Signed-off-by: Jiri Slaby jsl...@suse.cz --- drivers/media/dvb/dvb-usb/dib0700_devices.c | 36 +- 1 files

[PATCH 1/4] DVB: dib0700, move Nova-TD Stick to a separate set

2012-01-10 Thread Jiri Slaby
To properly support the three LEDs which are on the stick, we need a special handling in the -frontend_attach function. Thus let's have a separate -frontend_attach instead of ifs in the common one. The hadnling itself will be added in further patches. Signed-off-by: Jiri Slaby jsl...@suse.cz

[PATCH 2/5] MEDIA: ttusbir, fix double free

2013-04-04 Thread Jiri Slaby
-by: Jiri Slaby jsl...@suse.cz Cc: Sean Young s...@mess.org Cc: Mauro Carvalho Chehab mche...@redhat.com Cc: linux-media@vger.kernel.org --- drivers/media/rc/ttusbir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/rc/ttusbir.c b/drivers/media/rc/ttusbir.c index cf0d47f..891762d 100644

[PATCH dvb-utils] proper dvb-t scan data for Czech Republic

2012-06-26 Thread Jiri Slaby
BTW I would appreciate if you move also dvb-utils to GIT. hg wastes our time. -- js suse labs # HG changeset patch # User Jiri Slaby jirisl...@gmail.com # Date 1340742534 -7200 # Node ID 96025655e6e844af2bc69bd368f8d04a4e5bc58b # Parent 4030c51d6e7baef760e65d4ff2e8f61af91bec02 proper dvb-t scan

[PATCH -resend] DVB: dib0700, remove double \n's from log

2012-07-30 Thread Jiri Slaby
err() already adds \n to the end of the format string. So remove one more \n from formatting strings in the dib0700 driver. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: Michael Krufky mkru...@linuxtv.org --- drivers/media/dvb/dvb-usb/dib0700_core.c

dvb-tools: scan_data/cz-all: 4th multiplex has FEC 3/4

2012-12-06 Thread Jiri Slaby
-- js # HG changeset patch # User Jiri Slaby jirisl...@gmail.com # Date 1354786687 -3600 # Node ID c72238053530a0ad8e446af2cce0cb8d14c9640a # Parent 96025655e6e844af2bc69bd368f8d04a4e5bc58b scan_data/cz-all: 4th multiplex has FEC 3/4 Not 2/3. This I inappropriatelly got from the website

[PATCH] dib0700: do not lock interruptible on tear-down paths

2013-01-03 Thread Jiri Slaby
is not properly stopped in that case. And the device stops working from that moment on. Signed-off-by: Jiri Slaby jsl...@suse.cz --- drivers/media/usb/dvb-usb/dib0700_core.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/media/usb/dvb-usb/dib0700_core.c b/drivers/media

Re: [RFC] Initial scan files troubles and brainstorming

2013-01-07 Thread Jiri Slaby
On 12/18/2012 11:01 PM, Oliver Schinagl wrote: Unfortunatly, I have had zero replies. Hmm, it's sad there is a silence in this thread from linux-media guys :/. So why bring it up again? On 2012/11/30 Jakub Kasprzycki provided us with updated polish DVB-T frequencies for his region. This has

kaffeine.kde.org/scanfile.dvb.qz is obsolete [was: [RFC] Initial scan files troubles and brainstorming]

2013-01-09 Thread Jiri Slaby
On 01/09/2013 03:41 PM, Mauro Carvalho Chehab wrote: Christoph, Thank you for all the hard work over all those years! Yeah, I second this. I have a note though. Who is going to fix the URL in kaffeine? And how often is kaffeine.kde.org/scanfile.dvb.qz updated? Is this done automatically? As

Re: [RFC] Initial scan files troubles and brainstorming

2013-01-10 Thread Jiri Slaby
+0100 Oliver Schinagl oliver+l...@schinagl.nl escreveu: On 08-01-13 21:01, Johannes Stezenbach wrote: On Mon, Jan 07, 2013 at 01:48:29PM +0100, Oliver Schinagl wrote: On 07-01-13 11:46, Jiri Slaby wrote: On 12/18/2012 11:01 PM, Oliver Schinagl wrote: Unfortunatly, I have had zero replies

Re: [RFC] Initial scan files troubles and brainstorming

2013-01-10 Thread Jiri Slaby
On 01/10/2013 07:46 PM, Manu Abraham wrote: The scan files and config files are very specific to dvb-apps, some applications do rely on these config files. It doesn't really make sense to have split out config files for these small applications. I don't care where they are, really. However

Re: [RFC] Initial scan files troubles and brainstorming

2013-01-10 Thread Jiri Slaby
On 01/10/2013 07:56 PM, Michael Krufky wrote: I see great value in separating the history of the data files from the code files. If you really think this is such a terrible task for a developer to have to pull from a second repository to fetch these data files, then I find no reason why we

Re: [RFC] Initial scan files troubles and brainstorming

2013-01-10 Thread Jiri Slaby
On 01/10/2013 08:08 PM, Manu Abraham wrote: On 1/11/13, Jiri Slaby jirisl...@gmail.com wrote: On 01/10/2013 07:46 PM, Manu Abraham wrote: The scan files and config files are very specific to dvb-apps, some applications do rely on these config files. It doesn't really make sense to have split

Re: [RFC] Initial scan files troubles and brainstorming

2013-01-10 Thread Jiri Slaby
On 01/10/2013 09:25 PM, Manu Abraham wrote: Also, purely out of curiousity, how are the scanfiles used during development? The scanfiles what you call them are the configuration files for dvb-apps, rather than purely data files. But you cannot change their format, so what's the point? You

Re: [RFC] Initial scan files troubles and brainstorming

2013-01-10 Thread Jiri Slaby
On 01/10/2013 09:38 PM, Manu Abraham wrote: The format can be definitely changed. There's no issue to it. No you cannot. Applications depend on that, it's part of the dvb ABI. If you changed that, you would do the same mistake as Mauro let it flowing through his tree and it was pointed out by

Re: [RFC] Initial scan files troubles and brainstorming

2013-01-10 Thread Jiri Slaby
On 01/10/2013 09:41 PM, Jiri Slaby wrote: On 01/10/2013 09:38 PM, Manu Abraham wrote: The format can be definitely changed. There's no issue to it. No you cannot. Applications depend on that, it's part of the dvb ABI. If you changed that, you would do the same mistake as Mauro let it flowing

Re: [RFC] Initial scan files troubles and brainstorming

2013-01-10 Thread Jiri Slaby
On 01/10/2013 09:49 PM, Manu Abraham wrote: On 1/11/13, Jiri Slaby jirisl...@gmail.com wrote: On 01/10/2013 09:38 PM, Manu Abraham wrote: The format can be definitely changed. There's no issue to it. No you cannot. Applications depend on that, it's part of the dvb ABI. If you changed

Re: [RFC] Initial scan files troubles and brainstorming

2013-01-11 Thread Jiri Slaby
On 01/11/2013 01:39 PM, Mauro Carvalho Chehab wrote: tgz: git archive --format tgz HEAD dtv-scan-files-`date +%Y%m%d.%H:%M`.tar.gz Better to use the top commit date: git log -n1 --date=short --pretty=format:%ad You won't generate a snapshot every day with the same contents then. or

Re: [PATCH 1/2] media: video/tuner-core, fix memory leak

2010-01-06 Thread Jiri Slaby
On 01/06/2010 05:47 PM, Jiri Slaby wrote: Stanse found a memory leak in tuner_probe. t is not freed/assigned on all paths. Fix that. Oops. I generated two patches here, only the second is for PCI. Sorry Mauro, you got this one twice. -- js -- To unsubscribe from this list: send the line

[PATCH 1/2] media: dvb/siano, fix memory leak

2010-01-06 Thread Jiri Slaby
Stanse found a memory leak in smscore_gpio_configure. buffer is not freed/assigned on all paths. Fix that. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: linux-media@vger.kernel.org --- drivers/media/dvb/siano/smscoreapi.c |7 +-- 1 files

[PATCH 2/2] media: video/tuner-core, fix memory leak

2010-01-06 Thread Jiri Slaby
Stanse found a memory leak in tuner_probe. t is not freed/assigned on all paths. Fix that. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: linux-media@vger.kernel.org --- drivers/media/video/tuner-core.c |1 + 1 files changed, 1 insertions(+), 0

[PATCH 1/2] media: video/tuner-core, fix memory leak

2010-01-06 Thread Jiri Slaby
Stanse found a memory leak in tuner_probe. t is not freed/assigned on all paths. Fix that. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Mauro Carvalho Chehab mche...@infradead.org Cc: linux-media@vger.kernel.org --- drivers/media/video/tuner-core.c |1 + 1 files changed, 1 insertions(+), 0

[PATCH 1/1] media: video/cx18, fix potential null dereference

2010-01-10 Thread Jiri Slaby
Stanse found a potential null dereference in cx18_dvb_start_feed and cx18_dvb_stop_feed. There is a check for stream being NULL, but it is dereferenced earlier. Move the dereference after the check. Signed-off-by: Jiri Slaby jsl...@suse.cz --- drivers/media/video/cx18/cx18-dvb.c | 18

[PATCH 1/1] MAINTAINERS: ivtv-devel is moderated

2010-01-10 Thread Jiri Slaby
Mark ivtv-de...@ivtvdriver.org as 'moderated for non-subscribers'. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: linux-media@vger.kernel.org --- MAINTAINERS |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index d4baf3d..6f088ac 100644

Re: [PATCH 1/1] media: video/cx18, fix potential null dereference

2010-01-12 Thread Jiri Slaby
On 01/12/2010 12:48 AM, Andy Walls wrote: On Sun, 2010-01-10 at 09:56 +0100, Jiri Slaby wrote: Stanse found a potential null dereference in cx18_dvb_start_feed and cx18_dvb_stop_feed. There is a check for stream being NULL, but it is dereferenced earlier. Move the dereference after the check

Re: [PATCH 1/1] media: video/cx18, fix potential null dereference

2010-01-13 Thread Jiri Slaby
On 01/13/2010 12:32 PM, Andy Walls wrote: If you don't mind a delay of until Sunday or so to get the patch applied to the V4L-DVB tree, I can take the patch and work it in my normal path through Mauro. Let me know. I have no problem with that. thanks, -- js -- To unsubscribe from this list:

[PATCH 1/1] HID: ignore afatech 9016

2010-01-13 Thread Jiri Slaby
as well. With input going through dvb-usb-remote, the remote works perfectly. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Jiri Kosina jkos...@suse.cz --- drivers/hid/usbhid/hid-core.c |8 drivers/hid/usbhid/hid-quirks.c |2 +- include/linux/hid.h |1 - 3 files

[PATCH 1/1] media: dvb-usb/af9015, add IR support for digivox mini II

2010-01-13 Thread Jiri Slaby
MSI digivox mini II works even with remote=2 module parameter. Check for manufacturer and if it is Afatech, use af9015_ir_table_msi and af9015_rc_keys_msi. The device itself is 15a4:9016. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Antti Palosaari cr...@iki.fi Cc: Mauro Carvalho Chehab mche

Re: [PATCH 1/1] HID: ignore afatech 9016

2010-01-13 Thread Jiri Slaby
On 01/13/2010 09:20 PM, Jiri Kosina wrote: diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c index 38773dc..788d9a3 100644 --- a/drivers/hid/usbhid/hid-quirks.c +++ b/drivers/hid/usbhid/hid-quirks.c @@ -41,7 +41,7 @@ static const struct hid_blacklist { {

[PATCH v2 1/1] HID: ignore afatech 9016

2010-01-13 Thread Jiri Slaby
the quirk as well. With input going through dvb-usb-remote, the remote works perfectly. The device is 15a4:9016. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Jiri Kosina jkos...@suse.cz Cc: Pekka Sarnila sarn...@adit.fi --- drivers/hid/hid-core.c |1 + drivers/hid/usbhid/hid-core.c |8

[PATCH 1/1] media: dvb-usb/af9015, fix disconnection crashes

2010-01-20 Thread Jiri Slaby
] dvb_usb_device_exit+0x39/0x60 [dvb_usb] RSP 88018066bd48 CR2: 000700c5 ---[ end trace f25ee66d2135f162 ]--- Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Antti Palosaari cr...@iki.fi Cc: Mauro Carvalho Chehab mche...@redhat.com Cc: linux-media@vger.kernel.org --- drivers/media/dvb/dvb-usb

[PATCH 4/4] media: dvb/af9015, add hashes support

2010-01-22 Thread Jiri Slaby
So as a final patch, add support for hash and one hash entry for MSI digi vox mini II: iManufacturer 1 Afatech iProduct 2 DVB-T 2 iSerial 3 01010101061 It is now handled with proper IR and key map tables. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Antti Palosaari cr...@iki.fi Cc

[PATCH 2/4] media: dvb/af9015, factor out remote setting

2010-01-22 Thread Jiri Slaby
This is just a code shuffle without functional changes. For easier review of later changes, i.e. preparation. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Antti Palosaari cr...@iki.fi Cc: Mauro Carvalho Chehab mche...@redhat.com Cc: linux-media@vger.kernel.org --- drivers/media/dvb/dvb-usb

[PATCH 3/4] media: dvb/af9015, refactor remote setting

2010-01-22 Thread Jiri Slaby
into and matched against tables. Hashes will follow. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Antti Palosaari cr...@iki.fi Cc: Mauro Carvalho Chehab mche...@redhat.com Cc: linux-media@vger.kernel.org --- drivers/media/dvb/dvb-usb/af9015.c | 222 ++- 1 files changed, 89

Re: [PATCH 1/1] media: dvb-usb/af9015, add IR support for digivox mini II

2010-01-22 Thread Jiri Slaby
On 01/14/2010 08:09 PM, Antti Palosaari wrote: Device ID 15a4:9016 is reference design ID and it is used by vary many devices. Also manufacturer string Afatech is chipset default one. This leads MSI remote in question configured for many devices using default / reference values which I don't

[PATCH 1/4] media: dvb/af9015, implement eeprom hashing

2010-01-22 Thread Jiri Slaby
is moved earlier to the flow, namely from af9015_af9013_frontend_attach to af9015_read_config, so that we can access the sum in af9015_read_config already. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Antti Palosaari cr...@iki.fi Cc: Mauro Carvalho Chehab mche...@redhat.com Cc: linux-media

Re: [PATCH 1/4] media: dvb/af9015, implement eeprom hashing

2010-01-24 Thread Jiri Slaby
On 01/24/2010 05:16 PM, Antti Palosaari wrote: +af9015_config.eeprom_sum = 0; +for (reg = 0; reg eeprom_size / sizeof(u32); reg++) { +af9015_config.eeprom_sum *= GOLDEN_RATIO_PRIME_32; +af9015_config.eeprom_sum += le32_to_cpu(((u32 *)eeprom)[reg]); +} + +

Re: [PATCH 1/1] media: dvb-usb/af9015, fix disconnection crashes

2010-01-25 Thread Jiri Slaby
On 01/25/2010 12:44 AM, Antti Palosaari wrote: When I now test this patch with debugs enabled I don't see .probe and .disconnect be called for this HID interface (interface 1) at all and thus checks not needed. What happens if you disable the HID layer? Or at least if you add an ignore quirk

dvb-usb-remote woes [was: HID: ignore afatech 9016]

2010-02-01 Thread Jiri Slaby
On 02/01/2010 07:28 PM, Jiri Kosina wrote: On Mon, 1 Feb 2010, Pekka Sarnila wrote: Well short answer is: No, it does not work. Hi, thanks for the input. What I did: I pulled few days ago latest git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git and compiled it.

Re: dvb-usb-remote woes [was: HID: ignore afatech 9016]

2010-02-01 Thread Jiri Slaby
On 02/01/2010 10:23 PM, Antti Palosaari wrote: On 02/01/2010 09:42 PM, Jiri Slaby wrote: On 02/01/2010 07:28 PM, Jiri Kosina wrote: On Mon, 1 Feb 2010, Pekka Sarnila wrote: 3af9015: command failed:255 3dvb-usb: error while querying for an remote control event. Yes, I saw this quite

Re: [PATCH 1/1] media: dvb-usb/af9015, fix disconnection crashes

2010-02-04 Thread Jiri Slaby
) }, { HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_S510_RECEIVER_2) }, diff --git a/drivers/hid/hid-dvb.c b/drivers/hid/hid-dvb.c new file mode 100644 index 000..ee94c07 --- /dev/null +++ b/drivers/hid/hid-dvb.c @@ -0,0 +1,78 @@ +/* + * HID driver for dvb devices + * + * Copyright (c) 2010 Jiri Slaby

Re: [PATCH 1/1] media: dvb-usb/af9015, fix disconnection crashes

2010-02-04 Thread Jiri Slaby
On 02/04/2010 01:04 PM, Mauro Carvalho Chehab wrote: I have 2 dvb-t receivers and both of them need fullspeed quirk. Further disable_rc_polling (a dvb_usb module parameter) must be set to not get doubled characters now. And then, it works like a charm. Module parameters always bothers me.

Re: [PATCH 1/1] media: dvb-usb/af9015, fix disconnection crashes

2010-02-04 Thread Jiri Slaby
On 02/04/2010 02:41 PM, Mauro Carvalho Chehab wrote: The point is that it is better to name the function right since the beginning. Sorry, I misunderstood you for the first time. It's .event member of hid_driver. Hence I named it dvb_event (or now rc_event or whatever). The function may contain

Re: [PATCH 1/1] media: dvb-usb/af9015, fix disconnection crashes

2010-02-04 Thread Jiri Slaby
On 02/04/2010 07:14 PM, Dmitry Torokhov wrote: On Thu, Feb 04, 2010 at 11:31:45AM +0100, Jiri Slaby wrote: + +static int dvb_event(struct hid_device *hdev, struct hid_field *field, +struct hid_usage *usage, __s32 value) +{ +/* we won't get a key up event */ +if (value

[PATCH 1/1] DVB: ngene, fix memset parameters

2010-02-10 Thread Jiri Slaby
Switch second and third memset parameter to stamp the length buffer bytes by 0xff's, not 255 bytes by low 8 bits of Length. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Matthias Benesch two...@freenet.de Cc: Ralph Metzler r...@metzlerbros.de Cc: Oliver Endriss o.endr...@gmx.de Cc: Mauro Carvalho

[PATCH] V4L: dvb-usb, add extra sync to down-up input events

2010-02-14 Thread Jiri Slaby
Userspace is allowed to coalesce events between SYNCs. And since the code emits UP right after DOWN for the same key, it may be missed (up+down=nothing). Add an extra sync in between UP and DOWN events to disable the coalesce. Signed-off-by: Jiri Slaby jsl...@suse.cz Cc: Dmitry Torokhov d

[PATCH repost 1/4] V4L: radio-si470x, fix lock imbalance

2009-07-03 Thread Jiri Slaby
There is one path with omitted unlock in si470x_fops_release. Fix that. Signed-off-by: Jiri Slaby jirisl...@gmail.com --- drivers/media/radio/radio-si470x.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/radio/radio-si470x.c b/drivers/media/radio

[PATCH repost 2/4] V4L: em28xx, fix lock imbalance

2009-07-03 Thread Jiri Slaby
There is one omitted unlock in em28xx_usb_probe. Fix that. Signed-off-by: Jiri Slaby jirisl...@gmail.com --- drivers/media/video/em28xx/em28xx-cards.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/em28xx/em28xx-cards.c b/drivers/media/video/em28xx

[PATCH repost 3/4] V4L: hdpvr, fix lock imbalances

2009-07-03 Thread Jiri Slaby
There are many lock imbalances in this driver. Fix all found. Signed-off-by: Jiri Slaby jirisl...@gmail.com --- drivers/media/video/hdpvr/hdpvr-core.c | 12 ++-- drivers/media/video/hdpvr/hdpvr-video.c |6 -- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git

[PATCH repost 4/4] V4L: saa7134, fix lock imbalance

2009-07-03 Thread Jiri Slaby
There seems to be one superfluos unlock in a poll function. Remove it. Signed-off-by: Jiri Slaby jirisl...@gmail.com --- drivers/media/video/saa7134/saa7134-video.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/saa7134/saa7134-video.c b/drivers

[PATCH repost2 1/2] V4L: hdpvr, fix lock imbalances

2009-07-30 Thread Jiri Slaby
Hrm, nobody picked these up, twice. Maybe this time :)? -- There are many lock imbalances in this driver. Fix all found. Signed-off-by: Jiri Slaby jirisl...@gmail.com --- drivers/media/video/hdpvr/hdpvr-core.c | 12 ++-- drivers/media/video/hdpvr/hdpvr-video.c |6 -- 2 files

Re: V4L2 drivers: potentially dangerous and inefficient msecs_to_jiffies() calculation

2009-09-14 Thread Jiri Slaby
On 09/14/2009 11:07 PM, Andreas Mohr wrote: ./drivers/media/video/zc0301/zc0301_core.c do cam-module_param.frame_timeout * 1000 * msecs_to_jiffies(1) ); multiple times each. What they should do instead is frame_timeout *

Re: V4L2 drivers: potentially dangerous and inefficient msecs_to_jiffies() calculation

2009-09-14 Thread Jiri Slaby
On 09/14/2009 11:39 PM, Andreas Mohr wrote: On Mon, Sep 14, 2009 at 11:34:40PM +0200, Jiri Slaby wrote: On 09/14/2009 11:07 PM, Andreas Mohr wrote: msecs_to_jiffies(1) is quite a bit too boldly assuming that all of the msecs_to_jiffies(x) implementation branches always round up. They do

AF9035 with no tuner?

2015-12-12 Thread Jiri Slaby
Hello, I have a USB device which digitizes composite video into a MPEG-2 stream (I think). It is an AF9035 device according to windows. But it has no tuner. Is there a way to make it working on linux or am I out of luck? lsusb -v: Bus 001 Device 016: ID 1d19:6105 Dexatek Technology Ltd. Video

Re: AF9035 with no tuner?

2015-12-12 Thread Jiri Slaby
On 12/12/2015, 10:12 PM, Benjamin Larsson wrote: > On 12/12/2015 10:08 PM, Jiri Slaby wrote: >> Hello, >> >> I have a USB device which digitizes composite video into a MPEG-2 stream >> (I think). It is an AF9035 device according to windows. But it has no >> tuner.

Re: [PATCH v3] Add tw5864 driver

2016-07-11 Thread Jiri Slaby
On 07/11/2016, 07:58 AM, Hans Verkuil wrote: >> +static char *artifacts_warning = "BEWARE OF KNOWN ISSUES WITH VIDEO >> QUALITY\n" > > const char * const Or even better, drop the extra space for pointer: static const char artifacts_warning[] = thanks, -- js suse labs -- To unsubscribe from

[PATCH] media: radio-cadet, initialize timer with setup_timer

2017-01-23 Thread Jiri Slaby
; Signed-off-by: Jiri Slaby <jsl...@suse.cz> Cc: Hans Verkuil <hverk...@xs4all.nl> Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: <linux-media@vger.kernel.org> --- drivers/media/radio/radio-cadet.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/