Re: [PATCH 4/4] drivers/media/video: Remove dead CONFIG_OLPC_X0_1

2010-07-19 Thread Jonathan Corbet
On Wed, 14 Jul 2010 15:21:48 +0200 Christian Dietrich qy03f...@stud.informatik.uni-erlangen.de wrote: CONFIG_OLPC_X0_1 doesn't exist in Kconfig and is never defined anywhere else, therefore removing all references for it from the source code. That symbol is, needless to say, an OLPC thing;

Re: [PATCHv2 2/4] mm: cma: Contiguous Memory Allocator added

2010-07-27 Thread Jonathan Corbet
On Tue, 27 Jul 2010 14:45:58 +0200 Marek Szyprowski m.szyprow...@samsung.com wrote: How does one obtain the CPU address of this memory in order for the CPU to access it? Right, we did not cover such case. In CMA approach we tried to separate memory allocation from the memory mapping

Re: [PATCH 1/4] cafe_ccic: Fix hang in command write processing

2010-09-25 Thread Jonathan Corbet
On Fri, 24 Sep 2010 18:17:17 +0100 (BST) Daniel Drake d...@laptop.org wrote: This patch, which basically reverts 6d77444ac, fixes an occasional on-boot or on-capture hang on the XO-1 laptop. It seems like the cafe hardware is flakier than we thought and that in some cases, the commands get

Re: [PATCH 1/3] ov7670: remove QCIF mode

2010-10-08 Thread Jonathan Corbet
On Fri, 8 Oct 2010 22:04:12 +0100 (BST) Daniel Drake d...@laptop.org wrote: This super-low-resolution mode only captures from a small portion of the sensor FOV, making it a bit useless. I'm certainly not attached to this mode, but...does it harm anybody if it's there? ov7670 sensors appear

Re: [PATCH 2/3] ov7670: disable QVGA mode

2010-10-08 Thread Jonathan Corbet
On Fri, 8 Oct 2010 22:04:18 +0100 (BST) Daniel Drake d...@laptop.org wrote: Capturing at this resolution results in an ugly green horizontal line at the left side of the image. Disable until fixed. A problem like that will be at the controller level, not the sensor level. Given that this is

Re: [PATCH 3/3] ov7670: Support customization of clock speed

2010-10-08 Thread Jonathan Corbet
might have set through the DMI table. This certainly seems better than my hack. Acked-by: Jonathan Corbet cor...@lwn.net jon -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

[PATCH] viafb camera controller driver

2010-10-10 Thread Jonathan Corbet
Pinchart for a number of useful comments. Cc: Florian Tobias Schandinat florianschandi...@gmx.de Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/Kconfig | 10 + drivers/media/video/Makefile |2 + drivers/media/video/via-camera.c | 1406

Re: [PATCH] viafb camera controller driver

2010-10-11 Thread Jonathan Corbet
On Mon, 11 Oct 2010 14:18:55 +0200 Laurent Pinchart laurent.pinch...@ideasonboard.com wrote: +static __devexit int viacam_remove(struct platform_device *pdev) +{ + struct via_camera *cam = via_cam_info; And use it here. Just call platform_set_drvdata(pdev, cam) in viacam_probe to

Re: [PATCH] viafb camera controller driver

2010-10-18 Thread Jonathan Corbet
On Sat, 16 Oct 2010 10:44:56 -0300 Mauro Carvalho Chehab mche...@infradead.org wrote: Hmm... do you need BKL? Otherwise, you should be using, instead, .unlocked_ioctl. No, that was just silly. Btw, the driver build is broken: And that, it seems, indicates that I'm making my patch against

Re: [PATCH] viafb camera controller driver

2010-10-18 Thread Jonathan Corbet
On Sat, 16 Oct 2010 10:44:56 -0300 Mauro Carvalho Chehab mche...@infradead.org wrote: drivers/media/video/via-camera.c: In function ‘viacam_open’: drivers/media/video/via-camera.c:651: error: too few arguments to function ‘videobuf_queue_sg_init’ The fix for this one is trivial:

Re: [PATCH] ov7670: fix QVGA visible area

2010-10-19 Thread Jonathan Corbet
! Acked-by: Jonathan Corbet cor...@lwn.net jon -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] V4L/DVB: Add the via framebuffer camera controller driver

2010-10-19 Thread Jonathan Corbet
. This work was supported by the One Laptop Per Child project. Thanks to Laurent Pinchart for a number of useful comments. Cc: Florian Tobias Schandinat florianschandi...@gmx.de Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/Kconfig | 10 + drivers/media/video/Makefile

Re: ext_lock (was viafb camera controller driver)

2010-10-20 Thread Jonathan Corbet
On Tue, 19 Oct 2010 08:54:40 +0200 Hans Verkuil hverk...@xs4all.nl wrote: We are working on removing the BKL. As part of that effort it is now possible for drivers to pass a serialization mutex to the v4l core (a mutex pointer was added to struct video_device). If the core sees that mutex then

Re: [PATCH 1/2] ov7670: allow configuration of image size, clock speed, and I/O method

2010-10-21 Thread Jonathan Corbet
On Tue, 19 Oct 2010 22:24:05 +0100 (BST) Daniel Drake d...@laptop.org wrote: These parameters need to be configurable based on the host system. They can now be communicated through the s_config call. The old CONFIG_OLPC_XO_1 selector was not correct; this kind of arrangement wouldn't allow

Re: V4L/DVB/IR patches pending merge

2010-10-23 Thread Jonathan Corbet
On Sat, 23 Oct 2010 02:06:56 -0200 Mauro Carvalho Chehab mche...@redhat.com wrote: in the case of the first patch, I'm not sure if you acked or nacked it. I suspect that you ack ;) You didn't comment the second one (or maybe I just missed your email). Are both ok for you? Yes, I'm sorry, I

Re: [PATCH] cafe_ccic: fix colorspace corruption on resume

2010-10-28 Thread Jonathan Corbet
On Wed, 27 Oct 2010 14:55:00 +0100 (BST) Daniel Drake d...@laptop.org wrote: Only power down during resume if the camera is not in use, and correctly reconfigure the sensor during resume. Makes sense to me. Acked-by: Jonathan Corbet cor...@lwn.net jon -- To unsubscribe from this list: send

Re: [PATCH] via-camera: fix OLPC serial port check

2010-10-28 Thread Jonathan Corbet
around with the PCI config space on XO-1. This makes every user carry a bit of OLPC-specific code. But there are no non-OLPC users currently, the code is small, and we get rid of some #ifdefs, which is always a good thing. Seems good to me. Acked-by: Jonathan Corbet cor...@lwn.net jon

Re: [PATCH] via-camera: fix OLPC serial port check

2010-10-28 Thread Jonathan Corbet
On Thu, 28 Oct 2010 20:14:35 +0100 Daniel Drake d...@laptop.org wrote: I think the compiler might be smart enough to optimize it out. When CONFIG_OLPC=n, machine_is_olpc() compiles down to a simple no. Hopefully that then makes all of that code candidate for dead code elimination by the

Re: cafe_ccic: can ioctl be replaced by unlocked_ioctl?

2010-11-14 Thread Jonathan Corbet
On Sun, 14 Nov 2010 14:44:52 +0100 Hans Verkuil hverk...@xs4all.nl wrote: Unless you have any objections I'd like to replace .ioctl by .unlocked_ioctl in this driver. No objections, it should have been that way from the beginning. In fact, I thought it *was* that way...oh well, better late

An article on the media controller

2010-11-16 Thread Jonathan Corbet
I've just spent a fair while looking through the September posting of the media controller code (is there a more recent version?). The result is a high-level review which interested people can read here: http://lwn.net/SubscriberLink/415714/1e837f01b8579eb7/ Most people will not see it

Re: [RFC/PATCH v5 01/12] media: Media device node support

2010-11-16 Thread Jonathan Corbet
Here's the first of my more specific comments - probably the only file I'll get to today... The media_devnode structure provides support for registering and unregistering character devices using a dynamic major number. Reference counting is handled internally, making device drivers easier to

Re: [PATCH] media: vb2: dma-sg allocator: change scatterlist allocation method

2011-08-16 Thread Jonathan Corbet
On Tue, 16 Aug 2011 12:34:56 +0200 Marek Szyprowski m.szyprow...@samsung.com wrote: Right, I wasn't aware of that, but it still doesn't look like an issue. The only client of dma-sg allocator is marvell-ccic, which is used on x86 systems. If one needs dma-sg allocator on ARM, he should

Re: [PATCH v2/RFC] media: vb2: change queue initialization order

2011-08-25 Thread Jonathan Corbet
On Thu, 25 Aug 2011 12:52:11 +0200 Marek Szyprowski m.szyprow...@samsung.com wrote: This patch changes the order of operations during stream on call. Now the buffers are first queued to the driver and then the start_streaming method is called. This seems good to me (I guess it should, since

Re: [PATCH 1/2] videobuf2: Add a non-coherent contiguous DMA mode

2011-09-03 Thread Jonathan Corbet
On Sat, 03 Sep 2011 10:51:53 -0300 Mauro Carvalho Chehab mche...@redhat.com wrote: I'm understanding that I can just mark those two patches as RFC at patchwork and wait for your version two of those patchsets. So, I'll just remove those two from my pending queue and move on ;) That's the

Re: [PATCH] mmp_camera: add MODULE_ALIAS

2011-09-14 Thread Jonathan Corbet
On Wed, 7 Sep 2011 10:36:46 +0100 (BST) Daniel Drake d...@laptop.org wrote: This enables module autoloading. Signed-off-by: Daniel Drake d...@laptop.org No objections here, consider it acked. Mauro: as far as I'm concerned, Daniel can be considered a co-maintainer of the OLPC camera

Re: [PATCH V3] V4L/DVB: v4l: Add driver for Marvell PXA910 CCIC

2011-09-21 Thread Jonathan Corbet
On Wed, 21 Sep 2011 19:31:21 +0200 (CEST) Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: Indeed I would (mind);-) AFAIU, Jon has converted the cafe-ccic driver to be usable for other implementations, using the same core, this driver has to be converted to re-use the common code, and so

Re: [PATCH] via-camera: Add suspend/resume support

2011-02-11 Thread Jonathan Corbet
-by: Jonathan Corbet cor...@lwn.net jon -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] via-camera: Fix OLPC serial check

2011-03-10 Thread Jonathan Corbet
for anything. Did the check need to move for some reason? If so, a one-of-these-days nice feature might be to allow changing override_serial at run time. Regardless, the behavior change only affects OLPC folks using the serial line, so I'm OK with it. Acked-by: Jonathan Corbet cor...@lwn.net

Re: Patches still pending at linux-media queue (18 patches)

2011-05-05 Thread Jonathan Corbet
On Thu, 05 May 2011 00:58:51 -0300 Mauro Carvalho Chehab mche...@redhat.com wrote: Jon, One patch for your ack ;) Apr,29 2011: [media] via-camera: add MODULE_ALIAS http://patchwork.kernel.org/patch/742581 Daniel Drake d...@laptop.org Sorry...it's

Re: [PATCH V2] V4L/DVB: v4l: Add driver for Marvell PXA910 CCIC

2011-06-02 Thread Jonathan Corbet
On Wed, 1 Jun 2011 21:16:45 +0800 Kassey Lee y...@marvell.com wrote: This driver exports a video device node per each CCIC (CMOS Camera Interface Controller) device contained in Marvell Mobile PXA910 SoC The driver is based on soc-camera + videobuf2 frame work, and only USERPTR is

[RFC] Refactor the cafe_ccic driver and add Armada 610 support

2011-06-06 Thread Jonathan Corbet
Hello, all, As I promised last week, here's the state of my work refactoring the Cafe driver and adding Armada 610 support. I intend to have them ready for 3.1, but they are not ready for merging yet. There's a couple of things I'd like to clean up, and I'd like to let the OLPC people test

[PATCH 4/7] marvell-cam: Remove the untested comment

2011-06-06 Thread Jonathan Corbet
This code is, indeed, tested :) Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/marvell-ccic/cafe-driver.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/marvell-ccic/cafe-driver.c b/drivers/media/video/marvell-ccic/cafe

[PATCH 5/7] marvell-cam: Move Cafe-specific register definitions to cafe-driver.c

2011-06-06 Thread Jonathan Corbet
Nobody else ever needs to see these, so let's hide them. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/marvell-ccic/cafe-driver.c | 63 drivers/media/video/marvell-ccic/mcam-core.h | 56 +- 2 files changed, 64 insertions

[PATCH 3/7] marvell-cam: Pass sensor parameters from the platform

2011-06-06 Thread Jonathan Corbet
run anywhere else. Cc: Daniel Drake d...@laptop.org Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/marvell-ccic/cafe-driver.c |6 ++ drivers/media/video/marvell-ccic/mcam-core.c | 22 ++ drivers/media/video/marvell-ccic/mcam-core.h |3

[PATCH 6/7] marvell-cam: Right-shift i2c slave ID's in the cafe driver

2011-06-06 Thread Jonathan Corbet
This makes the cafe i2c implement consistent with the rest of Linux so that the core can use the same slave ID everywhere. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/marvell-ccic/cafe-driver.c |9 - drivers/media/video/marvell-ccic/mcam-core.c |2

[PATCH 7/7] marvell-cam: Basic working MMP camera driver

2011-06-06 Thread Jonathan Corbet
Now we have a camera working over the marvell cam controller core. It works like the cafe driver and has all the same limitations, contiguous DMA only being one of them. But it's a start. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/Makefile |1

Re: [RFC] Refactor the cafe_ccic driver and add Armada 610 support

2011-06-07 Thread Jonathan Corbet
On Tue, 7 Jun 2011 13:30:11 +0800 Kassey Lee kassey1...@gmail.com wrote: 1) this driver is still based on cafe_ccic.c, as you said, we can abstract the low level register function, and use soc_camera and videofbu2 to manage the buff and state machine, how do you think ? As I said,

Re: [PATCH 7/7] marvell-cam: Basic working MMP camera driver

2011-06-07 Thread Jonathan Corbet
On Tue, 7 Jun 2011 09:44:45 +0200 (CEST) Guennadi Liakhovetski g.liakhovet...@gmx.de wrote: +obj-$(CONFIG_VIDEO_MMP_CAMERA) += marvell-ccic/ Wouldn't it be better to have only one symbol, selecting the marvell-ccic directory in the Makefile and have all CAFE implementations select that

Re: [PATCH] V4L/DVB: v4l: Add driver for Marvell PXA910 CCIC

2011-06-09 Thread Jonathan Corbet
On Thu, 9 Jun 2011 16:46:47 +0800 Kassey Lee kassey1...@gmail.com wrote: As Jon will convert cafe_ccic.c to videobuf2 too, I wish He can review this driver too, if it is useful for him. and find the common ccic core. Just Mark it. I do plan to take a close look at the driver;

Re: [PATCH] V4L/DVB: v4l: Add driver for Marvell PXA910 CCIC

2011-06-09 Thread Jonathan Corbet
Hi, Kassey, I've been looking at the driver some to understand how you're using the hardware. One quick question: The driver is based on soc-camera + videobuf2 frame work, and only USERPTR is supported. Since you're limited to contiguous DMA (does the PXA910 even support scatter/gather

videobuf2 and VMAs

2011-06-09 Thread Jonathan Corbet
Hi, I'm finally getting around to trying to really understand videobuf2. In the process I've run into something which has thrown me for a bit of a loop... /** * vb2_get_vma() - acquire and lock the virtual memory area * @vma:given virtual memory area * * This function attempts to

[PATCH 1/8] marvell-cam: Move cafe-ccic into its own directory

2011-06-11 Thread Jonathan Corbet
This driver will soon become a family of drivers, so let's give it its own place to live. This move requires putting ov7670.h into include/media, but there are no code changes. Cc: Daniel Drake d...@laptop.org Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/Kconfig

Refactor cafe_ccic and add Armada 610 driver [V2]

2011-06-11 Thread Jonathan Corbet
like it was just more complication for no real benefit. If you feel strongly about it, though, I'll make the change. The changes in the series are: Jonathan Corbet (8): marvell-cam: Move cafe-ccic into its own directory marvell-cam: Separate out the Marvell camera core marvell

[PATCH 3/8] marvell-cam: Pass sensor parameters from the platform

2011-06-11 Thread Jonathan Corbet
run anywhere else. Cc: Daniel Drake d...@laptop.org Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/marvell-ccic/cafe-driver.c |6 ++ drivers/media/video/marvell-ccic/mcam-core.c | 22 ++ drivers/media/video/marvell-ccic/mcam-core.h |2

[PATCH 5/8] marvell-cam: Move Cafe-specific register definitions to cafe-driver.c

2011-06-11 Thread Jonathan Corbet
Nobody else ever needs to see these, so let's hide them. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/marvell-ccic/cafe-driver.c | 63 drivers/media/video/marvell-ccic/mcam-core.h | 56 +- 2 files changed, 64 insertions

[PATCH 4/8] marvell-cam: Remove the untested comment

2011-06-11 Thread Jonathan Corbet
This code is, indeed, tested :) Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/marvell-ccic/cafe-driver.c |3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/marvell-ccic/cafe-driver.c b/drivers/media/video/marvell-ccic/cafe

[PATCH 7/8] marvell-cam: Allocate the i2c adapter in the platform driver

2011-06-11 Thread Jonathan Corbet
The upcoming mmp-camera driver will need an i2c_adapter structure allocated externally, so change the core adapter to a pointer and require the platform code to fill it in. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/marvell-ccic/cafe-driver.c |9 +++-- drivers

[PATCH 8/8] marvell-cam: Basic working MMP camera driver

2011-06-11 Thread Jonathan Corbet
Now we have a camera working over the marvell cam controller core. It works like the cafe driver and has all the same limitations, contiguous DMA only being one of them. But it's a start. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/Makefile |1

[PATCH 6/8] marvell-cam: Right-shift i2c slave ID's in the cafe driver

2011-06-11 Thread Jonathan Corbet
This makes the cafe i2c implement consistent with the rest of Linux so that the core can use the same slave ID everywhere. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/marvell-ccic/cafe-driver.c |9 - drivers/media/video/marvell-ccic/mcam-core.c |2

Re: [PATCH 1/8] marvell-cam: Move cafe-ccic into its own directory

2011-06-14 Thread Jonathan Corbet
On Tue, 14 Jun 2011 10:23:58 +0800 Kassey Lee kassey1...@gmail.com wrote: Jon, Here is my comments. Thanks for having a look. +config VIDEO_CAFE_CCIC + tristate Marvell 88ALP01 (Cafe) CMOS Camera Controller support + depends on PCI I2C VIDEO_V4L2 + select

Re: [PATCH 2/8] marvell-cam: Separate out the Marvell camera core

2011-06-14 Thread Jonathan Corbet
On Tue, 14 Jun 2011 10:58:47 +0800 Kassey Lee kassey1...@gmail.com wrote: +#include linux/wait.h +#include linux/delay.h +#include linux/io.h + Would be good to sort headers alphabetically Um, I suppose. You're sure you don't want inverse Christmas-tree ordering? :) +static int

Re: [PATCH 8/8] marvell-cam: Basic working MMP camera driver

2011-06-16 Thread Jonathan Corbet
On Thu, 16 Jun 2011 10:37:37 +0800 Kassey Lee kassey1...@gmail.com wrote: +static void mmpcam_power_down(struct mcam_camera *mcam) +{ +       struct mmp_camera *cam = mcam_to_cam(mcam); +       struct mmp_camera_platform_data *pdata; +/* + * Turn off clocks and set reset lines + */

Re: [PATCH 2/8] marvell-cam: Separate out the Marvell camera core

2011-06-16 Thread Jonathan Corbet
On Thu, 16 Jun 2011 11:12:03 +0800 Kassey Lee kassey1...@gmail.com wrote: 2) for mcam_ctlr_stop_dma implementation, I guess you know something about the silicon limitation, but we found it can not pass our stress test(1000 times capture test, which will switch format between JPEG and

vb2: holding buffers until after start_streaming()

2011-06-17 Thread Jonathan Corbet
Here's another videobuf2 question...I've been trying to track down some weird behavior, the roots of which were in the fact that start_streaming() gets called even though no buffers have been queued. This behavior is quite explicit in the code: /* * Let driver notice that

Re: vb2: holding buffers until after start_streaming()

2011-06-20 Thread Jonathan Corbet
On Mon, 20 Jun 2011 07:30:11 +0200 Marek Szyprowski m.szyprow...@samsung.com wrote: Because of that I decided to call start_streaming first, before the __enqueue_in_driver() to ensure the drivers will get their methods called always in the same order, whatever used does. It still seems like

[RFC] Second marvell-cam patch series

2011-06-20 Thread Jonathan Corbet
. Somehow the gst-launch binary finds a way to use twice as much time processing frames. Given that the difference should not really even be visible to user space, I'm at a total loss here. In this series: Jonathan Corbet (5): marvell-cam: convert to videobuf2 marvell-cam: include file

[PATCH 5/5] marvell-cam: implement contiguous DMA operation

2011-06-20 Thread Jonathan Corbet
The core driver can now operate in either vmalloc or dma-contig modes; obviously the latter is preferable when it is supported. Default is currently vmalloc on all platforms; load the module with buffer_mode=1 for contiguous DMA mode. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers

[PATCH 4/5] marvell-cam: Don't spam the logs on frame loss

2011-06-20 Thread Jonathan Corbet
The sequence numbers already give that information if user space cares; this is a frequent occurrence on slower machines, alas. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/marvell-ccic/mcam-core.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git

[PATCH 3/5] marvell-cam: no need to initialize the DMA buffers

2011-06-20 Thread Jonathan Corbet
This was an old debugging thing from years ago. It's only done at initialization time, but it's still unnecessary; take it out. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/marvell-ccic/mcam-core.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git

[PATCH 2/5] marvell-cam: include file cleanup

2011-06-20 Thread Jonathan Corbet
Put the includes into a slightly more readable ordering and get rid of a few unneeded ones. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/marvell-ccic/mcam-core.c | 14 ++ 1 files changed, 6 insertions(+), 8 deletions(-) diff --git a/drivers/media/video

Re: vb2: holding buffers until after start_streaming()

2011-06-21 Thread Jonathan Corbet
On Tue, 21 Jun 2011 18:07:03 +0200 Marek Szyprowski m.szyprow...@samsung.com wrote: I have an idea to introduce a new flags to let device driver tell vb2 weather it supports 'streaming without buffers' or not. This way the order of operations in vb2_streamon() function can be switched and vb2

Re: vb2: holding buffers until after start_streaming()

2011-06-22 Thread Jonathan Corbet
On Wed, 22 Jun 2011 11:43:14 +0200 Marek Szyprowski m.szyprow...@samsung.com wrote: Do you really need a flag? If a driver absolutely cannot stream without buffers queued (and can't be fixed to start streaming for real when the buffers show up) it should just return -EINVAL from

Re: [PATCH 1/5] marvell-cam: convert to videobuf2

2011-06-22 Thread Jonathan Corbet
On Wed, 22 Jun 2011 15:59:04 +0200 Marek Szyprowski m.szyprow...@samsung.com wrote: This is a basic, naive conversion to the videobuf2 infrastructure, removing a lot of code in the process. For now, we're using vmalloc, which is suboptimal, but it does match what the cafe driver did

Re: [PATCH 2/8] marvell-cam: Separate out the Marvell camera core

2011-06-22 Thread Jonathan Corbet
[Sorry, I'm just now recovering from one of those total-loss-of-inbox-control episodes...] On Fri, 17 Jun 2011 11:11:33 +0800 Kassey Lee kassey1...@gmail.com wrote: the problem is: when we stop CCIC, and then switch to another format. at this stage, actually, CCIC DMA is not

[RFC] vb2: Push buffer allocation and freeing into drivers

2011-06-24 Thread Jonathan Corbet
I could, and run tested with vivi and mmp-camera. The patch is against linuxtv/for_v3.1, so it doesn't include the mmp-camera hunks (since videobuf2 support for that driver isn't upstream yet.) Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/mem2mem_testdev.c | 20

The return value of __vb2_queue_alloc()

2011-06-24 Thread Jonathan Corbet
On Fri, 24 Jun 2011 14:19:27 -0600 Jonathan Corbet cor...@lwn.net wrote: Here's a little something I decided to hack on rather than addressing all the real work I have to do. ...and while I was looking at this code, I noticed one little curious thing: int vb2_reqbufs(struct vb2_queue *q

Re: [RFC] vb2: Push buffer allocation and freeing into drivers

2011-06-27 Thread Jonathan Corbet
On Mon, 27 Jun 2011 18:09:41 +0200 Marek Szyprowski m.szyprow...@samsung.com wrote: Thanks for your work! I really appreciate your effort for making the kernel code better. :) However I would like to get some more comments before making the final decision. That's fine - it *was* an RFC, after

Re: [PATCH/RFC] media: vb2: change queue initialization order

2011-06-29 Thread Jonathan Corbet
On Wed, 29 Jun 2011 11:49:06 +0200 Marek Szyprowski m.szyprow...@samsung.com wrote: This patch introduces VB2_STREAMON_WITHOUT_BUFFERS io flag and changes the order of operations during stream on operation. Now the buffer are first queued to the driver and then the start_streaming method is

[PATCH] Third marvell-cam patch series

2011-06-30 Thread Jonathan Corbet
Another week, another series of Marvell cam patches. It's a short series this time: Jonathan Corbet (2): marvell-cam: Working s/g DMA marvell-cam: use S/G DMA by default Kconfig |3 mcam-core.c | 289 ++- mcam

[PATCH 2/2] marvell-cam: use S/G DMA by default

2011-06-30 Thread Jonathan Corbet
Scatter/gather DMA mode works nicely on this platform and is clearly the best way of doing things. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/marvell-ccic/mmp-driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/marvell

[PATCH 1/2] marvell-cam: Working s/g DMA

2011-06-30 Thread Jonathan Corbet
The core Marvell camera driver can now do scatter/gather DMA on controllers which support that functionality. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/marvell-ccic/Kconfig |3 + drivers/media/video/marvell-ccic/mcam-core.c | 289

Re: [PATCH/RFC] media: vb2: change queue initialization order

2011-06-30 Thread Jonathan Corbet
On Wed, 29 Jun 2011 16:10:45 +0200 Marek Szyprowski m.szyprow...@samsung.com wrote: I do still wonder why this is an issue - why not pass the buffers through to the driver at VIDIOC_QBUF time? I assume there must be a reason for doing things this way, I'd like to understand what it is.

Re: Missing 'select VIDEOBUF2_DMA_CONTIG'

2011-07-02 Thread Jonathan Corbet
On Sat, 2 Jul 2011 11:16:44 +0200 Hans Verkuil hverk...@xs4all.nl wrote: I think this is missing: diff --git a/drivers/media/video/marvell-ccic/Kconfig b/drivers/media/video/marvell-ccic/Kconfig index 22314a0..68ff5d6 100644 --- a/drivers/media/video/marvell-ccic/Kconfig +++

Re: [PATCH] viacam: Don't explode if pci_find_bus() returns NULL

2011-07-05 Thread Jonathan Corbet
unlikely - that function is only called on a single architecture where the bus is known to exist. Still, no harm can come from checking. Acked-by: Jonathan Corbet cor...@lwn.net Thanks, jon -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

Re: [RFC PATCH] poll: add poll_requested_events() function

2011-07-07 Thread Jonathan Corbet
On Fri, 1 Jul 2011 15:37:30 +0200 Hans Verkuil hverk...@xs4all.nl wrote: In some cases the poll() implementation in a driver has to do different things depending on the events the caller wants to poll for. An example is when a driver needs to start a DMA engine if the caller polls for POLLIN,

[PATCH] One more Marvell cam patch series

2011-07-08 Thread Jonathan Corbet
be pulled from: git://git.lwn.net/linux-2.6.git for-mauro Patches in this series: Jonathan Corbet (6): marvell-cam: delete struct mcam_sio_buffer marvell-cam: core code reorganization marvell-cam: remove {min,max}_buffers parameters marvell-cam: power down mmp camera

[PATCH 3/6] marvell-cam: remove {min,max}_buffers parameters

2011-07-08 Thread Jonathan Corbet
Somewhere along the way the code stopped actually paying any attention to them, and I doubt anybody has ever made use of them. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/marvell-ccic/mcam-core.c | 13 - 1 files changed, 0 insertions(+), 13 deletions

[PATCH 4/6] marvell-cam: power down mmp camera on registration failure

2011-07-08 Thread Jonathan Corbet
If registration does not work, we don't want to leave the sensor powered on. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/marvell-ccic/mmp-driver.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/marvell-ccic/mmp-driver.c b

[PATCH 2/6] marvell-cam: core code reorganization

2011-07-08 Thread Jonathan Corbet
: no functional changes here. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/marvell-ccic/mcam-core.c | 914 +- 1 files changed, 465 insertions(+), 449 deletions(-) diff --git a/drivers/media/video/marvell-ccic/mcam-core.c b/drivers/media/video/marvell-ccic

[PATCH 1/6] marvell-cam: delete struct mcam_sio_buffer

2011-07-08 Thread Jonathan Corbet
This structure got passed over in the videobuf2 conversion; it has no reason to exist now. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/marvell-ccic/mcam-core.h | 11 --- 1 files changed, 0 insertions(+), 11 deletions(-) diff --git a/drivers/media/video

[PATCH 6/6] marvell-cam: clean up a couple of unused cam structure fields

2011-07-08 Thread Jonathan Corbet
Delete a couple of leftover fields whose time has passed. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/marvell-ccic/mcam-core.c |2 -- drivers/media/video/marvell-ccic/mcam-core.h |3 --- 2 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH 5/6] marvell-cam: Allow selection of supported buffer modes

2011-07-08 Thread Jonathan Corbet
be good enough. The cafe driver is set to support vmalloc and dma-contig; mmp supports only dma-sg, since that's the only mode that really makes sense to use. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/marvell-ccic/Kconfig |3 - drivers/media/video/marvell-ccic

Re: [ANNOUNCE] Media subsystem workshop 2011 - Prague - Oct 24-26

2011-07-12 Thread Jonathan Corbet
On Mon, 11 Jul 2011 22:08:03 +0200 Hans de Goede hdego...@redhat.com wrote: On Wednesday 22 June 2011 20:33:34 Mauro Carvalho Chehab wrote: Media subsystem workshop 2011 - Prague - Oct 24-26 The below website says Oct 23 - 25, I'm confused now and I hope to book a plane ticket soon.

[PATCH] Non-coherent contiguous DMA for videobuf2

2011-07-14 Thread Jonathan Corbet
on - and every reason to go non-coherent. So here's a patch adding the new mode, and one showing how mmp-camera uses it. Jonathan Corbet (2): videobuf2: Add a non-coherent contiguous DMA mode marvell-cam: Convert contiguous DMA to non-coherent drivers/media/video/Kconfig |5

[PATCH 1/2] videobuf2: Add a non-coherent contiguous DMA mode

2011-07-14 Thread Jonathan Corbet
, and avoids possible page attribute conflict problems. It also is easy to support within the VB2 framework. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/Kconfig|5 ++ drivers/media/video/Makefile |1 + drivers/media/video/videobuf2-dma-nc.c

[PATCH 2/2] marvell-cam: Convert contiguous DMA to non-coherent

2011-07-14 Thread Jonathan Corbet
Switch to the new non-coherent contiguous DMA option. Non-coherent memory is far more reliable to allocate and performs vastly better on this platform. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/marvell-ccic/Kconfig |1 + drivers/media/video/marvell-ccic/mcam

[PATCH] videobuf2: call buf_finish() on unprocessed buffers

2011-07-14 Thread Jonathan Corbet
will not happen. This patch establishes a simple contract with drivers: buffers given to buf_prepare() will eventually see a buf_finish() call. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/videobuf2-core.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions

[PATCH] videobuf2: Do not unconditionally map S/G buffers into kernel space

2011-07-14 Thread Jonathan Corbet
not map the buffer at allocation time; that will save a little CPU time and a lot of address space in the vmalloc range. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/media/video/videobuf2-dma-sg.c |6 -- 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/drivers

Re: [PATCH 1/2] videobuf2: Add a non-coherent contiguous DMA mode

2011-07-15 Thread Jonathan Corbet
Hi, Marek, Thanks for having a look. +static unsigned int vb2_dma_nc_num_users(void *vbuf) +{ + struct vb2_nc_buf *buf = vbuf; + + return atomic_read(buf-refcount); + /* Let's hope they don't fork() about now... */ This comment is really not needed here. vm_handler takes

Re: [PATCH 1/2] videobuf2: Add a non-coherent contiguous DMA mode

2011-07-22 Thread Jonathan Corbet
The problem is that there's no convenient callback into the allocators where the mapping and unmapping can be done now. So I'd have had to add a couple of memops to do that. I think that some additional callbacks for allocators for synchronization buffer state will be required sooner or

[PATCH, RFC] Fix videobuf_queue_vmalloc_init() prototype

2009-11-23 Thread Jonathan Corbet
-off-by: Jonathan Corbet cor...@lwn.net diff --git a/drivers/media/video/videobuf-vmalloc.c b/drivers/media/video/videobuf-vmalloc.c index 99d646e..d6e6a28 100644 --- a/drivers/media/video/videobuf-vmalloc.c +++ b/drivers/media/video/videobuf-vmalloc.c @@ -392,7 +392,7 @@ static struct

[PATCH, RFC] Document the videobuf layer

2009-12-03 Thread Jonathan Corbet
is...sparse. This document attempts to improve the situation. Signed-off-by: Jonathan Corbet cor...@lwn.net diff --git a/Documentation/video4linux/videobuf b/Documentation/video4linux/videobuf new file mode 100644 index 000..4e21ea7 --- /dev/null +++ b/Documentation/video4linux/videobuf

Re: [PATCH, RFC] Document the videobuf layer

2009-12-14 Thread Jonathan Corbet
On Mon, 14 Dec 2009 15:36:08 -0200 Mauro Carvalho Chehab mche...@infradead.org wrote: It is probably better to have it as a separate document like what you've proposed, so, could you please drop the duplicated information that is there and move any missing info that might not be on your

Re: [PATCH 1/3] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2010-04-20 Thread Jonathan Corbet
On Tue, 20 Apr 2010 18:20:05 +0300 Matti J. Aaltonen matti.j.aalto...@nokia.com wrote: This is a parent driver for two child drivers: the V4L2 driver and the ALSA codec driver. The MFD part provides the I2C communication to the device and the state handling. So I was taking a quick look at

Re: [PATCH 1/3] MFD: WL1273 FM Radio: MFD driver for the FM radio.

2010-04-21 Thread Jonathan Corbet
On Wed, 21 Apr 2010 12:29:00 +0300 m7aalton matti.j.aalto...@nokia.com wrote: So I was taking a quick look at this; it mostly looks OK (though I wonder about all those symbol exports - does all that stuff need to be in the Some functions get called from both child drivers/modules, but some

[RFC] Third OLPC viafb patch series (camera driver)

2010-05-05 Thread Jonathan Corbet
could put the camera driver with the rest of the V4L2 crowd. This will also let us move the core, i2c, and gpio drivers to drivers/mfd, should we want to in the future. There shouldn't be any functionality changes beyond the new driver. Comments? Thanks, jon Jonathan Corbet (5): viafb

[PATCH 2/5] viafb: get rid of i2c debug cruft

2010-05-05 Thread Jonathan Corbet
It's ugly and adds a global.h dependency. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/video/via/via_i2c.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/video/via/via_i2c.c b/drivers/video/via/via_i2c.c index febc1dd..84ec2d6 100644

[PATCH 1/5] viafb: fold via_io.h into via-core.h

2010-05-05 Thread Jonathan Corbet
Preparatory move toward the ultimate goal of moving pan-subdevice stuff into include/linux. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/video/via/hw.h |1 - drivers/video/via/share.h | 11 ++ drivers/video/via/via-core.h| 48

[PATCH 5/5] Add the viafb video capture driver

2010-05-05 Thread Jonathan Corbet
Add a driver for the video capture port on VIA integrated chipsets. This version has a remaining OLPCism or two and expects to be talking to an ov7670; those can be improved as the need arises. This work was supported by the One Laptop Per Child project. Signed-off-by: Jonathan Corbet cor

[PATCH 4/5] viafb: move some include files to include/linux

2010-05-05 Thread Jonathan Corbet
These are the files which should be available to subdevices compiled outside of drivers/video/via. Signed-off-by: Jonathan Corbet cor...@lwn.net --- drivers/video/via/accel.c |2 +- drivers/video/via/dvi.c |4 +- drivers/video/via/hw.c |3

  1   2   3   4   >