RE: [SAMPLE v2 04/12] v4l-subdev: Add pads operations

2010-07-23 Thread Karicheri, Muralidharan
Laurent, Could you explain the probe and active usage using an example such as below? Link1Link2 input sensor - ccdc - video node. Assume Link2 we can have either format 1 or format 2 for capture. Thanks. Murali Karicheri Software Design Engineer Texas Instruments Inc.

RE: [SAMPLE v2 04/12] v4l-subdev: Add pads operations

2010-07-26 Thread Karicheri, Muralidharan
Pinchart [mailto:laurent.pinch...@ideasonboard.com] Sent: Monday, July 26, 2010 12:13 PM To: Karicheri, Muralidharan Cc: linux-media@vger.kernel.org; sakari.ai...@maxwell.research.nokia.com Subject: Re: [SAMPLE v2 04/12] v4l-subdev: Add pads operations On Friday 23 July 2010 17:56:02 Karicheri

RE: [PATCH v5 0/3] Multi-planar video format and buffer support for the V4L2 API

2010-07-30 Thread Karicheri, Muralidharan
Snip struct v4l2_format { enum v4l2_buf_type type; union { struct v4l2_pix_format pix; /* V4L2_BUF_TYPE_VIDEO_CAPTURE */ + struct v4l2_pix_format_mplane pix_mp; /* V4L2_BUF_TYPE_VIDEO_CAPTURE_MPLANE */ struct

RE: [PATCH v3 2/6] davinci vpbe: VPBE display driver

2010-12-02 Thread Karicheri, Muralidharan
; Mauro Carvalho Chehab; Hans Verkuil; Hadli, Manjunath; Karicheri, Muralidharan Subject: [PATCH v3 2/6] davinci vpbe: VPBE display driver This patch implements the coe functionality of the dislay driver, mainly controlling the VENC and other encoders, and acting as the one point interface

RE: [PATCH 4/6] davinci vpbe: VENC( Video Encoder) implementation

2010-12-02 Thread Karicheri, Muralidharan
; Mauro Carvalho Chehab; Hans Verkuil; Hadli, Manjunath; Karicheri, Muralidharan Subject: [PATCH 4/6] davinci vpbe: VENC( Video Encoder) implementation This patch adds the VENC or the Video encoder, whichis responsible for the blending of al source planes and timing generation for Video modes like

RE: [PATCH v3 5/6] davinci vpbe: platform specific additions

2010-12-02 Thread Karicheri, Muralidharan
-Original Message- From: Hadli, Manjunath Sent: Thursday, December 02, 2010 7:39 AM To: LMML Cc: dlos; Mauro Carvalho Chehab; Hans Verkuil; Hadli, Manjunath; Karicheri, Muralidharan Subject: [PATCH v3 5/6] davinci vpbe: platform specific additions This patch implements the overall

RE: [PATCH v3 6/6] davinci vpbe: Build infrastructure for VPBE driver

2010-12-02 Thread Karicheri, Muralidharan
, Manjunath; Karicheri, Muralidharan Subject: [PATCH v3 6/6] davinci vpbe: Build infrastructure for VPBE driver This patch adds the build infra-structure for Davinci VPBE dislay driver Signed-off-by: Manjunath Hadli manjunath.ha...@ti.com Signed-off-by: Muralidharan Karicheri m-kariche...@ti.com

RE: [PATCH v5 0/6] davinci vpbe: dm6446 v4l2 driver

2010-12-13 Thread Karicheri, Muralidharan
Manju, 2. Fixed Murali's comments on moving davinci_vpbe_readme.txt to different patch different patch or path? My comment was to move the documentation to Documentation folder. But it is still in it's original path :( Manjunath Hadli (6): davinci vpbe: V4L2 display driver for DM644X SoC

RE: [PATCH v6 7/7] davinci vpbe: Readme text for Dm6446 vpbe

2010-12-15 Thread Karicheri, Muralidharan
Manju, Could you review the Document? I think it is not updated to reflect the latest status: + Current status:- + + A build tested version of vpbe controller is available. I guess you have already tested this using the v4l2 driver. + v4l2 driver +- A version is already developed which is

RE: [PATCH v6 5/7] davinci vpbe: platform specific additions

2010-12-15 Thread Karicheri, Muralidharan
Sergei, I think the DM644x EVM board changes should be in a separate patch. Any reason? Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 -Original Message- From: davinci-linux-open-source-boun...@linux.davincidsp.com

RE: [RFD] frame-size switching: preview / single-shot use-case

2011-02-15 Thread Karicheri, Muralidharan
Adding Manjunath Hadli to the list... Murail -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Tuesday, February 15, 2011 12:34 PM To: Linux Media Mailing List Cc: Qing Xu; Hans Verkuil; Neil Johnson; Robert Jarzmik; Uwe Taeubert; Karicheri

MT9T031 and other similar sub devices...

2009-05-19 Thread Karicheri, Muralidharan
Hi, Guennadi Liakhovetski, Thanks for your effort to migrate the sensor drivers to sub device framework. We have interest in mt9t031 and other sensor drivers from Micron since this peripheral is used in our DM355/DM6446 EVMs as well. I have submitted a set of patches for our vpfe_capture

RE: MT9T031 and other similar sub devices...

2009-05-20 Thread Karicheri, Muralidharan
To: Karicheri, Muralidharan Cc: linux-media@vger.kernel.org Subject: Re: MT9T031 and other similar sub devices... Hi Murali On Tue, 19 May 2009, Karicheri, Muralidharan wrote: Hi, Guennadi Liakhovetski, Thanks for your effort to migrate the sensor drivers to sub device framework. We have

RE: [PATCH 3/9] dm355 ccdc module for vpfe capture driver

2009-06-01 Thread Karicheri, Muralidharan
Laurent, Thanks for reviewing this. I have not gone through all of your comments, but would like to respond to the following one first. I will respond to the rest as I do the rework. I've had a quick look at the DM355 and DM6446 datasheets. The CCDC and VPSS registers share the same memory

RE: New Driver for DaVinci DM355/DM365/DM6446

2009-06-01 Thread Karicheri, Muralidharan
Sergio, Is it part of the patches Vaibhav others from TI are submitting to open source ? I know that there is an ongoing effort at TI India to submit the resizer driver to open source for OMAP3? As per the email exchanges I had with Vaibhav (TI India) on this, it is part of the ISP module. We

[RFC] passing bus/interface parameters from bridge driver to sub device

2009-06-02 Thread Karicheri, Muralidharan
Hi, 1) I want to use v4l2_i2c_new_probed_subdev_addr() to load and probe the the v4l2 sub-device from my vpfe capture driver. Currently the api's available doesn't allow setting platform data in the client before the sub-device's probe is called. I see that there is discussion about adding

RE: [PATCH 1/9] vpfe-capture bridge driver for DM355 DM6446

2009-06-03 Thread Karicheri, Muralidharan
Laurent, See my responses below. I have accepted and modified the code based on your comments. Few are discussed here for conclusion. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 Phone : 301-515-3736 email: m-kariche...@ti.com +#include media/tvp514x.h

RE: [PATCH 3/9] dm355 ccdc module for vpfe capture driver

2009-06-04 Thread Karicheri, Muralidharan
My first reaction to this is... no. I'm reluctant to have a bunch of driver specific hooks in the core davinci SoC specific code. I'd much rather see this stuff kept along with the driver in drivers/media/* and abstracted as necessary there. I agree with Kevin on this. arch/* is mostly

RE: [PATCH 1/9] vpfe-capture bridge driver for DM355 DM6446

2009-06-08 Thread Karicheri, Muralidharan
Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 Phone : 301-515-3736 email: m-kariche...@ti.com -Original Message- From: Laurent Pinchart [mailto:laurent.pinch...@skynet.be] Sent: Friday, June 05, 2009 12:44 PM To: Karicheri, Muralidharan Cc: linux

RE: [PATCH 3/9] dm355 ccdc module for vpfe capture driver

2009-06-08 Thread Karicheri, Muralidharan
Laurent, Laurent, Thanks for reviewing this. See my response below for few comments. Rest of them I have incorporated into my next patch. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 Phone : 301-515-3736 email: m-kariche...@ti.com + +/* register

RE: [RFC] passing bus/interface parameters from bridge driver to sub device

2009-06-09 Thread Karicheri, Muralidharan
Hans, Thanks for looking into this... 1) I want to use v4l2_i2c_new_probed_subdev_addr() to load and probe the the v4l2 sub-device from my vpfe capture driver. Currently the api's available doesn't allow setting platform data in the client before the sub-device's probe is called. I see

RE: [PATCH 5/10 - v2] ccdc hw device header file for vpfe capture

2009-06-09 Thread Karicheri, Muralidharan
Please ignore this, it has wrong series number. I will re-send it soon email: m-kariche...@ti.com -Original Message- From: Karicheri, Muralidharan Sent: Tuesday, June 09, 2009 2:50 PM To: linux-media@vger.kernel.org Cc: davinci-linux-open-sou...@linux.davincidsp.com; Muralidharan

RE: [PATCH RFC] adding support for setting bus parameters in sub device

2009-06-09 Thread Karicheri, Muralidharan
email: m-kariche...@ti.com -Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Tuesday, June 09, 2009 5:03 PM To: Karicheri, Muralidharan Cc: linux-media@vger.kernel.org; davinci-linux-open- sou...@linux.davincidsp.com; Muralidharan Karicheri Subject: Re: [PATCH RFC

RE: [PATCH RFC] adding support for setting bus parameters in sub device

2009-06-10 Thread Karicheri, Muralidharan
+/* + * Some sub-devices are connected to the bridge device through a bus that + * carries * the clock, vsync, hsync and data. Some interfaces such as BT.656 + * carries the sync embedded in the data where as others have separate line + * carrying the sync signals. The structure

RE: [PATCH 0/10 - v2] ARM: DaVinci: Video: DM355/DM6446 VPFE Capture driver

2009-06-10 Thread Karicheri, Muralidharan
20874 Phone : 301-515-3736 email: m-kariche...@ti.com -Original Message- From: Karicheri, Muralidharan Sent: Tuesday, June 09, 2009 2:47 PM To: linux-media@vger.kernel.org Cc: davinci-linux-open-sou...@linux.davincidsp.com; Muralidharan Karicheri; Karicheri, Muralidharan Subject: [PATCH 0/10

RE: [PATCH] adding support for setting bus parameters in sub device

2009-06-10 Thread Karicheri, Muralidharan
To: Karicheri, Muralidharan Cc: linux-media@vger.kernel.org; davinci-linux-open- sou...@linux.davincidsp.com; Muralidharan Karicheri Subject: Re: [PATCH] adding support for setting bus parameters in sub device On Tue, 9 Jun 2009, m-kariche...@ti.com wrote: From: Muralidharan Karicheri a0868

RE: mt9t031 (was RE: [PATCH] adding support for setting bus parameters in sub device)

2009-06-10 Thread Karicheri, Muralidharan
We need streaming capability in the driver. This is how our driver works with mt9t031 sensor raw-bus (10 bit) vpfe-capture - mt9t031 driver || V V VPFE

RE: [PATCH 0/10 - v2] ARM: DaVinci: Video: DM355/DM6446 VPFE Capture driver

2009-06-10 Thread Karicheri, Muralidharan
Hans, Great! I look forward for your comments. Murali Karicheri email: m-kariche...@ti.com -Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Wednesday, June 10, 2009 5:28 PM To: Karicheri, Muralidharan Cc: linux-media@vger.kernel.org; davinci-linux-open- sou

RE: [PATCH] adding support for setting bus parameters in sub device

2009-06-11 Thread Karicheri, Muralidharan
Why force all platforms to set it if the driver is perfectly capable do this itself? As I said - this is not a platform-specific feature, it's chip-specific. What good would it make to have all platforms using mt9t031 to specify, that yes, the chip can use both falling and rising pclk edge,

RE: mt9t031 (was RE: [PATCH] adding support for setting bus parameters in sub device)

2009-06-11 Thread Karicheri, Muralidharan
-Philippe François; Karicheri, Muralidharan; davinci-linux-open- sou...@linux.davincidsp.com; Muralidharan Karicheri; Guennadi Liakhovetski; linux-media@vger.kernel.org Subject: Re: mt9t031 (was RE: [PATCH] adding support for setting bus parameters in sub device) On 06/11/2009 11:33 AM, Hans Verkuil

RE: mt9t031 (was RE: [PATCH] adding support for setting bus parameters in sub device)

2009-06-11 Thread Karicheri, Muralidharan
- video streaming devices like the davinci videoports where you can hook up HDTV receivers or FPGAs: here you definitely need a new API to setup the streaming parameters, and you want to be able to do that from the application as well. Actually, sensors are also hooked up to these devices

RE: mt9t031 (was RE: [PATCH] adding support for setting bus parameters in sub device)

2009-06-11 Thread Karicheri, Muralidharan
On Wed, 10 Jun 2009, Karicheri, Muralidharan wrote: So how do I know what frame-rate I get? Sensor output frame rate depends on the resolution of the frame, blanking, exposure time etc. This is not supported. I am still not clear. You had said in an earlier email that it can support

RE: mt9t031 (was RE: [PATCH] adding support for setting bus parameters in sub device)

2009-06-11 Thread Karicheri, Muralidharan
I am sorry, I do not know how I can explain myself clearer. Thanks for helping me to understand better :) Yes, you can stream video with mt9t031. No, you neither get the framerate measured by the driver nor can you set a specific framerate. Frames are produced as fast as it goes, depending on

USERPTR buffer exchange mechanism

2009-06-12 Thread Karicheri, Muralidharan
Hi, I would like to explore what level of support is available in the v4l buffer exchange mechanism for USERPTR buffer exchange. In our internal release, we had a hack to support this feature. We use contiguous buffers in our user ptr hack implementation. The buffers are allocated in a kernel

RE: [PATCH 0/10 - v2] ARM: DaVinci: Video: DM355/DM6446 VPFE Capture driver

2009-06-12 Thread Karicheri, Muralidharan
This is the version v2 of the patch series. This is the reworked version of the driver based on comments received against the last version of the patch. I'll be glad to see this get to mainline ... it's seeming closer and closer! What's the merge plan though? I had hopes for

RE: [PATCH (V2)] TVP514x: Migration to sub-device framework - Is it approved ???

2009-06-12 Thread Karicheri, Muralidharan
...@ti.com -Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Friday, June 12, 2009 12:18 PM To: Karicheri, Muralidharan Cc: linux-media@vger.kernel.org Subject: Re: [PATCH (V2)] TVP514x: Migration to sub-device framework - Is it approved ??? On Friday 12 June 2009 18:04

RE: [PATCH RFC] adding support for setting bus parameters in sub device

2009-06-15 Thread Karicheri, Muralidharan
+ +struct v4l2_subdev_bus { +       enum v4l2_subdev_bus_type type; +       u8 width; +       /* 0 - active low, 1 - active high */ +       unsigned pol_vsync:1; +       /* 0 - active low, 1 - active high */ +       unsigned pol_hsync:1; +       /* 0 - low to high , 1 - high to low */ +  

RE: Did I miss any other patches or RFCs that need to be reviewed?

2009-06-15 Thread Karicheri, Muralidharan
Hans, Thanks for your review. I will get back to you if I need more information on your comments. You have reviewed the following patches in this series... 1,7,8,10 Following are part of this series which requires review as well. [PATCH 2/10 - v2] ccdc hw device header file for vpfe capture

RE: [PATCH 1/10 - v2] vpfe capture bridge driver for DM355 and DM6446

2009-06-15 Thread Karicheri, Muralidharan
+       /* set the default image parameters in the device */ +       ret = vpfe_config_image_format(vpfe_dev, +                               vpfe_standards[vpfe_dev- std_index].std_id); +       if (ret) +               goto unlock_out; Why you check ret value and go to label below? Probably

RE: [PATCH 10/10 - v2] common vpss module for video drivers

2009-06-15 Thread Karicheri, Muralidharan
= dm644x_clear_wbl_overflow; +       else +               return -ENODEV; Do you need clean up procedure if you return error here? I mean - calls to release_mem_region, release_mem_region, etc Oops! I need to add that. Thanks. +       spin_lock_init(oper_cfg.vpss_lock); +      

RE: Did I miss any other patches or RFCs that need to be reviewed?

2009-06-15 Thread Karicheri, Muralidharan
Engineer Texas Instruments Inc. Germantown, MD 20874 Phone : 301-515-3736 email: m-kariche...@ti.com -Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Monday, June 15, 2009 1:56 PM To: Karicheri, Muralidharan Cc: linux-media@vger.kernel.org; davinci-linux-open- sou

RE: [PATCH 1/10 - v2] vpfe capture bridge driver for DM355 and DM6446

2009-06-15 Thread Karicheri, Muralidharan
Hans, I am not clear about some of your comments. Please see below with a [MK] prefix. +static int debug; +static u32 numbuffers = 3; +static u32 bufsize = (720 * 576 * 2); + +module_param(numbuffers, uint, S_IRUGO); +module_param(bufsize, uint, S_IRUGO); +module_param(debug, int, 0644);

RE: Did I miss any other patches or RFCs that need to be reviewed?

2009-06-15 Thread Karicheri, Muralidharan
5:46 PM To: Karicheri, Muralidharan Cc: linux-media@vger.kernel.org; davinci-linux-open- sou...@linux.davincidsp.com; linux-o...@vger.kernel.org Subject: Re: Did I miss any other patches or RFCs that need to be reviewed? On Monday 15 June 2009 20:44:15 Karicheri, Muralidharan wrote: Hans

RE: [PATCH 1/10 - v2] vpfe capture bridge driver for DM355 and DM6446

2009-06-16 Thread Karicheri, Muralidharan
Hans, Thanks for the response. snip Polarities have to be set for each side, that's correct. The other parameters are common for both. Although I can think of scenarios where the bus width can differ between host and subdev (e.g. subdev sends data on 8 pins and the host captures on 10 with the

RE: OMAP patches for linux-media

2009-06-16 Thread Karicheri, Muralidharan
Hi Mauro, [snip] I'm seeing lots of patches and discussions for OMAP and DaVinci being handled at the linux-media Mailing List, as part of the development process of the open source drivers. [MK] I along with Chaithrika are working with Hans Verkuil to get the DaVinci video drivers added to

RE: USERPTR buffer exchange mechanism

2009-06-16 Thread Karicheri, Muralidharan
Hi, Any suggestion here? Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 email: m-kariche...@ti.com -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of Karicheri, Muralidharan Sent

RE: [PATCH 1/10 - v2] vpfe capture bridge driver for DM355 and DM6446

2009-06-17 Thread Karicheri, Muralidharan
snip Can you post your latest proposal for the s_bus op? I propose a few changes: the name of the struct should be something like v4l2_bus_settings, the master/slave bit should be renamed to something like 'host_is_master', and we should have two widths: subdev_width and host_width. That way

RE: [RFC PATCH] adding support for setting bus parameters in sub device

2009-06-17 Thread Karicheri, Muralidharan
- From: Karicheri, Muralidharan Sent: Wednesday, June 17, 2009 11:44 AM To: linux-media@vger.kernel.org Cc: davinci-linux-open-sou...@linux.davincidsp.com; Muralidharan Karicheri; Karicheri, Muralidharan Subject: [RFC PATCH] adding support for setting bus parameters in sub device From

RE: [DaVinci] patches for linux-media

2009-06-17 Thread Karicheri, Muralidharan
Hi Hans Mauro, The v3 version of the DaVici VPFE Capture driver and TVP514x driver has been sent to the list for review. I expect this to sail through with out any comments as I have addressed few minor comments from last review. I think Hans will send you the pull request for these patches.

RE: [PATCH 1/11 - v3] vpfe capture bridge driver for DM355 and DM6446

2009-06-22 Thread Karicheri, Muralidharan
Hans, Thanks for taking care of this. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 email: m-kariche...@ti.com -Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Friday, June 19, 2009 8:41 AM To: Alexey Klimov Cc: Karicheri

RE: [PATCH 3/11 - v3] dm355 ccdc module for vpfe capture driver

2009-06-22 Thread Karicheri, Muralidharan
snip +static int dm355_ccdc_init(void) +{ +       printk(KERN_NOTICE dm355_ccdc_init\n); +       if (vpfe_register_ccdc_device(ccdc_hw_dev) 0) +               return -1; Don't you want to rewrite this to return good error code? int ret; printk(); ret =

RE: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-vpfe-cap

2009-06-22 Thread Karicheri, Muralidharan
Hi, Snip -/** +/* * struct tvp514x_decoder - TVP5146/47 decoder object - * @v4l2_int_device: Slave handle - * @tvp514x_slave: Slave pointer which is used by @v4l2_int_device + * @sd: Subdevice Slave handle * @tvp514x_regs: copy of hw's regs with preset values. * @pdata:

RE: Mem2Mem V4L2 devices [RFC]

2009-10-05 Thread Karicheri, Muralidharan
1. How to set different color space or size for input and output buffer each? It could be solved by adding a set of ioctls to get/set source image format and size, while the existing v4l2 ioctls would only refer to the output buffer. Frankly speaking, we don't like this idea. I think that

RE: Mem2Mem V4L2 devices [RFC]

2009-10-05 Thread Karicheri, Muralidharan
Ivan, There is another use case where there are two Resizer hardware working on the same input frame and give two different output frames of different resolution. How do we handle this using the one video device approach you just described here? what is the difference? - you can have only

Mem2Mem V4L2 devices [RFC] - Can we enhance the V4L2 API?

2009-10-05 Thread Karicheri, Muralidharan
] Sent: Monday, October 05, 2009 4:14 PM To: Karicheri, Muralidharan Cc: Marek Szyprowski; linux-media@vger.kernel.org; kyungmin.p...@samsung.com; Tomasz Fujak; Pawel Osciak Subject: RE: Mem2Mem V4L2 devices [RFC] Hi, On Mon, 2009-10-05 at 15:02 -0500, Karicheri, Muralidharan wrote: 1. How

RE: Mem2Mem V4L2 devices [RFC] - Can we enhance the V4L2 API?

2009-10-07 Thread Karicheri, Muralidharan
Marek, As we have seen in the discussion, this is not a streaming device, rather a transaction/conversion device which operate on a given frame to get a desired output frame. Each transaction may have it's own set of configuration context which will be applied to the hardware before starting

RE: Mem2Mem V4L2 devices [RFC]

2009-10-07 Thread Karicheri, Muralidharan
Marek, How the hardware is actually designed? I see two possibilities: 1. [input buffer] --[dma engine] [resizer1] --[dma]- [mem output buffer1] \- [resizer2] --[dma]- [mem output buffer2] This is the case. 2. [input buffer] ---[dma engine1]- [resizer1]

RFC (v1.1): V4L - Support for video timings at the input/output interface

2009-10-09 Thread Karicheri, Muralidharan
Hello, Here is the version 1.1 of the RFC which will be used for implementing the video timing APIs in the V4L2 core. Please review and let me know if I have missed something. Following are the changes incorporated in this version :- 1) Added width and height parameters in the struct

RE: RFC (v1.1): V4L - Support for video timings at the input/output interface

2009-10-10 Thread Karicheri, Muralidharan
Hans, From: Hans Verkuil [hverk...@xs4all.nl] Sent: Friday, October 09, 2009 10:43 AM To: Karicheri, Muralidharan Cc: linux-media@vger.kernel.org Subject: Re: RFC (v1.1): V4L - Support for video timings at the input/output interface i Murali, Reading

RE: RFC (v1.1): V4L - Support for video timings at the input/output interface

2009-10-12 Thread Karicheri, Muralidharan
Design Engineer Texas Instruments Inc. Germantown, MD 20874 email: m-kariche...@ti.com -Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Saturday, October 10, 2009 2:39 PM To: Karicheri, Muralidharan Cc: linux-media@vger.kernel.org Subject: Re: RFC (v1.1): V4L

RE: Support on discontinuous planer buffer and stride

2009-10-15 Thread Karicheri, Muralidharan
Hans, Well, it is definitely not possible to do it in this manner since changing the size of struct v4l2_buffer will break the API. Furthermore, something like this will only work if the DMA engine can handle strides. Is that the case for your hardware? I don't think you mentioned what the

RE: Support on discontinuous planer buffer and stride

2009-10-15 Thread Karicheri, Muralidharan
...@vger.kernel.org] On Behalf Of Karicheri, Muralidharan Sent: Thursday, October 15, 2009 10:00 AM To: Hans Verkuil; Jun Nie Cc: g.liakhovet...@gmx.de; linux-media Subject: RE: Support on discontinuous planer buffer and stride Hans, Well, it is definitely not possible to do it in this manner since

RE: [PATCH 4/6] Davinci VPFE Capture:Replaced IRQ_VDINT1 with vpfe_dev-ccdc_irq1

2009-10-16 Thread Karicheri, Muralidharan
Acked-by : Muralidharan Karicheri m-kariche...@ti.com Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 phone: 301-407-9583 email: m-kariche...@ti.com -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media-

RE: [PATCH 1/6] Davinci VPFE Capture: Specify device pointer in videobuf_queue_dma_contig_init

2009-10-16 Thread Karicheri, Muralidharan
Acked-by Muralidharan Karicheri m-kariche...@ti.com Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 email: m-kariche...@ti.com -Original Message- From: linux-media-ow...@vger.kernel.org [mailto:linux-media- ow...@vger.kernel.org] On Behalf Of

RE: [PATCH v1 1/4] DM365 Platform support for VPFE

2009-10-16 Thread Karicheri, Muralidharan
Kevin, I would like to wait on this one and re-submit a revised patch. There is a plan to use sub device model for ccdc driver. So I will re-submit the ccdc drivers with this change as well as the corresponding platform code. Murali Karicheri Software Design Engineer Texas Instruments Inc.

RE: [Resubmition PATCH] Davinci VPFE Capture: Take i2c adapter id through platform data

2009-10-16 Thread Karicheri, Muralidharan
Vaibhav, Thanks for the patch. See my comment below. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 phone: 301-407-9583 email: m-kariche...@ti.com -Original Message- From: davinci-linux-open-source-boun...@linux.davincidsp.com

RE: [PATCH 0/6 v5] Support for TVP7002 in DM365

2009-10-20 Thread Karicheri, Muralidharan
, Snehaprabha; Karicheri, Muralidharan; Diego Dompe; todd.fisc...@ridgerun.com; Grosen, Mark; Linux Media Mailing List Subject: [PATCH 0/6 v5] Support for TVP7002 in DM365 This series of patches provide support for the TVP7002 decoder in DM365. Support includes: * Inclusion of the chip in v4l2 definitions

RE: RFC (v1.2): V4L - Support for video timings at the input/output interface

2009-10-21 Thread Karicheri, Muralidharan
Hans, #defineV4L2_DV_INVALID0x #define V4L2_DV_480I59_94 0x0001 #define V4L2_DV_480I60 0x0002 #define V4L2_DV_480P23_976 0x0003 #define V4L2_DV_480P24 0x0004 #define V4L2_DV_480P29_97

RE: RFC (v1.2): V4L - Support for video timings at the input/output interface

2009-10-21 Thread Karicheri, Muralidharan
Hans, /* timing data values specified by various standards such as BT.1120, BT.656 etc. */ /* bt.656/bt.1120 timing data */ struct v4l2_bt_timings { __u32 interlaced; __u64 pixelclock; __u32 width, height; __u32 polarities; __u32

RE: [PATCH] V4L: adding digital video timings APIs

2009-10-23 Thread Karicheri, Muralidharan
Hans, following IOCTLS :- - verify the new v4l2_input capabilities flag added - Enumerate available presets using VIDIOC_ENUM_DV_PRESETS - Set one of the supported preset using VIDIOC_S_DV_PRESET - Get current preset using VIDIOC_G_DV_PRESET - Detect current preset using

RE: [PATCH] V4L/DVB: keep index within bound in vpfe_cropcap()

2009-10-26 Thread Karicheri, Muralidharan
Kluin [mailto:roel.kl...@gmail.com] Sent: Monday, October 26, 2009 7:25 AM To: Mauro Carvalho Chehab; linux-media@vger.kernel.org; Andrew Morton; Karicheri, Muralidharan Subject: [PATCH] V4L/DVB: keep index within bound in vpfe_cropcap() If vpfe_dev-std_index equals ARRAY_SIZE(vpfe_standards

RE: V4L2_MEMORY_USERPTR support in videobuf-core

2009-10-28 Thread Karicheri, Muralidharan
Pawel, We have been using USERPTR IO in our vpfe capture driver. I also want to acknowledge the fact that the core layer expects index contrary to API specs as you have pointed Even if that was the case though, would an application be supposed to arbitrarily choose what index to pass? If so,

RE: [PATCH V2] Davinci VPFE Capture: Add support for Control ioctls

2009-10-29 Thread Karicheri, Muralidharan
Acked-by Muralidharan Karicheri m-kariche...@ti.com Mauro, could you please merge this to your v4l-dvb tree? Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 email: m-kariche...@ti.com -Original Message- From: linux-media-ow...@vger.kernel.org

RE: [PATCH/RFC 0/9 v2] Image-bus API and accompanying soc-camera patches

2009-10-30 Thread Karicheri, Muralidharan
To: Linux Media Mailing List Cc: Hans Verkuil; Laurent Pinchart; Sakari Ailus; Karicheri, Muralidharan Subject: [PATCH/RFC 0/9 v2] Image-bus API and accompanying soc-camera patches Hi all As discussed yesterday, we sant to finalise the conversion of soc-camera to v4l2-subdev. The presented 9 patches

RE: [PATCH 2/9] v4l: add new v4l2-subdev sensor operations, use g_skip_top_lines in soc-camera

2009-10-30 Thread Karicheri, Muralidharan
Guennadi, mt9m111-rect.left = MT9M111_MIN_DARK_COLS; mt9m111-rect.top = MT9M111_MIN_DARK_ROWS; diff --git a/drivers/media/video/mt9t031.c b/drivers/media/video/mt9t031.c index 6966f64..57e04e9 100644 --- a/drivers/media/video/mt9t031.c +++ b/drivers/media/video/mt9t031.c

RE: [PATCH/RFC 9/9] mt9t031: make the use of the soc-camera client API optional

2009-10-30 Thread Karicheri, Muralidharan
Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Friday, October 30, 2009 10:02 AM To: Linux Media Mailing List Cc: Hans Verkuil; Laurent Pinchart; Sakari Ailus; Karicheri, Muralidharan Subject: [PATCH/RFC 9/9] mt9t031: make the use of the soc-camera client API optional

RE: [PATCH/RFC 9/9] mt9t031: make the use of the soc-camera client API optional

2009-11-02 Thread Karicheri, Muralidharan
Guennadi, Thanks for the reply. +}; + +static struct soc_camera_ops mt9t031_ops = { + .set_bus_param = mt9t031_set_bus_param, + .query_bus_param= mt9t031_query_bus_param, + .controls = mt9t031_controls, + .num_controls =

RE: [PATCH 2/9] v4l: add new v4l2-subdev sensor operations, use g_skip_top_lines in soc-camera

2009-11-02 Thread Karicheri, Muralidharan
: Friday, October 30, 2009 4:32 PM To: Karicheri, Muralidharan Cc: Linux Media Mailing List; Hans Verkuil; Laurent Pinchart; Sakari Ailus Subject: RE: [PATCH 2/9] v4l: add new v4l2-subdev sensor operations, use g_skip_top_lines in soc-camera On Fri, 30 Oct 2009, Karicheri, Muralidharan wrote

RE: [PATCH/RFC 9/9 v2] mt9t031: make the use of the soc-camera client API optional

2009-11-04 Thread Karicheri, Muralidharan
Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 phone: 301-407-9583 email: m-kariche...@ti.com -Original Message- From: Guennadi Liakhovetski [mailto:g.liakhovet...@gmx.de] Sent: Wednesday, November 04, 2009 11:49 AM To: Karicheri, Muralidharan Cc: Linux Media

RE: still image capture with video preview

2009-11-04 Thread Karicheri, Muralidharan
Hi Neil, Interesting use case. I am thinking of doing the same for vpfe capture drive and here is what I am thinking of doing. 1) sensor driver MT9P031 configures either full capture(2592x1944) (No skipping or binning) and video mode (VGA or 480p or any other resolution through skipping

RE: OMAP 3 ISP and N900 sensor driver update

2009-11-10 Thread Karicheri, Muralidharan
Hi Laurent, I have also copied Vaibhav from TI in this email since this is of interesting to his area of work as well. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 email: m-kariche...@ti.com Who is working on the CCDC driver for OMAP35xx? Just for

RE: [PATCH] V4L: adding digital video timings APIs

2009-11-11 Thread Karicheri, Muralidharan
Hans, [MK] Could you explain this to me? In my prototype, I had tvp5146 that implements S_STD and tvp7002 that implements S_PRESET. Since bridge driver has all the knowledge about the sub devices and their capabilities, it can set the flag for each of the input that it supports (currently I

RE: [PATCH] V4L: adding digital video timings APIs

2009-11-11 Thread Karicheri, Muralidharan
Texas Instruments Inc. Germantown, MD 20874 phone: 301-407-9583 email: m-kariche...@ti.com -Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Wednesday, November 11, 2009 2:21 AM To: Karicheri, Muralidharan Cc: linux-media@vger.kernel.org; davinci-linux-open- sou

RE: [PATCH 6/6] TVP514x:Switch to automode for s_input/querystd

2009-11-13 Thread Karicheri, Muralidharan
, Vaibhav Cc: linux-media@vger.kernel.org; Jadav, Brijesh R; Karicheri, Muralidharan Subject: Re: [PATCH 6/6] TVP514x:Switch to automode for s_input/querystd On Tuesday 10 November 2009 06:49:55 Hiremath, Vaibhav wrote: -Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl

RE: [PATCH] V4L: adding digital video timings APIs

2009-11-13 Thread Karicheri, Muralidharan
Inc. Germantown, MD 20874 phone: 301-407-9583 email: m-kariche...@ti.com -Original Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Wednesday, November 11, 2009 2:21 AM To: Karicheri, Muralidharan Cc: linux-media@vger.kernel.org; davinci-linux-open- sou...@linux.davincidsp.com

RE: [PATCH 3/4 v7] TVP7002 driver for DM365

2009-11-16 Thread Karicheri, Muralidharan
Hans, Please see my response below. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 email: m-kariche...@ti.com I think Santiago based his driver on tvp514x which doesn't update the register until the chip is ready to stream. Only when STREAMON is called

Help in adding documentation

2009-11-17 Thread Karicheri, Muralidharan
Hi Mauro, Is there some instructions on adding new sections in the v4l2 documentation. I had been struggling yesterday to add my documentation for video timing API. It is easy to make minor documentation changes. But since I am adding new ioctls, Looks like I need to create vidioc-xxx.xml

RE: Help in adding documentation

2009-11-17 Thread Karicheri, Muralidharan
-Original Message- From: Karicheri, Muralidharan Sent: Tuesday, November 17, 2009 10:58 AM To: 'Mauro Carvalho Chehab' Cc: 'Hans Verkuil'; linux-media@vger.kernel.org Subject: Help in adding documentation Hi Mauro, Is there some instructions on adding new sections in the v4l2 documentation

RE: Help in adding documentation

2009-11-17 Thread Karicheri, Muralidharan
Mauro, Thanks for your reply. I made progress after my email. My new file is being processed by Makefile now. I have some issues with some tags. This probably means that videodev2.h has it defined, while you didn't have Do you mean videodev2.h.xml? I see there videodev2.h under linux/include.

RE: Help in adding documentation

2009-11-17 Thread Karicheri, Muralidharan
email: m-kariche...@ti.com -Original Message- From: Mauro Carvalho Chehab [mailto:mche...@infradead.org] Sent: Tuesday, November 17, 2009 12:58 PM To: Karicheri, Muralidharan Cc: Hans Verkuil; linux-media@vger.kernel.org Subject: Re: Help in adding documentation Karicheri, Muralidharan

RE: [PATCH] VPFE Capture: Add call back function for interrupt clear to vpfe_cfg

2009-11-18 Thread Karicheri, Muralidharan
; Karicheri, Muralidharan; Hiremath, Vaibhav Subject: [PATCH] VPFE Capture: Add call back function for interrupt clear to vpfe_cfg From: Vaibhav Hiremath hvaib...@ti.com For the devices like AM3517, it is expected that driver clears the interrupt in ISR. Since this is device spcific, callback function

RE: [PATCH] Davinci VPFE Capture: Add Suspend/Resume Support

2009-11-18 Thread Karicheri, Muralidharan
To: linux-media@vger.kernel.org Cc: hverk...@xs4all.nl; Karicheri, Muralidharan; Hiremath, Vaibhav Subject: [PATCH] Davinci VPFE Capture: Add Suspend/Resume Support From: Vaibhav Hiremath hvaib...@ti.com Validated on AM3517 Platform. Signed-off-by: Vaibhav Hiremath hvaib...@ti.com --- drivers/media

RE: [PATCH] Davinci VPFE Capture: Add Suspend/Resume Support

2009-11-18 Thread Karicheri, Muralidharan
: Wednesday, November 18, 2009 10:36 AM To: Karicheri, Muralidharan; linux-media@vger.kernel.org Cc: hverk...@xs4all.nl Subject: RE: [PATCH] Davinci VPFE Capture: Add Suspend/Resume Support -Original Message- From: Karicheri, Muralidharan Sent: Wednesday, November 18, 2009 8:55 PM

RE: [PATCH] Davinci VPFE Capture: Add Suspend/Resume Support

2009-11-18 Thread Karicheri, Muralidharan
Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 phone: 301-407-9583 email: m-kariche...@ti.com -Original Message- From: Hiremath, Vaibhav Sent: Wednesday, November 18, 2009 11:52 AM To: Karicheri, Muralidharan; linux-media@vger.kernel.org Cc: hverk

RE: [PATCH v2] V4L - Adding Digital Video Timings APIs

2009-11-18 Thread Karicheri, Muralidharan
I will be sending the patch for documentation today. FYI. Murali Karicheri Software Design Engineer Texas Instruments Inc. Germantown, MD 20874 email: m-kariche...@ti.com -Original Message- From: Karicheri, Muralidharan Sent: Wednesday, November 18, 2009 12:04 PM To: linux-media

RE: Help in adding documentation

2009-11-18 Thread Karicheri, Muralidharan
Texas Instruments Inc. Germantown, MD 20874 phone: 301-407-9583 email: m-kariche...@ti.com -Original Message- From: Mauro Carvalho Chehab [mailto:mche...@infradead.org] Sent: Tuesday, November 17, 2009 12:58 PM To: Karicheri, Muralidharan Cc: Hans Verkuil; linux-media@vger.kernel.org Subject

RE: [PATCH v2] V4L - Adding Digital Video Timings APIs

2009-11-18 Thread Karicheri, Muralidharan
Message- From: Hans Verkuil [mailto:hverk...@xs4all.nl] Sent: Wednesday, November 18, 2009 1:09 PM To: Karicheri, Muralidharan Cc: linux-media@vger.kernel.org; davinci-linux-open- sou...@linux.davincidsp.com Subject: Re: [PATCH v2] V4L - Adding Digital Video Timings APIs On Wednesday 18 November

RE: [PATCH v2] V4L - Adding Digital Video Timings APIs

2009-11-18 Thread Karicheri, Muralidharan
Hans, Thanks for doing the 64-bit test. I will incorporate the below comments along with the other comments and will post v3 of the patch with you included in the sign off. Regards, Murali I did some quick 64-bit tests and discovered that we need to add the packed attribute to struct

RE: Help in adding documentation

2009-11-18 Thread Karicheri, Muralidharan
Carvalho Chehab [mailto:mche...@infradead.org] Sent: Wednesday, November 18, 2009 2:48 PM To: Karicheri, Muralidharan Cc: Hans Verkuil; linux-media@vger.kernel.org Subject: Re: Help in adding documentation Karicheri, Muralidharan wrote: Mauro, Is there specific way to create patch

RE: [PATCH v3] V4L - Adding Digital Video Timings APIs

2009-11-18 Thread Karicheri, Muralidharan
Randy, Thanks for your comments... Make sure that these ioctls (range) are added to/included in Documentation/ioctl/ioctl-number.txt . There is separate document for v4l2 APIs. These ioctls are added to that (See my patch with similar title) Hm, are those supposed to be small 'v' instead of

  1   2   3   >