[PATCH 3/3] dt-bindings: Add Renesas R-Car FDP1 bindings

2016-06-09 Thread Kieran Bingham
The FDP1 is a de-interlacing module which converts interlaced video to progressive video. It is also capable of performing pixel format conversion between YCbCr/YUV formats and RGB formats. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- .../devicetree/bindings/media/renesas,fd

[PATCH 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage

2016-06-09 Thread Kieran Bingham
The power domain must be specified to bring the device out of module standby. Document this in the example provided, so that new additions are not missed. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- Documentation/devicetree/bindings/media/renesas,fcp.txt | 1 + 1 file chan

Re: [PATCH RFC 1/2] v4l: platform: Add Renesas R-Car FDP1 Driver

2016-06-10 Thread Kieran Bingham
Today I learned about make C=1 So ... reviewing my own patch, consider the following sparse warnings 'fixed up' I'll run make C=1 before any future submissions from now on. On 09/06/16 18:37, Kieran Bingham wrote: > The FDP1 driver performs advanced de-interlacing on a memory 2 memory >

[PATCH RFC 1/2] v4l: platform: Add Renesas R-Car FDP1 Driver

2016-06-09 Thread Kieran Bingham
The FDP1 driver performs advanced de-interlacing on a memory 2 memory based video stream, and supports conversion from YCbCr/YUV to RGB pixel formats Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- drivers/media/platform/Kconfig | 13 + drivers/media/platform/Makefile

[PATCH RFC 2/2] MAINTAINERS: Add support for FDP driver

2016-06-09 Thread Kieran Bingham
Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 66de4da2d244..bc083b58e478 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7312,6 +7312,15 @@ S: Supported F: Documen

[PATCH RFC 0/2] v4l: platform: Add Renesas R-Car FDP1 Driver

2016-06-09 Thread Kieran Bingham
driver this seemed like an apt point to start the review process. Kieran Bingham (2): v4l: platform: Add Renesas R-Car FDP1 Driver MAINTAINERS: Add support for FDP driver MAINTAINERS|9 + drivers/media/platform/Kconfig | 13 + drivers/media/platform/Makefile

[PATCH] [media] v4l: vsp1: Fix format-info documentation

2016-06-09 Thread Kieran Bingham
Minor tweaks to document the swap register and make the documentation match the struct ordering Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- drivers/media/platform/vsp1/vsp1_pipe.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/platfor

[PATCH 1/3] dt-bindings: Update Renesas R-Car FCP DT binding

2016-06-09 Thread Kieran Bingham
The FCP driver, can also support the FCPF variant for FDP1 compatible processing. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- Documentation/devicetree/bindings/media/renesas,fcp.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devi

[PATCH] v4l: Extend FCP compatible list to support the FDP

2016-06-09 Thread Kieran Bingham
.html Kieran Bingham (1): v4l: Extend FCP compatible list to support the FDP drivers/media/platform/rcar-fcp.c | 1 + 1 file changed, 1 insertion(+) -- 2.7.4 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kerne

[PATCH] v4l: Extend FCP compatible list to support the FDP

2016-06-09 Thread Kieran Bingham
The FCP must be powered up for the FDP1 to function, even when the FDP1 does not make use of the FCNL features. Extend the compatible list to allow us to use the power domain and runtime-pm support. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- drivers/media/platform/rcar-fcp.c |

Re: [PATCH 1/3] dt-bindings: Update Renesas R-Car FCP DT binding

2016-06-13 Thread Kieran Bingham
On 10/06/16 18:37, Rob Herring wrote: > On Thu, Jun 09, 2016 at 02:41:32PM +0100, Kieran Bingham wrote: >> The FCP driver, can also support the FCPF variant for FDP1 compatible > > Drop the comma. Ok >> processing. >> >> Signed-off-by: K

Re: [PATCH 3/3] dt-bindings: Add Renesas R-Car FDP1 bindings

2016-06-13 Thread Kieran Bingham
On 10/06/16 18:40, Rob Herring wrote: > On Thu, Jun 09, 2016 at 02:41:34PM +0100, Kieran Bingham wrote: >> The FDP1 is a de-interlacing module which converts interlaced video to >> progressive video. It is also capable of performing pixel format conversion >> between YCbC

Re: [PATCH 2/4] dt-bindings: Update Renesas R-Car FCP DT binding

2016-05-30 Thread Kieran Bingham
Hi Geert! On 28/05/16 20:06, Geert Uytterhoeven wrote: > Hi Kieran, > > On Fri, May 27, 2016 at 7:19 PM, Kieran Bingham <kie...@ksquared.org.uk> > wrote: >> The FCP driver, can also support the FCPF variant for FDP1 compatible >> processing. >> &

Re: [PATCH 3/4] dt-bindings: Document Renesas R-Car FCP power-domains usage

2016-05-30 Thread Kieran Bingham
Hi Geert, On 28/05/16 20:03, Geert Uytterhoeven wrote: > Hi Kieran, > > On Fri, May 27, 2016 at 7:19 PM, Kieran Bingham <kie...@ksquared.org.uk> > wrote: >> The example misses the power-domains usage, and documentation that the >> property is used by the nod

[PATCH 0/4] RCar r8a7795 FCPF support

2016-05-27 Thread Kieran Bingham
/devicetree/bindings/media/renesas,fcp.txt These patches are based on Geert's renesas-drivers tree, and are pushed to a branch at g...@github.com:kbingham/linux.git renesas/fcpf for convenience. Kieran Bingham (4): v4l: Extend FCP compatible list to support the FDP dt-bindings: Update Renesas R-Car FCP

[PATCH 3/4] dt-bindings: Document Renesas R-Car FCP power-domains usage

2016-05-27 Thread Kieran Bingham
The example misses the power-domains usage, and documentation that the property is used by the node. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- Documentation/devicetree/bindings/media/renesas,fcp.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devi

[PATCH 4/4] arm64: dts: r8a7795: add FCPF device nodes

2016-05-27 Thread Kieran Bingham
Provide nodes for the FCP devices dedicated to the FDP device channels. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- arch/arm64/boot/dts/renesas/r8a7795.dtsi | 21 + 1 file changed, 21 insertions(+) diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi

Re: [PATCH 1/4] fcp: Extend FCP compatible list to support the FDP

2016-05-27 Thread Kieran Bingham
My apologies - I had a stale file in my patches folder :( This one had the wrong commit-shortlog, please ignore. -- Kieran On 27/05/16 18:19, Kieran Bingham wrote: > The FCP must be powered up for the FDP1 to function, even when the FDP1 > does not make use of the FCNL features.

[PATCH 1/4] v4l: Extend FCP compatible list to support the FDP

2016-05-27 Thread Kieran Bingham
The FCP must be powered up for the FDP1 to function, even when the FDP1 does not make use of the FCNL features. Extend the compatible list to allow us to use the power domain and runtime-pm support. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- drivers/media/platform/rcar-fcp.c |

[PATCH 1/4] fcp: Extend FCP compatible list to support the FDP

2016-05-27 Thread Kieran Bingham
The FCP must be powered up for the FDP1 to function, even when the FDP1 does not make use of the FCNL features. Extend the compatible list to allow us to use the power domain and runtime-pm support. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- drivers/media/platform/rcar-fcp.c |

[PATCH 2/4] dt-bindings: Update Renesas R-Car FCP DT binding

2016-05-27 Thread Kieran Bingham
The FCP driver, can also support the FCPF variant for FDP1 compatible processing. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- Documentation/devicetree/bindings/media/renesas,fcp.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Cc: devicet...@vger.kernel.org diff

Re: [PATCH] [media] fdp1: vb2_queue dev conversion

2016-07-19 Thread Kieran Bingham
> > /* M2M registration */ > @@ -2327,9 +2317,6 @@ release_m2m: > unreg_dev: > v4l2_device_unregister(>v4l2_dev); > > -vb2_allocator_rollback: > - vb2_dma_contig_cleanup_ctx(fdp1->alloc_ctx); > - > return ret; > } > > @@ -2340,7 +2327,6 @@ static int fdp1_remove(struct platform_device *pdev) > v4l2_m2m_release(fdp1->m2m_dev); > video_unregister_device(>vfd); > v4l2_device_unregister(>v4l2_dev); > - vb2_dma_contig_cleanup_ctx(fdp1->alloc_ctx); > pm_runtime_disable(>dev); > > return 0; > -- Regards Kieran Bingham -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] v4l: ioctl: Clear the v4l2_pix_format_mplane reserved field

2016-06-30 Thread Kieran Bingham
de pix_mp, not after it. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Tested-by: Kieran Bingham <kie...@bingham.xyz> > --- > drivers/media/v4l2-core/v4l2-ioctl.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > K

[PATCH] v4l: platform: Add Renesas R-Car FDP1 Driver

2016-06-30 Thread Kieran Bingham
The FDP1 driver performs advanced de-interlacing on a memory 2 memory based video stream, and supports conversion from YCbCr/YUV to RGB pixel formats Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- MAINTAINERS|9 + drivers/media/platform/Kconfig

[PATCH v2] v4l: platform: Add Renesas R-Car FDP1 Driver

2016-06-30 Thread Kieran Bingham
at the same time as converting interlaced content to progressive. Kieran Bingham (1): v4l: platform: Add Renesas R-Car FDP1 Driver MAINTAINERS|9 + drivers/media/platform/Kconfig | 13 + drivers/media/platform/Makefile|1 + drivers/media/platform

[PATCH v2 0/3] dt-bindings: RCar FCP and FDP1 bindings

2016-06-30 Thread Kieran Bingham
compatibles as we have a HW version register available to us in the hardware so we can detect at run-time what device version we are running on. Kieran Bingham (3): dt-bindings: Update Renesas R-Car FCP DT binding dt-bindings: Document Renesas R-Car FCP power-domains usage dt-bindings: Add Renesas R

[PATCH v2 2/3] dt-bindings: Document Renesas R-Car FCP power-domains usage

2016-06-30 Thread Kieran Bingham
The power domain must be specified to bring the device out of module standby. Document this in the bindings provided, so that new additions are not missed. Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- Documentation/devicetree/bindings/media/renesas,fcp.txt | 5 + 1 file chan

[PATCH v2 3/3] dt-bindings: Add Renesas R-Car FDP1 bindings

2016-06-30 Thread Kieran Bingham
The FDP1 is a de-interlacing module which converts interlaced video to progressive video. It is also capable of performing pixel format conversion between YCbCr/YUV formats and RGB formats. Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Signed-off-by: Kieran Bingha

[PATCH v2 1/3] dt-bindings: Update Renesas R-Car FCP DT binding

2016-06-30 Thread Kieran Bingham
The FCP driver can also support the FCPF variant for FDP1 compatible processing. Acked-by: Rob Herring <r...@kernel.org> Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> Signed-off-by: Kieran Bingham <kie...@bingham.xyz> --- Documentation/devicetree/bind

Re: [PATCH] v4l: vsp1: Fix WPF U/V order in 3-planar formats on Gen3

2017-02-20 Thread Kieran Bingham
memory formats > support") > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bing...@ideasonboard.com> > --- > drivers/media/platform/vsp1/vsp1_wpf.c | 9 + > 1 file changed, 9 insertions(+) >

[PATCH 0/8] v4l: vsp1: Partition phase developments

2017-02-10 Thread Kieran Bingham
s from one partition to the next. [0] https://www.mail-archive.com/linux-renesas-soc@vger.kernel.org/msg08631.html [1] https://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git#vsp1/pa-phases-2017-02-10 Kieran Bingham (8): v4l: vsp1: Provide UDS register updates v4l: vsp1: Track the

[PATCH 2/8] v4l: vsp1: Track the SRU entity in the pipeline

2017-02-10 Thread Kieran Bingham
The UDS and other entities are already tracked directly through the pipeline object. To follow the design pattern, and allow us to reference the SRU convert the usage of 'sru_found' Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platfor

[PATCH 3/8] v4l: vsp1: Correct image partition parameters

2017-02-10 Thread Kieran Bingham
The image partition algorithm operates on the image dimensions as input into the WPF entity. Correct this in the code, and document what defines the properties for the algorithm in the section header Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers

[PATCH 1/8] v4l: vsp1: Provide UDS register updates

2017-02-10 Thread Kieran Bingham
Provide register definitions required for UDS phase and partition algorithm support Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_regs.h | 14 ++ 1 file changed, 14 insertions(+) diff --git a/drivers/media/platfor

[PATCH 4/8] v4l: vsp1: Move partition rectangles to struct

2017-02-10 Thread Kieran Bingham
As we develop the partition algorithm, we need to store more information per partition to describe the phase and other parameters. To keep this data together, further abstract the existing v4l2_rect into a partition specific structure Signed-off-by: Kieran Bingham <kieran.bingham+r

[PATCH 7/8] v4l: vsp1: Calculate UDS phase for partitions

2017-02-10 Thread Kieran Bingham
To improve image quality when scaling using the UDS we need to correctly determine the start phase value for each partition window. Provide helper functions for calculating the phase, and write this value to the registers when used. Signed-off-by: Kieran Bingham <kieran.bingham+r

[PATCH 5/8] v4l: vsp1: Operate on partition struct data directly

2017-02-10 Thread Kieran Bingham
When generating the partition windows, operate directly on the partition struct rather than copying and duplicating the processed data Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_video.c | 43 -

[PATCH 8/8] v4l: vsp1: Implement left edge partition algorithm overlap

2017-02-10 Thread Kieran Bingham
Increase the overlap on the left edge to allow a margin to provide better image scaling Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_rpf.c | 7 +- drivers/media/platform/vsp1/vsp1_uds.c | 39 --- 2

[PATCH 6/8] v4l: vsp1: Allow entities to participate in the partition algorithm

2017-02-10 Thread Kieran Bingham
to it's predecessor in the pipeline. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_entity.h | 8 - drivers/media/platform/vsp1/vsp1_pipe.c | 22 - drivers/media/platform/vsp1/vsp1_pipe.h

Re: Patch status in patchwork

2017-02-10 Thread Kieran Bingham
Hi Avraham, On 08/02/17 12:11, Avraham Shukron wrote: > Hi! > > I submitted a patch which is now at v3 already. > In patchwork they appear separated / unrelated. > 1. Is there a way to tell patchwork that they are all actually iterations >of the same patch? I don't believe this is possible

Re: [PATCH] v4l: vsp1: Disable HSV formats on Gen3 hardware

2017-03-02 Thread Kieran Bingham
off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> > --- > drivers/media/platform/vsp1/vsp1_pipe.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/dr

Re: [PATCH v3 00/10] v4l: platform: Add Renesas R-Car FDP1 Driver

2016-09-08 Thread Kieran Bingham
experimental > and doesn't fix any known bug. I've included the patch in the series to get > feedback on whether this is a good idea. > > Kieran, I noticed that your patches are authored by > > Kieran Bingham <kie...@ksquared.org.uk> > > Is that correct o

Re: [PATCH v3 02/10] v4l: ctrls: Add deinterlacing mode control

2016-09-08 Thread Kieran Bingham
inchart+rene...@ideasonboard.com> Reviewed-by: Kieran Bingham <kie...@bingham.xyz> > --- > Documentation/media/uapi/v4l/extended-controls.rst | 4 > drivers/media/v4l2-core/v4l2-ctrls.c | 2 ++ > include/uapi/linux/v4l2-controls.h | 1 +

Re: [PATCH v3 05/10] v4l: fdp1: vb2_queue dev conversion

2016-09-08 Thread Kieran Bingham
p1_queue_setup(), > - Convert the FDP1 driver to use the new vb2_queue dev field, cfr. > commit 53ddcc683faef8c7 ("[media] media/platform: convert drivers to > use the new vb2_queue dev field"). > > Signed-off-by: Geert Uytterhoeven <geert+rene...@glider.be>

Re: [PATCH v3 09/10] v4l: fdp1: Fix field validation when preparing buffer

2016-09-11 Thread Kieran Bingham
tainly isn't a bad thing to verify they are what we were told they would be :D -- Reviewed-by: Kieran Bingham <kie...@bingham.xyz> > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com> > --- > drivers/media/platform/rcar_fdp1.c | 40 > +

Re: [PATCH v3 10/10] v4l: fdp1: Store buffer information in vb2 buffer

2016-09-11 Thread Kieran Bingham
, and preparing the buffers early is clearly more elegant and less prone to failure. Thanks Kieran ... Obligatory over tagging Acked-by: Kieran Bingham <kie...@bingham.xyz> Reviewed-by: Kieran Bingham <kie...@bingham.xyz> On 07/09/16 23:25, Laurent Pinchart wrote: > The struct fdp1_b

Re: [PATCH v3 08/10] v4l: fdp1: Rewrite format setting code

2016-09-11 Thread Kieran Bingham
I've gone through this one as well, and certainly seems like some much better approaches in there. I can't find anything to fault it. Acked-by: Kieran Bingham <kie...@bingham.xyz> Reviewed-by: Kieran Bingham <kie...@bingham.xyz> Thanks again, Kieran On 07/09/16 23:25, Laurent Pi

Re: [PATCH v3 07/10] v4l: fdp1: Remove unused struct fdp1_v4l2_buffer

2016-09-09 Thread Kieran Bingham
On 07/09/16 23:25, Laurent Pinchart wrote: > The structure is not used, remove it. Ahh yes, looks like a left over from my first attempt at serialising input fields. Reviewed-by: Kieran Bingham <kie...@bingham.xyz> > Signed-off-by: Laurent Pinchart <laurent.pinchart+rene...@i

Re: [PATCH 04/13] v4l: vsp1: Repair race between frame end and qbuf handler

2016-09-14 Thread Kieran Bingham
On 14/09/16 00:16, Laurent Pinchart wrote: > From: Kieran Bingham <kieran+rene...@bingham.xyz> > > The frame-end function releases and completes the buffers on the input > and output entities of the pipe before marking the pipe->state as > 'STOPPED'. This introduces a ra

[PATCH] v4l: vsp1: Prevent commencing pipelines before they are setup

2016-11-11 Thread Kieran Bingham
ned-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- I considered a few options to fix this issue. If anyone disagrees with my reasoning, and believes one of the below approaches should be used, let me know and I'll rework the patch. A) Moving the vsp1_video_pipeline_r

Re: [PATCH v4 4/4] arm64: dts: renesas: r8a7796: Add FDP1 instance

2016-10-24 Thread Kieran Bingham
t;0 0xfe94 0 0x2400>; > + interrupts = ; > + clocks = < CPG_MOD 119>; > + power-domains = < R8A7796_PD_A3VC>; > + renesas,fcp = <>; > + }; > }; > }; >

Re: [PATCH v4 3/4] v4l: Add Renesas R-Car FDP1 Driver

2016-10-24 Thread Kieran Bingham
respin. -- Regards Kieran On 24/10/16 10:03, Laurent Pinchart wrote: > From: Kieran Bingham <kieran+rene...@bingham.xyz> > > The FDP1 driver performs advanced de-interlacing on a memory 2 memory > based video stream, and supports conversion from YCbCr/YUV > to RGB pixel fo

Re: [PATCH] v4l: vsp1: Prevent commencing pipelines before they are setup

2016-11-23 Thread Kieran Bingham
the issue repaired here. -- Regards Kieran On 11/11/16 10:31, Kieran Bingham wrote: > With multiple inputs through the BRU it is feasible for the streams to > race each other at stream-on. In the case of the video pipelines, this > can present two serious issues. > > 1) A null-derefere

Re: [RFC 3/3] v4l: vsp1: Provide a writeback video device

2016-11-01 Thread Kieran Bingham
Looks like I forgot to run checkpatch here, and it picked up a few things. Please disregard them in your review, and they will be fixed for next version. On 27/10/16 15:01, Kieran Bingham wrote: > When the VSP1 is used in an active display pipeline, the output of the > WPF can supply t

[RFC 3/3] v4l: vsp1: Provide a writeback video device

2016-10-27 Thread Kieran Bingham
. The source will be able to perform pixel format conversion, but not rescaling, and as such the output from the memory node will always be of the same dimensions as the display output. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/

[RFC 1/3] Revert "[media] v4l: vsp1: Supply frames to the DU continuously"

2016-10-27 Thread Kieran Bingham
it (leaving the existing display pipeline unharmed) otherwise. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_video.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/d

[RFC 2/3] v4l: vsp1: allow entities to have multiple source pads

2016-10-27 Thread Kieran Bingham
of the entity. Configured in this mode, the WPF will output to both the LIF, and to a memory (V4L2 video) device. Support this feature by extending vsp1_entity_init() to specify the number of source and sink pads. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.

[RFC 0/3] vsp1 writeback prototype

2016-10-27 Thread Kieran Bingham
Video node from the VSP-D. On Salvator-H3, on renesas-drivers-2016-10-25-v4.9-rc2 this is active at /dev/video28 Kieran Bingham (3): Revert "[media] v4l: vsp1: Supply frames to the DU continuously" v4l: vsp1: allow entities to have multiple source pads v4l: vsp1: Provide a writeback vi

Re: [RFC 2/3] v4l: vsp1: allow entities to have multiple source pads

2016-11-03 Thread Kieran Bingham
Hi Laurent, On 02/11/16 23:59, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Thursday 27 Oct 2016 15:01:24 Kieran Bingham wrote: >> The upcoming writeback feature of the VSP1 WPF, allows the active output >> of the DU to be written back

[PATCHv2] v4l: vsp1: Provide a writeback video device

2016-11-03 Thread Kieran Bingham
. The source will be able to perform pixel format conversion, but not rescaling, and as such the output from the memory node will always be of the same dimensions as the display output. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- With the patch "[media

[PATCHv2 0/2] vsp1 writeback prototype

2016-11-04 Thread Kieran Bingham
/VSP1 specific. Kieran Bingham (2): Revert "[media] v4l: vsp1: Supply frames to the DU continuously" v4l: vsp1: Provide a writeback video device drivers/media/platform/vsp1/vsp1.h | 1 + drivers/media/platform/vsp1/vsp1_drm.c | 19 drivers/media/platform/vsp1/

[PATCHv2 1/2] Revert "[media] v4l: vsp1: Supply frames to the DU continuously"

2016-11-04 Thread Kieran Bingham
eback mode if there is an output buffer, or disable it (leaving the existing display pipeline unharmed) otherwise. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_video.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/driver

[PATCHv2 2/2] v4l: vsp1: Provide a writeback video device

2016-11-04 Thread Kieran Bingham
. The source will be able to perform pixel format conversion, but not rescaling, and as such the output from the memory node will always be of the same dimensions as the display output. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- Changes since RFC

[PATCH 3/4] v4l: vsp1: Calculate partition sizes at stream start.

2016-11-04 Thread Kieran Bingham
the partition sizes into this table. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_pipe.h | 6 ++ drivers/media/platform/vsp1/vsp1_video.c | 8 ++-- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/d

[PATCH 1/4] v4l: vsp1: Implement partition algorithm restrictions

2016-11-04 Thread Kieran Bingham
, the use of an SRU will always engage the partition algorithm, therefore we must always ensure the restrictions are met on Gen3 hardware utilising an SRU in the pipeline. A pipeline with an SRU connected after the UDS will disable any scaling features of the SRU. Signed-off-by: Kieran Bingham

[PATCH 4/4] v4l: vsp1: Remove redundant context variables

2016-11-04 Thread Kieran Bingham
. Utilise local variables for the processing as required. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_pipe.h | 4 drivers/media/platform/vsp1/vsp1_video.c | 19 +-- 2 files changed, 9 insertions(+), 14 del

[PATCH 2/4] v4l: vsp1: Move vsp1_video_pipeline_setup_partitions() function

2016-11-04 Thread Kieran Bingham
the function without any code change. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_video.c | 74 1 file changed, 37 insertions(+), 37 deletions(-) diff --git a/drivers/media/platform/vsp1/vsp1_vide

[PATCH 0/4] vsp1 partition algorithm improvements

2016-11-04 Thread Kieran Bingham
algorithm on Gen3 hardware. Patches 2,3 and 4 clean up the calculation of the partition sizes such that they are only calculated once at streamon - and the partition windows are stored in the vsp1_pipeline object. Kieran Bingham (4): v4l: vsp1: Implement partition algorithm restrictions v4l: vsp1

Re: [PATCH 2/4] v4l: vsp1: Refactor video pipeline configuration

2016-12-10 Thread Kieran Bingham
Reviewing my own patch here, as I've just seen something... On 06/12/16 09:35, Kieran Bingham wrote: > With multiple inputs through the BRU it is feasible for the streams to > race each other at stream-on. In the case of the video pipelines, this > can present two serious issues. >

Re: [PATCHv3 RFC 4/4] media: Catch null pipes on pipeline stop

2016-12-14 Thread Kieran Bingham
Hi Sakari, On 14/12/16 07:28, Sakari Ailus wrote: > Hi Kieran, > > On Tue, Dec 13, 2016 at 05:59:44PM +0000, Kieran Bingham wrote: >> media_entity_pipeline_stop() can be called through error paths with a >> NULL entity pipe object. In this instance, stopping is a no-op

[PATCHv3 2/4] v4l: vsp1: Refactor video pipeline configuration

2016-12-13 Thread Kieran Bingham
ent side effect of this, by specifying that the configuration has been lost during suspend/resume actions - the vsp1_video_pipeline_run() call can re-initialise pipelines when necessary thus repairing resume actions for active m2m pipelines. Signed-off-by: Kieran Bingham <kieran.bingha

[PATCHv3 RFC 4/4] media: Catch null pipes on pipeline stop

2016-12-13 Thread Kieran Bingham
media_entity_pipeline_stop() can be called through error paths with a NULL entity pipe object. In this instance, stopping is a no-op, so simply return without any action Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- I've marked this patch as RFC, although if

[PATCHv3 3/4] v4l: vsp1: Use local display lists and remove global pipe->dl

2016-12-13 Thread Kieran Bingham
dl is set during the atomic begin hook, but it is not utilised until the flush. Moving this should do no harm. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_drm.c | 20 +++--- drivers/media/platform/vsp1/vsp1_pipe.h |

[PATCHv3 1/4] v4l: vsp1: Move vsp1_video_setup_pipeline()

2016-12-13 Thread Kieran Bingham
Move the static vsp1_video_setup_pipeline() function in preparation for the callee updates so that the vsp1_video_pipeline_run() call can configure pipelines following suspend resume actions. This commit is just a code move for clarity performing no functional change. Signed-off-by: Kieran

[PATCHv3 0/4] v4l: vsp1: Fix suspend/resume and race on M2M pipelines

2016-12-13 Thread Kieran Bingham
U race in a single change v1: - Original pipeline configuration rework Kieran Bingham (4): v4l: vsp1: Move vsp1_video_setup_pipeline() v4l: vsp1: Refactor video pipeline configuration v4l: vsp1: Use local display lists and remove global pipe->dl media: Catch null pipes on pipe

Re: [PATCHv3 RFC 4/4] media: Catch null pipes on pipeline stop

2016-12-14 Thread Kieran Bingham
Hi Sakari, On 14/12/16 12:43, Sakari Ailus wrote: > Hi Kieran, > > On Wed, Dec 14, 2016 at 12:27:37PM +0000, Kieran Bingham wrote: >> Hi Sakari, >> >> On 14/12/16 07:28, Sakari Ailus wrote: >>> Hi Kieran, >>> >>> On Tue,

Re: [PATCHv3 RFC 4/4] media: Catch null pipes on pipeline stop

2016-12-14 Thread Kieran Bingham
at this. -- Regards Kieran On 13/12/16 17:59, Kieran Bingham wrote: > media_entity_pipeline_stop() can be called through error paths with a > NULL entity pipe object. In this instance, stopping is a no-op, so > simply return without any action > > Signed-off-by: Kieran Bingham <k

Re: [PATCHv3 2/4] v4l: vsp1: Refactor video pipeline configuration

2016-12-15 Thread Kieran Bingham
Hi Laurent, On 14/12/16 16:30, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Tuesday 13 Dec 2016 17:59:42 Kieran Bingham wrote: >> With multiple inputs through the BRU it is feasible for the streams to >> race each other at stream-on. &g

[PATCH 0/4] v4l: vsp1: Fix suspend/resume and race on M2M pipelines

2016-12-06 Thread Kieran Bingham
nsider it as blocking for the first three patches of this series. Kieran Bingham (4): v4l: vsp1: Move vsp1_video_setup_pipeline() v4l: vsp1: Refactor video pipeline configuration v4l: vsp1: Use local display lists and remove global pipe->dl media: Catch null pipes on pipeline stop

[PATCH 3/4] v4l: vsp1: Use local display lists and remove global pipe->dl

2016-12-06 Thread Kieran Bingham
dl is set during the atomic begin hook, but it is not utilised until the flush. Moving this should do no harm. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_drm.c | 20 +++--- drivers/media/platform/vsp1/vsp1_pipe.h |

[PATCH 1/4] v4l: vsp1: Move vsp1_video_setup_pipeline()

2016-12-06 Thread Kieran Bingham
Move the static vsp1_video_setup_pipeline() function in preparation for the callee updates so that the vsp1_video_pipeline_run() call can configure pipelines following suspend resume actions. This commit is just a code move for clarity performing no functional change. Signed-off-by: Kieran

[PATCH 2/4] v4l: vsp1: Refactor video pipeline configuration

2016-12-06 Thread Kieran Bingham
ent side effect of this, by specifying that the configuration has been lost during suspend/resume actions - the vsp1_video_pipeline_run() call can re-initialise pipelines when necessary thus repairing resume actions for active m2m pipelines. Signed-off-by: Kieran Bingham <kieran.bingha

[PATCH RFC 4/4] media: Catch null pipes on pipeline stop

2016-12-06 Thread Kieran Bingham
media_entity_pipeline_stop() can be called through error paths with a NULL entity pipe object. In this instance, stopping is a no-op, so simply return without any action Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- I've marked this patch as RFC, although if

[PATCH] media: entity: Catch unbalanced media_pipeline_stop calls

2017-01-03 Thread Kieran Bingham
nts, with a check on NULL pipe elements instead, as this is the symptom of unbalanced media_pipeline_stop calls. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/media-entity.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/driv

Re: [PATCH] media: entity: Catch unbalanced media_pipeline_stop calls

2017-01-03 Thread Kieran Bingham
On 03/01/17 13:36, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Tuesday 03 Jan 2017 13:12:11 Kieran Bingham wrote: >> Drivers must not perform unbalanced calls to stop the entity pipeline, >> however if they do they will fault in the core m

[PATCH v4 0/4] v4l: vsp1: Fix suspend/resume and race on M2M pipelines

2017-01-06 Thread Kieran Bingham
e_init to vsp1_reset_wpf() - Clean up flag dereferencing with a local struct * v2: - Refactor video pipeline configuration implementation to solve both suspend resume and the VSP BRU race in a single change v1: - Original pipeline configuration rework Kieran Bingham (4): v4l: vsp1: Prevent multiple st

[PATCH v4 4/4] v4l: vsp1: Remove redundant pipe->dl usage from drm

2017-01-06 Thread Kieran Bingham
The pipe->dl is used only inside vsp1_du_atomic_flush(), and can be obtained and stored locally to simplify the code. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_drm.c | 20 ++-- drivers/media/plat

[PATCH v4 3/4] v4l: vsp1: Repair suspend resume operations for video pipelines

2017-01-06 Thread Kieran Bingham
When a suspend/resume action is taken, the pipeline is reset and never reconfigured. To correct this, we establish a new flag pipe->configured and utilise this to establish when we write a full configuration set to the current display list. Signed-off-by: Kieran Bingham <kieran.bingha

[PATCH v4 1/4] v4l: vsp1: Prevent multiple streamon race commencing pipeline early

2017-01-06 Thread Kieran Bingham
ere a display list is committed without having called vsp1_video_setup_pipeline() first Repair this issue, by ensuring that only the stream which configures the pipeline is able to start it. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- v4: - Revert and re

[PATCH v4 2/4] v4l: vsp1: Move vsp1_video_setup_pipeline()

2017-01-06 Thread Kieran Bingham
Move the static vsp1_video_setup_pipeline() function in preparation for the callee updates so that the vsp1_video_pipeline_run() call can configure pipelines following suspend resume actions. This commit is just a code move for clarity performing no functional change. Signed-off-by: Kieran

Re: [PATCHv3 2/4] v4l: vsp1: Refactor video pipeline configuration

2017-01-06 Thread Kieran Bingham
Hi Laurent, I've been reworking this series to split things out and adapt for the comments you've provided, but I have the following queries outstanding: On 15/12/16 11:50, Kieran Bingham wrote: > Hi Laurent, > > On 14/12/16 16:30, Laurent Pinchart wrote: >> Hi Kieran,

Re: [PATCH 1/1] [media] v4l: rcar_fdp1: use %4.4s to format a 4-byte string

2016-12-28 Thread Kieran Bingham
is not zero). > > Add ".4" to the format specifier to limit the number of printed > characters to four. The resulting format specifier "%4.4s" is also used > by other media drivers to print pixelformat value. > > Signed-off-by: Nicolas Iooss <nicolas.i

[PATCH] uvcvideo: don't recode timespec_sub

2017-04-03 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> The statistics function subtracts two timespecs manually. A helper is provided by the kernel to do this. Replace the implementation, using the helper. Signed-off-by: Kieran Bingham <kieran.bing...@ideasonboard.com> --- drive

[PATCH] uvcvideo: Fix empty packet statistic

2017-04-03 Thread Kieran Bingham
From: Kieran Bingham <kieran.bing...@ideasonboard.com> The frame counters are inadvertently counting packets with content as empty. Fix it by correcting the logic expression Fixes: 7bc5edb00bbd [media] uvcvideo: Extract video stream statistics Signed-off-by: Kieran Bingham <ki

[PATCH v2 0/3] RCAR-DU, VSP1: Prevent pre-emptive frame flips on VSP1-DRM pipelines

2017-03-03 Thread Kieran Bingham
flips at the end of VSP processing. These patches have been tested by introducing artificial delays in the commit code paths and verifying that no visual tearing or flickering occurs. Manual start/stop testing has also been performed Kieran Bingham (3): v4l: vsp1: extend VSP1 module

[PATCH v2 1/3] v4l: vsp1: extend VSP1 module API to allow DRM callbacks

2017-03-03 Thread Kieran Bingham
to be registered within the VSP DRM interface. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- v2: - vsp1_du_setup_lif() uses config structure to set callbacks - vsp1_du_pipeline_frame_end() moved to interrupt section - vsp1_du_pipeline_frame_end regi

[PATCH v2 3/3] drm: rcar-du: Register a completion callback with VSP1

2017-03-03 Thread Kieran Bingham
when the full display pipeline has completed for the frame. Signed-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- v2: - Commit message completely re-worded for patch re-work. - drm_crtc_handle_vblank() re-instated in event of rcrtc->pending - removed passing of un

[PATCH v2 2/3] v4l: vsp1: Postpone page flip in event of display list race

2017-03-03 Thread Kieran Bingham
-off-by: Kieran Bingham <kieran.bingham+rene...@ideasonboard.com> --- drivers/media/platform/vsp1/vsp1_dl.c | 9 +++-- drivers/media/platform/vsp1/vsp1_dl.h | 2 +- drivers/media/platform/vsp1/vsp1_drm.c | 4 +++- drivers/media/platform/vsp1/vsp1_pipe.c | 6 +- drivers/media/pl

Re: [PATCH 1/4] v4l: vsp1: Implement partition algorithm restrictions

2017-03-06 Thread Kieran Bingham
Hi Laurent, Morimoto-san, On 06/03/17 15:16, Laurent Pinchart wrote: > Hi Morimoto-san, > > On Monday 06 Mar 2017 06:17:47 Kuninori Morimoto wrote: >> Hi Laurent, Kieran >> I asked it to HW team. Please wait >> >> I'm still waiting from HW team's response, but can you check >>

Re: [PATCH v3 2/3] v4l: vsp1: Extend VSP1 module API to allow DRM callbacks

2017-03-05 Thread Kieran Bingham
Hi Laurent, On 05/03/17 21:58, Laurent Pinchart wrote: > Hi Kieran, > > Thank you for the patch. > > On Sunday 05 Mar 2017 16:00:03 Kieran Bingham wrote: >> To be able to perform page flips in DRM without flicker we need to be >> able to notify the rcar-du module whe

  1   2   3   4   5   6   7   8   >