Re: [PATCH 22/57] [media] davinci: don't break long lines

2016-10-18 Thread Lad, Prabhakar
t the source code. So, join those continuation > lines. > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.o

Re: [PATCH v2 54/58] i2c: don't break long lines

2016-10-19 Thread Lad, Prabhakar
$next=""; > } else { > if (m/\"$/) { > if (!m/\\n\"$/) { > $next=$_; > next; > } > } > } > print $_; > } > > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 00/34] [media] DaVinci-Video Processing: Fine-tuning for several function implementations

2016-10-23 Thread Lad, Prabhakar
88 - > drivers/media/platform/davinci/vpif_capture.c | 28 ++++ > drivers/media/platform/davinci/vpif_display.c | 30 - > 4 files changed, 109 insertions(+), 130 deletions(-) > Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad -- To unsubscribe fro

Re: [PATCH v2 3/8] media: v4l2-async: simplify v4l2_async_subdev structure

2017-12-20 Thread Lad, Prabhakar
gt; > Acked-by: Sylwester Nawrocki > Acked-by: Benoit Parrot > Acked-by: Alexandre Belloni > Acked-by: Sakari Ailus > Acked-by: Philipp Zabel > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/platform/am437x/am437x-vpfe.c| 6 +++--- For above: Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad

Re: [PATCH 7/7] staging/media: set device_caps in struct video_device

2019-06-05 Thread Lad, Prabhakar
se this, so convert > all staging/media drivers in this patch. > > Signed-off-by: Hans Verkuil > Cc: Laurent Pinchart > Cc: Prabhakar Lad > --- > drivers/staging/media/bcm2048/radio-bcm2048.c | 7 ++- > drivers/staging/media/davinci_vpfe/vpfe_video.c | 9 +++

Re: [PATCH 01/16] am437x/davinci: set device_caps in struct video_device

2019-07-01 Thread Lad, Prabhakar
/media/platform/davinci/vpif_capture.c | 3 +-- > drivers/media/platform/davinci/vpif_display.c | 3 +-- > 5 files changed, 6 insertions(+), 12 deletions(-) > Acked-by: Lad, Prabhakar Cheers, Prabhakar Lad > diff --git a/drivers/media/platform/am437x/am437x-vpfe.c > b/drivers

Re: [PATCH 5/5] media/platform: don't set description in ENUM_FMT

2019-07-01 Thread Lad, Prabhakar
drivers/media/platform/am437x/am437x-vpfe.c | 18 ++--- > drivers/media/platform/davinci/vpbe_display.c | 14 ++ > drivers/media/platform/davinci/vpif_capture.c | 11 ++-- > drivers/media/platform/davinci/vpif_display.c | 4 --- For the above, Acked-by: Lad, Prabhakar Che

Re: [PATCH] media/i2c: don't return ENOTTY if SUBDEV_API is not set

2019-07-19 Thread Lad, Prabhakar
57584/) > when > working on the via-camera driver, but the same pattern is found in other > drivers, > and those are fixed in this patch. > --- > drivers/media/i2c/mt9m111.c | 2 +- > drivers/media/i2c/ov2640.c | 2 +- > drivers/media/i2c/ov2659.c | 4 +--- for ov2659

Re: [RFC] Removal of drivers/staging/media/davinci_vpfe

2019-07-23 Thread Lad, Prabhakar
Hi Hans, On Tue, Jul 23, 2019 at 9:48 AM Hans Verkuil wrote: > > +Laurent Pinchart > > On 7/23/19 10:46 AM, Hans Verkuil wrote: > > Hi Prabhakar, > > > > This staging driver is now almost 7 years old, but hasn't seen any real > > development for a long time. > > > > I think it is time to remove i

Re: [PATCH] am437x: remove unused struct vpfe_pixel_format

2019-07-24 Thread Lad, Prabhakar
latform/am437x/am437x-vpfe.h > index 17d7aa426788..4678285f34c6 100644 > --- a/drivers/media/platform/am437x/am437x-vpfe.h > +++ b/drivers/media/platform/am437x/am437x-vpfe.h Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad > @@ -65,12 +65,6 @@ struct vpfe_hw_if_param { > #def

Re: [PATCH] davinci/vpfe_capture.c: drop unused format descriptions

2019-07-24 Thread Lad, Prabhakar
i/vpfe_capture.c > b/drivers/media/platform/davinci/vpfe_capture.c Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad > index 852fc357e19d..916ed743d716 100644 > --- a/drivers/media/platform/davinci/vpfe_capture.c > +++ b/drivers/media/platform/davinci/vpfe_capture.c > @@ -1

Re: [PATCH v3] media: davinci vpbe: array underflow in vpbe_enum_outputs()

2018-05-29 Thread Lad, Prabhakar
dia] davinci vpbe: VPBE display driver") > Signed-off-by: Dan Carpenter > --- > v2: fix it a different way > v3: change everything to unsigned because that's the right thing to do > and looks nicer. > Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad > dif

Re: [PATCH 12/14] media: include: fix several typos

2019-02-19 Thread Lad, Prabhakar
4 ++-- > include/media/davinci/dm644x_ccdc.h| 2 +- For the above, Reviewed-by: Lad, Prabhakar Regards, Prabhakar

Re: [PATCH 1/2] media: ov2659: make S_FMT ioctl succeed even if requested format doesn't match

2019-04-04 Thread Lad, Prabhakar
> Drivers must not return an error solely because the requested format > doesn't match the device capabilities. They must instead modify the > format to match what the hardware can provide. > > So select default format code and return success in that case. > > This is detected

Re: [PATCH 2/2] media: ov2659: fix unbalanced mutex_lock/unlock

2019-04-04 Thread Lad, Prabhakar
Hi Akinobu, Thanks for the patch. On Sat, Mar 30, 2019 at 2:01 PM Akinobu Mita wrote: > > Avoid returning with mutex locked. > > Fixes: fa8cb6444c32 ("[media] ov2659: Don't depend on subdev API") > Cc: "Lad, Prabhakar" > Cc: Sakari Ailus > Cc: M

Re: [PATCH] media: i2c: ov2659: speedup probe if no device connected

2016-01-05 Thread Lad, Prabhakar
B and NACKs > are ignored in this case). > > Let's fix that by checking the chip version first and start > initialization only if it's supported. > > Cc: Benoit Parrot > Signed-off-by: Grygorii Strashko Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad > --- &g

Re: [PATCH][davinci] ccdc_update_raw_params() frees the wrong thing

2016-01-05 Thread Lad, Prabhakar
(). ccdc_close() does that properly, but > ccdc_update_raw_params() doesn't. > > Signed-off-by: Al Viro > Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad > diff --git a/drivers/media/platform/davinci/dm644x_ccdc.c > b/drivers/media/platform/davinci/dm644x_ccdc.c > inde

Re: [PATCH] media: use unsigned for pad index

2016-01-05 Thread Lad, Prabhakar
f.c | 2 +- > drivers/staging/media/davinci_vpfe/dm365_isif.c| 2 +- > drivers/staging/media/davinci_vpfe/dm365_resizer.c | 2 +- For the above: Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media&quo

Re: [PATCH][davinci] ccdc_update_raw_params() frees the wrong thing

2016-01-06 Thread Lad, Prabhakar
On Wed, Jan 6, 2016 at 4:34 PM, Al Viro wrote: > On Tue, Jan 05, 2016 at 05:37:06PM +0000, Lad, Prabhakar wrote: >> On Sun, Dec 13, 2015 at 12:32 AM, Al Viro wrote: >> > Passing a physical address to free_pages() is a bad idea. >> > config_params->faul

Re: [PATCH 4/8] media: Rename is_media_entity_v4l2_io to is_media_entity_v4l2_video_device

2016-03-07 Thread Lad, Prabhakar
ame it accordingly, we will introduce a more > specific is_media_entity_v4l2_io() check when needed. > > Signed-off-by: Laurent Pinchart Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a messa

Re: [patch] [media] am437x-vpfe: fix an uninitialized variable bug

2016-03-15 Thread Lad, Prabhakar
d-off-by: Dan Carpenter > Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] [media] am437x-vfpe: fix typo in vpfe_get_app_input_index

2016-03-15 Thread Lad, Prabhakar
t's > clear that the comparison was meant to compare the iterator > to the current subdev instead, as we do in the line above. > > Signed-off-by: Arnd Bergmann > Fixes: d37232390fd4 ("[media] media: am437x-vpfe: match the OF node/i2c addr > instead of name") >

Re: [PATCH] [media] media: am437x-vpfe: ensure ret is initialized

2016-03-22 Thread Lad, Prabhakar
Hi Colin, On Mon, Mar 21, 2016 at 11:32 PM, Colin King wrote: > From: Colin Ian King > > ret should be initialized to 0; for example if pfe->fmt.fmt.pix.field > is V4L2_FIELD_NONE then ret will contain garbage from the > uninitialized state causing garbage to be returned if it is non-zero. > Tha

Re: [PATCH v6 0/2] media: Add entity types

2016-03-26 Thread Lad, Prabhakar
is_media_entity_v4l2_video_device > Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCHv4 07/13] media/platform: convert drivers to use the new vb2_queue dev field

2016-04-24 Thread Lad, Prabhakar
Hi Hans, Thanks for the patch. On Sat, Apr 23, 2016 at 12:03 PM, Hans Verkuil wrote: > From: Hans Verkuil > > Stop using alloc_ctx and just fill in the device pointer. > > Signed-off-by: Hans Verkuil > Cc: "Lad, Prabhakar" > Cc: Scott Jiang > Acked-by: Phi

Re: [PATCHv3 05/12] staging/media: convert drivers to use the new vb2_queue dev field

2016-04-24 Thread Lad, Prabhakar
Hi Hans, Thanks for the patch. On Fri, Apr 22, 2016 at 9:38 AM, Hans Verkuil wrote: > From: Hans Verkuil > > Stop using alloc_ctx and just fill in the device pointer. > > Signed-off-by: Hans Verkuil > Cc: "Lad, Prabhakar" > Cc: Laurent Pinchart > --- >

Re: [PATCHv4 06/13] staging/media: convert drivers to use the new vb2_queue dev field

2016-04-24 Thread Lad, Prabhakar
Hi Hans, On Sat, Apr 23, 2016 at 12:03 PM, Hans Verkuil wrote: > From: Hans Verkuil > > Stop using alloc_ctx and just fill in the device pointer. > > Signed-off-by: Hans Verkuil > Cc: "Lad, Prabhakar" > Reviewed-by: Laurent Pinchart Acked-by: Lad, Prab

Re: [PATCH 1/2] [media] tvp5150: return I2C write operation failure to callers

2016-04-24 Thread Lad, Prabhakar
and also because it's called > in a lot of places, so making inline is in fact counter productive > since it makes the kernel image size to be much bigger (~16 KiB). > > Signed-off-by: Javier Martinez Canillas Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad > --- > >

Re: [PATCH 2/2] [media] tvp5150: propagate I2C write error in .s_register callback

2016-04-24 Thread Lad, Prabhakar
On Fri, Apr 15, 2016 at 2:00 AM, Javier Martinez Canillas wrote: > The tvp5150_write() function can fail so don't return 0 unconditionally > in tvp5150_s_register() but propagate what's returned by tvp5150_write(). > > Signed-off-by: Javier Martinez Canillas > Acked-by

Re: [PATCH v2 2/4] [media] davinci: vpif_capture: get subdevs from DT when available

2017-06-09 Thread Lad, Prabhakar
Hi Kevin, Thanks for the patch. On Fri, Jun 9, 2017 at 2:01 AM, Kevin Hilman wrote: > On Wed, Jun 7, 2017 at 11:29 PM, Hans Verkuil wrote: >> On 07/06/17 01:37, Kevin Hilman wrote: >>> Enable getting of subdevs from DT ports and endpoints. >>> >>> The _get_pdata() function was larely inspired

Re: [PATCH v2] [media] davinci: vpif: adaptions for DT support

2017-06-20 Thread Lad, Prabhakar
defined for its subdevs. Therefore, vpif_probe() > checks for the presence of endpoints, and if detected manually creates > the platform_devices for the display and capture platform_drivers. > > [1] Documentation/devicetree/bindings/media/ti,da850-vpif.txt > > Signed-off-by: Kevin Hilman Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad

Re: [PATCH] [media] davinci/dm644x: work around ccdc_update_raw_params trainwreck

2017-06-20 Thread Lad, Prabhakar
Hi Arnd, Thanks for the patch. On Fri, Jun 9, 2017 at 10:36 PM, Arnd Bergmann wrote: > Now that the davinci drivers can be enabled in compile tests on other > architectures, I ran into this warning on a 64-bit build: > > drivers/media/platform/davinci/dm644x_ccdc.c: In function > 'ccdc_update_r

Re: [PATCH] [media] davinci/dm644x: work around ccdc_update_raw_params trainwreck

2017-06-30 Thread Lad, Prabhakar
Hi Arnd, On Tue, Jun 27, 2017 at 12:08 PM, Arnd Bergmann wrote: > On Tue, Jun 27, 2017 at 12:13 PM, Sekhar Nori wrote: >> On Tuesday 20 June 2017 06:36 PM, Lad, Prabhakar wrote: >>> Hi Arnd, >>> >>> Thanks for the patch. >>> >>> On Fri, J

Re: [PATCH] [media] media/platform: add const to v4l2_file_operations structures

2017-06-30 Thread Lad, Prabhakar
should go below --- (after the signoff) so that its not the part of commit message. > Signed-off-by: Bhumika Goyal > --- > drivers/media/platform/davinci/vpbe_display.c | 2 +- > drivers/media/platform/davinci/vpif_capture.c | 2 +- For above: Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad

Re: [PATCH] media: platform: davinci: drop VPFE_CMD_S_CCDC_RAW_PARAMS

2017-06-30 Thread Lad, Prabhakar
Hi Arnd, On Fri, Jun 30, 2017 at 11:03 AM, Arnd Bergmann wrote: > On Fri, Jun 30, 2017 at 11:32 AM, Prabhakar > wrote: >> From: "Lad, Prabhakar" >> >> For dm355 and dm644x the vpfe driver provided a ioctl to >> configure the raw bayer config usin

Re: [PATCH] media: platform: constify vb2_ops structures

2017-01-25 Thread Lad, Prabhakar
Hi, Thanks for the patch. On Sat, Jan 21, 2017 at 9:29 AM, Bhumika Goyal wrote: > Declare vb2_ops structures as const as they are only stored in > the ops field of a vb2_queue structure. This field is of type > const, so vb2_ops structures having same properties can be made > const too. > Done u

Re: [PATCH] media: vpif: use a configurable i2c_adapter_id for vpif display

2017-03-07 Thread Lad, Prabhakar
es changed, 3 insertions(+), 1 deletion(-) > Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad

Re: [PATCH 1/3] [media] DaVinci-VPBE-Display: Delete an error message for a failed memory allocation in init_vpbe_layer()

2017-09-11 Thread Lad, Prabhakar
gned-off-by: Markus Elfring Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad

Re: [PATCH 2/3] [media] DaVinci-VPBE-Display: Improve a size determination in two functions

2017-09-11 Thread Lad, Prabhakar
t; determination a bit safer according to the Linux coding style convention. > > Signed-off-by: Markus Elfring Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad

Re: [PATCH 3/3] [media] DaVinci-VPBE-Display: Adjust 12 checks for null pointers

2017-09-11 Thread Lad, Prabhakar
ut like the following. > > Comparison to NULL could be written … > > Thus fix the affected source code places. > > Signed-off-by: Markus Elfring Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad

[PATCH v2 0/2] media: platform: davinci: remove VPFE_CMD_S_CCDC_RAW_PARAMS IOCTL

2017-07-19 Thread Lad, Prabhakar
[2] and applying too many changes would produce conflicts, just applying this patch would produce build warning of unused functions. [2] commit 5f15fbb68fd7 ("V4L/DVB (12251): v4l: dm644x ccdc module for vpfe capture driver") Lad, Prabhakar (2): media: platfo

[PATCH v2 1/2] media: platform: davinci: prepare for removal of VPFE_CMD_S_CCDC_RAW_PARAMS ioctl

2017-07-19 Thread Lad, Prabhakar
preparing for removal of VPFE_CMD_S_CCDC_RAW_PARAMS ioctl having minimalistic code changes so as it can be applied for backports. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpfe_capture.c | 22 ++ 1 file changed, 2 insertions(+), 20 deletions(-) diff

[PATCH v2 2/2] media: platform: davinci: drop VPFE_CMD_S_CCDC_RAW_PARAMS

2017-07-19 Thread Lad, Prabhakar
For dm355 and dm644x the vpfe driver provided a ioctl to configure the raw bayer config using a IOCTL, but since the code was not properly implemented and aswell the IOCTL was marked as 'experimental ioctl that will change in future kernels', dropping this IOCTL. Signed-off-by: Lad,

[v3 1/2] media: platform: davinci: prepare for removal of VPFE_CMD_S_CCDC_RAW_PARAMS ioctl

2017-07-20 Thread Lad, Prabhakar
644x ccdc module for vpfe capture driver") Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpfe_capture.c | 22 ++ 1 file changed, 2 insertions(+), 20 deletions(-) diff --git a/drivers/media/platform/davinci/vpfe_capture.c b/drivers/media/platform/davinc

[v3 0/2] media: platform: davinci: remove VPFE_CMD_S_CCDC_RAW_PARAMS IOCTL

2017-07-20 Thread Lad, Prabhakar
[2] and applying too many changes would produce conflicts, just applying this patch would produce build warning of unused functions. [2] commit 5f15fbb68fd7 ("V4L/DVB (12251): v4l: dm644x ccdc module for vpfe capture driver") Lad, Prabhakar (2): media: platfo

[v3 2/2] media: platform: davinci: drop VPFE_CMD_S_CCDC_RAW_PARAMS

2017-07-20 Thread Lad, Prabhakar
ded by user space as both the __user pointer for input and pass it through phys_to_virt to come up with a kernel pointer to copy the data to. This looks like a trivially exploitable root hole. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/ccdc_hw_device.h | 10 -- dr

Re: [PATCH] media: Convert to using %pOF instead of full_name

2017-07-20 Thread Lad, Prabhakar
yungmin Park > Cc: Andrzej Hajda > Cc: Mauro Carvalho Chehab > Cc: "Lad, Prabhakar" > Cc: Songjun Wu > Cc: Sylwester Nawrocki > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Javier Martinez Canillas > Cc: Minghsiu Tsai > Cc: Houlong Wei > Cc: Andrew-

[v4] media: platform: davinci: return -EINVAL for VPFE_CMD_S_CCDC_RAW_PARAMS ioctl

2017-07-20 Thread Lad, Prabhakar
sure this ioctl now returns -EINVAL and backport this patch as far as possible. Fixes: 5f15fbb68fd7 ("V4L/DVB (12251): v4l: dm644x ccdc module for vpfe capture driver") Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpfe_capture.c | 22 ++ 1 fil

Re: [PATCH 2/3] [media] davinci: constify platform_device_id

2017-08-17 Thread Lad, Prabhakar
Arvind Yadav Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad

Re: [PATCH] davinci: vpif_capture: fix default pixel format for BT.656/BT.1120 video

2017-05-30 Thread Lad, Prabhakar
> > This is documented in section 36.2.3 of OMAP-L138 > Technical Reference Manual, SPRUH77A. > > The VPIF driver incorrectly sets the default format > to V4L2_PIX_FMT_YUV422P. Fix it. > > Reported-by: Alejandro Hernandez > Signed-off-by: Sekhar Nori Acked-by: Lad, Prabha

Re: [PATCH v2 12/26] media: davinci: fix a debug printk

2017-11-09 Thread Lad, Prabhakar
ined before the print logic. > > Fixes: 68d9c47b1679 ("media: Convert to using %pOF instead of full_name") > Fixes: a2d17962c9ca ("[media] davinci: Switch from V4L2 OF to V4L2 fwnode") > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/platform/davinci/vpif_capture.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad

Re: [PATCH 06/12] media: vpif: don't generate a kernel-doc warning on a constant

2017-11-30 Thread Lad, Prabhakar
type: 'const struct vpif_channel_config_params vpif_ch_params[] > = ' > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/platform/davinci/vpif.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad

Re: [PATCH 4/7] media: davinci: fix kernel-doc warnings

2017-11-30 Thread Lad, Prabhakar
gt; description found for parameter 'fmt' > drivers/media/platform/davinci/vpif_capture.c:940: warning: Excess > function parameter 'index' description in 'vpif_enum_fmt_vid_cap' > drivers/media/platform/davinci/vpif_capture.c:1750: warning: No > description found for parameter 'dev' > > Fix them. > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/platform/davinci/vpif_capture.c | 27 > ++- > drivers/media/platform/davinci/vpif_display.c | 16 > 2 files changed, 22 insertions(+), 21 deletions(-) > Acked-by: Lad, Prabhakar Regards, --Prabhakar Lad

[PATCH] media: OF: add "sync-on-green-active" property

2013-08-10 Thread Lad, Prabhakar
From: "Lad, Prabhakar" This patch adds 'sync-on-green-active' property as part of endpoint property. Signed-off-by: Lad, Prabhakar Acked-by: Sylwester Nawrocki --- Changes for non RFC: 1: Fixed review comments pointed by Hans. 2: Added Ack from Sylwester.

[PATCH v5] media: i2c: tvp7002: add OF support

2013-08-10 Thread Lad, Prabhakar
From: "Lad, Prabhakar" add OF support for the tvp7002 driver. Signed-off-by: Lad, Prabhakar --- This patch depends on https://patchwork.kernel.org/patch/2842680/ Changes for v5: 1: Fixed review comments pointed by Hans. Changes for v4: 1: Improved descrition of end point

Re: [Patch v3 1/1] media: am437x-vpfe: Fix a race condition during release

2015-07-07 Thread Lad, Prabhakar
("[media] media: platform: add VPFE capture driver > support for AM437X") > Cc: # v4.0+ > Signed-off-by: Benoit Parrot Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad > --- > Changes since v2: > - fix the stable commit reference syntax > > drivers/media/platfor

Re: [Patch v3 1/1] media: am437x-vpfe: Requested frame size and fmt overwritten by current sensor setting

2015-07-07 Thread Lad, Prabhakar
media: platform: add VPFE capture driver > support for AM437X") > Cc: # v4.0+ > Signed-off-by: Benoit Parrot Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad > --- > Changes since v2: > - fix the stable commit reference syntax > > drivers/media/platform/am437x/am

Re: drivers/media/platform/am437x/am437x-vpfe.c:1698: bad test ?

2015-08-04 Thread Lad, Prabhakar
Hi David, On Mon, Aug 3, 2015 at 3:02 PM, David Binderman wrote: > Hello there, > > drivers/media/platform/am437x/am437x-vpfe.c:1698:27: warning: self-comparison > always evaluates to true [-Wtautological-compare] > > if (client->addr == curr_client->addr && > client->adapter->n

Re: [PATCH v2.2 09/10] v4l: 16-bit BGGR is always 16 bits

2016-07-13 Thread Lad, Prabhakar
rently only two drivers, am437x and davinci, use the V4L2_PIX_FMT_SBGGR16 > pixelformat currently. The sampling precision is understood to be 16 bits in > all current cases. > > Remove the note on sampling precision. > > Signed-off-by: Sakari Ailus > --- Acked-by: Lad,

Re: [PATCH 6/9] vpfe_capture: convert g/s_crop to g/s_selection.

2016-07-13 Thread Lad, Prabhakar
On Mon, Jul 4, 2016 at 9:32 AM, Hans Verkuil wrote: > From: Hans Verkuil > > This is part of a final push to convert all drivers to g/s_selection. > > Signed-off-by: Hans Verkuil > Cc: Prabhakar Lad Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad > --- > driver

Re: [PATCH 03/14] davinci: drop unused control callbacks

2016-07-13 Thread Lad, Prabhakar
On Mon, Jul 4, 2016 at 9:34 AM, Hans Verkuil wrote: > From: Hans Verkuil > > These callbacks are no longer used since the davinci drivers use the > control framework. > > Signed-off-by: Hans Verkuil > Cc: Prabhakar Lad Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad &

Re: [PATCH 7/9] vpbe_display: convert g/s_crop to g/s_selection.

2016-07-13 Thread Lad, Prabhakar
On Mon, Jul 4, 2016 at 9:32 AM, Hans Verkuil wrote: > From: Hans Verkuil > > This is part of a final push to convert all drivers to g/s_selection. > > Signed-off-by: Hans Verkuil > Cc: Prabhakar Lad Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad > --- > driver

Re: [PATCH v2.2 10/10] v4l: Add 16-bit raw bayer pixel format definitions

2016-07-13 Thread Lad, Prabhakar
ion to match that of the other sample depths. > > Signed-off-by: Sakari Ailus > --- Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad > Documentation/DocBook/media/v4l/pixfmt-sbggr16.xml | 81 --- > Documentation/DocBook/media/v4l/pixfmt-srggb16.xml | 91 > +

Re: [PATCH] [media] tvp5150: add support for asynchronous probing

2015-09-22 Thread Lad, Prabhakar
On Mon, Sep 21, 2015 at 12:23 PM, Javier Martinez Canillas wrote: > Allow the subdevice to be probed asynchronously. > > Signed-off-by: Javier Martinez Canillas > Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe li

Re: [PATCH] [media] i2c: constify v4l2_ctrl_ops structures

2015-11-16 Thread Lad, Prabhakar
On Fri, Nov 13, 2015 at 10:05 PM, Julia Lawall wrote: > These v4l2_ctrl_ops structures are never modified, like all the other > v4l2_ctrl_ops structures, so declare them as const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall > Acked-by: La

Re: [GIT PULL FOR v4.5] Davinci staging fixes

2015-11-17 Thread Lad, Prabhakar
Hi Mauro, On Tue, Nov 17, 2015 at 4:29 PM, Mauro Carvalho Chehab wrote: > Em Mon, 09 Nov 2015 23:27:02 +0200 > Laurent Pinchart escreveu: > >> Hi Mauro, >> >> I've collected the pending Davinci staging fixes from patchwork and prepared >> a >> branch for you. >> >> Prabhakar, is that fine with

Re: [PATCH] [media] davinci: add i2c Kconfig dependencies

2015-11-19 Thread Lad, Prabhakar
_display.c:1298:14: error: implicit declaration of > function 'i2c_get_adapter' [-Werror=implicit-function-declaration] > > This adds explicit Kconfig dependencies so we don't see the > driver options if I2C is turned off. > > Signed-off-by: Arnd Bergmann Acked-by:

Re: [PATCH 09/14] zoran: fix indent

2015-04-30 Thread Lad, Prabhakar
be recovered from git logs. > > Signed-off-by: Mauro Carvalho Chehab > Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 18/27] cx25840: fix bad identing

2015-04-30 Thread Lad, Prabhakar
On Thu, Apr 30, 2015 at 12:06 AM, Mauro Carvalho Chehab wrote: > drivers/media/i2c/cx25840/cx25840-core.c:974 input_change() warn: > inconsistent indenting > > Signed-off-by: Mauro Carvalho Chehab > Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad -- To unsubscribe from this

Re: [PATCH 3/3] am437x: remove unused variable

2015-04-30 Thread Lad, Prabhakar
sed-but-set-variable] > struct vpfe_subdev_info *sdinfo; >^ > > Cc: Benoit Parrot > Signed-off-by: Mauro Carvalho Chehab > Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media

Re: [PATCH 2/3] am437x: Fix a wrong identation

2015-04-30 Thread Lad, Prabhakar
On Tue, Apr 28, 2015 at 12:59 PM, Mauro Carvalho Chehab wrote: > drivers/media/platform/am437x/am437x-vpfe.c:513 vpfe_ccdc_set_params() warn: > inconsistent indenting > > Cc: Benoit Parrot > Signed-off-by: Mauro Carvalho Chehab > Acked-by: Lad, Prabhakar Cheers, --P

Re: [PATCH 1/3] am437x-vpfe: really update the vpfe_ccdc_update_raw_params data

2015-04-30 Thread Lad, Prabhakar
pile-tested only. > > Cc: Benoit Parrot > Signed-off-by: Mauro Carvalho Chehab > Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 00/17] media: blackfin: bfin_capture enhancements

2015-05-05 Thread Lad, Prabhakar
Hi Scott, On Tue, May 5, 2015 at 10:58 AM, Scott Jiang wrote: > 2015-04-24 18:04 GMT+08:00 Hans Verkuil : >> On 04/10/2015 12:42 PM, Scott Jiang wrote: >>> Hi Hans, >>> > > Hans, I tried to use v4l2-compliance but it failed to compile. Sorry > for telling you it have passed compilatio

Re: [PATCH] Clarify expression which uses both multiplication and pointer dereference

2015-05-18 Thread Lad, Prabhakar
On Mon, May 18, 2015 at 7:51 AM, Michal Kubecek wrote: > On Sun, May 17, 2015 at 07:18:42PM +0200, Alex Dowad wrote: >> This fixes a checkpatch style error in vpfe_buffer_queue_setup. >> >> Signed-off-by: Alex Dowad >> --- >> drivers/staging/media/davinci_vpfe/vpfe_video.c | 2 +- >> 1 file chan

Re: [PATCH] Clarify expression which uses both multiplication and pointer dereference

2015-05-18 Thread Lad, Prabhakar
Hi Hans, On Mon, May 18, 2015 at 9:15 AM, Hans Verkuil wrote: > > > On 05/18/2015 10:06 AM, Lad, Prabhakar wrote: >> On Mon, May 18, 2015 at 7:51 AM, Michal Kubecek wrote: >>> On Sun, May 17, 2015 at 07:18:42PM +0200, Alex Dowad wrote: >>>> Th

Re: [PATCH] ov2659: Don't depend on subdev API

2015-05-19 Thread Lad, Prabhakar
^ > > Compile-tested only. > > Signed-off-by: Mauro Carvalho Chehab > Acked-by: Lad, Prabhakar Tested-by: Lad, Prabhakar Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] usb drivers: use BUG_ON() instead of if () BUG

2015-05-19 Thread Lad, Prabhakar
es. We should convert them > to use VB2, in order to avoid those crappy things. > > Signed-off-by: Mauro Carvalho Chehab > Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to major

Re: [PATCH] [media] ov2659: add v4l2_subdev dependency

2015-05-19 Thread Lad, Prabhakar
Hi Arnd, Thanks for the patch. On Tue, May 19, 2015 at 1:39 PM, Arnd Bergmann wrote: > The newly added ov2659 driver uses the v4l2 subdev API, but > can be enabled even when that API is not part of the kernel, > resulting in this build error: > > media/i2c/ov2659.c: In function 'ov2659_get_fmt':

[PATCH] media: v4l2-core/v4l2-of.c: determine bus_type only on hsync/vsync flags

2015-05-19 Thread Lad Prabhakar
From: "Lad, Prabhakar" the bus_type needs to be determined only on the hsync/vsync flags, this patch fixes the above by moving the check just after hsync/vsync flags are being set. Reported-by: Nikhil Devshatwar Signed-off-by: Lad, Prabhakar --- drivers/media/v4l2-core/v4l

[PATCH 0/3] davinci_vpfe: minor cleanups

2015-05-25 Thread Lad Prabhakar
From: "Lad, Prabhakar" Hi Hans, These patch series includes minor cleanups for davinci vpfe driver. Lad, Prabhakar (3): media: davinci_vpfe: clear the output_specs media: davinci_vpfe: set minimum required buffers to three media: davinci_vpfe: use monotonic timestamp drive

[PATCH 1/3] media: davinci_vpfe: clear the output_specs

2015-05-25 Thread Lad Prabhakar
From: "Lad, Prabhakar" clear of the output_specs before passing it to the configure_resizer_out_params(), so that no garbage values are set. This fixes following build warning: drivers/staging/media/davinci_vpfe/dm365_resizer.c: In function 'resizer_set_stream': d

[PATCH 3/3] media: davinci_vpfe: use monotonic timestamp

2015-05-25 Thread Lad Prabhakar
From: "Lad, Prabhakar" V4L2 drivers should use MONOTONIC timestamps instead of gettimeofday, which is affected by daylight savings time. Signed-off-by: Lad, Prabhakar --- drivers/staging/media/davinci_vpfe/vpfe_video.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) di

[PATCH 2/3] media: davinci_vpfe: set minimum required buffers to three

2015-05-25 Thread Lad Prabhakar
From: "Lad, Prabhakar" this patch sets nbuffers to three or more and drops the unset member video_limit which just a copy paste from earlier driver. Signed-off-by: Lad, Prabhakar --- drivers/staging/media/davinci_vpfe/vpfe_mc_capture.h | 2 -- drivers/staging/media/davinci_vpfe/vp

[PATCH] media: davinci: vpbe: use v4l2_get_timestamp()

2015-05-26 Thread Lad Prabhakar
From: "Lad, Prabhakar" this patch makes use of helper function v4l2_get_timestamp() to set the timestamp of vb2 buffer. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vpbe_display.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/dri

Re: [PATCH 01/12] media/i2c/adv7343: Remove compat control ops

2015-06-15 Thread Lad, Prabhakar
On Fri, Jun 12, 2015 at 5:31 PM, Ricardo Ribalda Delgado wrote: > They are no longer used in old non-control-framework > bridge drivers. > > Reported-by: Hans Verkuil > Signed-off-by: Ricardo Ribalda Delgado Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad > --- > driv

Re: [PATCH 08/12] media/i2c/tvp514x: Remove compat control ops

2015-06-15 Thread Lad, Prabhakar
On Fri, Jun 12, 2015 at 5:31 PM, Ricardo Ribalda Delgado wrote: > They are no longer used in old non-control-framework > bridge drivers. > > Reported-by: Hans Verkuil > Signed-off-by: Ricardo Ribalda Delgado Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad > --- &g

Re: [PATCH 09/12] media/i2c/tvp7002: Remove compat control ops

2015-06-15 Thread Lad, Prabhakar
On Fri, Jun 12, 2015 at 5:31 PM, Ricardo Ribalda Delgado wrote: > They are no longer used in old non-control-framework > bridge drivers. > > Reported-by: Hans Verkuil > Signed-off-by: Ricardo Ribalda Delgado Acked-by: Lad, Prabhakar Cheers, --Prabhakar Lad > --- > driv

[PATCH] s5p-fimc: Fix typo of URL pointing to Media Controller API's

2013-01-01 Thread Lad, Prabhakar
Signed-off-by: Lad, Prabhakar Cc: Sylwester Nawrocki Cc: Kyungmin Park --- Documentation/video4linux/fimc.txt |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/Documentation/video4linux/fimc.txt b/Documentation/video4linux/fimc.txt index fd02d9a..25f4d34 100644 --- a

[PATCH] davinci: dm644x: fix enum ccdc_gama_width and enum ccdc_data_size comparision warning

2013-01-02 Thread Lad, Prabhakar
] Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/dm644x_ccdc.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/davinci/dm644x_ccdc.c b/drivers/media/platform/davinci/dm644x_ccdc.c index ee7942b..42b473a 100644 --- a/drivers

[PATCH] davinci: dm355: Fix uninitialized variable compiler warnings

2013-01-02 Thread Lad, Prabhakar
the variable to 0. Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/dm355_ccdc.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/davinci/dm355_ccdc.c b/drivers/media/platform/davinci/dm355_ccdc.c index ce0e413..3c28aaa 100644 --- a

[PATCH] adv7343: use devm_kzalloc() instead of kzalloc()

2013-01-03 Thread Lad, Prabhakar
I2C drivers can use devm_kzalloc() too in their .probe() methods. Doing so simplifies their clean up paths. Signed-off-by: Lad, Prabhakar Signed-off-by: Manjunath Hadli --- drivers/media/i2c/adv7343.c | 13 - 1 files changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers

[PATCH] ths7303: use devm_kzalloc() instead of kzalloc()

2013-01-03 Thread Lad, Prabhakar
I2C drivers can use devm_kzalloc() too in their .probe() methods. Doing so simplifies their clean up paths. Signed-off-by: Lad, Prabhakar Signed-off-by: Manjunath Hadli --- drivers/media/i2c/ths7303.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c

[PATCH] tvp514x: use devm_kzalloc() instead of kzalloc()

2013-01-03 Thread Lad, Prabhakar
I2C drivers can use devm_kzalloc() too in their .probe() methods. Doing so simplifies their clean up paths. Signed-off-by: Lad, Prabhakar Signed-off-by: Manjunath Hadli --- drivers/media/i2c/tvp514x.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/media

[PATCH] tvp7002: use devm_kzalloc() instead of kzalloc()

2013-01-03 Thread Lad, Prabhakar
I2C drivers can use devm_kzalloc() too in their .probe() methods. Doing so simplifies their clean up paths. Signed-off-by: Lad, Prabhakar Signed-off-by: Manjunath Hadli --- drivers/media/i2c/tvp7002.c | 10 ++ 1 files changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers

[PATCH v2] adv7343: use devm_kzalloc() instead of kzalloc()

2013-01-03 Thread Lad, Prabhakar
I2C drivers can use devm_kzalloc() too in their .probe() methods. Doing so simplifies their clean up paths. Signed-off-by: Lad, Prabhakar Signed-off-by: Manjunath Hadli --- Changes for v2: 1: Fixed comments pointed out by Laurent. drivers/media/i2c/adv7343.c |9 +++-- 1 files

[PATCH v2] tvp514x: use devm_kzalloc() instead of kzalloc()

2013-01-03 Thread Lad, Prabhakar
I2C drivers can use devm_kzalloc() too in their .probe() methods. Doing so simplifies their clean up paths. Signed-off-by: Lad, Prabhakar Signed-off-by: Manjunath Hadli --- Changes for v2: 1: Fixed comments pointed out by Laurent. drivers/media/i2c/tvp514x.c |4 +--- 1 files changed, 1

[PATCH v2] tvp7002: use devm_kzalloc() instead of kzalloc()

2013-01-03 Thread Lad, Prabhakar
I2C drivers can use devm_kzalloc() too in their .probe() methods. Doing so simplifies their clean up paths. Signed-off-by: Lad, Prabhakar Signed-off-by: Manjunath Hadli --- Changes for v2: 1: Fixed comments pointed out by Laurent. drivers/media/i2c/tvp7002.c | 18 ++ 1

[PATCH RFC 0/3] vpif capture support for async subdevice probing

2013-01-09 Thread Lad, Prabhakar
for vpif disaply, based on review comments on this series. Lad, Prabhakar (3): davinci: vpif: capture: add V4L2-async support tvp514x: support asynchronous probing ARM: da850/omap-l138: vpif capture convert to asynchronously register of subdev arch/arm/mach-davinci/board-da850-evm.c

[PATCH RFC 1/3] davinci: vpif: capture: add V4L2-async support

2013-01-09 Thread Lad, Prabhakar
, even when there are multiple such instances registered with a single soc-camera host simultaneously. Signed-off-by: Lad, Prabhakar Cc: Guennadi Liakhovetski Cc: Hans Verkuil Cc: Laurent Pinchart Cc: Sakari Ailus Cc: Mauro Carvalho Chehab --- drivers/media/platform/davinci/vpif_capture.c

[PATCH RFC 3/3] ARM: da850/omap-l138: vpif capture convert to asynchronously register of subdev

2013-01-09 Thread Lad, Prabhakar
Register the tvp514x decoder devices directly in board platform data instead of letting the vpif capture driver register them at their run-time. This uses the V4L2 asynchronous subdevice probing capability. Signed-off-by: Lad, Prabhakar Cc: Sekhar Nori --- arch/arm/mach-davinci/board-da850

  1   2   3   4   5   >