Re: Are media drivers abusing of GFP_DMA? - was: Re: [LSF/MM TOPIC NOTES] x86 ZONE_DMA love

2018-05-15 Thread Luis R. Rodriguez
On Mon, May 14, 2018 at 07:35:03AM -0300, Mauro Carvalho Chehab wrote: > Hi Fabien, > > Em Mon, 14 May 2018 08:00:37 + > Fabien DESSENNE escreveu: > > > On 07/05/18 17:19, Mauro Carvalho Chehab wrote: > > > Em Mon, 07 May 2018 16:26:08 +0300 > > > Laurent Pinchart escreveu: > > > > > >> H

Re: ivtv: use arch_phys_wc_add() and require PAT disabled

2018-03-07 Thread Luis R. Rodriguez
On Tue, Mar 06, 2018 at 09:01:10PM +, French, Nicholas A. wrote: > any reason why PAT can't be enabled for ivtvfb as simply as in the attached > patch? diff --git a/drivers/media/pci/ivtv/ivtvfb.c b/drivers/media/pci/ivtv/ivtvfb.c index 621b2f613d81..69de110726e8 100644 --- a/drivers/media/pci

Re: ivtv: use arch_phys_wc_add() and require PAT disabled

2018-03-07 Thread Luis R. Rodriguez
On Thu, Mar 08, 2018 at 03:16:29AM +, French, Nicholas A. wrote: > On Wed, Mar 07, 2018 at 07:02:05PM +0000, Luis R. Rodriguez wrote: > > On Tue, Mar 06, 2018 at 09:01:10PM +, French, Nicholas A. wrote: > > > any reason why PAT can't be enabled for ivt

Re: ivtv: use arch_phys_wc_add() and require PAT disabled

2018-03-07 Thread Luis R. Rodriguez
On Thu, Mar 08, 2018 at 04:06:01AM +, Luis R. Rodriguez wrote: > On Thu, Mar 08, 2018 at 03:16:29AM +, French, Nicholas A. wrote: > > On Wed, Mar 07, 2018 at 07:02:05PM +0000, Luis R. Rodriguez wrote: > > > On Tue, Mar 06, 2018 at 09:01:10PM +, French, Nicholas A.

Re: ivtv: use arch_phys_wc_add() and require PAT disabled

2018-03-10 Thread Luis R. Rodriguez
On Sat, Mar 10, 2018 at 8:57 AM, French, Nicholas A. wrote: > On Wed, Mar 07, 2018 at 11:23:09PM -0600, French, Nicholas A. wrote: >> On Thu, Mar 08, 2018 at 04:14:11AM +0000, Luis R. Rodriguez wrote: >> > On Thu, Mar 08, 2018 at 04:06:01AM +, Luis R. Rodriguez wrote: >

Re: ivtv: use arch_phys_wc_add() and require PAT disabled

2018-03-10 Thread Luis R. Rodriguez
On Sat, Mar 10, 2018 at 11:03 AM, Luis R. Rodriguez wrote: > On Sat, Mar 10, 2018 at 8:57 AM, French, Nicholas A. wrote: >> On Wed, Mar 07, 2018 at 11:23:09PM -0600, French, Nicholas A. wrote: >>> On Thu, Mar 08, 2018 at 04:14:11AM +, Luis R. Rodriguez wrote: >>> &

Re: [RFC 5/5] pm: remove kernel thread freezing

2017-10-03 Thread Luis R. Rodriguez
On Tue, Oct 03, 2017 at 03:09:53PM -0600, Shuah Khan wrote: > On Tue, Oct 3, 2017 at 3:00 PM, Jiri Kosina wrote: > > On Tue, 3 Oct 2017, Pavel Machek wrote: > > > >> > Again, I agree that the (rare) kthreads that are actually "creating" new > >> > I/O have to be somehow frozen and require special

Re: [PATCH 1/2] x86/mm/pat, drivers/infiniband/ipath: replace WARN() with pr_warn()

2015-06-23 Thread Luis R. Rodriguez
On Tue, Jun 23, 2015 at 12:39 AM, Ingo Molnar wrote: > Same observation as for the other patch: please only warn if the hardware is > present and the driver tries to activate. No need to annoy others. Will fix, and respin. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-

[PATCH v2 0/2] x86/mm/pat: modify nopat requirement warning

2015-06-24 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" The 0-day robot found that the notpat requirement warning was being triggered on the ivtv driver on the module init path, that will always trigger on built-in devices. We want that warning to trigger only if real hardware is found so this moves the ivtv w

[PATCH v2 1/2] x86/mm/pat, drivers/infiniband/ipath: replace WARN() with pr_warn()

2015-06-24 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" WARN() may confuse users, fix that. ipath_init_one() is part the device's probe so this would only be triggered if a corresponding device was found. Signed-off-by: Luis R. Rodriguez --- drivers/infiniband/hw/ipath/ipath_driver.c | 6 -- 1

[PATCH v2 2/2] x86/mm/pat, drivers/media/ivtv: move pat warn and replace WARN() with pr_warn()

2015-06-24 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" On built-in kernels this warning will always splat as this is part of the module init. Fix that by shifting the PAT requirement check out under the code that does the "quasi-probe" for the device. This device driver relies on an existing driver to

Re: [PATCH v2 1/2] x86/mm/pat, drivers/infiniband/ipath: replace WARN() with pr_warn()

2015-06-25 Thread Luis R. Rodriguez
On Thu, Jun 25, 2015 at 08:49:22AM +0200, Ingo Molnar wrote: > > * Luis R. Rodriguez wrote: > > > From: "Luis R. Rodriguez" > > > > WARN() may confuse users, fix that. ipath_init_one() is part the > > device's probe so this would only be t

Re: [PATCH v2 2/2] x86/mm/pat, drivers/media/ivtv: move pat warn and replace WARN() with pr_warn()

2015-06-25 Thread Luis R. Rodriguez
On Thu, Jun 25, 2015 at 08:51:47AM +0200, Ingo Molnar wrote: > > * Luis R. Rodriguez wrote: > > > From: "Luis R. Rodriguez" > > > > On built-in kernels this warning will always splat as this is part > > of the module init. Fix that by shifting the P

Re: [PATCH v2 2/2] x86/mm/pat, drivers/media/ivtv: move pat warn and replace WARN() with pr_warn()

2015-07-06 Thread Luis R. Rodriguez
On Mon, Jun 29, 2015 at 05:52:18AM -0400, Andy Walls wrote: > On June 29, 2015 2:55:05 AM EDT, Ingo Molnar wrote: > > > >* Andy Walls wrote: > > > >> On Fri, 2015-06-26 at 10:45 +0200, Ingo Molnar wrote: > >> > * Luis R. Rodriguez wrote: > >> &

Re: [PATCH v2 2/2] x86/mm/pat, drivers/media/ivtv: move pat warn and replace WARN() with pr_warn()

2015-07-06 Thread Luis R. Rodriguez
On Mon, Jul 6, 2015 at 5:44 PM, Luis R. Rodriguez wrote: > If we really wanted to we could consider arch_phys_wc_add() I mean adding a __arch_phys_wc_add() which does not check for pat_enabled(). > and > deal with that this will not check for pat_enabled() and forces MTRR... > I thi

[RESEND PATCH v2 2/2] x86/mm/pat, drivers/media/ivtv: move pat warn and replace WARN() with pr_warn()

2015-07-17 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" On built-in kernels this warning will always splat as this is part of the module init. Fix that by shifting the PAT requirement check out under the code that does the "quasi-probe" for the device. This device driver relies on an existing driver to

[RESEND PATCH v2 1/2] x86/mm/pat, drivers/infiniband/ipath: replace WARN() with pr_warn()

2015-07-17 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" WARN() may confuse users, fix that. ipath_init_one() is part the device's probe so this would only be triggered if a corresponding device was found. Signed-off-by: Luis R. Rodriguez --- drivers/infiniband/hw/ipath/ipath_driver.c | 6 -- 1

[RESEND PATCH v2 0/2] x86/mm/pat: modify nopat requirement warning

2015-07-17 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Ingo, Boris is on vacation so sending this through you. This is just a resend of the v2 series. The issue here was the WARN() splat on built-in kernels due to ivtv's funky probe which will trigger even if you don't have any ivtv hardware. I&#

Re: [Xen-devel] RIP MTRR - status update for upcoming v4.2

2015-08-06 Thread Luis R. Rodriguez
On Fri, Jun 12, 2015 at 9:58 AM, Toshi Kani wrote: > On Fri, 2015-06-12 at 08:59 +0100, Jan Beulich wrote: >> >>> On 12.06.15 at 01:23, wrote: >> > There are two usages on MTRRs: >> > 1) MTRR entries set by firmware >> > 2) MTRR entries set by OS drivers >> > >> > We can obsolete 2), but we hav

Re: [Xen-devel] RIP MTRR - status update for upcoming v4.2

2015-08-06 Thread Luis R. Rodriguez
On Thu, Aug 6, 2015 at 12:53 PM, Luis R. Rodriguez wrote: > For those type of OSes... > could it be possible to negotiate or hint to the platform through an > attribute somehow that the OS has such capability to not use MTRR? And if that's not possible how about a new platform sett

Re: [Xen-devel] RIP MTRR - status update for upcoming v4.2

2015-08-07 Thread Luis R. Rodriguez
On Thu, Aug 6, 2015 at 3:58 PM, Toshi Kani wrote: > On Thu, 2015-08-06 at 12:53 -0700, Luis R. Rodriguez wrote: >> On Fri, Jun 12, 2015 at 9:58 AM, Toshi Kani wrote: >> > On Fri, 2015-06-12 at 08:59 +0100, Jan Beulich wrote: >> > > > > > On 12.06.15 a

Re: [Xen-devel] RIP MTRR - status update for upcoming v4.2

2015-08-07 Thread Luis R. Rodriguez
On Fri, Aug 7, 2015 at 2:56 PM, Toshi Kani wrote: > On Fri, 2015-08-07 at 13:25 -0700, Luis R. Rodriguez wrote: >> On Thu, Aug 6, 2015 at 3:58 PM, Toshi Kani wrote: >> > On Thu, 2015-08-06 at 12:53 -0700, Luis R. Rodriguez wrote: >> > > On Fri, Jun 12, 2015

Re: [Xen-devel] RIP MTRR - status update for upcoming v4.2

2015-08-07 Thread Luis R. Rodriguez
On Fri, Aug 7, 2015 at 4:08 PM, Toshi Kani wrote: > On Fri, 2015-08-07 at 15:23 -0700, Luis R. Rodriguez wrote: >> On Fri, Aug 7, 2015 at 2:56 PM, Toshi Kani wrote: >> > On Fri, 2015-08-07 at 13:25 -0700, Luis R. Rodriguez wrote: >> > > On Thu, Aug 6, 2015

[PATCH v4 11/11] mtrr: bury MTRR - unexport mtrr_add() and mtrr_del()

2015-08-24 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" The crusade to replace mtrr_add() with architecture agnostic arch_phys_wc_add() is complete, this will ensure write-combining implementations (PAT on x86) is taken advantage instead of using MTRR. With the crusade done now, hide direct MTRR access for driver

Re: [PATCH] [media] ivtv: use arch_phys_wc_add() and require PAT disabled

2015-04-27 Thread Luis R. Rodriguez
On Sat, Apr 25, 2015 at 07:12:05AM -0400, Andy Walls wrote: > Hi Luis, > > Sorry for the late reply. > > Thank you for the patch! See my comments below: > > On Wed, 2015-04-22 at 12:33 -0700, Luis R. Rodriguez wrote: > > From: "Luis R. Rodriguez" > >

[PATCH v2] ivtv: use arch_phys_wc_add() and require PAT disabled

2015-04-27 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" We are burrying direct access to MTRR code support on x86 in order to take advantage of PAT. In the future we also want to make the default behaviour of ioremap_nocache() to use strong UC, use of mtrr_add() on those systems would make write-combining void. I

[PATCH v4 6/8] ivtv: use arch_phys_wc_add() and require PAT disabled

2015-04-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" We are burrying direct access to MTRR code support on x86 in order to take advantage of PAT. In the future we also want to make the default behaviour of ioremap_nocache() to use strong UC, use of mtrr_add() on those systems would make write-combining void. I

[PATCH v5 4/6] ivtv: use arch_phys_wc_add() and require PAT disabled

2015-04-30 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" We are burrying direct access to MTRR code support on x86 in order to take advantage of PAT. In the future we also want to make the default behaviour of ioremap_nocache() to use strong UC, use of mtrr_add() on those systems would make write-combining void. I

[PATCH v6 0/3] linux: address broken PAT drivers

2015-06-08 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Mauro, since the ivtv patch is already acked by the driver maintainer and depends on an x86 symbol that went through Boris' tree are you OK in it going through Boris' tree? Boris, provided the outcome of the above maintainer's preference for

[PATCH v6 1/3] ivtv: use arch_phys_wc_add() and require PAT disabled

2015-06-08 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" We are burrying direct access to MTRR code support on x86 in order to take advantage of PAT. In the future we also want to make the default behaviour of ioremap_nocache() to use strong UC, use of mtrr_add() on those systems would make write-combining void. I

[PATCH v6 2/3] IB/ipath: add counting for MTRR

2015-06-08 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" There is no good reason not to, we eventually delete it as well. Cc: Toshi Kani Cc: Roland Dreier Cc: Sean Hefty Cc: Hal Rosenstock Cc: Suresh Siddha Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Juergen Gross Cc: Daniel Vetter Cc: Andy Lutomirski Cc: D

[PATCH v6 3/3] IB/ipath: use arch_phys_wc_add() and require PAT disabled

2015-06-08 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" We are burrying direct access to MTRR code support on x86 in order to take advantage of PAT. In the future we also want to make the default behaviour of ioremap_nocache() to use strong UC, use of mtrr_add() on those systems would make write-combining void. I

Re: [PATCH v6 0/3] linux: address broken PAT drivers

2015-06-11 Thread Luis R. Rodriguez
On Mon, Jun 08, 2015 at 09:57:12PM -0300, Mauro Carvalho Chehab wrote: > Em Mon, 08 Jun 2015 17:20:19 -0700 > "Luis R. Rodriguez" escreveu: > > > From: "Luis R. Rodriguez" > > > > Mauro, > > > > since the ivtv patch is already acke

[PATCH v6 1/3] ivtv: use arch_phys_wc_add() and require PAT disabled

2015-06-11 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" We are burrying direct access to MTRR code support on x86 in order to take advantage of PAT. In the future we also want to make the default behaviour of ioremap_nocache() to use strong UC, use of mtrr_add() on those systems would make write-combining void. I

[PATCH v6 0/3] linux: address broken PAT drivers

2015-06-11 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Mauro, since the ivtv patch is already acked by the driver maintainer and depends on an x86 symbol that went through Boris' tree are you OK in it going through Boris' tree? Boris, provided the outcome of the above maintainer's preference for

[PATCH v6 3/3] IB/ipath: use arch_phys_wc_add() and require PAT disabled

2015-06-11 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" We are burrying direct access to MTRR code support on x86 in order to take advantage of PAT. In the future we also want to make the default behaviour of ioremap_nocache() to use strong UC, use of mtrr_add() on those systems would make write-combining void. I

[PATCH v6 2/3] IB/ipath: add counting for MTRR

2015-06-11 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" There is no good reason not to, we eventually delete it as well. Cc: Toshi Kani Cc: Roland Dreier Cc: Sean Hefty Cc: Hal Rosenstock Cc: Suresh Siddha Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Juergen Gross Cc: Daniel Vetter Cc: Andy Lutomirski Cc: D

Re: [PATCH v6 0/3] linux: address broken PAT drivers

2015-06-11 Thread Luis R. Rodriguez
On Thu, Jun 11, 2015 at 10:49:59AM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > Mauro, > > since the ivtv patch is already acked by the driver maintainer > and depends on an x86 symbol that went through Boris' tree are you > OK in it going

[PATCH v7 0/3] linux: address broken PAT drivers

2015-06-11 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Boris, the following patches make use of the newly exported pat_enabled() which went in through your tree. All driver and respective subsystem maintainers have Acked these patches and are OK for them to go in through your tree. Please let me know if there any

[PATCH v7 1/3] ivtv: use arch_phys_wc_add() and require PAT disabled

2015-06-11 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" We are burrying direct access to MTRR code support on x86 in order to take advantage of PAT. In the future we also want to make the default behaviour of ioremap_nocache() to use strong UC, use of mtrr_add() on those systems would make write-combining void. I

[PATCH v7 2/3] IB/ipath: add counting for MTRR

2015-06-11 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" There is no good reason not to, we eventually delete it as well. Cc: Toshi Kani Cc: Roland Dreier Cc: Sean Hefty Cc: Hal Rosenstock Cc: Suresh Siddha Cc: Ingo Molnar Cc: Thomas Gleixner Cc: Juergen Gross Cc: Daniel Vetter Cc: Andy Lutomirski Cc: D

RIP MTRR - status update for upcoming v4.2

2015-06-11 Thread Luis R. Rodriguez
The series to bury direct MTRR use is almost all in and on its way to v4.2. As the pending series continue slowly to be merged I wanted to take the time to reiterate the justification for these changes in hopes it may help those still reviewing some of these patches which are pending and to help do

[PATCH v7 3/3] IB/ipath: use arch_phys_wc_add() and require PAT disabled

2015-06-11 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" We are burrying direct access to MTRR code support on x86 in order to take advantage of PAT. In the future we also want to make the default behaviour of ioremap_nocache() to use strong UC, use of mtrr_add() on those systems would make write-combining void. I

Re: RIP MTRR - status update for upcoming v4.2

2015-06-11 Thread Luis R. Rodriguez
On Thu, Jun 11, 2015 at 05:23:16PM -0600, Toshi Kani wrote: > On Thu, 2015-06-11 at 13:36 -0700, Luis R. Rodriguez wrote: > : > > Pending RIP MTRR patches > > > > > > There are a few pending series so I wanted to provide a status update >

Re: [x86/mm/pat, drivers/media/ivtv] WARNING: CPU: 0 PID: 1 at drivers/media/pci/ivtv/ivtvfb.c:1270 ivtvfb_init()

2015-06-21 Thread Luis R. Rodriguez
b/scm/linux/kernel/git/next/linux-next.git master > > > > commit 1bf1735b478008c30acaff18ec6f4a3ff211c28a > > Author: Luis R. Rodriguez > > AuthorDate: Mon Jun 15 10:28:16 2015 +0200 > > Commit: Ingo Molnar > > CommitDate: Thu Jun 18 11:23:41 2015 +0200 &g

Re: [x86/mm/pat, drivers/media/ivtv] WARNING: CPU: 0 PID: 1 at drivers/media/pci/ivtv/ivtvfb.c:1270 ivtvfb_init()

2015-06-21 Thread Luis R. Rodriguez
On Sun, Jun 21, 2015 at 10:41:20PM +0200, Borislav Petkov wrote: > On Sun, Jun 21, 2015 at 10:23:48PM +0200, Luis R. Rodriguez wrote: > > Nope, well the driver requires huge amounts of work to work with PAT, > > that work will likely never be done, so hence the warning. Its our &g

Re: [x86/mm/pat, drivers/media/ivtv] WARNING: CPU: 0 PID: 1 at drivers/media/pci/ivtv/ivtvfb.c:1270 ivtvfb_init()

2015-06-22 Thread Luis R. Rodriguez
On Mon, Jun 22, 2015 at 09:06:41AM +0200, Borislav Petkov wrote: > On Mon, Jun 22, 2015 at 03:01:38AM +0200, Luis R. Rodriguez wrote: > > We can certainly replace the WARN() with pr_warn(), I don't see > > how its confusing though as its a run time real issue. Either > >

[PATCH 0/2] x86/mm/pat: don't use WARN for nopat requirement

2015-06-22 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Mauro, Doug, The 0-day robot found using WARN() on built-in kernels confusing. Upon further thought pr_warn() is better and will likely also not confuse humans too. Boris, provided maintainers Ack, please consider these patches. These depend on pat_enabled(

[PATCH 1/2] x86/mm/pat, drivers/infiniband/ipath: replace WARN() with pr_warn()

2015-06-22 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" On built-in kernels this will always splat. Fix that. Reported-by: Fengguang Wu [0-day test robot] Signed-off-by: Luis R. Rodriguez --- drivers/infiniband/hw/ipath/ipath_driver.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[PATCH 2/2] x86/mm/pat, drivers/media/ivtv: replace WARN() with pr_warn()

2015-06-22 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" On built-in kernels this will always splat. Fix that. Reported-by: Fengguang Wu [0-day test robot] Signed-off-by: Luis R. Rodriguez --- drivers/media/pci/ivtv/ivtvfb.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/medi

[PATCH 6/6] ie6xx_wdt: convert struct spinlock to spinlock_t

2012-11-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" spinlock_t should always be used. CHECK drivers/watchdog/ie6xx_wdt.c CC [M] drivers/watchdog/ie6xx_wdt.o Building modules, stage 2. MODPOST 43 modules LD [M] drivers/watchdog/ie6xx_wdt.ko Cc: Alexander Stein Reported-by: Hauke Mehrtens Sig

[PATCH 5/6] brcmfmac: convert struct spinlock to spinlock_t

2012-11-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" spinlock_t should always be used. LD drivers/net/wireless/brcm80211/built-in.o CHECK drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c CC [M] drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.o CHECK drivers/net/wireless/brcm8021

[PATCH 2/6] i915: convert struct spinlock to spinlock_t

2012-11-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" spinlock_t should always be used. LD drivers/gpu/drm/i915/built-in.o CHECK drivers/gpu/drm/i915/i915_drv.c CC [M] drivers/gpu/drm/i915/i915_drv.o CHECK drivers/gpu/drm/i915/i915_dma.c CC [M] drivers/gpu/drm/i915/i915_dma.o CHECK drive

[PATCH 3/6] s5p-fimc: convert struct spinlock to spinlock_t

2012-11-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" spinlock_t should always be used. Could not get this to build with allmodconfig: mcgrof@frijol ~/linux-next (git::(no branch))$ make C=1 M=drivers/media/platform/s5p-fimc/ WARNING: Symbol version dump /home/mcgrof/linux-next/Module.symvers

[PATCH 4/6] s5p-jpeg: convert struct spinlock to spinlock_t

2012-11-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" spinlock_t should always be used. Could not get this to build with allmodconfig: mcgrof@frijol ~/linux-next (git::(no branch))$ make C=1 M=drivers/media/platform/s5p-jpeg WARNING: Symbol version dump /home/mcgrof/linux-next/Module.symvers

[PATCH 0/6] drivers: convert struct spinlock to spinlock_t

2012-11-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Turns out a few drivers have strayed away from using the spinlock_t typedef and decided to use struct spinlock directly. This series converts these drivers to use spinlock_t. Each change has been compile tested with allmodconfig and sparse checked. Driver deve

[PATCH 1/6] ux500: convert struct spinlock to spinlock_t

2012-11-29 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" spinlock_t should always be used. I was unable to build test with allmodconfig: mcgrof@frijol ~/linux-next (git::(no branch))$ make C=1 M=drivers/crypto/ux500/ WARNING: Symbol version dump /home/mcgrof/linux-next/Module.symvers is missing; mo

Re: [PATCH 0/6] drivers: convert struct spinlock to spinlock_t

2012-11-30 Thread Luis R. Rodriguez
On Fri, Nov 30, 2012 at 12:38 AM, Arend van Spriel wrote: > So what is the rationale here. During mainlining our drivers we had to > remove all uses of 'typedef struct foo foo_t;'. The Linux CodingStyle > (chapter 5 Typedefs) is spending a number of lines explaining why. > > So is spinlock_t an ex

Re: [PATCH 0/6] drivers: convert struct spinlock to spinlock_t

2012-11-30 Thread Luis R. Rodriguez
On Fri, Nov 30, 2012 at 11:18 AM, Luis R. Rodriguez wrote: > On Fri, Nov 30, 2012 at 12:38 AM, Arend van Spriel wrote: >> So what is the rationale here. During mainlining our drivers we had to >> remove all uses of 'typedef struct foo foo_t;'. The Linux CodingStyle &

[PATCH 6/7] backports: add media subsystem drivers

2013-04-13 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This adds backport support for all media subsystem drivers. This is enabled only for >= 3.2. Some media drivers rely on the new probe deferrral mechanism (-EPROBE_DEFER see commit d1c3414c), those are only enabled for kernels >= 3.4. Some media driver

Re: [PATCH] rtl28xxu: do not hard depend on staging SDR module

2014-04-09 Thread Luis R. Rodriguez
On Wed, Apr 9, 2014 at 9:14 AM, Antti Palosaari wrote: > +extern struct dvb_frontend *rtl2832_sdr_attach(struct dvb_frontend *fe, > + struct i2c_adapter *i2c, const struct rtl2832_config *cfg, > + struct v4l2_subdev *sd); Thanks for the patch! Joe has been going on a crusade to remov

Re: [PATCHv2 1/2] rtl28xxu: do not hard depend on staging SDR module

2014-04-09 Thread Luis R. Rodriguez
On Wed, Apr 9, 2014 at 2:32 PM, Antti Palosaari wrote: > +extern struct dvb_frontend *rtl2832_sdr_attach(struct dvb_frontend *fe, > + struct i2c_adapter *i2c, const struct rtl2832_config *cfg, > + struct v4l2_subdev *sd); extern Luis -- To unsubscribe from this list: send the line

[PATCH 0/2] media: make drivers use their own namespace

2014-04-17 Thread Luis R. Rodriguez
Couple of changes to help with backports, both to help with ensuring drivers use their own namespace. Luis R. Rodriguez (2): technisat-usb2: rename led enums to be specific to driver bt8xx: make driver routines fit into its own namespcae drivers/media/pci/bt8xx/dst.c | 20

[PATCH 1/2] technisat-usb2: rename led enums to be specific to driver

2014-04-17 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" The current names clash with include/linux/leds.h namespace, although there is no compile issue currently this does affect backports. Drivers should also try to avoid generic namespaces for things like this. Cc: Mauro Carvalho Chehab Cc: Felipe Pena C

[PATCH 2/2] bt8xx: make driver routines fit into its own namespcae

2014-04-17 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" There is a few conflicts with older symbols on older kernels so we have to patch this driver when backporting. Instead just make these routines specific to the driver. Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Signed-off-by: Luis R.

3 linux-next based backports releases

2014-04-17 Thread Luis R. Rodriguez
3 new linux backports release are now available based on linux-next tags next-20140320 [0] next-20140411 [1] and next-20140417 [2]. This should mean that we can keep things in synch now almost daily, and drivers can be tested with the latest code as-is on linux-next. We've shaved off kernel support

[ANNOUNCE] backports-3.14-1 released

2014-04-17 Thread Luis R. Rodriguez
s net/ieee802154/ with make backports: fix compilation with CONFIG_OF backports: add crypto/ccm backport Luis R. Rodriguez (25): backports: backport ktime_to_ms() backports: backport getrawmonotonic() with do_posix_clock_monotonic_gettime() backports: refres

[ANNOUNCE] backports-3.15-rc1 is released

2014-04-17 Thread Luis R. Rodriguez
Linux backports [0] backports-v3.15-rc1 is out [1]. Please go test and see if you can and break things or if see if we've broken anything so far before a final release in sync with Linus' releases. As usual development only happens on the master branch, we'll then carry fixes onto the stable branch

[ANN] Kernel integration now merged on backports

2014-11-18 Thread Luis R. Rodriguez
Full kernel integration is now merged as part of Linux backports-20141114. I've written a bit about it [0] [1], what we need now are users and developer to give this a good spin as we wind down for the v3.19 release, which will be the first release that will support kernel integration down to any k

[PATCH v1 15/47] [media] media: ivtv: use __arch_phys_wc_add()

2015-03-20 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Sadly this driver requires a bit of work in order to use ioremap_wc() on the range currently used for MTRR write-combining. We'd need to ensure two ioremap() calls are done. Annotate this. Cc: Andy Lutomirski Cc: Andy Walls Cc: Suresh Siddha Cc: Venk

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-13 Thread Luis R. Rodriguez
usses overlapping ioremap() calls and what we'd need for a default shift from UC- to strong UC. On Fri, Apr 10, 2015 at 11:25:22PM -0700, Andy Lutomirski wrote: > On Apr 10, 2015 6:29 PM, "Luis R. Rodriguez" wrote: > > > > On Fri, Apr 10, 2015 at 02:22:51PM -0700, Andy Lut

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-15 Thread Luis R. Rodriguez
On Wed, Apr 15, 2015 at 01:42:47PM -0700, Andy Lutomirski wrote: > On Mon, Apr 13, 2015 at 10:49 AM, Luis R. Rodriguez wrote: > > > c) ivtv: the driver does not have the PCI space mapped out separately, and > > in fact it actually does not do the math for the framebuffer, in

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-15 Thread Luis R. Rodriguez
Hey Andy, thanks for your review, adding Hyong-Youb Kim for review of the full range ioremap_wc() idea below. On Wed, Apr 15, 2015 at 06:38:51PM -0400, Andy Walls wrote: > Hi All, > > On Mon, 2015-04-13 at 19:49 +0200, Luis R. Rodriguez wrote: > > From the beginning it seems o

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-16 Thread Luis R. Rodriguez
On Thu, Apr 16, 2015 at 01:18:37PM +0900, Hyong-Youb Kim wrote: > On Thu, Apr 16, 2015 at 01:58:16AM +0200, Luis R. Rodriguez wrote: > > > > An alternative... is to just ioremap_wc() the entire region, including > > MMIO registers for these old devices. I see one ethe

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-21 Thread Luis R. Rodriguez
On Wed, Apr 15, 2015 at 05:58:14PM -0700, Andy Lutomirski wrote: > On Wed, Apr 15, 2015 at 4:59 PM, Andy Walls wrote: > > On Wed, 2015-04-15 at 16:42 -0700, Andy Lutomirski wrote: > >> On Wed, Apr 15, 2015 at 3:38 PM, Andy Walls > >> wrote: > > > >> > > >> > >> IMO the right solution would be to

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-21 Thread Luis R. Rodriguez
On Wed, Apr 15, 2015 at 09:07:37PM -0400, Andy Walls wrote: > On Thu, 2015-04-16 at 01:58 +0200, Luis R. Rodriguez wrote: > > Hey Andy, thanks for your review, adding Hyong-Youb Kim for review of the > > full range ioremap_wc() idea below. > > > > On Wed, Apr 15, 201

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-21 Thread Luis R. Rodriguez
On Tue, Apr 21, 2015 at 3:02 PM, Luis R. Rodriguez wrote: > Andy, can we live without MTRR support on this driver for future kernels? This > would only leave ipath as the only offending driver. Sorry to be clear, can we live with removal of write-combining on this driver? Luis

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-21 Thread Luis R. Rodriguez
On Wed, Apr 15, 2015 at 01:42:47PM -0700, Andy Lutomirski wrote: > On Mon, Apr 13, 2015 at 10:49 AM, Luis R. Rodriguez wrote: > > > c) ivtv: the driver does not have the PCI space mapped out separately, and > > in fact it actually does not do the math for the framebuffer, in

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-21 Thread Luis R. Rodriguez
On Tue, Apr 21, 2015 at 06:51:26PM -0400, Andy Walls wrote: > Sorry for the top post; mobile work email account. > > Luis, > > You do the changes to remove MTTR and point me to your dev repo and branch. > Also point me to the new functions/primitives I'll need. There is nothing new actually need

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-21 Thread Luis R. Rodriguez
On Tue, Apr 21, 2015 at 04:57:32PM -0600, Jason Gunthorpe wrote: > On Wed, Apr 22, 2015 at 12:46:01AM +0200, Luis R. Rodriguez wrote: > > > are talking about annotating the qib driver as "known to be broken without > > PAT" > > and since the ipath driver needs

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-22 Thread Luis R. Rodriguez
On Tue, Apr 21, 2015 at 11:39:39PM -0600, Jason Gunthorpe wrote: > On Wed, Apr 22, 2015 at 01:39:07AM +0200, Luis R. Rodriguez wrote: > > > Mike, do you think the time is right to just remove the iPath driver? > > > > With PAT now being default the driver effectively w

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-22 Thread Luis R. Rodriguez
On Wed, Apr 22, 2015 at 05:23:28PM +0200, Luis R. Rodriguez wrote: > On Tue, Apr 21, 2015 at 11:39:39PM -0600, Jason Gunthorpe wrote: > > On Wed, Apr 22, 2015 at 01:39:07AM +0200, Luis R. Rodriguez wrote: > > > > Mike, do you think the time is right to just re

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-22 Thread Luis R. Rodriguez
On Wed, Apr 22, 2015 at 8:54 AM, Luis R. Rodriguez wrote: > On Wed, Apr 22, 2015 at 05:23:28PM +0200, Luis R. Rodriguez wrote: >> On Tue, Apr 21, 2015 at 11:39:39PM -0600, Jason Gunthorpe wrote: >> > On Wed, Apr 22, 2015 at 01:39:07AM +0200, Luis R. Rodriguez wrote: >>

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-22 Thread Luis R. Rodriguez
On Wed, Apr 22, 2015 at 10:17:55AM -0600, Jason Gunthorpe wrote: > On Wed, Apr 22, 2015 at 05:23:28PM +0200, Luis R. Rodriguez wrote: > > On Tue, Apr 21, 2015 at 11:39:39PM -0600, Jason Gunthorpe wrote: > > > On Wed, Apr 22, 2015 at 01:39:07AM +0200, Luis R. Rodriguez wrote: >

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-22 Thread Luis R. Rodriguez
On Wed, Apr 22, 2015 at 09:53:03AM -0700, Andy Lutomirski wrote: > On Wed, Apr 22, 2015 at 8:23 AM, Luis R. Rodriguez wrote: > > On Tue, Apr 21, 2015 at 11:39:39PM -0600, Jason Gunthorpe wrote: > >> On Wed, Apr 22, 2015 at 01:39:07AM +0200, Luis R. Rodriguez wrote: > >>

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-22 Thread Luis R. Rodriguez
On Wed, Apr 22, 2015 at 02:53:11PM -0400, Doug Ledford wrote: > On Wed, 2015-04-22 at 10:17 -0600, Jason Gunthorpe wrote: > > On Wed, Apr 22, 2015 at 05:23:28PM +0200, Luis R. Rodriguez wrote: > > > On Tue, Apr 21, 2015 at 11:39:39PM -0600, Jason Gunthorpe wrote: > > > &

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-22 Thread Luis R. Rodriguez
On Wed, Apr 22, 2015 at 12:10 PM, Doug Ledford wrote: > On Wed, 2015-04-22 at 21:05 +0200, Luis R. Rodriguez wrote: > >> > > I'd also love to remove the driver if it turns out there are actually >> > > no users. qib substantially replaces it except for a few ver

[PATCH] [media] ivtv: use arch_phys_wc_add() and require PAT disabled

2015-04-22 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" We are burrying direct access to MTRR code support on x86 in order to take advantage of PAT. In the future we also want to make the default behaviour of ioremap_nocache() to use strong UC, use of mtrr_add() on those systems would make write-combining void. I

Re: [PATCH 00/22] Add and use pci_zalloc_consistent

2014-06-23 Thread Luis R. Rodriguez
On Mon, Jun 23, 2014 at 06:41:28AM -0700, Joe Perches wrote: > Adding the helper reduces object code size as well as overall > source size line count. > > It's also consistent with all the various zalloc mechanisms > in the kernel. > > Done with a simple cocci script and some typing. Awesome, an

Re: Removal of regulator framework

2014-07-23 Thread Luis R. Rodriguez
On Sat, Jul 19, 2014 at 9:19 AM, Hauke Mehrtens wrote: > Maintaining the regulator drivers in backports costs some time and I do > not need them. Is anybody using the regulator drivers from backports? I > would like to remove them. That came simply from collateral of backporting media drivers, ev

Re: Removal of regulator framework

2014-07-23 Thread Luis R. Rodriguez
On Wed, Jul 23, 2014 at 10:57 AM, Mauro Carvalho Chehab wrote: > Em Wed, 23 Jul 2014 10:13:28 -0700 > "Luis R. Rodriguez" escreveu: > >> On Sat, Jul 19, 2014 at 9:19 AM, Hauke Mehrtens wrote: >> > Maintaining the regulator drivers in backports costs some ti

Re: Removal of regulator framework

2014-07-23 Thread Luis R. Rodriguez
On Wed, Jul 23, 2014 at 11:56 AM, Hauke Mehrtens wrote: > carrying some regularity drivers which are needed for some specific > media driver does not look like a big problem. The current problem from > my side is that we carry all regularity drivers by default and that > causes some problems. Many

Re: randconfig build error with next-20140829, in drivers/media/usb/dvb-usb/technisat-usb2.c

2014-08-30 Thread Luis R. Rodriguez
On Fri, Aug 29, 2014 at 09:19:42AM -0700, Jim Davis wrote: > Building with the attached random configuration file, > > LD init/built-in.o > drivers/built-in.o: In function `technisat_usb2_set_voltage': > technisat-usb2.c:(.text+0x3b4919): undefined reference to `stv090x_set_gpio' > make: **