Re: Summary of the pending patches up to Dec, 31 (26 patches)

://patchwork.kernel.org/patch/118147 Marko Ristola > This patch affects equally for both dvb_dmx_swfilter() and dvb_dmx_swfilter_204(). The resulting performance and functionality is similar with dvb_dmx_swfilter_packets(). dvb_dmx_swfilter(_204)() have robustness checks. Devices witho

Re: Remote control not working for Terratec Cinergy C (2.6.37 Mantis driver)

kernels. I haven't seen remote control working lately. Turning mantis module debug options on gives some information what is happening into /var/log/messages. Regards, Marko Ristola Thanks in advance, Jonas -- To unsubscribe from this list: send the line "unsubscribe linux-media

Re: Remote control not working for Terratec Cinergy C (2.6.37 Mantis driver)

s driver, No UART can work with Mantis in vanilla kernel. You can try to check mantis directory and mantis_uart.c, and see if there are some input_device_XXX functions. A good reference for implementation might be media/dvb/ttpci/av7110_ir.c: it looks like a working implementation with input dev

Re: [Q]: any DVB-S2 card which is 45MS/s capable?

aster. Best regards, Marko Ristola 27.07.2010 18:11, VDR User wrote: On Tue, Jul 27, 2010 at 5:52 AM, Emmanuel wrote: VDR User a écrit : Look at the vp-1041 I think. From what I gathered it is not able to do 45MS/s for DVB-S2. Thanks anyway, You may want to ask Manu Abraham (author of the manti

Re: [Q]: any DVB-S2 card which is 45MS/s capable?

03.08.2010 06:20, Emmanuel wrote: Marko Ristola a écrit : Hi. I have written some Mantis bandwidth related DMA transfer optimizations on June/July this year. They are now waiting for approval by Manu Abraham. Those reduce CPU pressure, increasing the bandwidth that can be received from the

Re: [RFC/PATCH v3 06/10] media: Entities, pads and links enumeration

hy and stream flow capability hierarchy) at necessary points, and use buses to bind the entities/pads by links to each other. A single wire with just two end points can also be thought like a bus. Regards, Marko Ristola [ snip ] -- To unsubscribe from this list: send the line "unsubscribe linux

Re: [RFC/PATCH v3 06/10] media: Entities, pads and links enumeration

05.08.2010 12:38, Laurent Pinchart wrote: Hi Marko, On Wednesday 04 August 2010 21:28:22 Marko Ristola wrote: Hi Hans and Laurent. I hope my thoughts help you further. Thank you for sharing them. Thank you for taking time to answer for me. [ snip ] There's probably some confusion

Re: [PATCH] Avoid unnecessary data copying inside dvb_dmx_swfilter_204() function

Hi. This patch is like the original, but without mangled spaces. I found Documentation/email-clients.txt to be useful for tuning Thunderbird. DVB-S2 users with high volume stream data are interested in trying this patch too. Signed-off-by: Marko Ristola diff --git a/drivers/media/dvb/dvb

Re: [PATCH] Avoid unnecessary data copying inside dvb_dmx_swfilter_204() function

Hi The old patch with broken spaces is https://patchwork.kernel.org/patch/108274/ The one with good patch and bad introduction is https://patchwork.kernel.org/patch/118147/ Regards, Marko Ristola 07.08.2010 12:47, Marko Ristola wrote: > > Hi. > > This patch is like the original,

[PATCH] Refactor Mantis DMA transfer to deliver 16Kb TS data per interrupt

after changing the TS. One effect of the old version was, that the DMA transfer and driver's DMA buffer access might happen at the same time - a race condition. Signed-off-by: Marko M. Ristola Regards, Marko Ristola diff --git a/drivers/media/dvb/mantis/hopper_cards.c b/drivers/media/dvb/m

Pending dvb_dmx_swfilter(_204)() patch tested enough

ear period. I was asked by a person this week that if the patch could go forward. Regards, Marko Ristola -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Pending dvb_dmx_swfilter(_204)() patch tested enough

Hello Andreas and Mauro Thank you for looking at the patch. Than you Mauro for giving the likely() unlikely() GCC assembly example and remind of scripts/checkpatch.pl. 28.03.2011 15:07, Andreas Oberritter wrote: Hello Marko, On 03/26/2011 09:20 PM, Marko Ristola wrote: Following patch has

[PATCH] Speed up DVB TS stream delivery from DMA buffer into dvb-core's buffer

Avoid unnecessary DVB TS 188 sized packet copying from DMA buffer into stack. Backtrack one 188 sized packet just after some garbage bytes when possible. This obsoletes patch https://patchwork.kernel.org/patch/118147/ Signed-off-by: Marko Ristola marko.rist...@kolumbus.fi diff --git a/drivers

Re: [PATCH] Speed up DVB TS stream delivery from DMA buffer into dvb-core's buffer

ly" functions using patch. Regards, Marko Ristola 08.04.2011 18:40, Marko Ristola kirjoitti: > Avoid unnecessary DVB TS 188 sized packet copying from DMA buffer into stack. > Backtrack one 188 sized packet just after some garbage bytes when possible. > This obsoletes patch https://patchwo

Re: Remote control not working for Terratec Cinergy C (2.6.37 Mantis driver)

04.05.2011 01:42, Adrian C. kirjoitti: > On Wed, 2 Mar 2011, Marko Ristola wrote: > >> So this means, that my remote control works, pressing key with hex >> value 0x26 works. > > It works. > >> Unfortunately mantis_uart.c doesn't have IR input initiali

Re: AW: Remote control not working for Terratec Cinergy C (2.6.37 Mantis driver)

't come a '1 pressed' from remote within 30ms, then driver sends "key 1 unpressed to input layer". I don't know if there is any reusable algorithm (easilly usable code) for remote control drivers for this. Regards, Marko Ristola 21.05.2011 10:23, Adrian C. kirjoit

Re: [PATCH] Refactor Mantis DMA transfer to deliver 16Kb TS data per interrupt

garbage generating problem, if you want to have a quick look. Regards, Marko Ristola When I wrote this patch, I took lots of time to understand the RISC processor's commands from Manu's existing code and from Manu's old Internet references

Re: [RFCv2 PATCH 0/5] tuner-core: fix s_std and s_tuner

when both "frontends" are sleeping. If only one sleeps, the one can be put to sleep or suspended, but power button can't be touched. What do you think? I did this easy case mantis_core.ko solution in about Summer 2007. It needs a rewrite and testing, if I take it from the

Re: [RFCv2 PATCH 0/5] tuner-core: fix s_std and s_tuner

06.07.2011 21:17, Devin Heitmueller kirjoitti: > On Wed, Jul 6, 2011 at 1:53 PM, Marko Ristola > wrote: >> > > All that said, I believe that you are correct in that the business > logic needs to ultimately be decided by the bridge driver, rather than > having the dvb/tu

Re: [RFCv2 PATCH 0/5] tuner-core: fix s_std and s_tuner

Mauro Carvalho Chehab kirjoitti: > Em 06-07-2011 16:59, Marko Ristola escreveu: >> 06.07.2011 21:17, Devin Heitmueller kirjoitti: >>> On Wed, Jul 6, 2011 at 1:53 PM, Marko Ristola >>> wrote: >>>> > > IMO, the proper solution is to provide a core res

Re: Cinergy C PCI HD with current v4l-dvb - PATCH for review/pull included

Hi Bjørn, Thank you for your answer. 19.06.2010 18:34, Bjørn Mork kirjoitti: [ I think this should have been posted to linux-media@vger.kernel.org instead ] Marko Ristola writes: I am now subscribed into that list too, but maybe I start with the small patches instead of the big patch

Re: Cinergy C PCI HD with current v4l-dvb - PATCH for review/pull included

Proving the DMA transfer alignment problem existence isn't easy. So maybe it doesn't exist. I saw only very rare packet losses on picture quality (didn't test h264 this time). I couldn't do the record test though. Too much work. Marko Ristola -- To unsubscribe from this

[PATCH] Mantis DMA transfer cleanup, fixes data corruption and a race, improves performance.

e understandable for reviewers and others. My patch is GPLv2. The patch is made against GIT linuxtv/master, applies cleanly to Mercurial v4l-dvb too. Best regards, Marko Ristola diff --git a/drivers/media/dvb/mantis/hopper_cards.c b/drivers/media/dvb/mantis/hopper_cards.c index 09e9fc7..

[PATCH] Mantis: append tasklet maintenance for DVB stream delivery

ght occur with rmmod. The following patch tries to deactivate the tasklet in mantis_dma_stop and activate it in mantis_dma_start, thus avoiding these cases. Marko Ristola diff --git a/drivers/media/dvb/mantis/mantis_dma.c b/drivers/media/dvb/mantis/mantis_dma.c index 46202a4..cf502a6 100644

Re: [PATCH] Mantis: append tasklet maintenance for DVB stream delivery

ntis->tasklet) must be called inside of mantis-fe->stop_feed(dvbdmxfeed) when necessary. Signed-off-by: Marko Ristola Marko diff --git a/drivers/media/dvb/mantis/mantis_dvb.c b/drivers/media/dvb/mantis/mantis_dvb.c index 99d82ee..a9864f7 100644 --- a/drivers/media/dvb/manti

Re: [PATCH] Mantis, hopper: use MODULE_DEVICE_TABLE use the macro to make modules auto-loadable

21.06.2010 19:51, Bjørn Mork wrote: VDR User writes: Instead of copy&paste patches from Manu's tree, maybe it's better to just wait for him to push all the changes into v4l. I'm Manu sorry about trying to put patches directly into v4-dvb, if those should go onto your branch fi

Re: buffer management

23.06.2010 15:43, Steven Toth kirjoitti: Now, on each video interrupt, I know which SG list i need to read from. At this stage i do need to copy the buffers associated with each of the SG lists at once. In this scenario, I don't see how videobuf could be used, while I keep getting this feeling th

Re: [linux-dvb] Cinergy C PCI HD with current v4l-dvb - PATCH for review/pull included

22.06.2010 22:27, Yannick K wrote: > On 6/19/10 15:56 , Marko Ristola wrote: >> >> Hello all interested in a robust Mantis driver. > hi Marko, > > is there a hg/git branch where your (and possibly Bjorn Morks) recent > patches are already in? > since i had diff

[PATCH] Avoid unnecessary data copying inside dvb_dmx_swfilter_204() function

ftware; you can redistribute it and/or * modify it under the terms of the GNU Lesser General Public License * as published by the Free Software Foundation; either version 2.1 * of the License, or (at your option) any later version. as the original license in that file. Patch written by: Marko Ri

Re: [PATCH] Avoid unnecessary data copying inside dvb_dmx_swfilter_204() function

Hi Here is an improved version of the original patch: The original patch removed unnecessary copying for 204 sized packets only. This patch improves performance for 188 sized packets too. Unnecessary copying means: if dvb_dmx_swfilter(_204)() doesn't have to modify the source packet, the source

Re: TS discontinuity with TT S-2300

27.06.2010 15:37, Oliver Endriss wrote: > Hi, > > On Sunday 27 June 2010 01:05:57 Jaroslav Klaus wrote: > >> Hi, >> >> I'm loosing TS packets in my dual CAM premium TT S-2300 card >> (av7110+saa7146). >> >> I use dvblast to select 4 TV channels (~ 16 PIDs) from multiplex, >> descramble them and

Re: [PATCH] Avoid unnecessary data copying inside dvb_dmx_swfilter_204() function

d 191 bytes into position 986 Regards, Marko Ristola diff --git a/drivers/media/dvb/dvb-core/dvb_demux.c b/drivers/media/dvb/dvb-core/dvb_demux.c index 977ddba..b71d77d 100644 --- a/drivers/media/dvb/dvb-core/dvb_demux.c +++ b/drivers/media/dvb/dvb-core/dvb_demux.c @@ -478,97 +478,96 @@

Re: TS discontinuity with TT S-2300

27.06.2010 21:25, Oliver Endriss wrote: > Are you sure that Mantis driver delivers garbage, not partial packets? > Please note that the dvb_dmx_swfilter[_204]() routines must accept > partial packets, i.e. the rest of the packet will be dellivered with the > next call. > Yes, I'm sure that the g

Mantis DMA interrupt with FTRGT flag?

ove, Stat=<> is hidden. With bttv, FTRGT means something like FIFO overflow. How can I make the error more rare? Regards, Marko Ristola -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: buffer management

One possible problem that remains with this approach, is that what if the DMA buffer gets overwritten? Then the pointers in the ringbuffer might become garbage. Another possible (cache coherency) problem is, that in this scenario you both read and write to the DMA buffer. Maybe with x86 computers

[PATCH] Mantis DMA transfer cleanup, fixes data corruption and a race, improves performance. (signed-off this time)

Hi This is a resend of the exactly same patch than I sent 2010-06-20, to sign off it. Signed-off-by: Marko M Ristola Regards, Marko Ristola - Here is another version of the DMA transfer fix. Please try it. Comments? The current DMA code with

Re: [PATCH] Mantis: append tasklet maintenance for DVB stream delivery

be called. There is a risk that dvb_dmx_swfilter() references freed resources (memory or spinlocks or ???) causing instabilities. Thus tasklet_disable(&mantis->tasklet) must be called inside of mantis-fe->stop_feed(dvbdmxfeed) when necessary. Signed-off-by: Marko Ristola Marko diff --git

Mantis driver patch: use interrupt for I2C traffic instead of busy registry polling

, that the heavy PCI contention by polling is justified. Or is it? I looked at saa7146_i2c.c from Linux kernel, how to use wait_event_interruptible_timeout. Signed-off-by: Marko M Ristola Regards, Marko Ristola diff --git a/drivers/media/dvb/mantis/mantis_cards.c b/drivers/media/dvb/mantis/m

Thoughts about suspending DVB C PCI device transparently

used? For my current usage, powering off the unused tuner gives more power savings than implementing suspend/resume. Marko Ristola -- // suspend to standby, ram or disk. int mantis_dvb_suspend(struct mantis_pci *mantis, pm_message_t prevState, pm_message_t mesg) {

Re: USB mini-summit at LinuxCon Vancouver

ss. If the driver would not get all three locks, it would not lock any of them (with _trylock case). I don't have time to implement this feature. Happy meeting for all of you, Marko Ristola -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a m

Re: [GIT PATCHES FOR 2.6.38] mantis for_2.6.38

Hi Bjørn Mork and Mauro Carvalho Chehab. The following patch was an experiment and wasn't actually meant for inclusion into the Kernel. >>> Jul,10 2010: Mantis driver patch: use interrupt for I2C traffic instead of >>> busy reg http://patchwork.kernel.org/patc

Re: Thoughts about suspending DVB C PCI device transparently

uspend, FE lock waited and DMA transfer turned back on. Other kernel parts (the framework) took care that no user space program will interfere during the resume process. Media/dvb-core didn't need any changes for this to work. Regards, Marko Ristola 20.11.2010 14:57, Richard Zidlicky wro

Re: [PATCH] Various nits, fixes and hacks for mantis CA support on SMP

03.03.2012 01:21, Steinar H. Gunderson kirjoitti: > On Sat, Mar 03, 2012 at 12:42:19AM +0200, Marko Ristola wrote: >> I'm not happy with I2CDONE busy looping either. >> I've tried twice lately to swith into I2C IRQ, but those patches have caused >> I2CDONE tim

Re: [PATCH 04/11] Show timeouts on I2C transfers.

I had a plan to rework I2C handling a lot more, than log the changes. I wrote a patch that uses I2C IRQ. I had a feeling that it worked well (with old single CPU desktop computer): framerate with HDTV was low, but it was glitchless. Do you want to have the patch to be sent for you? I think that

Re: [PATCH] Various nits, fixes and hacks for mantis CA support on SMP

ad 1 turns I2C gate into DVB frontend and sets up frequency. It waits 10ms. Thread 2 will talk to some I2C device, thus breaking the silence. This case would not be so bad, because it would just delay taking the wanted DVB TS lock. Regards, Marko Ristola 28.02.2012 03:03, Steinar H. Gunderson

Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

pen(dev); ... send_i2c_messages(); if (num == 5 && is_tda665()) usleep(50); if (is_tda665(addr)) send_msg_tda665_gate_close(dev); mutex_unlock(&dev->i2c_lock); } Regards, Marko Ristola On 06/21/2012 10:10 PM, Mauro Carvalho Chehab wrote: Em 21-06-2012 10:36, Mauro

Re: DVB core enhancements - comments please?

Hi Antti. My suspend / resume patch implemented "Kaffeine continues viewing channel after resume". Some of the ideas could be still useful: http://www.spinics.net/lists/linux-dvb/msg19651.html Rest of this email has a more thorough description. Regards, Marko Ristola On 06/28/201

Re: DVB core enhancements - comments please?

Moikka Antti. On 07/01/2012 02:11 PM, Antti Palosaari wrote: Moikka Marko, -- snip -- Hmm, I did some initial suspend / resume changes for DVB USB when I rewrote it recently. On suspend, it just kills all ongoing urbs used for streaming. And on resume it resubmit those urbs in order to r

Re: Mantis CAM not SMP safe / Activating CAM on Technisat Skystar HD2 (DVB-S2)

list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Regards, Marko Ristola --- PATCH -- Mantis/Hopper: Check and clear G

Re: Multiple Mantis devices gives me glitches

x this yet though. Regards, Marko Ristola --- Refactor Mantis DMA transfer to deliver 16Kb TS data per interrupt https://patchwork.kernel.org/patch/107036/ With VDR streaming HDTV into network, generating an interrupt onc

Re: Multiple Mantis devices gives me glitches

13.12.2011 20:11, Vidar Tyldum kirjoitti: 13.12.2011 08:31, Marko Ristola: Hi Here is a patch that went into Linus GIT this year. It reduces the number of DMA transfer interrupts into one third. Linus released 2.6.38.8 doesn't seem to have this patch yet Good news, combining this patch

[PATCH] Mantis and Hopper: Fix CAM hangup caused by losing GPIF status

angup takes about 3-5s.) Signed-off-by: Marko Ristola diff --git a/drivers/media/dvb/mantis/hopper_cards.c b/drivers/media/dvb/mantis/hopper_cards.c index 71622f6..c2084e9 100644 --- a/drivers/media/dvb/mantis/hopper_cards.c +++ b/drivers/media/dvb/mantis/hopper_cards.c @@ -84,15 +84,6 @@ s