[PATCH 2/2] [media] c8sectpfe: forward err instead of returning an uninitialized variable

2015-09-20 Thread Nicolas Iooss
() to the caller of load_c8sectpfe_fw_step1(). Signed-off-by: Nicolas Iooss <nicolas.iooss_li...@m4x.org> --- drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers

[PATCH 1/2] [media] c8sectpfe: initialize err in load_slim_core_fw

2015-09-20 Thread Nicolas Iooss
load_slim_core_fw() uses a for loop with !err in its condition without first initializing err. Fix this by setting err to 0 in its definition. Signed-off-by: Nicolas Iooss <nicolas.iooss_li...@m4x.org> --- drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 2 +- 1 file changed, 1 ins

[PATCH 1/1] [media] ite-cir: initialize use_demodulator before using it

2016-09-10 Thread Nicolas Iooss
based ite-cir driver for several ITE CIRs") Signed-off-by: Nicolas Iooss <nicolas.iooss_li...@m4x.org> --- drivers/media/rc/ite-cir.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/rc/ite-cir.c b/drivers/media/rc/ite-cir.c index 0f301903aa6f..63165d324fff 100644 --- a/

[PATCH 1/1] [media] mb86a20s: always initialize a return value

2016-09-10 Thread Nicolas Iooss
. Signed-off-by: Nicolas Iooss <nicolas.iooss_li...@m4x.org> --- drivers/media/dvb-frontends/mb86a20s.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/dvb-frontends/mb86a20s.c b/drivers/media/dvb-frontends/mb86a20s.c index 41325328a22e..eca07432645e 100644 --- a/drivers/med

Re: [PATCH 1/1] [media] mb86a20s: always initialize a return value

2016-10-23 Thread Nicolas Iooss
:49, Nicolas Iooss wrote: > In mb86a20s_read_status_and_stats(), when mb86a20s_read_status() fails, > the function returns the value in variable rc without initializing it > first. Fix this by propagating the error code from variable status_nr. > > This bug has been fo

Re: [PATCH 1/1] [media] ite-cir: initialize use_demodulator before using it

2016-10-23 Thread Nicolas Iooss
, Nicolas Iooss wrote: > Function ite_set_carrier_params() uses variable use_demodulator after > having initialized it to false in some if branches, but this variable is > never set to true otherwise. > > This bug has been found using clang -Wsometimes-uninitialized warning >

[PATCH 1/1] [media] tw686x: silent -Wformat-security warning

2016-11-26 Thread Nicolas Iooss
rity issue. Nevertheless adding a "%s" format string to silent the warning helps to detect real bugs in the kernel. Signed-off-by: Nicolas Iooss <nicolas.iooss_li...@m4x.org> --- drivers/media/pci/tw686x/tw686x-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCH] [media] am437x-vpfe: always assign bpp variable

2016-12-27 Thread Nicolas Iooss
has been found by compiling the kernel with clang. Fixes: 417d2e507edc ("[media] media: platform: add VPFE capture driver support for AM437X") Cc: sta...@vger.kernel.org Signed-off-by: Nicolas Iooss <nicolas.iooss_li...@m4x.org> --- drivers/media/platform/am437x/am437x-vpfe.c | 2 +-

[PATCH 1/1] [media] v4l: rcar_fdp1: use %4.4s to format a 4-byte string

2016-12-26 Thread Nicolas Iooss
mat specifier "%4.4s" is also used by other media drivers to print pixelformat value. Signed-off-by: Nicolas Iooss <nicolas.iooss_li...@m4x.org> --- drivers/media/platform/rcar_fdp1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform

[PATCH 1/1] staging/atomisp: fix header guards

2017-09-03 Thread Nicolas Iooss
#ifndef. Fixes: a49d25364dfb ("staging/atomisp: Add support for the Intel IPU v2") Signed-off-by: Nicolas Iooss <nicolas.iooss_li...@m4x.org> --- .../css2400/css_2400_system/hrt/input_formatter_subsystem_defs.h| 2 +- .../css2400/css_2401_csi2p_system/hrt/input_formatter_subsy