-by: Robert Jarzmik
---
drivers/media/i2c/soc_camera/mt9m111.c | 51 ++
1 file changed, 15 insertions(+), 36 deletions(-)
diff --git a/drivers/media/i2c/soc_camera/mt9m111.c
b/drivers/media/i2c/soc_camera/mt9m111.c
index 6dfaead6aaa8..a7efaa5964d1 100644
--- a
There is no change between v4 and v5, ie. the global diff is empty, only one
line was shifted to prevent breaking bisectablility.
All the text in https://lkml.org/lkml/2016/8/15/609 is still applicable.
Cheers.
--
Robert
Robert Jarzmik (13):
media: mt9m111: make a standalone v4l2 subdevice
Add pxa_camera registers access through advanced video debugging.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/pxa_camera.c | 32 ++
1 file changed, 32 insertions(+)
diff --git a/drivers/media/platform/soc_camera/pxa_camera.c
b/drivers/media
Make all print consistent by always using :
- dev_xxx(pcdev_to_dev(pcdev), )
This prepares the soc_camera adherence removal by making these call rely
on only pcdev, and not the soc_camera icd structure.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/pxa_camera.c | 70
ned-off-by: Robert Jarzmik
---
Since v1: took into account Hans's comments
renamed all vb2 functions to pxac_vb2_*()
Since v2: spit queue_buffer() and start_streaming()
Since v3: replace void *alloc_ctxs by struct device *alloc_devs
Since v4: move the queue device initialization to
As the conversion to a v4l2 standalone device is finished, move
pxa_camera one directory up and finish severing any dependency to
soc_camera.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/Kconfig |8 +
drivers/media/platform/Makefile|1
Introduce sensor_call(), which will be used for all sensor invocations.
This is a preparation move to v4l2 device conversion, ie. soc_camera
adherence removal.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/pxa_camera.c | 27 ++
1 file changed, 15
mt9m111 being a camera sensor, its colorspace should always be SRGB, for
both RGB based formats or YCbCr based ones.
Signed-off-by: Robert Jarzmik
---
drivers/media/i2c/soc_camera/mt9m111.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/soc_camera
As the mt9m111 is now working as a standalone v4l2 subdevice sensor,
move it out of soc_camera directory and severe its dependency on
soc_camera.
Signed-off-by: Robert Jarzmik
---
drivers/media/i2c/Kconfig |7 +
drivers/media/i2c/Makefile |1 +
drivers/media/i2c
a "cancel capture" than a "wait for end
of capture" semantic.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/pxa_camera.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/soc_camera/pxa_camer
doesn't modify a single line of code.
Signed-off-by: Robert Jarzmik
---
Since v3: replace void *alloc_ctxt by struct device *alloc_devs impact
Since v4: videobuf2 device init change impact
---
drivers/media/platform/soc_camera/pxa_camera.c | 473 +
1 file changed
Add sequence numbers to completed buffers.
Signed-off-by: Robert Jarzmik
---
Since v3: reset buffer sequence number in start_streaming()
---
drivers/media/platform/soc_camera/pxa_camera.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/media/platform/soc_camera/pxa_camera.c
b
This is to be seen as a regression as the set_crop function is
removed. This is a temporary situation in the v4l2 porting, and will
have to be added later.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/pxa_camera.c | 76 --
1 file changed, 76
sing.
In a subsequence patch pxa_camera_mclk_ops should be used, and
platform data MCLK ignored. It will be the sensor's duty to request
the clock and enable it, which will end in pxa_camera_mclk_ops.
Signed-off-by: Robert Jarzmik
---
Since v1:
- function namings were cleaned into pxac_XXX_Y
Guennadi Liakhovetski writes:
> Hi Robert,
>
> On Mon, 29 Aug 2016, Robert Jarzmik wrote:
>
>> Remove the soc_camera adherence. Mostly the change removes the power
>> manipulation provided by soc_camera, and instead :
>> - powers on the sensor when the s_power con
Hans Verkuil writes:
> On 08/29/2016 07:55 PM, Robert Jarzmik wrote:
>> There is no change between v4 and v5, ie. the global diff is empty, only one
>> line was shifted to prevent breaking bisectablility.
>
> Against which tree do you develop? Unfortunately this patch se
This is to be seen as a regression as the set_selection (former
set_crop) function is removed. This is a temporary situation in the v4l2
porting, and will have to be added later.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/pxa_camera.c | 83 --
1
sing.
In a subsequence patch pxa_camera_mclk_ops should be used, and
platform data MCLK ignored. It will be the sensor's duty to request
the clock and enable it, which will end in pxa_camera_mclk_ops.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/Kconfig | 2
Add sequence numbers to completed buffers.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/pxa_camera.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/media/platform/soc_camera/pxa_camera.c
b/drivers/media/platform/soc_camera/pxa_camera.c
index
ned-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/Kconfig | 4 +-
drivers/media/platform/soc_camera/pxa_camera.c | 579 -
2 files changed, 269 insertions(+), 314 deletions(-)
diff --git a/drivers/media/platform/soc_camera/Kconfig
b/drivers/medi
As the mt9m111 is now working as a standalone v4l2 subdevice sensor,
move it out of soc_camera directory and severe its dependency on
soc_camera.
Signed-off-by: Robert Jarzmik
---
drivers/media/i2c/Kconfig| 7 +++
drivers/media/i2c/Makefile | 1
mt9m111 being a camera sensor, its colorspace should always be SRGB, for
both RGB based formats or YCbCr based ones.
Signed-off-by: Robert Jarzmik
---
drivers/media/i2c/soc_camera/mt9m111.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/i2c/soc_camera
doesn't modify a single line of code.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/pxa_camera.c | 473 +
1 file changed, 241 insertions(+), 232 deletions(-)
diff --git a/drivers/media/platform/soc_camera/pxa_camera.c
b/drivers/media/platform/soc_c
also drops support for inverters on synchronisation and clock
lines. It is assumed, if any board ever needs such inverters, support
for them can be added in the future
Acked-by: Guennadi Liakhovetski
Signed-off-by: Robert Jarzmik
---
drivers/media/i2c/soc_camera/mt9m111.c | 51
Make all print consistent by always using :
- dev_xxx(pcdev_to_dev(pcdev), )
This prepares the soc_camera adherence removal by making these call rely
on only pcdev, and not the soc_camera icd structure.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/pxa_camera.c | 70
This is a tiny fix for a switch case which quiets 2 checkpatch harmless
warnings. The generated code is not affected.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/pxa_camera.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/pxa_camera.c
b/drivers/media
a "cancel capture" than a "wait for end
of capture" semantic.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/pxa_camera.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/drivers/media/platform/soc_camera/pxa_camer
Add pxa_camera registers access through advanced video debugging.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/pxa_camera.c | 32 ++
1 file changed, 32 insertions(+)
diff --git a/drivers/media/platform/soc_camera/pxa_camera.c
b/drivers/media
As the conversion to a v4l2 standalone device is finished, move
pxa_camera one directory up and finish severing any dependency to
soc_camera.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/Kconfig | 8
drivers/media/platform/Makefile
Introduce sensor_call(), which will be used for all sensor invocations.
This is a preparation move to v4l2 device conversion, ie. soc_camera
adherence removal.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/pxa_camera.c | 27 ++
1 file changed, 15
Hans Verkuil writes:
> Allow building this driver if COMPILE_TEST is set.
>
> Signed-off-by: Hans Verkuil
Acked-by: Robert Jarzmik
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
Mor
*soc_mbus_xlate_by_fourcc(
>^~~~
>
> Signed-off-by: Mauro Carvalho Chehab
Acked-by: Robert Jarzmik
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordo
able]
> struct pxa_buffer *active;
> ^~
>
> Signed-off-by: Mauro Carvalho Chehab
Acked-by: Robert Jarzmik
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
b2_core_streamon+0x1b4): undefined reference to
> `v4l_vb2q_enable_media_source'
> drivers/media/v4l2-core/videobuf2-v4l2.o: In function `vb2_ioctl_reqbufs':
> videobuf2-v4l2.c:(.text.vb2_ioctl_reqbufs+0xc): undefined reference to
> `video_devdata'
>
> Th
gned-off-by: Wei Yongjun
Acked-by: Robert Jarzmik
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Wei Yongjun writes:
> From: Wei Yongjun
>
> Remove duplicated include.
>
> Signed-off-by: Wei Yongjun
Acked-by: Robert Jarzmik
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.
tures from soc_mediabus and renames it
> to pxa_mbus_*.
>
> The large table of formats has been culled a bit, removing formats that are
> not supported
> by this driver.
>
> Signed-off-by: Hans Verkuil
> Cc: Robert Jarzmik
Hi Hans,
I wonder why you chose to copy-paste this co
i driver out of soc_camera.
Ok, fair enough.
I have tested that for at least YUV422, YUYV, YVYU and RGB565 formats :
Tested-by: Robert Jarzmik
Cheers.
--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
During sensors binding, there is a window where the sensor is switched
off, while there is a call it to set a new format, which can end up in
an access to the sensor, especially an I2C based sensor.
Remove this window by activating the sensor.
Signed-off-by: Robert Jarzmik
---
drivers/media
plug in a
gpio based or ldo regulator, mimicking their former soc_camera power
hook.
Fixes: 5c10113cc668 ("media: mt9m111: make a standalone v4l2 subdevice")
Signed-off-by: Robert Jarzmik
---
drivers/media/i2c/mt9m111.c | 14 ++
1 file changed, 14 insertions(+)
diff --git
Signed-off-by: Mauro Carvalho Chehab
> ---
> drivers/media/platform/mx2_emmaprp.c | 3 +--
> drivers/media/platform/pxa_camera.c | 6 ++
> drivers/media/platform/via-camera.c | 7 ++-
> 3 files changed, 5 insertions(+), 11 deletions(-)
For pxa_camera, FWIW:
Acked-by: Rober
Robert Jarzmik writes:
> During sensors binding, there is a window where the sensor is switched
> off, while there is a call it to set a new format, which can end up in
> an access to the sensor, especially an I2C based sensor.
>
> Remove this window by activating the sensor.
Hi
Mauro Carvalho Chehab writes:
> Hi Sakari,
>
> Em Fri, 31 May 2019 14:27:24 +0300
> Sakari Ailus escreveu:
>
>> Hi Mauro,
>>
>> On Wed, May 29, 2019 at 03:25:18PM -0400, Mauro Carvalho Chehab wrote:
>> > From: Robert Jarzmik
>
> As stated here
Akinobu Mita writes:
>> Can anyone test this patch and send a tested-by?
>
> In my devicetree, vdd-supply is not defined. So it falls back to the dummy
> regulator and works fine.
Would that work also in a non devicetree build, ie. in a platform_data based one
(as this is one of the mach-pxa tar
Mauro Carvalho Chehab writes:
> From: Robert Jarzmik
>
> In the soc_camera removal, the board specific power callback was
> dropped. This at least will remove the power optimization from ezx and
> em-x270 pxa based boards.
>
> As to recreate the same level of functional
that the cpu device provides the DMA
- I added pxa2xx-i2s which was forgotten
Therefore I need a new ack
- Arnd and Daniel / SSP topic / 0013
Review and ack of this one
Happy review.
--
Robert
Robert Jarzmik (13):
dmaengine: pxa: use a dma slave map
ARM: pxa: add dma slave map
-off-by: Robert Jarzmik
---
drivers/net/ethernet/smsc/smc91x.c | 12 +---
drivers/net/ethernet/smsc/smc91x.h | 1 -
2 files changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/net/ethernet/smsc/smc91x.c
b/drivers/net/ethernet/smsc/smc91x.c
index 080428762858..4c600f430f6d
x" or "tx".
- for device tree platforms, the dma node should be hooked into the
pxa2xx-ac97 or pxa-ssp-dai node.
Signed-off-by: Robert Jarzmik
---
Since v1: Removed channel names from platform_data
---
arch/arm/plat-pxa/ssp.c| 47 -
tatic, and the DMA resources removed from
device.c.
Signed-off-by: Robert Jarzmik
Reported-by: Arnd Bergmann
Acked-by: Vinod Koul
---
drivers/dma/pxa_dma.c | 10 +-
include/linux/platform_data/mmp_dma.h | 4
2 files changed, 13 insertions(+), 1 deletion(-)
diff --
-off-by: Robert Jarzmik
Acked-by: Hans Verkuil
Acked-by: Mauro Carvalho Chehab
---
drivers/media/platform/pxa_camera.c | 22 +++---
1 file changed, 3 insertions(+), 19 deletions(-)
diff --git a/drivers/media/platform/pxa_camera.c
b/drivers/media/platform/pxa_camera.c
index
-off-by: Signed-off-by: Daniel Mack
Signed-off-by: Robert Jarzmik
---
drivers/mtd/nand/raw/marvell_nand.c | 17 +
1 file changed, 1 insertion(+), 16 deletions(-)
diff --git a/drivers/mtd/nand/raw/marvell_nand.c
b/drivers/mtd/nand/raw/marvell_nand.c
index 10e953218948
Add some documentation for the pxad_param structure, and describe the
contract behind the minimal required priority of a DMA channel.
Signed-off-by: Robert Jarzmik
---
include/linux/dma/pxa-dma.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/include/linux/dma/pxa-dma.h b/include
As the pxa architecture and all its related drivers do not rely anymore
on the filter function, thanks to the slave map conversion, make
pxad_filter_fn() static, and remove it from the global namespace.
Signed-off-by: Robert Jarzmik
---
drivers/dma/pxa_dma.c | 5 ++---
include/linux/dma
-off-by: Robert Jarzmik
---
sound/arm/pxa2xx-ac97.c | 14 ++
sound/arm/pxa2xx-pcm-lib.c | 6 +++---
sound/soc/pxa/pxa2xx-ac97.c | 32 +---
sound/soc/pxa/pxa2xx-i2s.c | 6 ++
4 files changed, 12 insertions(+), 46 deletions(-)
diff --git a/sound
-off-by: Robert Jarzmik
Acked-by: Ulf Hansson
---
drivers/mmc/host/pxamci.c | 29 +++--
1 file changed, 3 insertions(+), 26 deletions(-)
diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
index c763b404510f..6c94474e36f4 100644
--- a/drivers/mmc/host
-off-by: Robert Jarzmik
Acked-by: Bartlomiej Zolnierkiewicz
---
drivers/ata/pata_pxa.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c
index f6c46e9a4dc0..e8b6a2e464c9 100644
--- a/drivers/ata/pata_pxa.c
+++ b/drivers
In order to remove the specific knowledge of the dma mapping from PXA
drivers, add a default slave map for pxa architectures.
This is the first step, and once all drivers are converted,
pxad_filter_fn() will be made static, and the DMA resources removed from
device.c.
Signed-off-by: Robert
-off-by: Robert Jarzmik
---
drivers/net/ethernet/smsc/smc911x.c | 16 ++--
1 file changed, 2 insertions(+), 14 deletions(-)
diff --git a/drivers/net/ethernet/smsc/smc911x.c
b/drivers/net/ethernet/smsc/smc911x.c
index 05157442a980..4c3713bd5caa 100644
--- a/drivers/net/ethernet/smsc
As the last driver using the former mechanism to acquire the DMA
requestor line has be converted to the dma_slave_map, remove all these
resources from the PXA devices.
Signed-off-by: Robert Jarzmik
---
arch/arm/mach-pxa/devices.c | 136
1 file
From: Robert Jarzmik
As the pxa architecture switched towards the dmaengine slave map, the
old compatibility mechanism to acquire the dma requestor line number and
priority are not needed anymore.
This patch simplifies the dma resource acquisition, using the more
generic function
From: Robert Jarzmik
As the pxa architecture switched towards the dmaengine slave map, the
old compatibility mechanism to acquire the dma requestor line number and
priority are not needed anymore.
This patch simplifies the dma resource acquisition, using the more
generic function
As the last driver using the former mechanism to acquire the DMA
requestor line has be converted to the dma_slave_map, remove all these
resources from the PXA devices.
Signed-off-by: Robert Jarzmik
---
arch/arm/mach-pxa/devices.c | 136
1 file
In order to prepare for the dma_slave_map change for SSP DMA channels
allocation, the SSP platform devices will now include a platform data
structure which in turn selects which dma channel has to be used for
data transfers, especially the PCM ones.
Signed-off-by: Robert Jarzmik
---
arch/arm
device tree platforms, the dma node should be hooked into the
pxa-pcm-audio node.
Signed-off-by: Robert Jarzmik
---
arch/arm/plat-pxa/ssp.c| 50 +-
include/linux/pxa2xx_ssp.h | 4 ++--
sound/soc/pxa/pxa-ssp.c| 5 ++---
3 files changed, 9
As the pxa architecture and all its related drivers do not rely anymore
on the filter function, thanks to the slave map conversion, make
pxad_filter_fn() static, and remove it from the global namespace.
Signed-off-by: Robert Jarzmik
---
drivers/dma/pxa_dma.c | 5 ++---
include/linux/dma
Add some documentation for the pxad_param structure, and describe the
contract behind the minimal required priority of a DMA channel.
Signed-off-by: Robert Jarzmik
---
include/linux/dma/pxa-dma.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/include/linux/dma/pxa-dma.h b/include
-off-by: Robert Jarzmik
---
drivers/ata/pata_pxa.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c
index f6c46e9a4dc0..e8b6a2e464c9 100644
--- a/drivers/ata/pata_pxa.c
+++ b/drivers/ata/pata_pxa.c
@@ -25,7 +25,6
-off-by: Robert Jarzmik
---
drivers/staging/irda/drivers/pxaficp_ir.c | 14 ++
1 file changed, 2 insertions(+), 12 deletions(-)
diff --git a/drivers/staging/irda/drivers/pxaficp_ir.c
b/drivers/staging/irda/drivers/pxaficp_ir.c
index 2ea00a6531f9..9dd6e21dc11e 100644
--- a/drivers
From: Robert Jarzmik
As the pxa architecture switched towards the dmaengine slave map, the
old compatibility mechanism to acquire the dma requestor line number and
priority are not needed anymore.
This patch simplifies the dma resource acquisition, using the more
generic function
From: Robert Jarzmik
As the pxa architecture switched towards the dmaengine slave map, the
old compatibility mechanism to acquire the dma requestor line number and
priority are not needed anymore.
This patch simplifies the dma resource acquisition, using the more
generic function
-off-by: Robert Jarzmik
---
drivers/mmc/host/pxamci.c | 29 +++--
1 file changed, 3 insertions(+), 26 deletions(-)
diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
index c763b404510f..6c94474e36f4 100644
--- a/drivers/mmc/host/pxamci.c
+++ b/drivers/mmc
tatic, and the DMA resources removed from
device.c.
Signed-off-by: Robert Jarzmik
Reported-by: Arnd Bergmann
---
drivers/dma/pxa_dma.c | 10 +-
include/linux/platform_data/mmp_dma.h | 4
2 files changed, 13 insertions(+), 1 deletion(-)
diff --git a/drivers/dma/pxa_
In order to remove the specific knowledge of the dma mapping from PXA
drivers, add a default slave map for pxa architectures.
This is the first step, and once all drivers are converted,
pxad_filter_fn() will be made static, and the DMA resources removed from
device.c.
Signed-off-by: Robert
ware, including :
- pxamci
- pxa_camera
- smc*
- ASoC and SSP
Happy review.
Robert Jarzmik (15):
dmaengine: pxa: use a dma slave map
ARM: pxa: add dma slave map
mmc: pxamci: remove the dmaengine compat need
media: pxa_camera: remove the dmaengine compat need
mtd: nand: pxa3xx: remov
-off-by: Robert Jarzmik
---
sound/arm/pxa2xx-ac97.c | 14 ++
sound/arm/pxa2xx-pcm-lib.c | 6 +++---
sound/soc/pxa/pxa2xx-ac97.c | 32 +---
3 files changed, 10 insertions(+), 42 deletions(-)
diff --git a/sound/arm/pxa2xx-ac97.c b/sound/arm/pxa2xx-ac97.c
Arnd Bergmann writes:
>> + { "smc911x.0", "rx", PDMA_FILTER_PARAM(LOWEST, -1) },
>> + { "smc911x.0", "tx", PDMA_FILTER_PARAM(LOWEST, -1) },
>> + { "smc91x.0", "data", PDMA_FILTER_PARAM(LOWEST, -1) },
>
> This one is interesting, as you are dealing with an off-chip device,
> and
Ulf Hansson writes:
> On 2 April 2018 at 16:26, Robert Jarzmik wrote:
>> Hi,
>>
>> This serie is aimed at removing the dmaengine slave compat use, and transfer
>> knowledge of the DMA requestors into architecture code.
>> As this looks like a patch bomb, each m
Mark Brown writes:
> On Mon, Apr 02, 2018 at 04:26:49PM +0200, Robert Jarzmik wrote:
>> As the pxa architecture switched towards the dmaengine slave map, the
>> old compatibility mechanism to acquire the dma requestor line number and
>> priority are not needed anymore.
>
Wolfram Sang writes:
> This header only contains platform_data. Move it to the proper directory.
>
> Signed-off-by: Wolfram Sang
For mach-pxa:
Acked-by: Robert Jarzmik
Take it through your tree, no problem for the pxa part.
Cheers.
--
Robert
Robert Jarzmik writes:
> From: Robert Jarzmik
>
> As the pxa architecture switched towards the dmaengine slave map, the
> old compatibility mechanism to acquire the dma requestor line number and
> priority are not needed anymore.
>
> This patch simplifies the dma resource a
Sakari Ailus writes:
> V4L2 fwnode matching right now still works based on device nodes, not port
> nodes. Fix this.
Mmmh why does it need a fix, and what's wrong on device node matching ? This
commit message is a bit too brief for me to understand why a fix is needed.
Moreover, does it have an
Hi,
I've been converting pxa_camera driver from videobuf to videobuf2, and I have a
question about multiple plane semantics.
I have a case where I have 3 planes for a yuv422 capture :
- 1 Y plane (total_size / 2 bytes)
- 1 U plane (total_size / 4 bytes)
- 1 V plane (total_size / 4 bytes)
I wo
Robert Jarzmik writes:
> Hi,
>
> I've been converting pxa_camera driver from videobuf to videobuf2, and I have
> a
> question about multiple plane semantics.
>
> I have a case where I have 3 planes for a yuv422 capture :
> - 1 Y plane (total_size / 2 bytes)
> -
Hans Verkuil writes:
> Hi Robert,
>
> In the case of PIX_FMT_YUV422P there is only *one* buffer and the planes are
> laid out in
> that single buffer. So from the point of view of v4l2/vb2 this is a single
> planar
> format and you have a single sglist.h
That's the piece of information I was mi
accept it anyway, and adapt the dmaengine transfer accordingly.
Signed-off-by: Robert Jarzmik
---
I'm not very sure about the locking of the video buffers yet.
---
drivers/media/platform/soc_camera/Kconfig | 4 +-
drivers/media/platform/soc_camera/pxa_camera.c | 598 ---
Hans Verkuil writes:
> Hi Robert,
>
> A quick review below.
>
> I assume this is the first step to moving the pxa_camera driver out of
> soc-camera?
Hi Hans,
It probably is. The next step would be the soc_camera adherence removal. I
already began the work, but it's still in very early draft ugly
Hans Verkuil writes:
> On 03/11/2016 02:41 PM, Robert Jarzmik wrote:
>> Hans Verkuil writes:
> One area where I would like to see some helper functions is with respect to
> format/media bus processing. I played with this a little bit but it is
> surprisingly
> hard to do.
v4l2 devices
- pxa_camera is ported
This sets a ground of discussion for soc_camera adherence removal from
pxa_camera. I'd like to have a comment from Hans if this is what he has in mind,
and Guennadi if he agrees to transfer the soc xlate stuff to soc_mediabus.
Cheers.
--
Robert
Robert
available in the v4l2 device, given any sensors format capabilities
bound with known image processing transformations.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/soc_camera.c | 7 +--
drivers/media/platform/soc_camera/soc_mediabus.c | 65
provided by then sensor, ie. not MCLK, the dual
stage change is not handled yet.
(see all the comments left)
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/pxa_camera.c | 715 ++---
include/linux/platform_data/media/camera-pxa.h | 2 +
2 files changed
Hans Verkuil writes:
> On 03/19/2016 10:01 PM, Robert Jarzmik wrote:
>> Hi Hans and Guennadi,
>>
>> As Hans is converting sh_mobile_ceu_camera.c,
>
> That's not going as fast as I hoped. This driver is quite complex and
> extracting
> it from soc-camera
Hans Verkuil writes:
>> Input ioctls:
>> test VIDIOC_G/S_TUNER/ENUM_FREQ_BANDS: OK (Not Supported)
>> test VIDIOC_G/S_FREQUENCY: OK (Not Supported)
>> test VIDIOC_S_HW_FREQ_SEEK: OK (Not Supported)
>> test VIDIOC_ENUMAUDIO: OK (Not Supported)
>> fail: v4l2-test-in
ned-off-by: Robert Jarzmik
---
Since v1: took into account Hans's comments
renamed all vb2 functions to pxac_vb2_*()
---
drivers/media/platform/soc_camera/Kconfig | 4 +-
drivers/media/platform/soc_camera/pxa_camera.c | 576 -
2 files changed, 266 ins
available in the v4l2 device, given any sensors format capabilities
bound with known image processing transformations.
Signed-off-by: Robert Jarzmik
---
drivers/media/platform/soc_camera/soc_camera.c | 7 +--
drivers/media/platform/soc_camera/soc_mediabus.c | 65
OK (Not Supported)
test MMAP: OK
test USERPTR: OK
test DMABUF: Cannot test, specify --expbuf-device
Total: 45, Succeeded: 45, Failed: 0, Warnings: 6
Robert Jarzmik (2):
media: platform: transfer format translations to soc_mediabus
media: pla
sing.
In a subsequence patch pxa_camera_mclk_ops should be used, and
platform data MCLK ignored. It will be the sensor's duty to request
the clock and enable it, which will end in pxa_camera_mclk_ops.
Signed-off-by: Robert Jarzmik
---
Since v1:
- function namings were cleaned into pxac_XXX_Y
Hans Verkuil writes:
> Hi Robert,
>
> It's been a very busy time for me, and both Guennadi and myself are attending
> the
> ELC the coming week. Speaking for myself that means that it is unlikely I'll
> have
> time to review anything for the next two weeks.
>
> My own renesas driver conversion
Guennadi Liakhovetski writes:
Hi Guennadi,
> Not sure I understand, what should the purpose of this patch be?
See in [1].
> Why do you want to move some function(s) from one file to another? And you
> aren't even calling the new soc_mbus_build_fmts_xlate() function
I'm calling it in pxa_camera_
SF Markus Elfring writes:
> From: Markus Elfring
> Date: Fri, 8 Sep 2017 22:05:14 +0200
>
> Omit an extra message for a memory allocation failure in this function.
>
> This issue was detected by using the Coccinelle software.
>
> Signed-off-by: Markus Elfring
Acked-by:
the ov9640 from the soc_camera.
>
> Signed-off-by: Petr Cvek
Yeah, it's way better with this patch, especially the insmod/rmmod/insmod/rmmod
test.
Tested-by: Robert Jarzmik
Acked-by: Robert Jarzmik
Cheers.
--
Robert
1 - 100 of 323 matches
Mail list logo
