[PATCH 1/1] [media] MFC: Change MFC firmware binary name

This patches renames the MFC firmware binary to avoid SoC name in it. Signed-off-by: Sachin Kamat --- drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c b/drivers/media/video/s5p-mfc

Re: [PATCH] drm/exynos: Add check for IOMMU while passing physically continous memory flag

Hi Vikas, On 2 August 2013 09:23, Vikas Sajjan wrote: > Hi Tomasz, > > > On 2 August 2013 04:50, Tomasz Figa wrote: >> >> Hi Vikas, >> >> On Thursday 01 of August 2013 16:49:32 Vikas Sajjan wrote: >> > While trying to get boot-logo up on exynos5420 SMDK which has eDP panel >> > connected with re

Re: [PATCH] drm/exynos: Add check for IOMMU while passing physically continous memory flag

Hi Vikas, On 1 August 2013 16:49, Vikas Sajjan wrote: > While trying to get boot-logo up on exynos5420 SMDK which has eDP panel > connected with resolution 2560x1600, following error occured even with > IOMMU enabled: > [0.88] [drm:lowlevel_buffer_allocate] *ERROR* failed to allocate buffer.

[PATCH 1/3] [media] exynos4-is: Staticize local symbol

__fimc_is_hw_update_param is used only in this file. Make it static. Signed-off-by: Sachin Kamat --- drivers/media/platform/exynos4-is/fimc-is-param.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/fimc-is-param.c b/drivers/media

[PATCH 3/3] [media] exynos4-is: Fix potential NULL pointer dereference

dev->of_node could be NULL. Hence check for the same and return before dereferencing it in the subsequent error message. Signed-off-by: Sachin Kamat --- drivers/media/platform/exynos4-is/fimc-lite.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/media/platform/exynos4-is/f

[PATCH 2/3] [media] exynos4-is: Annotate unused functions

__is_set_init_isp_aa and fimc_is_hw_set_tune currently do not have any callers. However these functions may be used in the future. Hence instead of deleting them, staticize and annotate them with __maybe_unused flag to avoid compiler warnings. Signed-off-by: Sachin Kamat --- drivers/media

Re: [PATCH 3/3] [media] exynos4-is: Fix potential NULL pointer dereference

Hi Sylwester, On 2 August 2013 14:15, Sylwester Nawrocki wrote: > Hi Sachin, > > On 08/02/2013 08:32 AM, Sachin Kamat wrote: >> dev->of_node could be NULL. Hence check for the same and return before >> dereferencing it in the subsequent error message. >>

[PATCH v2 3/3] [media] exynos4-is: Fix potential NULL pointer dereference

dev->of_node could be NULL. Hence check for the same and return before dereferencing it in the subsequent error message. Signed-off-by: Sachin Kamat --- Changes since v1: Moved the NULL check to beginning of probe. --- drivers/media/platform/exynos4-is/fimc-lite.c | 13 +++-- 1 f

Re: [PATCH 2/3] [media] exynos4-is: Annotate unused functions

Hi Sylwester, On 2 August 2013 12:02, Sachin Kamat wrote: > __is_set_init_isp_aa and fimc_is_hw_set_tune currently do not have > any callers. However these functions may be used in the future. Hence > instead of deleting them, staticize and annotate them with __maybe_unused > f

Re: [RFC v3 01/13] [media] exynos5-is: Adding media device driver for exynos5

On 2 August 2013 20:32, Arun Kumar K wrote: > From: Shaik Ameer Basha > > This patch adds support for media device for EXYNOS5 SoCs. > The current media device supports the following ips to connect > through the media controller framework. > > * MIPI-CSIS > Support interconnection(subdev interf

Re: [PATCH 2/3] [media] exynos4-is: Annotate unused functions

Hi Sylwester, On 5 August 2013 16:35, Sylwester Nawrocki wrote: > Hi Sachin, > > On 08/05/2013 07:12 AM, Sachin Kamat wrote: >> On 2 August 2013 12:02, Sachin Kamat wrote: >>> > __is_set_init_isp_aa and fimc_is_hw_set_tune currently do not have >>> > any

Re: [PATCH v3] drm/exynos: Add fallback option to get non physically continous memory for fb

Hi Vikas, On 6 August 2013 10:53, Vikas Sajjan wrote: > While trying to get boot-logo up on exynos5420 SMDK which has eDP panel > connected with resolution 2560x1600, following error occured even with > IOMMU enabled: > [0.88] [drm:lowlevel_buffer_allocate] *ERROR* failed to allocate buffer.

Re: [RFC v3 09/13] [media] exynos5-fimc-is: Add the hardware pipeline control

Hi Arun, On 4 August 2013 20:30, Sylwester Nawrocki wrote: > Hi Arun, > > On 08/02/2013 05:02 PM, Arun Kumar K wrote: >> >> This patch adds the crucial hardware pipeline control for the >> fimc-is driver. All the subdev nodes will call this pipeline >> interfaces to reach the hardware. Responsibi

Re: [PATCH 2/6] V4L2: mx3_camera: convert to managed resource allocation

Hi Guennadi , On 8 August 2013 20:22, Guennadi Liakhovetski wrote: > Use devm_* resource allocators to simplify the driver's probe and clean up > paths. > > Signed-off-by: Guennadi Liakhovetski > --- > drivers/media/platform/soc_camera/mx3_camera.c | 47 > +--- > 1 files

Re: [PATCH v5 01/13] [media] exynos5-is: Adding media device driver for exynos5

Hi Arun, On 14 August 2013 10:16, Arun Kumar K wrote: > From: Shaik Ameer Basha > > This patch adds support for media device for EXYNOS5 SoCs. > The current media device supports the following ips to connect > through the media controller framework. > > * MIPI-CSIS > Support interconnection(su

[PATCH 1/1] [media] v4l2-ctrls: Remove duplicate const

The function returns a pointer to a const array. Duplicate use of const led to the following warning. drivers/media/v4l2-core/v4l2-ctrls.c:574:32: warning: duplicate const Signed-off-by: Sachin Kamat Cc: Sylwester Nawrocki --- drivers/media/v4l2-core/v4l2-ctrls.c |6 +++--- include/media

Re: [PATCH 1/1] [media] v4l2-ctrls: Remove duplicate const

On 30 August 2013 17:02, Sylwester Nawrocki wrote: > Hi Sachin, > > On 08/30/2013 01:11 PM, Sachin Kamat wrote: >> The function returns a pointer to a const array. Duplicate use of const >> led to the following warning. >> drivers/media/v4l2-core/v4l2-ctrls.c:574:3

[PATCH 2/3] [media] pci: cx88-mpeg: Use module_pci_driver

module_pci_driver removes some boilerplate and makes code simpler. Signed-off-by: Sachin Kamat Cc: Jelle Foks --- drivers/media/pci/cx88/cx88-mpeg.c | 14 +- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/media/pci/cx88/cx88-mpeg.c b/drivers/media/pci/cx88

[PATCH 3/3] [media] pci: cx88-video: Use module_pci_driver

module_pci_driver removes some boilerplate and makes code simpler. Signed-off-by: Sachin Kamat Cc: Gerd Knorr --- drivers/media/pci/cx88/cx88-video.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/media/pci/cx88/cx88-video.c b/drivers/media/pci

[PATCH 1/3] [media] pci: cx88-alsa: Use module_pci_driver

module_pci_driver removes some boilerplate and makes code simpler. Signed-off-by: Sachin Kamat --- drivers/media/pci/cx88/cx88-alsa.c | 25 + 1 file changed, 1 insertion(+), 24 deletions(-) diff --git a/drivers/media/pci/cx88/cx88-alsa.c b/drivers/media/pci/cx88/cx88

[PATCH 6/9] [media] pci: pt1: Remove redundant pci_set_drvdata

Driver core sets driver data to NULL upon failure or remove. Signed-off-by: Sachin Kamat Cc: Takahito HIRANO --- drivers/media/pci/pt1/pt1.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/pci/pt1/pt1.c b/drivers/media/pci/pt1/pt1.c index 75ce142..db887b0 100644 --- a

[PATCH 3/9] [media] pci: dm1105: Remove redundant pci_set_drvdata

Driver core sets driver data to NULL upon failure or remove. Signed-off-by: Sachin Kamat Cc: Igor M. Liplianin --- drivers/media/pci/dm1105/dm1105.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/pci/dm1105/dm1105.c b/drivers/media/pci/dm1105/dm1105.c index ab797fe

[PATCH 1/9] [media] pci: flexcop: Remove redundant pci_set_drvdata

Driver core sets driver data to NULL upon failure or remove. Signed-off-by: Sachin Kamat Cc: Patrick Boettcher --- drivers/media/pci/b2c2/flexcop-pci.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/pci/b2c2/flexcop-pci.c b/drivers/media/pci/b2c2/flexcop-pci.c index

[PATCH 5/9] [media] pci: pluto2: Remove redundant pci_set_drvdata

Driver core sets driver data to NULL upon failure or remove. Signed-off-by: Sachin Kamat Cc: Andreas Oberritter --- drivers/media/pci/pluto2/pluto2.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/pci/pluto2/pluto2.c b/drivers/media/pci/pluto2/pluto2.c index 4938285

[PATCH 4/9] [media] pci: mantis: Remove redundant pci_set_drvdata

Driver core sets driver data to NULL upon failure or remove. Signed-off-by: Sachin Kamat Cc: Manu Abraham --- drivers/media/pci/mantis/mantis_pci.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/pci/mantis/mantis_pci.c b/drivers/media/pci/mantis/mantis_pci.c index

[PATCH 2/9] [media] pci: cx88: Remove redundant pci_set_drvdata

Driver core sets driver data to NULL upon failure or remove. Signed-off-by: Sachin Kamat --- drivers/media/pci/cx88/cx88-alsa.c |2 -- drivers/media/pci/cx88/cx88-mpeg.c |1 - drivers/media/pci/cx88/cx88-video.c |1 - 3 files changed, 4 deletions(-) diff --git a/drivers/media/pci

[PATCH 8/9] [media] pci: bt878: Remove redundant pci_set_drvdata

Driver core sets driver data to NULL upon failure or remove. Signed-off-by: Sachin Kamat --- drivers/media/pci/bt8xx/bt878.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/pci/bt8xx/bt878.c b/drivers/media/pci/bt8xx/bt878.c index 66eb0ba..2bd2483 100644 --- a/drivers/media

[PATCH 9/9] [media] pci: ngene: Remove redundant pci_set_drvdata

Driver core sets driver data to NULL upon failure or remove. Signed-off-by: Sachin Kamat --- drivers/media/pci/ngene/ngene-core.c |2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/media/pci/ngene/ngene-core.c b/drivers/media/pci/ngene/ngene-core.c index 37ebc42..8402ed6 100644

[PATCH 7/9] [media] pci: saa7164: Remove redundant pci_set_drvdata

Driver core sets driver data to NULL upon failure or remove. Signed-off-by: Sachin Kamat Cc: Steven Toth --- drivers/media/pci/saa7164/saa7164-core.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/pci/saa7164/saa7164-core.c b/drivers/media/pci/saa7164/saa7164-core.c index

[PATCH 1/1] [media] radio-sf16fmr2: Remove redundant dev_set_drvdata

Driver core sets driver data to NULL upon failure or remove. Signed-off-by: Sachin Kamat --- drivers/media/radio/radio-sf16fmr2.c |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/media/radio/radio-sf16fmr2.c b/drivers/media/radio/radio-sf16fmr2.c index f1e3714..448cac9 100644

Re: [PATCH v5 0/4] media: s5p-tv: clean-up and fixes

Hi Mateusz, On 21 September 2013 20:30, Mateusz Krawczuk wrote: > This patch series add restoring previous vpll rate after driver offs stream > or recives error. > It also replace mxr_info, mxr_dbg, mxr_warn and mxr_err macro > by generic solution. It is a good practice to include revision histo

Re: [PATCH 00/10] [media] remove unnecessary pci_set_drvdata()

Hi Hans, On 30 September 2013 17:52, Hans Verkuil wrote: > On 09/23/2013 03:43 AM, Jingoo Han wrote: >> Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d >> (device-core: Ensure drvdata = NULL when no driver is bound), >> the driver core clears the driver data to NULL after device_release >>

[PATCH 1/1] [media] radio-keene: Use module_usb_driver

module_usb_driver eliminates the boilerplate and makes the code simpler. Signed-off-by: Sachin Kamat --- drivers/media/radio/radio-keene.c | 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/drivers/media/radio/radio-keene.c b/drivers/media/radio/radio

Re: [PATCH v2 0/2] drivers/media: Add controls for Horizontal and Vertical MV Search Range

Hi Amit, On 30 January 2014 11:12, Amit Grover wrote: > Based on 'master' branch of Linux-next. Kamil's tree [1] would be more current most of the times for this driver. [1] git://linuxtv.org/kdebski/media.git > This is v2 version for the patch: > s5p-mfc: Add Horizontal and Vertical search r

Re: exynos4 / g2d

+cc linux-media list and some related maintainers Hi, On 10 February 2014 00:22, Tobias Jakobi wrote: > Hello! > > I noticed while here > (https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/arch/arm/boot/dts/exynos4x12.dtsi?id=3a0d48f6f81459c874165ffb14b310c0b5bb0c58) > the n

Re: exynos4 / g2d

+cc Joonyoung Shim Hi, On 10 February 2014 13:58, Tobias Jakobi wrote: > Hello! > > > Sachin Kamat wrote: >> +cc linux-media list and some related maintainers >> >> Hi, >> >> On 10 February 2014 00:22, Tobias Jakobi >> wrote: >>> Hello!

Re: exynos4 / g2d

On 10 February 2014 14:28, Inki Dae wrote: > 2014-02-10 17:44 GMT+09:00 Sachin Kamat : >> +cc Joonyoung Shim >> >> Hi, >> >> On 10 February 2014 13:58, Tobias Jakobi >> wrote: >>> Hello! >>> >>> >>> Sachin Kamat

Re: [PATCH] [media] s5-mfc: remove meaningless memory bank assignment

On 5 March 2014 16:38, Seung-Woo Kim wrote: > There was assignment of memory bank with dma address converted > from physical address. But allocation has been changed with dma > function, so the assignment is not necessary. > > Signed-off-by: Seung-Woo Kim > --- > change from v1 > - fixes subject

Re: [PATCH] [media] s5-mfc: remove meaningless memory bank assignment

Hi Seung-Woo, On 6 March 2014 07:43, Seung-Woo Kim wrote: > Hello Sachin, > > On 2014년 03월 05일 20:42, Sachin Kamat wrote: >> On 5 March 2014 16:38, Seung-Woo Kim wrote: > > (...) > >>> - dev->bank1 = dev->bank1; >> >> Are you sure th

Re: [PATCH v3] [media] s5p-mfc: remove meaningless memory bank assignment

Hi Seung-Woo, On 6 March 2014 10:25, Seung-Woo Kim wrote: > This patch removes meaningless assignment of memory bank to itself. > > Signed-off-by: Seung-Woo Kim > --- Thanks for re-doing this. Acked-by: Sachin Kamat -- With warm regards, Sachin -- To unsubscribe from this li

[PATCH 1/1] gspca: Use module_usb_driver macro

module_usb_driver eliminates a lot of boilerplate by replacing module_init() and module_exit() calls. Signed-off-by: Sachin Kamat --- Compile tested with linux-next --- drivers/media/usb/gspca/jl2005bcd.c | 18 +- 1 files changed, 1 insertions(+), 17 deletions(-) diff --git a

Re: [PATCH] s5p-mfc: Fix interrupt error handling routine

Hi Kamil, Please add some description about the fix (in the commit log/message). On 12 December 2012 16:49, Kamil Debski wrote: > Signed-off-by: Kamil Debski > Signed-off-by: Kyungmin Park > --- > drivers/media/platform/s5p-mfc/s5p_mfc.c | 88 > +- > 1 file cha

[PATCH 1/3] [media] s5p-mfc: use mfc_err instead of printk

Use mfc_err for consistency. Also silences checkpatch warning. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c b/drivers/media/platform/s5p

[PATCH 2/3] [media] s5p-mfc: Remove redundant 'break'

The code returns before this statement. Hence not required. Silences the following smatch message: drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c:525 s5p_mfc_set_dec_frame_buffer_v5() info: ignoring unreachable code. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5

[PATCH 3/3] [media] s5p-mfc: Use of_match_ptr and CONFIG_OF

This builds the code only if DT is enabled. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-mfc/s5p_mfc.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index 3930177

[PATCH 1/2] [media] s5p-jpeg: Use spinlock_t instead of 'struct spinlock'

Silences the following checkpatch warning: WARNING: struct spinlock should be spinlock_t Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-jpeg/jpeg-core.h |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/s5p-jpeg/jpeg-core.h b/drivers

[PATCH 2/2] [media] s5p-fimc: Use spinlock_t instead of 'struct spinlock'

Silences the following checkpatch warning: WARNING: struct spinlock should be spinlock_t Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-fimc/mipi-csis.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/s5p-fimc/mipi-csis.c b/drivers

[PATCH-Trivial] [media] s5p-mfc: Fix a typo in error message in s5p_mfc_pm.c

Fixed a trivial typo. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-mfc/s5p_mfc_pm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_pm.c b/drivers/media/platform/s5p-mfc/s5p_mfc_pm.c index 2895333..6aa38a5 100644

[PATCH 1/1] [media] s5p-mfc: Fix an error check

Checking unsigned variable for negative value always returns false. Hence make this value signed as we expect it to be negative too. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH Resend] [media] s5p-mfc: Fix an error check

never less than zero. Signed-off-by: Sachin Kamat --- Added additional description in commit message. Please ignore the previous patch. --- drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mf

Re: [PATCH 2/3] [media] s5p-mfc: Remove redundant 'break'

-Original Message- >> From: linux-media-ow...@vger.kernel.org [mailto:linux-media- >> ow...@vger.kernel.org] On Behalf Of Sachin Kamat >> Sent: Friday, December 28, 2012 11:18 AM >> To: linux-media@vger.kernel.org >> Cc: k.deb...@samsung.com; s.nawro..

Re: [PATCH 1/2] [RFC] video: exynos mipi dsi: Making Exynos MIPI Complaint with CDF

Hi Vikas, Some nitpicks inline Subject: s/Complaint/Compliant On 2 January 2013 18:47, Vikas C Sajjan wrote: > From: Vikas Sajjan > Please add some description about this patch here. > Signed-off-by: Vikas Sajjan > --- > drivers/video/exynos/exynos_mipi_dsi.c| 46 > +

[PATCH] s5p-g2d: Add support for G2D H/W Rev.4.1

L_REG only with FIMG2D v3. Signed-off-by: Ajay Kumar Signed-off-by: Sachin Kamat Cc: Kamil Debski --- Earlier attempts at adding this support can be found at: http://patchwork.linuxtv.org/patch/10833/ This version addresses all the previous comments. --- drivers/media/platform/s5p-g2d/g2d-hw.

[PATCH 1/1] [media] s5k6aa: Use devm_regulator_bulk_get API

devm_regulator_bulk_get is device managed and saves some cleanup and exit code. Signed-off-by: Sachin Kamat --- drivers/media/i2c/s5k6aa.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/i2c/s5k6aa.c b/drivers/media/i2c/s5k6aa.c index 57cd4fa

[PATCH 1/1] [media] s5p-csis: Use devm_regulator_bulk_get API

devm_regulator_bulk_get is device managed and saves some cleanup and exit code. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-fimc/mipi-csis.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/s5p-fimc/mipi-csis.c b/drivers/media

Re: [RFC PATCH 4/4] alsa/soc: add hdmi audio codec based on cdf

+CC: ALSA mailing list, Mark Brown On 13 January 2013 18:22, Rahul Sharma wrote: > This patch registers hdmi-audio codec to the ALSA framework. This is the > second > client to the hdmi panel. Once notified by the CDF Core it proceeds towards > audio setting and audio control. It also subscribes

[PATCH 1/1] [media] s5p-mfc: Use NULL instead of 0 for pointer

Fixes the following warning: drivers/media/platform/s5p-mfc/s5p_mfc_opr.c:56:27: warning: Using plain integer as NULL pointer Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-mfc/s5p_mfc_opr.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media

Re: [PATCH] s5p-g2d: Add support for G2D H/W Rev.4.1

Hi Sylwester, On 16 January 2013 15:43, Sylwester Nawrocki wrote: > Hi Sachin, > > I have just one small comment... > > On 01/07/2013 07:44 AM, Sachin Kamat wrote: >> +static void *g2d_get_drv_data(struct platform_device *pdev) >> +{ >> + struc

[PATCH v2] s5p-g2d: Add support for G2D H/W Rev.4.1

L_REG only with FIMG2D v3. Signed-off-by: Ajay Kumar Signed-off-by: Sachin Kamat Acked-by: Kamil Debski --- Changes since v1: Moved g2d_get_drv_data() to g2d.h as suggested by Sylwester Nawrocki . --- drivers/media/platform/s5p-g2d/g2d-hw.c | 16 +++--- drivers/media/platform/s5p-g2d/

Re: [PATCH v2] s5p-g2d: Add support for G2D H/W Rev.4.1

Hi Sylwester, On 17 January 2013 16:46, Sylwester Nawrocki wrote: > Hi Sachin, > > On 01/17/2013 05:07 AM, Sachin Kamat wrote: >> Modified the G2D driver (which initially supported only H/W Rev.3) >> to support H/W Rev.4.1 present on Exynos4x12 and Exynos52x0 SOCs. >>

[PATCH 1/1] [media] s5p-mfc: Use WARN_ON(condition) directly

Use WARN_ON(condition) directly instead of wrapping around an if condition. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-mfc/s5p_mfc.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p

[PATCH 1/2] [media] s5p-g2d: Add DT based discovery support

This patch adds device tree based discovery support to G2D driver Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-g2d/g2d.c | 17 - 1 files changed, 16 insertions(+), 1 deletions(-) diff --git a/drivers/media/platform/s5p-g2d/g2d.c b/drivers/media/platform/s5p-g2d

[PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

From: Ajay Kumar This patch adds device tree match table for Exynos G2D controller. Signed-off-by: Ajay Kumar Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/exynos

Re: [PATCH] Adds display-timing node parsing to exynos drm fimd as per

Hi Vikas, This patch should be numbered 0/1 as it is not a patch in itself and the subsequent patch should be 1/1 so as to show that these 2 together form a series. Also, your subject line seems to have been truncated. On 28 January 2013 11:15, Vikas Sajjan wrote: > This patch adds display-timi

[PATCH 1/1] [media] s5c73m3: Staticize some symbols

rs/media/i2c/s5c73m3/s5c73m3-core.c:298:5: warning: symbol 's5c73m3_isp_comm_result' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/media/i2c/s5c73m3/s5c73m3-core.c |7 --- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/media

Re: [PATCH v2 0/1] Adds display-timing node parsing to exynos drm fimd

Hi Vikas, Changelog mentioning differences between v1 and v2 is generally preferred as it will help the reviewers. On 30 January 2013 12:00, Vikas Sajjan wrote: > This patch adds display-timing node parsing to drm fimd, this depends on > the display helper patchset at > http://lists.freedesktop.

[PATCH 1/1] [media] s5c73m3: Use devm_regulator_bulk_get API

devm_regulator_bulk_get saves some cleanup and exit code. Cc: Andrzej Hajda Signed-off-by: Sachin Kamat --- drivers/media/i2c/s5c73m3/s5c73m3-core.c |9 +++-- 1 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c b/drivers/media/i2c

Re: [PATCH 1/2] [media] s5p-g2d: Add DT based discovery support

Hi Sylwester. Thank you for the review. On 31 January 2013 03:08, Sylwester Nawrocki wrote: > Hi Sachin, > > > On 01/25/2013 10:55 AM, Sachin Kamat wrote: >> >> This patch adds device tree based discovery support to G2D driver >> >> Signed-off-by: Sachin Kama

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

On 1 February 2013 06:57, Inki Dae wrote: > > For example, > If compatible = "samsung,g2d-3.0" is added to exynos4210.dtsi, it'd be > reasonable. But what if that compatible string is added to exynos4.dtsi?. > This case isn't considered for exynos4412 SoC with v4.1. In case of Exynos4 series the

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

>> In any case please let me know the final preferred one so that I can >> update the code send the revised patches. > > The version with SoC name embedded in it seems most reliable and correct > to me. > > compatible = "samsung,exynos3110-fimg-2d" /* for Exynos3110 (S5PC110, > S5PV210), >

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

On 1 February 2013 17:02, Inki Dae wrote: > > How about using like below? > Compatible = ""samsung,exynos4x12-fimg-2d" /* for Exynos4212, > Exynos4412 */ > It looks odd to use "samsung,exynos4212-fimg-2d" saying that this ip is for > exynos4212 and exynos4412. AFAIK, compatible strings a

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

On 1 February 2013 18:28, Inki Dae wrote: > > > > > 2013. 2. 1. 오후 8:52 Inki Dae 작성: > >> >> >>> -Original Message- >>> From: linux-media-ow...@vger.kernel.org [mailto:linux-media- >>> ow...@vger.kernel.org] On Behalf Of Sachin

Re: [PATCH 2/2] drm/exynos: Add device tree based discovery support for G2D

On 5 February 2013 15:03, Sylwester Nawrocki wrote: > On 02/05/2013 04:03 AM, Inki Dae wrote: > [...] >>> Exynos4210 has same g2d IP (v3.0) as C110 or V210; so the same >>> comptible string will be used for this one too. >>> And please check if exynos4212 and 4412 SoCs have same fimg-2d ip. >

[PATCH v2 1/2] [media] s5p-g2d: Add DT based discovery support

This patch adds device tree based discovery support to G2D driver Signed-off-by: Sachin Kamat --- Based on for_v3.9 branch of below tree: git://linuxtv.org/snawrocki/samsung.git Changes since v1: * Addressed review comments from Sylwester . * Modified the compatible string as per the

[PATCH v2 2/2] drm/exynos: Add device tree based discovery support for G2D

From: Ajay Kumar This patch adds device tree match table for Exynos G2D controller. Signed-off-by: Ajay Kumar Signed-off-by: Sachin Kamat --- Patch based on exynos-drm-fixes branch of Inki Dae's tree: git://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git Changes sin

Re: [PATCH v2 2/2] drm/exynos: Add device tree based discovery support for G2D

On 6 February 2013 13:02, Inki Dae wrote: > > Looks good to me but please add document for it. Yes. I will. I was planning to send the bindings document patch along with the dt patches (adding node entries to dts files). Sylwester had suggested adding this to Documentation/devicetree/bindings/med

Re: [PATCH v2 2/2] drm/exynos: Add device tree based discovery support for G2D

On 6 February 2013 16:53, Sylwester Nawrocki wrote: > On 02/06/2013 09:51 AM, Inki Dae wrote: > [...] > So I propose following classification, which seems less inaccurate: > > GPU: g2d, g3d > Media: mfc, fimc, fimc-lite, fimc-is, mipi-csis, gsc > Video: fimd, hdmi, eDP, mipi-dsim Thanks Inki a

[PATCH 1/2] [media] s5p-tv: Include missing irqreturn.h header

Without this patch we get the following compilation errors: drivers/media/platform/s5p-tv/mixer.h:345:13: error: Expected ; at end of declaration drivers/media/platform/s5p-tv/mixer.h:345:13: error: got mxr_irq_handler Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-tv/mixer.h

[PATCH 2/2] [media] s5p-tv: Include missing platform_device.h header

Without this patch we get the following build error: drivers/media/platform/s5p-tv/mixer_video.c: In function ‘find_and_register_subdev’: drivers/media/platform/s5p-tv/mixer_video.c:42:34: error: ‘platform_bus_type’ undeclared (first use in this function) Signed-off-by: Sachin Kamat --- drivers

[PATCH 1/1] [media] timblogiw: Fix sparse warning

Fixes the below warning: drivers/media/platform/timblogiw.c:81:31: warning: symbol 'timblogiw_tvnorms' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/media/platform/timblogiw.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: V4L2 MFC video decoding example application

Hi Kamil, Thank you for this really cool app. Tested on Origen board for MPEG4 and H.264 streams and they work fine. Regards, Sachin On 06/03/2012, Kamil Debski wrote: > Hi, > > I would like to inform you that the example application for the MFC driver > has been prepared and was today released

[PATCH] [media] s5p-tv: Fix section mismatch warning in mixer_video.c

): Section mismatch in reference from the function mxr_probe() to the function .devexit.text:mxr_release_video() Signed-off-by: Sachin Kamat --- Tested on for-next branch of Kukjin Kim's tree git://git.kernel.org/pub/scm/linux/kernel/git/kgene/linux-samsung.git --- drivers/media/video/s5p-tv/mi

[PATCH] [media] s5p-jpeg: Make the output format setting conditional

S5P-JPEG IP on Exynos4210 SoC supports YCbCr422 and YCbCr420 as decoded output formats. But the driver used to fix the output format as YCbCr422. This is now made conditional depending upon the requested output format. Signed-off-by: Sachin Kamat --- drivers/media/video/s5p-jpeg/jpeg-core.c

Re: [PATCH] [media] s5p-jpeg: Make the output format setting conditional

Hi Andrzej, On 19/03/2012, Andrzej Pietrasiewicz wrote: > Hello, > > On March 19, 2012 12:35 PM Sachin Kamat wrote: > >> Subject: [PATCH] [media] s5p-jpeg: Make the output format setting > conditional >> >> S5P-JPEG IP on Exynos4210 SoC supports YCbCr422

[PATCH] [media] s5p-tv: Fix compiler warning in mixer_video.c file

Fixes the following warning: mixer_video.c:857:3: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘unsigned int’ [-Wformat] Signed-off-by: Sachin Kamat --- drivers/media/video/s5p-tv/mixer_video.c |2 +- 1 files changed, 1 insertions(+), 1

Re: [PATCH] [media] s5p-tv: Fix compiler warning in mixer_video.c file

Ok. Please ignore my patch. Looks like this series has not yet made into mainline. On 03/04/2012, Tomasz Stanislawski wrote: > Hi Sachin Kamat, > Thanks for the patch. > However, the patch is already a duplicate of > > http://thread.gmane.org/gmane.linux.drivers.video-input-infra

[PATCH v3] [media] s5p-g2d: Add support for FIMG2D v4.1 H/W logic

different logic for stretching(scaling). -- Use CACHECTL_REG only with FIMG2D v3. Signed-off-by: Ajay Kumar Signed-off-by: Sachin Kamat --- drivers/media/video/s5p-g2d/g2d-hw.c | 17 + drivers/media/video/s5p-g2d/g2d-regs.h |6 ++ drivers/media/video/s5p

Re: [PATCH v3] [media] s5p-g2d: Add support for FIMG2D v4.1 H/W logic

Hi Kamil, Any comments on the below patch? Regards Sachin On 24 April 2012 16:08, Sachin Kamat wrote: > From: Ajay Kumar > > Modify the G2D driver(which initially supported only FIMG2D v3 style H/W) > to support FIMG2D v4.1 style hardware present on Exynos4x12 and Exyno

[PATCH 1/2] [media] s5p-mfc: Fix NULL pointer warnings

Fixes the following type of warnings detected by sparse: warning: Using plain integer as NULL pointer. Signed-off-by: Sachin Kamat --- drivers/media/video/s5p-mfc/s5p_mfc.c | 10 +- drivers/media/video/s5p-mfc/s5p_mfc_ctrl.c | 16 drivers/media/video/s5p-mfc

[PATCH 2/2] [media] s5p-mfc: Add missing static storage class to silence warnings

lared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/media/video/s5p-mfc/s5p_mfc.c |2 +- drivers/media/video/s5p-mfc/s5p_mfc_opr.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/s5p-mfc/s5p_mfc.c b/drivers/media/video/s5p

[PATCH 1/2] [media] s5p-g2d: Fix NULL pointer warnings in g2d.c file

Fixes the following warnings detected by sparse: warning: Using plain integer as NULL pointer Signed-off-by: Sachin Kamat --- drivers/media/video/s5p-g2d/g2d.c | 12 ++-- 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/media/video/s5p-g2d/g2d.c b/drivers/media

[PATCH 2/2] [media] s5p-g2d: Add missing static storage class in g2d.c file

/s5p-g2d/g2d.c:205:5: warning: symbol 'g2d_setup_ctrls' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/media/video/s5p-g2d/g2d.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/s5p-g2d/g2d.c b/drivers/m

[PATCH] [media] s5p-jpeg: Make s5p_jpeg_g_selection function static

Makes the function s5p_jpeg_g_selection static (detected by sparse). Signed-off-by: Sachin Kamat --- drivers/media/video/s5p-jpeg/jpeg-core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/s5p-jpeg/jpeg-core.c b/drivers/media/video/s5p-jpeg/jpeg

[PATCH] [media] s5p-mfc: Add missing static storage class in s5p_mfc_enc.c file

atic? Signed-off-by: Sachin Kamat --- drivers/media/video/s5p-mfc/s5p_mfc_enc.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/s5p-mfc/s5p_mfc_enc.c b/drivers/media/video/s5p-mfc/s5p_mfc_enc.c index dff9dc7..acedb20 100644 --- a/drivers

[PATCH] s5p-g2d: Use devm_* functions in g2d.c file

devm_* functions are device managed functions and make error handling and cleanup simpler. Signed-off-by: Sachin Kamat --- drivers/media/video/s5p-g2d/g2d.c | 47 drivers/media/video/s5p-g2d/g2d.h |1 - 2 files changed, 11 insertions(+), 37 deletions

[PATCH] s5p-jpeg: Use devm_* functions in jpeg-core.c file

devm_* functions are used to replace kzalloc, request_mem_region, ioremap and request_irq functions in probe call. With the usage of devm_* functions explicit freeing and unmapping is not required. Signed-off-by: Sachin Kamat --- drivers/media/video/s5p-jpeg/jpeg-core.c | 58

[PATCH] [media] s5p-mfc: Use devm_* functions in s5p_mfc.c file

devm_* functions are device managed functions and make error handling and cleanup simpler. Signed-off-by: Sachin Kamat --- drivers/media/video/s5p-mfc/s5p_mfc.c| 63 ++ drivers/media/video/s5p-mfc/s5p_mfc_common.h |2 - 2 files changed, 14 insertions(+), 51

[PATCH 1/2] [media] s5p-tv: Use devm_regulator_get() in sdo_drv.c file

devm_regulator_get() is a device managed function and makes the exit code a bit simpler and cleaner. Signed-off-by: Sachin Kamat --- drivers/media/video/s5p-tv/sdo_drv.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/media/video/s5p-tv/sdo_drv.c b

[PATCH 2/2] [media] s5p-tv: Use devm_* functions in sii9234_drv.c file

devm_* functions are device managed functions and make error handling and cleanup cleaner and simpler. Signed-off-by: Sachin Kamat --- drivers/media/video/s5p-tv/sii9234_drv.c | 17 - 1 files changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/media/video/s5p-tv

[PATCH] [media] s5p-fimc: Make FIMC-Lite dependent on S5P-FIMC

c:1018: undefined reference to `fimc_register_driver' drivers/built-in.o: In function `fimc_md_exit': fimc-mdevice.c:1028: undefined reference to `fimc_unregister_driver' make: *** [vmlinux] Error 1 Signed-off-by: Sachin Kamat --- drivers/media/video/s5p-fimc/Kconfig |2 +- 1 files c

  1   2   3   4   >