v4l2: lockdep spew mmap_sem/dev_mutex

2013-05-06 Thread Sasha Levin
Hi guys, While fuzzing with trinity running inside a KVM tools guest, using latest -next kernel, I've stumbled on the following spew: [ 160.267181] == [ 160.267896] [ INFO: possible circular locking dependency detected ] [ 160.268631]

Re: [PATCH] USB: Staging: media: lirc: initialize spinlocks before usage

2012-06-10 Thread Sasha Levin
Ping? This thing still causes spinlock errors in 3.5-rc2. On Sat, May 26, 2012 at 9:25 PM, Sasha Levin levinsasha...@gmail.com wrote: Initialize the spinlock for each hardware time. Signed-off-by: Sasha Levin levinsasha...@gmail.com ---  drivers/staging/media/lirc/lirc_serial.c |    6

[PATCH] rc-core: don't return from store_protocols without releasing device mutex

2012-12-08 Thread Sasha Levin
-by: Sasha Levin sasha.le...@oracle.com --- drivers/media/rc/rc-main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/rc/rc-main.c b/drivers/media/rc/rc-main.c index 601d1ac1..0510f4d 100644 --- a/drivers/media/rc/rc-main.c +++ b/drivers/media/rc/rc-main.c @@ -890,7

Re: [PATCH] rc-core: don't return from store_protocols without releasing device mutex

2012-12-20 Thread Sasha Levin
Ping? On Sat, Dec 8, 2012 at 7:50 AM, Sasha Levin sasha.le...@oracle.com wrote: Commit c003ab1b ([media] rc-core: add separate defines for protocol bitmaps and numbers) has introduced a bug which allows store_protocols() to return without releasing the device mutex it's holding. Doing

[PATCH] m2m-deinterlace: use correct check for kzalloc failure

2012-12-20 Thread Sasha Levin
There is no point in PTR_ERR()ing a NULL pointer, use a real error instead. Signed-off-by: Sasha Levin sasha.le...@oracle.com --- drivers/media/platform/m2m-deinterlace.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/media/platform/m2m-deinterlace.c b/drivers

Re: v4l2: lockdep spew mmap_sem/dev_mutex

2014-04-06 Thread Sasha Levin
Ping? This is still happening in -next, more than half a year later... Thanks, Sasha On 05/06/2013 09:29 PM, Sasha Levin wrote: Hi guys, While fuzzing with trinity running inside a KVM tools guest, using latest -next kernel, I've stumbled on the following spew: [ 160.267181

v4l2: circular locking between mmap_sem and device mutex

2014-05-05 Thread Sasha Levin
Hi all, While fuzzing with trinity inside a KVM tools guest running latest -next kernel I've stumbled on the following: [ 2179.111265] == [ 2179.112228] [ INFO: possible circular locking dependency detected ] [ 2179.113144]

Re: v4l2: circular locking between mmap_sem and device mutex

2014-05-22 Thread Sasha Levin
ping? On 05/05/2014 11:49 AM, Sasha Levin wrote: Hi all, While fuzzing with trinity inside a KVM tools guest running latest -next kernel I've stumbled on the following: [ 2179.111265] == [ 2179.112228] [ INFO: possible circular

Re: [PATCH v7] media: vb2: Take queue or device lock in mmap-related vb2 ioctl handlers

2014-06-25 Thread Sasha Levin
Ping? On 05/23/2014 09:54 AM, Hans Verkuil wrote: Hi Laurent, This patch caused a circular locking dependency as reported by Sasha Levin: https://lkml.org/lkml/2014/5/5/366 The reason is that copy_to/from_user is called in video_usercopy() with the core lock held. The copy functions

[PATCH AUTOSEL for 4.15 005/102] video/hdmi: Allow "empty" HDMI infoframes

2018-03-03 Thread Sasha Levin
e.syrj...@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20171113170427.4150-2-ville.syrj...@linux.intel.com Reviewed-by: Shashank Sharma <shashank.sha...@intel.com> Signed-off-by: Sasha Levin <alexander.le...@microsoft.com> --- drivers/video/hdmi.c | 51 +

[PATCH AUTOSEL for 4.14 03/84] video/hdmi: Allow "empty" HDMI infoframes

2018-03-03 Thread Sasha Levin
e.syrj...@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20171113170427.4150-2-ville.syrj...@linux.intel.com Reviewed-by: Shashank Sharma <shashank.sha...@intel.com> Signed-off-by: Sasha Levin <alexander.le...@microsoft.com> --- drivers/video/hdmi.c | 51 +

[PATCH AUTOSEL for 4.4 085/115] video/hdmi: Allow "empty" HDMI infoframes

2018-03-03 Thread Sasha Levin
e.syrj...@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20171113170427.4150-2-ville.syrj...@linux.intel.com Reviewed-by: Shashank Sharma <shashank.sha...@intel.com> Signed-off-by: Sasha Levin <alexander.le...@microsoft.com> --- drivers/video/hdmi.c | 51 +

[PATCH AUTOSEL for 4.9 172/219] video/hdmi: Allow "empty" HDMI infoframes

2018-03-03 Thread Sasha Levin
e.syrj...@linux.intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20171113170427.4150-2-ville.syrj...@linux.intel.com Reviewed-by: Shashank Sharma <shashank.sha...@intel.com> Signed-off-by: Sasha Levin <alexander.le...@microsoft.com> --- drivers/video/hdmi.c | 51 +

Re: [PATCH v4.9 1/1] v4l: event: Add subscription to list before calling "add" operation

2018-11-08 Thread Sasha Levin
On Thu, Nov 08, 2018 at 01:46:06PM +0200, Sakari Ailus wrote: [ upstream commit 92539d3eda2c090b382699bbb896d4b54e9bdece ] Patch ad608fbcf166 changed how events were subscribed to address an issue elsewhere. As a side effect of that change, the "add" callback was called before the event

Re: [Outreachy kernel] [PATCH vicodec] media: pvrusb2: replace `printk` with `pr_*`

2018-10-06 Thread Sasha Levin
On Sat, Oct 06, 2018 at 10:21:38PM +0300, Dafna Hirschfeld wrote: Replace calls to `printk` with the appropriate `pr_*` macro. Hi Dafna, I'd encourage you to look into the dev_ family of print functions (such as dev_info() ). They can avoid having to repeat the driver name in every print

Re: [PATCH for v4.9] Revert "media: videobuf2-core: don't call memop 'finish' when queueing"

2018-11-23 Thread Sasha Levin
On Thu, Nov 22, 2018 at 12:43:56PM +0100, Hans Verkuil wrote: This reverts commit 9ac47200b51cb09d2f15dbefa67e0412741d98aa. This commit fixes a bug in upstream commit a136f59c0a1f ("vb2: Move buffer cache synchronisation to prepare from queue") which isn't present in 4.9. So as a result you