status request of et8k8, ad5820 and their corresponding rx51 board code

Hi, What's the plan for the rx51 camera drivers from [0]? Is there a chance, that they get included in the mainline 3.2 or 3.3 kernel? [0] http://git.linuxtv.org/pinchartl/media.git/shortlog/refs/heads/omap3isp-2.6.37-rx51 -- Sebastian signature.asc Description: Digital signature

Re: [git:v4l-dvb/for_v3.7] [media] media: rc: Introduce RX51 IR transmitter driver

Hi, It was an requirement back then that this driver needs to be a module as 99% of the N900 owners still don't even know they have this kind of capability on their devices, so it doesn't make sense to keep the module loaded unless the user actually needs it. I don't think that's so

[early RFC] Device Tree bindings for OMAP3 Camera Subsystem

Hi, This is an early RFC for omap3isp DT support. For now i just created a potential DT binding documentation based on the existing platform data: Binding for the OMAP3 Camera subsystem with the image signal processor (ISP) feature. omap3isp node - Required properties: -

Re: [PATCH] media: Add BCM2048 radio driver

On Thu, Dec 05, 2013 at 02:20:56PM +0100, Pali Rohár wrote: Anyway, I've posted the pull request. Please note, if you want to avoid having this driver be removed again in the future, then you (or someone else) should work on addressing the issues in the TODO file I added. Ok. CCing

Re: omap3isp device tree support

, Sebastian Reichel (in CC) posted an RFC for the binding [2]. Are you working with him on this? No, I've replied to Sebastian's patch but haven't received any answer. My main concern is that the proposal didn't use the V4L2 DT bindings to describe the pipeline. ah sorry I thought I replied

[RFCv2] Device Tree bindings for OMAP3 Camera System

Hi, I finally found some time to update the proposed binding documentation for omap3isp according to the comments on RFCv1. Changes since v1: * Use common DT clock bindings to provide isp-xclk * Use common DT video-interface bindings to specify device connections * Apply style updates

Re: [RFCv2] Device Tree bindings for OMAP3 Camera System

Hi, On Mon, Jan 20, 2014 at 11:16:43PM +0100, Sylwester Nawrocki wrote: On 01/20/2014 05:19 AM, Sakari Ailus wrote: I've also been working on this (besides others); what I have however are mostly experimental patches. [...] Thanks. I will have a look at it. [...] Over 80 characters per

Re: [RFCv2] Device Tree bindings for OMAP3 Camera System

Hi, On Wed, Jan 22, 2014 at 11:57:45PM +0100, Laurent Pinchart wrote: [...] camera-switch { /* * TODO: * - check if the switching code is generic enough to use a *more generic name like gpio-camera-switch. I think you can use a more generic name. You could

[RFC 1/2] [media] si4713: add Device Tree support

Update si4713 driver to support being instantiated via Device Tree. This includes moving the regulator names back into the drivers, using regulator_get_optional to avoid breaking the USB driver and switching to the gpio resource interface. Signed-off-by: Sebastian Reichel s...@kernel.org

[RFC 0/2] [media] si4713 DT binding

to removed in the near future anyways) -- Sebastian Sebastian Reichel (2): [media] si4713: add Device Tree support [media] Ad DT binding documentation for si4713 Documentation/devicetree/bindings/media/si4713.txt | 30 arch/arm/mach-omap2/board-rx51-peripherals.c | 67

[RFC 2/2] [media] Ad DT binding documentation for si4713

This patch adds the DT bindings documentation for Silicon Labs Si4713 FM radio transmitter. Signed-off-by: Sebastian Reichel s...@kernel.org --- Documentation/devicetree/bindings/media/si4713.txt | 30 ++ 1 file changed, 30 insertions(+) create mode 100644 Documentation

Re: [RFC 0/2] [media] si4713 DT binding

On Sun, Apr 06, 2014 at 01:52:03PM +0200, Sebastian Reichel wrote: This is an RFC patch adding DT support to the si4713 radio transmitter i2c driver. ping? -- Sebastian signature.asc Description: Digital signature

[RFCv2 8/8] [media] si4713: cleanup platform data

Remove unreferenced members from the platform data's structure. Signed-off-by: Sebastian Reichel s...@kernel.org --- include/media/si4713.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/media/si4713.h b/include/media/si4713.h index 343b8fb5..be4f58e 100644 --- a/include/media

[RFCv2 6/8] [media] si4713: add DT binding documentation

This patch adds the DT bindings documentation for Silicon Labs Si4713 FM radio transmitter. Signed-off-by: Sebastian Reichel s...@kernel.org --- Documentation/devicetree/bindings/media/si4713.txt | 30 ++ 1 file changed, 30 insertions(+) create mode 100644 Documentation

[RFCv2 2/8] [media] si4713: switch reset gpio to devm_gpiod API

This updates the driver to use the managed gpiod interface instead of the unmanged old GPIO API. This is a preperation for the introduction of device tree support. Signed-off-by: Sebastian Reichel s...@kernel.org --- drivers/media/radio/si4713/si4713.c | 38

[RFCv2 4/8] [media] si4713: use managed irq request

Introduce the usage of managed irq request to simplify the code slightly. Signed-off-by: Sebastian Reichel s...@kernel.org --- drivers/media/radio/si4713/si4713.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/media/radio/si4713/si4713.c b/drivers/media

[RFCv2 3/8] [media] si4713: use managed memory allocation

Introduce the usage of managed memory allocation to simplify the code slightly. Signed-off-by: Sebastian Reichel s...@kernel.org --- drivers/media/radio/si4713/si4713.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/media/radio/si4713/si4713.c b/drivers/media

[RFCv2 5/8] [media] si4713: add device tree support

Add device tree support by changing the device registration order. In the device tree the si4713 node is a normal I2C device, which will be probed as such. Thus the V4L device must be probed from the I2C device and not the other way around. Signed-off-by: Sebastian Reichel s...@kernel.org

[RFCv2 7/8] ARM: OMAP2: RX-51: update si4713 platform data

This updates platform data related to Si4713, which has been updated to be compatible with DT interface. Signed-off-by: Sebastian Reichel s...@kernel.org --- arch/arm/mach-omap2/board-rx51-peripherals.c | 69 +--- 1 file changed, 31 insertions(+), 38 deletions(-) diff

[RFCv2 0/8] [media] si4713 DT binding

Sebastian Reichel (8): [media] si4713: switch to devm regulator API [media] si4713: switch reset gpio to devm_gpiod API [media] si4713: use managed memory allocation [media] si4713: use managed irq request [media] si4713: add device tree support [media] si4713: add DT binding

[RFCv2 1/8] [media] si4713: switch to devm regulator API

This switches back to the normal regulator API (but use managed variant) in preparation for device tree support. Signed-off-by: Sebastian Reichel s...@kernel.org --- drivers/media/radio/si4713/si4713.c | 80 ++--- drivers/media/radio/si4713/si4713.h | 6 +-- 2

[PATCHv3 0/4] [media] si4713 DT binding

solution would be to merge it via the media tree (assuming, that the boardcode is not yet removed in 3.19). [0] https://patchwork.linuxtv.org/patch/26506/ -- Sebastian Sebastian Reichel (4): [media] si4713: add device tree support [media] si4713: add DT binding documentation ARM: OMAP2: RX-51

[PATCHv3 3/4] ARM: OMAP2: RX-51: update si4713 platform data

This updates platform data related to Si4713, which has been updated to be compatible with DT interface. Signed-off-by: Sebastian Reichel s...@kernel.org --- arch/arm/mach-omap2/board-rx51-peripherals.c | 69 +--- 1 file changed, 31 insertions(+), 38 deletions(-) diff

[PATCHv3 1/4] [media] si4713: add device tree support

Add device tree support by changing the device registration order. In the device tree the si4713 node is a normal I2C device, which will be probed as such. Thus the V4L device must be probed from the I2C device and not the other way around. Signed-off-by: Sebastian Reichel s...@kernel.org

[PATCHv3 4/4] [media] si4713: cleanup platform data

Remove unreferenced members from the platform data's structure. Signed-off-by: Sebastian Reichel s...@kernel.org --- include/media/si4713.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/media/si4713.h b/include/media/si4713.h index 343b8fb5..be4f58e 100644 --- a/include/media

[PATCHv3 2/4] [media] si4713: add DT binding documentation

This patch adds the DT bindings documentation for Silicon Labs Si4713 FM radio transmitter. Signed-off-by: Sebastian Reichel s...@kernel.org --- Documentation/devicetree/bindings/media/si4713.txt | 30 ++ 1 file changed, 30 insertions(+) create mode 100644 Documentation

Re: [RFCv2 5/8] [media] si4713: add device tree support

Hi Sakari, On Tue, Nov 04, 2014 at 11:47:14PM +0200, Sakari Ailus wrote: Nice set of patches! Thanks! :-) Thanks :) [...] struct si4713_device *sdev; - struct si4713_platform_data *pdata = client-dev.platform_data; struct v4l2_ctrl_handler *hdl; - int rval, i; +

Re: [RFCv2 1/8] [media] si4713: switch to devm regulator API

Hi Mauro, On Tue, Nov 11, 2014 at 09:07:10AM -0200, Mauro Carvalho Chehab wrote: Em Tue, 21 Oct 2014 17:07:00 +0200 Sebastian Reichel s...@kernel.org escreveu: This switches back to the normal regulator API (but use managed variant) in preparation for device tree support. This patch

Re: [GIT PULL FOR v3.19] si4713 improvements and vb2_start_streaming_called() helper

Hi Hans, On Fri, Nov 14, 2014 at 11:21:27AM +0100, Hans Verkuil wrote: This is the full si4713 patch series (with some small changes to fix compiler warnings), Thanks for taking care of this. -- Sebastian signature.asc Description: Digital signature

Re: [RFC 18/18] omap3isp: Deprecate platform data support

Hi, [+CC Tony] On Sat, Mar 07, 2015 at 11:41:15PM +0200, Sakari Ailus wrote: Print a warning when the driver is used with platform data. Existing platform data user should move to DT now. I guess this should become a more visible warning on OMAP SoC level, since platform data based boot will

Re: [RFC 14/18] dt: bindings: Add bindings for omap3isp

Hi, On Fri, Mar 13, 2015 at 01:03:21AM +0200, Sakari Ailus wrote: [...] +Required properties +=== + +compatible : ti,omap3-isp I would rephrase that using the usual wording as compatible: Must contain ti,omap3-isp. [...] +ti,phy-type : 0 --

Re: [PATCH v2 14/15] omap3isp: Add support for the Device Tree

Hi, The code crashed for me on Nokia N900. I found the following problem: On Thu, Mar 26, 2015 at 12:57:38AM +0200, Sakari Ailus wrote: [...] +static int isp_of_parse_nodes(struct device *dev, + struct v4l2_async_notifier *notifier) +{ + struct device_node

Re: [PATCH 1/1] omap3isp: Don't pass uninitialised arguments to of_graph_get_next_endpoint()

-by: Sebastian Reichel s...@kernel.org --- drivers/media/platform/omap3isp/isp.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/omap3isp/isp.c b/drivers/media/platform/omap3isp/isp.c index ff8f633..ff51c4f 100644 --- a/drivers/media/platform/omap3isp

Re: [PATCH v8 1/1] media: i2c/adp1653: Devicetree support for adp1653

Hi Sakari, Since this driver won't make it into 4.1 anyways, I have one more comment: On Thu, Apr 16, 2015 at 02:37:13AM +0300, Sakari Ailus wrote: From: Pavel Machek pa...@ucw.cz Add device tree support for adp1653 flash LED driver. Signed-off-by: Pavel Machek pa...@ucw.cz

Re: [PATCH v8 1/1] media: i2c/adp1653: Devicetree support for adp1653

Hi Pavel, On Thu, Apr 16, 2015 at 07:58:18AM +0200, Pavel Machek wrote: On Thu 2015-04-16 07:24:42, Sebastian Reichel wrote: Hi Sakari, Since this driver won't make it into 4.1 anyways, I have one more comment: Like this driver did not receive enough bikesheding. You should become

Re: [PATCH 1/1] omap3isp: Fix async notifier registration order

: Reviewed-By: Sebastian Reichel s...@kernel.org You may want to add a Fixes Tag against the patch implementing the async notifier support in omap3isp, since its quite easy to run into the callback problems (at least I did) and the missing resource freeing (due to EPROBE_AGAIN). -- Sebastian

Re: [PATCHv5 10/13] hackrf: add support for transmitter

Hi, On Sun, Oct 11, 2015 at 05:42:05PM +0300, Antti Palosaari wrote: > Moikka! > IMHO it is false positive. Variable which is defined on line 777 is used > just few lines later on line 782 as can be seen easily. I think it is > because option CONFIG_DYNAMIC_DEBUG is not set =>

Re: [PATCH] hsi: Build hsi_boardinfo.c into hsi core if enabled

Hi Andrew, On Tue, Jun 14, 2016 at 11:13:04AM -0500, Andrew F. Davis wrote: > If the HSI core is built as a module hsi_boardinfo may still > be built-in as its Kconfig type is bool, which can cause build > issues. Fix this by building this code into the HSI core when > enabled. > > Reported-by:

Re: [RFC 11/15] power: reset: keystone: Add missing MFD_SYSCON dependency on HAS_IOMEM

Hi, On Thu, Mar 03, 2016 at 12:00:14PM +0100, Arnd Bergmann wrote: > On Thursday 03 March 2016 17:03:37 Krzysztof Kozlowski wrote: > > diff --git a/drivers/power/reset/Kconfig b/drivers/power/reset/Kconfig > > index 0a6408a39c66..0f34846ae80d 100644 > > --- a/drivers/power/reset/Kconfig > > +++

Re: [RFC PATCH 00/24] Make Nokia N900 cameras working

Hi, On Wed, Apr 27, 2016 at 06:45:29PM +0200, Pavel Machek wrote: > > I don't have pre-production N900s. The phone I use for development > > is HW revision 2101 with Finish keyboard layout. Apart from that > > I have my productive phone, which is rev 2204 with German layout. > > How do you check

Re: [RFC PATCH 00/24] Make Nokia N900 cameras working

Hi, On Wed, Apr 27, 2016 at 09:57:51AM +0300, Ivaylo Dimitrov wrote: > >>https://git.kernel.org/cgit/linux/kernel/git/sre/linux-n900.git/log/?h=n900-camera-ivo > > > >Ok, going to diff with my tree to see what I have missed to send in the > >patchset > > Now, that's getting weird. [...] > I

Re: [RFC PATCH 00/24] Make Nokia N900 cameras working

Hi, On Mon, Apr 25, 2016 at 12:08:00AM +0300, Ivaylo Dimitrov wrote: > Those patch series make cameras on Nokia N900 partially working. > Some more patches are needed, but I've already sent them for > upstreaming so they are not part of the series: > > https://lkml.org/lkml/2016/4/16/14 >

Re: [RFC PATCH 00/24] Make Nokia N900 cameras working

Hi, On Fri, Apr 29, 2016 at 02:05:52AM +0200, Sebastian Reichel wrote: > On Wed, Apr 27, 2016 at 08:12:50PM +0300, Ивайло Димитров wrote: > > > The zImage + initrd works with the steps you described below. > > > > Great! > > I also got it working with th

Re: [RFC PATCH 00/24] Make Nokia N900 cameras working

Hi Ivo, On Wed, Apr 27, 2016 at 08:12:50PM +0300, Ивайло Димитров wrote: > > The zImage + initrd works with the steps you described below. > > Great! I also got it working with the previously referenced branch with the following built as modules: CONFIG_VIDEOBUF2_CORE=m

Re: [PATCH 4/7] [media] ir-rx51: add DT support to driver

Hi, On Mon, May 09, 2016 at 04:07:35PM -0500, Rob Herring wrote: > There's already a pwm-led binding that can be used. Though there > may be missing consumer IR to LED subsystem support in the kernel. > You could list both compatibles, use the rx51 IR driver now, and > then move to pwm-led driver

Re: [PATCH 4/7] [media] ir-rx51: add DT support to driver

Hi, On Fri, May 13, 2016 at 09:15:38AM +0300, Ivaylo Dimitrov wrote: > I prefer the shorter "nokia,n900-ir", will resend the series with > it used, unless someone has concerns about it. Sounds fine to me. -- Sebastian signature.asc Description: PGP signature

Re: [PATCH] devicetree: Add video bus switch

Hi, On Fri, Feb 03, 2017 at 10:07:28PM +0100, Pavel Machek wrote: > On Fri 2017-02-03 14:32:19, Pali Rohár wrote: > > On Friday 03 February 2017 13:35:08 Pavel Machek wrote: > > > N900 contains front and back camera, with a switch between the > > > two. This adds support for the switch component,

Re: [PATCH] devicetree: Add video bus switch

Hi, On Sun, Feb 05, 2017 at 10:12:20PM +0100, Pavel Machek wrote: > > > 9) Highly reconfigurable hardware - Julien Beraud > > > > > > - 44 sub-devices connected with an interconnect. > > > - As long as formats match, any sub-device could be connected to any > > > - other sub-device through a

Re: [RFC 06/13] v4l2-async: per notifier locking

Hi, On Tue, Feb 14, 2017 at 02:39:56PM +0100, Pavel Machek wrote: > From: Sebastian Reichel <s...@kernel.org> > > Without this, camera support breaks boot on N900. That's kind of vague. I just checked my original patch and it looks like I did not bother to write a proper patch

Re: [PATCH] omap3isp: add support for CSI1 bus

Hi, On Wed, Feb 15, 2017 at 11:23:01AM +0100, Pavel Machek wrote: > It seems csiphy_routing_cfg_3430 is not called at all. I added > printks, but they don't trigger. If you have an idea what is going on > there, it would help... You added printk to csiphy_routing_cfg_3630 instead of

Re: [PATCH v1.2 5/5] smiapp: Switch to gpiod API for GPIO control

p.h | 1 + > include/media/i2c/smiapp.h | 3 --- > 3 files changed, 12 insertions(+), 28 deletions(-) Reviewed-By: Sebastian Reichel <s...@kernel.org> -- Sebastian signature.asc Description: PGP signature

Re: [PATCH 3/5] smiapp: Return -EPROBE_DEFER if the clock cannot be obtained

Hi, On Wed, Aug 31, 2016 at 10:42:03AM +0300, Sakari Ailus wrote: > The clock may be provided by a driver which is yet to probe. This probably fixes N950 with built-in drivers, where I could see smiapp fails due to missing clk. I have not yet further anaylsed it, since more important parts like

Re: [PATCH 5/5] smiapp: Switch to gpiod API for GPIO control

Hi Sakari, On Wed, Aug 31, 2016 at 10:42:05AM +0300, Sakari Ailus wrote: > - if (gpio_is_valid(sensor->hwcfg->xshutdown)) { > + if (client->dev.of_node) { > + sensor->xshutdown = > + devm_gpiod_get_optional(>dev, "xshutdown", > +

Re: [PATCH 0/5] smiapp cleanups, retry probe if getting clock fails

Hi, On Wed, Aug 31, 2016 at 10:42:00AM +0300, Sakari Ailus wrote: > These patches contain cleanups for the smiapp driver and return > -EPROBE_DEFER if getting the clock fails. Apart from comments on patches 3 & 5 the patchset is Reviewed-By: Sebastian Reichel <s...@kernel.org&g

Re: [PATCH v1.1 3/5] smiapp: Return -EPROBE_DEFER if the clock cannot be obtained

ing of the original error code Reviewed-By: Sebastian Reichel <s...@kernel.org> signature.asc Description: PGP signature

Re: [PATCH v1.1 6/6] smiapp: Remove set_xclk() callback from hwconfig

miapp/smiapp-core.c | 49 > -- > include/media/i2c/smiapp.h | 2 -- > 2 files changed, 17 insertions(+), 34 deletions(-) Reviewed-By: Sebastian Reichel <s...@kernel.org> -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v1.1 5/5] smiapp: Switch to gpiod API for GPIO control

ould add: if (IS_ERR(sensor->xshutdown)) { rval = PTR_ERR(sensor->xshutdown); dev_err(>dev, "Could not get gpio (%ld)\n", rval); return rval; } > [...] Otherwise the patch looks fine, so with this fixed: Reviewed-By: Sebastian Reichel <s...@kernel.org> -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v2 16/17] smiapp: Drop a debug print on frame size and bit depth

Hi, On Thu, Sep 15, 2016 at 02:22:30PM +0300, Sakari Ailus wrote: > The first time the sensor is powered on, the information is not yet > available. > > Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> Reviewed-By: Sebastian Reichel <s...@kernel.org> -- S

Re: [PATCH v2 15/17] smiapp: Obtain correct media bus code for try format

Hi, On Thu, Sep 15, 2016 at 02:22:29PM +0300, Sakari Ailus wrote: > The media bus code obtained for try format may have been a code that the > sensor did not even support. Use a supported code with the current pixel > order. Reviewed-By: Sebastian Reichel <s...@kernel.org>

Re: [PATCH v2 17/17] smiapp-pll: Don't complain aloud about failing PLL calculation

re > lots of unnecessary driver messages. During normal operation the failure > generally does not happen. Use dev_dbg() instead. > > Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> Reviewed-By: Sebastian Reichel <s...@kernel.org> -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v2 03/17] smiapp: Initialise media entity after sensor init

gt;pads); > + if (rval < 0) > + goto out_media_entity_cleanup; > + > rval = v4l2_async_register_subdev(>src->sd); > if (rval < 0) > goto out_media_entity_cleanup; As far as I can see this is not strictly needed, but: Reviewed-By: Sebastian Reichel <s...@kernel.org> -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v2 04/17] smiapp: Split off sub-device registration into two

Hi, On Thu, Sep 15, 2016 at 02:22:18PM +0300, Sakari Ailus wrote: > Remove the loop in sub-device registration and create each sub-device > explicitly instead. Reviewed-By: Sebastian Reichel <s...@kernel.org> > +static int smiapp_register_subdevs(struct smiapp_sensor *sensor) &

Re: [PATCH v2 06/17] smiapp: Remove unnecessary BUG_ON()'s

Hi, On Thu, Sep 15, 2016 at 02:22:20PM +0300, Sakari Ailus wrote: > Instead, calculate how much is needed and then allocate the memory > dynamically. Reviewed-By: Sebastian Reichel <s...@kernel.org> -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v2 13/17] smiapp: Improve debug messages from frame layout reading

", 0x8.8x doesn't look very interesting ;) Apart from the '%' the actual argument is also missing. > [...] Once that is fixed: Reviewed-By: Sebastian Reichel <s...@kernel.org> -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v2 14/17] smiapp: Remove useless newlines and other small cleanups

Hi, On Thu, Sep 15, 2016 at 02:22:28PM +0300, Sakari Ailus wrote: > The code probably has been unindented at some point but rewrapping has not > been done. Do it now. > > Also remove a useless memory allocation failure message. Reviewed-By: Sebastian Reichel <s...@kernel.org

Re: [PATCH v1.1 5/5] smiapp: Implement support for autosuspend

ng > pm_runtime_get_noresume(), and decrement it before returning. This > avoids a serialisation problem with autosuspend. > > drivers/media/i2c/smiapp/smiapp-core.c | 10 +++--- > drivers/media/i2c/smiapp/smiapp-regs.c | 21 +++-- > 2 files changed, 22 inser

Re: [PATCH v3 00/18] More smiapp cleanups, fixes

frame descriptor (image data lines are > among embedded data lines) > > - Fix error handling in registered() callback, add unregistered() > callback > > - smiapp_create_subdev() will return immediately if its ssd argument is > NULL. No need for caller to check this. Re

Re: [PATCH v2 02/17] smiapp: Explicitly define number of pads in initialisation

Hi, On Thu, Sep 15, 2016 at 02:22:16PM +0300, Sakari Ailus wrote: > Define the number of pads explicitly in initialising the sub-devices. Reviewed-By: Sebastian Reichel <s...@kernel.org> -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v2 01/17] smiapp: Move sub-device initialisation into a separate function

Hi, On Thu, Sep 15, 2016 at 02:22:15PM +0300, Sakari Ailus wrote: > Simplify smiapp_init() by moving the initialisation of individual > sub-devices to a separate function. Reviewed-By: Sebastian Reichel <s...@kernel.org> > Signed-off-by: Sakari Ailus <sakari.ai.

Re: [PATCH v2 05/17] smiapp: Provide a common function to obtain native pixel array size

Hi, On Thu, Sep 15, 2016 at 02:22:19PM +0300, Sakari Ailus wrote: > The same pixel array size is required for the active format of each > sub-device sink pad and try format of each sink pad of each opened file > handle as well as for the native size rectangle. Reviewed-By: Sebastian R

Re: [PATCH v2 07/17] smiapp: Always initialise the sensor in probe

Hi, On Thu, Sep 15, 2016 at 02:22:21PM +0300, Sakari Ailus wrote: > Initialise the sensor in probe. The reason why it wasn't previously done > in case of platform data was that the probe() of the driver that provided > the clock through the set_xclk() callback would need to finish before the >

Re: [PATCH v2 04/17] smiapp: Split off sub-device registration into two

Hi, On Mon, Sep 19, 2016 at 11:50:02PM +0300, Sakari Ailus wrote: > Hi Sebastian, > > Sebastian Reichel wrote: > > Hi, > > > > On Thu, Sep 15, 2016 at 02:22:18PM +0300, Sakari Ailus wrote: > > > Remove the loop in sub-device registration and create each

Re: [PATCH v2 09/17] smiapp: Read frame format earlier

Hi, On Thu, Sep 15, 2016 at 02:22:23PM +0300, Sakari Ailus wrote: > The information gathered during frame format reading will be required > earlier in the initialisation when it was available. Also return an error > if frame format cannot be obtained. > > Signed-off-by: Sakari Ailus

Re: [PATCH v2 12/17] smiapp: Obtain frame layout from the frame descriptor

Hi, On Thu, Sep 15, 2016 at 02:22:26PM +0300, Sakari Ailus wrote: > Besides the image data, SMIA++ compliant sensors also provide embedded > data in form of registers used to capture the image. Store this > information for later use in frame descriptor and routing. Reviewed-By: Sebastia

Re: [PATCH v2 09/17] smiapp: Read frame format earlier

Hi, On Tue, Sep 20, 2016 at 12:19:54AM +0300, Sakari Ailus wrote: > Hi Sebastian, > > Sebastian Reichel wrote: > > Hi, > > > > On Thu, Sep 15, 2016 at 02:22:23PM +0300, Sakari Ailus wrote: > > > The information gathered during frame format re

Re: [PATCH v2 08/17] smiapp: Merge smiapp_init() with smiapp_probe()

Hi, On Thu, Sep 15, 2016 at 02:22:22PM +0300, Sakari Ailus wrote: > The smiapp_probe() is the sole caller of smiapp_init(). Unify the two. Reviewed-By: Sebastian Reichel <s...@kernel.org> -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v2 11/17] smiapp: Use SMIAPP_PADS when referring to number of pads

Hi, On Thu, Sep 15, 2016 at 02:22:25PM +0300, Sakari Ailus wrote: > Replace plain value 2 with SMIAPP_PADS when referring to the number of > pads. Reviewed-By: Sebastian Reichel <s...@kernel.org> -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v2 10/17] smiapp: Unify setting up sub-devices

Hi, On Thu, Sep 15, 2016 at 02:22:24PM +0300, Sakari Ailus wrote: > The initialisation of the source sub-device is somewhat different as it's > not created by the smiapp driver itself. Remove redundancy in initialising > the two kind of sub-devices. Reviewed-By: Sebastian R

Re: [PATCH v1.1 4/5] smiapp: Use runtime PM

Hi, On Fri, Sep 16, 2016 at 01:53:29AM +0300, Sakari Ailus wrote: > [...] > > diff --git a/drivers/media/i2c/smiapp/smiapp-regs.c > b/drivers/media/i2c/smiapp/smiapp-regs.c > index 1e501c0..a9c7baf 100644 > --- a/drivers/media/i2c/smiapp/smiapp-regs.c > +++

Re: [PATCH 2/5] smiapp: Set device for pixel array and binner

Hi, On Thu, Sep 15, 2016 at 02:29:18PM +0300, Sakari Ailus wrote: > The dev field of the v4l2_subdev was left NULL for the pixel array and > binner sub-devices. Fix this. > > Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> Reviewed-By: Sebastian Reiche

Re: [PATCH 3/5] smiapp: Set use suspend and resume ops for other functions

Hi, On Thu, Sep 15, 2016 at 02:29:19PM +0300, Sakari Ailus wrote: > Use the suspend and resume ops for freeze, thaw, poweroff and restore > callbacks as well. > > Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> Reviewed-By: Sebastian Reichel <s...@kern

Re: [PATCH v1.1 4/5] smiapp: Use runtime PM

| 130 > - > drivers/media/i2c/smiapp/smiapp-regs.c | 5 ++ > drivers/media/i2c/smiapp/smiapp.h | 11 +-- > 3 files changed, 67 insertions(+), 79 deletions(-) Reviewed-By: Sebastian Reichel <s...@kernel.org> -- Sebastian signature.asc Description: PGP signature

Re: [PATCH v4] media: Driver for Toshiba et8ek8 5MP sensor

Hi Sakari, On Mon, Nov 14, 2016 at 11:58:28PM +0200, Sakari Ailus wrote: > [...] > > On Fri, Nov 04, 2016 at 01:05:25AM +0100, Sebastian Reichel wrote: > > I'm not sure what part relevant for video-bus-switch is currently > > not supported? > > > > video-b

Re: [PATCH v4] media: Driver for Toshiba et8ek8 5MP sensor

Hi, On Tue, Nov 01, 2016 at 12:54:08AM +0200, Sakari Ailus wrote: > > > Thanks, this answered half of my questions already. ;-) > > :-). > > > > I'll have to go through the patches, et8ek8 driver is probably not > > enough to get useful video. platform/video-bus-switch.c is needed for > > camera

Re: [PATCH v4] media: Driver for Toshiba et8ek8 5MP sensor

Hi, On Fri, Nov 04, 2016 at 01:05:01AM +0200, Sakari Ailus wrote: > On Thu, Nov 03, 2016 at 11:48:43PM +0100, Sebastian Reichel wrote: > > On Tue, Nov 01, 2016 at 12:54:08AM +0200, Sakari Ailus wrote: > > > > > Thanks, this answered half

Re: [PATCHv2] dt: bindings: Add support for CSI1 bus

f data-lanes and clock-lanes properties. >If the lane-polarities property is omitted, the value must be interpreted >as 0 (normal). This property is valid for serial busses only. > - > +- strobe: Whether the clock signal is used as clock or strobe. Used > + with CCP2, for instance. > > Example > --- > > Reviewed-By: Sebastian Reichel <s...@kernel.org> -- Sebastian signature.asc Description: PGP signature

Re: [PATCH] mark myself as mainainer for camera on N900

r/supply/bq27xxx_battery_i2c.c F: drivers/power/supply/isp1704_charger.c F: drivers/power/supply/rx51_battery.c TI BQ27XXX POWER SUPPLY DRIVER R: Andrew F. Davis <a...@ti.com> F: include/linux/power/bq27xxx_battery.h F: drivers/power/supply/bq27xxx_battery.c F:

Re: [RFC/PATCH] media: Add video bus switch

Hi, On Thu, Dec 22, 2016 at 09:53:17PM +0100, Pavel Machek wrote: > > 1. Settings must be applied before the streaming starts instead of > > at probe time, since the settings may change (based one the selected > > camera). That should be fairly easy to implement by just moving the > > code to the

Re: [RFC/PATCH] media: Add video bus switch

Hi, On Thu, Dec 22, 2016 at 11:42:26PM +0100, Pavel Machek wrote: > On Thu 2016-12-22 15:32:44, Sebastian Reichel wrote: > > Hi Pavel, > > > > On Thu, Dec 22, 2016 at 02:39:38PM +0100, Pavel Machek wrote: > > > N900 contains front and back camera, with a switch be

Re: [RFC/PATCH] media: Add video bus switch

Hi Pavel, On Thu, Dec 22, 2016 at 02:39:38PM +0100, Pavel Machek wrote: > N900 contains front and back camera, with a switch between the > two. This adds support for the swich component. > > Signed-off-by: Sebastian Reichel <s...@kernel.org> > Signed-off-by: Ivaylo Dim

Re: [PATCH 4/7] omap3isp: Return -EPROBE_DEFER if the required regulators can't be obtained

Hi, On Tue, Jul 18, 2017 at 01:01:13AM +0300, Sakari Ailus wrote: > From: Pavel Machek > > If regulator returns -EPROBE_DEFER, we need to return it too, so that > omap3isp will be re-probed when regulator is ready. > > Signed-off-by: Pavel Machek > Reviewed-by:

Re: [PATCH 1/7] omap3isp: Ignore endpoints with invalid configuration

Hi, On Tue, Jul 18, 2017 at 01:01:10AM +0300, Sakari Ailus wrote: > If endpoint has an invalid configuration, ignore it instead of happily > proceeding to use it nonetheless. Ignoring such an endpoint is better than > failing since there could be multiple endpoints, only some of which are > bad.

Re: [PATCH 2/7] omap3isp: Parse CSI1 configuration from the device tree

Hi, On Tue, Jul 18, 2017 at 01:01:11AM +0300, Sakari Ailus wrote: > From: Pavel Machek <pa...@ucw.cz> > > Add support for parsing CSI1 configuration. > > Signed-off-by: Pavel Machek <pa...@ucw.cz> > Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com

Re: [PATCH 7/8] omap3isp: Check for valid port in endpoints

Hi, On Thu, Jul 06, 2017 at 02:00:18AM +0300, Sakari Ailus wrote: > Check that we do have a valid port in an endpoint, return an error if not. > > Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co

Re: [PATCH 5/8] v4l: Add support for CSI-1 and CCP2 busses

achek <pa...@ucw.cz> Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> -- Sebastian > --- > drivers/media/platform/pxa_camera.c | 3 ++ > drivers/media/platform/soc_camera/soc_mediabus.c | 3 ++ > drivers/media/v4l2-core/v4l2-fwnode.c

Re: [PATCH 4/8] v4l: fwnode: Obtain data bus type from FW

Hi, On Thu, Jul 06, 2017 at 02:00:15AM +0300, Sakari Ailus wrote: > From: Sakari Ailus <sakari.ai...@iki.fi> > > Just obtain it. It'll actually get used soon with CSI-1/CCP2. > > Signed-off-by: Sakari Ailus <sakari.ai...@linux.intel.com> Reviewed-by: Sebast

Re: [PATCH 3/8] v4l: fwnode: Call CSI2 bus csi2, not csi

i Ailus <sakari.ai...@linux.intel.com> Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> -- Sebastian > --- > drivers/media/v4l2-core/v4l2-fwnode.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/v4l2-co

Re: [PATCH 1/8] arm: omap4: enable CEC pin for Pandaboard A4 and ES

Hi, On Fri, Apr 28, 2017 at 08:08:59AM -0700, Tony Lindgren wrote: > * Tomi Valkeinen [170428 04:15]: > > On 14/04/17 13:25, Hans Verkuil wrote: > > > From: Hans Verkuil > > > > > > The CEC pin was always pulled up, making it impossible to use it.

Re: [PATCH v5 2/3] platform: add video-multiplexer subdevice driver

s through > the mbus configuration of the active input to the output side. > > Signed-off-by: Sascha Hauer <s.ha...@pengutronix.de> > Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> > Signed-off-by: Steve Longerbeam <steve_longerb...@mentor.com> Revi

Re: [PATCH 1/8] dt: bindings: Add a binding for flash devices associated to a sensor

ilus <sakari.ai...@linux.intel.com> Reviewed-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk> -- Sebastian > --- > Documentation/devicetree/bindings/media/video-interfaces.txt | 8 > 1 file changed, 8 insertions(+) > > diff --git a/Documentation/devi

  1   2   >