Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-21 Thread Tomasz Figa
Hi, On Monday 08 of April 2013 16:41:54 Viresh Kumar wrote: On 8 April 2013 16:37, Vikas Sajjan vikas.saj...@linaro.org wrote: While migrating to common clock framework (CCF), I found that the FIMD clocks were pulled down by the CCF. If CCF finds any clock(s) which has NOT been claimed by

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-21 Thread Tomasz Figa
Hi Inki, On Sunday 21 of April 2013 22:36:08 Inki Dae wrote: 2013/4/21 Tomasz Figa tomasz.f...@gmail.com Hi, On Monday 08 of April 2013 16:41:54 Viresh Kumar wrote: On 8 April 2013 16:37, Vikas Sajjan vikas.saj...@linaro.org wrote: While migrating to common clock framework (CCF

[PATCH] MAINTAINERS: Add linux-samsung-soc list to all related entries

2013-04-21 Thread Tomasz Figa
, even though they are related to Samsung SoCs. This patch adds pointers to linux-samsung-soc mailing list to affected entries of MAINTAINERS file. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- MAINTAINERS | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MAINTAINERS b

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
On Sunday 21 of April 2013 22:36:08 Inki Dae wrote: 2013/4/21 Tomasz Figa tomasz.f...@gmail.com Hi, On Monday 08 of April 2013 16:41:54 Viresh Kumar wrote: On 8 April 2013 16:37, Vikas Sajjan vikas.saj...@linaro.org wrote: While migrating to common clock framework (CCF

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
On Monday 22 of April 2013 10:44:00 Viresh Kumar wrote: On 21 April 2013 20:13, Tomasz Figa tomasz.f...@gmail.com wrote: 3) after those two changes, all that remains is to fix compliance with Common Clock Framework, in other words: s/clk_enable/clk_prepare_enable/ and s

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
. This would mean that any user that from some reasons don't want to use PM_RUNTIME, would not be able to use the driver anymore. Rafael, Kevin, do you have any opinion on this? Best regards, -- Tomasz Figa Samsung Poland RD Center SW Solution Development, Kernel and System Framework -- To unsubscribe

Re: [PATCH v4] drm/exynos: prepare FIMD clocks

2013-04-22 Thread Tomasz Figa
On Monday 22 of April 2013 12:05:49 Sylwester Nawrocki wrote: On 04/22/2013 11:56 AM, Tomasz Figa wrote: On Monday 22 of April 2013 10:44:00 Viresh Kumar wrote: On 21 April 2013 20:13, Tomasz Figa tomasz.f...@gmail.com wrote: 3) after those two changes, all that remains is to fix compliance

Re: Introduce a new helper framework for buffer synchronization

2013-05-13 Thread Tomasz Figa
Hi, On Monday 13 of May 2013 20:24:01 Inki Dae wrote: -Original Message- From: Maarten Lankhorst [mailto:maarten.lankho...@canonical.com] Sent: Monday, May 13, 2013 6:52 PM To: Inki Dae Cc: 'Rob Clark'; 'Daniel Vetter'; 'DRI mailing list'; linux-arm-

[PATCH 27/28] ARM: EXYNOS: Remove CONFIG_SOC_EXYNOS4412

2013-06-14 Thread Tomasz Figa
: linux-media@vger.kernel.org Cc: linux-ser...@vger.kernel.org Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/Kconfig | 11 +-- arch/arm/plat-samsung/include/plat/cpu.h | 6 +- drivers/cpufreq

Re: [PATCH 27/28] ARM: EXYNOS: Remove CONFIG_SOC_EXYNOS4412

2013-06-15 Thread Tomasz Figa
On Saturday 15 of June 2013 10:06:25 Eduardo Valentin wrote: Tomasz, On 14-06-2013 15:33, Tomasz Figa wrote: Exynos4212 and Exynos4412 SoCs differ only in number of ARM cores and there is no need to have separate Kconfig options for them, since they use the same code. This patch

Re: [RFC PATCH 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-06-16 Thread Tomasz Figa
Hi Sylwester, Looks good, but I added some nitpicks inline. On Friday 14 of June 2013 19:45:47 Sylwester Nawrocki wrote: Add a PHY provider driver for the Samsung S5P/Exynos SoC MIPI CSI-2 receiver and MIPI DSI transmitter DPHYs. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com

Re: [RFC PATCH 2/5] ARM: dts: Add MIPI PHY node to exynos4.dtsi

2013-06-16 Thread Tomasz Figa
On Friday 14 of June 2013 19:45:48 Sylwester Nawrocki wrote: Add PHY provider node for the MIPI CSIS and MIPI DSIM PHYs. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4.dtsi | 12

Re: [RFC PATCH 3/5] video: exynos_dsi: Use generic PHY driver

2013-06-16 Thread Tomasz Figa
On Friday 14 of June 2013 19:45:49 Sylwester Nawrocki wrote: Use the generic PHY API instead of the platform callback to control the MIPI DSIM DPHY. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com ---

[PATCH v2 17/38] [media] platform: Check for ARCH_EXYNOS separately

2013-06-17 Thread Tomasz Figa
Stanislawski t.stanisl...@samsung.com Cc: Jeongtae Park jtp.p...@samsung.com Signed-off-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/Kconfig| 6 +++--- drivers/media/platform/exynos4-is/Kconfig | 3 ++- drivers/media

[PATCH v2 32/38] [media] exynos4-is: Remove check for SOC_EXYNOS4412

2013-06-17 Thread Tomasz Figa
Since SOC_EXYNOS4412 Kconfig symbol has been removed, it is enough to check for SOC_EXYNOS4212 for both SoCs from Exynos4x12 series. Cc: linux-media@vger.kernel.org Cc: Mauro Carvalho Chehab mche...@redhat.com Cc: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Tomasz Figa t.f

Re: [RFC PATCH 3/5] video: exynos_dsi: Use generic PHY driver

2013-06-19 Thread Tomasz Figa
On Wednesday 19 of June 2013 19:10:52 Sylwester Nawrocki wrote: On 06/16/2013 11:15 PM, Tomasz Figa wrote: On Friday 14 of June 2013 19:45:49 Sylwester Nawrocki wrote: Use the generic PHY API instead of the platform callback to control the MIPI DSIM DPHY. Signed-off-by: Sylwester

Re: [PATCH 0/1] S3C244X/S3C64XX SoC camera host interface driver

2012-08-11 Thread Tomasz Figa
of S3C64xx and any needed stream duplication and rescaling is done in later processing, so it might be wise to migrate to yours. Best regards, Tomasz Figa The patch to follow only adds the CAMIF driver, the other two required for the camera on Mini2440 board to work (OV9650 sensor driver

Re: [PATCH 0/1] S3C244X/S3C64XX SoC camera host interface driver

2012-08-11 Thread Tomasz Figa
On Saturday 11 of August 2012 21:32:15 Sylwester Nawrocki wrote: On 08/11/2012 08:39 PM, Tomasz Figa wrote: Hi, On Saturday 11 of August 2012 20:06:13 Sylwester Nawrocki wrote: Hi all, This patch adds a driver for Samsung S3C244X/S3C64XX SoC series camera host interface. My

Re: s5p-fimc VIDIOC_STREAMOFF bug

2012-04-21 Thread Tomasz Figa
Hi Sylwester, Thanks for your response. On Friday 20 of April 2012 20:24:38 Sylwester Nawrocki wrote: Hi Tomasz, On 04/19/2012 11:45 PM, Tomasz Figa wrote: Hi, I have been working on adapting s5p-fimc driver for s3c6410 and everything seems to be working just fine after some minor

Re: [PATCH v5 0/4] media: s5p-tv: clean-up and fixes

2013-09-23 Thread Tomasz Figa
/platform/s5p-tv/sdo_drv.c | 39 +++-- 7 files changed, 137 insertions(+), 105 deletions(-) For the whole series: Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord

[PATCH 4/5] ASoC: samsung: Use CONFIG_ARCH_S3C64XX to check for S3C64xx support

2013-09-28 Thread Tomasz Figa
Since CONFIG_PLAT_S3C64XX is going to be removed, this patch modifies the s3c-i2s-v2 driver to use the proper way of checking for S3C64xx support - CONFIG_ARCH_S3C64XX. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- sound/soc/samsung/s3c-i2s-v2.c | 6 +- 1 file changed, 1 insertion

[PATCH 3/5] [media] s3c-camif: Use CONFIG_ARCH_S3C64XX to check for S3C64xx support

2013-09-28 Thread Tomasz Figa
Since CONFIG_PLAT_S3C64XX is going to be removed, this patch modifies the Kconfig entry of s3c-camif driver to use the proper way of checking for S3C64xx support - CONFIG_ARCH_S3C64XX. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- drivers/media/platform/Kconfig | 2 +- 1 file changed, 1

[PATCH 5/5] ARM: s3c64xx: Kill CONFIG_PLAT_S3C64XX

2013-09-28 Thread Tomasz Figa
CONFIG_PLAT_S3C64XX has been kept in place way too long since it was marked as temporary in commit 110d85a ARM: S3C64XX: Eliminate plat-s3c64xx After fixing all users of it in previous patches, this patch finally kills this temporary Kconfig entry. Signed-off-by: Tomasz Figa tomasz.f

[PATCH 1/5] ARM: Kconfig: Move if ARCH_S3C64XX statement to mach-s3c64xx/Kconfig

2013-09-28 Thread Tomasz Figa
All other platforms have this condition checked inside their own Kconfig files, so for consistency this patch makes it this way for mach-s3c64xx as well. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- arch/arm/Kconfig | 2 -- arch/arm/mach-s3c64xx/Kconfig | 4 2 files

[PATCH 2/5] gpio: samsung: Use CONFIG_ARCH_S3C64XX to check for S3C64xx support

2013-09-28 Thread Tomasz Figa
Since CONFIG_PLAT_S3C64XX is going to be removed, this patch modifies the gpio-samsung driver to use the proper way of checking for S3C64xx support - CONFIG_ARCH_S3C64XX. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com --- drivers/gpio/gpio-samsung.c | 8 1 file changed, 4 insertions

Re: [PATCH 2/5] gpio: samsung: Use CONFIG_ARCH_S3C64XX to check for S3C64xx support

2013-10-02 Thread Tomasz Figa
Hi Linus, On Wednesday 02 of October 2013 12:46:51 Linus Walleij wrote: On Sat, Sep 28, 2013 at 8:21 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Since CONFIG_PLAT_S3C64XX is going to be removed, this patch modifies the gpio-samsung driver to use the proper way of checking for S3C64xx

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-04 Thread Tomasz Figa
not contain my fixes for S3C6410. Best regards, Tomasz Figa -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC v2 0/5] Common Display Framework

2012-12-21 Thread Tomasz Figa
and s6e8ax0 LCD driver to use the v2 RFC of Common Display Framework. I have most of the work done, I have just to solve several remaining problems. Best regards, -- Tomasz Figa Samsung Poland RD Center SW Solution Development, Linux Platform -- To unsubscribe from this list: send the line unsubscribe

Re: [RFC v2 0/5] Common Display Framework

2012-12-27 Thread Tomasz Figa
Hi Laurent, On Monday 24 of December 2012 15:12:28 Laurent Pinchart wrote: Hi Tomasz, On Friday 21 December 2012 11:00:52 Tomasz Figa wrote: On Tuesday 18 of December 2012 08:31:30 Vikas Sajjan wrote: On 17 December 2012 20:55, Laurent Pinchart wrote: Hi Vikas, Sorry

Re: [PATCH 2/2] [RFC] video: display: Adding frame related ops to MIPI DSI video source struct

2013-01-03 Thread Tomasz Figa
used at the moment and if frame done status monitoring will be ever needed, I think a better way should be implemented. Best regards, -- Tomasz Figa Samsung Poland RD Center SW Solution Development, Linux Platform -- To unsubscribe from this list: send the line unsubscribe linux-media

Re: [RFC v2 0/5] Common Display Framework

2013-01-08 Thread Tomasz Figa
On Tuesday 08 of January 2013 11:12:26 Marcus Lorentzon wrote: On 01/08/2013 09:18 AM, Laurent Pinchart wrote: On Thursday 27 December 2012 15:43:34 Tomasz Figa wrote: On Monday 24 of December 2012 15:12:28 Laurent Pinchart wrote: On Friday 21 December 2012 11:00:52 Tomasz Figa wrote

Re: [oselas] Audio support on Mini6410 board

2013-02-09 Thread Tomasz Figa
Hi, On Saturday 09 of February 2013 19:21:32 Sylwester Nawrocki wrote: Hi, On 01/20/2013 09:46 PM, Alexander Nestorov wrote: I have been playing for a week with the board. Both audio and video work correctly, but I haven't been able to set the mic settings in alsamixer (so I can't test

Re: [PATCH v2 1/5] phy: Add driver for Exynos MIPI CSIS/DSIM DPHYs

2013-06-25 Thread Tomasz Figa
Hi Sylwester, Felipe, On Tuesday 25 of June 2013 19:44:52 Sylwester Nawrocki wrote: Hi Felipe, Thanks for the review. On 06/25/2013 05:06 PM, Felipe Balbi wrote: On Tue, Jun 25, 2013 at 04:21:46PM +0200, Sylwester Nawrocki wrote: +enum phy_id { + PHY_CSIS0, + PHY_DSIM0, +

Re: [PATCH V4 4/4] video: exynos_dp: Use the generic PHY driver

2013-07-05 Thread Tomasz Figa
video_info *video_info; struct link_train link_train; struct work_struct hotplug_work; + nit: unnecessary blank line + struct phy *phy; }; /* exynos_dp_reg.c */ Otherwise looks good. Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards

Re: [PATCH V4 3/4] video: exynos_dp: remove non-DT support for Exynos Display Port

2013-07-05 Thread Tomasz Figa
| 131 - 5 files changed, 135 insertions(+), 225 deletions(-) delete mode 100644 include/video/exynos_dp.h Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

Re: [PATCH V4 2/4] phy: Add driver for Exynos DP PHY

2013-07-05 Thread Tomasz Figa
-exynos-dp-video.c Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V4 1/4] ARM: dts: Add DP PHY node to exynos5250.dtsi

2013-07-05 Thread Tomasz Figa
(-) Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Tomasz Figa
Hi, On Saturday 20 of July 2013 19:59:10 Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: On Sat, 20 Jul 2013, Greg KH wrote: That should be passed using platform data. Ick, don't pass strings around, pass pointers. If you have platform data you

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-21 Thread Tomasz Figa
On Sunday 21 of July 2013 16:37:33 Kishon Vijay Abraham I wrote: Hi, On Sunday 21 July 2013 04:01 PM, Tomasz Figa wrote: Hi, On Saturday 20 of July 2013 19:59:10 Greg KH wrote: On Sat, Jul 20, 2013 at 10:32:26PM -0400, Alan Stern wrote: On Sat, 20 Jul 2013, Greg KH wrote

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
Hi Alan, On Monday 22 of July 2013 10:44:39 Alan Stern wrote: On Mon, 22 Jul 2013, Kishon Vijay Abraham I wrote: The PHY and the controller it is attached to are both physical devices. The connection between them is hardwired by the system manufacturer and cannot be

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
[Fixed address of devicetree mailing list and added more people on CC.] For reference, full thread can be found under following link: http://thread.gmane.org/gmane.linux.ports.arm.kernel/252813 Best regards, Tomasz On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi Alan, On Monday 22

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 10:37:05 Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi Alan, Thanks for helping to clarify the issues here. Okay. Are PHYs _always_ platform devices? They can be i2c, spi or any

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 09:18:46 Greg KH wrote: On Tue, Jul 23, 2013 at 08:48:24PM +0530, Kishon Vijay Abraham I wrote: Hi, On Tuesday 23 July 2013 08:07 PM, Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: On Tuesday 23 of July 2013 09:29:32 Tomasz Figa wrote: Hi Alan

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 10:37:11 Greg KH wrote: On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: Ick, no. Why can't you just pass the pointer to the phy itself? If you had a priv pointer to search from, then you could have just passed the original phy pointer

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 12:44:23 Greg KH wrote: On Tue, Jul 23, 2013 at 08:31:05PM +0100, Mark Brown wrote: You don't know the id of the device you are looking up, due to multiple devices being in the system (dynamic ids, look back earlier in this thread for details about that.)

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 15:36:00 Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: IMHO it would be better if you provided some code example, but let's try to check if I understood you correctly. 8

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 11:04:14 Greg KH wrote: On Tue, Jul 23, 2013 at 07:48:11PM +0200, Tomasz Figa wrote: On Tuesday 23 of July 2013 10:37:11 Greg KH wrote: On Tue, Jul 23, 2013 at 06:50:29PM +0200, Tomasz Figa wrote: Ick, no. Why can't you just pass the pointer to the phy itself

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 16:53:55 Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: That's what I was going to suggest too. The struct phy is defined in the board file, which already knows about all the PHYs that exist in the system. (Or perhaps it is allocated dynamically

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 13:50:07 Greg KH wrote: On Tue, Jul 23, 2013 at 10:07:52PM +0200, Tomasz Figa wrote: On Tuesday 23 of July 2013 12:44:23 Greg KH wrote: On Tue, Jul 23, 2013 at 08:31:05PM +0100, Mark Brown wrote: You don't know the id of the device you are looking up, due

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-07-23 Thread Tomasz Figa
On Tuesday 23 of July 2013 17:14:20 Alan Stern wrote: On Tue, 23 Jul 2013, Tomasz Figa wrote: If you want to keep the phy struct completely separate from the board file, there's an easy way to do it. Let's say the board file knows about N different PHYs in the system. Then you

Re: [PATCH] drm/exynos: Add check for IOMMU while passing physically continous memory flag

2013-08-01 Thread Tomasz Figa
Hi Vikas, On Thursday 01 of August 2013 16:49:32 Vikas Sajjan wrote: While trying to get boot-logo up on exynos5420 SMDK which has eDP panel connected with resolution 2560x1600, following error occured even with IOMMU enabled: [0.88] [drm:lowlevel_buffer_allocate] *ERROR* failed to

Re: [PATCH] drm/exynos: Add check for IOMMU while passing physically continous memory flag

2013-08-02 Thread Tomasz Figa
Hi Vikas, On Friday 02 of August 2013 12:08:52 Vikas Sajjan wrote: Hi Rob, On 2 August 2013 06:03, Rob Clark robdcl...@gmail.com wrote: On Thu, Aug 1, 2013 at 7:20 PM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Vikas, On Thursday 01 of August 2013 16:49:32 Vikas Sajjan wrote

Re: [PATCH V2] drm/exynos: Add fallback option to get non physically continous memory for fb

2013-08-05 Thread Tomasz Figa
. Signed-off-by: Vikas Sajjan vikas.saj...@linaro.org Signed-off-by: Arun Kumar arun...@samsung.com --- changes since v1: - Modified to add the fallback patch if CONTIG alloc fails as suggested by Rob Clark robdcl...@gmail.com and Tomasz Figa tomasz.f...@gmail.com. - changed

Re: [PATCH 2/2] media: s5p-mfc: remove DT hacks and simplify initialization code

2013-08-06 Thread Tomasz Figa
Hi Kukjin, On Wednesday 07 of August 2013 07:13:09 Kukjin Kim wrote: On 08/06/13 19:22, Kamil Debski wrote: Hi Kukjin, This patch looks good. Best wishes, Kamil Debski From: Marek Szyprowski [mailto:m.szyprow...@samsung.com] Sent: Monday, August 05, 2013 2:27 PM This

Re: [PATCH 1/2] ARM: Exynos: replace custom MFC reserved memory handling with generic code

2013-08-08 Thread Tomasz Figa
Hi Stephen, On Thursday 08 of August 2013 15:00:52 Stephen Warren wrote: On 08/05/2013 06:26 AM, Marek Szyprowski wrote: MFC driver use custom bindings for managing reserved memory. Those bindings are not really specific to MFC device and no even well discussed. They can be easily replaced

Re: [PATCH 1/2] ARM: Exynos: replace custom MFC reserved memory handling with generic code

2013-08-08 Thread Tomasz Figa
On Thursday 08 of August 2013 15:47:19 Stephen Warren wrote: On 08/08/2013 03:19 PM, Tomasz Figa wrote: Hi Stephen, On Thursday 08 of August 2013 15:00:52 Stephen Warren wrote: On 08/05/2013 06:26 AM, Marek Szyprowski wrote: MFC driver use custom bindings for managing reserved memory

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-08-13 Thread Tomasz Figa
On Tuesday 13 of August 2013 16:14:44 Kishon Vijay Abraham I wrote: Hi, On Wednesday 31 July 2013 11:45 AM, Felipe Balbi wrote: Hi, On Wed, Jul 31, 2013 at 11:14:32AM +0530, Kishon Vijay Abraham I wrote: IMHO we need a lookup method for PHYs, just like for clocks, regulators, PWMs

Re: [PATCH 01/15] drivers: phy: add generic PHY framework

2013-08-13 Thread Tomasz Figa
On Wednesday 14 of August 2013 00:19:28 Sylwester Nawrocki wrote: W dniu 2013-08-13 14:05, Kishon Vijay Abraham I pisze: On Tuesday 13 August 2013 05:07 PM, Tomasz Figa wrote: On Tuesday 13 of August 2013 16:14:44 Kishon Vijay Abraham I wrote: On Wednesday 31 July 2013 11:45 AM, Felipe

Re: [PATCH RFC v5] s5k5baf: add camera sensor driver

2013-08-19 Thread Tomasz Figa
On Monday 19 of August 2013 16:30:45 Stephen Warren wrote: On 08/19/2013 11:25 AM, Sylwester Nawrocki wrote: On 08/19/2013 03:25 PM, Pawel Moll wrote: On Mon, 2013-08-19 at 14:18 +0100, Andrzej Hajda wrote: +++ b/Documentation/devicetree/bindings/media/samsung-s5k5baf.txt @@ -0,0 +1,51 @@

Re: [PATCH v7 13/13] V4L: Add driver for s5k4e5 image sensor

2013-08-21 Thread Tomasz Figa
Hi Hans, On Wednesday 21 of August 2013 08:53:55 Hans Verkuil wrote: On 08/21/2013 08:34 AM, Arun Kumar K wrote: This patch adds subdev driver for Samsung S5K4E5 raw image sensor. Like s5k6a3, it is also another fimc-is firmware controlled sensor. This minimal sensor driver doesn't do any

Re: [PATCH v7] s5k5baf: add camera sensor driver

2013-08-22 Thread Tomasz Figa
Hi Andrzej, Please see some minor comments inline. On Wednesday 21 of August 2013 16:41:31 Andrzej Hajda wrote: Driver for Samsung S5K5BAF UXGA 1/5 2M CMOS Image Sensor with embedded SoC ISP. The driver exposes the sensor as two V4L2 subdevices: - S5K5BAF-CIS - pure CMOS Image Sensor, fixed

Re: [PATCH v3 1/6] media: s5p-tv: Replace mxr_ macro by default dev_

2013-08-29 Thread Tomasz Figa
Hi Mateusz, On Wednesday 28 of August 2013 18:12:59 Mateusz Krawczuk wrote: Replace mxr_dbg, mxr_info and mxr_warn by generic solution. Signed-off-by: Mateusz Krawczuk m.krawc...@partner.samsung.com --- drivers/media/platform/s5p-tv/mixer.h | 12 ---

Re: [PATCH v3 2/6] media: s5p-tv: Restore vpll clock rate

2013-08-29 Thread Tomasz Figa
Hi Mateusz, Generally this patch looks good, but I have some minor nitpicks, that I would like to be fixed. On Wednesday 28 of August 2013 18:13:00 Mateusz Krawczuk wrote: Restore vpll clock rate if start stream fail or stream is off. Signed-off-by: Mateusz Krawczuk

Re: [PATCH v3 3/6] media: s5p-tv: Fix sdo driver to work with CCF

2013-08-29 Thread Tomasz Figa
Hi Mateusz, On Wednesday 28 of August 2013 18:13:01 Mateusz Krawczuk wrote: Replace clk_enable by clock_enable_prepare and clk_disable with clk_disable_unprepare. Clock prepare is required by Clock Common Framework, and old clock driver didn`t support it. Without it Common Clock Framework

Re: [PATCH v3 4/6] media: s5p-tv: Fix mixer driver to work with CCF

2013-08-29 Thread Tomasz Figa
On Wednesday 28 of August 2013 18:13:02 Mateusz Krawczuk wrote: Replace clk_enable by clock_enable_prepare and clk_disable with clk_disable_unprepare. Clock prepare is required by Clock Common Framework, and old clock driver didn`t support it. Without it Common Clock Framework prints a

Re: [PATCH v3 5/6] clk: samsung: Add clock driver for s5pc110/s5pv210

2013-08-29 Thread Tomasz Figa
Hi Mateusz, On Wednesday 28 of August 2013 18:13:03 Mateusz Krawczuk wrote: This patch adds new, Common Clock Framework-based clock driver for Samsung S5PV210 SoCs. The driver is just added, without enabling it yet. Signed-off-by: Mateusz Krawczuk m.krawc...@partner.samsung.com ---

Re: [PATCH v3 6/6] ARM: s5pv210: Migrate clock handling to Common Clock Framework

2013-08-29 Thread Tomasz Figa
Hi Mateusz, On Wednesday 28 of August 2013 18:13:04 Mateusz Krawczuk wrote: This patch migrates the s5pv210 platform to use new clock driver using Common Clock Framework. Signed-off-by: Mateusz Krawczuk m.krawc...@partner.samsung.com --- arch/arm/mach-s5pv210/Kconfig | 9

Re: [PATCH 01/11] dt: binding: add binding for ImgTec IR block

2013-12-22 Thread Tomasz Figa
Hi James, On Friday 13 of December 2013 15:12:49 James Hogan wrote: Add device tree binding for ImgTec Consumer Infrared block. Signed-off-by: James Hogan james.ho...@imgtec.com Cc: Mauro Carvalho Chehab m.che...@samsung.com Cc: linux-media@vger.kernel.org Cc: Rob Herring

Re: [PATCH v5 4/4] [media] exynos-scaler: Add DT bindings for SCALER driver

2014-01-24 Thread Tomasz Figa
Hi Shaik, On 09.01.2014 04:28, Shaik Ameer Basha wrote: This patch adds the DT binding documentation for the Exynos5420/5410 based SCALER device driver. Signed-off-by: Shaik Ameer Basha shaik.am...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com ---

Re: [PATCH v4 03/10] Documentation: devicetree: Update Samsung FIMC DT binding

2014-02-22 Thread Tomasz Figa
[Ccing Mike] On 22.02.2014 23:02, Sylwester Nawrocki wrote: On 02/21/2014 04:50 PM, Mark Rutland wrote: On Thu, Feb 20, 2014 at 07:40:30PM +, Sylwester Nawrocki wrote: +- #clock-cells: from the common clock bindings (../clock/clock-bindings.txt), + must be 1. A clock provider is

Re: [PATCH v6 1/4] [media] exynos-scaler: Add DT bindings for SCALER driver

2014-03-19 Thread Tomasz Figa
documentation, it should be fine. So, from me it's a Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCHv2 1/3] phy: Add exynos-simple-phy driver

2014-05-07 Thread Tomasz Figa
[CCing more DT-folks :)] On 07.05.2014 16:19, Rahul Sharma wrote: On 7 May 2014 19:06, Tomasz Stanislawski t.stanisl...@samsung.com wrote: On 05/07/2014 12:38 PM, Rahul Sharma wrote: On 5 May 2014 15:14, Kishon Vijay Abraham I kis...@ti.com wrote: Hi, On Wednesday 09 April 2014 03:31 PM,

Re: [PATCH 1/3] [media] s5p-mfc: Add variants to access mfc registers

2014-05-08 Thread Tomasz Figa
Hi Arun, PaweĊ‚, On 09.05.2014 06:49, Arun Kumar K wrote: Hi Kamil, On 05/09/14 06:30, Pawel Osciak wrote: Hi Kamil, On Fri, May 9, 2014 at 1:31 AM, Kamil Debski k.deb...@samsung.com wrote: Hi Arun, I think that this driver is getting too complicated now. First there are separate files

Re: [PATCH 0/3] Support for multiple MFC FW sub-versions

2014-05-20 Thread Tomasz Figa
series looks good. Reviewed-by: Tomasz Figa t.f...@samsung.com Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-media in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [media] Remove references to non-existent PLAT_S5P symbol

2014-10-06 Thread Tomasz Figa
On 06.10.2014 17:39, Sylwester Nawrocki wrote: diff --git a/drivers/media/platform/exynos4-is/Kconfig b/drivers/media/platform/exynos4-is/Kconfig index 77c9512..b3b270a 100644 --- a/drivers/media/platform/exynos4-is/Kconfig +++ b/drivers/media/platform/exynos4-is/Kconfig @@ -2,7 +2,7 @@

Re: [PATCH v6 1/3] iommu: Implement common IOMMU ops for DMA mapping

2015-11-02 Thread Tomasz Figa
On Mon, Nov 2, 2015 at 10:11 PM, Daniel Kurtz wrote: > > +Tomasz, so he can reply to the thread > +Marek and Russell as recommended by Tomasz > > On Oct 30, 2015 22:27, "Robin Murphy" wrote: > > > > Hi Dan, > > > > On 30/10/15 01:17, Daniel Kurtz

Re: [PATCH v6 1/3] iommu: Implement common IOMMU ops for DMA mapping

2015-11-03 Thread Tomasz Figa
On Wed, Nov 4, 2015 at 2:41 AM, Robin Murphy <robin.mur...@arm.com> wrote: > Hi Tomasz, > > On 02/11/15 13:43, Tomasz Figa wrote: >> >> I'd like to know what is the boundary mask and what hardware imposes >> requirements like this. The cost here is not only over-a

Re: [PATCH v6 1/3] iommu: Implement common IOMMU ops for DMA mapping

2015-11-03 Thread Tomasz Figa
On Wed, Nov 4, 2015 at 3:40 AM, Russell King - ARM Linux <li...@arm.linux.org.uk> wrote: > On Tue, Nov 03, 2015 at 05:41:24PM +, Robin Murphy wrote: >> Hi Tomasz, >> >> On 02/11/15 13:43, Tomasz Figa wrote: >> >Agreed. The dma_map_*() API is not guarante

Re: [PATCH v6 1/3] iommu: Implement common IOMMU ops for DMA mapping

2015-11-04 Thread Tomasz Figa
On Wed, Nov 4, 2015 at 6:27 PM, Russell King - ARM Linux <li...@arm.linux.org.uk> wrote: > On Wed, Nov 04, 2015 at 02:12:03PM +0900, Tomasz Figa wrote: >> My understanding of a scatterlist was that it represents a buffer as a >> whole, by joining together its physically d

[PATCH] media: vb2: Allow reqbufs(0) with "in use" MMAP buffers

2015-10-15 Thread Tomasz Figa
even though old buffers might be still in processing. Signed-off-by: John Sheu <s...@chromium.org> Reviewed-by: Pawel Osciak <posc...@chromium.org> Reviewed-by: Tomasz Figa <tf...@chromium.org> Signed-off-by: Tomasz Figa <tf...@chromium.org> --- drive

Re: Questions about userspace, request and frame API in your Rockchip VPU driver

2016-07-26 Thread Tomasz Figa
Hi Florent, Let's keep more people in the loop. CCing Pawel, Hans, Laurent and linux-media ML, as there might be more people interested in the status and/or helping. On Tue, Jul 26, 2016 at 4:50 PM, Florent Revest wrote: > Hi Tomasz, > > I'm currently an

Re: [RFC 0/2] Add V4L2_BUF_TYPE_META_OUTPUT buffer type

2017-08-03 Thread Tomasz Figa
Hi Sakari, On Sat, Jun 17, 2017 at 12:14 AM, Sakari Ailus wrote: > The V4L2_BUF_TYPE_META_OUTPUT buffer type complements the metadata buffer > types support for OUTPUT buffers, capture being already supported. This is > intended for similar cases than

Re: [GIT PULL] linux-firmware: intel: Add Kabylake IPU3 firmware

2017-08-15 Thread Tomasz Figa
Hi everyone, On Sat, Aug 5, 2017 at 9:04 AM, Mani, Rajmohan wrote: > Hi, > > Please review this PULL request to add Kabylake IPU3 firmware to the > linux-firmware repository. > > > The following changes since commit 7d2c913dcd1be083350d97a8cb1eba24cfacbc8a: > >

Re: [PATCH v2] media: ov5670: Fix incorrect frame timing reported to user

2017-08-10 Thread Tomasz Figa
value. And, add more comments to it. > drivers/media/i2c/ov5670.c | 45 +++-- > 1 file changed, 23 insertions(+), 22 deletions(-) Okay, the numbers in this version finally make sense. Thanks for figuring this out. Reviewed-by: Tomasz Figa <tf...@chromium.org> Best regards, Tomasz

Re: [PATCH v4 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver

2017-07-12 Thread Tomasz Figa
Hi Yong, On Thu, Jul 13, 2017 at 8:20 AM, Zhi, Yong wrote: > Hi, Sakari, > > Thanks for the time spent on code review, acks to all the comments, except > two places: > >> +/* .complete() is called after all subdevices have been located */ >> +static int

Re: [PATCH v4 3/3] intel-ipu3: cio2: Add new MIPI-CSI2 driver

2017-07-13 Thread Tomasz Figa
On Thu, Jul 13, 2017 at 5:21 PM, Sakari Ailus wrote: >> >> + ret = v4l2_async_notifier_register(>v4l2_dev, >> >> >notifier); >> >> + if (ret) { >> >> + cio2->notifier.num_subdevs = 0; >> > >> > No need to assign num_subdevs as 0. >> > >> > [YZ]

Re: [PATCH v3 02/12] intel-ipu3: mmu: implement driver

2017-07-26 Thread Tomasz Figa
Hi Robin, On Wed, Jul 19, 2017 at 10:37 PM, Robin Murphy <robin.mur...@arm.com> wrote: > On 19/07/17 04:12, Yong Zhi wrote: >> From: Tomasz Figa <tf...@chromium.org> >> >> This driver translates Intel IPU3 internal virtual >> address to physical addres

Re: [PATCH v3 03/12] intel-ipu3: Add DMA API implementation

2017-07-26 Thread Tomasz Figa
On Fri, Jul 21, 2017 at 7:09 AM, Sakari Ailus <sakari.ai...@iki.fi> wrote: > Hi Arnd, > > On Wed, Jul 19, 2017 at 09:24:41AM +0200, Arnd Bergmann wrote: >> On Wed, Jul 19, 2017 at 5:12 AM, Yong Zhi <yong@intel.com> wrote: >> > From: Tomasz Figa <tf...@

Re: [PATCH 01/12] [media] vb2: add explicit fence user API

2017-07-03 Thread Tomasz Figa
Hi Gustavo, On Tue, Jun 27, 2017 at 12:39 AM, Gustavo Padovan wrote: > 2017-06-18 kbuild test robot : > >> Hi Gustavo, >> >> [auto build test ERROR on linuxtv-media/master] >> [also build test ERROR on v4.12-rc5 next-20170616] >> [if your patch is applied to

Re: [RFC PATCH 1/5] base: dma-mapping: Export commonly used symbols

2017-07-06 Thread Tomasz Figa
On Thu, Jul 6, 2017 at 5:26 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Thu, Jul 6, 2017 at 3:44 AM, Tomasz Figa <tf...@chromium.org> wrote: >> On Thu, Jul 6, 2017 at 2:20 AM, Christoph Hellwig <h...@lst.de> wrote: >>> On Thu, Jul 06, 2017 at 12:22:35AM +0900,

Re: [RFC PATCH 1/5] base: dma-mapping: Export commonly used symbols

2017-07-06 Thread Tomasz Figa
On Thu, Jul 6, 2017 at 5:34 PM, Tomasz Figa <tf...@chromium.org> wrote: > On Thu, Jul 6, 2017 at 5:26 PM, Arnd Bergmann <a...@arndb.de> wrote: >> On Thu, Jul 6, 2017 at 3:44 AM, Tomasz Figa <tf...@chromium.org> wrote: >>> On Thu, Jul 6, 2017 at 2:20 AM, C

Re: [RFC PATCH 1/5] base: dma-mapping: Export commonly used symbols

2017-07-06 Thread Tomasz Figa
On Thu, Jul 6, 2017 at 10:31 PM, Tomasz Figa <tf...@chromium.org> wrote: > On Thu, Jul 6, 2017 at 9:23 PM, Arnd Bergmann <a...@arndb.de> wrote: >> On Thu, Jul 6, 2017 at 10:36 AM, Tomasz Figa <tf...@chromium.org> wrote: >>> On Thu, Jul 6, 2017 at 5:34 PM, To

Re: [RFC PATCH 1/5] base: dma-mapping: Export commonly used symbols

2017-07-06 Thread Tomasz Figa
On Thu, Jul 6, 2017 at 11:02 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Thu, Jul 6, 2017 at 3:49 PM, Tomasz Figa <tf...@chromium.org> wrote: >> On Thu, Jul 6, 2017 at 10:31 PM, Tomasz Figa <tf...@chromium.org> wrote: > >>> On the other hand, if it's st

Re: [RFC PATCH 1/5] base: dma-mapping: Export commonly used symbols

2017-07-06 Thread Tomasz Figa
On Thu, Jul 6, 2017 at 9:23 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Thu, Jul 6, 2017 at 10:36 AM, Tomasz Figa <tf...@chromium.org> wrote: >> On Thu, Jul 6, 2017 at 5:34 PM, Tomasz Figa <tf...@chromium.org> wrote: >>> On Thu, Jul 6, 2017 at 5:26 PM,

Re: [RFC PATCH 1/5] base: dma-mapping: Export commonly used symbols

2017-07-06 Thread Tomasz Figa
On Thu, Jul 6, 2017 at 11:27 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Thu, Jul 6, 2017 at 4:06 PM, Tomasz Figa <tf...@chromium.org> wrote: >> On Thu, Jul 6, 2017 at 11:02 PM, Arnd Bergmann <a...@arndb.de> wrote: >>> On Thu, Jul 6, 2017 at 3:49 PM, To

Re: [PATCH v2 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

2017-06-28 Thread Tomasz Figa
On Wed, Jun 28, 2017 at 10:31 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote: > On Tue, Jun 27, 2017 at 06:33:13PM +0900, Tomasz Figa wrote: >> On Mon, Jun 26, 2017 at 11:51 PM, Sakari Ailus <sakari.ai...@iki.fi> wrote: >> > On Mon, Jun 12, 2017 at 06:59

Re: [PATCH v3 02/12] intel-ipu3: mmu: implement driver

2017-07-28 Thread Tomasz Figa
On Fri, Jul 28, 2017 at 11:10 PM, Robin Murphy <robin.mur...@arm.com> wrote: > On 26/07/17 11:38, Tomasz Figa wrote: >> Hi Robin, >> >> On Wed, Jul 19, 2017 at 10:37 PM, Robin Murphy <robin.mur...@arm.com> wrote: >>> On 19/07/17 04:12, Yong Zhi wrote:

Re: [PATCH v1] media: ov13858: Correct link-frequency and pixel-rate

2017-07-28 Thread Tomasz Figa
Hi Chiranjeevi, On Sat, Jul 29, 2017 at 3:48 AM, Chiranjeevi Rapolu wrote: > Previously both link-frequency and pixel-rate reported by > the sensor was incorrect, resulting in incorrect FPS. > Report link-frequency in Hz rather than link data rate in bps. >

Re: [PATCH 0/2] Add V4L2_BUF_TYPE_META_OUTPUT buffer type

2017-08-21 Thread Tomasz Figa
+ > drivers/media/v4l2-core/v4l2-ioctl.c | 25 ++ > drivers/media/v4l2-core/videobuf2-v4l2.c | 1 + > include/media/v4l2-ioctl.h | 17 > include/uapi/linux/videodev2.h | 2 ++ > 9 files changed, 75 insertions(+), 13 deletions(-) For the whole series: Reviewed-by: Tomasz Figa <tf...@chromium.org> Best regards, Tomasz

Re: [RFC v4 10/18] vb2: dma-contig: Fix DMA attribute and cache management

2017-05-10 Thread Tomasz Figa
Hi Sakari, Some comments inline. On Mon, May 8, 2017 at 11:03 PM, Sakari Ailus wrote: > Patch ccc66e73 ("ARM: 8508/2: videobuf2-dc: Let drivers specify DMA > attrs") added support for driver specific DMA attributes to > videobuf2-dma-contig but it had several

  1   2   3   4   >