Re: Fw: [PATCH] cx88: Missing failure checks

2009-03-26 Thread Trent Piepho
On Thu, 26 Mar 2009, Mauro Carvalho Chehab wrote: From: Alan Cox a...@lxorguk.ukuu.org.uk To: linux-ker...@vger.kernel.org, mche...@infradead.org Subject: [PATCH] cx88: Missing failure checks The ioremap one was reported in October 2007 (Bug 9146), the kmalloc one was blindingly obvious

Re: [PATCH] v4l2: fill reserved fields of VIDIOC_ENUMAUDIO also

2009-03-27 Thread Trent Piepho
On Fri, 27 Mar 2009, Mauro Carvalho Chehab wrote: On Wed, 25 Mar 2009 17:51:39 +0100 N?meth M?rton nm...@freemail.hu wrote: From: M?rton N?meth nm...@freemail.hu When enumerating audio inputs with VIDIOC_ENUMAUDIO the gspca_sunplus driver does not fill the reserved fields of the struct

Re: [PATCH] v4l2: fill reserved fields of VIDIOC_ENUMAUDIO also

2009-03-27 Thread Trent Piepho
On Fri, 27 Mar 2009, Hans Verkuil wrote: On Friday 27 March 2009 20:45:40 Trent Piepho wrote: On Fri, 27 Mar 2009, Mauro Carvalho Chehab wrote: On Wed, 25 Mar 2009 17:51:39 +0100 N?meth M?rton nm...@freemail.hu wrote: From: M?rton N?meth nm...@freemail.hu When enumerating

[pull] http://linuxtv.org/hg/~tap/v4l-dvb

2009-03-28 Thread Trent Piepho
Mauro, Please pull from http://linuxtv.org/hg/~tap/v4l-dvb for the following 14 changesets: 01/14: build: Fix kernel output directory support http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=346bab8698ea 02/14: v4l2-ioctl: Check format for S_PARM and G_PARM

Re: [linuxtv-commits] [hg:v4l-dvb] v4l2-ioctl: Check format for S_PARM and G_PARM

2009-03-29 Thread Trent Piepho
On Sun, 29 Mar 2009, Hans Verkuil wrote: On Sunday 29 March 2009 12:21:58 Trent Piepho wrote: On Sun, 29 Mar 2009, Hans Verkuil wrote: On Sunday 29 March 2009 10:50:02 Patch from Trent Piepho wrote: From: Trent Piepho xy...@speakeasy.org v4l2-ioctl: Check format for S_PARM

Re: [linuxtv-commits] [hg:v4l-dvb] v4l2-ioctl: Check format for S_PARM and G_PARM

2009-03-30 Thread Trent Piepho
On Sun, 29 Mar 2009, Hans Verkuil wrote: On Sunday 29 March 2009 13:03:13 Trent Piepho wrote: How does overlay depend on video capture in any way? It's perfectly reasonable for a driver to support _only_ overlay and not video capture. The zr36067 chip is only designed to support

Re: Problems with Hauppauge HVR 1600 and cx18 driver

2009-03-30 Thread Trent Piepho
On Sun, 29 Mar 2009, Andy Walls wrote: On Sun, 2009-03-29 at 01:24 -0700, Trent Piepho wrote: wait_event() should take care of this. wait_event(q, test) basically does: for(;;) { // point A add_me_to_waitqueue(q); set_current_state(TASK_UNINTERRUPTIBLE); if (test

Re: [PATCH 3/4] ARM: DaVinci: DM646x Video: Add VPIF display driver

2009-03-30 Thread Trent Piepho
On Mon, 30 Mar 2009, Hans Verkuil wrote: On Thursday 26 March 2009 14:22:32 Chaithrika U S wrote: + /* one field is displayed configure the next + frame if it is available else hold on current + frame */

Re: When is a wake_up() not a wake up?

2009-04-04 Thread Trent Piepho
On Fri, 3 Apr 2009, Andy Walls wrote: 1. A work queue thread or read() call needs to send a command to the CX23418 using the cx18_api_call() function 2. It fills out a mailbox with a command for the CX23418 3. It prepares to wait, just in case a wait is needed 4. A SW1 interrupt is sent to

Re: [PATCH] [0904_16] Siano: smsdvb - additional case of endian handling.

2009-04-05 Thread Trent Piepho
On Sun, 5 Apr 2009, Uri Shkolnik wrote: PidMsg.xMsgHeader.msgLength = sizeof(PidMsg); PidMsg.msgData[0] = feed-pid; - /* smsendian_handle_tx_message((struct SmsMsgHdr_ST *)PidMsg); */ + smsendian_handle_tx_message((struct SmsMsgHdr_ST *)PidMsg); return

Re: [PATCH 3/6] ir-kbd-i2c: Switch to the new-style device binding model

2009-04-05 Thread Trent Piepho
On Sun, 5 Apr 2009, Andy Walls wrote: Here is where LIRC may be its own worst enemy. LIRC has filled some shortcomings in the kernel for support of IR device functions for so long (LWN says LIRC is 10 years old), that large numbers of users have come to depend on its operation, while at the

Re: [PATCH 3/6] ir-kbd-i2c: Switch to the new-style device binding model

2009-04-05 Thread Trent Piepho
On Sun, 5 Apr 2009, Mike Isely wrote: 1. The switch statement in ir-kbd-i2c.c:ir_attach() is apparently implicitly trying to assume a particular type of remote based on the I2C address of the IR receiver it's talking to. Yuck. That's really not right at all. The IR receiver used does not

Re: patch: s2255drv high quality mode and video status querying

2009-04-07 Thread Trent Piepho
On Tue, 7 Apr 2009, Dean A. wrote: +static int vidioc_g_parm(struct file *file, void *priv, + struct v4l2_streamparm *sp) +{ + struct s2255_fh *fh = priv; + struct s2255_dev *dev = fh-dev; + if (sp-type != V4L2_BUF_TYPE_VIDEO_CAPTURE) + return

Re: [PATCH] [0904_14] Siano: assemble all components to one kernel module

2009-04-20 Thread Trent Piepho
On Mon, 20 Apr 2009, Uri Shkolnik wrote: better to have the BUS configurable, e. g. just because you have USB interface, it doesn't mean that you want siano for USB, instead of using SDIO. Since the module is using dynamic registration, I don't find it a problem. When the system has both

Re: [PATCH] zoran: invalid test on unsigned

2009-04-26 Thread Trent Piepho
this in it. Patch is fine. Acked-by: Trent Piepho xy...@speakeasy.org diff --git a/drivers/media/video/zoran/zoran_driver.c b/drivers/media/video/zoran/zoran_driver.c index 092333b..0db5d0f 100644 --- a/drivers/media/video/zoran/zoran_driver.c +++ b/drivers/media/video/zoran/zoran_driver.c @@ -1871,7

Re: [Mjpeg-users] [PATCH] zoran: invalid test on unsigned

2009-04-27 Thread Trent Piepho
. It's simpler this way too. The unnecessary check for (unsigned)fmt-index 0 found by Roel Kluin roel.kl...@gmail.com is removed this way too. Signed-off-by: Trent Piepho xy...@speakeasy.org diff -r 63eba6df4b8a -r c247021eb11c linux/drivers/media/video/zoran/zoran_driver.c --- a/linux/drivers

Re: [PATCH] [0904_14] Siano: assemble all components to one kernel module

2009-04-28 Thread Trent Piepho
On Mon, 27 Apr 2009, Uri Shkolnik wrote: --- On Tue, 4/21/09, Mauro Carvalho Chehab mche...@infradead.org wrote: If the system includes SDIO and OMAP SPI/SPP, the module build will discard the USB interface driver, but the SDIO and the OMAP SPI will be built. The patch you've provided

Re: [PATCH] v4l2: fill the reserved fields of VIDIOC_REQBUFS ioctl

2009-04-30 Thread Trent Piepho
On Wed, 29 Apr 2009, [UTF-8] N??meth M??rton wrote: The parameter of VIDIOC_REQBUFS is a pointer to struct v4l2_requestbuffers. This structure has reserved fields which has to be filled with zeros according to the V4L2 API specification, revision 0.24 [1]. As I read the spec, the reserved

Re: [PATCH] v4l2: fill the reserved fields of VIDIOC_REQBUFS ioctl

2009-04-30 Thread Trent Piepho
On Thu, 30 Apr 2009, Trent Piepho wrote: On Wed, 29 Apr 2009, [UTF-8] N??meth M??rton wrote: The parameter of VIDIOC_REQBUFS is a pointer to struct v4l2_requestbuffers. This structure has reserved fields which has to be filled with zeros according to the V4L2 API specification, revision

[pull] http://linuxtv.org/hg/~tap/v4l-dvb

2009-04-30 Thread Trent Piepho
Mauro, Please pull from http://linuxtv.org/hg/~tap/v4l-dvb for the following 4 changesets: 01/04: compat: Add DMA_BIT_MASK() macro http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=486add0e3f1f 02/04: zoran: fix bug when enumerating format -1

Re: [patch 4/4] zoran: fix /|| error

2009-05-12 Thread Trent Piepho
On Tue, 12 May 2009, Mauro Carvalho Chehab wrote: Em Tue, 12 May 2009 17:18:20 -0400 Devin Heitmueller dheitmuel...@kernellabs.com escreveu: On Tue, May 12, 2009 at 4:39 PM, a...@linux-foundation.org wrote: From: Roel Kluin roel.kl...@gmail.com Fix /|| typo. `default_norm' can be 0

Re: [PULL] http://endr...@linuxtv.org/hg/~endriss/v4l-dvb

2009-05-13 Thread Trent Piepho
On Wed, 13 May 2009, Oliver Endriss wrote: 02/05: dvb-ttpci: Check transport error indicator flag http://endr...@linuxtv.org/hg/~endriss/v4l-dvb?cmd=changeset;node=8a742338523d Are you sure this is a good idea? The cx88 driver doesn't do this. -- To unsubscribe from this list: send the line

Re: Sound capture with Osprey 230

2009-05-14 Thread Trent Piepho
On Mon, 11 May 2009, Sverker Abrahamsson wrote: Hi all, I've been using Osprey 230 cards for AV capture for several years, earlier with a modified version of Viewcast's driver but it was never very stable. When doing a new setup I therefore wanted to get the Alsa driver to work. I found that

Re: [PATCH 1/5 - part 2] V4L2 patches for Intel Moorestown Camera Imaging Drivers

2009-05-23 Thread Trent Piepho
On Sat, 23 May 2009, Mauro Carvalho Chehab wrote: + + if (intel-open) { + ++intel-open; + DBG_DD((device has opened already - %d\n, intel-open)); + return 0; + } + + file-private_data = dev; + /* increment our usage count for the driver */ + ++intel-open; + DBG_DD((intel_open is %d\n,

Re: PULL request - http://linuxtv.org/hg/~pb/v4l-dvb/

2009-05-25 Thread Trent Piepho
On Mon, 25 May 2009, Mauro Carvalho Chehab wrote: + if (params-frequency = 4800 params-frequency = 15400) \ + bs = 0x09; + if (params-frequency = 16100 params-frequency = 43900) \ + bs = 0x0a; + if (params-frequency =

Re: [RFC,PATCH] VIDIOC_G_EXT_CTRLS does not handle NULL pointer correctly

2009-05-25 Thread Trent Piepho
On Mon, 25 May 2009, Laurent Pinchart wrote: diff -r e0d881b21bc9 linux/drivers/media/video/v4l2-ioctl.c --- a/linux/drivers/media/video/v4l2-ioctl.c Tue May 19 15:12:17 2009 +0200 +++ b/linux/drivers/media/video/v4l2-ioctl.c Sun May 24 18:26:29 2009 +0200 @@ -402,6 +402,10 @@

Re: PULL request - http://linuxtv.org/hg/~pb/v4l-dvb/

2009-05-27 Thread Trent Piepho
, but the latter could easily be done by adding a break to the end of the Clean up partially attached frontend code block. # HG changeset patch # User Trent Piepho xy...@speakeasy.org # Date 1243476805 25200 # Node ID 27aa25fe54ae2fd9a166bfdb3cec4c4ecadc9cba # Parent

[PULL] generic image bounds setting and alignment function

2009-05-30 Thread Trent Piepho
Mauro, Please pull from http://linuxtv.org/hg/~tap/v4l-dvb This series adds a function for bounding and alignment image sizes and modifies a number of drivers to use it. It came up when the pxa patches to deal with the alignment issues for that driver were posted. I haven't tested these

Re: [PATCH] Leadtek WinFast DTV-1800H support

2009-05-31 Thread Trent Piepho
On Sun, 31 May 2009, Miroslav [UTF-8] ??ustek wrote: Trent Piepho xyzzy at speakeasy.org writes: Instead of raising the reset line here, why not change the gpio settings in the card definition to have it high? Change gpio1 for television to 0x7050 and radio to 0x7010. Personally, I

Re: [PATCH] bttv-driver.c :poll method lose race condition for capture video

2009-05-31 Thread Trent Piepho
On Sun, 31 May 2009, Figo.zhang wrote: bttv-driver.c,cx23885-video.c,cx88-video.c: poll method lose race condition for capture video. Please use patch titles that are not so long. It would be nice if you could describe this race condition. Signed-off-by: Figo.zhang figo1...@gmail.com ---

Re: webcam drivers and V4L2_MEMORY_USERPTR support

2009-06-01 Thread Trent Piepho
On Mon, 1 Jun 2009, Stefan Kost wrote: I have implemented support for V4L2_MEMORY_USERPTR buffers in gstreamers v4l2src [1]. This allows to request shared memory buffers from xvideo, capture into those and therefore save a memcpy. This works great with the v4l2 driver on our embedded device.

Re: [PULL] generic image bounds setting and alignment function

2009-06-03 Thread Trent Piepho
On Mon, 1 Jun 2009, Robert Jarzmik wrote: Trent Piepho xy...@speakeasy.org writes: Please pull from http://linuxtv.org/hg/~tap/v4l-dvb This series adds a function for bounding and alignment image sizes and modifies a number of drivers to use it. It came up when the pxa patches to deal

Re: [PATCHv5 1 of 8] v4l2_subdev i2c: Add v4l2_i2c_new_subdev_board i2c helper function

2009-06-06 Thread Trent Piepho
On Sat, 6 Jun 2009, Hans Verkuil wrote: On Saturday 06 June 2009 13:59:19 Hans Verkuil wrote: I propose to change the API as follows: #define V4L2_I2C_ADDRS(addr, addrs...) \ ((const unsigned short []){ addr, ## addrs, I2C_CLIENT_END }) struct v4l2_subdev

Re: RFC: proposal for new i2c.h macro to initialize i2c address lists on the fly

2009-06-06 Thread Trent Piepho
On Sat, 6 Jun 2009, Hans Verkuil wrote: For video4linux we sometimes need to probe for a single i2c address. Normally you would do it like this: static const unsigned short addrs[] = { addr, I2C_CLIENT_END }; client = i2c_new_probed_device(adapter, info, addrs); This is a bit

Re: [PATCH] bt8xx: Add support for the Conexant Fusion 878a / Twinhan VP 1025 DVB-S

2009-06-07 Thread Trent Piepho
On Sun, 7 Jun 2009, Michael Stapelberg wrote: Add fefe:0001 to the list of identifiers for the bt8xx driver. The chip is named Conexant Fusion 878a, the card is a Twinhan VP 1025 DVB-S PCI. Please commit the attached patch. You can remove Conexant Fusion from the board name. All the boards

Re: [PULL] http://linuxtv.org/hg/~pinchartl/uvcvideo/

2009-06-09 Thread Trent Piepho
On Tue, 9 Jun 2009, Mauro Carvalho Chehab wrote: Em Tue, 9 Jun 2009 18:08:38 +0200 Hans Verkuil hverk...@xs4all.nl escreveu: Should I submit a patch that implement VIDIOC_S_JPEGCOMP support in the UVC driver and implement a JPEG compression quality control later, or would you

Re: S_FMT vs. S_CROP

2009-06-10 Thread Trent Piepho
On Wed, 10 Jun 2009, Hans Verkuil wrote: On Wednesday 10 June 2009 18:02:39 Guennadi Liakhovetski wrote: This question - how S_FMT and S_CROP affest image geometry - has been discussed at least twice before - that's only with my participation, don't know if and how often it has come up

Re: PULL request - http://linuxtv.org/hg/~pb/v4l-dvb/

2009-06-11 Thread Trent Piepho
On Thu, 11 Jun 2009, Patrick Boettcher wrote: On Wed, 27 May 2009, Trent Piepho wrote: On Tue, 26 May 2009, Patrick Boettcher wrote: Does this patch to fix these problems look ok? In fact, everything looks correct in my eyes. I'll ask Mauro to pull any minute from now. I even have

Re: [PATCH -next] v4l: expose function outside of ifdef/endif block

2009-06-12 Thread Trent Piepho
+987,3 @@ void v4l_bound_align_image(u32 *w, unsig } } EXPORT_SYMBOL_GPL(v4l_bound_align_image); - -#endif# HG changeset patch # User Trent Piepho xy...@speakeasy.org # Date 1244834958 25200 # Node ID 23bd6516eafcc06ffb590073e744c7e17382aef9 # Parent

Re: [PATCHv7 2/9] v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls

2009-06-14 Thread Trent Piepho
On Sun, 14 Jun 2009, Eduardo Valentin wrote: +/* FM Modulator class control IDs */ +#define V4L2_CID_FM_TX_CLASS_BASE (V4L2_CTRL_CLASS_FM_TX | 0x900) +#define V4L2_CID_FM_TX_CLASS ? ? ? ? ? ? ? ? (V4L2_CTRL_CLASS_FM_TX | 1) + +#define V4L2_CID_RDS_ENABLED ? ? ? ? ? ? ? ?

Re: [PATCHv7 2/9] v4l2: video device: Add V4L2_CTRL_CLASS_FM_TX controls

2009-06-16 Thread Trent Piepho
On Tue, 16 Jun 2009, Eduardo Valentin wrote: On Sun, Jun 14, 2009 at 06:59:13PM +0200, ext Hans Verkuil wrote: On Sunday 14 June 2009 18:23:41 Trent Piepho wrote: similar V4L2_CID_MPEG_EMPHASIS control and others might well appear in the future, so I think this name should

Re: [PULL] http://kernellabs.com/hg/~mkrufky/k2c2

2009-06-16 Thread Trent Piepho
On Tue, 16 Jun 2009, Mauro Carvalho Chehab wrote: Em Tue, 16 Jun 2009 11:19:29 -0400 Michael Krufky mkru...@linuxtv.org escreveu: +static int cx23885_dvb_set_frontend(struct dvb_frontend *fe, + struct dvb_frontend_parameters *param) You could make this an

Re: [PULL] generic image bounds setting and alignment function

2009-06-16 Thread Trent Piepho
On Tue, 16 Jun 2009, Mauro Carvalho Chehab wrote: Em Tue, 16 Jun 2009 17:57:20 +0200 (CEST) Guennadi Liakhovetski g.liakhovet...@gmx.de escreveu: On Sat, 30 May 2009, Trent Piepho wrote: + if (walign + halign salign) { + /* Max walign where there is still a valid width

Re: [PATCH] High resolution timer for cx88 remotes

2009-06-16 Thread Trent Piepho
On Tue, 16 Jun 2009, Mauro Carvalho Chehab wrote: Em Sat, 23 May 2009 14:06:01 +0200 AH andrzej.ha...@wp.pl escreveu: Patched driver seems to work on my system, with kernel 2.6.28. I have removed kernel checks for versions below 2.6.20 - they were because of API changes in scheduler. If

Re: [PATCH] adding support for setting bus parameters in sub device

2009-06-17 Thread Trent Piepho
On Wed, 17 Jun 2009, Guennadi Liakhovetski wrote: On Wed, 17 Jun 2009, Hans Verkuil wrote: It is my strong opinion that while autonegotiation is easy to use, it is not a wise choice to make. Filling in a single struct with the bus settings to use for each board-subdev combination (usually

Re: [PULL] generic image bounds setting and alignment function

2009-06-17 Thread Trent Piepho
On Wed, 17 Jun 2009, Guennadi Liakhovetski wrote: On Tue, 16 Jun 2009, Trent Piepho wrote: /* up the smaller alignment until we have enough */ do { - if (walign = halign walign wmaxa) { + if (halign = hmaxa

Re: bttv problem loading takes about several minutes

2009-06-17 Thread Trent Piepho
On Wed, 17 Jun 2009, Halim Sahin wrote: Hi, In the past I could use this card by typing modprobe bttv card=34 tuner=24 gbuffers=16 What card do you actually have? What is the PCI subsystem vendor/device and what tuner does it actually have? Hans, the problem might be with bttv audio probing.

Re: [PULL] generic image bounds setting and alignment function

2009-06-17 Thread Trent Piepho
On Wed, 17 Jun 2009, Guennadi Liakhovetski wrote: On Tue, 16 Jun 2009, Trent Piepho wrote: On Tue, 16 Jun 2009, Guennadi Liakhovetski wrote: 01/14: compat: handle __fls http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=c4b55ce6c273 02/14: v4l2: Create helper function

Re: [PATCH] af9015: avoid magically sized temporal buffer in eeprom_dump

2009-06-18 Thread Trent Piepho
On Thu, 18 Jun 2009, Jan Nikitenko wrote: Replace printing to magically sized temporal buffer with use of KERN_CONT temporary not temporal. - sprintf(buf2, %02x , val); + deb_info(KERN_CONT, %02x, val); No comma after KERN_CONT else -

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-misc

2009-06-20 Thread Trent Piepho
On Sat, 20 Jun 2009, Hans Verkuil wrote: - compat: fix __fls check for the arm architecture. This one isn't quite right. The __fls defined for arm in 2.6.27 (between v2.6.26-7260-g0c65f45 and v2.6.28-rc6-187-g94fc733) isn't the same as the __fls() used everwhere else in the kernel. This

Re: IR raw input is not sutable for input system

2009-11-24 Thread Trent Piepho
On Wed, 25 Nov 2009, Maxim Levitsky wrote: Its not the case. There are many protocols, I know that by experimenting with my universal remote. There are many receivers, and all have different accuracy. Most remotes aren't designed to be used with PC, thus user has to invent mapping between

Re: [RFC] Should we create a raw input interface for IR's ? - Was: Re: [PATCH 1/3 v2] lirc core device driver infrastructure

2009-11-26 Thread Trent Piepho
On Thu, 26 Nov 2009, Mauro Carvalho Chehab wrote: See above. Also, several protocols have a way to check if a keystroke were properly received. When handling just one protocol, we can use this to double check the key. However, on a multiprotocol mode, we'll need to disable this feature.

Re: [RFC] Should we create a raw input interface for IR's ? - Was: Re: [PATCH 1/3 v2] lirc core device driver infrastructure

2009-11-26 Thread Trent Piepho
On Thu, 26 Nov 2009, Mauro Carvalho Chehab wrote: lircd supports input layer interface. Yet, patch 3/3 exports both devices that support only pulse/space raw mode and devices that generate scan codes via the raw mode interface. It does it by generating artificial pulse codes. Nonsense!

Re: Replace Mercurial with GIT as SCM

2009-12-01 Thread Trent Piepho
On Tue, 1 Dec 2009, Patrick Boettcher wrote: To start right away: I'm in favour of using GIT because of difficulties I have with my daily work with v4l-dvb. It is in my nature do to mistakes, so I need a tool which assists me in fixing those, I have not found a simple way to do my stuff with

Re: [RFC v2] Another approach to IR

2009-12-02 Thread Trent Piepho
On Wed, 2 Dec 2009, Jarod Wilson wrote: My main point is that each of these devices has device ID that can be determined without having to first do some protocol analysis and table lookups to figure out which device some random IR input is actually coming from. Heh, right back

Re: [RFC v2] Another approach to IR

2009-12-02 Thread Trent Piepho
On Wed, 2 Dec 2009, Jon Smirl wrote: A bluetooth remote has a specific device ID that the receiver has to pair with. Your usb mouse and keyboard each have specific device IDs. A usb IR *receiver* has a specific device ID, the remotes do not. So there's the major difference from your

Re: [v4l-dvb-maintainer] zr36067 no longer loadsautomatically (regression)

2009-01-08 Thread Trent Piepho
On Thu, 8 Jan 2009, Jean Delvare wrote: +#if (defined(CONFIG_USB_ZR364XX_MODULE) defined(MODULE)) Huh? I guess you really mean: CONFIG_VIDEO_ZORAN_MODULE? I don't get the point of checking for both CONFIG_VIDEO_ZORAN_MODULE and MODULE, checking for just one of them should be enough, right?

Re: [PATCH] cx88: fix unexpected video resize when setting tv norm

2009-01-10 Thread Trent Piepho
On Sat, 10 Jan 2009, Marton Balint wrote: Cx88_set_tvnorm sets the size of the video to fixed 320x240. This is ugly at least, but also can cause problems, if it happens during an active video transfer. With this patch, cx88_set_scale will save the last requested video size, and cx88_set_tvnorm

Re: [PATCH] Siano 10226 Siano sub-system

2009-01-13 Thread Trent Piepho
On Tue, 13 Jan 2009, Uri Shkolnik wrote: This patch adds Siano subsystem, which supports the CMMB and T-DMB DTV standards. The patch also adds Network interface (network driver) in order to support the DVB-H and DAB-IP standards. Commit messages should be wrapped to 75 columns. -- To

Re: [PATCH] Siano 10234 big endian support

2009-01-15 Thread Trent Piepho
On Thu, 15 Jan 2009, Uri Shkolnik wrote: + firmware-StartAddress = __le32_to_cpu(firmware-StartAddress); + firmware-Length = __le32_to_cpu(firmware-Length); Any reason you didn't just use le32_to_cpu()? -- To unsubscribe from this list: send the line unsubscribe linux-media in the body

Re: KWorld ATSC 115 all static

2009-01-15 Thread Trent Piepho
On Thu, 15 Jan 2009, Mauro Carvalho Chehab wrote: It has nothing to do with the load order. It is related to i2c binding. With the current approach (before Hans patch), the i2c core will try to bind the tuner after having 2 conditions satisfied: 1) I2C bus were registered; 2)

Re: KWorld ATSC 115 all static

2009-01-16 Thread Trent Piepho
On Fri, 16 Jan 2009, Jean Delvare wrote: Hi Mauro, Trent, On Fri, 16 Jan 2009 00:02:52 -0200, Mauro Carvalho Chehab wrote: On Thu, 15 Jan 2009 10:33:15 -0800 (PST) Trent Piepho xy...@speakeasy.org wrote: On Thu, 15 Jan 2009, Mauro Carvalho Chehab wrote: For now, we should finish

Re: Confusion in usr/include/linux/videodev.h

2009-01-21 Thread Trent Piepho
On Wed, 21 Jan 2009, Jaswinder Singh Rajput wrote: On Wed, Jan 21, 2009 at 7:20 AM, Mauro Carvalho Chehab mche...@infradead.org wrote: On Wed, 21 Jan 2009 07:10:38 +0530 Jaswinder Singh Rajput jaswin...@kernel.org wrote: usr/include/linux/videodev.h is giving 2 warnings in 'make

Re: Confusion in usr/include/linux/videodev.h

2009-01-21 Thread Trent Piepho
On Wed, 21 Jan 2009, Arnd Bergmann wrote: On Wednesday 21 January 2009, Jaswinder Singh Rajput wrote: diff -r 29c5787efcda linux/include/linux/videodev.h --- a/linux/include/linux/videodev.hThu Jan 15 09:07:03 2009 -0800 +++ b/linux/include/linux/videodev.hWed Jan 21 00:51:45

[PATCH] zoran: Update MAINTAINERS entry

2009-01-24 Thread Trent Piepho
Ronald Bultje hasn't been maintaining the zoran driver for some time. Re-direct people to the mailing lists and web pages. Signed-off-by: Trent Piepho xy...@speakeasy.org --- I think it's better to keep what info there is here instead of deleting the entry entirely. Sure you can find

Re: [PATCH] Bttv: move check on unsigned

2009-01-24 Thread Trent Piepho
On Mon, 19 Jan 2009, Trent Piepho wrote: On Sat, 17 Jan 2009, Roel Kluin wrote: Please review, this patch was not tested. The static function set_tvnorm is called in drivers/media/video/bt8xx/bttv-driver.c: 1355: set_tvnorm(btv, norm); 1868: set_tvnorm(btv, i); 3273

Re: [PATCH] New V4L2 ioctls for OMAP class of Devices

2009-01-25 Thread Trent Piepho
On Sun, 25 Jan 2009, Hans Verkuil wrote: I also would like to see the documentation for these ioctls and controls. I hope my www.linuxtv.org/hg/~hverkuil/v4l-dvb-spec tree will be merged soon with the master, but in the meantime you can mail a diff against the documentation in my tree. I will

RE: [PATCH] New V4L2 ioctls for OMAP class of Devices

2009-01-27 Thread Trent Piepho
On Tue, 27 Jan 2009, Shah, Hardik wrote: The rotation values are 0, 90, 180 and 270 degree but to disable rotation the value passed should be -1 and this is one more value. I know 0 degree rotation corresponds to rotation disabled but DSS hardware requires 0 degree rotation to be enabled for

Re: [PATCH] New V4L2 ioctls for OMAP class of Devices

2009-01-27 Thread Trent Piepho
On Tue, 27 Jan 2009, Hans Verkuil wrote: [Shah, Hardik] Hi Hans, I got your above point. Now regarding the enum I am not sure about how to implement it. Are you suggesting me to remove the control ID for rotation and implement in some other way. Please let me know if I am missing

Re: [PATCH] New V4L2 ioctls for OMAP class of Devices

2009-01-27 Thread Trent Piepho
On Tue, 27 Jan 2009, Hans Verkuil wrote: On Tuesday 27 January 2009 19:08:43 Trent Piepho wrote: On Tue, 27 Jan 2009, Hans Verkuil wrote: [Shah, Hardik] Hi Hans, I got your above point. Now regarding the enum I am not sure about how to implement it. Are you suggesting me to remove

Re: [PATCHv2] New V4L2 ioctls for OMAP class of Devices

2009-01-28 Thread Trent Piepho
On Thu, 29 Jan 2009, Hardik Shah wrote: 1. Control ID added for rotation. Same as HFLIP. 2. Control ID added for setting background color on output device. 3. New ioctl added for setting the color space conversion from YUV to RGB. 4. Updated the v4l2-common.c file according to

Re: [PATCH] cx88: fix unexpected video resize when setting tv norm

2009-01-29 Thread Trent Piepho
On Thu, 29 Jan 2009, Marton Balint wrote: The status of this patch has changed to Changes Requested in patchwork, but it's not obvious to me what changes are needed exactly. Yes, in the comments quite a few questions came up, but we haven't decided the correct course of action for good, and

Re: [PATCHv2] New V4L2 ioctls for OMAP class of Devices

2009-01-29 Thread Trent Piepho
On Thu, 29 Jan 2009, Hans Verkuil wrote: On Thursday 29 January 2009 08:44:20 DongSoo Kim wrote: Hello. +#define VIDIOC_S_COLOR_SPACE_CONV _IOW('V', 83, struct v4l2_color_space_conversion) +#define VIDIOC_G_COLOR_SPACE_CONV _IOR('V', 84, struct v4l2_color_space_conversion)

[PULL] bttv driver improvements

2009-01-29 Thread Trent Piepho
Mauro, I haven't been able to test this code. It seems my bt848 card doesn't work with my SATA controller and I sort of need the latter to access the harddrive. But I think everything should work. It cuts the the bttv driver to less than half its current size. A number of the changes are for

Re: [PULL] bttv driver improvements

2009-01-30 Thread Trent Piepho
On Thu, 29 Jan 2009, Devin Heitmueller wrote: On Thu, Jan 29, 2009 at 8:19 PM, Trent Piepho xy...@speakeasy.org wrote: I haven't been able to test this code. It seems my bt848 card doesn't work with my SATA controller and I sort of need the latter to access the harddrive. But I think

Re: [PULL] http://linuxtv.org/hg/~tap/v4l-dvb

2009-02-09 Thread Trent Piepho
On Mon, 9 Feb 2009, Mauro Carvalho Chehab wrote: On Thu, 5 Feb 2009 10:57:21 -0800 (PST) Trent Piepho xy...@speakeasy.org wrote: 01/03: cx88: Fix MPEG kconfig dependencies http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node=2e05fd69e6b6 Hmm... This patch converts a depends

Re: [PULL] http://linuxtv.org/hg/~tap/v4l-dvb

2009-02-09 Thread Trent Piepho
On Tue, 10 Feb 2009, Mauro Carvalho Chehab wrote: On Mon, 9 Feb 2009, Mauro Carvalho Chehab wrote: On Thu, 5 Feb 2009 10:57:21 -0800 (PST) Trent Piepho xy...@speakeasy.org wrote: 01/03: cx88: Fix MPEG kconfig dependencies http://linuxtv.org/hg/~tap/v4l-dvb?cmd=changeset;node

Re: cx8802.ko module not being built with current HG tree

2009-02-10 Thread Trent Piepho
On Tue, 10 Feb 2009, Mauro Carvalho Chehab wrote: I did some more testing and the bug disappears in kernel 2.6.25. Also, if I just run 'make', then the .config file it produces is fine. I wonder if it isn't a bug in menuconfig itself. It seems to be a bug at the Kbuild, fixed on Feb, 2008,

Re: cx8802.ko module not being built with current HG tree

2009-02-13 Thread Trent Piepho
On Wed, 11 Feb 2009, Mauro Carvalho Chehab wrote: On Tue, 10 Feb 2009 17:20:52 -0800 (PST) Trent Piepho xy...@speakeasy.org wrote: I still think using select is better. What Roman Zippel was talking about was the mess with select and the tuner drivers. I agree that's a mess

Re: RFC: Finalizing the V4L2 RDS interface

2009-02-13 Thread Trent Piepho
On Fri, 13 Feb 2009, Hans Verkuil wrote: On Friday 13 February 2009 22:15:45 Mauro Carvalho Chehab wrote: On Fri, 13 Feb 2009 09:55:19 +0100 The V4L API defines its RDS API as follows. From radio devices supporting it, RDS data can be read with the read() function. The data is

Re: [PULL] bttv driver improvements

2009-02-14 Thread Trent Piepho
On Sat, 14 Feb 2009, VDR User wrote: On Fri, Feb 13, 2009 at 5:07 PM, Trent Piepho xy...@speakeasy.org wrote: I tested it on my bttv card. I assume Mauro was able to test it too. Have you found a problem? Didn't you say in your original post that you _haven't_ tested the code because

Re: [PULL] bttv driver improvements

2009-02-14 Thread Trent Piepho
On Sat, 14 Feb 2009, VDR User wrote: On Sat, Feb 14, 2009 at 11:54 AM, Trent Piepho xy...@speakeasy.org wrote: Didn't you say in your original post that you _haven't_ tested the code because of a conflict with your sata driver? It's not safe to I was able to test it later by getting

Re: Adding a control for Sensor Orientation

2009-02-15 Thread Trent Piepho
On Sun, 15 Feb 2009, Hans de Goede wrote: Trent Piepho wrote: On Sun, 15 Feb 2009, Hans de Goede wrote: Hans Verkuil wrote: On Sunday 15 February 2009 10:08:04 Hans de Goede wrote: kilg...@banach.math.auburn.edu wrote: On Sat, 14 Feb 2009, Hans Verkuil wrote: On Saturday 14 February

Re: Adding a control for Sensor Orientation

2009-02-15 Thread Trent Piepho
On Sun, 15 Feb 2009 kilg...@banach.math.auburn.edu wrote: On Sun, 15 Feb 2009, Trent Piepho wrote: On Sun, 15 Feb 2009, Hans de Goede wrote: I think we should also be able to detect 90 and 270 degree rotations. Or at the very least prepare for it. It's a safe bet to assume that webcams

Re: Adding a control for Sensor Orientation

2009-02-15 Thread Trent Piepho
On Sun, 15 Feb 2009, Mauro Carvalho Chehab wrote: On Sun, 15 Feb 2009 10:29:03 +0100 Hans de Goede hdego...@redhat.com wrote: I think we should also be able to detect 90 and 270 degree rotations. Or at the very least prepare for it. It's a safe bet to assume that webcams will arrive

Re: Adding a control for Sensor Orientation

2009-02-16 Thread Trent Piepho
On Mon, 16 Feb 2009, Hans Verkuil wrote: If you want to add two bits with mount information, feel free. But don't abuse them for pivot information. If you want that, then add another two bits for the rotation: Ok, this seems good. But if we want to distinguish between static sensor

Re: [linux-dvb] [BUG] changeset 9029 (http://linuxtv.org/hg/v4l-dvb/rev/aa3e5cc1d833)

2009-02-17 Thread Trent Piepho
On Wed, 18 Feb 2009, Oliver Endriss wrote: [1] If you want to lock a process against an interrupt handler, - the process must use spin_lock_irq() - the interrupt can use spin_lock() A routine has to use spin_lock_irqsave if (and only if) process and irq call the routine concurrently. I do

Re: [linux-dvb] [BUG] changeset 9029 (http://linuxtv.org/hg/v4l-dvb/rev/aa3e5cc1d833)

2009-02-18 Thread Trent Piepho
On Wed, 18 Feb 2009, Steven Toth wrote: Trent Piepho wrote: On Tue, 17 Feb 2009, Steven Toth wrote: Trent Piepho wrote: On Mon, 16 Feb 2009, Steven Toth wrote: Fixing the demux... Would this require and extra buffer copy? probably, but it's a trade-off between the amount of spent

Re: Questions about VIDIOC_G_JPEGCOMP / VIDIOC_S_JPEGCOMP

2009-02-20 Thread Trent Piepho
On Fri, 20 Feb 2009, Jean-Francois Moine wrote: So, I propose to remove these ioctls, and to add two controls: one to set the JPEG quality (range 15..95 %) and the other to set a webcam quality which might be a boolean or any value depending on some associated webcam parameter. A control can

Re: Minimum kernel version supported by v4l-dvb

2009-02-21 Thread Trent Piepho
On Fri, 20 Feb 2009, Mauro Carvalho Chehab wrote: On Sat, 21 Feb 2009 02:12:53 +0100 Hans Verkuil hverk...@xs4all.nl wrote: I think that maybe we'll need some legacy-like support for bttv and cx88, since there are some boards that relies on the old i2c method to work. On those boards

Re: RFCv1: v4l-dvb development models old kernel support

2009-02-21 Thread Trent Piepho
On Sat, 21 Feb 2009, wk wrote: Hans Verkuil wrote: Comments? Hans As only beeing reader of this list.., why not simply reduce the work load by - reducing the number of supported kernel versions to five major versions? Currently 2.6.28 would mean down to 2.6.23, this would be

Re: Minimum kernel version supported by v4l-dvb

2009-02-21 Thread Trent Piepho
On Sat, 21 Feb 2009, Jean Delvare wrote: On Sat, 21 Feb 2009 04:06:53 -0800 (PST), Trent Piepho wrote: The new i2c driver interface also supports a -detect() method and a list of address_data to use it with. This is much more like the legacy model than using i2c_new_probed_device

Re: [RFC] How to pass camera Orientation to userspace

2009-02-22 Thread Trent Piepho
On Sun, 22 Feb 2009, Hans de Goede wrote: Yes that is what we are talking about, the camera having a gravity switch (usually nothing as advanced as a gyroscope). Also the bits we are talking about are in a struct which communicates information one way, from the camera to userspace, so there is

Re: [RFC] How to pass camera Orientation to userspace

2009-02-22 Thread Trent Piepho
On Sun, 22 Feb 2009, Hans de Goede wrote: Trent Piepho wrote: On Sun, 22 Feb 2009, Hans de Goede wrote: Yes that is what we are talking about, the camera having a gravity switch (usually nothing as advanced as a gyroscope). Also the bits we are talking about are in a struct which

Re: [RFC] How to pass camera Orientation to userspace

2009-02-22 Thread Trent Piepho
On Mon, 23 Feb 2009, Hans Verkuil wrote: On Sunday 22 February 2009 23:54:42 Hans de Goede wrote: Trent Piepho wrote: On Sun, 22 Feb 2009, Hans de Goede wrote: Yes that is what we are talking about, the camera having a gravity switch (usually nothing as advanced as a gyroscope). Also

Re: [RFC] How to pass camera Orientation to userspace

2009-02-22 Thread Trent Piepho
On Mon, 23 Feb 2009, Hans de Goede wrote: Trent Piepho wrote: On Sun, 22 Feb 2009, Hans de Goede wrote: Trent Piepho wrote: On Sun, 22 Feb 2009, Hans de Goede wrote: Yes that is what we are talking about, the camera having a gravity switch (usually nothing as advanced as a gyroscope

Re: POLL: for/against dropping support for kernels 2.6.22

2009-02-23 Thread Trent Piepho
On Mon, 23 Feb 2009, Jean Delvare wrote: There are lot's of discussions, but it can be hard sometimes to actually determine someone's opinion. So here is a quick poll, please reply either to the list or directly to me with your yes/no answer and (optional but welcome) a short explanation

Re: POLL: for/against dropping support for kernels 2.6.22

2009-02-23 Thread Trent Piepho
On Mon, 23 Feb 2009, David Ellingsworth wrote: On Sun, Feb 22, 2009 at 5:15 AM, Hans Verkuil hverk...@xs4all.nl wrote: Optional question: Why can't we drop support for all but the latest kernel? Why: As others have already pointed out, it is a waste of time for developers who

Re: [PULL] http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-zoran

2009-02-24 Thread Trent Piepho
On Sun, 22 Feb 2009, Hans Verkuil wrote: Hi Mauro, Please pull from http://www.linuxtv.org/hg/~hverkuil/v4l-dvb-zoran for the following: You might consider posting to the mjpeg users list. Maybe there are some people who used the playback feature more often. -- To unsubscribe from this

Re: [PULL] http://mercurial.intuxication.org/hg/v4l-dvb-commits

2009-02-26 Thread Trent Piepho
On Fri, 27 Feb 2009, Igor M. Liplianin wrote: 01/02: dm1105: not demuxing from interrupt context. http://mercurial.intuxication.org/hg/v4l-dvb-commits?cmd=changeset;node=6faf0753950b I'm not sure if you considered this, but the default work queue is multi-threaded with a kernel thread for each

  1   2   >