Re: [PATCH] [media] uvcvideo: Enable VIDIOC_CREATE_BUFS

2014-02-06 Thread Laurent Pinchart
Hi Hans, On Wednesday 05 February 2014 08:57:14 Hans Verkuil wrote: On 02/05/2014 12:04 AM, Sylwester Nawrocki wrote: On 02/03/2014 10:03 AM, Hans Verkuil wrote: On 02/02/2014 02:04 PM, Philipp Zabel wrote: On Sun, Feb 02, 2014 at 11:21:13AM +0100, Laurent Pinchart wrote: On Friday 31

Re: [PATCH] [media] uvcvideo: Enable VIDIOC_CREATE_BUFS

2014-02-05 Thread Hans Verkuil
On 02/05/14 08:57, Hans Verkuil wrote: On 02/05/2014 12:04 AM, Sylwester Nawrocki wrote: Hi, On 02/03/2014 10:03 AM, Hans Verkuil wrote: Hi Philipp, Laurent, On 02/02/2014 02:04 PM, Philipp Zabel wrote: On Sun, Feb 02, 2014 at 11:21:13AM +0100, Laurent Pinchart wrote: Hi Hans, On Friday

Re: [PATCH] [media] uvcvideo: Enable VIDIOC_CREATE_BUFS

2014-02-04 Thread Laurent Pinchart
Hi Hans, On Monday 03 February 2014 10:03:39 Hans Verkuil wrote: On 02/02/2014 02:04 PM, Philipp Zabel wrote: On Sun, Feb 02, 2014 at 11:21:13AM +0100, Laurent Pinchart wrote: On Friday 31 January 2014 09:43:00 Hans Verkuil wrote: I think you might want to add a check in uvc_queue_setup to

Re: [PATCH] [media] uvcvideo: Enable VIDIOC_CREATE_BUFS

2014-02-04 Thread Sylwester Nawrocki
Hi, On 02/03/2014 10:03 AM, Hans Verkuil wrote: Hi Philipp, Laurent, On 02/02/2014 02:04 PM, Philipp Zabel wrote: On Sun, Feb 02, 2014 at 11:21:13AM +0100, Laurent Pinchart wrote: Hi Hans, On Friday 31 January 2014 09:43:00 Hans Verkuil wrote: I think you might want to add a check in

Re: [PATCH] [media] uvcvideo: Enable VIDIOC_CREATE_BUFS

2014-02-04 Thread Hans Verkuil
On 02/05/2014 12:04 AM, Sylwester Nawrocki wrote: Hi, On 02/03/2014 10:03 AM, Hans Verkuil wrote: Hi Philipp, Laurent, On 02/02/2014 02:04 PM, Philipp Zabel wrote: On Sun, Feb 02, 2014 at 11:21:13AM +0100, Laurent Pinchart wrote: Hi Hans, On Friday 31 January 2014 09:43:00 Hans Verkuil

Re: [PATCH] [media] uvcvideo: Enable VIDIOC_CREATE_BUFS

2014-02-03 Thread Hans Verkuil
Hi Philipp, Laurent, On 02/02/2014 02:04 PM, Philipp Zabel wrote: On Sun, Feb 02, 2014 at 11:21:13AM +0100, Laurent Pinchart wrote: Hi Hans, On Friday 31 January 2014 09:43:00 Hans Verkuil wrote: I think you might want to add a check in uvc_queue_setup to verify the fmt that create_bufs

Re: [PATCH] [media] uvcvideo: Enable VIDIOC_CREATE_BUFS

2014-02-02 Thread Laurent Pinchart
Hi Hans, On Friday 31 January 2014 09:43:00 Hans Verkuil wrote: I think you might want to add a check in uvc_queue_setup to verify the fmt that create_bufs passes. The spec says that: Unsupported formats will result in an error. In this case I guess that the format basically should match the

Re: [PATCH] [media] uvcvideo: Enable VIDIOC_CREATE_BUFS

2014-02-02 Thread Philipp Zabel
On Sun, Feb 02, 2014 at 11:21:13AM +0100, Laurent Pinchart wrote: Hi Hans, On Friday 31 January 2014 09:43:00 Hans Verkuil wrote: I think you might want to add a check in uvc_queue_setup to verify the fmt that create_bufs passes. The spec says that: Unsupported formats will result in an

Re: [PATCH] [media] uvcvideo: Enable VIDIOC_CREATE_BUFS

2014-01-31 Thread Hans Verkuil
I think you might want to add a check in uvc_queue_setup to verify the fmt that create_bufs passes. The spec says that: Unsupported formats will result in an error. In this case I guess that the format basically should match the current selected format. I'm unhappy with the current

Re: [PATCH] [media] uvcvideo: Enable VIDIOC_CREATE_BUFS

2014-01-30 Thread Laurent Pinchart
Hi Philipp, Thank you for the patch. On Wednesday 29 January 2014 17:13:52 Philipp Zabel wrote: This patch enables the ioctl to create additional buffers on the videobuf2 capture queue. Signed-off-by: Philipp Zabel p.za...@pengutronix.de This looks good to me. I've applied the patch to my

[PATCH] [media] uvcvideo: Enable VIDIOC_CREATE_BUFS

2014-01-29 Thread Philipp Zabel
This patch enables the ioctl to create additional buffers on the videobuf2 capture queue. Signed-off-by: Philipp Zabel p.za...@pengutronix.de --- drivers/media/usb/uvc/uvc_queue.c | 11 +++ drivers/media/usb/uvc/uvc_v4l2.c | 10 ++ drivers/media/usb/uvc/uvcvideo.h | 2 ++ 3