Re: [PATCH] cx25840: Fix composite detection.

2010-01-30 Thread Andy Walls
On Sun, 2010-01-10 at 09:31 +0900, Kusanagi Kouichi wrote: > If CX25840_VIN1_CH1 and the like is used, input is not detected as composite. > > Signed-off-by: Kusanagi Kouichi This patch is fine for fixing the identified problem. Thanks. Reviewed-by: Andy Walls Acked-by: Andy Walls Note: I h

[PATCH] cx25840: Fix composite detection.

2010-01-21 Thread Kusanagi Kouichi
If CX25840_VIN1_CH1 and the like is used, input is not detected as composite. Their value is 0x80XX and CX25840_COMPONENT_ON is 0x8200. So 739 else if ((vid_input & CX25840_COMPONENT_ON) == 0) this condition never be true. Signed-off-by: Kusanagi Kouichi --- drivers

[PATCH] cx25840: Fix composite detection.

2010-01-09 Thread Kusanagi Kouichi
If CX25840_VIN1_CH1 and the like is used, input is not detected as composite. Signed-off-by: Kusanagi Kouichi --- drivers/media/video/cx25840/cx25840-core.c |6 ++ 1 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/media/video/cx25840/cx25840-core.c b/drivers/media/v