Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static

2016-09-25 Thread Gustavo Padovan
Hi Baoyou, 2016-09-22 Greg Kroah-Hartman : > On Tue, Sep 20, 2016 at 06:23:33PM +0530, Sumit Semwal wrote: > > Hi Baoyou, > > > > On 20 September 2016 at 16:43, Gustavo Padovan wrote: > > > 2016-09-18 Baoyou Xie : > > > >

Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static

2016-09-24 Thread Arnd Bergmann
On Saturday, September 24, 2016 12:33:46 PM CEST Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for > 'sync_timeline_create' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which

[PATCH] dma-buf/sw_sync: mark sync_timeline_create() static

2016-09-23 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. So this

Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static

2016-09-22 Thread Greg Kroah-Hartman
On Tue, Sep 20, 2016 at 06:23:33PM +0530, Sumit Semwal wrote: > Hi Baoyou, > > On 20 September 2016 at 16:43, Gustavo Padovan wrote: > > 2016-09-18 Baoyou Xie : > > > >> We get 1 warning when building kernel with W=1: > >>

Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static

2016-09-20 Thread Sumit Semwal
Hi Baoyou, On 20 September 2016 at 16:43, Gustavo Padovan wrote: > 2016-09-18 Baoyou Xie : > >> We get 1 warning when building kernel with W=1: >> drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for >> 'sync_timeline_create'

Re: [PATCH] dma-buf/sw_sync: mark sync_timeline_create() static

2016-09-20 Thread Gustavo Padovan
2016-09-18 Baoyou Xie : > We get 1 warning when building kernel with W=1: > drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for > 'sync_timeline_create' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it is > declared

[PATCH] dma-buf/sw_sync: mark sync_timeline_create() static

2016-09-18 Thread Baoyou Xie
We get 1 warning when building kernel with W=1: drivers/dma-buf/sw_sync.c:87:23: warning: no previous prototype for 'sync_timeline_create' [-Wmissing-prototypes] In fact, this function is only used in the file in which it is declared and don't need a declaration, but can be made static. So this