Re: [PATCH] em28xx: Remove useless runtime-private_data usage

2012-07-06 Thread Ezequiel Garcia
Mauro, On Thu, Jul 5, 2012 at 2:22 PM, Ezequiel Garcia Are you sure that this can be removed? I think this is used internally by the alsa API, but maybe something has changed and this is not required anymore. Yes, I'm sure. This should be: I'm almost sure :-) Anyway, probably the patch

Re: [PATCH] em28xx: Remove useless runtime-private_data usage

2012-07-06 Thread Mauro Carvalho Chehab
Em 06-07-2012 11:33, Ezequiel Garcia escreveu: Mauro, On Thu, Jul 5, 2012 at 2:22 PM, Ezequiel Garcia Are you sure that this can be removed? I think this is used internally by the alsa API, but maybe something has changed and this is not required anymore. Yes, I'm sure. This should

Re: [PATCH] em28xx: Remove useless runtime-private_data usage

2012-07-06 Thread Ezequiel Garcia
On Fri, Jul 6, 2012 at 12:12 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: Em 06-07-2012 11:33, Ezequiel Garcia escreveu: Mauro, On Thu, Jul 5, 2012 at 2:22 PM, Ezequiel Garcia Are you sure that this can be removed? I think this is used internally by the alsa API, but maybe something

Re: [PATCH] em28xx: Remove useless runtime-private_data usage

2012-07-05 Thread Mauro Carvalho Chehab
Em 12-06-2012 10:53, Ezequiel Garcia escreveu: Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/video/em28xx/em28xx-audio.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/em28xx/em28xx-audio.c

Re: [PATCH] em28xx: Remove useless runtime-private_data usage

2012-07-05 Thread Ezequiel Garcia
Hi Mauro, On Thu, Jul 5, 2012 at 1:57 PM, Mauro Carvalho Chehab mche...@redhat.com wrote: snd_pcm_hw_constraint_integer(runtime, SNDRV_PCM_HW_PARAM_PERIODS); dev-adev.capture_pcm_substream = substream; - runtime-private_data = dev; Are you sure that this can be removed? I

[PATCH] em28xx: Remove useless runtime-private_data usage

2012-06-12 Thread Ezequiel Garcia
Signed-off-by: Ezequiel Garcia elezegar...@gmail.com --- drivers/media/video/em28xx/em28xx-audio.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/em28xx/em28xx-audio.c b/drivers/media/video/em28xx/em28xx-audio.c index d7e2a3d..2fcddae 100644 ---