Re: [PATCH] media: soc_camera: ov772x: correct setting of banding filter

2018-06-11 Thread jacopo mondi
Hi Mita-san, On Mon, Jun 11, 2018 at 12:42:26AM +0900, Akinobu Mita wrote: > The banding filter ON/OFF is controlled via bit 5 of COM8 register. It > is attempted to be enabled in ov772x_set_params() by the following line. > > ret = ov772x_mask_set(client, COM8, BNDF_ON_OFF, 1); > > But

[PATCH] media: soc_camera: ov772x: correct setting of banding filter

2018-06-10 Thread Akinobu Mita
The banding filter ON/OFF is controlled via bit 5 of COM8 register. It is attempted to be enabled in ov772x_set_params() by the following line. ret = ov772x_mask_set(client, COM8, BNDF_ON_OFF, 1); But this unexpectedly results disabling the banding filter, because the mask and set bits