Re: [PATCH 08/12] media: ov5640: Adjust the clock based on the expected rate

2018-03-15 Thread Sakari Ailus
On Tue, Mar 13, 2018 at 01:49:37PM +0100, Maxime Ripard wrote: > Hi Sakari, > > On Fri, Mar 09, 2018 at 01:16:24PM +0200, Sakari Ailus wrote: > > > + * > > > + * +--+ > > > + * | Oscillator | > > > > I wonder if this should be simply called external clock, that's what the > >

Re: [PATCH 08/12] media: ov5640: Adjust the clock based on the expected rate

2018-03-13 Thread Maxime Ripard
Hi Sakari, On Fri, Mar 09, 2018 at 01:16:24PM +0200, Sakari Ailus wrote: > > + * > > + * +--+ > > + * | Oscillator | > > I wonder if this should be simply called external clock, that's what the > sensor uses. Ack > > + * +--+---+ > > + * | > > + *

Re: [PATCH 08/12] media: ov5640: Adjust the clock based on the expected rate

2018-03-09 Thread Sakari Ailus
Hi Maxime, On Fri, Mar 02, 2018 at 03:34:56PM +0100, Maxime Ripard wrote: ... > @@ -902,6 +920,246 @@ static int ov5640_mod_reg(struct ov5640_dev *sensor, > u16 reg, > return ov5640_write_reg(sensor, reg, val); > } > > +/* > + * After spending way too much time trying the various

[PATCH 08/12] media: ov5640: Adjust the clock based on the expected rate

2018-03-02 Thread Maxime Ripard
The clock structure for the PCLK is quite obscure in the documentation, and was hardcoded through the bytes array of each and every mode. This is troublesome, since we cannot adjust it at runtime based on other parameters (such as the number of bytes per pixel), and we can't support either