Re: [PATCH 17/34] [media] DaVinci-VPFE-Capture: Improve another size determination in vpfe_enum_input()
On 03/11/16 22:05, SF Markus Elfring wrote: @@ -1091,7 +1091,7 @@ static int vpfe_enum_input(struct file *file, void *priv, return -EINVAL; } sdinfo = &vpfe_dev->cfg->sub_devs[subdev]; -memcpy(inp, &sdinfo->inputs[index], sizeof(struct v4l2_input)); +memcpy(inp, &sdinfo->inputs[index], sizeof(*inp)); If I am not mistaken this can be written as: *inp = sdinfo->inputs[index]; Much better. At which position would you like to integrate a second approach for such a change from this patch series? * Do you expect me to send a "V2" for the whole series? No, just for the patches I commented upon. * Will an update step be appropriate if I would rebase it on other recently accepted suggestions? You can base it on https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=for-v4.10a That branch has all your other patches of this series merged and is part of a pull request I posted yesterday. Hans Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 17/34] [media] DaVinci-VPFE-Capture: Improve another size determination in vpfe_enum_input()
>> @@ -1091,7 +1091,7 @@ static int vpfe_enum_input(struct file *file, void >> *priv, >> return -EINVAL; >> } >> sdinfo = &vpfe_dev->cfg->sub_devs[subdev]; >> -memcpy(inp, &sdinfo->inputs[index], sizeof(struct v4l2_input)); >> +memcpy(inp, &sdinfo->inputs[index], sizeof(*inp)); > > If I am not mistaken this can be written as: > > *inp = sdinfo->inputs[index]; > > Much better. At which position would you like to integrate a second approach for such a change from this patch series? * Do you expect me to send a "V2" for the whole series? * Will an update step be appropriate if I would rebase it on other recently accepted suggestions? Regards, Markus -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Re: [PATCH 17/34] [media] DaVinci-VPFE-Capture: Improve another size determination in vpfe_enum_input()
On 12/10/16 16:55, SF Markus Elfring wrote: From: Markus Elfring Date: Wed, 12 Oct 2016 10:33:42 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer. Signed-off-by: Markus Elfring --- drivers/media/platform/davinci/vpfe_capture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/davinci/vpfe_capture.c b/drivers/media/platform/davinci/vpfe_capture.c index 8314c39..87ee35d 100644 --- a/drivers/media/platform/davinci/vpfe_capture.c +++ b/drivers/media/platform/davinci/vpfe_capture.c @@ -1091,7 +1091,7 @@ static int vpfe_enum_input(struct file *file, void *priv, return -EINVAL; } sdinfo = &vpfe_dev->cfg->sub_devs[subdev]; - memcpy(inp, &sdinfo->inputs[index], sizeof(struct v4l2_input)); + memcpy(inp, &sdinfo->inputs[index], sizeof(*inp)); If I am not mistaken this can be written as: *inp = sdinfo->inputs[index]; Much better. Regards, Hans return 0; } -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
[PATCH 17/34] [media] DaVinci-VPFE-Capture: Improve another size determination in vpfe_enum_input()
From: Markus Elfring Date: Wed, 12 Oct 2016 10:33:42 +0200 Replace the specification of a data structure by a pointer dereference as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer. Signed-off-by: Markus Elfring --- drivers/media/platform/davinci/vpfe_capture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/davinci/vpfe_capture.c b/drivers/media/platform/davinci/vpfe_capture.c index 8314c39..87ee35d 100644 --- a/drivers/media/platform/davinci/vpfe_capture.c +++ b/drivers/media/platform/davinci/vpfe_capture.c @@ -1091,7 +1091,7 @@ static int vpfe_enum_input(struct file *file, void *priv, return -EINVAL; } sdinfo = &vpfe_dev->cfg->sub_devs[subdev]; - memcpy(inp, &sdinfo->inputs[index], sizeof(struct v4l2_input)); + memcpy(inp, &sdinfo->inputs[index], sizeof(*inp)); return 0; } -- 2.10.1 -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
