Re: [PATCH 3/3] media: imx-pxp: add i.MX Pixel Pipeline driver

2018-09-04 Thread Philipp Zabel
Hi Jacopo, thank you for the review! On Tue, 2018-09-04 at 10:04 +0200, jacopo mondi wrote: > Hi Philipp, > > On Fri, Aug 10, 2018 at 05:18:22PM +0200, Philipp Zabel wrote: [...] > > +static struct pxp_fmt formats[] = { > > + { > > + .fourcc = V4L2_PIX_FMT_XBGR32, > > + .de

Re: [PATCH 3/3] media: imx-pxp: add i.MX Pixel Pipeline driver

2018-09-04 Thread jacopo mondi
Hi Philipp, On Fri, Aug 10, 2018 at 05:18:22PM +0200, Philipp Zabel wrote: > Add a V4L2 mem-to-mem scaler/CSC driver for the Pixel Pipeline (PXP) > version found on i.MX6ULL SoCs. A similar variant is used on i.MX7D. > > Since this driver only uses the legacy pipeline, it should be reasonably > ea

Re: [PATCH 3/3] media: imx-pxp: add i.MX Pixel Pipeline driver

2018-09-03 Thread Philipp Zabel
Hi Hans, On Mon, 2018-09-03 at 14:55 +0200, Hans Verkuil wrote: > Hi Philipp, > > Apologies for the delay, but the Request API took most of my time. Understandable. Also, I expect I'll profit from that work when adding CODA960 JPEG support. So I have no reason to complain. > But I finally got a

Re: [PATCH 3/3] media: imx-pxp: add i.MX Pixel Pipeline driver

2018-09-03 Thread Hans Verkuil
Hi Philipp, Apologies for the delay, but the Request API took most of my time. But I finally got around to it: On 08/10/2018 05:18 PM, Philipp Zabel wrote: > Add a V4L2 mem-to-mem scaler/CSC driver for the Pixel Pipeline (PXP) > version found on i.MX6ULL SoCs. A similar variant is used on i.MX7D

Re: [PATCH 3/3] media: imx-pxp: add i.MX Pixel Pipeline driver

2018-08-10 Thread Philipp Zabel
On Fri, 2018-08-10 at 17:18 +0200, Philipp Zabel wrote: > Add a V4L2 mem-to-mem scaler/CSC driver for the Pixel Pipeline (PXP) > version found on i.MX6ULL SoCs. A similar variant is used on i.MX7D. > > Since this driver only uses the legacy pipeline, it should be reasonably > easy to extend it to

[PATCH 3/3] media: imx-pxp: add i.MX Pixel Pipeline driver

2018-08-10 Thread Philipp Zabel
Add a V4L2 mem-to-mem scaler/CSC driver for the Pixel Pipeline (PXP) version found on i.MX6ULL SoCs. A similar variant is used on i.MX7D. Since this driver only uses the legacy pipeline, it should be reasonably easy to extend it to work with the older PXP versions found on i.MX6UL, i.MX6SX, i.MX6S