Re: [PATCH 3/3] media: replace strncpy() by strscpy()

2018-09-12 Thread Hans Verkuil
On 09/10/2018 02:19 PM, Mauro Carvalho Chehab wrote: > The strncpy() function is being deprecated upstream. Replace > it by the safer strscpy(). > > Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/dvb-frontends/as102_fe.c | 2 +- > drivers/media/dvb-frontends/dib7000p.c

Re: [PATCH 3/3] media: replace strncpy() by strscpy()

2018-09-10 Thread Kees Cook
On Mon, Sep 10, 2018 at 11:34 AM, Mauro Carvalho Chehab wrote: > Em Mon, 10 Sep 2018 09:18:05 -0700 > Kees Cook escreveu: > >> On Mon, Sep 10, 2018 at 5:19 AM, Mauro Carvalho Chehab >> wrote: >> > The strncpy() function is being deprecated upstream. Replace >> > it by the safer strscpy(). >> >>

Re: [PATCH 3/3] media: replace strncpy() by strscpy()

2018-09-10 Thread Mauro Carvalho Chehab
Em Mon, 10 Sep 2018 09:18:05 -0700 Kees Cook escreveu: > On Mon, Sep 10, 2018 at 5:19 AM, Mauro Carvalho Chehab > wrote: > > The strncpy() function is being deprecated upstream. Replace > > it by the safer strscpy(). > > This one I'm quite concerned about. This could lead to kernel memory >

Re: [PATCH 3/3] media: replace strncpy() by strscpy()

2018-09-10 Thread Kees Cook
On Mon, Sep 10, 2018 at 5:19 AM, Mauro Carvalho Chehab wrote: > The strncpy() function is being deprecated upstream. Replace > it by the safer strscpy(). This one I'm quite concerned about. This could lead to kernel memory exposures if any of the callers depend on strncpy()'s trailing

[PATCH 3/3] media: replace strncpy() by strscpy()

2018-09-10 Thread Mauro Carvalho Chehab
The strncpy() function is being deprecated upstream. Replace it by the safer strscpy(). Signed-off-by: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/as102_fe.c | 2 +- drivers/media/dvb-frontends/dib7000p.c | 3 ++- drivers/media/dvb-frontends/dib8000.c