Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Niklas, On Monday, 16 April 2018 00:26:06 EEST Niklas Söderlund wrote: > Hi Laurent, > > Thanks for your feedback. > > I have addressed all your comment's but one for the next version. Please > indicate if you are fine with this and I can still keep your review tag > > :-) > > On

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Jacopo, On 2018-04-16 01:16:35 +0200, Niklas Söderlund wrote: [snip] > > > + > > > + /* Set frequency range if we have it */ > > > + if (priv->info->csi0clkfreqrange) > > > + rcar_csi2_write(priv, CSI0CLKFCPR_REG, > > > +

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Niklas, On Mon, Apr 16, 2018 at 01:16:35AM +0200, Niklas Söderlund wrote: > Hi Jacopo, > > Thanks for your feedback. > > Comments I have snipped out from this reply are addressed, thanks for > bringing them to my attention! > > On 2018-04-05 11:10:01 +0200, Jacopo Mondi wrote: > > [snip] > > >

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Niklas, On Sun, Apr 15, 2018 at 10:47:37PM +0200, Niklas Söderlund wrote: > Hi Sakari, > > Thanks for your feedback. > > On 2018-04-04 23:13:57 +0300, Sakari Ailus wrote: > > [snip] > > > > > + pm_runtime_enable(>dev); > > > > > > Is CONFIG_PM mandatory on Renesas SoCs? If not, you

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Jacopo, Thanks for your feedback. Comments I have snipped out from this reply are addressed, thanks for bringing them to my attention! On 2018-04-05 11:10:01 +0200, Jacopo Mondi wrote: [snip] > > +static int rcar_csi2_wait_phy_start(struct rcar_csi2 *priv) > > +{ > > + int timeout; > >

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Laurent, Thanks for your feedback. I have addressed all your comment's but one for the next version. Please indicate if you are fine with this and I can still keep your review tag :-) On 2018-04-04 18:15:16 +0300, Laurent Pinchart wrote: [snip] > > +static int rcar_csi2_start(struct

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Sakari, Thanks for your feedback. On 2018-04-04 23:13:57 +0300, Sakari Ailus wrote: [snip] > > > + pm_runtime_enable(>dev); > > > > Is CONFIG_PM mandatory on Renesas SoCs? If not, you end up with the > > device uninitialised at probe, and pm_runtime_get_sync will not > > initialise it

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Geert and Laurent, Thanks for the feedback. On 2018-04-05 11:26:45 +0300, Laurent Pinchart wrote: [snip] > > Alternatively, you could check for a valid number of lanes, and use > > knowledge about the internal lane bits: > > > > phycnt = PHYCNT_ENABLECLK; > > phycnt |= (1 <<

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Maxime, Thanks for your feedback. On 2018-03-29 13:30:39 +0200, Maxime Ripard wrote: > Hi Niklas, > > On Tue, Feb 13, 2018 at 12:01:32AM +0100, Niklas Söderlund wrote: > > + switch (priv->lanes) { > > + case 1: > > + phycnt = PHYCNT_ENABLECLK | PHYCNT_ENABLE_0; > > +

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Laurent, Thanks for your feedback. On 2018-04-04 18:25:23 +0300, Laurent Pinchart wrote: [snip] > > > diff --git a/drivers/media/platform/rcar-vin/rcar-csi2.c > > > b/drivers/media/platform/rcar-vin/rcar-csi2.c new file mode 100644 > > > index ..c0c2a763151bc928 > > > ---

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Kieran, Thanks for your feedback. On 2018-03-13 23:23:49 +0100, Kieran Bingham wrote: > Hi Niklas > > Thank you for this patch ... > I know it has been a lot of work getting this and the VIN together! > > On 13/02/18 00:01, Niklas Söderlund wrote: > > A V4L2 driver for Renesas R-Car MIPI

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

A few corrections, On Thu, Apr 05, 2018 at 11:10:01AM +0200, jacopo mondi wrote: > Hi Niklas, > thanks for the VIN and CSI-2 effort! > > On Tue, Feb 13, 2018 at 12:01:32AM +0100, Niklas Söderlund wrote: > > A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver > > supports the

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Niklas, thanks for the VIN and CSI-2 effort! On Tue, Feb 13, 2018 at 12:01:32AM +0100, Niklas Söderlund wrote: > A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver > supports the R-Car Gen3 SoCs where separate CSI-2 hardware blocks are > connected between the video sources

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Geert, On Thursday, 5 April 2018 10:33:55 EEST Geert Uytterhoeven wrote: > On Wed, Apr 4, 2018 at 5:26 PM, Laurent Pinchart wrote: > > On Thursday, 29 March 2018 14:30:39 EEST Maxime Ripard wrote: > >> On Tue, Feb 13, 2018 at 12:01:32AM +0100, Niklas Söderlund wrote: > >> > + switch

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

On Wed, Apr 4, 2018 at 5:26 PM, Laurent Pinchart wrote: > On Thursday, 29 March 2018 14:30:39 EEST Maxime Ripard wrote: >> On Tue, Feb 13, 2018 at 12:01:32AM +0100, Niklas Söderlund wrote: >> > + switch (priv->lanes) { >> > + case 1: >> > + phycnt

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Maxime and Niklas, On Thu, Mar 29, 2018 at 01:30:39PM +0200, Maxime Ripard wrote: > Hi Niklas, > > On Tue, Feb 13, 2018 at 12:01:32AM +0100, Niklas Söderlund wrote: > > + switch (priv->lanes) { > > + case 1: > > + phycnt = PHYCNT_ENABLECLK | PHYCNT_ENABLE_0; > > +

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Maxime, On Thursday, 29 March 2018 14:30:39 EEST Maxime Ripard wrote: > On Tue, Feb 13, 2018 at 12:01:32AM +0100, Niklas Söderlund wrote: > > + switch (priv->lanes) { > > + case 1: > > + phycnt = PHYCNT_ENABLECLK | PHYCNT_ENABLE_0; > > + break; > > + case 2: > > +

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hello, On Wednesday, 14 March 2018 00:23:49 EEST Kieran Bingham wrote: > Hi Niklas > > Thank you for this patch ... > I know it has been a lot of work getting this and the VIN together! > > On 13/02/18 00:01, Niklas Söderlund wrote: > > A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Niklas, Thank you for the patch. On Tuesday, 13 February 2018 01:01:32 EEST Niklas Söderlund wrote: > A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver > supports the R-Car Gen3 SoCs where separate CSI-2 hardware blocks are > connected between the video sources and the video

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Niklas, On Tue, Feb 13, 2018 at 12:01:32AM +0100, Niklas Söderlund wrote: > + switch (priv->lanes) { > + case 1: > + phycnt = PHYCNT_ENABLECLK | PHYCNT_ENABLE_0; > + break; > + case 2: > + phycnt = PHYCNT_ENABLECLK | PHYCNT_ENABLE_1 |

Re: [PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

Hi Niklas Thank you for this patch ... I know it has been a lot of work getting this and the VIN together! On 13/02/18 00:01, Niklas Söderlund wrote: > A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver > supports the R-Car Gen3 SoCs where separate CSI-2 hardware blocks are >

[PATCH v13 2/2] rcar-csi2: add Renesas R-Car MIPI CSI-2 receiver driver

A V4L2 driver for Renesas R-Car MIPI CSI-2 receiver. The driver supports the R-Car Gen3 SoCs where separate CSI-2 hardware blocks are connected between the video sources and the video grabbers (VIN). Driver is based on a prototype by Koji Matsuoka in the Renesas BSP. Signed-off-by: Niklas