Re: [PATCH v2 13/17] smiapp: Improve debug messages from frame layout reading

[Sebastian Reichel]

Hi,

On Thu, Sep 15, 2016 at 02:22:27PM +0300, Sakari Ailus wrote:
> Provide more debugging information on reading the frame layout.
> 
> [...]
>
> @@ -130,7 +127,7 @@ static int smiapp_read_frame_fmt(struct smiapp_sensor 
> *sensor)
>   pixels = desc & SMIAPP_FRAME_FORMAT_DESC_4_PIXELS_MASK;
>   } else {
>   dev_dbg(&client->dev,
> - "invalid frame format model type %d\n",
> + "0x8.8x invalid frame format model type %d\n",

0x8.8x doesn't look very interesting ;)

Apart from the '%' the actual argument is also missing.

> [...]

Once that is fixed:

Reviewed-By: Sebastian Reichel 

-- Sebastian


signature.asc
Description: PGP signature

[PATCH v2 13/17] smiapp: Improve debug messages from frame layout reading

[Sakari Ailus]

Provide more debugging information on reading the frame layout.

Signed-off-by: Sakari Ailus 
---
 drivers/media/i2c/smiapp/smiapp-core.c | 21 +
 1 file changed, 9 insertions(+), 12 deletions(-)

diff --git a/drivers/media/i2c/smiapp/smiapp-core.c 
b/drivers/media/i2c/smiapp/smiapp-core.c
index f09665d..8b042e2 100644
--- a/drivers/media/i2c/smiapp/smiapp-core.c
+++ b/drivers/media/i2c/smiapp/smiapp-core.c
@@ -100,12 +100,11 @@ static int smiapp_read_frame_fmt(struct smiapp_sensor 
*sensor)
u32 pixels;
char *which;
char *what;
+   u32 reg;
 
if (fmt_model_type == SMIAPP_FRAME_FORMAT_MODEL_TYPE_2BYTE) {
-   rval = smiapp_read(
-   sensor,
-   SMIAPP_REG_U16_FRAME_FORMAT_DESCRIPTOR_2(i),
-   &desc);
+   reg = SMIAPP_REG_U16_FRAME_FORMAT_DESCRIPTOR_2(i);
+   rval = smiapp_read(sensor, reg, &desc);
if (rval)
return rval;
 
@@ -116,10 +115,8 @@ static int smiapp_read_frame_fmt(struct smiapp_sensor 
*sensor)
pixels = desc & SMIAPP_FRAME_FORMAT_DESC_2_PIXELS_MASK;
} else if (fmt_model_type
   == SMIAPP_FRAME_FORMAT_MODEL_TYPE_4BYTE) {
-   rval = smiapp_read(
-   sensor,
-   SMIAPP_REG_U32_FRAME_FORMAT_DESCRIPTOR_4(i),
-   &desc);
+   reg = SMIAPP_REG_U32_FRAME_FORMAT_DESCRIPTOR_4(i);
+   rval = smiapp_read(sensor, reg, &desc);
if (rval)
return rval;
 
@@ -130,7 +127,7 @@ static int smiapp_read_frame_fmt(struct smiapp_sensor 
*sensor)
pixels = desc & SMIAPP_FRAME_FORMAT_DESC_4_PIXELS_MASK;
} else {
dev_dbg(&client->dev,
-   "invalid frame format model type %d\n",
+   "0x8.8x invalid frame format model type %d\n",
fmt_model_type);
return -EINVAL;
}
@@ -158,12 +155,12 @@ static int smiapp_read_frame_fmt(struct smiapp_sensor 
*sensor)
break;
default:
what = "invalid";
-   dev_dbg(&client->dev, "pixelcode %d\n", pixelcode);
break;
}
 
-   dev_dbg(&client->dev, "%s pixels: %d %s\n",
-   what, pixels, which);
+   dev_dbg(&client->dev,
+   "0x%8.8x %s pixels: %d %s (pixelcode %u)\n", reg,
+   what, pixels, which, pixelcode);
 
if (i < ncol_desc) {
if (pixelcode ==
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html